Repository navigation
test(assets): enabled API parity - #16266
christian-byrne wants to merge 10 commits into
Conversation
|
Warning Review limit reachedNext included review available in 6 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
🎭 Playwright: ✅ 1917 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 558 kB (baseline 558 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 35 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 297 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-03T21:24:33.375Z",
"gitSha": "6d7d6467660b2eec9fa29ecefc4a6cd97da4ff61",
"branch": "test/assets-api-parity",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2073.1609999999705,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.238000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.3219999999999,
"heapDeltaBytes": -323868,
"heapUsedBytes": 70133864,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.559,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2028.6230000000387,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.655000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.179,
"heapDeltaBytes": -2989316,
"heapUsedBytes": 66965344,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.061,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2017.2629999999572,
"styleRecalcs": 83,
"styleRecalcDurationMs": 47.321000000000005,
"layouts": 14,
"layoutDurationMs": 5.308999999999999,
"taskDurationMs": 1013.612,
"heapDeltaBytes": -7393948,
"heapUsedBytes": 62981296,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 171.981,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1884.6229999999764,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.193,
"layouts": 14,
"layoutDurationMs": 4.776,
"taskDurationMs": 899.2260000000001,
"heapDeltaBytes": -11897588,
"heapUsedBytes": 59024024,
"domNodes": -285,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 154.769,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.1700000000014,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.273,
"layouts": 6,
"layoutDurationMs": 1.327,
"taskDurationMs": 366.808,
"heapDeltaBytes": 5056472,
"heapUsedBytes": 75754436,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.504000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.6469999999144,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.432,
"layouts": 6,
"layoutDurationMs": 1.081,
"taskDurationMs": 368.72499999999997,
"heapDeltaBytes": 5128624,
"heapUsedBytes": 75588928,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.155000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 708.789999999965,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.117999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.673,
"heapDeltaBytes": -7470184,
"heapUsedBytes": 63078208,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 160.463,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 706.2800000000493,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.747,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.29599999999994,
"heapDeltaBytes": -7535012,
"heapUsedBytes": 62944988,
"domNodes": 14,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 155.445,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2050.8029999999735,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.572999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 658.1159999999999,
"heapDeltaBytes": -14739144,
"heapUsedBytes": 86664268,
"domNodes": -266,
"jsHeapTotalBytes": 720896,
"scriptDurationMs": 36.998000000000005,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.7070000000258,
"styleRecalcs": 4,
"styleRecalcDurationMs": 6.487,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.5129999999999,
"heapDeltaBytes": 10600788,
"heapUsedBytes": 86625532,
"domNodes": -272,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 33.885,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2308.513000000005,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.303000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1611.9219999999998,
"heapDeltaBytes": 23499924,
"heapUsedBytes": 89123428,
"domNodes": -275,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 767.085,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2222.3249999999553,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.754999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1636.4489999999998,
"heapDeltaBytes": 9224040,
"heapUsedBytes": 85484884,
"domNodes": -276,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 769.8999999999999,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3582.5439999999844,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.161000000000001,
"layouts": 60,
"layoutDurationMs": 13.652999999999999,
"taskDurationMs": 1738.208,
"heapDeltaBytes": 9447112,
"heapUsedBytes": 76209312,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 767.163,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3612.0750000000044,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.236999999999997,
"layouts": 60,
"layoutDurationMs": 13.709,
"taskDurationMs": 1750.389,
"heapDeltaBytes": 11747624,
"heapUsedBytes": 79487968,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 774.284,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3121.3349999999878,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.438999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1978.3840000000002,
"heapDeltaBytes": 23978324,
"heapUsedBytes": 91424092,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 952.1139999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3087.49899999998,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.503999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1924.485,
"heapDeltaBytes": 25771200,
"heapUsedBytes": 92922764,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 930.263,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2020.986999999991,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.165,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.9550000000002,
"heapDeltaBytes": 22254252,
"heapUsedBytes": 88385016,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.017,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2028.413999999998,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.2200000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.923,
"heapDeltaBytes": 22362496,
"heapUsedBytes": 87860236,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.733000000000004,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.8130000000074,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.953999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.68899999999996,
"heapDeltaBytes": 15128600,
"heapUsedBytes": 87816712,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 145.153,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.9800000000878,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.277999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.96199999999993,
"heapDeltaBytes": 15119692,
"heapUsedBytes": 88029620,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 152.858,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2025.4450000000475,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.3210000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.443,
"heapDeltaBytes": -141752,
"heapUsedBytes": 72552000,
"domNodes": -298,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.719000000000001,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2023.1539999999768,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.255000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.357,
"heapDeltaBytes": -9291924,
"heapUsedBytes": 63468632,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.743999999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1752.3980000000279,
"styleRecalcs": 77,
"styleRecalcDurationMs": 42.077000000000005,
"layouts": 18,
"layoutDurationMs": 6.077999999999999,
"taskDurationMs": 873.8480000000001,
"heapDeltaBytes": -15883504,
"heapUsedBytes": 56981880,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 111.146,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.7690000000157,
"styleRecalcs": 79,
"styleRecalcDurationMs": 39.106,
"layouts": 18,
"layoutDurationMs": 5.9670000000000005,
"taskDurationMs": 860.223,
"heapDeltaBytes": 2441276,
"heapUsedBytes": 75461240,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 109.86999999999999,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.2860000000273,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.38700000000001,
"layouts": 15,
"layoutDurationMs": 14.977999999999998,
"taskDurationMs": 945.2129999999999,
"heapDeltaBytes": 21152280,
"heapUsedBytes": 109416336,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.671999999999997,
"eventListeners": 2385,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8413.358000000017,
"styleRecalcs": 248,
"styleRecalcDurationMs": 41.565,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5825.9400000000005,
"heapDeltaBytes": -12860344,
"heapUsedBytes": 88952640,
"domNodes": -265,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 2591.323,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8393.94500000003,
"styleRecalcs": 248,
"styleRecalcDurationMs": 41.071999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5866.304,
"heapDeltaBytes": -16124172,
"heapUsedBytes": 85237628,
"domNodes": -265,
"jsHeapTotalBytes": 421888,
"scriptDurationMs": 2603.7729999999997,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18284.648000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17768.470999999998,
"heapDeltaBytes": -37516256,
"heapUsedBytes": 176601084,
"domNodes": -6548,
"jsHeapTotalBytes": -9216000,
"scriptDurationMs": 330.664,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18579.643999999917,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17800.877999999997,
"heapDeltaBytes": -35364768,
"heapUsedBytes": 177481044,
"domNodes": -6548,
"jsHeapTotalBytes": -5439488,
"scriptDurationMs": 303.199,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22870.249,
"styleRecalcs": 171,
"styleRecalcDurationMs": 22.079999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22647.197,
"heapDeltaBytes": -21152044,
"heapUsedBytes": 192594928,
"domNodes": -6548,
"jsHeapTotalBytes": -4829184,
"scriptDurationMs": 921.187,
"eventListeners": -7467,
"totalBlockingTimeMs": 67,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 22638.65499999997,
"styleRecalcs": 171,
"styleRecalcDurationMs": 22.147000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22329.630999999998,
"heapDeltaBytes": -20355812,
"heapUsedBytes": 183220172,
"domNodes": -6548,
"jsHeapTotalBytes": 1445888,
"scriptDurationMs": 918.9640000000002,
"eventListeners": -7469,
"totalBlockingTimeMs": 105,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6621.222999999986,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.28799999999997,
"layouts": 20,
"layoutDurationMs": 24.443000000000005,
"taskDurationMs": 6498.704999999999,
"heapDeltaBytes": -28967312,
"heapUsedBytes": 180839472,
"domNodes": -6548,
"jsHeapTotalBytes": 11370496,
"scriptDurationMs": 127.39900000000002,
"eventListeners": -7469,
"totalBlockingTimeMs": 425,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6589.614999999981,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.463,
"layouts": 20,
"layoutDurationMs": 24.663000000000004,
"taskDurationMs": 6521.344,
"heapDeltaBytes": -31362564,
"heapUsedBytes": 178738868,
"domNodes": -6548,
"jsHeapTotalBytes": 9023488,
"scriptDurationMs": 123.98499999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 515,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9203.759000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9016.253,
"heapDeltaBytes": 19109456,
"heapUsedBytes": 179542080,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 152.24500000000006,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9168.138999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8891.962000000001,
"heapDeltaBytes": 10229596,
"heapUsedBytes": 175923252,
"domNodes": 0,
"jsHeapTotalBytes": -13631488,
"scriptDurationMs": 148.91300000000007,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 112.74600000001556,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.968,
"layouts": 2,
"layoutDurationMs": 1.1640000000000001,
"taskDurationMs": 75.962,
"heapDeltaBytes": 3010172,
"heapUsedBytes": 71890496,
"domNodes": 129,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 4.541999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 97.9099999999562,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.77,
"layouts": 2,
"layoutDurationMs": 1.36,
"taskDurationMs": 69.42699999999999,
"heapDeltaBytes": 2987516,
"heapUsedBytes": 71742616,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.817999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16266 +/- ##
==========================================
+ Coverage 81.15% 82.73% +1.57%
==========================================
Files 2460 2042 -418
Lines 126623 119144 -7479
Branches 33739 30569 -3170
==========================================
- Hits 102766 98575 -4191
+ Misses 23341 20388 -2953
+ Partials 516 181 -335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
1e2f54c to
9e1b953
Compare
|
@coderabbitai review |
|
9e1b953 to
9fc117f
Compare
|
@coderabbitai review |
|
|
Caution CodeRabbit couldn't update its existing comment. The review summary may be out of date. Error details |
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Went through the full diff, nothing to flag. LGTM.
9fc117f to
8e07e2a
Compare
|
cifix: rebased onto origin/main (was ~1700 commits behind) and fixed the 2 real failures:
The Verified locally on the pushed head: New head: |
- add required Asset.size field to the two mock fixtures (main's
Asset type requires size: number; both mocks were missing it,
causing 'does not satisfy the expected type Asset' errors)
- drop contractTest.use({ initialFeatureFlags: {...} }) — that
fixture option was removed from ComfyPage; the assets sidebar tab
is unconditionally available on main (see assets.spec.ts, which
needs no flag setup), so the flag override was dead/type-invalid
code, not a behavior change
Also rebased onto current origin/main (was ~1700 commits behind);
the runtime timeout seen in CI (AssetsSidebarTab.open() waiting on
stale asset-count logic) no longer reproduces since open() dropped
that wait entirely upstream.
Verified manually (hook's own full-repo typecheck exceeds harness
timeout): vue-tsc --noEmit clean, oxlint clean, oxfmt --check clean.
8e07e2a to
ea1fb03
Compare
|
Removed Before: head Force-pushed with lease. CI re-triggered on |
|
@coderabbitai review |
|
|
Deployment failed for project comfy-home-v1 with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
Root-cause fix is green at the exact head. All required checks and every E2E shard passed; no review threads remain. Full context for agent readersHead: The OSS test used a localStorage development override for a server-owned feature flag. The backend WebSocket handshake replaces server flags, leaving Asset API mode disabled. The test now applies Exact-head evidence:
|
Summary
Adds Cloud and flagged-OSS Asset API parity coverage. Verifies generated and imported Assets use the same public Asset API contract in both distributions.
Review Focus
Changes
tags_any=output,temp, input usesinclude_tags=input, and both excludemissing.Review Focus
The test is rebased directly onto
main; the predecessor flag-isolation coverage is intentionally excluded from this PR.Validation:
tags_none=missingfailed at the exact query assertion.Not Found); CI is the Cloud execution gate.