Repository navigation
test(assets): workflow output focus - #16270
christian-byrne wants to merge 4 commits into
Conversation
|
Warning Review limit reachedNext included review available in 15 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
🎭 Playwright: ✅ 1898 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 9.68 MB gzip 🟢 -123 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • 🟢 -909 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 18 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 223 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T12:11:36.473Z",
"gitSha": "895dc89beead00535f9f2299cdd7c42bcce89ac9",
"branch": "test/assets-workflow-switch-focus",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.9650000000229,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.073,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.59099999999995,
"heapDeltaBytes": -9742584,
"heapUsedBytes": 60599316,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.162,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.4840000000768,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.956000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.881,
"heapDeltaBytes": -8507420,
"heapUsedBytes": 62107704,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.171,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.2940000000017,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.461,
"layouts": 14,
"layoutDurationMs": 3.4739999999999998,
"taskDurationMs": 771.051,
"heapDeltaBytes": -8231816,
"heapUsedBytes": 61477132,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 120.812,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.0110000000932,
"styleRecalcs": 73,
"styleRecalcDurationMs": 25.392000000000003,
"layouts": 14,
"layoutDurationMs": 3.437,
"taskDurationMs": 686.101,
"heapDeltaBytes": -13283948,
"heapUsedBytes": 57069052,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 109.33500000000002,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1669.6380000000204,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.852,
"layouts": 6,
"layoutDurationMs": 1.118,
"taskDurationMs": 285.89899999999994,
"heapDeltaBytes": 5089620,
"heapUsedBytes": 75626492,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.100999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1680.6169999999838,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.296000000000001,
"layouts": 6,
"layoutDurationMs": 1.1520000000000001,
"taskDurationMs": 282.04799999999994,
"heapDeltaBytes": 4473048,
"heapUsedBytes": 74094236,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8.875000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 515.8289999999965,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.873,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.474,
"heapDeltaBytes": -8081728,
"heapUsedBytes": 62465524,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 111.201,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 537.531999999942,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.827000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.827,
"heapDeltaBytes": -7865552,
"heapUsedBytes": 62746200,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 116.155,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.36200000002,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.5369999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.4710000000001,
"heapDeltaBytes": 11347324,
"heapUsedBytes": 87279424,
"domNodes": -268,
"jsHeapTotalBytes": -2973696,
"scriptDurationMs": 27.903,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2050.324000000046,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.462999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.0129999999999,
"heapDeltaBytes": 10980372,
"heapUsedBytes": 86992624,
"domNodes": -266,
"jsHeapTotalBytes": -2449408,
"scriptDurationMs": 28.006000000000004,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2116.041999999993,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.576999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1234.302,
"heapDeltaBytes": 11025468,
"heapUsedBytes": 87867040,
"domNodes": -268,
"jsHeapTotalBytes": -126976,
"scriptDurationMs": 576.8910000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2092.2160000000076,
"styleRecalcs": 66,
"styleRecalcDurationMs": 7.976000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1169.267,
"heapDeltaBytes": 21848264,
"heapUsedBytes": 88175852,
"domNodes": 8,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 558.167,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3181.1569999999847,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.9,
"layouts": 60,
"layoutDurationMs": 11.25,
"taskDurationMs": 1304.202,
"heapDeltaBytes": 9463016,
"heapUsedBytes": 76290056,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 560.328,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3119.709999999941,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.614,
"layouts": 60,
"layoutDurationMs": 11.122,
"taskDurationMs": 1274.7459999999999,
"heapDeltaBytes": 8068956,
"heapUsedBytes": 75189868,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 542.893,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2134.0260000000058,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.144000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1354.434,
"heapDeltaBytes": 13329668,
"heapUsedBytes": 80650912,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 640.663,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2240.6330000000025,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.656999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1412.1610000000003,
"heapDeltaBytes": 14066192,
"heapUsedBytes": 81088104,
"domNodes": 6,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 661.6659999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2029.0840000000117,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.449000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.9770000000001,
"heapDeltaBytes": 10472428,
"heapUsedBytes": 87070628,
"domNodes": -267,
"jsHeapTotalBytes": -2973696,
"scriptDurationMs": 26.111,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2029.480000000035,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.401000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.93600000000004,
"heapDeltaBytes": -14577556,
"heapUsedBytes": 87260032,
"domNodes": -265,
"jsHeapTotalBytes": -2412544,
"scriptDurationMs": 30.195,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 507.54499999999325,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.755000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.924,
"heapDeltaBytes": 14034304,
"heapUsedBytes": 86075704,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 94.827,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 508.98099999994884,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.629999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 293.071,
"heapDeltaBytes": 15105028,
"heapUsedBytes": 87040064,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 94.717,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.1539999999904,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.781,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.521,
"heapDeltaBytes": -14886116,
"heapUsedBytes": 58041848,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.1160000000000005,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1990.622999999914,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.667,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.092,
"heapDeltaBytes": 2629160,
"heapUsedBytes": 75560304,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.857000000000002,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1687.9619999999704,
"styleRecalcs": 79,
"styleRecalcDurationMs": 24.66,
"layouts": 18,
"layoutDurationMs": 3.3539999999999996,
"taskDurationMs": 619.83,
"heapDeltaBytes": 9997476,
"heapUsedBytes": 82879676,
"domNodes": -293,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 69.281,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.5540000000437,
"styleRecalcs": 79,
"styleRecalcDurationMs": 25.456000000000003,
"layouts": 18,
"layoutDurationMs": 3.613,
"taskDurationMs": 632.9050000000001,
"heapDeltaBytes": -10017540,
"heapUsedBytes": 62747340,
"domNodes": -292,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 70.756,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 899.6180000000322,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.07,
"layouts": 15,
"layoutDurationMs": 10.612000000000002,
"taskDurationMs": 703.131,
"heapDeltaBytes": 20937280,
"heapUsedBytes": 109020892,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 22.775000000000002,
"eventListeners": 2381,
"totalBlockingTimeMs": 111,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8155.6659999999965,
"styleRecalcs": 249,
"styleRecalcDurationMs": 27.91,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4295.002,
"heapDeltaBytes": -16332620,
"heapUsedBytes": 84588988,
"domNodes": -265,
"jsHeapTotalBytes": -1400832,
"scriptDurationMs": 1862.259,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8227.267999999982,
"styleRecalcs": 248,
"styleRecalcDurationMs": 32.31399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4346.759000000001,
"heapDeltaBytes": 9215796,
"heapUsedBytes": 84653264,
"domNodes": -269,
"jsHeapTotalBytes": -1175552,
"scriptDurationMs": 1910.4399999999998,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12645.709999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11812.752,
"heapDeltaBytes": -30272484,
"heapUsedBytes": 183100908,
"domNodes": -6548,
"jsHeapTotalBytes": 1376256,
"scriptDurationMs": 193.262,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12493.709999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11498.721,
"heapDeltaBytes": -26617240,
"heapUsedBytes": 174306896,
"domNodes": -6548,
"jsHeapTotalBytes": 3674112,
"scriptDurationMs": 188.604,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15220.510999999988,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.910000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14697.496000000001,
"heapDeltaBytes": -21482380,
"heapUsedBytes": 182792352,
"domNodes": -6548,
"jsHeapTotalBytes": 1196032,
"scriptDurationMs": 731.997,
"eventListeners": -7473,
"totalBlockingTimeMs": 2,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15389.829000000078,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.165999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14876.74,
"heapDeltaBytes": -1364524,
"heapUsedBytes": 186311200,
"domNodes": -6548,
"jsHeapTotalBytes": 1769472,
"scriptDurationMs": 719.839,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4348.635999999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.894000000000034,
"layouts": 20,
"layoutDurationMs": 21.318000000000005,
"taskDurationMs": 4195.5960000000005,
"heapDeltaBytes": -31438156,
"heapUsedBytes": 174948592,
"domNodes": -6548,
"jsHeapTotalBytes": 11288576,
"scriptDurationMs": 92.74100000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 15,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4398.409000000015,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.38799999999997,
"layouts": 20,
"layoutDurationMs": 20.880999999999997,
"taskDurationMs": 4233.491000000001,
"heapDeltaBytes": -24179908,
"heapUsedBytes": 176619776,
"domNodes": -6548,
"jsHeapTotalBytes": 13328384,
"scriptDurationMs": 76.585,
"eventListeners": -7475,
"totalBlockingTimeMs": 27,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 477.8450000000021,
"styleRecalcs": 21,
"styleRecalcDurationMs": 16.191999999999997,
"layouts": 3,
"layoutDurationMs": 1.088,
"taskDurationMs": 106.037,
"heapDeltaBytes": 5056528,
"heapUsedBytes": 73586300,
"domNodes": 151,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9.733999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 106.09999999996944,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.453000000000001,
"layouts": 2,
"layoutDurationMs": 1.4160000000000001,
"taskDurationMs": 61.185,
"heapDeltaBytes": 3060100,
"heapUsedBytes": 71981052,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.108999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎨 Storybook: ✅ Built — View Storybook🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-16270.vercel.app This commit: https://website-frontend-e5zha2phb-comfyui.vercel.app Last updated: 2026-09-01T07:01:04Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16270 +/- ##
==========================================
+ Coverage 80.75% 82.41% +1.65%
==========================================
Files 2440 2031 -409
Lines 124479 117236 -7243
Branches 31124 29392 -1732
==========================================
- Hits 100525 96616 -3909
+ Misses 23452 20442 -3010
+ Partials 502 178 -324
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
1e2f54c to
9e1b953
Compare
|
@coderabbitai review |
|
9e1b953 to
9fc117f
Compare
c7d2233 to
711068b
Compare
|
@coderabbitai review |
|
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
|
Fully contained in #16293; our review is posted there. |
711068b to
0dcf057
Compare
|
@coderabbitai review |
|
benjcooley
left a comment
There was a problem hiding this comment.
This review is generated by Claude. It may not always be accurate. If any comment is wrong, please say why.
Test-only PR, and the journey it adds is real coverage — the queue View -> exact-asset-focus assertion is the valuable part and it does hold up against the code (focusAssetInSidebar selects by String(jobId), and history-derived asset ids are taskItem.jobId, so data-asset-id === job.id is the right invariant).
The problem is roughly a third of the test is ceremony that does nothing, and one piece of it actively misrepresents the system.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 5 |
| TRIVIAL | 3 |
Main points
- The
/api/assetsroute mock is never hit by this spec, and the asset id it returns (10000000-...) contradicts the assertion four lines from the end that the selected card's id equals the job id (00000000-...). Delete it. initialFeatureFlags: { assets: true },setServerFlagsPersistent({ assets: true }), andComfy.Assets.UseAssetAPI: trueare all inert here — theassetsserver flag is read only byisAssetPreviewSupported()(3D preview persistence), andUseAssetAPIroutes the model library. Three switches, none wired to this journey, one of them set twice by two different mechanisms.- Hardcoded
nodeId = '1'—setNodeOutputsByExecutionIdsilently no-ops on an unresolvable id, so a default-workflow change turns this into a poll timeout rather than a clear failure.workflowPersistence.spec.tsderives the id instead. - The mid-test Assets preload needs a justification. If it is load-bearing, it is masking a real race in the cold queue -> Assets focus path and that is worth fixing in product code.
- Lines 184-215 duplicate
workflowPersistence.spec.ts-> 'Node outputs are preserved when switching workflow tabs'.
Positive: correct use of mergeTests + the WS fixture; the afterEach workflows-directory reset is right (the user id is per-worker, not per-test, so it is genuinely needed); expect.poll rather than fixed waits throughout; satisfies on the mock payload.
None of this blocks merge on correctness — it is a maintainability and honesty-of-intent issue. Removing the inert config would shrink the diff by ~25 lines and make the test say what it actually does.
| test.describe('Queue overlay', () => { | ||
| test.beforeEach(async ({ comfyPage, jobsRoutes }) => { | ||
| await jobsRoutes.mockJobsScenario({ history: MOCK_JOBS, queue: [] }) | ||
| await comfyPage.page.route(/\/api\/assets(?:\?.*)?$/, async (route) => { |
There was a problem hiding this comment.
SHOULD FIX — this /api/assets mock is never exercised by this spec, and its data contradicts the assertion it appears to support.
The Generated tab renders from useAssetsApi('output') -> assetsStore.historyAssets, which is filled by api.getHistory() (the jobs routes you already mock) and mapped through mapTaskOutputToAssetItem, where id: taskItem.jobId. Nothing in this journey calls /assets: fetchInputFilesFromAPI uses /internal/files/input on non-cloud, and useFlatOutputAssets (the only asset-API-backed output list) is not what AssetsSidebarTab uses.
So the mocked asset id 10000000-...-0002 is not the id the grid renders — the card's data-asset-id is the job id, which is exactly what line 230 asserts. If the sidebar ever did read this route, this mock would make the test fail. As written it encodes a false model (asset id != job id) directly next to an assertion that asset id == job id.
It is also installed in the shared beforeEach, so it applies to the six unrelated tests in this file.
Suggest deleting the whole page.route block and the now-unused ListAssetsResponse import. If it is load-bearing for something I missed, please add a one-line note saying which request it serves, and align the id with targetJobId so the two ids do not disagree.
| create_time: mockJobTimestamp - 120_000, | ||
| execution_start_time: mockJobTimestamp - 120_000, | ||
| execution_end_time: mockJobTimestamp - 115_000, | ||
| preview_output: { |
There was a problem hiding this comment.
TRIVIAL — adding preview_output to this shared fixture changes the rendered row for the six pre-existing tests in this file: the job now renders a preview tile (fetching /api/view?filename=workflow-output.png, which 404s in the test backend) instead of a state icon, and becomes double-click/View-able. Nothing currently asserts on that, so it is safe today, but it makes MOCK_JOBS carry state that only one nested describe needs. Consider a local fixture for the new test instead of mutating the shared array.
| test.describe('workflow output focus', () => { | ||
| test.use({ | ||
| initialFeatureFlags: { assets: true }, | ||
| initialSettings: { 'Comfy.Assets.UseAssetAPI': true } |
There was a problem hiding this comment.
SHOULD FIX — neither of these gates anything on this code path.
Comfy.Assets.UseAssetAPI routes the model library to the asset browser (sidebarTabStore, modelStore, ModelLibrarySidebarTab) and enables assetService.isAssetAPIEnabled(). The assets server flag is read in exactly one place — isAssetPreviewSupported() in platform/assets/utils/assetPreviewUtil.ts, used by the Load3D / 3D-preview thumbnail persistence path. The Generated sidebar list, the queue overlay View button, and focusAssetInSidebar all ignore both.
Also worth noting initialFeatureFlags seeds the ff: localStorage override, which FeatureFlagHelper documents as dev-only and tree-shaken from production builds — so on a prod-build run it is a no-op regardless.
Unless one of these is actually needed, drop both; they make the test look like it is covering asset-API behaviour that it is not.
| const ws = await getWebSocket() | ||
| const execution = new ExecutionHelper(comfyPage, ws) | ||
|
|
||
| await comfyPage.featureFlags.setServerFlagsPersistent({ assets: true }) |
There was a problem hiding this comment.
SHOULD FIX — third mechanism for the same flag: test.use({ initialFeatureFlags: { assets: true } }) (localStorage ff: seed) plus this (api.serverFeatureFlags). Setting one flag two ways in one test usually means the first one did not work and the second was added without removing it. Given nothing on this journey reads the assets flag (see comment on line 152), please remove both — or keep exactly one and say why it is required.
| }) => { | ||
| const workflowName = `assets-output-focus-${Date.now().toString(36)}` | ||
| const job = MOCK_JOBS[1] | ||
| const nodeId = '1' |
There was a problem hiding this comment.
SHOULD FIX — hardcoding node id '1' couples this test to the default workflow's node ids.
app.ts's executed handler calls setNodeOutputsByExecutionId, which does executionIdToNodeLocatorId(app.rootGraph, executionId) and silently returns when the id does not resolve to a node in the current graph. If the default workflow's node ids ever change, this test does not fail with "node 1 not found" — it hangs on the first expect.poll until timeout with an opaque message.
browser_tests/tests/workflowPersistence.spec.ts handles the same case by deriving the id (getRequiredFirstNodeRef -> String(firstNode.id)). Worth following that here.
| ) | ||
| .toEqual(output) | ||
|
|
||
| await comfyPage.menu.assetsTab.open({ waitForAssets: false }) |
There was a problem hiding this comment.
SHOULD FIX — what is this preload for?
focusAssetInSidebar already awaits assetsStore.updateHistory() before selecting, and AssetsSidebarTab is a statically-imported markRaw component, so the cold path should work without warming the store first. Opening Assets here and then switching back to Workflows also unmounts the tab, which runs deactivate() -> clearSelection(), so it cannot be preserving selection state either.
If you added this to fix a flake, that flake is worth chasing to root cause rather than warming: the only way it should matter is if the tab's watch(activeTab, { immediate: true }) -> clearSelection() can land after setSelection() on a cold mount, which would be a real product bug in the queue -> Assets focus path, not a test problem. If it is not needed, delete these four lines — as written they add an unrelated "card is visible in Assets" assertion that sidebar/assetsSidebarTab.spec.ts already covers.
| ) | ||
| await comfyPage.menu.workflowsTab.open() | ||
| await comfyPage.menu.topbar.saveWorkflow(workflowName) | ||
| execution.executed(job.id, nodeId, output) |
There was a problem hiding this comment.
TRIVIAL — worth knowing so the test is not over-trusted: the prompt_id here is decorative. app.ts's executed listener writes to the node output store unconditionally, and the other executed listener (changeTracker.ts, which does use prompt_id) bails immediately because useExecutionStore().queuedJobs[job.id] is empty — nothing was ever queued through storeJob. Restoration on tab switch works via deactivate() -> store() -> snapshotOutputs(), which does not care about job ids.
So the executed output and the queue job's asset are linked only by matching filenames, not by id. The PR description reads as if the two halves are causally connected; they are not. Not a defect, but the queuedJobs-keyed changeTracker path is left uncovered.
| ) | ||
| .toEqual(output) | ||
|
|
||
| await comfyPage.command.executeCommand('Comfy.NewBlankWorkflow') |
There was a problem hiding this comment.
TRIVIAL — lines 184-215 (save workflow, produce output, Comfy.NewBlankWorkflow, switch back, assert output restored) duplicate browser_tests/tests/workflowPersistence.spec.ts -> 'Node outputs are preserved when switching workflow tabs'. The only new assertion in that stretch is that the blank workflow does not inherit the output.
The genuinely new coverage is lines 223-241 (queue View -> exact asset focused, output not clobbered). Consider trimming the front half to the minimum needed to set up that state, and per AGENTS.md ('be parsimonious', composable tests) putting the focus test somewhere it is discoverable — this is currently a workflow-persistence + assets test living in queueOverlay.spec.ts.
Summary
Workflow output focus covered. Workflow output restoration and exact Assets focus now share one browser journey. Mutation verified. Adds route-mocked browser coverage that:
Review Focus
This is stacked on frontend Assets API parity pull request 16266.
Verification
Validation: