Repository navigation
[agent-v1 06/18] infrastructure and observability - #16185
CodeJuggernaut wants to merge 6 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ❌ 1866 passed, 10 failed · 2 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle: 9.63 MB gzipDetailsSummary
Category Glance App Entry Points — 3.8 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.4 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 124 kBTop-level views, pages, and routed surfaces
Status: 17 added Panels & Settings — 621 kBConfiguration panels, inspectors, and settings screens
Status: 27 added User & Accounts — 27.5 kBAuthentication, profile, and account management bundles
Status: 11 added Editors & Dialogs — 126 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 115 kBReusable component library chunks
Status: 15 added Data & Services — 3.58 MBStores, services, APIs, and repositories
Status: 17 added Utilities & Hooks — 559 kBHelpers, composables, and utility bundles
Status: 37 added Vendor & Third-Party — 18.1 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 16.2 MBBundles that do not match a named category
Status: 294 added ⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-31T14:15:49.874Z",
"gitSha": "e720297b9e6968ca4d190333b8d6383a1b4e9572",
"branch": "nathaniel/agent-v1/06-infra-observability",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2001.3359999999807,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.090999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.707,
"heapDeltaBytes": 348152,
"heapUsedBytes": 64360056,
"domNodes": 16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7.595999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2006.0789999999997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.258,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.51300000000003,
"heapDeltaBytes": 415892,
"heapUsedBytes": 64091232,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.792000000000001,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1826.6430000000469,
"styleRecalcs": 74,
"styleRecalcDurationMs": 31.788999999999998,
"layouts": 14,
"layoutDurationMs": 4.619,
"taskDurationMs": 811.9830000000001,
"heapDeltaBytes": 2060068,
"heapUsedBytes": 71922668,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 120.61,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1701.6320000000178,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.626,
"layouts": 14,
"layoutDurationMs": 4.081,
"taskDurationMs": 673.4760000000001,
"heapDeltaBytes": 3527180,
"heapUsedBytes": 73199012,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 99.82,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1732.9679999999712,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.147999999999998,
"layouts": 6,
"layoutDurationMs": 1.3450000000000002,
"taskDurationMs": 344.748,
"heapDeltaBytes": 4638332,
"heapUsedBytes": 74506692,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.609000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.5950000000057,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.069,
"layouts": 6,
"layoutDurationMs": 1.2610000000000001,
"taskDurationMs": 316.3,
"heapDeltaBytes": 4335020,
"heapUsedBytes": 74123180,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9.522000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 545.3170000000114,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.718000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.15,
"heapDeltaBytes": 17794104,
"heapUsedBytes": 87681920,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 120.54700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 544.1419999999653,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.417,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.42600000000004,
"heapDeltaBytes": 17865264,
"heapUsedBytes": 87869640,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 119.03899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2018.068000000028,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.832,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.916,
"heapDeltaBytes": -13441000,
"heapUsedBytes": 86696312,
"domNodes": -267,
"jsHeapTotalBytes": -1581056,
"scriptDurationMs": 31.081000000000003,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2019.0029999999979,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.236,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.7830000000001,
"heapDeltaBytes": -13081152,
"heapUsedBytes": 86903728,
"domNodes": -268,
"jsHeapTotalBytes": -1581056,
"scriptDurationMs": 32.09,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2084.52299999999,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.545999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1255.8669999999997,
"heapDeltaBytes": 17811088,
"heapUsedBytes": 83789180,
"domNodes": 4,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 579.7549999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2104.1910000000144,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.684999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1218.236,
"heapDeltaBytes": 14132604,
"heapUsedBytes": 80213236,
"domNodes": -270,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 573.8890000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3228.5529999999767,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.309000000000003,
"layouts": 60,
"layoutDurationMs": 13.653,
"taskDurationMs": 1436.65,
"heapDeltaBytes": 9099196,
"heapUsedBytes": 76086224,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 614.3530000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3099.3419999999787,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.018999999999998,
"layouts": 60,
"layoutDurationMs": 12.154,
"taskDurationMs": 1322.2649999999999,
"heapDeltaBytes": 8734408,
"heapUsedBytes": 75456336,
"domNodes": -281,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 553.978,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2501.697999999976,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.725999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1479.8340000000003,
"heapDeltaBytes": 17723496,
"heapUsedBytes": 84555188,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 713.225,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2252.62500000008,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.227999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1432.254,
"heapDeltaBytes": 13738648,
"heapUsedBytes": 81276696,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 671.708,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.2529999999965,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.5109999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.635,
"heapDeltaBytes": 21932716,
"heapUsedBytes": 87030928,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.105000000000008,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.5080000000207,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.4370000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.1570000000001,
"heapDeltaBytes": -14999672,
"heapUsedBytes": 86845020,
"domNodes": -270,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 29.494,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 539.6250000000009,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.089999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.055,
"heapDeltaBytes": 14079912,
"heapUsedBytes": 85927044,
"domNodes": 20,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 109.95299999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.6469999999354,
"styleRecalcs": 49,
"styleRecalcDurationMs": 8.505,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.592,
"heapDeltaBytes": 14796036,
"heapUsedBytes": 87101020,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 107.29699999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.2499999999795,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.862999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.13100000000003,
"heapDeltaBytes": 3487772,
"heapUsedBytes": 75527064,
"domNodes": -295,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.428000000000001,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.6939999999158,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.172000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.588,
"heapDeltaBytes": -10276432,
"heapUsedBytes": 61730916,
"domNodes": -298,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.515999999999998,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1686.1419999999612,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.736,
"layouts": 18,
"layoutDurationMs": 4.625000000000001,
"taskDurationMs": 677.756,
"heapDeltaBytes": -12243796,
"heapUsedBytes": 59678632,
"domNodes": -295,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 77.313,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1700.749999999971,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.396,
"layouts": 18,
"layoutDurationMs": 4.939,
"taskDurationMs": 703.041,
"heapDeltaBytes": 318164,
"heapUsedBytes": 72676836,
"domNodes": -298,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 82.15700000000001,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 897.9669999999942,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.39,
"layouts": 15,
"layoutDurationMs": 11.138,
"taskDurationMs": 718.3889999999997,
"heapDeltaBytes": 26389120,
"heapUsedBytes": 99806420,
"domNodes": 13671,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 22.743000000000006,
"eventListeners": 2381,
"totalBlockingTimeMs": 109,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8223.499000000003,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.497,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4683.226000000001,
"heapDeltaBytes": -11345096,
"heapUsedBytes": 88639264,
"domNodes": -264,
"jsHeapTotalBytes": -569344,
"scriptDurationMs": 2016.5130000000001,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8173.217000000022,
"styleRecalcs": 249,
"styleRecalcDurationMs": 32.900999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4502.963,
"heapDeltaBytes": -10922788,
"heapUsedBytes": 88813092,
"domNodes": -266,
"jsHeapTotalBytes": -569344,
"scriptDurationMs": 1934.21,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14640.619000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13524.556,
"heapDeltaBytes": -33847772,
"heapUsedBytes": 174057052,
"domNodes": -6548,
"jsHeapTotalBytes": -3575808,
"scriptDurationMs": 228.36200000000002,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12693.20300000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11955.406,
"heapDeltaBytes": -35276352,
"heapUsedBytes": 173806240,
"domNodes": -6548,
"jsHeapTotalBytes": 1822720,
"scriptDurationMs": 182.386,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16991.45900000002,
"styleRecalcs": 127,
"styleRecalcDurationMs": 17.27199999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16526.454,
"heapDeltaBytes": -34115628,
"heapUsedBytes": 175768484,
"domNodes": -6548,
"jsHeapTotalBytes": -6541312,
"scriptDurationMs": 837.071,
"eventListeners": -7470,
"totalBlockingTimeMs": 22,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 16650.726999999963,
"styleRecalcs": 115,
"styleRecalcDurationMs": 16.312000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16101.369000000002,
"heapDeltaBytes": -38300016,
"heapUsedBytes": 165699024,
"domNodes": -6548,
"jsHeapTotalBytes": -3657728,
"scriptDurationMs": 876.281,
"eventListeners": -7467,
"totalBlockingTimeMs": 149,
"frameDurationMs": 17.22666666666664,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4947.9069999999865,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.53,
"layouts": 20,
"layoutDurationMs": 23.09299999999999,
"taskDurationMs": 4832.005,
"heapDeltaBytes": -28200632,
"heapUsedBytes": 174165644,
"domNodes": -6548,
"jsHeapTotalBytes": 11829248,
"scriptDurationMs": 87.624,
"eventListeners": -7471,
"totalBlockingTimeMs": 125,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4744.869999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.442,
"layouts": 20,
"layoutDurationMs": 22.319000000000006,
"taskDurationMs": 4668.058,
"heapDeltaBytes": -9920404,
"heapUsedBytes": 179300720,
"domNodes": -6548,
"jsHeapTotalBytes": 16572416,
"scriptDurationMs": 86.26500000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 100,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 84.1970000000174,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.13,
"layouts": 2,
"layoutDurationMs": 1.163,
"taskDurationMs": 58.106,
"heapDeltaBytes": 3187412,
"heapUsedBytes": 71168088,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.014000000000002,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 450.860999999918,
"styleRecalcs": 13,
"styleRecalcDurationMs": 15.796999999999999,
"layouts": 2,
"layoutDurationMs": 0.541,
"taskDurationMs": 86.018,
"heapDeltaBytes": 5054476,
"heapUsedBytes": 73134652,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.109999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## nathaniel/agent-v1/05-shared-ui-media #16185 +/- ##
=========================================================================
+ Coverage 80.84% 80.87% +0.02%
=========================================================================
Files 2355 2355
Lines 120684 120732 +48
Branches 33647 33157 -490
=========================================================================
+ Hits 97569 97642 +73
+ Misses 22519 22494 -25
Partials 596 596
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 2 |
| 🟢 Low | 5 |
Panel: 8/8 reviewers contributed findings.
|
Automated fleet review (desktop operator, Christian-authorized)
Full context for agent readersPR #16185 — design-review packet (slice 06/18, infrastructure and observability)Subject: Comfy-Org/ComfyUI_frontend#16185 Verdict: MERGE-AFTER-CHANGES (2 cheap disposition items: clear the author's FE-1774 merge gate 1. What the PR actually does
The PostHog merge order lets server [nathaniel-pr-rationale: #16185] The PR declares FE-1774's billing-containment answer a merge gate 2. Alignment with our ADRs and CRDT recut
CRDT-internals audit: clean. No import or changed path under 3. Flag-off safety — accepted cosmetic LEAKThe Agent telemetry methods are dormant without producers, and the error branches require Under BBC #149 the relevant question is user regression. Label, tooltip, click action, and 4. Test coverage and CIFocused tests cover telemetry event names and payload positions, PII stripping, prompt-error catalog Current GitHub rollup is 97 passing, 16 skipped, 11 failing. Failures are 5. VerdictMERGE-AFTER-CHANGES
No CRDT change or flag boundary is requested. The accepted cosmetic feedback delta should remain SourcesDirect PR diff and checks at the exact head; Glossary
|
9f3023c to
1c6e239
Compare
7b8d51b to
3ef683a
Compare
1c6e239 to
08b3023
Compare
3ef683a to
c7c7f9f
Compare
08b3023 to
3a256cb
Compare
Addresses review feedback: #16185 (comment)
Addresses review feedback: #16185 (comment)
Addresses review feedback: #16185 (comment)
Addresses review feedback: #16185 (comment)
c7c7f9f to
38fc577
Compare
3a256cb to
87d6f57
Compare
Addresses review feedback: #16185 (comment)
Addresses review feedback: #16185 (comment)
Addresses review feedback: #16185 (comment)
38fc577 to
2c331fb
Compare
2c331fb to
06e6091
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 9 prior finding(s) across 1 round(s) (9 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 2 |
| 🟢 Low | 7 |
Panel: 5/8 reviewers contributed findings.
Reviewers that did not contribute: gpt-5.6-sol-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), gemini-3.1-pro:edge-case (error)
The finding(s) below could not be anchored to a line the reviewed diff carries, so they are reported here instead of inline:
src/lib/litegraph/src/linkDeduplication.ts:219— 🟡 Medium — Swapping the boundedfor (let pass = 0; pass < Math.max(1, referencedNames.size); pass++)forwhile (successfulPasses < referencedNames.size)removes the iteration bound: progress now depends on either a successful pass or at least one link landing inskipped. When an apply fails with nomovedparticipants — a removal-only pass, or one where every remaining link was already skipped —blockedandmovedare both empty, this loop adds nothing toskipped,successfulPassesnever advances, and the identical state is retried forever, hanging the tab during graph configure. Add a hard pass ceiling, or bail out when a failing pass skipped nothing.Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
src/workbench/extensions/agent/crdt/docFrameClient.ts:146— 🟡 Medium —parseDocOpFailurerejects arrays and any object without top-levelop_id/code/messagestrings, soparseServerDocFramestripsfailedbefore it can reachtoOpsResultView— which was written specifically to normalize exactly those shapes (array entries, and the newer{index, op: {op_id}}form). The two files contradict each other about the wire shape and the strict parser runs first, so an identified empty-list failure degrades to an anonymous one andopSenderloses the batch correlation itsfailure.op_idpath depends on. Either passdata.failedthrough verbatim or widen this guard to matchnormalizeFailure.Raised by 1 of 8 reviewers (gemini-3.1-pro edge-case).
src/utils/markdownRendererUtil.ts:50— 🟢 Low — This rewrite turns any absolutehttps://*.comfy.org/api/...URL appearing in untrusted markdown (workflow markdown widgets, node descriptions, agent output) into a same-origin path, so the image renderer emits an<img src>that fires a credentialed GET at the user's own API with an attacker-chosen path and query string — request forgery against any side-effecting or state-revealing GET route. Restricting the rewrite to the media prefix actually needed (e.g./api/view) keeps the convenience without opening the whole API surface.Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
src/platform/assets/schemas/mediaAssetSchema.ts:62— 🟢 Low —z.string().url()accepts any parseable URL, includingjavascript:anddata:, and this payload is attacker-influenceable — any page can attachapplication/x-comfy-asset-infoto a drag that lands on the canvas. The first consumer that putspreview_urlinto anhref/srcinherits a script-URL injection; constrain the scheme to http/https at the schema (and apply the same check to theurithatgetDroppedAssethands back for fetching).Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
src/platform/workflow/core/services/workflowService.ts:473— 🟢 Low — The drain awaitsworkflowLoadTailwith no timeout whileclosingWorkflowCountsalready holds an entry for this workflow, so a load that never settles (a hungworkflow.load()orloadGraphData) parks this loop forever, thefinallynever releases the latch, andopenWorkflowthen refuses that workflow permanently — the tab can neither be closed nor reopened for the rest of the session. Bounding the drain with a timeout (or releasing the latch before awaiting) keeps a stuck load from wedging one workflow.Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
src/extensions/core/agentPanel.ts:24— 🟢 Low — This dynamic import of the agent panel store sits outsidesetupFlagGate'stry, so if it ever rejects the function rejects before thecatchcan runsettle(), leavingagentPanelStore.gateSettledpermanently false and hanging anything waiting ondata-agent-gate-settled— against the "any failure settles fail-closed" contract the rest of the function is written to (and covered for the flag-source chunk byagentPanelGateDependencyFailure.test.ts). Move the store import inside thetryand make the failure path settle without it.Raised by 1 of 8 reviewers (kimi-k3-max edge-case).
| } | ||
| }) | ||
| res.writeHead(proxyRes.statusCode || 200) | ||
| proxyRes.pipe(res) |
There was a problem hiding this comment.
🟠 High — The pass-through branch still uses bare proxyRes.pipe(res) with no 'error' listener, and nothing destroys proxyRes when the client aborts. Under selfHandleResponse: true this handler owns the stream, so a backend reset or truncated body mid-transfer (routine during a backend reload) emits an unhandled 'error' and takes down the Vite dev server, and every aborted media request leaks the upstream response and its socket. Round 1's identical finding was fixed only on the GCS branch (stream.pipeline); use pipeline(proxyRes, res) here too.
Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| const rangeHeader = req.headers.range | ||
| fetch(location, { | ||
| headers: rangeHeader ? { range: rangeHeader } : undefined, | ||
| redirect: 'manual' |
There was a problem hiding this comment.
🟢 Low — redirect: 'manual' also stops GCS's own redirects from being followed: Node returns an opaque-redirect filtered response (status 0, empty headers, body === null), so the relay falls into the !gcsResponse.body branch and answers 500 Empty response from GCS instead of the media, where before round 1's hardening the hop was followed transparently. If GCS-side redirects need to keep working, validate the hop against the same host allowlist and re-fetch rather than failing the request.
Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| // are forwarded and the partial-content response relayed so ranged reads | ||
| // behave like production, where the browser talks to GCS directly. | ||
| const rangeHeader = req.headers.range | ||
| fetch(location, { |
There was a problem hiding this comment.
🟢 Low — Re-raising the missing timeout (the round-1 thread was never answered by the author): the reply argued stream.pipeline now couples the upstream body to the client response lifecycle, but the pipeline only exists after this promise resolves. A target that accepts the TCP connection and never sends response headers leaves this fetch pending indefinitely with no AbortSignal, pinning the dev-server request and its client socket, and each retry of the media load stacks another. Pass signal: AbortSignal.timeout(...) and abort it on res 'close'.
Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| before_send: createPostHogBeforeSend() | ||
| }) | ||
| ...serverConfig, | ||
| person_profiles: serverConfig.person_profiles ?? 'identified_only' |
There was a problem hiding this comment.
🟢 Low — The nullish guard only rejects null/undefined; serverConfig is an untyped remote payload that is never runtime-validated, so any other value ('always' typo'd, true, 0) still flows through, and posthog-js only special-cases the exact strings 'never' and 'identified_only' — anything else lands in the always-on branch and creates person profiles for anonymous visitors. Validate against the two accepted literals. The same ...serverConfig spread also leaves api_host/ui_host and collection toggles (autocapture, capture_pageview, persistence, disable_session_recording) remote-settable; consider pinning the destination and privacy-critical fields after the spread the way before_send is.
Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial).
|
Closing: superseded by merged CRDT v2 (#16198) — salvage continues as main-based PRs.
Full context for agent readersThis PR is part of the pre-#16198 agent-v1 slice series superseded by the merged v2 foundation on main (f954e47). Per program policy all verification/QA/test content from this series is transplanted to main-based successor PRs as permanent CI tests; deliverables route only to OPEN successor PRs. Closed PRs remain readable sources. Completes the slc-1 close set flagged partially-done in bbc #165 read-back manifest reports/pr-lifecycle/bbc165-state-readback.json. |
|
This slice is reference-only. Accepted work is routed to #16198 and #16492. Full context for agent readersPer Christian's main-target close ruling, #16185 (06 — infrastructure and observability) is no longer a landing vehicle. It remains readable implementation and review provenance. PostHog-specific behavior was deliberately dropped. If a genuinely unaccounted delta is found, reopen this source or file a bounded main-based carrier rather than reviving the stacked merge path. |
browser_tests carried 10 `test.fixme(true, 'Activates after slice PR 1618x merges')` gates. All four gating PRs (#16184, #16185, #16186, #16187) were closed unmerged on 2026-09-14, along with the rest of the agent-v1 03-17 slice series, so the activation condition can never be met and the tests have never executed. None of them depend on unmerged source: they are written entirely against fixtures that exist on main (nodeOps, canvasOps, topbar, mockCloudBoot, Load3DFixtures). Removing the gates so CI reports their real state; any that fail become `test.fail()` pins with a tracking issue, per the repo's existing known-defect convention. Also drops the stale slice-PR comments, renames `slice03CanvasPrimitives.spec.ts` to `agentCanvasPrimitives.spec.ts`, and retitles the two describe blocks that named a slice number.
…-Org#18840) ## Problem `browser_tests` carried 10 tests parked behind `test.fixme(true, 'Activates after slice PR 1618x merges')`. All four gating PRs were closed unmerged on 2026-09-14, so their activation condition could never be met. | File | Tests | Gate | |---|---:|---| | `browser_tests/tests/topbar/workflowTabs.spec.ts` | 4 | Comfy-Org#16184 — closed unmerged | | `browser_tests/tests/agent/slice03CanvasPrimitives.spec.ts` | 4 | Comfy-Org#16186 — closed unmerged | | `browser_tests/tests/billingFacadeConsumers.spec.ts` | 1 | Comfy-Org#16185 — closed unmerged | | `browser_tests/tests/load3d/load3dViewer.spec.ts` | 1 | Comfy-Org#16187 — closed unmerged | ## Change - Remove all 10 gates and the stale slice-PR comments. - Rename `slice03CanvasPrimitives.spec.ts` to `agentCanvasPrimitives.spec.ts` and remove slice numbering from its suite names. - Move reusable canvas operations into their fixture owners and make the centering and fit tests establish that a viewport change is required before checking the result. - Make the full-screen Load3D viewer respect the right workspace inset published by the Agent panel. - Preserve the widest active inset publisher during graph/linear host switches. - Keep Agent usable as a viewport-width overlay when the dock cannot fit, while publishing zero workspace inset so portaled dialogs retain positive width. Production changes span `ViewerControls.vue`, `load3dViewerDialog.ts`, `useWorkspaceInset.ts`, `load3d.ts`, `DockedAgentPanel.vue`, and `agentPanelStore.ts`, with focused component/composable and cloud browser coverage. ## First-run results 8 of the 10 tests passed on their first run. The two failures were fixed rather than pinned: - **Load3D workspace geometry:** the full-screen viewer was centered and sized against the whole viewport, so it rendered beneath the Agent dock. The cloud case now opens the real Agent panel and checks both docked and 400px overlay geometry in `load3dAgentUpdate.spec.ts` through `load3dAgentFixture`. - **Canvas primitive oracle:** `graph.serialize()` includes viewport state in `extra.ds`, so comparing the whole serialization incorrectly treated `centerOnNode()` doing its job as graph mutation. The test now compares graph data without viewport state. The centering test first shifts the viewport 400×250 away and proves the node is off-center. The fit test first zooms to 3× and proves a node is outside the canvas. Both then assert the requested operation changes the viewport; the centering test also verifies that graph data is unchanged. - Fixes Comfy-Org#18918 --------- Co-authored-by: Amp <amp@ampcode.com>
`browser_tests` carried 10 tests parked behind `test.fixme(true, 'Activates after slice PR 1618x merges')`. All four gating PRs were closed unmerged on 2026-09-14, so their activation condition could never be met. | File | Tests | Gate | |---|---:|---| | `browser_tests/tests/topbar/workflowTabs.spec.ts` | 4 | #16184 — closed unmerged | | `browser_tests/tests/agent/slice03CanvasPrimitives.spec.ts` | 4 | | `browser_tests/tests/billingFacadeConsumers.spec.ts` | 1 | #16185 — closed unmerged | | `browser_tests/tests/load3d/load3dViewer.spec.ts` | 1 | #16187 — closed unmerged | - Remove all 10 gates and the stale slice-PR comments. - Rename `slice03CanvasPrimitives.spec.ts` to `agentCanvasPrimitives.spec.ts` and remove slice numbering from its suite names. - Move reusable canvas operations into their fixture owners and make the centering and fit tests establish that a viewport change is required before checking the result. - Make the full-screen Load3D viewer respect the right workspace inset published by the Agent panel. - Preserve the widest active inset publisher during graph/linear host switches. - Keep Agent usable as a viewport-width overlay when the dock cannot fit, while publishing zero workspace inset so portaled dialogs retain positive width. Production changes span `ViewerControls.vue`, `load3dViewerDialog.ts`, `useWorkspaceInset.ts`, `load3d.ts`, `DockedAgentPanel.vue`, and `agentPanelStore.ts`, with focused component/composable and cloud browser coverage. 8 of the 10 tests passed on their first run. The two failures were fixed rather than pinned: - **Load3D workspace geometry:** the full-screen viewer was centered and sized against the whole viewport, so it rendered beneath the Agent dock. The cloud case now opens the real Agent panel and checks both docked and 400px overlay geometry in `load3dAgentUpdate.spec.ts` through `load3dAgentFixture`. - **Canvas primitive oracle:** `graph.serialize()` includes viewport state in `extra.ds`, so comparing the whole serialization incorrectly treated `centerOnNode()` doing its job as graph mutation. The test now compares graph data without viewport state. The centering test first shifts the viewport 400×250 away and proves the node is off-center. The fit test first zooms to 3× and proves a node is outside the canvas. Both then assert the requested operation changes the viewport; the centering test also verifies that graph data is unchanged. - Fixes #18918
Merge after: #16187 (05) - stacked on its branch; retargets to main as the stack lands.
Decisions: Agent V1 Decision Log
Summary
Slice 06 of the agent-v1 chain: telemetry registry + PostHog provider coverage for the nine agent events (FE-1771 pins at both the event-string and payload-type level), the agent error-type drift guard wired to the prompt catalog (compile-time exhaustive in both directions), the gcsRedirect dev plugin extracted to build/plugins with behavioral tests, and the e2e/unit runner boundary made explicit.
Changes
Review Focus
typecheck:build+buildinoxlint:main. Slice 06 introduces the first test file underbuild/, which no existing gate reached.Linear tickets