Repository navigation
[backport cloud/1.51] fix: clarify missing core node version warning - #16179
Closed
comfy-pr-bot wants to merge 1 commit into
Closed
comfy-pr-bot wants to merge 1 commit into
comfy-pr-bot wants to merge 1 commit into
Conversation
## ELI5 The warning says a workflow was created with a newer ComfyUI version, but the number shown is actually the currently installed backend version. This changes the warning to say that some missing core nodes require a newer ComfyUI version and asks the user to update. ## Motivation MissingNodeCard receives the current ComfyUI version from /system_stats. Describing that value as the workflow creation version is misleading. The new copy matches the actual data source and gives users the appropriate next step. ## Provenance - **Authored by:** interactive session - **Verified:** targeted MissingNodeCard tests, format check, lint, typecheck, knip, and locale check - **Deviations:** none ## Reviewer context - **Type:** bug fix for missing-core-node guidance - **Slots into:** right-side-panel workflow issue reporting - **Not in scope:** core-node metadata detection or workflow serialization ## Summary Clarify that missing core nodes may require a newer ComfyUI version and that the displayed version is the current installation. ## Changes - **What:** Replace the misleading workflow-creation wording with update guidance. - **Localization:** Replace the old keys so the release translation pipeline queues the new copy and prunes the obsolete translations. ## Review Focus Confirm that the warning distinguishes the current installed version from the required versions listed for missing core nodes. ## Test plan - MissingNodeCard unit tests: 21 passed - pnpm format:check - pnpm lint: 0 errors - pnpm typecheck - pnpm knip - pnpm locale:check: new keys queued for translation; 0 protected-token violations ## Screenshots Before <img width="569" height="127" alt="스크린샷 2026-08-28 오후 1 30 32" src="https://github.com/user-attachments/assets/f5d00960-f4f0-4101-92c8-a9206d03539b" /> After <img width="558" height="111" alt="스크린샷 2026-08-28 오후 1 30 42" src="https://github.com/user-attachments/assets/73767250-d76c-4b11-b2ac-5267502d0bd2" />
comfy-pr-bot
enabled auto-merge
August 28, 2026 09:59
Contributor
🎭 Playwright: 🕵🏻 0 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.51 #16179 +/- ##
=============================================
Coverage ? 73.31%
=============================================
Files ? 1801
Lines ? 95986
Branches ? 26924
=============================================
Hits ? 70373
Misses ? 25449
Partials ? 164
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
auto-merge was automatically disabled
August 28, 2026 15:44
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #16166 to
cloud/1.51Automatically created by backport workflow.