Skip to content

[backport cloud/1.51] fix: clarify missing core node version warning - #16179

Closed
comfy-pr-bot wants to merge 1 commit into
cloud/1.51from
backport-16166-to-cloud-1.51
Closed

comfy-pr-bot wants to merge 1 commit into
cloud/1.51from
backport-16166-to-cloud-1.51

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16166 to cloud/1.51

Automatically created by backport workflow.

## ELI5

The warning says a workflow was created with a newer ComfyUI version,
but the number shown is actually the currently installed backend
version. This changes the warning to say that some missing core nodes
require a newer ComfyUI version and asks the user to update.

## Motivation

MissingNodeCard receives the current ComfyUI version from /system_stats.
Describing that value as the workflow creation version is misleading.
The new copy matches the actual data source and gives users the
appropriate next step.

## Provenance

- **Authored by:** interactive session
- **Verified:** targeted MissingNodeCard tests, format check, lint,
typecheck, knip, and locale check
- **Deviations:** none

## Reviewer context

- **Type:** bug fix for missing-core-node guidance
- **Slots into:** right-side-panel workflow issue reporting
- **Not in scope:** core-node metadata detection or workflow
serialization

## Summary

Clarify that missing core nodes may require a newer ComfyUI version and
that the displayed version is the current installation.

## Changes

- **What:** Replace the misleading workflow-creation wording with update
guidance.
- **Localization:** Replace the old keys so the release translation
pipeline queues the new copy and prunes the obsolete translations.

## Review Focus

Confirm that the warning distinguishes the current installed version
from the required versions listed for missing core nodes.

## Test plan

- MissingNodeCard unit tests: 21 passed
- pnpm format:check
- pnpm lint: 0 errors
- pnpm typecheck
- pnpm knip
- pnpm locale:check: new keys queued for translation; 0 protected-token
violations

## Screenshots

Before
<img width="569" height="127" alt="스크린샷 2026-08-28 오후 1 30 32"
src="https://github.com/user-attachments/assets/f5d00960-f4f0-4101-92c8-a9206d03539b"
/>

After
<img width="558" height="111" alt="스크린샷 2026-08-28 오후 1 30 42"
src="https://github.com/user-attachments/assets/73767250-d76c-4b11-b2ac-5267502d0bd2"
/>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 28, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge August 28, 2026 09:59
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 28, 2026
@github-actions

github-actions Bot commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: 🕵🏻 0 passed, 0 failed

📊 Browser Reports
  • chromium: ❌ Deployment failed
  • chromium-2x: ❌ Deployment failed
  • chromium-0.5x: ❌ Deployment failed
  • mobile-chrome: ❌ Deployment failed

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/28/2026, 10:01:41 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance

⚠️ Performance tests failed. Check the CI workflow logs.

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 28, 2026
@github-actions
github-actions Bot requested a review from thedatalife August 28, 2026 10:00
@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.51   #16179   +/-   ##
=============================================
  Coverage              ?   73.31%           
=============================================
  Files                 ?     1801           
  Lines                 ?    95986           
  Branches              ?    26924           
=============================================
  Hits                  ?    70373           
  Misses                ?    25449           
  Partials              ?      164           
Flag Coverage Δ
unit 73.31% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...mponents/rightSidePanel/errors/MissingNodeCard.vue 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaeone94 jaeone94 closed this Aug 28, 2026
auto-merge was automatically disabled August 28, 2026 15:44

Pull request was closed

@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants