Skip to content

[backport cloud/1.51] fix: clarify missing core node version warning (#16166) - #16734

Merged
christian-byrne merged 1 commit into
cloud/1.51from
christian-byrne/bkp-4-cloud-1.51-warning
Sep 4, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.51from
christian-byrne/bkp-4-cloud-1.51-warning

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backports the wording fix from #16166 to cloud/1.51; the prior automated backport #16179 closed unmerged and its branch was deleted.

Changes

  • What: Clarifies that workflows created with newer ComfyUI versions may require a newer frontend version.

Review Focus

Confirm the cloud/1.51 warning copy matches the merged source fix.

Evidence

  • NODE_OPTIONS="--no-experimental-webstorage" pnpm exec vitest run src/components/rightSidePanel/errors/MissingNodeCard.test.ts — 21 tests passed.
  • pnpm exec oxfmt --check src/components/rightSidePanel/errors/MissingNodeCard.test.ts src/components/rightSidePanel/errors/MissingNodeCard.vue src/locales/en/main.json — all matched files correctly formatted.
  • pnpm exec oxlint src/components/rightSidePanel/errors/MissingNodeCard.test.ts src/components/rightSidePanel/errors/MissingNodeCard.vue — 0 warnings, 0 errors.

## ELI5

The warning says a workflow was created with a newer ComfyUI version,
but the number shown is actually the currently installed backend
version. This changes the warning to say that some missing core nodes
require a newer ComfyUI version and asks the user to update.

## Motivation

MissingNodeCard receives the current ComfyUI version from /system_stats.
Describing that value as the workflow creation version is misleading.
The new copy matches the actual data source and gives users the
appropriate next step.

## Provenance

- **Authored by:** interactive session
- **Verified:** targeted MissingNodeCard tests, format check, lint,
typecheck, knip, and locale check
- **Deviations:** none

## Reviewer context

- **Type:** bug fix for missing-core-node guidance
- **Slots into:** right-side-panel workflow issue reporting
- **Not in scope:** core-node metadata detection or workflow
serialization

## Summary

Clarify that missing core nodes may require a newer ComfyUI version and
that the displayed version is the current installation.

## Changes

- **What:** Replace the misleading workflow-creation wording with update
guidance.
- **Localization:** Replace the old keys so the release translation
pipeline queues the new copy and prunes the obsolete translations.

## Review Focus

Confirm that the warning distinguishes the current installed version
from the required versions listed for missing core nodes.

## Test plan

- MissingNodeCard unit tests: 21 passed
- pnpm format:check
- pnpm lint: 0 errors
- pnpm typecheck
- pnpm knip
- pnpm locale:check: new keys queued for translation; 0 protected-token
violations

## Screenshots

Before
<img width="569" height="127" alt="스크린샷 2026-08-28 오후 1 30 32"
src="https://github.com/user-attachments/assets/f5d00960-f4f0-4101-92c8-a9206d03539b"
/>

After
<img width="558" height="111" alt="스크린샷 2026-08-28 오후 1 30 42"
src="https://github.com/user-attachments/assets/73767250-d76c-4b11-b2ac-5267502d0bd2"
/>

(cherry picked from commit 89ad1c5)
@christian-byrne christian-byrne added the risk:R1 PR risk grade (advisory shadow check; grader-owned) label Sep 3, 2026
@christian-byrne christian-byrne self-assigned this Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1823 passed, 0 failed · 5 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1802 / ❌ 0 / ⚠️ 5 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/03/2026, 03:14:25 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 12ms TBT · 63.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 35ms TBT · 52.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 96ms TBT · 76.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap
vue-large-graph-idle: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 164.3 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 179.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 333ms
canvas-idle: script duration 6ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.4 MB
canvas-idle: DOM nodes 21
canvas-idle: event listeners 6
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 22ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 72
canvas-mouse-sweep: task duration 633ms
canvas-mouse-sweep: script duration 67ms
canvas-mouse-sweep: TBT 12ms
canvas-mouse-sweep: heap used 63.4 MB
canvas-mouse-sweep: DOM nodes 57
canvas-mouse-sweep: event listeners 4
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 12ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 33
canvas-zoom-sweep: task duration 269ms
canvas-zoom-sweep: script duration 7ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.5 MB
canvas-zoom-sweep: DOM nodes 79
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 4ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 315ms
dom-widget-clipping: script duration 34ms
dom-widget-clipping: TBT 35ms
dom-widget-clipping: heap used 52.6 MB
dom-widget-clipping: DOM nodes 16
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 431ms
large-graph-idle: script duration 10ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 61.9 MB
large-graph-idle: DOM nodes -280
large-graph-idle: event listeners -178
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 836ms
large-graph-pan: script duration 218ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 76.9 MB
large-graph-pan: DOM nodes -285
large-graph-pan: event listeners -164
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 6ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 67
large-graph-zoom: task duration 922ms
large-graph-zoom: script duration 241ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 65.1 MB
large-graph-zoom: DOM nodes 18
large-graph-zoom: event listeners -70
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 436ms
minimap-idle: script duration 11ms
minimap-idle: TBT 0ms
minimap-idle: heap used 61.4 MB
minimap-idle: DOM nodes -283
minimap-idle: event listeners -177
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 281ms
subgraph-dom-widget-clipping: script duration 78ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 53.9 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 5ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 339ms
subgraph-idle: script duration 5ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 70.8 MB
subgraph-idle: DOM nodes 20
subgraph-idle: event listeners 6
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 23ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 524ms
subgraph-mouse-sweep: script duration 52ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 61.7 MB
subgraph-mouse-sweep: DOM nodes 66
subgraph-mouse-sweep: event listeners 4
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 8ms
subgraph-transition-enter: style recalc duration 22ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 670ms
subgraph-transition-enter: script duration 12ms
subgraph-transition-enter: TBT 96ms
subgraph-transition-enter: heap used 76.5 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2373
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 30ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 2873ms
viewport-pan-sweep: script duration 697ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 63.1 MB
viewport-pan-sweep: DOM nodes -281
viewport-pan-sweep: event listeners -133
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 10572ms
vue-large-graph-idle: script duration 78ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 164.3 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16391
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 71
vue-large-graph-pan: task duration 13839ms
vue-large-graph-pan: script duration 383ms
vue-large-graph-pan: TBT 0ms
vue-large-graph-pan: heap used 179.1 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16388
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 0ms
workflow-execution: style recalc duration 12ms
workflow-execution: layout count 2
workflow-execution: style recalc count 15
workflow-execution: task duration 77ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.4 MB
workflow-execution: DOM nodes 127
workflow-execution: event listeners 99
Raw data
{
  "timestamp": "2026-09-03T03:23:54.977Z",
  "gitSha": "3cab5bd44a315bd56396db6df87ede21a90312d1",
  "branch": "christian-byrne/bkp-4-cloud-1.51-warning",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 1997.9890000000182,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.282,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 337.56800000000004,
      "heapDeltaBytes": 3454852,
      "heapUsedBytes": 69390008,
      "domNodes": 20,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 5.821999999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2006.0249999999087,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.75,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 329.14099999999996,
      "heapDeltaBytes": 5480584,
      "heapUsedBytes": 71991020,
      "domNodes": 22,
      "jsHeapTotalBytes": 23592960,
      "scriptDurationMs": 5.433000000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1829.4519999999466,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 22.431,
      "layouts": 12,
      "layoutDurationMs": 2.669,
      "taskDurationMs": 718.459,
      "heapDeltaBytes": 149500,
      "heapUsedBytes": 66524072,
      "domNodes": 56,
      "jsHeapTotalBytes": 24907776,
      "scriptDurationMs": 69.48000000000002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 23,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1701.0329999999385,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 22.131,
      "layouts": 12,
      "layoutDurationMs": 2.504,
      "taskDurationMs": 547.824,
      "heapDeltaBytes": 98748,
      "heapUsedBytes": 66438916,
      "domNodes": 57,
      "jsHeapTotalBytes": 25432064,
      "scriptDurationMs": 64.63000000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1687.310000000025,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 11.780000000000003,
      "layouts": 6,
      "layoutDurationMs": 0.62,
      "taskDurationMs": 270.97,
      "heapDeltaBytes": 8330712,
      "heapUsedBytes": 74772748,
      "domNodes": 80,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 6.982000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1708.9879999999766,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 11.353,
      "layouts": 6,
      "layoutDurationMs": 0.512,
      "taskDurationMs": 267.72300000000007,
      "heapDeltaBytes": 8416756,
      "heapUsedBytes": 75073656,
      "domNodes": 78,
      "jsHeapTotalBytes": 23592960,
      "scriptDurationMs": 7.928000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 554.631000000029,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 3.547999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 374.76200000000006,
      "heapDeltaBytes": -11820772,
      "heapUsedBytes": 54517984,
      "domNodes": 12,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 34.31,
      "eventListeners": 2,
      "totalBlockingTimeMs": 70,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 413.560000000075,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.219000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 254.63600000000002,
      "heapDeltaBytes": -10721160,
      "heapUsedBytes": 55717260,
      "domNodes": 20,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 33.248,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2019.3810000000099,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.759000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 431.96900000000005,
      "heapDeltaBytes": 2599396,
      "heapUsedBytes": 64073768,
      "domNodes": -280,
      "jsHeapTotalBytes": 2453504,
      "scriptDurationMs": 10.329,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2006.2880000000405,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.251000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 430.61699999999996,
      "heapDeltaBytes": 4204240,
      "heapUsedBytes": 65761628,
      "domNodes": -280,
      "jsHeapTotalBytes": 1929216,
      "scriptDurationMs": 10.499,
      "eventListeners": -177,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2112.493000000029,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 10.944,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 828.0719999999999,
      "heapDeltaBytes": 17799704,
      "heapUsedBytes": 81802756,
      "domNodes": -283,
      "jsHeapTotalBytes": 4481024,
      "scriptDurationMs": 212.198,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2082.9629999999497,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 9.644,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 843.7330000000001,
      "heapDeltaBytes": 17478104,
      "heapUsedBytes": 79539948,
      "domNodes": -287,
      "jsHeapTotalBytes": 3694592,
      "scriptDurationMs": 223.42999999999998,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3104.8720000000003,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.874,
      "layouts": 60,
      "layoutDurationMs": 6.1419999999999995,
      "taskDurationMs": 955.2669999999999,
      "heapDeltaBytes": -8172892,
      "heapUsedBytes": 54944764,
      "domNodes": 18,
      "jsHeapTotalBytes": 2977792,
      "scriptDurationMs": 243.30800000000002,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3022.557000000006,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.274999999999999,
      "layouts": 60,
      "layoutDurationMs": 6.0889999999999995,
      "taskDurationMs": 888.262,
      "heapDeltaBytes": 16495628,
      "heapUsedBytes": 81585792,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 238.752,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2022.2530000000347,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.135999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 424.716,
      "heapDeltaBytes": 3153568,
      "heapUsedBytes": 65284352,
      "domNodes": -283,
      "jsHeapTotalBytes": 2977792,
      "scriptDurationMs": 10.875,
      "eventListeners": -177,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 1990.3470000000425,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.875000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 447.58599999999996,
      "heapDeltaBytes": 1616236,
      "heapUsedBytes": 63563216,
      "domNodes": -282,
      "jsHeapTotalBytes": 2453504,
      "scriptDurationMs": 11.129999999999997,
      "eventListeners": -177,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 424.49000000004844,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 6.751999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 261.895,
      "heapDeltaBytes": -10012408,
      "heapUsedBytes": 56631308,
      "domNodes": 22,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 70.898,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 505.8799999999337,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.300000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 300.987,
      "heapDeltaBytes": -10167036,
      "heapUsedBytes": 56457892,
      "domNodes": 20,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 84.407,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1999.7250000000122,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.155999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 355.951,
      "heapDeltaBytes": 5415612,
      "heapUsedBytes": 71630180,
      "domNodes": 18,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 5.313,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2003.1910000000153,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.492999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 321.335,
      "heapDeltaBytes": 5834812,
      "heapUsedBytes": 76763324,
      "domNodes": 22,
      "jsHeapTotalBytes": 18452480,
      "scriptDurationMs": 4.9769999999999985,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1701.8880000000536,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 23.131999999999998,
      "layouts": 16,
      "layoutDurationMs": 2.796,
      "taskDurationMs": 517.2869999999999,
      "heapDeltaBytes": -3451676,
      "heapUsedBytes": 62952500,
      "domNodes": 67,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 51.166999999999994,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1684.1779999999744,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 23.793000000000003,
      "layouts": 16,
      "layoutDurationMs": 2.8019999999999996,
      "taskDurationMs": 529.8009999999999,
      "heapDeltaBytes": -3867940,
      "heapUsedBytes": 66382276,
      "domNodes": 65,
      "jsHeapTotalBytes": 19763200,
      "scriptDurationMs": 52.199,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 882.6780000000554,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 21.846000000000004,
      "layouts": 16,
      "layoutDurationMs": 7.962999999999999,
      "taskDurationMs": 669.905,
      "heapDeltaBytes": -5953832,
      "heapUsedBytes": 80214228,
      "domNodes": 13673,
      "jsHeapTotalBytes": 8912896,
      "scriptDurationMs": 12.465000000000003,
      "eventListeners": 2373,
      "totalBlockingTimeMs": 96,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8112.191999999994,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 27.889999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2823.855,
      "heapDeltaBytes": 5544256,
      "heapUsedBytes": 66169588,
      "domNodes": -282,
      "jsHeapTotalBytes": 3432448,
      "scriptDurationMs": 685.433,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8097.862000000077,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 32.580999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2922.192,
      "heapDeltaBytes": 5166100,
      "heapUsedBytes": 66144388,
      "domNodes": -280,
      "jsHeapTotalBytes": 4218880,
      "scriptDurationMs": 708.723,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10646.519000000011,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9890.812,
      "heapDeltaBytes": -43645280,
      "heapUsedBytes": 169949968,
      "domNodes": -8312,
      "jsHeapTotalBytes": -14094336,
      "scriptDurationMs": 67.36200000000001,
      "eventListeners": -16391,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12160.258999999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11252.192000000001,
      "heapDeltaBytes": -25084684,
      "heapUsedBytes": 174586620,
      "domNodes": -8312,
      "jsHeapTotalBytes": -7802880,
      "scriptDurationMs": 87.898,
      "eventListeners": -16391,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14564.560000000029,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 17.140000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13845.485,
      "heapDeltaBytes": -35591084,
      "heapUsedBytes": 191402268,
      "domNodes": -8312,
      "jsHeapTotalBytes": -7348224,
      "scriptDurationMs": 375.44,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14464.451000000054,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 14.556999999999986,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13831.838000000002,
      "heapDeltaBytes": -30098912,
      "heapUsedBytes": 184129884,
      "domNodes": -8312,
      "jsHeapTotalBytes": -15736832,
      "scriptDurationMs": 389.82500000000005,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 427.846000000045,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 11.645,
      "layouts": 2,
      "layoutDurationMs": 0.33699999999999997,
      "taskDurationMs": 82.26200000000001,
      "heapDeltaBytes": 5045868,
      "heapUsedBytes": 70810332,
      "domNodes": 128,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 5.835000000000001,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "workflow-execution",
      "durationMs": 430.8650000000398,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 11.783999999999999,
      "layouts": 2,
      "layoutDurationMs": 0.298,
      "taskDurationMs": 70.81,
      "heapDeltaBytes": 4994496,
      "heapUsedBytes": 70621228,
      "domNodes": 125,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 5.112,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    }
  ]
}

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: d28b371b-09f0-463e-835b-50558ffab1e5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added risk:R2 PR risk grade (advisory shadow check; grader-owned) and removed risk:R1 PR risk grade (advisory shadow check; grader-owned) labels Sep 3, 2026
@github-actions
github-actions Bot requested a review from DrJKL September 3, 2026 03:13
@christian-byrne
christian-byrne removed the request for review from DrJKL September 3, 2026 03:14
@github-actions
github-actions Bot requested a review from DrJKL September 3, 2026 03:14
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff               @@
##           cloud/1.51   #16734      +/-   ##
==============================================
+ Coverage       79.15%   81.71%   +2.55%     
==============================================
  Files            2218     1891     -327     
  Lines          113239   108336    -4903     
  Branches        31726    30087    -1639     
==============================================
- Hits            89633    88525    -1108     
+ Misses          23147    19462    -3685     
+ Partials          459      349     -110     
Flag Coverage Δ
unit 73.35% <ø> (+<0.01%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...mponents/rightSidePanel/errors/MissingNodeCard.vue 100.00% <ø> (ø)

... and 327 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: ready to approve

I compared this hand-authored backport of #16166 with merged source commit 89ad1c5. The stable patch IDs match with no content adaptation. Every i18n key referenced by MissingNodeCard.vue exists on cloud/1.51; missing non-English translations fall back to English until the release translation workflow updates them. The corrected wording describes the installed backend version accurately and is an appropriate low-risk patch fix. pnpm typecheck, scoped ESLint, scoped oxfmt, 21 targeted tests, and pnpm locale:check passed. Hosted checks are green apart from a cancelled duplicate binary-size job whose replacement passed. I found no blocking issues.

Comment thread src/locales/en/main.json
"loadWorkflowWarning": {
"outdatedVersion": "This workflow was created with a newer version of ComfyUI ({version}). Some nodes may not work correctly.",
"outdatedVersionGeneric": "This workflow was created with a newer version of ComfyUI. Some nodes may not work correctly.",
"newerVersionRequired": "Some nodes require a newer version of ComfyUI (current: {version}). Please update to use all nodes.",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice if we could list the nodes somewhere.

@DrJKL

DrJKL commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

1.51?

@christian-byrne
christian-byrne added this pull request to the merge queue Sep 4, 2026
Merged via the queue into cloud/1.51 with commit 362816d Sep 4, 2026
82 of 83 checks passed
@christian-byrne
christian-byrne deleted the christian-byrne/bkp-4-cloud-1.51-warning branch September 4, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:R2 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants