Repository navigation
[backport cloud/1.51] fix: clarify missing core node version warning (#16166) - #16734
Conversation
## ELI5 The warning says a workflow was created with a newer ComfyUI version, but the number shown is actually the currently installed backend version. This changes the warning to say that some missing core nodes require a newer ComfyUI version and asks the user to update. ## Motivation MissingNodeCard receives the current ComfyUI version from /system_stats. Describing that value as the workflow creation version is misleading. The new copy matches the actual data source and gives users the appropriate next step. ## Provenance - **Authored by:** interactive session - **Verified:** targeted MissingNodeCard tests, format check, lint, typecheck, knip, and locale check - **Deviations:** none ## Reviewer context - **Type:** bug fix for missing-core-node guidance - **Slots into:** right-side-panel workflow issue reporting - **Not in scope:** core-node metadata detection or workflow serialization ## Summary Clarify that missing core nodes may require a newer ComfyUI version and that the displayed version is the current installation. ## Changes - **What:** Replace the misleading workflow-creation wording with update guidance. - **Localization:** Replace the old keys so the release translation pipeline queues the new copy and prunes the obsolete translations. ## Review Focus Confirm that the warning distinguishes the current installed version from the required versions listed for missing core nodes. ## Test plan - MissingNodeCard unit tests: 21 passed - pnpm format:check - pnpm lint: 0 errors - pnpm typecheck - pnpm knip - pnpm locale:check: new keys queued for translation; 0 protected-token violations ## Screenshots Before <img width="569" height="127" alt="스크린샷 2026-08-28 오후 1 30 32" src="https://github.com/user-attachments/assets/f5d00960-f4f0-4101-92c8-a9206d03539b" /> After <img width="558" height="111" alt="스크린샷 2026-08-28 오후 1 30 42" src="https://github.com/user-attachments/assets/73767250-d76c-4b11-b2ac-5267502d0bd2" /> (cherry picked from commit 89ad1c5)
🎭 Playwright: ✅ 1823 passed, 0 failed · 5 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-03T03:23:54.977Z",
"gitSha": "3cab5bd44a315bd56396db6df87ede21a90312d1",
"branch": "christian-byrne/bkp-4-cloud-1.51-warning",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1997.9890000000182,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.282,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.56800000000004,
"heapDeltaBytes": 3454852,
"heapUsedBytes": 69390008,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 5.821999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2006.0249999999087,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.75,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.14099999999996,
"heapDeltaBytes": 5480584,
"heapUsedBytes": 71991020,
"domNodes": 22,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 5.433000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1829.4519999999466,
"styleRecalcs": 72,
"styleRecalcDurationMs": 22.431,
"layouts": 12,
"layoutDurationMs": 2.669,
"taskDurationMs": 718.459,
"heapDeltaBytes": 149500,
"heapUsedBytes": 66524072,
"domNodes": 56,
"jsHeapTotalBytes": 24907776,
"scriptDurationMs": 69.48000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 23,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1701.0329999999385,
"styleRecalcs": 72,
"styleRecalcDurationMs": 22.131,
"layouts": 12,
"layoutDurationMs": 2.504,
"taskDurationMs": 547.824,
"heapDeltaBytes": 98748,
"heapUsedBytes": 66438916,
"domNodes": 57,
"jsHeapTotalBytes": 25432064,
"scriptDurationMs": 64.63000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1687.310000000025,
"styleRecalcs": 33,
"styleRecalcDurationMs": 11.780000000000003,
"layouts": 6,
"layoutDurationMs": 0.62,
"taskDurationMs": 270.97,
"heapDeltaBytes": 8330712,
"heapUsedBytes": 74772748,
"domNodes": 80,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 6.982000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.9879999999766,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.353,
"layouts": 6,
"layoutDurationMs": 0.512,
"taskDurationMs": 267.72300000000007,
"heapDeltaBytes": 8416756,
"heapUsedBytes": 75073656,
"domNodes": 78,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 7.928000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 554.631000000029,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.547999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.76200000000006,
"heapDeltaBytes": -11820772,
"heapUsedBytes": 54517984,
"domNodes": 12,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 34.31,
"eventListeners": 2,
"totalBlockingTimeMs": 70,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 413.560000000075,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.219000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 254.63600000000002,
"heapDeltaBytes": -10721160,
"heapUsedBytes": 55717260,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 33.248,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2019.3810000000099,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.759000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.96900000000005,
"heapDeltaBytes": 2599396,
"heapUsedBytes": 64073768,
"domNodes": -280,
"jsHeapTotalBytes": 2453504,
"scriptDurationMs": 10.329,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2006.2880000000405,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.251000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.61699999999996,
"heapDeltaBytes": 4204240,
"heapUsedBytes": 65761628,
"domNodes": -280,
"jsHeapTotalBytes": 1929216,
"scriptDurationMs": 10.499,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2112.493000000029,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.944,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 828.0719999999999,
"heapDeltaBytes": 17799704,
"heapUsedBytes": 81802756,
"domNodes": -283,
"jsHeapTotalBytes": 4481024,
"scriptDurationMs": 212.198,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2082.9629999999497,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.644,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 843.7330000000001,
"heapDeltaBytes": 17478104,
"heapUsedBytes": 79539948,
"domNodes": -287,
"jsHeapTotalBytes": 3694592,
"scriptDurationMs": 223.42999999999998,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3104.8720000000003,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.874,
"layouts": 60,
"layoutDurationMs": 6.1419999999999995,
"taskDurationMs": 955.2669999999999,
"heapDeltaBytes": -8172892,
"heapUsedBytes": 54944764,
"domNodes": 18,
"jsHeapTotalBytes": 2977792,
"scriptDurationMs": 243.30800000000002,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3022.557000000006,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.274999999999999,
"layouts": 60,
"layoutDurationMs": 6.0889999999999995,
"taskDurationMs": 888.262,
"heapDeltaBytes": 16495628,
"heapUsedBytes": 81585792,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 238.752,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2022.2530000000347,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.135999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.716,
"heapDeltaBytes": 3153568,
"heapUsedBytes": 65284352,
"domNodes": -283,
"jsHeapTotalBytes": 2977792,
"scriptDurationMs": 10.875,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1990.3470000000425,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.875000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.58599999999996,
"heapDeltaBytes": 1616236,
"heapUsedBytes": 63563216,
"domNodes": -282,
"jsHeapTotalBytes": 2453504,
"scriptDurationMs": 11.129999999999997,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 424.49000000004844,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.751999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 261.895,
"heapDeltaBytes": -10012408,
"heapUsedBytes": 56631308,
"domNodes": 22,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 70.898,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 505.8799999999337,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.300000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 300.987,
"heapDeltaBytes": -10167036,
"heapUsedBytes": 56457892,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 84.407,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1999.7250000000122,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.155999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.951,
"heapDeltaBytes": 5415612,
"heapUsedBytes": 71630180,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 5.313,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2003.1910000000153,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.492999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.335,
"heapDeltaBytes": 5834812,
"heapUsedBytes": 76763324,
"domNodes": 22,
"jsHeapTotalBytes": 18452480,
"scriptDurationMs": 4.9769999999999985,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1701.8880000000536,
"styleRecalcs": 78,
"styleRecalcDurationMs": 23.131999999999998,
"layouts": 16,
"layoutDurationMs": 2.796,
"taskDurationMs": 517.2869999999999,
"heapDeltaBytes": -3451676,
"heapUsedBytes": 62952500,
"domNodes": 67,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 51.166999999999994,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1684.1779999999744,
"styleRecalcs": 77,
"styleRecalcDurationMs": 23.793000000000003,
"layouts": 16,
"layoutDurationMs": 2.8019999999999996,
"taskDurationMs": 529.8009999999999,
"heapDeltaBytes": -3867940,
"heapUsedBytes": 66382276,
"domNodes": 65,
"jsHeapTotalBytes": 19763200,
"scriptDurationMs": 52.199,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 882.6780000000554,
"styleRecalcs": 21,
"styleRecalcDurationMs": 21.846000000000004,
"layouts": 16,
"layoutDurationMs": 7.962999999999999,
"taskDurationMs": 669.905,
"heapDeltaBytes": -5953832,
"heapUsedBytes": 80214228,
"domNodes": 13673,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 12.465000000000003,
"eventListeners": 2373,
"totalBlockingTimeMs": 96,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8112.191999999994,
"styleRecalcs": 249,
"styleRecalcDurationMs": 27.889999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2823.855,
"heapDeltaBytes": 5544256,
"heapUsedBytes": 66169588,
"domNodes": -282,
"jsHeapTotalBytes": 3432448,
"scriptDurationMs": 685.433,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8097.862000000077,
"styleRecalcs": 249,
"styleRecalcDurationMs": 32.580999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2922.192,
"heapDeltaBytes": 5166100,
"heapUsedBytes": 66144388,
"domNodes": -280,
"jsHeapTotalBytes": 4218880,
"scriptDurationMs": 708.723,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10646.519000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9890.812,
"heapDeltaBytes": -43645280,
"heapUsedBytes": 169949968,
"domNodes": -8312,
"jsHeapTotalBytes": -14094336,
"scriptDurationMs": 67.36200000000001,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12160.258999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11252.192000000001,
"heapDeltaBytes": -25084684,
"heapUsedBytes": 174586620,
"domNodes": -8312,
"jsHeapTotalBytes": -7802880,
"scriptDurationMs": 87.898,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14564.560000000029,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.140000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13845.485,
"heapDeltaBytes": -35591084,
"heapUsedBytes": 191402268,
"domNodes": -8312,
"jsHeapTotalBytes": -7348224,
"scriptDurationMs": 375.44,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14464.451000000054,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.556999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13831.838000000002,
"heapDeltaBytes": -30098912,
"heapUsedBytes": 184129884,
"domNodes": -8312,
"jsHeapTotalBytes": -15736832,
"scriptDurationMs": 389.82500000000005,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 427.846000000045,
"styleRecalcs": 15,
"styleRecalcDurationMs": 11.645,
"layouts": 2,
"layoutDurationMs": 0.33699999999999997,
"taskDurationMs": 82.26200000000001,
"heapDeltaBytes": 5045868,
"heapUsedBytes": 70810332,
"domNodes": 128,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 5.835000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 430.8650000000398,
"styleRecalcs": 14,
"styleRecalcDurationMs": 11.783999999999999,
"layouts": 2,
"layoutDurationMs": 0.298,
"taskDurationMs": 70.81,
"heapDeltaBytes": 4994496,
"heapUsedBytes": 70621228,
"domNodes": 125,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 5.112,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.51 #16734 +/- ##
==============================================
+ Coverage 79.15% 81.71% +2.55%
==============================================
Files 2218 1891 -327
Lines 113239 108336 -4903
Branches 31726 30087 -1639
==============================================
- Hits 89633 88525 -1108
+ Misses 23147 19462 -3685
+ Partials 459 349 -110
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 327 files with indirect coverage changes 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
I compared this hand-authored backport of #16166 with merged source commit 89ad1c5. The stable patch IDs match with no content adaptation. Every i18n key referenced by MissingNodeCard.vue exists on cloud/1.51; missing non-English translations fall back to English until the release translation workflow updates them. The corrected wording describes the installed backend version accurately and is an appropriate low-risk patch fix. pnpm typecheck, scoped ESLint, scoped oxfmt, 21 targeted tests, and pnpm locale:check passed. Hosted checks are green apart from a cancelled duplicate binary-size job whose replacement passed. I found no blocking issues.
| "loadWorkflowWarning": { | ||
| "outdatedVersion": "This workflow was created with a newer version of ComfyUI ({version}). Some nodes may not work correctly.", | ||
| "outdatedVersionGeneric": "This workflow was created with a newer version of ComfyUI. Some nodes may not work correctly.", | ||
| "newerVersionRequired": "Some nodes require a newer version of ComfyUI (current: {version}). Please update to use all nodes.", |
There was a problem hiding this comment.
It'd be nice if we could list the nodes somewhere.
|
1.51? |
Summary
Backports the wording fix from #16166 to
cloud/1.51; the prior automated backport #16179 closed unmerged and its branch was deleted.Changes
Review Focus
Confirm the
cloud/1.51warning copy matches the merged source fix.Evidence
NODE_OPTIONS="--no-experimental-webstorage" pnpm exec vitest run src/components/rightSidePanel/errors/MissingNodeCard.test.ts— 21 tests passed.pnpm exec oxfmt --check src/components/rightSidePanel/errors/MissingNodeCard.test.ts src/components/rightSidePanel/errors/MissingNodeCard.vue src/locales/en/main.json— all matched files correctly formatted.pnpm exec oxlint src/components/rightSidePanel/errors/MissingNodeCard.test.ts src/components/rightSidePanel/errors/MissingNodeCard.vue— 0 warnings, 0 errors.