Repository navigation
test: retain CDP task accounting metrics - #16016
Conversation
|
Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2013 passed, 0 failed📊 Browser Reports
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## test/perf-in-window-raf #16016 +/- ##
===========================================================
+ Coverage 82.59% 82.61% +0.01%
===========================================================
Files 1941 1942 +1
Lines 111783 111758 -25
Branches 32275 32298 +23
===========================================================
- Hits 92326 92325 -1
+ Misses 19113 19095 -18
+ Partials 344 338 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 64 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
|
|
@coderabbitai review |
|
## Summary Stacked on #16016/#15997. Add schema-v4, per-measurement workload identity so results are comparable only when topology and environment denominators match. ## Identity and privacy Includes anonymized topology hash/counts, renderer/settings, viewport/DPR, frontend/build/browser identity, coarse GPU classification, and explicit nullable activity fields. Raw node IDs, types, labels, widget values, prompts, paths, workflow content, and raw GPU strings are excluded. Dirty-reason keys are allowlisted and counts sanitized. ## Verification Identity + CDP tests 9/9; Knip; browser/scripts typechecks; formatting; hooks and diff checks pass.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
benjcooley
left a comment
There was a problem hiding this comment.
Requesting changes: the branch is stale/conflicting with its target and does not integrate the new metrics into the target's current typed report pipeline. Rebase onto test/perf-in-window-raf, preserve its measurement-result/rejection lifecycle, and extend the authoritative Zod schema so the new fields survive serialization.
| Severity | Count |
|---|---|
| BLOCKER | 2 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
The exact PR head also has no lint/unit/perf CI run; only ancillary checks ran.
Stacked on #16016/#15997. Add schema-v4, per-measurement workload identity so results are comparable only when topology and environment denominators match. Includes anonymized topology hash/counts, renderer/settings, viewport/DPR, frontend/build/browser identity, coarse GPU classification, and explicit nullable activity fields. Raw node IDs, types, labels, widget values, prompts, paths, workflow content, and raw GPU strings are excluded. Dirty-reason keys are allowlisted and counts sanitized. Identity + CDP tests 9/9; Knip; browser/scripts typechecks; formatting; hooks and diff checks pass. Addresses review feedback: #16016 (comment)
Addresses review feedback: #16016 (comment)
2b1535c to
8f4f4e5
Compare
benjcooley
left a comment
There was a problem hiding this comment.
Requesting changes: the previous lifecycle/schema-preservation blockers are fixed, but the rebase left the report format version incompatible with existing v2 artifacts.
| Severity | Count |
|---|---|
| BLOCKER | 1 |
| SHOULD FIX | 1 |
| TRIVIAL | 0 |
SHOULD FIX: restore the new CDP/accounting fields to MetricKey and REPORTED_METRICS; they are retained in JSON now but never appear in baseline/history regression tables.
CI is broadly green, although the perf job log still contains 2 failed tests under a green workflow because that step is continue-on-error.
Full context for agent readersVerified at exact head Focused tests passed 15/15. A schema mutation deleting However, Ben's exact-head review found a substantive compatibility blocker: new required fields changed the v2 wire contract while Glossary: CDP = Chrome DevTools Protocol; Zod = runtime schema parser; wire contract = persisted JSON format; merge authority = the program's D-prl-authority rule for merging an eligible Christian-authored PR. |
Addresses review feedback: #16016 (comment)
Addresses review feedback: #16016 (review)
Addresses review feedback: #16016 (comment)
Full context for agent readersPushed exact head Commit evidence:
Compatibility mutation proof: deleting the v2 union arm failed the focused pre-change-artifact test; restoring it passed. Focused Vitest passed 17/17. Repository gates passed: typecheck, browser/scripts typechecks, lint, format, and knip. The two hidden perf failures are the same All human review threads remain unresolved for independent verification. No merge or approval action taken. Glossary: CDP = Chrome DevTools Protocol; v2/v3 = persisted report schema versions; |
benjcooley
left a comment
There was a problem hiding this comment.
Approved after re-review. The measurement-result lifecycle remains intact, v3 preserves real v2 artifacts as a new epoch, and all new CDP accounting metrics are retained and reported.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
The two performance-test failures reproduce on the target branch and are not introduced by this PR.
Summary
Stacked on #15997. Extend schema v3 so performance results retain Chromium task buckets and CPU counters without fabricating zeroes or unsupported native attribution.
Metrics
ThreadTime)ProcessTime)Required legacy metrics fail loudly; optional missing metrics remain null.
TaskOtherDurationis explicitly a broad renderer-main residual, not a native-stack attribution.Verification
5 deterministic unit controls, browser/scripts typechecks, Oxlint, Oxfmt, and diff checks pass.
Performance proof evidence
c0eac84f3bfea28f742fad59e59d0a1ff13b63c7:PATH=/home/c_byrne/.nvm/versions/node/v25.9.0/bin:$PATH \ NODE_OPTIONS=--localstorage-file=/tmp/codex-proof-wave-b-localstorage \ node_modules/.bin/vitest run src/utils/cdpPerformanceMetrics.test.ts4e37c20ebddbbe6a9936ebdfa663fd60c56e6a54, focused Vitest passed 17/17; typecheck, browser/scripts typechecks, lint, format, and Knip passed. Compatibility mutation proof confirmed that removing the v2 parser arm fails the pre-change-artifact test. Final GitHub state: merged at exact validated head4e37c20ebddbbe6a9936ebdfa663fd60c56e6a54on 2026-08-27; the fresh audit found no red or pending checks.