Repository navigation
test: add privacy-safe perf workload identity - #16023
Conversation
|
Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2013 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## test/perf-cdp-task-accounting #16023 +/- ##
=================================================================
+ Coverage 82.61% 82.62% +0.01%
=================================================================
Files 1942 1942
Lines 111756 111759 +3
Branches 32668 32182 -486
=================================================================
+ Hits 92323 92337 +14
+ Misses 19095 19072 -23
- Partials 338 350 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
|
|
@coderabbitai review |
|
benjcooley
left a comment
There was a problem hiding this comment.
Requesting changes: the real perf collection path is broken, and the new identity is not used to gate comparisons.
| Severity | Count |
|---|---|
| BLOCKER | 2 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
The perf CI timed out after every measurement-backed test failed; no perf artifact was produced.
Addresses review feedback: #16023 (comment)
Addresses review feedback: #16023 (comment)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Stale after both blockers were verified fixed.
Full context for agent readers
Exact remote head 469632ad2 reads Vite-provided page globals in Playwright and filters baseline/history/trend samples by comparable workload identity. Fresh-clone focused tests pass 42/42; bypassing identity filtering fails the mismatch detector. Current-head CI has no failed checks; this stacked branch reports no separately required checks.
2b1535c
into
test/perf-cdp-task-accounting
Stacked on #16016/#15997. Add schema-v4, per-measurement workload identity so results are comparable only when topology and environment denominators match. Includes anonymized topology hash/counts, renderer/settings, viewport/DPR, frontend/build/browser identity, coarse GPU classification, and explicit nullable activity fields. Raw node IDs, types, labels, widget values, prompts, paths, workflow content, and raw GPU strings are excluded. Dirty-reason keys are allowlisted and counts sanitized. Identity + CDP tests 9/9; Knip; browser/scripts typechecks; formatting; hooks and diff checks pass. Addresses review feedback: #16016 (comment)
Summary
Stacked on #16016/#15997. Add schema-v4, per-measurement workload identity so results are comparable only when topology and environment denominators match.
Identity and privacy
Includes anonymized topology hash/counts, renderer/settings, viewport/DPR, frontend/build/browser identity, coarse GPU classification, and explicit nullable activity fields. Raw node IDs, types, labels, widget values, prompts, paths, workflow content, and raw GPU strings are excluded. Dirty-reason keys are allowlisted and counts sanitized.
Verification
Identity + CDP tests 9/9; Knip; browser/scripts typechecks; formatting; hooks and diff checks pass.
Performance proof evidence
52f3f5d82f29a01bb6efb6179e95c5a7d3d61e6d:PATH=/home/c_byrne/.nvm/versions/node/v25.9.0/bin:$PATH \ NODE_OPTIONS=--localstorage-file=/tmp/codex-proof-wave-b-localstorage \ node_modules/.bin/vitest run \ scripts/perf-workload-identity.test.ts \ src/utils/cdpPerformanceMetrics.test.ts469632ad225f2facb59ad174aa842fc1d6796f33; the fresh audit found no red or pending checks. The exact local command above was run on the cited earlier revision.