Skip to content

[backport cloud/1.51] fix(workspace): establish workspace context for API-key sessions - #15951

Merged
comfy-pr-bot merged 1 commit into
cloud/1.51from
backport-15917-to-cloud-1.51
Aug 26, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.51from
backport-15917-to-cloud-1.51

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Backport of #15917 to cloud/1.51

Auto-backport failed on cherry-pick conflicts; backported manually. Conflict resolution: dropped the useBillingCapabilities import and test mock (#15803 is main-only) and ported the CurrentWorkspaceResponse block into this branch's generated ingest-types (absent from its older generation). Affected unit suites and pnpm typecheck pass on this branch.

)

API-key login sessions on Local never established workspace context, so
every billing surface fell back to the legacy user-scoped `/customers/*`
rail and showed a different customer's data than the one actually being
charged. Reported in 1.51 QA by Denys (Slack QA thread, Aug 25): empty
workspace name on Plan & Credits, balance always 0, wrong workspace in
Manage billing, credits 0 in the profile menu, Credits opening the old
combined view, purchase failing with `workspace_billing_required`, and
the Activity tab showing another workspace's events.

Two gates kept an API-key session off the workspace rail:

1. `WorkspaceAuthGate` (Local branch) only initialized
`teamWorkspaceStore` inside `watch(currentUser)`, where `currentUser` is
the **Firebase** user. API-key login never sets it, so `initState`
stayed `uninitialized` forever.
2. Even if initialization ran, `workspaceApi` auth
(`getWorkspaceAuthHeader`) fell back to `getFirebaseAuthHeader()` when
no workspace was active — `null` for API-key sessions, so every
workspace call threw `User not authenticated`. There was no `X-API-KEY`
fallback anywhere in the workspace client.

With `activeWorkspace` empty, `useBillingRouting` returned `legacy`, so
balance came from `GET /customers/balance` (the user's legacy customer —
zeros or a different account's credits), activity from `GET
/customers/events` (resolved by *user identity* to the canonical
migrated workspace, not the key's workspace), and top-up hit `POST
/customers/credit`, which the backend deterministically rejects with 409
`workspace_billing_required` for accounts on workspace billing
(`billing_legacy_topup.go`).

Meanwhile generation charges were always correct, because the backend
binds every API key to exactly one workspace (`workspace_api_keys`) —
only the frontend was reading the wrong rail.

The server already knows the key's workspace; the frontend now asks
instead of guessing. No backend changes — verified against staging with
real keys (`GET /api/workspaces/current` returns the bound workspace
incl. name/type/role for both personal and team keys, and all
`/api/billing/*` reads accept `X-API-KEY`, scoped to that workspace).

- `authStore.getWorkspaceAuthHeader` sends the stored API key when there
is no Firebase session; the key **is** the workspace credential, so no
token minting. `getWorkspaceAuthToken` returns `undefined` for key
sessions (unchanged behavior — no JWT exists to mint).
- `teamWorkspaceStore` bootstraps an API-key session from `GET
/api/workspaces/current`: seeds the single bound workspace, skips
session-cookie restore, discovery, and token exchange. An omitted `role`
fails closed to `member` so owner-only actions stay hidden instead of
403ing.
- `WorkspaceAuthGate` keys Local initialization off the session identity
(Firebase uid **or** validated API key) and resets workspace state when
that identity changes, so key→email transitions can't reuse stale
context.
- `CurrentUserPopoverWorkspace` renders a static workspace row for key
sessions — no switcher, matching the test-plan contract that API-key
auth exposes no workspace discovery/switching.

Once `initState` is `ready`, billing routing flips to the workspace rail
and all seven findings resolve together (name, balance ×2, portal, Plan
& Credits routing, top-up, activity).

- Regression (Vitest): `teamWorkspaceStore` API-key bootstrap (seeding,
no discovery/token-exchange, role fail-closed, retry-then-error),
`authStore` workspace-header priority (API key sent for key sessions,
Firebase session still wins when both exist), `WorkspaceAuthGate` (init
on key sign-in, cancel on key sign-out, reset on identity change).
- E2E user story (Playwright, `apiKeyLoginBilling.spec.ts` +
`apiKeyAuthFixture`): boots a key-only session, asserts the popover
shows the key's workspace and balance with no switcher, Plan & Credits
shows the workspace name/balance, Activity lists the workspace-rail
events, and **zero requests hit the legacy `/customers/balance` /
`/customers/events` rail**.

- Auth priority: the API-key fallback only applies when `currentUser ===
null`, so Firebase sessions (Local and Cloud) are untouched;
unified-cloud-auth branch is untouched.
- `resetForIdentityChange` on Local identity swaps is new — previously
only Firebase A→B triggered it (via authStore); now key⇄email
transitions do too.

Captured on a real Local app (`--comfy-api-base
https://stagingapi.comfy.org`, build with
`VITE_STAGING_CLOUD_BASE_URL=https://stagingcloud.comfy.org`), logged in
with a staging **team-workspace** API key (`team2`).

| Profile menu (legacy popover, user-scoped balance, no workspace) |
Credits → old combined view, personal account's balance & activity |
Plan & Credits: empty workspace name |
| --- | --- | --- |
| <img
src="https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-15917-screenshots/docs-assets/pr-15917/asis-popover.png"
width="280" /> | <img
src="https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-15917-screenshots/docs-assets/pr-15917/asis-credits-panel.png"
width="280" /> | <img
src="https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-15917-screenshots/docs-assets/pr-15917/asis-plan-credits.png"
width="280" /> |

| Profile menu: `team2` row, workspace balance, no switcher | Plan &
Credits: `team2` header + workspace balance | Activity: `team2`
workspace events only |
| --- | --- | --- |
| <img
src="https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-15917-screenshots/docs-assets/pr-15917/tobe-popover.png"
width="280" /> | <img
src="https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-15917-screenshots/docs-assets/pr-15917/tobe-plan-credits.png"
width="280" /> | <img
src="https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-15917-screenshots/docs-assets/pr-15917/tobe-activity.png"
width="280" /> |
@dante01yoon dante01yoon added the backport Backporting a PR onto a release candidate label Aug 26, 2026
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 26, 2026
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 0304a8f1-d60e-4a8f-9ead-c2c424b452c8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/26/2026, 12:40:11 AM UTC

Links

🎭 Playwright: ✅ 1833 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1812 / ❌ 0 / ⚠️ 0 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 150ms TBT · 77.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
vue-large-graph-idle: · 54.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 158.6 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 69ms TBT · 175.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 576ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.6 MB
canvas-idle: DOM nodes 18
canvas-idle: event listeners 4
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 44ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 930ms
canvas-mouse-sweep: script duration 116ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 55.6 MB
canvas-mouse-sweep: DOM nodes -111
canvas-mouse-sweep: event listeners -75
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 20ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 428ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.3 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 401ms
dom-widget-clipping: script duration 58ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 51.8 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 685ms
large-graph-idle: script duration 18ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 63.2 MB
large-graph-idle: DOM nodes -282
large-graph-idle: event listeners -179
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 15ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1233ms
large-graph-pan: script duration 344ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 57.6 MB
large-graph-pan: DOM nodes -284
large-graph-pan: event listeners -164
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1454ms
large-graph-zoom: script duration 414ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 58.7 MB
large-graph-zoom: DOM nodes -287
large-graph-zoom: event listeners -153
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 629ms
minimap-idle: script duration 16ms
minimap-idle: TBT 0ms
minimap-idle: heap used 70.9 MB
minimap-idle: DOM nodes -285
minimap-idle: event listeners -149
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 432ms
subgraph-dom-widget-clipping: script duration 122ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 53.0 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 557ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.6 MB
subgraph-idle: DOM nodes 19
subgraph-idle: event listeners 4
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 39ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 818ms
subgraph-mouse-sweep: script duration 88ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 59.4 MB
subgraph-mouse-sweep: DOM nodes 65
subgraph-mouse-sweep: event listeners 4
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 896ms
subgraph-transition-enter: script duration 15ms
subgraph-transition-enter: TBT 150ms
subgraph-transition-enter: heap used 77.0 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2375
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4416ms
viewport-pan-sweep: script duration 1105ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 71.4 MB
viewport-pan-sweep: DOM nodes -283
viewport-pan-sweep: event listeners -132
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16438ms
vue-large-graph-idle: script duration 114ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 158.6 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16387
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 21ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 173
vue-large-graph-pan: task duration 20330ms
vue-large-graph-pan: script duration 427ms
vue-large-graph-pan: TBT 69ms
vue-large-graph-pan: heap used 175.8 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16381
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 25ms
workflow-execution: layout count 4
workflow-execution: style recalc count 14
workflow-execution: task duration 126ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 66.4 MB
workflow-execution: DOM nodes 125
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-08-26T00:50:39.374Z",
  "gitSha": "7955e07191ccc650f6678a1d6a4e12536b0b091f",
  "branch": "backport-15917-to-cloud-1.51",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2060.3419999999915,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.9430000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 535.551,
      "heapDeltaBytes": 5063160,
      "heapUsedBytes": 70652244,
      "domNodes": 18,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 7.003000000000002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2054.587999999967,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.126000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 616.291,
      "heapDeltaBytes": 5406936,
      "heapUsedBytes": 71063028,
      "domNodes": 18,
      "jsHeapTotalBytes": 23592960,
      "scriptDurationMs": 11.575000000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1869.4389999999999,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 40.336999999999996,
      "layouts": 12,
      "layoutDurationMs": 3.534,
      "taskDurationMs": 896.7270000000001,
      "heapDeltaBytes": 513296,
      "heapUsedBytes": 65937872,
      "domNodes": 59,
      "jsHeapTotalBytes": 25432064,
      "scriptDurationMs": 113.29899999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1922.5139999999783,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 47.86,
      "layouts": 12,
      "layoutDurationMs": 4.361000000000001,
      "taskDurationMs": 962.601,
      "heapDeltaBytes": -14829520,
      "heapUsedBytes": 50662532,
      "domNodes": -280,
      "jsHeapTotalBytes": 22646784,
      "scriptDurationMs": 118.847,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1747.3320000000285,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 17.959999999999997,
      "layouts": 6,
      "layoutDurationMs": 0.696,
      "taskDurationMs": 476.48300000000006,
      "heapDeltaBytes": 8221072,
      "heapUsedBytes": 73531320,
      "domNodes": 75,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 13.846999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.5650000000232,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 21.691999999999997,
      "layouts": 6,
      "layoutDurationMs": 0.735,
      "taskDurationMs": 379.318,
      "heapDeltaBytes": 8525932,
      "heapUsedBytes": 73824880,
      "domNodes": 78,
      "jsHeapTotalBytes": 23330816,
      "scriptDurationMs": 8.637,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 609.3609999999785,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.517,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 403.075,
      "heapDeltaBytes": -10514796,
      "heapUsedBytes": 54895016,
      "domNodes": 20,
      "jsHeapTotalBytes": 23855104,
      "scriptDurationMs": 58.658,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 612.0690000000195,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.319999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 399.77299999999997,
      "heapDeltaBytes": -11640120,
      "heapUsedBytes": 53802452,
      "domNodes": 20,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 57.684,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2024.8280000000136,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.532000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 742.2309999999999,
      "heapDeltaBytes": 7793220,
      "heapUsedBytes": 67545864,
      "domNodes": -283,
      "jsHeapTotalBytes": 2981888,
      "scriptDurationMs": 19.468,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2022.8230000000167,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.238999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 628.2050000000002,
      "heapDeltaBytes": 4637484,
      "heapUsedBytes": 64968880,
      "domNodes": -280,
      "jsHeapTotalBytes": 2457600,
      "scriptDurationMs": 15.679000000000006,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2237.6160000000027,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.597999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1301.905,
      "heapDeltaBytes": 5654908,
      "heapUsedBytes": 66288704,
      "domNodes": -284,
      "jsHeapTotalBytes": 3174400,
      "scriptDurationMs": 357.174,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2138.553999999999,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.851999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1163.962,
      "heapDeltaBytes": -6135844,
      "heapUsedBytes": 54607608,
      "domNodes": -283,
      "jsHeapTotalBytes": 4030464,
      "scriptDurationMs": 330.204,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3300.219000000027,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 15.169000000000002,
      "layouts": 60,
      "layoutDurationMs": 7.805000000000001,
      "taskDurationMs": 1482.25,
      "heapDeltaBytes": -1239540,
      "heapUsedBytes": 61533976,
      "domNodes": -288,
      "jsHeapTotalBytes": 2981888,
      "scriptDurationMs": 423.44200000000006,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3265.066000000047,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 13.609999999999998,
      "layouts": 60,
      "layoutDurationMs": 7.2620000000000005,
      "taskDurationMs": 1425.369,
      "heapDeltaBytes": -766748,
      "heapUsedBytes": 61527920,
      "domNodes": -285,
      "jsHeapTotalBytes": 2981888,
      "scriptDurationMs": 405.281,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2036.580000000015,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.0870000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 665.8709999999999,
      "heapDeltaBytes": 12469632,
      "heapUsedBytes": 73802504,
      "domNodes": -286,
      "jsHeapTotalBytes": 2981888,
      "scriptDurationMs": 18.415,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2008.7029999999686,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.176999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 591.7900000000001,
      "heapDeltaBytes": 13329684,
      "heapUsedBytes": 74881020,
      "domNodes": -284,
      "jsHeapTotalBytes": 3768320,
      "scriptDurationMs": 13.324000000000002,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 727.7650000000335,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 13.057000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 474.267,
      "heapDeltaBytes": -9828700,
      "heapUsedBytes": 55657808,
      "domNodes": 20,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 129.447,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 566.387000000077,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.080999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 388.79600000000005,
      "heapDeltaBytes": -10004728,
      "heapUsedBytes": 55578860,
      "domNodes": 20,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 115.38100000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2025.5349999999908,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.302,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 659.056,
      "heapDeltaBytes": 5461428,
      "heapUsedBytes": 70835676,
      "domNodes": 18,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 11.972,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2029.8720000000685,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.746,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.04100000000005,
      "heapDeltaBytes": 5521348,
      "heapUsedBytes": 71026008,
      "domNodes": 20,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 5.266,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1774.2000000000075,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 43.830999999999996,
      "layouts": 16,
      "layoutDurationMs": 5.085,
      "taskDurationMs": 896.9259999999999,
      "heapDeltaBytes": -3563396,
      "heapUsedBytes": 61971112,
      "domNodes": 65,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 95.62300000000002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.4490000001006,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 34.024,
      "layouts": 16,
      "layoutDurationMs": 4.124,
      "taskDurationMs": 738.6830000000001,
      "heapDeltaBytes": -3222040,
      "heapUsedBytes": 62586020,
      "domNodes": 64,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 80.86500000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.6560000000263,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 31.94899999999999,
      "layouts": 14,
      "layoutDurationMs": 13.544,
      "taskDurationMs": 895.5430000000002,
      "heapDeltaBytes": -4007932,
      "heapUsedBytes": 80733340,
      "domNodes": 13673,
      "jsHeapTotalBytes": 9437184,
      "scriptDurationMs": 15.425,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 150,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8939.639,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 40.404,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4668.84,
      "heapDeltaBytes": 14437620,
      "heapUsedBytes": 74969860,
      "domNodes": -283,
      "jsHeapTotalBytes": 4222976,
      "scriptDurationMs": 1148.1109999999999,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8356.567000000041,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 37.095000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4162.705,
      "heapDeltaBytes": 15009236,
      "heapUsedBytes": 74695920,
      "domNodes": -282,
      "jsHeapTotalBytes": 4222976,
      "scriptDurationMs": 1061.067,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18065.788999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17147.482,
      "heapDeltaBytes": -30894464,
      "heapUsedBytes": 166441888,
      "domNodes": -8312,
      "jsHeapTotalBytes": -14622720,
      "scriptDurationMs": 126.103,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.33666666666662,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16776.761999999962,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15728.324,
      "heapDeltaBytes": -32139144,
      "heapUsedBytes": 166181164,
      "domNodes": -8312,
      "jsHeapTotalBytes": -21696512,
      "scriptDurationMs": 101.688,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.33666666666662,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22004.37499999998,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 22.415000000000017,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21275.114,
      "heapDeltaBytes": -12660848,
      "heapUsedBytes": 185777504,
      "domNodes": -8312,
      "jsHeapTotalBytes": -11280384,
      "scriptDurationMs": 430.59099999999995,
      "eventListeners": -16379,
      "totalBlockingTimeMs": 62,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19979.423999999995,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 19.287,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19385.813,
      "heapDeltaBytes": -14506240,
      "heapUsedBytes": 182800824,
      "domNodes": -8312,
      "jsHeapTotalBytes": -16003072,
      "scriptDurationMs": 423.624,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 75,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 469.9850000000083,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 24.333999999999996,
      "layouts": 4,
      "layoutDurationMs": 1.346,
      "taskDurationMs": 121.90599999999999,
      "heapDeltaBytes": 4994676,
      "heapUsedBytes": 69684660,
      "domNodes": 126,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 8.585,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 493.8649999999143,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 26.343999999999998,
      "layouts": 3,
      "layoutDurationMs": 0.8080000000000002,
      "taskDurationMs": 130.06300000000002,
      "heapDeltaBytes": 4975472,
      "heapUsedBytes": 69576824,
      "domNodes": 123,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 9.681000000000001,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Aug 26, 2026
@github-actions
github-actions Bot requested a review from thedatalife August 26, 2026 00:39
@codecov

codecov Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.18919% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/platform/workspace/api/workspaceApi.ts 12.50% 7 Missing ⚠️
...rkspace/components/CurrentUserPopoverWorkspace.vue 90.90% 0 Missing and 1 partial ⚠️
@@              Coverage Diff              @@
##             cloud/1.51   #15951   +/-   ##
=============================================
  Coverage              ?   79.25%           
=============================================
  Files                 ?     2212           
  Lines                 ?   122800           
  Branches              ?    38460           
=============================================
  Hits                  ?    97322           
  Misses                ?    24896           
  Partials              ?      582           
Flag Coverage Δ
unit 73.23% <90.27%> (?)
website-unit 22.59% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/auth/useCurrentUser.ts 65.62% <100.00%> (ø)
src/platform/workspace/auth/WorkspaceAuthGate.vue 97.31% <100.00%> (ø)
...rc/platform/workspace/stores/teamWorkspaceStore.ts 69.42% <100.00%> (ø)
src/scripts/app.ts 84.36% <100.00%> (ø)
src/stores/apiKeyAuthStore.ts 88.88% <100.00%> (ø)
src/stores/authStore.ts 83.16% <100.00%> (ø)
...rkspace/components/CurrentUserPopoverWorkspace.vue 87.67% <90.90%> (ø)
src/platform/workspace/api/workspaceApi.ts 46.72% <12.50%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit 933ae09 into cloud/1.51 Aug 26, 2026
88 of 90 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-15917-to-cloud-1.51 branch August 26, 2026 04:43
@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned) size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants