Repository navigation
fix(ingest-types): dedupe CurrentWorkspaceResponse on cloud/1.51 - #16449
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1831 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-01T01:16:13.579Z",
"gitSha": "f1b7710254b4158c82af24863927f8eefd3f03d6",
"branch": "fix/cloud-1.51-ingest-types-dedupe",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2047.145999999998,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.063999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.735,
"heapDeltaBytes": 5506068,
"heapUsedBytes": 70916684,
"domNodes": 16,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 9.879999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2038.3410000000026,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.706000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.53,
"heapDeltaBytes": 5677516,
"heapUsedBytes": 71285928,
"domNodes": 18,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 7.107999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2091.823999999974,
"styleRecalcs": 79,
"styleRecalcDurationMs": 55.944,
"layouts": 12,
"layoutDurationMs": 4.075,
"taskDurationMs": 1131.5520000000001,
"heapDeltaBytes": -17948428,
"heapUsedBytes": 47529516,
"domNodes": -281,
"jsHeapTotalBytes": 23166976,
"scriptDurationMs": 139.17200000000003,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1858.0930000000535,
"styleRecalcs": 74,
"styleRecalcDurationMs": 37.905,
"layouts": 12,
"layoutDurationMs": 3.4850000000000003,
"taskDurationMs": 893.9650000000001,
"heapDeltaBytes": -16626552,
"heapUsedBytes": 48864744,
"domNodes": -281,
"jsHeapTotalBytes": 22904832,
"scriptDurationMs": 114.613,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.246999999987,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.908,
"layouts": 6,
"layoutDurationMs": 0.673,
"taskDurationMs": 423.02599999999995,
"heapDeltaBytes": 8013112,
"heapUsedBytes": 73502648,
"domNodes": 77,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 12.146,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.8269999999484,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.402,
"layouts": 6,
"layoutDurationMs": 0.719,
"taskDurationMs": 361.51099999999997,
"heapDeltaBytes": 8192140,
"heapUsedBytes": 73689844,
"domNodes": 78,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 8.847000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 622.2939999999539,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.676,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.90999999999997,
"heapDeltaBytes": -11661132,
"heapUsedBytes": 53674024,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 61.407,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 593.3929999999918,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.710999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.039,
"heapDeltaBytes": -11347104,
"heapUsedBytes": 54026692,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 61.364000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2026.4329999999973,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.164000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 716.332,
"heapDeltaBytes": 12947844,
"heapUsedBytes": 73038756,
"domNodes": -280,
"jsHeapTotalBytes": 2977792,
"scriptDurationMs": 20.199,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2018.5109999999895,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.763999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.7,
"heapDeltaBytes": 12796972,
"heapUsedBytes": 73045296,
"domNodes": -282,
"jsHeapTotalBytes": 3502080,
"scriptDurationMs": 15.077999999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2334.5279999999775,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.572999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1297.0720000000001,
"heapDeltaBytes": 8001664,
"heapUsedBytes": 68982160,
"domNodes": -282,
"jsHeapTotalBytes": 3432448,
"scriptDurationMs": 349.921,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2171.8270000000075,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.508000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1172.654,
"heapDeltaBytes": 10802076,
"heapUsedBytes": 71457672,
"domNodes": -286,
"jsHeapTotalBytes": 4218880,
"scriptDurationMs": 336.372,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3300.559000000021,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.282000000000004,
"layouts": 60,
"layoutDurationMs": 8.158,
"taskDurationMs": 1493.202,
"heapDeltaBytes": 393592,
"heapUsedBytes": 62659156,
"domNodes": -287,
"jsHeapTotalBytes": 4550656,
"scriptDurationMs": 423.799,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3132.745,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.900999999999996,
"layouts": 60,
"layoutDurationMs": 7.128000000000001,
"taskDurationMs": 1332.674,
"heapDeltaBytes": -6683840,
"heapUsedBytes": 55571528,
"domNodes": -286,
"jsHeapTotalBytes": 2977792,
"scriptDurationMs": 370.19399999999996,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2019.56899999999,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.818999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 668.1100000000001,
"heapDeltaBytes": 10587516,
"heapUsedBytes": 71204712,
"domNodes": -285,
"jsHeapTotalBytes": 3764224,
"scriptDurationMs": 18.269000000000002,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2028.1999999999698,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.770999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.0269999999999,
"heapDeltaBytes": 13491644,
"heapUsedBytes": 75091320,
"domNodes": -285,
"jsHeapTotalBytes": 3502080,
"scriptDurationMs": 14.425,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 627.1899999999846,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.186,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.01,
"heapDeltaBytes": -9934452,
"heapUsedBytes": 55556836,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 122.68400000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 576.5609999999697,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.795,
"heapDeltaBytes": -9956232,
"heapUsedBytes": 55842012,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 116.57199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2033.3529999999769,
"styleRecalcs": 9,
"styleRecalcDurationMs": 12.381,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.7510000000001,
"heapDeltaBytes": 5434776,
"heapUsedBytes": 71108964,
"domNodes": 18,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 9.004000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2037.6710000000458,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.295,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.88900000000007,
"heapDeltaBytes": 5509356,
"heapUsedBytes": 71109612,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 7.343999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.100999999985,
"styleRecalcs": 76,
"styleRecalcDurationMs": 42.73800000000001,
"layouts": 16,
"layoutDurationMs": 5.289000000000001,
"taskDurationMs": 862.9899999999999,
"heapDeltaBytes": -3197652,
"heapUsedBytes": 62292036,
"domNodes": 62,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 99.17300000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.4440000000432,
"styleRecalcs": 78,
"styleRecalcDurationMs": 41.882000000000005,
"layouts": 16,
"layoutDurationMs": 4.720000000000001,
"taskDurationMs": 816.7189999999999,
"heapDeltaBytes": -3432712,
"heapUsedBytes": 62196968,
"domNodes": 66,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 92.42399999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.4130000000064,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.610000000000014,
"layouts": 13,
"layoutDurationMs": 13.060000000000002,
"taskDurationMs": 1007.485,
"heapDeltaBytes": -359008,
"heapUsedBytes": 87687104,
"domNodes": 13673,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 18.573000000000008,
"eventListeners": 2375,
"totalBlockingTimeMs": 134,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8792.830999999978,
"styleRecalcs": 248,
"styleRecalcDurationMs": 40.032,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4599.258,
"heapDeltaBytes": 14227716,
"heapUsedBytes": 74473716,
"domNodes": -283,
"jsHeapTotalBytes": 4218880,
"scriptDurationMs": 1108.0800000000002,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8233.35499999996,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.74099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4071.084,
"heapDeltaBytes": 14192024,
"heapUsedBytes": 74418648,
"domNodes": -281,
"jsHeapTotalBytes": 3694592,
"scriptDurationMs": 1018.243,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17898.83800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16964.788,
"heapDeltaBytes": -25705408,
"heapUsedBytes": 171562428,
"domNodes": -8311,
"jsHeapTotalBytes": -6234112,
"scriptDurationMs": 128.04100000000003,
"eventListeners": -16393,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17330.81500000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16665.675,
"heapDeltaBytes": -41469940,
"heapUsedBytes": 170840852,
"domNodes": -8312,
"jsHeapTotalBytes": -8327168,
"scriptDurationMs": 122.13899999999998,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21137.767999999993,
"styleRecalcs": 180,
"styleRecalcDurationMs": 18.88000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20497.231,
"heapDeltaBytes": -22073792,
"heapUsedBytes": 175384892,
"domNodes": -8312,
"jsHeapTotalBytes": -12595200,
"scriptDurationMs": 466.06500000000005,
"eventListeners": -16383,
"totalBlockingTimeMs": 97,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21151.406000000065,
"styleRecalcs": 179,
"styleRecalcDurationMs": 19.208000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20502.632999999998,
"heapDeltaBytes": -16480044,
"heapUsedBytes": 182977636,
"domNodes": -8316,
"jsHeapTotalBytes": -15998976,
"scriptDurationMs": 417.98400000000004,
"eventListeners": -16383,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 450.080000000014,
"styleRecalcs": 12,
"styleRecalcDurationMs": 19.285000000000004,
"layouts": 2,
"layoutDurationMs": 0.40700000000000003,
"taskDurationMs": 108.129,
"heapDeltaBytes": 4999592,
"heapUsedBytes": 69731176,
"domNodes": 124,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.656999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 459.67800000005354,
"styleRecalcs": 13,
"styleRecalcDurationMs": 23.485,
"layouts": 4,
"layoutDurationMs": 1.2619999999999998,
"taskDurationMs": 116.13499999999999,
"heapDeltaBytes": 4977244,
"heapUsedBytes": 69757532,
"domNodes": 121,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.945,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.51 #16449 +/- ##
=============================================
Coverage ? 70.85%
=============================================
Files ? 2128
Lines ? 100889
Branches ? 30011
=============================================
Hits ? 71481
Misses ? 29134
Partials ? 274
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Summary
Backports #15951 and #15927 each added CurrentWorkspaceResponse, leaving types.gen.ts with two identical declarations (the second one shadowing CreateWorkspaceRequest's doc comment) and index.ts exporting it twice. Every job that runs typecheck on this branch fails with TS2300.
Remove the duplicate block and export line; typecheck passes again.