Repository navigation
feat: assert registration-identity invariants in registerNodeState/nodeDataStore - #15726
christian-byrne wants to merge 3 commits into
Conversation
…deDataStore Catches three silent failure modes in the node-data-store lifecycle: - Cross-root re-registration: asserts node._graphScope.rootGraphId matches before registering - Identity drift on unregister: asserts deleteNode returns true (state found in bucket) - Duplicate NodeState for same (id, graphId): asserts in registerNode instead of silent undefined Also adds unit tests for all three failure modes plus the idempotent same-state re-registration happy path. Closes BE-5048 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1991 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-23T10:20:16.347Z",
"gitSha": "dbb7ec11d4a815f73f78d8b24cbb41b885e0b77e",
"branch": "be-5048-assert-registration-invariants",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2034.8410000000285,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.472000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.691,
"heapDeltaBytes": -11286692,
"heapUsedBytes": 58636864,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.415,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2055.513000000019,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.178,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.564,
"heapDeltaBytes": 8456852,
"heapUsedBytes": 78370596,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.827,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2488.9629999999556,
"styleRecalcs": 82,
"styleRecalcDurationMs": 48.239000000000004,
"layouts": 12,
"layoutDurationMs": 4.401999999999999,
"taskDurationMs": 1497.5990000000002,
"heapDeltaBytes": -5417396,
"heapUsedBytes": 63547092,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 193.62800000000001,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2241.184999999973,
"styleRecalcs": 78,
"styleRecalcDurationMs": 48.373000000000005,
"layouts": 12,
"layoutDurationMs": 3.9459999999999997,
"taskDurationMs": 1362.5280000000002,
"heapDeltaBytes": 8304304,
"heapUsedBytes": 77305780,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 179.043,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1751.9439999999804,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.721999999999998,
"layouts": 6,
"layoutDurationMs": 0.755,
"taskDurationMs": 392.57200000000006,
"heapDeltaBytes": 3745004,
"heapUsedBytes": 73050228,
"domNodes": 74,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.418,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.6169999999101,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.027000000000005,
"layouts": 6,
"layoutDurationMs": 0.819,
"taskDurationMs": 383.70000000000005,
"heapDeltaBytes": 3959532,
"heapUsedBytes": 72997504,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.956,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 735.8319999999594,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.182,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.68899999999996,
"heapDeltaBytes": -6809776,
"heapUsedBytes": 62243356,
"domNodes": 14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 34.044000000000004,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 751.7329999999447,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.638999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.6389999999999,
"heapDeltaBytes": 19735784,
"heapUsedBytes": 81683992,
"domNodes": 14,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 36.11599999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2051.5819999999962,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.218,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 627.7530000000002,
"heapDeltaBytes": -21732996,
"heapUsedBytes": 68750696,
"domNodes": -281,
"jsHeapTotalBytes": 4714496,
"scriptDurationMs": 45.263,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.6540000000277,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.143000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.564,
"heapDeltaBytes": -21857004,
"heapUsedBytes": 68850452,
"domNodes": -281,
"jsHeapTotalBytes": 4714496,
"scriptDurationMs": 44.42,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3808.915000000013,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.696000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2935.888,
"heapDeltaBytes": -17966812,
"heapUsedBytes": 66149404,
"domNodes": -282,
"jsHeapTotalBytes": 3891200,
"scriptDurationMs": 1053.113,
"eventListeners": -179,
"totalBlockingTimeMs": 28,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 3822.520000000054,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.387999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2932.678,
"heapDeltaBytes": -13424060,
"heapUsedBytes": 77565904,
"domNodes": -279,
"jsHeapTotalBytes": 4939776,
"scriptDurationMs": 1053.3260000000002,
"eventListeners": -179,
"totalBlockingTimeMs": 29,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4662.346999999954,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.534999999999998,
"layouts": 60,
"layoutDurationMs": 8.024,
"taskDurationMs": 2787.703,
"heapDeltaBytes": 8154148,
"heapUsedBytes": 74677632,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 964.5879999999999,
"eventListeners": 12,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4634.41499999999,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.508000000000001,
"layouts": 60,
"layoutDurationMs": 8.097,
"taskDurationMs": 2784.9519999999998,
"heapDeltaBytes": 495528,
"heapUsedBytes": 72479304,
"domNodes": -265,
"jsHeapTotalBytes": -1875968,
"scriptDurationMs": 929.131,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3547.3610000000235,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.496999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2457.0570000000002,
"heapDeltaBytes": -396400,
"heapUsedBytes": 71912916,
"domNodes": -285,
"jsHeapTotalBytes": -827392,
"scriptDurationMs": 277.907,
"eventListeners": -1,
"totalBlockingTimeMs": 4,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3436.177999999927,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.127,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2315.561,
"heapDeltaBytes": 12998400,
"heapUsedBytes": 79660012,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 253.081,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2091.3550000000214,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.3480000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 631.35,
"heapDeltaBytes": -21983364,
"heapUsedBytes": 70539900,
"domNodes": -281,
"jsHeapTotalBytes": 3928064,
"scriptDurationMs": 50.952,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.517999999949,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.1680000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.3489999999999,
"heapDeltaBytes": -22502480,
"heapUsedBytes": 69207092,
"domNodes": -284,
"jsHeapTotalBytes": 3665920,
"scriptDurationMs": 39.623,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 756.2800000000607,
"styleRecalcs": 44,
"styleRecalcDurationMs": 9.395000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.122,
"heapDeltaBytes": 17512164,
"heapUsedBytes": 87846668,
"domNodes": 14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 141.121,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 742.8859999999986,
"styleRecalcs": 43,
"styleRecalcDurationMs": 8.357999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.6059999999999,
"heapDeltaBytes": 17850656,
"heapUsedBytes": 88165540,
"domNodes": 12,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 142.60500000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2031.9070000000465,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.280000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.6899999999999,
"heapDeltaBytes": -13892612,
"heapUsedBytes": 55840628,
"domNodes": -297,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.512,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2033.4459999999126,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.149,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.674,
"heapDeltaBytes": -12538976,
"heapUsedBytes": 57103904,
"domNodes": -297,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.189000000000002,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1974.4160000000193,
"styleRecalcs": 78,
"styleRecalcDurationMs": 45.88399999999999,
"layouts": 16,
"layoutDurationMs": 4.814,
"taskDurationMs": 1235.121,
"heapDeltaBytes": 12939424,
"heapUsedBytes": 75736548,
"domNodes": -298,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 127.775,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1930.2710000000616,
"styleRecalcs": 80,
"styleRecalcDurationMs": 44.028999999999996,
"layouts": 16,
"layoutDurationMs": 4.854000000000001,
"taskDurationMs": 1195.906,
"heapDeltaBytes": -5498196,
"heapUsedBytes": 64213040,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 128.62500000000003,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.951999999953,
"styleRecalcs": 19,
"styleRecalcDurationMs": 33.306000000000004,
"layouts": 14,
"layoutDurationMs": 14.994999999999997,
"taskDurationMs": 1026.2479999999998,
"heapDeltaBytes": 17935676,
"heapUsedBytes": 99627604,
"domNodes": 13671,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 34.605,
"eventListeners": 2383,
"totalBlockingTimeMs": 155,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 13270.83099999993,
"styleRecalcs": 245,
"styleRecalcDurationMs": 38.46000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10214.215999999999,
"heapDeltaBytes": -11631980,
"heapUsedBytes": 78995384,
"domNodes": -277,
"jsHeapTotalBytes": 3072000,
"scriptDurationMs": 3465.829,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 13780.726000000072,
"styleRecalcs": 245,
"styleRecalcDurationMs": 38.66700000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10466.335000000001,
"heapDeltaBytes": 2186024,
"heapUsedBytes": 92513224,
"domNodes": -280,
"jsHeapTotalBytes": 4382720,
"scriptDurationMs": 3683.695,
"eventListeners": -125,
"totalBlockingTimeMs": 34,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18681.970999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17831.053,
"heapDeltaBytes": -34665552,
"heapUsedBytes": 176846516,
"domNodes": -6548,
"jsHeapTotalBytes": -5705728,
"scriptDurationMs": 377.745,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18811.147000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17958.203,
"heapDeltaBytes": -29720772,
"heapUsedBytes": 176982612,
"domNodes": -6548,
"jsHeapTotalBytes": -57344,
"scriptDurationMs": 392.07599999999996,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22914.10099999996,
"styleRecalcs": 175,
"styleRecalcDurationMs": 23.336999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22609.328999999998,
"heapDeltaBytes": -51627404,
"heapUsedBytes": 168795692,
"domNodes": -6548,
"jsHeapTotalBytes": 1130496,
"scriptDurationMs": 983.919,
"eventListeners": -7467,
"totalBlockingTimeMs": 139,
"frameDurationMs": 19.44333333333319,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22919.823000000066,
"styleRecalcs": 179,
"styleRecalcDurationMs": 23.09699999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22596.193,
"heapDeltaBytes": -36429452,
"heapUsedBytes": 169053036,
"domNodes": -6548,
"jsHeapTotalBytes": 249856,
"scriptDurationMs": 1001.0210000000002,
"eventListeners": -7467,
"totalBlockingTimeMs": 178,
"frameDurationMs": 18.33666666666662,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "workflow-execution",
"durationMs": 490.02500000005966,
"styleRecalcs": 17,
"styleRecalcDurationMs": 20.621000000000002,
"layouts": 3,
"layoutDurationMs": 1.377,
"taskDurationMs": 137.34500000000003,
"heapDeltaBytes": 5756364,
"heapUsedBytes": 68646368,
"domNodes": 140,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.628999999999998,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 129.598999999871,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.830000000000002,
"layouts": 3,
"layoutDurationMs": 1.4460000000000002,
"taskDurationMs": 103.81899999999999,
"heapDeltaBytes": 3285968,
"heapUsedBytes": 69883296,
"domNodes": 130,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.095999999999999,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
|
The third assert in this PR has been tried before and it went red. Flagging before this merges, because it is non-draft and three days from the branch merge. The hunk: - if (incumbent) return undefined
+ if (incumbent) {
+ assert(
+ false,
+ `nodeDataStore: duplicate NodeState for node ${state.id} in graph ${state.graphId}`
+ )
+ return undefined
+ }That is the unconditional rejection branch, and Prior measurement. BE-5048's worker reported on 2026-07-30, in that ticket's comments: the new Why the branch reaches it on ordinary input. // LGraph.ts:1171
while (!registerNodeState(this, node)) node.id = mintNodeId(state)So a rejection here is the retry protocol working, not necessarily an invariant violation. Asserting on it makes the normal path throw in DEV. The other two asserts in this PR — cross-root re-registration and identity drift on unregister — do not have this problem. They fire on states the caller cannot reach legitimately, and they are worth having. Suggested change: keep asserts 1 and 2, drop or narrow assert 3. If it stays, gate it on the case the caller cannot resolve rather than on every incumbent, and answer the July question first with the red arms that already exist ( Also, three open PRs are rewriting this same branch right now, and whichever lands first conflicts with the other two:
Worth picking one before any of them merges. Context: FE-1810 and BE-5048 comment threads; |
…ror directives vue-tsc failed with three errors in this file, which failed `setup` and cascaded to test, lint-and-format, scan, perf-tests, validate-fonts, e2e-status and merge-reports: 186:13 TS6133 'subgraph' is declared but its value is never read 195:5 TS2578 Unused '@ts-expect-error' directive 201:5 TS2578 Unused '@ts-expect-error' directive `node._state` assignment type-checks without suppression, so both directives were errors in themselves. The IIFE only existed to name the subgraph binding that was never used.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## feature/ecs-migration #15726 +/- ##
=========================================================
- Coverage 82.31% 82.30% -0.01%
=========================================================
Files 1900 1900
Lines 107652 107656 +4
Branches 34061 34062 +1
=========================================================
Hits 88610 88610
- Misses 18706 18718 +12
+ Partials 336 328 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Closing in favour of #15720. |
Summary
Closes BE-5048 / #15706
Three silent failure modes in the node-data-store registration lifecycle now assert in DEV instead of failing silently:
registerNodeState): assertsnode._graphScope.rootGraphIdmatches the new graph's root before mutating state — previously would strand the old bucket entry as a ghostunregisterNodeState): captures thebooleanreturn fromdeleteNodeand asserts it'strue— catches cases where_statewas reassigned after registration, leaving a ghostNodeStatethe renderer keeps drawing(id, graphId)(nodeDataStore.registerNode): replaces the silentreturn undefinedwith anassert(false, ...)for the case where a genuinely different state object collides on the same id — idempotent same-object re-registration still returns early without assertingTest plan
pnpm test:unitfully green (22 tests pass acrossnodeDataStore.test.tsandLGraphNode.nodeState.test.ts)🤖 Generated with Claude Code