Repository navigation
test(litegraph): cover interrupted workflow load and slot-mirror normalisation - #15729
Conversation
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used all 3 included reviews currently available. Your 77 included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. 📝 WalkthroughWalkthroughThe pull request adds LiteGraph tests for interrupted ChangesLiteGraph load behavior
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This PR adds focused coverage without changing product behavior, and the reported checks pass; no actionable merge-blocking risk remains beyond normal review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1992 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 9.14 MB gzip 🟢 -421 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 591 kB (baseline 591 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 112 kB (baseline 112 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.44 MB (baseline 3.44 MB) • 🟢 -2.48 kBStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 549 kB (baseline 549 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 16 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.3 MB (baseline 14.3 MB) • 🟢 -154 BBundles that do not match a named category
Status: 78 added / 78 removed / 212 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-24T20:51:08.184Z",
"gitSha": "a37305a7e49957b41b01d480b2b5046b0fdd9e2b",
"branch": "cb__interrupted-load-coverage",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2054.9030000000243,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.318,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.613,
"heapDeltaBytes": -12374460,
"heapUsedBytes": 56948340,
"domNodes": -278,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.377999999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2054.70600000001,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.291999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.867,
"heapDeltaBytes": 12724576,
"heapUsedBytes": 82128816,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.7079999999999975,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2335.3549999999927,
"styleRecalcs": 78,
"styleRecalcDurationMs": 44.973,
"layouts": 12,
"layoutDurationMs": 3.635,
"taskDurationMs": 1398.5430000000001,
"heapDeltaBytes": -1537952,
"heapUsedBytes": 61173492,
"domNodes": -280,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 191.333,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2172.951000000012,
"styleRecalcs": 78,
"styleRecalcDurationMs": 40.493,
"layouts": 12,
"layoutDurationMs": 3.5140000000000002,
"taskDurationMs": 1213.001,
"heapDeltaBytes": -1674300,
"heapUsedBytes": 61181400,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 160.058,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1748.7049999999726,
"styleRecalcs": 29,
"styleRecalcDurationMs": 22.656999999999996,
"layouts": 6,
"layoutDurationMs": 0.6560000000000001,
"taskDurationMs": 376.802,
"heapDeltaBytes": 4400292,
"heapUsedBytes": 74143264,
"domNodes": 74,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.975,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.6480000000256,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.587000000000002,
"layouts": 6,
"layoutDurationMs": 0.5929999999999999,
"taskDurationMs": 351.717,
"heapDeltaBytes": 3995304,
"heapUsedBytes": 73311288,
"domNodes": 74,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.218,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 718.089999999961,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.037000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.30999999999995,
"heapDeltaBytes": -6805128,
"heapUsedBytes": 62422308,
"domNodes": 14,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 32.675,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 740.688000000091,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.611999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.361,
"heapDeltaBytes": -6048732,
"heapUsedBytes": 63386432,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 32.139,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2036.1320000000092,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.011000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.7439999999999,
"heapDeltaBytes": -18233780,
"heapUsedBytes": 73020148,
"domNodes": -269,
"jsHeapTotalBytes": -1576960,
"scriptDurationMs": 39.732,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2084.8829999999907,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.214,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.2660000000001,
"heapDeltaBytes": -21631044,
"heapUsedBytes": 69798016,
"domNodes": -282,
"jsHeapTotalBytes": 3928064,
"scriptDurationMs": 39.889,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3350.9090000000015,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.471,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2709.8520000000003,
"heapDeltaBytes": 7499184,
"heapUsedBytes": 92143884,
"domNodes": -284,
"jsHeapTotalBytes": 5427200,
"scriptDurationMs": 989.9419999999999,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 3382.8759999998965,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.4,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2713.4109999999996,
"heapDeltaBytes": 6665964,
"heapUsedBytes": 98211152,
"domNodes": -282,
"jsHeapTotalBytes": 5464064,
"scriptDurationMs": 983.0079999999999,
"eventListeners": -181,
"totalBlockingTimeMs": 25,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4395.125000000007,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.812999999999999,
"layouts": 60,
"layoutDurationMs": 7.43,
"taskDurationMs": 2602.343,
"heapDeltaBytes": -8731204,
"heapUsedBytes": 80555212,
"domNodes": -265,
"jsHeapTotalBytes": 4939776,
"scriptDurationMs": 894.1909999999999,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4291.719000000057,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.992999999999999,
"layouts": 60,
"layoutDurationMs": 7.0249999999999995,
"taskDurationMs": 2525.3360000000002,
"heapDeltaBytes": 7648636,
"heapUsedBytes": 73810812,
"domNodes": 24,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 884.7420000000001,
"eventListeners": 12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3155.6809999999587,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.302000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2043.742,
"heapDeltaBytes": 14049684,
"heapUsedBytes": 78048688,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 206.344,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3228.3219999999346,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.372999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2149.04,
"heapDeltaBytes": -1771124,
"heapUsedBytes": 70424684,
"domNodes": -285,
"jsHeapTotalBytes": -303104,
"scriptDurationMs": 230.82199999999997,
"eventListeners": 29,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.2089999999762,
"styleRecalcs": 4,
"styleRecalcDurationMs": 9.238000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 574.672,
"heapDeltaBytes": -22005408,
"heapUsedBytes": 70649408,
"domNodes": -274,
"jsHeapTotalBytes": 3403776,
"scriptDurationMs": 37.605,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2054.6190000000024,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.324000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.934,
"heapDeltaBytes": 116456,
"heapUsedBytes": 71601748,
"domNodes": -274,
"jsHeapTotalBytes": -303104,
"scriptDurationMs": 44.151,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 744.4780000000719,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.47,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.736,
"heapDeltaBytes": -7903136,
"heapUsedBytes": 62850156,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 136.37099999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 716.293999999948,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.858000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.4190000000001,
"heapDeltaBytes": 17563372,
"heapUsedBytes": 87538148,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 138.431,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.6810000000387,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.203,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.26,
"heapDeltaBytes": 3809400,
"heapUsedBytes": 66861708,
"domNodes": -299,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.882000000000001,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2000.3850000000511,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.677,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.183,
"heapDeltaBytes": 10143652,
"heapUsedBytes": 80130140,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.7749999999999995,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1822.9950000000485,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.998000000000005,
"layouts": 16,
"layoutDurationMs": 4.286,
"taskDurationMs": 1099.3809999999999,
"heapDeltaBytes": -3794700,
"heapUsedBytes": 66035420,
"domNodes": -295,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 114.789,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1908.0350000000408,
"styleRecalcs": 76,
"styleRecalcDurationMs": 43.894000000000005,
"layouts": 16,
"layoutDurationMs": 4.216,
"taskDurationMs": 1136.663,
"heapDeltaBytes": 12064180,
"heapUsedBytes": 74997792,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 115.86200000000002,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1369.4249999999784,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.842999999999996,
"layouts": 13,
"layoutDurationMs": 13.911,
"taskDurationMs": 885.7299999999999,
"heapDeltaBytes": -1851276,
"heapUsedBytes": 94337760,
"domNodes": 13671,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 31.607999999999997,
"eventListeners": 2381,
"totalBlockingTimeMs": 130,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 12412.112999999976,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.781000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9250.906,
"heapDeltaBytes": 7072732,
"heapUsedBytes": 98062056,
"domNodes": -280,
"jsHeapTotalBytes": 5431296,
"scriptDurationMs": 3278.871,
"eventListeners": -159,
"totalBlockingTimeMs": 32,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 12384.559999999965,
"styleRecalcs": 246,
"styleRecalcDurationMs": 34.571999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9249.117,
"heapDeltaBytes": 8024712,
"heapUsedBytes": 98547896,
"domNodes": -270,
"jsHeapTotalBytes": 3596288,
"scriptDurationMs": 3248.017,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17217.72199999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16723.429,
"heapDeltaBytes": -40795804,
"heapUsedBytes": 177044136,
"domNodes": -6548,
"jsHeapTotalBytes": 3395584,
"scriptDurationMs": 326.291,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18023.359999999913,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17122.536999999997,
"heapDeltaBytes": -27343720,
"heapUsedBytes": 176823708,
"domNodes": -6548,
"jsHeapTotalBytes": 2609152,
"scriptDurationMs": 369.682,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21231.42299999995,
"styleRecalcs": 179,
"styleRecalcDurationMs": 17.516999999999978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20969.109,
"heapDeltaBytes": -27564468,
"heapUsedBytes": 178830356,
"domNodes": -6548,
"jsHeapTotalBytes": -2678784,
"scriptDurationMs": 902.045,
"eventListeners": -7469,
"totalBlockingTimeMs": 88,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21465.575999999943,
"styleRecalcs": 180,
"styleRecalcDurationMs": 18.9,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21148.974,
"heapDeltaBytes": -23454020,
"heapUsedBytes": 188028556,
"domNodes": -6548,
"jsHeapTotalBytes": -4464640,
"scriptDurationMs": 922.8830000000002,
"eventListeners": -7467,
"totalBlockingTimeMs": 88,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 116.39599999989514,
"styleRecalcs": 10,
"styleRecalcDurationMs": 17.801,
"layouts": 2,
"layoutDurationMs": 0.611,
"taskDurationMs": 91.03599999999999,
"heapDeltaBytes": 3476540,
"heapUsedBytes": 70425172,
"domNodes": 111,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.161999999999999,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 474.86099999991893,
"styleRecalcs": 14,
"styleRecalcDurationMs": 23.201,
"layouts": 2,
"layoutDurationMs": 0.54,
"taskDurationMs": 121.81299999999999,
"heapDeltaBytes": 5443668,
"heapUsedBytes": 72150080,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.044999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15729 +/- ##
==========================================
+ Coverage 79.98% 82.41% +2.43%
==========================================
Files 2250 1920 -330
Lines 114153 109156 -4997
Branches 31543 30841 -702
==========================================
- Hits 91307 89963 -1344
+ Misses 22375 18857 -3518
+ Partials 471 336 -135
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
This PR adds two test files and deletes nothing (462+/0-). Codecov reports The base is the anomaly, not the head.
Every differing file is outside this diff. 20 files differ between the two
Those are carryforward artifacts. It correlates with the base, not with the change. Of the ten open PRs based on
2 for 2 on the contaminated base, 0 for 8 elsewhere. Not the Nothing to fix in this PR. Rebasing onto a branch head past |
…alisation Two gaps the soak plan is about to walk into. 1. `LGraph.interruptedConfigure.test.ts` — Gate 1 P0 #2 of `docs/architecture/ecs/ecs-verification-audit.md` ("failed or interrupted workflow load ... assert no node/link/reroute/layout/widget ownership leaks from the failed graph") had no coverage. `configure` is not transactional: when a node's `onConfigure` throws, the entities registered so far stay registered, and what makes a later load clean is `resetAfterClear()` clearing every graph-scoped store under `this.id` before the id is reassigned. The test forces the throw after two nested subgraph definitions and three root nodes have registered, loads a second workflow, and asserts nothing survives under the failed graph id. It also pins, as characterisation rather than endorsement, that a load which threw still dispatches `configured` exactly as a successful one does. 2. `slotMirrorNormalisationOnLoad.test.ts` — the legacy slot mirrors (`input.link`, `output.links`) are derived from the link records on this branch, so a disagreement present in a saved file does not survive the load. That decides what a third-party link-repair tool can still see, and it is the difference between this branch and `main`. Mutation-verified, not assumed: - Dropping `useNodeDataStore().clearGraph` + `layoutStore.clearGraph` from `resetAfterClear` -> 1 failure, `layouts` non-empty. - Dropping the link/reroute/widget/preview `clearGraph` calls -> 1 failure, `widgets` non-empty. - Dropping `unregisterAllLinkTopologies` + `unregisterAllRerouteChains` from `teardownOwnedGraphs` as well -> `links: [11]`, `reroutes: [1]`. - Dropping `unregisterNodeState` as well -> `nodes: ['101'..'104']`. - Failure-path-only: `configure` skipping `clear()` on the load after a failed load -> 2 failures. With the new file removed, that same mutation leaves the whole suite green (1231 files, 16830 passed, exit 0), which is the proof the gap was real. - `NodeInputSlot` keeping the serialized mirror instead of deriving it -> the input-mirror test fails with `expected null to be 3`, matching what the same file does on `main` (3 of 4 fail there). Suite at this commit: 1233 files, 16838 passed, 21 expected fail, 13 skipped, exit 0. `vue-tsc --noEmit` exit 0, 0 errors, 0 TS2688. knip output byte identical with and without these files.
61150b7 to
d158f09
Compare
DrJKL
left a comment
There was a problem hiding this comment.
Revalidated against the current main base and rebased head. Two still-relevant test-quality issues are inline: the cleanup assertion misses ownership dimensions it claims to cover, and the interrupted-configure suite now substantially duplicates coverage already on the base.
| } | ||
| } | ||
|
|
||
| /** Everything a graph id still owns across the ECS stores. */ |
There was a problem hiding this comment.
This helper cannot substantiate the “everything” claim: it queries only the root owner scope, so records owned by the two nested subgraphs are invisible; it checks only root-node layouts, not nested/group/reroute layouts; and it never seeds or queries preview exposure even though resetAfterClear() clears that store. Regressions in those cleanup paths would still pass. Please seed and assert each claimed ownership class across the nested owners, or narrow the test’s stated guarantee.
There was a problem hiding this comment.
Addressed in ebe6ddb. The duplicate suite was removed, and the existing failed-configure suite now snapshots root and nested-owner node, link, reroute, node/reroute/group layout, and widget state before and after recovery. Preview exposure is also seeded and verified through root cleanup.
| LiteGraph.registerNodeType('throwing', ThrowingNode as never) | ||
| }) | ||
|
|
||
| describe('LGraph.configure interrupted by a throwing node callback', () => { |
There was a problem hiding this comment.
After the rebase to main, LGraph.failedConfigure.test.ts already covers partial failure, configured after a throw, fresh-vs-reused equivalence, and cleanup of nodes/links/reroutes/groups/widgets/subgraphs. This 306-line parallel fixture repeats those contracts. Please extend the existing suite with only the missing ECS store/layout assertions instead of maintaining a second scenario.
There was a problem hiding this comment.
Addressed in ebe6ddb. LGraph.interruptedConfigure.test.ts was deleted; the missing ECS ownership and layout assertions were folded into LGraph.failedConfigure.test.ts. The existing partial-failure, configured-event, and fresh-vs-reused coverage remains the single scenario owner.
Two test files, no product change. Both cover things the 2026-08-24 soak plan is about to rely on.
1. Interrupted workflow load (Gate 1 P0 #2)
docs/architecture/ecs/ecs-verification-audit.mdlists as its second P0 gap: "failed or interrupted workflow load. Force a configure callback to throw after some nested definitions register, then load another workflow. Assert no node/link/reroute/layout/widget ownership leaks from the failed graph." Nothing covered it.LGraph.configureis not transactional. Itstry/finallyrestores the shadow-diff flag and dispatchesconfigured, but it does not roll back the entities already registered when a node'sonConfigurethrows. What keeps a later load clean isresetAfterClear(), which clears every graph-scoped store underthis.idbefore the id is reassigned.LGraph.interruptedConfigure.test.tspins that: two nested subgraph definitions, four root nodes, a link, a reroute and a group, with the last node throwing; then a second workflow is loaded and nothing is left owned by the failed graph id acrosslinkStore,nodeDataStore,rerouteStore,layoutStoreandwidgetValueStore.It also pins, as characterisation rather than endorsement, that a load which threw dispatches
configuredexactly as a successful one does, so no listener can tell them apart.2. Slot mirrors are rebuilt from link records on load
slotMirrorNormalisationOnLoad.test.ts. A saved workflow carries two views of a connection: the link records, and the legacy slot mirrors (input.link,output.links). On this branch the mirrors are derived (NodeInputSlot.linkreturnslinkIdOf(this); the constructor strips the serialized mirror beforeObject.assign), so a file-level disagreement between the two does not survive the load. That is a real behaviour difference frommainand it decides what a third-party link-repair tool can still find. Measured onmainat296fc5cd07with the same fixture, 3 of these 4 tests fail with the corrupt values preserved through load and through a save/reload round trip.Mutation verification
Tests are detectors, not decoration. Each assertion arm was perturbed and confirmed to fail with the exact expected diff, then reverted:
useNodeDataStore().clearGraph+layoutStore.clearGraphfromresetAfterClearlayouts: [101, 102, 103, 104]clearGraphcalls fromresetAfterClearwidgetsnon-emptyunregisterAllLinkTopologies+unregisterAllRerouteChainsfromteardownOwnedGraphslinks: [11],reroutes: [1]unregisterNodeStatenodes: ['101', '102', '103', '104']configureskipsclear()on the load after a failed load (failure path only)NodeInputSlotkeeps the serialized mirror instead of deriving itexpected null to be 3The fifth row is also the proof that the gap was real rather than assumed. With that mutation applied and the new file removed, the full unit suite stays green: 1231 files, 16830 passed, 21 expected fail, 13 skipped, exit 0. With the file present, 2 of its 4 tests go red. Scope of that claim: the vitest suite at
f1bfb313d6; the 314browser_testsspecs were not executed, and the nearest neighbour there (workflowPersistence.spec.ts:290) is a completed load with placeholder nodes, not an aborted one.Gates
pnpm test:unit: 1233 files, 16838 passed, 21 expected fail, 13 skipped, exit 0vue-tsc --noEmit: exit 0, 0 errors, 0TS2688pnpm lint: exit 0 (4 pre-existing warnings, none in these files)pnpm format:check: exit 0, 4863 filesknip: output byte-identical with and without these filesNot covered by any open stacked PR as of 2026-08-23 09:15Z. Checked #15723, #15721, #15720, #15708, #15689, #15615, #15613, #15544, #15502, #14257. The nearest are #15721 (call-site atomicity for
add/connect/replaceNodeInputs, not graph-levelconfigurefailure) and #15613 (store scope clearing on a successfulconfigure).Note on the
configuredcharacterisationDispatching
configuredfrom thefinallyis pre-existing, not introduced here:LGraph.tshas the samefinally { endNamedValuesShadowDiffLoad(); this.events.dispatch('configured') }atmain296fc5cd07(:2734-2736) as atf1bfb313d6. What changed with this branch is the size of the half-built state a listener sees when it fires, becauseconfigurenow registers into five external stores. The assertion is there to make the behaviour visible and to make a future change to it deliberate - if it is decided that a failed load should not dispatch, flip the assertion rather than deleting the test.