Repository navigation
test: cover shift/Ctrl multi-select on video assets - #15655
christian-byrne wants to merge 1 commit into
Conversation
🎭 Playwright: ✅ 1902 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 295 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T09:55:38.049Z",
"gitSha": "bbf43dc358dabe1ff2e33c4fb02f463274caaa3a",
"branch": "glary/test-video-asset-multi-select",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2076.6969999999674,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.668,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.557,
"heapDeltaBytes": -11575360,
"heapUsedBytes": 58107224,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.002,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2026.593000000048,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.625,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.741,
"heapDeltaBytes": 2635228,
"heapUsedBytes": 73469132,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.506,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1875.9370000000217,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.253,
"layouts": 14,
"layoutDurationMs": 4.829999999999999,
"taskDurationMs": 913.751,
"heapDeltaBytes": 5351428,
"heapUsedBytes": 75785416,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 148.38899999999998,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1858.2659999999578,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.977000000000004,
"layouts": 14,
"layoutDurationMs": 4.630000000000001,
"taskDurationMs": 889.2539999999999,
"heapDeltaBytes": -6546060,
"heapUsedBytes": 64031540,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 142.268,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.1340000000023,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.284000000000002,
"layouts": 6,
"layoutDurationMs": 1.2580000000000002,
"taskDurationMs": 374.75499999999994,
"heapDeltaBytes": 5097452,
"heapUsedBytes": 75731268,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.956999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1679.6300000000883,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.733999999999998,
"layouts": 6,
"layoutDurationMs": 1.1889999999999998,
"taskDurationMs": 390.5350000000001,
"heapDeltaBytes": 4448960,
"heapUsedBytes": 74394956,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.21,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 716.9260000000008,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.914999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.963,
"heapDeltaBytes": -8137916,
"heapUsedBytes": 62585640,
"domNodes": 18,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 158.62199999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 701.8909999999323,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.629,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.15099999999995,
"heapDeltaBytes": -7772460,
"heapUsedBytes": 63109016,
"domNodes": 22,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 156.022,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2071.451999999965,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.112999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 639.7660000000001,
"heapDeltaBytes": 11832428,
"heapUsedBytes": 86896328,
"domNodes": -269,
"jsHeapTotalBytes": -2187264,
"scriptDurationMs": 32.846,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2053.154999999947,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.260000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 648.499,
"heapDeltaBytes": -13239516,
"heapUsedBytes": 87333320,
"domNodes": -263,
"jsHeapTotalBytes": -1101824,
"scriptDurationMs": 38.032999999999994,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2202.5970000000257,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.283,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1597.8729999999998,
"heapDeltaBytes": 18898392,
"heapUsedBytes": 84775024,
"domNodes": -273,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 756.528,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2411.03099999998,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.309999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1711.7830000000001,
"heapDeltaBytes": 16776404,
"heapUsedBytes": 93231932,
"domNodes": -270,
"jsHeapTotalBytes": -1699840,
"scriptDurationMs": 785.162,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3617.500000000007,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.785999999999998,
"layouts": 60,
"layoutDurationMs": 12.096,
"taskDurationMs": 1725.3970000000002,
"heapDeltaBytes": 8202604,
"heapUsedBytes": 75905460,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 754.4660000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3574.237000000039,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.004,
"layouts": 60,
"layoutDurationMs": 12.299000000000001,
"taskDurationMs": 1698.349,
"heapDeltaBytes": 11715880,
"heapUsedBytes": 79610388,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 732.4219999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3084.295999999995,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.030000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1883.016,
"heapDeltaBytes": 17833452,
"heapUsedBytes": 85207680,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 904.5269999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 3101.216000000022,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.771000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1914.2069999999999,
"heapDeltaBytes": 18205836,
"heapUsedBytes": 84753112,
"domNodes": 2,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 917.8879999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2022.1149999999852,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.758,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 610.923,
"heapDeltaBytes": 10570980,
"heapUsedBytes": 87007984,
"domNodes": -264,
"jsHeapTotalBytes": -1400832,
"scriptDurationMs": 32.199999999999996,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2024.387000000047,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.1540000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.7839999999999,
"heapDeltaBytes": 10269464,
"heapUsedBytes": 87212700,
"domNodes": -275,
"jsHeapTotalBytes": -1925120,
"scriptDurationMs": 30.350999999999996,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.854000000008,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.978000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.992,
"heapDeltaBytes": 15161164,
"heapUsedBytes": 87959936,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 132.39499999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 629.1670000000522,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.745999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.895,
"heapDeltaBytes": 15220368,
"heapUsedBytes": 87876032,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 140.75400000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.1990000000242,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.752,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.247,
"heapDeltaBytes": -7328232,
"heapUsedBytes": 65331036,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.347999999999997,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.7789999999477,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.980999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.8009999999999,
"heapDeltaBytes": -14835176,
"heapUsedBytes": 57635272,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.496,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.58299999999,
"styleRecalcs": 78,
"styleRecalcDurationMs": 36.376,
"layouts": 18,
"layoutDurationMs": 5.421,
"taskDurationMs": 834.4449999999999,
"heapDeltaBytes": -808320,
"heapUsedBytes": 71167096,
"domNodes": -293,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 98.41,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1774.3229999999812,
"styleRecalcs": 77,
"styleRecalcDurationMs": 42.498,
"layouts": 18,
"layoutDurationMs": 6.024,
"taskDurationMs": 896.5070000000001,
"heapDeltaBytes": -13051888,
"heapUsedBytes": 59704928,
"domNodes": -295,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 105.128,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.7059999999765,
"styleRecalcs": 16,
"styleRecalcDurationMs": 28.873999999999995,
"layouts": 12,
"layoutDurationMs": 13.513,
"taskDurationMs": 944.6820000000002,
"heapDeltaBytes": 21920588,
"heapUsedBytes": 104922072,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 32.018,
"eventListeners": 2383,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8432.670000000031,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.737,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5757.137000000001,
"heapDeltaBytes": -7523596,
"heapUsedBytes": 93026128,
"domNodes": -265,
"jsHeapTotalBytes": -876544,
"scriptDurationMs": 2569.4300000000003,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9081.977999999935,
"styleRecalcs": 245,
"styleRecalcDurationMs": 34.124,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6388.51,
"heapDeltaBytes": 22661128,
"heapUsedBytes": 98946956,
"domNodes": -273,
"jsHeapTotalBytes": -1437696,
"scriptDurationMs": 2870.221,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16069.172000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15367.212000000001,
"heapDeltaBytes": -30129680,
"heapUsedBytes": 180078876,
"domNodes": -6548,
"jsHeapTotalBytes": 7852032,
"scriptDurationMs": 250.54500000000002,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 15854.745999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15132.248,
"heapDeltaBytes": -13667932,
"heapUsedBytes": 175235056,
"domNodes": -6548,
"jsHeapTotalBytes": 3919872,
"scriptDurationMs": 262.839,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18843.605000000025,
"styleRecalcs": 144,
"styleRecalcDurationMs": 17.683000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18543.013,
"heapDeltaBytes": -16380204,
"heapUsedBytes": 186291508,
"domNodes": -6548,
"jsHeapTotalBytes": 1257472,
"scriptDurationMs": 888.269,
"eventListeners": -7471,
"totalBlockingTimeMs": 93,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 19002.01700000002,
"styleRecalcs": 145,
"styleRecalcDurationMs": 17.27300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18721.746,
"heapDeltaBytes": -23629072,
"heapUsedBytes": 189882800,
"domNodes": -6548,
"jsHeapTotalBytes": -8224768,
"scriptDurationMs": 865.866,
"eventListeners": -7471,
"totalBlockingTimeMs": 14,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5585.608999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.71300000000002,
"layouts": 20,
"layoutDurationMs": 24.592000000000002,
"taskDurationMs": 5500.893,
"heapDeltaBytes": -41162680,
"heapUsedBytes": 175003688,
"domNodes": -6548,
"jsHeapTotalBytes": 9424896,
"scriptDurationMs": 113.941,
"eventListeners": -7471,
"totalBlockingTimeMs": 311,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5648.46799999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.315,
"layouts": 20,
"layoutDurationMs": 31.691999999999997,
"taskDurationMs": 5528.5650000000005,
"heapDeltaBytes": -27066660,
"heapUsedBytes": 180564664,
"domNodes": -6578,
"jsHeapTotalBytes": 233472,
"scriptDurationMs": 94.92800000000001,
"eventListeners": -7491,
"totalBlockingTimeMs": 283,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 475.3969999999299,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.249000000000006,
"layouts": 4,
"layoutDurationMs": 1.9369999999999998,
"taskDurationMs": 119.99900000000001,
"heapDeltaBytes": 5052140,
"heapUsedBytes": 73910280,
"domNodes": 147,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 11.880999999999998,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 444.9259999998958,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.284999999999997,
"layouts": 3,
"layoutDurationMs": 0.9449999999999998,
"taskDurationMs": 99.194,
"heapDeltaBytes": 4778096,
"heapUsedBytes": 73269248,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.953999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Warning Review limit reachedNext included review available in 39 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughAdded Playwright coverage for video asset multi-selection. The test mocks video assets and view responses, then validates plain clicks, Ctrl/Cmd-click selection, Shift-click range selection, deselection, and bulk action controls. ChangesVideo asset selection tests
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR adds focused coverage for modifier-based multi-selection of video assets without changing product behavior. No actionable merge-blocking risk remains beyond normal checks and review. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15655 +/- ##
==========================================
+ Coverage 80.73% 82.35% +1.61%
==========================================
Files 2438 2029 -409
Lines 124324 117082 -7242
Branches 32894 29350 -3544
==========================================
- Hits 100378 96424 -3954
+ Misses 23444 20480 -2964
+ Partials 502 178 -324
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Video is the one media kind whose plain preview click is deliberately swallowed so the clip plays instead of selecting, which leaves the modifier paths as the only way to build a multi-selection on it. Nothing covered that, so a regression in the guard would make video assets unselectable while images kept working. Part of the QA test plan for cloud 1.50 -> 1.51 (Asset Management).
bc00937 to
f220430
Compare
|
Rebased onto current Full context for agent readers
|
PR Created by the Glary-Bot Agent
Automates one item from the QA test plan for cloud 1.50 → 1.51 (Asset Management, #14347 / #14765 / #14848 / #14858):
Why this item needs its own test
Video is the one media kind whose plain preview click is deliberately swallowed —
MediaAssetCard.handlePreviewClickreturns early forfileKind === 'video'so a click plays the clip instead of selecting it. That early return is skipped only while a selection modifier is held, which makes the modifier paths the only way to build a multi-selection on video.Nothing covered that. A regression in the guard would silently make video assets unselectable while images kept working. No existing spec covered shift-range click on assets of any kind.
What it asserts
Against three mocked video jobs, in one test:
Selection is read from real state —
[data-selected="true"]counts plus the footer text — not from the click merely succeeding.Verification
MediaAssetCard.handlePreviewClick(if (fileKind.value === 'video') return) turns the test red. It is not a vacuous pass.pnpm lint,pnpm format:check,pnpm typecheckclean.Uses
ControlOrMetaso the Cmd path is exercised on macOS runners rather than only Ctrl.plain_video.mp4is served for the mocked/api/viewresponses so the cards mount a real<video>element.Screenshots