Repository navigation
test: pin literal rendering of HTML in node-search results - #15656
Conversation
🎭 Playwright: ✅ 2008 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.37 MB gzip 🔴 +905 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • 🟢 -1.76 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 592 kB (baseline 592 kB) • 🔴 +289 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 115 kB (baseline 115 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.53 MB (baseline 3.53 MB) • 🟢 -2.49 kBStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 16 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 15.1 MB (baseline 15.1 MB) • 🔴 +7.49 kBBundles that do not match a named category
Status: 80 added / 80 removed / 212 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-26T00:54:54.911Z",
"gitSha": "74394412cb4282a5874ec05a497880e8cb108ba9",
"branch": "glary/test-node-search-html-escaping",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.9319999999689,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.433,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.39900000000006,
"heapDeltaBytes": -14864272,
"heapUsedBytes": 57048788,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.943,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2041.0809999999628,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.7,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.986,
"heapDeltaBytes": -3744584,
"heapUsedBytes": 68704880,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.829,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2352.56899999996,
"styleRecalcs": 78,
"styleRecalcDurationMs": 49.08800000000001,
"layouts": 12,
"layoutDurationMs": 3.8389999999999995,
"taskDurationMs": 1411.839,
"heapDeltaBytes": 8267984,
"heapUsedBytes": 80162876,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 177.68300000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2186.900000000037,
"styleRecalcs": 78,
"styleRecalcDurationMs": 42.21900000000001,
"layouts": 12,
"layoutDurationMs": 3.901,
"taskDurationMs": 1224.4229999999998,
"heapDeltaBytes": 5652436,
"heapUsedBytes": 78018440,
"domNodes": -284,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 153.884,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.215999999989,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.4,
"layouts": 6,
"layoutDurationMs": 0.9039999999999999,
"taskDurationMs": 382.92900000000003,
"heapDeltaBytes": 4374660,
"heapUsedBytes": 76684116,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.078999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1713.7769999999364,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.478,
"layouts": 6,
"layoutDurationMs": 0.537,
"taskDurationMs": 372.51900000000006,
"heapDeltaBytes": 4292620,
"heapUsedBytes": 76803608,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.688,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 992.5429999999551,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.1400000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 729.1000000000001,
"heapDeltaBytes": 7763812,
"heapUsedBytes": 79383908,
"domNodes": 16,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 151.125,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 971.4500000000044,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.624000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 719.1659999999999,
"heapDeltaBytes": 6772780,
"heapUsedBytes": 79112816,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 149.27,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.3310000000088,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.459,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.662,
"heapDeltaBytes": -1544300,
"heapUsedBytes": 77372456,
"domNodes": -270,
"jsHeapTotalBytes": -1880064,
"scriptDurationMs": 44.28900000000001,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2030.4219999999304,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.773000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.1120000000001,
"heapDeltaBytes": -2615652,
"heapUsedBytes": 76897892,
"domNodes": -270,
"jsHeapTotalBytes": -1880064,
"scriptDurationMs": 35.907999999999994,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3161.2440000000106,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.533000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2533.083,
"heapDeltaBytes": 21636416,
"heapUsedBytes": 86524168,
"domNodes": -272,
"jsHeapTotalBytes": 3371008,
"scriptDurationMs": 887.056,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3267.744999999991,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.953999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2466.7799999999997,
"heapDeltaBytes": 777184,
"heapUsedBytes": 66014696,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 885.698,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 4260.114999999985,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.671999999999999,
"layouts": 60,
"layoutDurationMs": 7.611000000000001,
"taskDurationMs": 2418.0739999999996,
"heapDeltaBytes": -3512220,
"heapUsedBytes": 67261884,
"domNodes": 24,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 818.1220000000001,
"eventListeners": 12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4279.953999999975,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.483999999999998,
"layouts": 60,
"layoutDurationMs": 7.107,
"taskDurationMs": 2439.761,
"heapDeltaBytes": -2789656,
"heapUsedBytes": 67886628,
"domNodes": 24,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 831.3,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 5086.822999999981,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.780000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3737.906,
"heapDeltaBytes": 23302212,
"heapUsedBytes": 91280208,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 1063.5110000000002,
"eventListeners": 194,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 4989.832000000092,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.8519999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3640.709,
"heapDeltaBytes": 23351408,
"heapUsedBytes": 91797848,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 997.056,
"eventListeners": 192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1998.974999999973,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.6959999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.839,
"heapDeltaBytes": 12731428,
"heapUsedBytes": 77724744,
"domNodes": -278,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.381,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2051.8220000000156,
"styleRecalcs": 2,
"styleRecalcDurationMs": 7.949000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.2479999999999,
"heapDeltaBytes": -3578564,
"heapUsedBytes": 77543584,
"domNodes": -276,
"jsHeapTotalBytes": -2142208,
"scriptDurationMs": 34.922,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 711.3679999999931,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.267,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.3449999999999,
"heapDeltaBytes": -7907260,
"heapUsedBytes": 64790704,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 138.397,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 736.9919999999865,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.749999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.1049999999999,
"heapDeltaBytes": -7390452,
"heapUsedBytes": 64787216,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 136.895,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.1709999999907,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.583999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.2939999999999,
"heapDeltaBytes": -11445600,
"heapUsedBytes": 61347380,
"domNodes": -297,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.734,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.0540000000256,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.137999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.644,
"heapDeltaBytes": -15542860,
"heapUsedBytes": 56469536,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.938999999999998,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1909.846000000016,
"styleRecalcs": 79,
"styleRecalcDurationMs": 39.951,
"layouts": 16,
"layoutDurationMs": 4.55,
"taskDurationMs": 1139.548,
"heapDeltaBytes": -3094580,
"heapUsedBytes": 69779052,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 113.61999999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1888.908000000015,
"styleRecalcs": 79,
"styleRecalcDurationMs": 38.48,
"layouts": 16,
"layoutDurationMs": 4.506,
"taskDurationMs": 1119.637,
"heapDeltaBytes": -4397604,
"heapUsedBytes": 68066988,
"domNodes": -294,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 114.684,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1398.8259999999855,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.657000000000004,
"layouts": 14,
"layoutDurationMs": 14.561000000000005,
"taskDurationMs": 950.4490000000001,
"heapDeltaBytes": -22224,
"heapUsedBytes": 96953624,
"domNodes": 13671,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.769999999999992,
"eventListeners": 2383,
"totalBlockingTimeMs": 136,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 12300.292000000012,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.454,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8594.181,
"heapDeltaBytes": 730180,
"heapUsedBytes": 79635696,
"domNodes": -272,
"jsHeapTotalBytes": 3031040,
"scriptDurationMs": 2920.0879999999997,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 12391.014000000041,
"styleRecalcs": 246,
"styleRecalcDurationMs": 34.792,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8659.857,
"heapDeltaBytes": 2832848,
"heapUsedBytes": 81195200,
"domNodes": -284,
"jsHeapTotalBytes": 2506752,
"scriptDurationMs": 2976.169,
"eventListeners": -159,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17742.45000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16971.661,
"heapDeltaBytes": -31088056,
"heapUsedBytes": 175435460,
"domNodes": -6548,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 360.3970000000001,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17857.548999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17014.874,
"heapDeltaBytes": -25615460,
"heapUsedBytes": 180562052,
"domNodes": -6548,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 332.451,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21315.75700000002,
"styleRecalcs": 168,
"styleRecalcDurationMs": 18.666000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20943.406000000003,
"heapDeltaBytes": -15784924,
"heapUsedBytes": 190682396,
"domNodes": -6548,
"jsHeapTotalBytes": -1351680,
"scriptDurationMs": 894.054,
"eventListeners": -7471,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21345.511999999984,
"styleRecalcs": 172,
"styleRecalcDurationMs": 20.48899999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20961.909,
"heapDeltaBytes": -28656688,
"heapUsedBytes": 177159984,
"domNodes": -6548,
"jsHeapTotalBytes": 2347008,
"scriptDurationMs": 938.0509999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 74,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 504.0920000000142,
"styleRecalcs": 20,
"styleRecalcDurationMs": 26.657,
"layouts": 3,
"layoutDurationMs": 1.2099999999999997,
"taskDurationMs": 163.57700000000003,
"heapDeltaBytes": 6227236,
"heapUsedBytes": 74782364,
"domNodes": 148,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.515000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 467.4969999999803,
"styleRecalcs": 14,
"styleRecalcDurationMs": 22.479,
"layouts": 3,
"layoutDurationMs": 0.6719999999999999,
"taskDurationMs": 127.27100000000003,
"heapDeltaBytes": 5853228,
"heapUsedBytes": 74637724,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.437999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. 📝 WalkthroughWalkthroughAdds a reusable helper for creating test nodes from donor definitions. Adds an end-to-end regression test that verifies node display names render HTML payloads as literal text during node search. ChangesNode Metadata XSS Regression
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized test-only change adds coverage for literal HTML rendering in node-search results, with no actionable merge-blocking risk remaining after normal checks and review. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: Description checkExplanation The description provides a clear summary, detailed scope, test assertions, rationale, verification results, and a screenshot. It does not use every template heading or explicitly state breaking changes and dependencies, but it contains the required information and is mostly complete. Full details: End-To-End Regression Coverage For FixesExplanation The changed-file list is available and shows changes only under Full details: Website End-To-End Regression CoverageExplanation PASS. The changed files are Full details: Adr Compliance For Entity/Litegraph ChangesExplanation PASS. The PR changes only
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15656 +/- ##
==========================================
+ Coverage 79.39% 82.54% +3.15%
==========================================
Files 2217 1967 -250
Lines 112188 112274 +86
Branches 35091 34952 -139
==========================================
+ Hits 89069 92681 +3612
+ Misses 22640 19255 -3385
+ Partials 479 338 -141
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Thanks — the review landed as approved with "No actionable comments were generated", so there's nothing for me to change here. No code pushed. Two things worth recording now that CI has finished, since both were open questions when I opened this: 1. The runtime concern is resolved. I flagged in the description that the 2. The one red check is On the "End-To-End Regression Coverage For Fixes" pre-merge check coming back inconclusive: that rule looks for e2e coverage accompanying a bug fix. This PR fixes no bug — it is e2e coverage — so the condition doesn't apply. CodeRabbit reported it couldn't read the PR title/commit subjects rather than finding an actual gap. For reviewers, the substantive claim to check is that the test isn't a vacuous pass. I verified that by mutation: deleting the modifier exemption in |
|
Noting for the record: CodeRabbit didn't actually review this one — it hit the org's Fair Usage rate limit ("Review limit reached", next slot in ~58 min) and posted the limit notice instead of findings. So there's no feedback to address and I've pushed nothing. It should pick this up automatically on the next reset or on a new commit. Meanwhile CI has finished and is clean, which covers the main risk I called out in the description:
That resolves the open question from the description: I could only verify this locally in a slow sandbox where the run took ~23s with a raised The claim most worth a reviewer's attention is that the test can actually fail. I checked by mutation: switching Also flagging one judgement call explicitly, since it's the part I'd most want challenged: the QA plan phrases this item as "type a query containing HTML characters", but the query never reaches the DOM — |
|
Thanks — the review landed as approved with "No actionable comments were generated", so there's nothing for me to change here. No code pushed. Two things worth recording now that CI has finished, since both were open questions when I opened this: 1. The runtime concern is resolved. I flagged in the description that the 2. The one red check is On the "End-To-End Regression Coverage For Fixes" pre-merge check coming back inconclusive: that rule looks for e2e coverage accompanying a bug fix. This PR fixes no bug — it is e2e coverage — so the condition doesn't apply. CodeRabbit reported it couldn't read the PR title/commit subjects rather than finding an actual gap. For reviewers, the substantive claim to check is that the test isn't a vacuous pass. I verified that by mutation: deleting the modifier exemption in (Apologies for the noise — an earlier copy of this comment went to #15656 by mistake.) |
|
Correction: the comment above beginning "Thanks — the review landed as approved…" was misfiled. It belongs to #15655 (the video-asset multi-select PR) and has been reposted there. Please disregard it on this PR — CodeRabbit has not approved #15656; it was rate-limited before it could review. The comment that does apply to this PR is the one beginning "Noting for the record: CodeRabbit didn't actually review this one…". |
|
Final correction, and then I'll stop adding noise here — apologies for the clutter. What applies to this PR (#15656): only the comment beginning "Noting for the record: CodeRabbit didn't actually review this one…". CodeRabbit was rate-limited on this PR and has not reviewed it. No approval, no findings, no code pushed. What does not apply: the two duplicated comments beginning "Thanks — the review landed as approved…". Those describe #15655 and were posted here by mistake. My correction just above them claimed they had been "reposted there" — that turned out to be wrong too: my commenting tool resolves to this PR regardless of which branch I'm on, so the retry landed here as well. I can't delete them, hence this note. Nothing in those two comments should be read as applying to #15656. Substance that does apply to this PR, unchanged: CI is green — all 16 |
benjcooley
left a comment
There was a problem hiding this comment.
Review summary
The test is sound: it does exercise a real path (object_info -> node-def store -> v2 dialog), the payload survives whitespace normalization in toContainText, the v2 result list is not virtualized so results.filter({hasText}) will find the item, and highlightQuery() emits every slice of the text so the concatenated textContent is the full display name. ensureV2Search() -> reloadAndWaitForApp() is correctly ordered (settingStore.set awaits api.storeSetting), and the **/object_info route matches /api/object_info. No blockers.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 2 |
| TRIVIAL | 3 |
Main points: the shared helper hands out a shallow clone that aliases the donor's nested input/output objects, and the onerror half of the payload is dead weight — nothing ever reads the global it sets, so the comment claiming it "cannot pass silently" is not earned by the code.
The search result label reassembles a node's display name around the query, making the display name the one place arbitrary text reaches that DOM. NodeSearchListItem.test.ts already pins the escaping at the component level, so this covers the narrower slice that test cannot reach: that nothing between the object_info response and the component writes the display name as innerHTML on the way through. Injects a node whose display name carries an img/onerror payload and asserts it survives as text, with no element created and the handler never firing anywhere on the page. Lives alongside the existing XSS surfaces in xss.spec.ts. The shared object_info helper deep-clones its donor so a later mutator aimed at the clone cannot rewrite the real node. Part of the QA test plan for cloud 1.50 -> 1.51 (Node Search Highlights).
cfe269f to
d8a9571
Compare
|
All five review points are addressed and pushed (
The PR is now two modified files and no new ones. CI is fully green on the updated commit — 57 checks passed, 0 failures, including all 16 Both mutations still fail the test after the move — the |
benjcooley
left a comment
There was a problem hiding this comment.
Re-reviewed at d8a9571. All five points addressed: structuredClone in the helper, the XSS flag is now actually read, the header claim is narrowed to what the test really pins, and it moved into the existing xss.spec.ts (which also picks up comfyExpect).
Checked the new version: structuredClone is fine in the route-handler context, flag in window typechecks without a cast, and the non-retrying evaluate read is safe since it runs after the retrying assertions have settled. No new issues — good to merge from my side.
|
Thanks for the re-review, and for checking the three things I couldn't fully self-verify — Nothing further from me. One note in case it's useful for the sibling PR (#15655, the video-asset multi-select one): |
benjcooley
left a comment
There was a problem hiding this comment.
Approving at d8a9571. All review findings addressed; re-verified the helper's deep clone, the XSS-flag assertion, and the move into the existing xss.spec.ts.
|
No residual work. All five review findings were fixed before merge and remain on current Full context for agent readersVerified against current
No duplicate follow-up carrier references #15656, and current main preserves the reviewed implementation and regression coverage. Glossary: XSS means cross-site scripting; |
|
Confirmed — I re-verified your checks independently against current
Agreed: no residual work on #15656. One thing outside this PR's scope that the "no follow-up needed" conclusion shouldn't be read to cover: the sibling PR #15655 ( For whoever picks it up — I checked, and it has not gone stale despite the 198-commit drift:
It was approved by CodeRabbit with all Playwright checks green; the only red was |
|
Thanks for the rebase. I verified it rather than assuming, and it's clean:
Fresh CI on Worth noting for anyone who saw the earlier state: the I also confirmed the test hasn't been quietly invalidated by the ~200 commits of drift: the guard it pins, The only thing left is flipping it out of draft — I have no tool to do that, and this sandbox's GitHub token has since expired, so that one needs a maintainer. Nothing outstanding from my side. |
PR Created by the Glary-Bot Agent
Automates one item from the QA test plan for cloud 1.50 → 1.51 (Node Search Highlights, #14789):
A note on what the plan item actually means
The plan phrases this as a property of the query, but the query never reaches the DOM:
highlightQuery()only ever emits slices of the node's display name, split around the match. So the display name is the real injection point, and asserting on the query would be vacuous. This test targets the display name and says so in the file header.What it asserts
Patches
object_info(via the existingrouteObjectInfoFromSetupApi) to add a node whose display name carries an<img src=x onerror=...>payload, then searches for it and asserts:imgelement was createdonerroris used deliberately — a payload that gets parsed cannot pass silently.Why an e2e when a unit test exists
NodeSearchListItem.test.tsalready covers escaping at the component level, and this does not replace it. The layer it adds is the one the unit test cannot reach: a node definition travelling fromobject_infothrough the node-def store into the v2 search dialog.eslintbansv-htmlundersrc/components/searchbox/, but a rawinnerHTMLassignment anywhere along that path would slip past both the linter and the component test.Verification
HighlightedText.vuetov-htmlturns the test red — the payload is parsed as markup and disappears from the rendered text ("HtmlEscapingProbe Comfytesting"). It is not a vacuous pass.pnpm lint,pnpm format:check,pnpm typecheckclean.The node-cloning helper is added to
browser_tests/fixtures/utils/objectInfo.tsalongside the existingobject_infomutators rather than living in the spec.Screenshots