Skip to content

[backport cloud/1.50] fix(errors): keep missing node packs across prompt submissions - #15514

Merged
comfy-pr-bot merged 1 commit into
cloud/1.50from
backport-14900-to-cloud-1.50
Aug 21, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.50from
backport-14900-to-cloud-1.50

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #14900 to cloud/1.50

Automatically created by backport workflow.

## Summary

Pressing Run emptied the missing-node-pack rows from the Errors tab; the
nodes were still missing, the panel just stopped saying so.

## Changes

- **What**: `clearAllErrors` was shared by `queuePrompt` ("forget the
last run") and `clean()` ("forget this graph"), and cleared missing-node
state for both. A submission carries no evidence about the environment —
it never checks whether the pack was installed — so it cannot justify
dropping the row. The clear moves to `clean()`, and the function is
renamed `clearRunErrors` to match what it now does.

Missing **model** and **media** state already followed this rule:
`clearAllErrors` never touched it, and it is cleared in `loadGraphData`
instead. This aligns missing nodes with the two resources that were
already right; it does not change when models or media are cleared.

Production change is four lines.

## Review Focus

**Every discard path still clears.** `clean()` is reached by
`loadGraphData`, `loadApiJson`, `Comfy.ClearWorkflow`
(`useCoreCommands.ts:279`) and the legacy Clear button (`ui.ts:680`).

**Except one, which needed the clear spelled out.** The A1111 import
replaces the graph from inside `importA1111` through a
`beforeGraphClear` callback and never reaches `clean()`, so it already
left the store describing the outgoing graph. That was survivable only
because the next submission happened to wipe it — with submissions no
longer clearing, the stale rows would persist indefinitely.
`afterLoadNewGraph` does not call `showPendingWarnings`, so nothing else
re-syncs that path. The callback runs after the parameters and required
core nodes validate, so a failed import keeps the current state.

**What this deliberately does not do.** An earlier version of this PR
generalised the same rule to the missing-model and missing-media stores.
It was abandoned: those two carry async verification that outlives the
graph that started it, plus a per-workflow cache and a two-tier repair
state, and unifying them produced five separate defects (cache
resurrection after discard, cache not synced on per-node removal,
verification not aborted, an abort whose signal was passed but never
checked after the await, and the A1111 bypass for all three resources).
None of that is in this PR. It is written up separately and will be its
own change.

## Verification

Four tests, each mutation-proved — revert the production line, watch the
named test fail, restore, watch it pass:

| mutation | fails |
|---|---|
| restore the clear inside `clearRunErrors` | `preserves missing node
packs when submitting a prompt`, store test, E2E |
| drop `clean()`'s clear | `clears missing node packs when the graph is
discarded` |
| drop the A1111 callback clear | `clears missing node packs, which its
graph swap skips clean() for` |
| drop `queuePrompt`'s `clearRunErrors()` | queue unit test |

The E2E (`errorsTabMissingNodes.spec.ts`) waits on the `POST
/api/prompt` response before re-asserting, so it observes the state
after the submit path has run rather than racing it.

`pnpm typecheck`, `pnpm typecheck:browser`, `pnpm lint` (0 errors),
`pnpm knip`, `pnpm format` all clean; 88 unit tests and the E2E pass.

Replaces #14557.
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 21, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) August 21, 2026 01:48
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 21, 2026
@github-actions

github-actions Bot commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1803 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1782 / ❌ 0 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/21/2026, 01:50:51 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 45.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 112ms TBT · 96.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.2 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 157.7 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 295ms TBT · 167.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 518ms
canvas-idle: script duration 21ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.2 MB
canvas-idle: DOM nodes 19
canvas-idle: event listeners 4
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 41ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 974ms
canvas-mouse-sweep: script duration 123ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 45.6 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -153
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 397ms
canvas-zoom-sweep: script duration 22ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.1 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 395ms
dom-widget-clipping: script duration 60ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 51.1 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 736ms
large-graph-idle: script duration 112ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 62.2 MB
large-graph-idle: DOM nodes -282
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 15ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1267ms
large-graph-pan: script duration 405ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 61.1 MB
large-graph-pan: DOM nodes -283
large-graph-pan: event listeners -148
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1529ms
large-graph-zoom: script duration 537ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 69.0 MB
large-graph-zoom: DOM nodes -139
large-graph-zoom: event listeners -73
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 724ms
minimap-idle: script duration 111ms
minimap-idle: TBT 0ms
minimap-idle: heap used 64.5 MB
minimap-idle: DOM nodes -284
minimap-idle: event listeners -148
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 403ms
subgraph-dom-widget-clipping: script duration 120ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 51.6 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 482ms
subgraph-idle: script duration 17ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.5 MB
subgraph-idle: DOM nodes 19
subgraph-idle: event listeners 4
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 39ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 794ms
subgraph-mouse-sweep: script duration 94ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 58.5 MB
subgraph-mouse-sweep: DOM nodes 64
subgraph-mouse-sweep: event listeners 4
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 933ms
subgraph-transition-enter: script duration 34ms
subgraph-transition-enter: TBT 112ms
subgraph-transition-enter: heap used 96.5 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2375
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 42ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4498ms
viewport-pan-sweep: script duration 1338ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 74.2 MB
viewport-pan-sweep: DOM nodes -281
viewport-pan-sweep: event listeners -148
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 15666ms
vue-large-graph-idle: script duration 549ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 157.7 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16390
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 21ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 150
vue-large-graph-pan: task duration 21337ms
vue-large-graph-pan: script duration 893ms
vue-large-graph-pan: TBT 295ms
vue-large-graph-pan: heap used 167.1 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16382
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 104ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 65.6 MB
workflow-execution: DOM nodes 124
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-08-21T02:00:47.017Z",
  "gitSha": "90bfb5bcc71aa79fdbdc3af135cbbe9af985ab69",
  "branch": "backport-14900-to-cloud-1.50",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2001.687000000004,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.496,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 548.564,
      "heapDeltaBytes": 5809028,
      "heapUsedBytes": 70388588,
      "domNodes": 18,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 23.656000000000002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2023.8789999999653,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.931,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 486.64300000000003,
      "heapDeltaBytes": 5978732,
      "heapUsedBytes": 70543916,
      "domNodes": 20,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 18.664,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1984.8599999999692,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 45.173,
      "layouts": 12,
      "layoutDurationMs": 3.93,
      "taskDurationMs": 1055.242,
      "heapDeltaBytes": -16522968,
      "heapUsedBytes": 47976700,
      "domNodes": -275,
      "jsHeapTotalBytes": 23568384,
      "scriptDurationMs": 129.551,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1823.9340000000084,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 36.998000000000005,
      "layouts": 12,
      "layoutDurationMs": 3.651,
      "taskDurationMs": 892.0840000000001,
      "heapDeltaBytes": -17100676,
      "heapUsedBytes": 47664212,
      "domNodes": -282,
      "jsHeapTotalBytes": 24616960,
      "scriptDurationMs": 116.58500000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1736.4180000000147,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.891000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.6719999999999998,
      "taskDurationMs": 409.9680000000001,
      "heapDeltaBytes": 8798984,
      "heapUsedBytes": 73497740,
      "domNodes": 78,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 22.964,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1740.7020000000557,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.791,
      "layouts": 6,
      "layoutDurationMs": 0.699,
      "taskDurationMs": 383.78700000000003,
      "heapDeltaBytes": 8903728,
      "heapUsedBytes": 73525236,
      "domNodes": 77,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 20.765,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 590.073000000018,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.317000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 387.813,
      "heapDeltaBytes": -11037420,
      "heapUsedBytes": 53581084,
      "domNodes": 18,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 58.946000000000005,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 623.1810000000451,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.945999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.31999999999994,
      "heapDeltaBytes": -11186516,
      "heapUsedBytes": 53594064,
      "domNodes": 18,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 61.748,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2045.0270000000046,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.7090000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 769.7819999999999,
      "heapDeltaBytes": 2892096,
      "heapUsedBytes": 62709412,
      "domNodes": -282,
      "jsHeapTotalBytes": 3772416,
      "scriptDurationMs": 117.549,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2028.5860000000184,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.869,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 702.2420000000001,
      "heapDeltaBytes": 6875576,
      "heapUsedBytes": 67720572,
      "domNodes": -282,
      "jsHeapTotalBytes": 3510272,
      "scriptDurationMs": 107.04399999999998,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2168.608000000006,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.981000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1278.802,
      "heapDeltaBytes": 4246116,
      "heapUsedBytes": 65100116,
      "domNodes": -284,
      "jsHeapTotalBytes": 3702784,
      "scriptDurationMs": 406.36100000000005,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2153.0460000000176,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 15.256000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1254.231,
      "heapDeltaBytes": 1529184,
      "heapUsedBytes": 62980908,
      "domNodes": -282,
      "jsHeapTotalBytes": 3178496,
      "scriptDurationMs": 403.467,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3163.7909999999465,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.573,
      "layouts": 60,
      "layoutDurationMs": 8.307,
      "taskDurationMs": 1512.837,
      "heapDeltaBytes": 23447092,
      "heapUsedBytes": 86001832,
      "domNodes": 12,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 538.654,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3181.349999999952,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.847999999999997,
      "layouts": 60,
      "layoutDurationMs": 8.182,
      "taskDurationMs": 1545.3049999999998,
      "heapDeltaBytes": -3786800,
      "heapUsedBytes": 58676532,
      "domNodes": -289,
      "jsHeapTotalBytes": 6393856,
      "scriptDurationMs": 535.859,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.520999999998,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.482999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 732.0470000000001,
      "heapDeltaBytes": 6924072,
      "heapUsedBytes": 67834412,
      "domNodes": -283,
      "jsHeapTotalBytes": 3510272,
      "scriptDurationMs": 111.461,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2022.248999999988,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.469999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 716.4200000000001,
      "heapDeltaBytes": 6544520,
      "heapUsedBytes": 67500220,
      "domNodes": -284,
      "jsHeapTotalBytes": 2723840,
      "scriptDurationMs": 111.47299999999998,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 593.1120000000192,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.930000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.70400000000006,
      "heapDeltaBytes": -10797216,
      "heapUsedBytes": 53789968,
      "domNodes": 18,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 121.194,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 603.1950000000279,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 10.864999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 405.17,
      "heapDeltaBytes": -10347400,
      "heapUsedBytes": 54436104,
      "domNodes": 22,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 119.066,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2024.1329999999493,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.043,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.181,
      "heapDeltaBytes": 5994928,
      "heapUsedBytes": 70829472,
      "domNodes": 20,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 18.156,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.1770000000934,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.303999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 463.84799999999996,
      "heapDeltaBytes": 5946888,
      "heapUsedBytes": 70715432,
      "domNodes": 18,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 15.292000000000002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1766.1829999999554,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 39.698,
      "layouts": 16,
      "layoutDurationMs": 4.642,
      "taskDurationMs": 827.645,
      "heapDeltaBytes": -3196336,
      "heapUsedBytes": 61345168,
      "domNodes": 66,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 94.63,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1738.332000000014,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 37.388999999999996,
      "layouts": 16,
      "layoutDurationMs": 4.356999999999999,
      "taskDurationMs": 761.261,
      "heapDeltaBytes": -3344132,
      "heapUsedBytes": 61356348,
      "domNodes": 62,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 93.14399999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.5430000000079,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 29.143,
      "layouts": 14,
      "layoutDurationMs": 11.077,
      "taskDurationMs": 932.7220000000001,
      "heapDeltaBytes": 8867240,
      "heapUsedBytes": 101198532,
      "domNodes": 13673,
      "jsHeapTotalBytes": 11796480,
      "scriptDurationMs": 34.08299999999999,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 112,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8279.562999999996,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 42.271,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4590.407,
      "heapDeltaBytes": 26839876,
      "heapUsedBytes": 86651728,
      "domNodes": -280,
      "jsHeapTotalBytes": 6324224,
      "scriptDurationMs": 1347.832,
      "eventListeners": -163,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8193.083999999999,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 41.92,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4405.643,
      "heapDeltaBytes": 9113904,
      "heapUsedBytes": 69004324,
      "domNodes": -282,
      "jsHeapTotalBytes": 5537792,
      "scriptDurationMs": 1328.673,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17928.854,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17896.75,
      "heapDeltaBytes": -38099768,
      "heapUsedBytes": 160092472,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9641984,
      "scriptDurationMs": 568.3620000000001,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13449.82200000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13435.265000000001,
      "heapDeltaBytes": -48332556,
      "heapUsedBytes": 170707260,
      "domNodes": -8312,
      "jsHeapTotalBytes": -5971968,
      "scriptDurationMs": 529.833,
      "eventListeners": -16393,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21230.309000000034,
      "styleRecalcs": 146,
      "styleRecalcDurationMs": 19.94800000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21202.126,
      "heapDeltaBytes": -34604228,
      "heapUsedBytes": 178701732,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10498048,
      "scriptDurationMs": 898.7779999999999,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 275,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21496.218,
      "styleRecalcs": 153,
      "styleRecalcDurationMs": 22.18500000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21472.79,
      "heapDeltaBytes": -55517188,
      "heapUsedBytes": 171651820,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10235904,
      "scriptDurationMs": 886.2880000000001,
      "eventListeners": -16381,
      "totalBlockingTimeMs": 315,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 446.71999999991385,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 16.554,
      "layouts": 2,
      "layoutDurationMs": 0.36399999999999993,
      "taskDurationMs": 103.683,
      "heapDeltaBytes": 5062872,
      "heapUsedBytes": 68862464,
      "domNodes": 126,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.05,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 450.9049999999206,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 18.289999999999996,
      "layouts": 3,
      "layoutDurationMs": 0.6609999999999999,
      "taskDurationMs": 104.628,
      "heapDeltaBytes": 5037552,
      "heapUsedBytes": 68788372,
      "domNodes": 121,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 9.766000000000002,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    }
  ]
}

@comfy-pr-bot
comfy-pr-bot merged commit ccea935 into cloud/1.50 Aug 21, 2026
77 of 79 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-14900-to-cloud-1.50 branch August 21, 2026 02:03
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.50   #15514   +/-   ##
=============================================
  Coverage              ?   81.34%           
=============================================
  Files                 ?     1872           
  Lines                 ?   106315           
  Branches              ?    32307           
=============================================
  Hits                  ?    86480           
  Misses                ?    19480           
  Partials              ?      355           
Flag Coverage Δ
unit 72.48% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scripts/app.ts 80.12% <100.00%> (ø)
src/stores/executionErrorStore.ts 95.23% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants