Repository navigation
fix(risk-map): scope billing globs to src/ and classify apps/website - #15415
Conversation
The billing class matched bare filename tokens (`**/*credit*`, `**/*price*`, `**/*Subscription*`) and directory globs (`**/pricing/**`) anywhere in the repo, so it graded e2e specs, PNG snapshot baselines, `.stories.ts`, `.test.ts`, `locales/*/pricing.json`, `docs/pricing-faq.md` and the marketing site at R3. `apps/website/**` had no rule at all, which left the map inverted over that tree: a launch page graded R0 while a `pricing-*.png` beside it graded R3. Scope the directory globs to `src/**` and the token globs to the trees where billing code actually lives (`src/platform/**`, `src/stores/`, `src/services/`, `src/config/`), and give `apps/website/**` an explicit R2 class. Path floor is a max over every matched rule, so the website rule only works paired with scoping billing off the website tree. Measured over the 212 labelled PRs in the pilot corpus by replaying their real changed-path lists: path floor R3 118 -> 110, R2 26 -> 55, R0 68 -> 47. 31 PRs move, none upward into R3. Backed by the synthetic path-glob suite: 44/44 invariant cases still pass, 13 of 28 contested cases resolve, all in the argued direction.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. 📝 WalkthroughWalkthroughThe risk configuration narrows billing matches to application source paths under ChangesRisk configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This is a localized change to advisory risk-map labels and does not alter product behavior or runtime configuration; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1824 passed, 0 failed · 5 flaky📊 Browser Reports
📦 Bundle: 8.85 MB gzip 🟢 -1.73 kBDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • 🟢 -2 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.37 MB (baseline 1.37 MB) • 🟢 -40 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 566 kB (baseline 566 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27.7 kB (baseline 27.5 kB) • 🔴 +231 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • 🟢 -2 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.52 MB (baseline 3.52 MB) • 🟢 -841 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 550 kB (baseline 549 kB) • 🔴 +1.27 kBHelpers, composables, and utility bundles
Status: 19 added / 18 removed / 19 unchanged Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • 🟢 -197 BExternal libraries and shared vendor chunks
Status: 1 added / 1 removed / 17 unchanged Other — 14.2 MB (baseline 14.2 MB) • 🟢 -2.7 kBBundles that do not match a named category
Status: 68 added / 69 removed / 217 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-18T21:50:00.498Z",
"gitSha": "4a338bc91eb9452966a813f87edeee703ca924aa",
"branch": "fix/risk-map-billing-website-scope",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2048.279999999977,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.603999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.584,
"heapDeltaBytes": -2072560,
"heapUsedBytes": 58885264,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.426000000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2070.2229999999417,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.95,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.325,
"heapDeltaBytes": -217924,
"heapUsedBytes": 60781488,
"domNodes": -282,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 6.289,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1933.4160000000224,
"styleRecalcs": 73,
"styleRecalcDurationMs": 36.604,
"layouts": 12,
"layoutDurationMs": 3.413,
"taskDurationMs": 940.1709999999999,
"heapDeltaBytes": 1035212,
"heapUsedBytes": 62030224,
"domNodes": -286,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 110.21700000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1848.043999999959,
"styleRecalcs": 73,
"styleRecalcDurationMs": 35.333000000000006,
"layouts": 12,
"layoutDurationMs": 3.5469999999999997,
"taskDurationMs": 839.336,
"heapDeltaBytes": 2427324,
"heapUsedBytes": 62840868,
"domNodes": -283,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 104.146,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.4679999999644,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.960000000000003,
"layouts": 6,
"layoutDurationMs": 0.5260000000000002,
"taskDurationMs": 339.58900000000006,
"heapDeltaBytes": 2786328,
"heapUsedBytes": 63104360,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.155,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1731.540999999993,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.481000000000005,
"layouts": 6,
"layoutDurationMs": 0.5970000000000001,
"taskDurationMs": 350.429,
"heapDeltaBytes": 2714972,
"heapUsedBytes": 63265452,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.618,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 605.7239999999524,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.171000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.00300000000004,
"heapDeltaBytes": 10678076,
"heapUsedBytes": 70721012,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 59.35399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 559.1370000000779,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.197000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.64199999999994,
"heapDeltaBytes": 10676500,
"heapUsedBytes": 70979248,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 53.357000000000006,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2053.2140000000254,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.375000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.31,
"heapDeltaBytes": 1826312,
"heapUsedBytes": 75985000,
"domNodes": -257,
"jsHeapTotalBytes": -790528,
"scriptDurationMs": 12.873999999999997,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2057.8120000000126,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.938999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.676,
"heapDeltaBytes": 1896160,
"heapUsedBytes": 75997396,
"domNodes": -263,
"jsHeapTotalBytes": -1839104,
"scriptDurationMs": 12.607,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2132.1419999999875,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.100000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1183.81,
"heapDeltaBytes": 2097656,
"heapUsedBytes": 77173512,
"domNodes": -264,
"jsHeapTotalBytes": -1351680,
"scriptDurationMs": 362.455,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2214.992999999936,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.195999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1245.021,
"heapDeltaBytes": -6125584,
"heapUsedBytes": 68831844,
"domNodes": -270,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 371.81499999999994,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3125.9849999999574,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.281000000000004,
"layouts": 60,
"layoutDurationMs": 6.609,
"taskDurationMs": 1247.5400000000002,
"heapDeltaBytes": 15100124,
"heapUsedBytes": 77243064,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 372.63100000000003,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3385.671000000002,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.482000000000001,
"layouts": 60,
"layoutDurationMs": 7.6290000000000004,
"taskDurationMs": 1476.595,
"heapDeltaBytes": 15523300,
"heapUsedBytes": 76867432,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 419.56699999999995,
"eventListeners": -143,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2224.390000000028,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1440.1830000000002,
"heapDeltaBytes": -19618784,
"heapUsedBytes": 62940680,
"domNodes": -273,
"jsHeapTotalBytes": 6619136,
"scriptDurationMs": 455.683,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2372.7820000000293,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.158000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1486.576,
"heapDeltaBytes": 11431088,
"heapUsedBytes": 88230620,
"domNodes": 12,
"jsHeapTotalBytes": 7008256,
"scriptDurationMs": 466.86400000000003,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2029.8139999999876,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.030999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.377,
"heapDeltaBytes": -11612192,
"heapUsedBytes": 69127184,
"domNodes": -281,
"jsHeapTotalBytes": 4714496,
"scriptDurationMs": 11.483,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2028.6399999999958,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.649999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.1469999999998,
"heapDeltaBytes": 16742992,
"heapUsedBytes": 77899532,
"domNodes": -267,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 18.01599999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 570.2400000000125,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.228,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.28499999999997,
"heapDeltaBytes": 10827160,
"heapUsedBytes": 71239148,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 117.665,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 586.2149999999247,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.444000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.146,
"heapDeltaBytes": 10791176,
"heapUsedBytes": 71426140,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 121.88,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.8170000000032,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.195000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.71399999999994,
"heapDeltaBytes": -44228,
"heapUsedBytes": 60317960,
"domNodes": -283,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 5.741000000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.3419999999196,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.708999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.64,
"heapDeltaBytes": 943568,
"heapUsedBytes": 62455796,
"domNodes": -280,
"jsHeapTotalBytes": 3399680,
"scriptDurationMs": 5.957000000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1721.8270000000189,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.928,
"layouts": 16,
"layoutDurationMs": 4.579,
"taskDurationMs": 763.5999999999999,
"heapDeltaBytes": -2170656,
"heapUsedBytes": 58570300,
"domNodes": -278,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 82.54700000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1715.5380000000378,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.927,
"layouts": 16,
"layoutDurationMs": 4.539,
"taskDurationMs": 797.658,
"heapDeltaBytes": -3353096,
"heapUsedBytes": 57778872,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 84.944,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.717000000047,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.055000000000007,
"layouts": 13,
"layoutDurationMs": 14.350999999999999,
"taskDurationMs": 882.6580000000001,
"heapDeltaBytes": 1411812,
"heapUsedBytes": 98123268,
"domNodes": 13673,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 15.147,
"eventListeners": 2375,
"totalBlockingTimeMs": 132,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8164.293000000043,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.517,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3980.4649999999997,
"heapDeltaBytes": -1948832,
"heapUsedBytes": 72137092,
"domNodes": -270,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 1031.83,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8422.408000000018,
"styleRecalcs": 251,
"styleRecalcDurationMs": 40.369,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4309.396,
"heapDeltaBytes": 9620252,
"heapUsedBytes": 83482472,
"domNodes": -258,
"jsHeapTotalBytes": -1351680,
"scriptDurationMs": 1078.444,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16321.819000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15381.8,
"heapDeltaBytes": -45234648,
"heapUsedBytes": 173770824,
"domNodes": -8312,
"jsHeapTotalBytes": -14094336,
"scriptDurationMs": 96.839,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17460.990000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16644.106,
"heapDeltaBytes": -27050172,
"heapUsedBytes": 178171304,
"domNodes": -8312,
"jsHeapTotalBytes": -14311424,
"scriptDurationMs": 127.39600000000002,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20735.120999999934,
"styleRecalcs": 177,
"styleRecalcDurationMs": 18.504999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20045.796,
"heapDeltaBytes": -23592592,
"heapUsedBytes": 182805968,
"domNodes": -8312,
"jsHeapTotalBytes": -15478784,
"scriptDurationMs": 473.77899999999994,
"eventListeners": -16385,
"totalBlockingTimeMs": 74,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21276.047000000064,
"styleRecalcs": 178,
"styleRecalcDurationMs": 19.083000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20578.617000000002,
"heapDeltaBytes": -26537864,
"heapUsedBytes": 178741124,
"domNodes": -8312,
"jsHeapTotalBytes": -14430208,
"scriptDurationMs": 414.325,
"eventListeners": -16383,
"totalBlockingTimeMs": 75,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 448.0189999999311,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.500999999999998,
"layouts": 3,
"layoutDurationMs": 0.6280000000000001,
"taskDurationMs": 102.20599999999999,
"heapDeltaBytes": 4949148,
"heapUsedBytes": 65759524,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.715000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 487.0489999999563,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.483999999999998,
"layouts": 3,
"layoutDurationMs": 1.392,
"taskDurationMs": 117.52799999999999,
"heapDeltaBytes": 5053804,
"heapUsedBytes": 65230696,
"domNodes": 145,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.980000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15415 +/- ##
==========================================
+ Coverage 79.13% 81.66% +2.53%
==========================================
Files 2209 1882 -327
Lines 114176 109273 -4903
Branches 35154 33519 -1635
==========================================
- Hits 90349 89241 -1108
+ Misses 23338 19644 -3694
+ Partials 489 388 -101
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 6 |
| 🟢 Low | 3 |
Panel: 8/8 reviewers contributed findings.
benjcooley
left a comment
There was a problem hiding this comment.
BLOCKER: preserve R3 coverage for the team credit slider before merging. The map revision and its synthetic expectations should also be uniquely versioned and checked in CI.
Severity correction: the risk map is advisory, so the classification miss is SHOULD FIX rather than BLOCKER.
benjcooley
left a comment
There was a problem hiding this comment.
No blocker. Three SHOULD FIX findings remain: preserve R3 coverage for the team credit slider, bump the map version, and check in executable glob fixtures.
benjcooley
left a comment
There was a problem hiding this comment.
Approved with non-blocking follow-ups.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 3 |
| TRIVIAL | 0 |
Rebased onto #15415, which scoped the billing globs and classified apps/website. These eleven are orthogonal to that and all still fall through to default_tier R0 on current main. - service-endpoints (new, R3): src/config/{comfyApi,firebase,turnstile}.ts bake in the api.comfy.org / platform.comfy.org base URLs, the Firebase project credentials and the Turnstile signup sitekey at build time. Exact filenames rather than src/config/** so clientFeatureFlags.json stays in the R2 flag lane. - billing (extended, R3): src/platform/cloud/churnkey/** is the cancellation and retention vendor flow; src/platform/workspace/api/workspaceApi.ts carries credit limits, credit stops and billing_rail. Neither has a money token in its path, so even the scoped globs from #15415 cannot see them. workspaceApi.ts is listed exactly rather than workspaceApi* — its sibling workspaceApiUrl.ts is a 7-line URL builder, and sweeping it in would reintroduce the over-grading #15415 just removed. - workflow-serialization (extended, R3): comfyWorkflow.ts JSON.stringify()s the active graph state and writes it with save({force:true}). It is a writer of the on-disk format despite living outside the persistence tree. - extension-contract (extended, R3): src/lib/litegraph/src/types/widgets.ts imports Bounds, CompositorWidgetValue and CurveData from three modules that do not sit under a schemas/ path, so they enter the @comfyorg/comfyui-frontend-types rollup and ship to consumers. Verified against all 5730 tracked files: exactly 11 change tier, every one R0 -> R3, zero downgrades, and nothing #15415 classified is disturbed.
|
Follow-up opened: #16599 restores R3 coverage for the team credit slider, versions the map revision, and adds CI-backed glob fixtures. |
|
All 13 deferred review threads now have one follow-up: #16599. Fixes pushed; source threads resolved. Full context for agent readers#16599 now covers the original three Ben follow-ups plus all ten Cursor-panel findings: current component/composable gaps, recursive and symmetric service/store globs, website purchase paths, package/desktop billing domains, TopUp casing/extensions, delete sensitivity, and reachable website R0 carve-outs. Commit 54744fcf81 adds residual fixes and fixtures. Typecheck, 12 affected Vitest cases, 23 risk-map fixtures, and formatting passed locally. |
Summary
The
billingR3 class matches filename characters, not concepts, andapps/website/**has no rule at all — so a PNG snapshot namedpricing-tiers-*.pnggrades "flag + ephemeral env + Sheriff sign-off" while the production launch page next to it grades R0. This scopes the billing globs to the trees where billing code lives and gives the marketing site an explicit R2 class.Defects fixed (measured over 212 labelled PRs)
Impact is measured by replaying the real changed-path lists of the 212 labelled PRs from the pilot window through
grade-pr-risk.sh --stdin, live map vs. this map. Counts are PRs whose path floor moves, not estimates.**/pricing/**reaches intoapps/website/— a coins-icon swap and a redundant-CSS-class removal grade R3pricing/directory, not the token globs**/*credit*,**/*price*,**/*Subscription*, …) match e2e specs, PNG snapshots,.stories.ts,.test.ts,locales/*/pricing.json,docs/pricing-faq.md, anduseSubscriptionCleanup.ts(an event subscription)browser_tests/tests/priceBadge.spec.ts+ a binary screenshot baseline → R3apps/website/**has no rule, and the map is inverted over it: pages grade R0 while apricing-*.pngbeside them grades R3D1 and D4 are coupled. The path floor is a MAX over every matched rule, so adding an
apps/website/**rule alone cannot fix D1 — the website rule only works paired with scoping billing off the website tree.Before / after — path-floor distribution over the same 212 PRs
31 PRs move: 23 R0 → R2 (coverage hole closed), 6 R3 → R2 and 2 R3 → R0 (over-grading relieved). 181 unchanged. No PR moves up into R3.
Attribution also improves: PRs whose only R3 class is
billingdrop from 30 to 22, and thebillingclass stops matching 10 PRs that never touched a money path.Backed by a synthetic path-glob suite
The path-floor axis is a pure function of
(changed-path list, risk map)— no network, no clock, no CI state, no author — so it is testable exhaustively at zero labelling cost. The suite pins provenance (human) and reversibility (SUCCESS) constant and asserts on.risk.axes.path_floor.tier, never the overall tier, so axis 1 is isolated by construction.Against 44 invariant cases + 28 contested cases:
apps/websitepresentation cases land R2 rather than R0, which is the website rule doing its job).Three glob-matcher behaviours the suite measured directly, worth knowing before editing this file:
*does not cross/.**/is root-anchored.[Bb]illingmatches a file literally named[Bb]illing.ts, notBilling.ts. Every case must be spelled out, which is why both casings appear explicitly.Review Focus
Three additions beyond the directly-measured proposal, each closing a hole this diff would otherwise open. Drop any of them freely:
src/**/credit/**— singular, symmetric with the existing pluralcredits/; keepssrc/components/dialog/content/credit/**at R3.src/config/*<token>*— symmetric with thesrc/stores/andsrc/services/scoping; keepssrc/config/subscriptionPricesConfig.tsat R3.src/**/*TopUp*.vue— keepsTopUpCreditsDialogContentLegacy.vue, the legacy purchase dialog, at R3. The.vuesuffix is deliberate: the unsuffixed form re-catches its.test.tssibling, which is exactly D2.Files that deliberately lose R3. Seven shipping files under
src/drop out of the billing class, all display-only:UserCredit.vue,CreditsPanel.vue,CreditBadge.vue,NodePricingBadge.vue,CreditSlider.vue,useNodePricing.ts,usePriceBadge.ts. They render numbers the backend already computed. They now land atdefault_tierbecausesrc/components/**andsrc/composables/**are unmapped — a separate coverage defect, not this one. If you want them at R2, the fix is asrc/components/**rule, not a billing token glob.apps/website/**at R2, not R0. The site is production, but it is copy and layout — it cannot corrupt a saved workflow or move money. I did not add the decorativewebsite-contentR0 sub-rule for images and snapshots: under max semantics an R0 rule cannot lower anything, so it would annotate without changing a single grade.Deliberately out of scope
These are real defects the same suite measured, and a path map cannot fix any of them — the discriminator is diff content, which is a closed question (rejected on data). They belong on the runbook / map-granularity track, not here:
.github/workflows/**is R3 for everything — 22 PRs are R3 withcias their only R3 class, and a 2-line SHA pin bump (ci: bump cursor-review to github-workflows@08460fc #15310, the safe operation) grades byte-identically to a credential-bearing workflow rewrite. Splitting privileged from routine workflows is a separate, contested change and needs its own conversation.depscannot see apackage.jsonversion-field bump vs. a real dependency addition — 13 PRs are R3 ondepsalone; 1.51.8 #15344 and 4 siblings were one-line version bumps. The lockfile delta is the available discriminator and the map does not use it.Also unfixed and recorded honestly:
src/platform/registry/accreditationBadge.tsstill grades R3. Prefix-scoping fixes where the token globs apply, not the substring match itself — "accreditation" contains "credit". Only deleting the bare-token globs entirely fixes that class of collision.Changes
.github/risk.jsononly —billingpath globs scoped, newwebsiteR2 class. No code, no behaviour change outside the advisory risk label.