Repository navigation
chore(risk-map): classify 12 unclassified high-consequence files - #15348
Conversation
🎭 Playwright: ✅ 1982 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.11 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.38 MB (baseline 1.38 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 591 kB (baseline 591 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks Status: 14 unchanged Data & Services — 3.53 MB (baseline 3.53 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 549 kB (baseline 549 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 37 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.1 MB (baseline 14.1 MB) • ⚪ 0 BBundles that do not match a named category Status: 285 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-23T01:24:09.520Z",
"gitSha": "4e58270fffeac62488349a9aed4f60a0bec58463",
"branch": "chore/risk-map-r3-gaps",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2046.295999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.984999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.7769999999999,
"heapDeltaBytes": 4053412,
"heapUsedBytes": 66237392,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.146,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.1770000000697,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.087999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.67,
"heapDeltaBytes": -1774476,
"heapUsedBytes": 59710492,
"domNodes": -280,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 8.232999999999999,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1940.3279999999654,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.13999999999999,
"layouts": 12,
"layoutDurationMs": 3.267,
"taskDurationMs": 979.7840000000001,
"heapDeltaBytes": 11773252,
"heapUsedBytes": 74408092,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 103.884,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.3659999999336,
"styleRecalcs": 72,
"styleRecalcDurationMs": 32.658,
"layouts": 12,
"layoutDurationMs": 3.2359999999999993,
"taskDurationMs": 802.889,
"heapDeltaBytes": -2187564,
"heapUsedBytes": 60380004,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 95.44500000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.1860000000315,
"styleRecalcs": 29,
"styleRecalcDurationMs": 17.58,
"layouts": 6,
"layoutDurationMs": 0.702,
"taskDurationMs": 376.74399999999997,
"heapDeltaBytes": 3228368,
"heapUsedBytes": 65751440,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.739000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1673.7090000000308,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.535000000000004,
"layouts": 6,
"layoutDurationMs": 0.7460000000000001,
"taskDurationMs": 362.26000000000005,
"heapDeltaBytes": 2914408,
"heapUsedBytes": 65675588,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.533999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 595.8279999999831,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.452999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.499,
"heapDeltaBytes": 10500952,
"heapUsedBytes": 71670348,
"domNodes": 14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 51.221000000000004,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 574.0520000000515,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.869999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.948,
"heapDeltaBytes": 10794524,
"heapUsedBytes": 73378944,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 52.189,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.051999999946,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.844,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.544,
"heapDeltaBytes": -13468488,
"heapUsedBytes": 62015640,
"domNodes": -280,
"jsHeapTotalBytes": 2355200,
"scriptDurationMs": 16.099000000000004,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.190999999997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.091000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 679.8820000000001,
"heapDeltaBytes": -13531084,
"heapUsedBytes": 63484716,
"domNodes": -280,
"jsHeapTotalBytes": 4190208,
"scriptDurationMs": 17.594,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2182.9040000000077,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.055999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1206.948,
"heapDeltaBytes": -14072384,
"heapUsedBytes": 63734152,
"domNodes": -278,
"jsHeapTotalBytes": 1306624,
"scriptDurationMs": 308.611,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2317.4220000000787,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.590999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1210.782,
"heapDeltaBytes": -2136256,
"heapUsedBytes": 75459952,
"domNodes": -240,
"jsHeapTotalBytes": -827392,
"scriptDurationMs": 336.07300000000004,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3133.197999999993,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.939000000000004,
"layouts": 60,
"layoutDurationMs": 8.345,
"taskDurationMs": 1374.835,
"heapDeltaBytes": -13475604,
"heapUsedBytes": 64927384,
"domNodes": -284,
"jsHeapTotalBytes": 4714496,
"scriptDurationMs": 358.478,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3229.372000000012,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.333999999999996,
"layouts": 60,
"layoutDurationMs": 8.193000000000001,
"taskDurationMs": 1363.528,
"heapDeltaBytes": -9048660,
"heapUsedBytes": 70002256,
"domNodes": -286,
"jsHeapTotalBytes": 4714496,
"scriptDurationMs": 361.74600000000004,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2362.9999999999995,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.448000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1360.7,
"heapDeltaBytes": 11556028,
"heapUsedBytes": 90988144,
"domNodes": 10,
"jsHeapTotalBytes": 7270400,
"scriptDurationMs": 420.06100000000004,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2337.9400000000032,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.565999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1439.8959999999997,
"heapDeltaBytes": -20653568,
"heapUsedBytes": 64125120,
"domNodes": -245,
"jsHeapTotalBytes": 6287360,
"scriptDurationMs": 444.373,
"eventListeners": 31,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2041.3469999999734,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.701,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 632.174,
"heapDeltaBytes": -12802348,
"heapUsedBytes": 70374936,
"domNodes": -284,
"jsHeapTotalBytes": 2879488,
"scriptDurationMs": 15.707999999999997,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.9110000000464,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.129,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 693.3509999999999,
"heapDeltaBytes": -12660416,
"heapUsedBytes": 70426836,
"domNodes": -280,
"jsHeapTotalBytes": 3928064,
"scriptDurationMs": 16.925000000000004,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 557.4909999999136,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.663,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.218,
"heapDeltaBytes": 11460192,
"heapUsedBytes": 74249484,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 104.97300000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 547.284999999988,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.697999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.616,
"heapDeltaBytes": 11800664,
"heapUsedBytes": 74124036,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 108.74199999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.8999999999974,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.165,
"heapDeltaBytes": 7801236,
"heapUsedBytes": 69556752,
"domNodes": -282,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.369999999999997,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2032.532999999944,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.594,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.335,
"heapDeltaBytes": 13982236,
"heapUsedBytes": 76683724,
"domNodes": -283,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 9.895000000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.791999999974,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.823,
"layouts": 16,
"layoutDurationMs": 4.732,
"taskDurationMs": 794.345,
"heapDeltaBytes": 2410552,
"heapUsedBytes": 65420820,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 86.886,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.1509999999298,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.660000000000004,
"layouts": 16,
"layoutDurationMs": 4.041,
"taskDurationMs": 788.895,
"heapDeltaBytes": 2883896,
"heapUsedBytes": 65750044,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 83.531,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1333.992999999964,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.907,
"layouts": 14,
"layoutDurationMs": 11.683,
"taskDurationMs": 885.0049999999998,
"heapDeltaBytes": -357160,
"heapUsedBytes": 97433620,
"domNodes": 13673,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 17.976,
"eventListeners": 2375,
"totalBlockingTimeMs": 108,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8221.745000000055,
"styleRecalcs": 251,
"styleRecalcDurationMs": 42.573,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4078.899,
"heapDeltaBytes": 3745512,
"heapUsedBytes": 80603704,
"domNodes": -237,
"jsHeapTotalBytes": -565248,
"scriptDurationMs": 979.427,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8238.848999999958,
"styleRecalcs": 251,
"styleRecalcDurationMs": 43.085,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4128.3099999999995,
"heapDeltaBytes": 1613216,
"heapUsedBytes": 78349460,
"domNodes": -272,
"jsHeapTotalBytes": -565248,
"scriptDurationMs": 950.104,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16624.60299999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15858.472,
"heapDeltaBytes": -36167016,
"heapUsedBytes": 176089064,
"domNodes": -8312,
"jsHeapTotalBytes": -17649664,
"scriptDurationMs": 127.00499999999998,
"eventListeners": -16393,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16624.817000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15877.278999999999,
"heapDeltaBytes": -36633916,
"heapUsedBytes": 176030564,
"domNodes": -8312,
"jsHeapTotalBytes": -19177472,
"scriptDurationMs": 115.03299999999999,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18226.09699999998,
"styleRecalcs": 147,
"styleRecalcDurationMs": 16.851000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17821.426,
"heapDeltaBytes": -52309940,
"heapUsedBytes": 173831392,
"domNodes": -8312,
"jsHeapTotalBytes": -19673088,
"scriptDurationMs": 386.83599999999996,
"eventListeners": -16385,
"totalBlockingTimeMs": 36,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 19466.380999999958,
"styleRecalcs": 157,
"styleRecalcDurationMs": 20.879999999999953,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19047.953,
"heapDeltaBytes": -47103972,
"heapUsedBytes": 192394980,
"domNodes": -8312,
"jsHeapTotalBytes": -18722816,
"scriptDurationMs": 377.485,
"eventListeners": -16389,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 468.19299999992836,
"styleRecalcs": 16,
"styleRecalcDurationMs": 18.964000000000002,
"layouts": 3,
"layoutDurationMs": 1.1909999999999998,
"taskDurationMs": 109.50500000000001,
"heapDeltaBytes": 5224988,
"heapUsedBytes": 67188256,
"domNodes": 150,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.990999999999998,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 95.59500000000298,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.231999999999998,
"layouts": 1,
"layoutDurationMs": 0.6100000000000001,
"taskDurationMs": 65.40199999999999,
"heapDeltaBytes": 3037388,
"heapUsedBytes": 65125280,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.411999999999998,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 9 minutes Limit details: You’ve used the included review currently available. Your 92 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: 1 review is currently available. Based on recent review activity, included reviews refill at 4 per hour. 📝 WalkthroughWalkthroughThe PR updates ChangesRisk configuration coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR makes a localized risk-classification update without changing product behavior; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15348 +/- ##
==========================================
+ Coverage 79.38% 81.86% +2.48%
==========================================
Files 2217 1887 -330
Lines 112240 107234 -5006
Branches 35106 34384 -722
==========================================
- Hits 89100 87787 -1313
+ Misses 22652 19111 -3541
+ Partials 488 336 -152
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Rebased onto #15415, which scoped the billing globs and classified apps/website. These eleven are orthogonal to that and all still fall through to default_tier R0 on current main. - service-endpoints (new, R3): src/config/{comfyApi,firebase,turnstile}.ts bake in the api.comfy.org / platform.comfy.org base URLs, the Firebase project credentials and the Turnstile signup sitekey at build time. Exact filenames rather than src/config/** so clientFeatureFlags.json stays in the R2 flag lane. - billing (extended, R3): src/platform/cloud/churnkey/** is the cancellation and retention vendor flow; src/platform/workspace/api/workspaceApi.ts carries credit limits, credit stops and billing_rail. Neither has a money token in its path, so even the scoped globs from #15415 cannot see them. workspaceApi.ts is listed exactly rather than workspaceApi* — its sibling workspaceApiUrl.ts is a 7-line URL builder, and sweeping it in would reintroduce the over-grading #15415 just removed. - workflow-serialization (extended, R3): comfyWorkflow.ts JSON.stringify()s the active graph state and writes it with save({force:true}). It is a writer of the on-disk format despite living outside the persistence tree. - extension-contract (extended, R3): src/lib/litegraph/src/types/widgets.ts imports Bounds, CompositorWidgetValue and CurveData from three modules that do not sit under a schemas/ path, so they enter the @comfyorg/comfyui-frontend-types rollup and ship to consumers. Verified against all 5730 tracked files: exactly 11 change tier, every one R0 -> R3, zero downgrades, and nothing #15415 classified is disturbed.
4bd11a9
3682b7a to
4bd11a9
Compare
|
Rebased onto #15415 — apologies for dismissing the approvals, the branch had gone What #15415 changed for this PR: nothing structural. It scoped the billing globs to One thing I tightened because of #15415. The rebase surfaced two new files, export function workspaceApiUrl(route: string): string {
return isCloud ? api.apiURL(route) : `${getComfyCloudBaseUrl()}/api${route}`
}That is exactly the over-grading #15415 removed, so the glob is now the exact file Re-verified over all 5730 tracked files:
|
|
Follow-up audit for this PR's two open items ("Two things worth your call"):
No action needed on this PR itself — the 12 files it classified are still present and still grade R3 on current |
What
Twelve files currently match no path rule in
.github/risk.jsonand fall through todefault_tier: R0. Each one is high-consequence. This classifies them and nothing else.Found while running the map over the whole tree to see what
R0was actually covering — the map is new (#14889) so this is coverage feedback, not a criticism of it.The twelve
src/config/{comfyApi,firebase,turnstile}.tsservice-endpoints(new, R3)api.comfy.org/platform.comfy.orgbase URLs, the Firebase project credentials and the Turnstile signup sitekey at build timesrc/platform/cloud/churnkey/**src/platform/workspace/api/workspaceApi*billing(R3)billingglobs match on filename tokens (**/billing/**,**/pricing/**,**/credits/**). Neither of these has a money word in its pathsrc/platform/workflow/management/stores/comfyWorkflow.tsworkflow-serialization(R3)workflow/persistence/**src/renderer/core/layout/types.tssrc/renderer/extensions/compositor/components/types.tssrc/components/curve/types.tsextension-contract(R3)schemas/pathEvidence for the two least obvious:
comfyWorkflow.tsis a writer of the on-disk format.The three
types.tsmodules ship to consumers.src/lib/litegraph/src/types/widgets.tsopens with:litegraph reaches
src/types/index.ts, which is therollupTypes: trueentry for the published@comfyorg/comfyui-frontend-types. So these are part of the published surface.workspaceApiis money code.subscribe()sendsteam_credit_stop_idandbilling_cycle; the module carries credit limits andbilling_rail.Verification
Applied the map to all 5553 tracked files, before and after:
Nothing else in the repo changes tier. JSON parses;
prettier --checkclean.Two things worth your call
1. Two colocated test files inherit R3 (
churnkeyClient.test.ts,workspaceApi.test.ts), so a test-only change to them now grades R3. The map's globs have no negation, so "tests are R0 regardless of tree" is not expressible — this is pre-existing (285 files already match the R0testsrule and still floor R2/R3 because a co-matching rule wins), not something this PR introduces. Happy to narrow to exact non-test filenames if you'd rather, though that's more brittle.2. I deliberately did not do the big coverage expansion. 2316 of 5551 tracked files still match no rule. I drafted rules taking that to 98% and then measured the effect: over the risk-labeled PRs merged since the map landed, adding R2 rules for every unclassified app tree moves one PR's label — the provenance axis already floors a human PR at R1, and
core-infraR2 dominates viaworst(). So the static gap is large and the operational gap is not, and padding the map would dilute it rather than serve it. These twelve are different: they are all R3, and R3 is the tier that actually changes what a reviewer sees.Separately, and not for this PR: an R0 rule can never bind, because the floor is a
worst()starting fromdefault_tier: R0. That makesdefault_tier: R0the only place R0 has force, and it spends it making unmapped paths the safest thing in the file — which is what let 42% of the tree read as "safe" when it meant "unknown". Worth a conversation aboutdefault_tier: R1, but that is a repo-wide decision, not a drive-by.