Skip to content

test: tolerate sub-pixel drift in the mobile touch-pan screenshot - #15354

Closed
christian-byrne wants to merge 1 commit into
mainfrom
fix/flaky-mobile-pan-screenshot
Closed

christian-byrne wants to merge 1 commit into
mainfrom
fix/flaky-mobile-pan-screenshot

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

@mobile Can pan with touch (pan.spec.ts:212) asserts an exact canvas screenshot with no tolerance. It flakes, and because it only flakes once the merge queue rebuilds a PR against main, it ejects PRs silently.

Evidence

Three merge-queue branches on 2026-08-17, all built on the same base commit 926d78c8bf:

queue branch PR content CI: Tests E2E
pr-14068-926d78c8bf per-language CODEOWNERS entries ❌ 40 pixels (ratio 0.01)
pr-15067-fb633f46b3 run acknowledgement ordering ❌ 40 pixels (ratio 0.01)
pr-15108-926d78c8bf test: pin that script src loads never reach the network ✅ pass

Neither failing PR can move a canvas. The third passing on the same base is what rules out a regression on main and leaves flake. Both failures reported the identical 40 pixels, and both PRs were removed from the queue by github-merge-queue[bot] with no reason recorded.

The change

await expect(comfyPage.canvas).toHaveScreenshot(
  'vue-nodes-paned-with-touch.png',
  { maxDiffPixels: 50 }
)

maxDiffPixels: 50 is the same tolerance, for the same reason, as the sibling canvas assertion at interaction.spec.ts:234 ("Litegraph renders edge with a slight offset"). Other canvas-heavy specs already carry tolerances — canvasSettings.spec.ts uses maxDiffPixels: 100, load3d.spec.ts uses maxDiffPixelRatio up to 0.1.

50 is deliberately just above the observed 40 and far below anything that would hide a real visual change: the canvas is 1081×1999, so this is 0.0019% of the image.

Why this is worth fixing rather than retrying

The assertion passes on the PR branch and fails only on the queue branch. So the author sees a green PR, the queue ejects it without a reason, and mergeStateStatus goes back to CLEAN — indistinguishable from a PR that is simply waiting. Whoever is in the queue at the time absorbs the blame.

Review focus

  • If anyone believes the 40px delta is a real rendering change rather than sub-pixel antialiasing, say so and I will chase the cause instead — I could not reproduce it deterministically, and the passing run on the identical base is the main argument against a regression.
  • I have deliberately not re-recorded the baseline. Accepting a new snapshot would bury the question of whether anything actually changed.

`@mobile Can pan with touch` asserts an exact canvas screenshot. On
2026-08-17 it failed at `40 pixels (ratio 0.01 of all image pixels)` on two
merge-queue branches in a row, ejecting both PRs:

- #14068, which adds CODEOWNERS entries
- #15067, which changes run acknowledgement

Neither can move a canvas. A third PR, #15108, passed the same assertion on
the same base commit (926d78c), which is what rules out a regression on
`main` and leaves flake.

`maxDiffPixels: 50` matches the sibling canvas assertion in
`interaction.spec.ts:234`, which carries the same tolerance for the same
reason. It is deliberately just above the observed 40 and far below anything
that would hide a real visual change.

The cost of leaving it strict is not a red check on the PR that caused it —
the assertion passes on the PR branch and only fails once the queue rebuilds
it against `main`, so it ejects PRs silently and blames whichever change
happens to be in the queue.
@christian-byrne
christian-byrne requested a review from a team August 17, 2026 02:50
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 17, 2026
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 3 minutes

Limit details: You’ve used all 4 included reviews currently available under your plan. You completed 68 included PR reviews in the past 7 days; at that activity level, included reviews refill at 4 reviews per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: bf12d0e2-a40b-4815-b16f-4ebcb03e7542

📥 Commits

Reviewing files that changed from the base of the PR and between 7a01087 and 21aafe9.

📒 Files selected for processing (1)
  • browser_tests/tests/vueNodes/interactions/canvas/pan.spec.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1820 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1799 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle: 8.85 MB gzip 🔴 +138 B

Details

Summary

  • Raw size: 37.4 MB baseline 37.3 MB — 🔴 +875 B
  • Gzip: 8.85 MB baseline 8.85 MB — 🔴 +138 B
  • Brotli: 6.19 MB baseline 6.19 MB — 🔴 +79 B
  • Bundles: 438 current • 438 baseline • 3 added / 3 removed

Category Glance
Graph Workspace 🔴 +875 B (1.37 MB) · Vendor & Third-Party ⚪ 0 B (16.8 MB) · Other ⚪ 0 B (14.2 MB) · Data & Services ⚪ 0 B (3.52 MB) · Panels & Settings ⚪ 0 B (566 kB) · Utilities & Hooks ⚪ 0 B (550 kB) · + 5 more

App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-B2nlvIEN.js (new) — 3.71 kB 🔴 +3.71 kB 🔴 +1.86 kB 🔴 +1.6 kB
assets/index-C8HBiFox.js (removed) 3.71 kB — 🟢 -3.71 kB 🟢 -1.86 kB 🟢 -1.6 kB

Status: 1 added / 1 removed

Graph Workspace — 1.37 MB (baseline 1.37 MB) • 🔴 +875 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-D3eZEaEl.js (new) — 1.36 MB 🔴 +1.36 MB 🔴 +297 kB 🔴 +223 kB
assets/GraphView-qBMkfPJP.js (removed) 1.36 MB — 🟢 -1.36 MB 🟢 -297 kB 🟢 -223 kB

Status: 1 added / 1 removed / 2 unchanged

Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 17 unchanged

Panels & Settings — 566 kB (baseline 566 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 26 unchanged

User & Accounts — 27.7 kB (baseline 27.7 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 11 unchanged

Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 8 unchanged

UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 B

Reusable component library chunks

Status: 14 unchanged

Data & Services — 3.52 MB (baseline 3.52 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 38 unchanged

Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 14.2 MB (baseline 14.2 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/main-CjAixWEH.js (removed) 45.3 kB — 🟢 -45.3 kB 🟢 -13.2 kB 🟢 -11.4 kB
assets/main-dC8YM91B.js (new) — 45.3 kB 🔴 +45.3 kB 🔴 +13.2 kB 🔴 +11.4 kB

Status: 1 added / 1 removed / 284 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 52.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 50.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 133ms TBT · 77.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.0 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 159.4 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 73ms TBT · 167.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.5 MB heap

⚠️ 3 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
large-graph-pan: task duration 859ms 1190ms +39% ⚠️ z=2.5
subgraph-dom-widget-clipping: task duration 296ms 424ms +43% ⚠️ z=2.5
subgraph-idle: task duration 364ms 438ms +20% ⚠️ z=2.2
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.1
canvas-idle: p95 frame time 17ms 17ms +0% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 6ms 8ms +43% z=-2.9
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 10 10 -5% z=-2.9
canvas-idle: task duration 385ms 455ms +18% z=2.0
canvas-idle: script duration 6ms 6ms +14% z=-8.5
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 66.1 MB 66.2 MB +0% —
canvas-idle: DOM nodes 20 19 -5% z=-2.8
canvas-idle: event listeners 6 4 -33% z=-1.6
canvas-mouse-sweep: avg frame time 17ms 17ms -0% z=-0.9
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 2ms 4ms +62% z=1.4
canvas-mouse-sweep: style recalc duration 23ms 40ms +73% z=-0.8
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 74 77 +3% z=-0.9
canvas-mouse-sweep: task duration 619ms 912ms +47% z=0.8
canvas-mouse-sweep: script duration 72ms 114ms +59% z=-3.4
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 60.9 MB 52.7 MB -13% —
canvas-mouse-sweep: DOM nodes 56 31 -45% z=-12.1
canvas-mouse-sweep: event listeners 6 -75 -1342% z=-19.9
canvas-zoom-sweep: avg frame time 17ms 17ms +0% z=1.4
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% —
canvas-zoom-sweep: layout duration 1ms 1ms +3% z=-2.0
canvas-zoom-sweep: style recalc duration 12ms 16ms +33% z=-2.1
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 31 33 +6% z=3.8
canvas-zoom-sweep: task duration 291ms 363ms +25% z=1.6
canvas-zoom-sweep: script duration 8ms 8ms +10% z=-6.3
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 69.1 MB 69.0 MB -0% —
canvas-zoom-sweep: DOM nodes 80 78 -3% z=-1.6
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.2
dom-widget-clipping: p95 frame time 17ms 17ms +0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 5ms 9ms +63% z=-1.6
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 13 13 -4% z=-1.2
dom-widget-clipping: task duration 270ms 385ms +42% z=1.2
dom-widget-clipping: script duration 36ms 57ms +58% z=-3.3
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 49.8 MB 50.4 MB +1% —
dom-widget-clipping: DOM nodes 22 21 -5% z=-0.8
dom-widget-clipping: event listeners 2 2 +0% variance too high
large-graph-idle: avg frame time 17ms 17ms -0% z=-1.0
large-graph-idle: p95 frame time 17ms 17ms +1% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 6ms 7ms +18% z=-4.9
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 10 9 -15% z=-9.9
large-graph-idle: task duration 491ms 589ms +20% z=0.9
large-graph-idle: script duration 9ms 12ms +32% z=-8.6
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 69.6 MB 69.3 MB -0% —
large-graph-idle: DOM nodes -282 -281 -0% z=-338.2
large-graph-idle: event listeners -149 -149 +0% z=-28.7
large-graph-pan: avg frame time 17ms 17ms +0% z=0.3
large-graph-pan: p95 frame time 17ms 17ms -0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 9ms 15ms +60% z=-3.3
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 68 69 +1% z=-1.7
large-graph-pan: task duration 859ms 1190ms +39% ⚠️ z=2.5
large-graph-pan: script duration 215ms 341ms +59% z=-3.4
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 66.5 MB 61.7 MB -7% —
large-graph-pan: DOM nodes -281 -285 +1% z=-184.0
large-graph-pan: event listeners -149 -164 +10% z=-204.0
large-graph-zoom: avg frame time 17ms 17ms -0% —
large-graph-zoom: p95 frame time 17ms 17ms -0% —
large-graph-zoom: layout duration 6ms 8ms +29% —
large-graph-zoom: style recalc duration 10ms 14ms +39% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 65 65 -1% —
large-graph-zoom: task duration 988ms 1304ms +32% —
large-graph-zoom: script duration 252ms 390ms +55% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 75.6 MB 75.6 MB +0% —
large-graph-zoom: DOM nodes 14 11 -21% —
large-graph-zoom: event listeners 6 8 +33% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.1
minimap-idle: p95 frame time 17ms 17ms -0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 5ms 6ms +18% z=-4.0
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 9 7 -22% z=-3.8
minimap-idle: task duration 488ms 582ms +19% z=1.2
minimap-idle: script duration 11ms 13ms +19% z=-8.6
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 71.0 MB 70.0 MB -1% —
minimap-idle: DOM nodes -282 -286 +1% z=-223.1
minimap-idle: event listeners -149 -149 +0% z=-232.6
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.9
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 7ms 11ms +50% z=-2.0
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 47 -1% z=-2.5
subgraph-dom-widget-clipping: task duration 296ms 424ms +43% ⚠️ z=2.5
subgraph-dom-widget-clipping: script duration 79ms 124ms +57% z=-0.6
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 51.5 MB 51.6 MB +0% —
subgraph-dom-widget-clipping: DOM nodes 20 19 -5% z=-2.8
subgraph-dom-widget-clipping: event listeners 8 7 -13% z=-1.6
subgraph-idle: avg frame time 17ms 17ms +0% z=-0.2
subgraph-idle: p95 frame time 17ms 17ms +1% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 6ms 8ms +31% z=-3.4
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 10 10 -5% z=-2.1
subgraph-idle: task duration 364ms 438ms +20% ⚠️ z=2.2
subgraph-idle: script duration 5ms 6ms +4% z=-5.5
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 66.3 MB 66.4 MB +0% —
subgraph-idle: DOM nodes 20 19 -5% z=-1.9
subgraph-idle: event listeners 6 4 -33% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.4
subgraph-mouse-sweep: p95 frame time 17ms 17ms +0% —
subgraph-mouse-sweep: layout duration 3ms 4ms +38% z=-1.4
subgraph-mouse-sweep: style recalc duration 25ms 35ms +40% z=-2.2
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 75 76 +1% z=-2.1
subgraph-mouse-sweep: task duration 565ms 747ms +32% z=-0.3
subgraph-mouse-sweep: script duration 55ms 84ms +52% z=-2.6
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 57.7 MB 57.6 MB -0% —
subgraph-mouse-sweep: DOM nodes 61 63 +2% z=-2.0
subgraph-mouse-sweep: event listeners 4 4 +0% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms -0% —
subgraph-transition-enter: p95 frame time 17ms 17ms +0% —
subgraph-transition-enter: layout duration 8ms 13ms +55% —
subgraph-transition-enter: style recalc duration 22ms 30ms +34% —
subgraph-transition-enter: layout count 16 16 +0% —
subgraph-transition-enter: style recalc count 21 21 +0% —
subgraph-transition-enter: task duration 700ms 893ms +28% —
subgraph-transition-enter: script duration 12ms 17ms +38% —
subgraph-transition-enter: TBT 103ms 133ms +29% —
subgraph-transition-enter: heap used 74.7 MB 77.4 MB +4% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2373 2375 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 22ms 40ms +78% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 249 250 +0% —
viewport-pan-sweep: task duration 2954ms 4208ms +42% —
viewport-pan-sweep: script duration 666ms 1116ms +68% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 69.9 MB 54.0 MB -23% —
viewport-pan-sweep: DOM nodes -282 -282 -0% —
viewport-pan-sweep: event listeners -133 -165 +24% —
vue-large-graph-idle: avg frame time 17ms 18ms +7% —
vue-large-graph-idle: p95 frame time 17ms 17ms +1% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 10857ms 15817ms +46% —
vue-large-graph-idle: script duration 73ms 112ms +52% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 160.9 MB 159.4 MB -1% —
vue-large-graph-idle: DOM nodes -8312 -8312 +0% —
vue-large-graph-idle: event listeners -16391 -16389 -0% —
vue-large-graph-pan: avg frame time 17ms 18ms +3% —
vue-large-graph-pan: p95 frame time 17ms 17ms +1% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 12ms 19ms +53% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 72 173 +140% —
vue-large-graph-pan: task duration 13472ms 20643ms +53% —
vue-large-graph-pan: script duration 341ms 430ms +26% —
vue-large-graph-pan: TBT 20ms 73ms +265% —
vue-large-graph-pan: heap used 174.4 MB 167.8 MB -4% —
vue-large-graph-pan: DOM nodes -8312 -8314 +0% —
vue-large-graph-pan: event listeners -16387 -16382 -0% —
workflow-execution: avg frame time 17ms 17ms -0% z=-0.4
workflow-execution: p95 frame time 17ms 17ms +0% —
workflow-execution: layout duration 0ms 1ms +58% z=-6.1
workflow-execution: style recalc duration 14ms 14ms +1% z=-4.8
workflow-execution: layout count 2 3 +25% z=-4.5
workflow-execution: style recalc count 14 7 -54% z=-5.5
workflow-execution: task duration 88ms 78ms -11% z=-4.1
workflow-execution: script duration 6ms 5ms -11% z=-8.1
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 65.4 MB 63.5 MB -3% —
workflow-execution: DOM nodes 123 109 -12% z=-7.4
workflow-execution: event listeners 99 49 -51% z=-0.7
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-08-17T03:02:49.096Z",
  "gitSha": "7fe7b4b38889cb11ba82c955c5968a83c503bc04",
  "branch": "fix/flaky-mobile-pan-screenshot",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2034.0040000000101,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 453.512,
      "heapDeltaBytes": 4900148,
      "heapUsedBytes": 69406304,
      "domNodes": 18,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 6.591999999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2038.063999999963,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.509,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.97999999999996,
      "heapDeltaBytes": 4769104,
      "heapUsedBytes": 69381404,
      "domNodes": 20,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 6.255999999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2008.340000000004,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 42.713,
      "layouts": 12,
      "layoutDurationMs": 3.7809999999999997,
      "taskDurationMs": 1007.3809999999999,
      "heapDeltaBytes": -17615312,
      "heapUsedBytes": 46607568,
      "domNodes": 6,
      "jsHeapTotalBytes": 23826432,
      "scriptDurationMs": 118.333,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1803.651000000002,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 37.641,
      "layouts": 12,
      "layoutDurationMs": 3.9880000000000004,
      "taskDurationMs": 817.3000000000001,
      "heapDeltaBytes": -664324,
      "heapUsedBytes": 63995844,
      "domNodes": 56,
      "jsHeapTotalBytes": 25690112,
      "scriptDurationMs": 109.307,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.2790000000477,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 15.571,
      "layouts": 6,
      "layoutDurationMs": 0.531,
      "taskDurationMs": 360.205,
      "heapDeltaBytes": 7995872,
      "heapUsedBytes": 72493948,
      "domNodes": 78,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 8.209000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1739.496000000031,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 16.132,
      "layouts": 6,
      "layoutDurationMs": 0.576,
      "taskDurationMs": 365.52799999999996,
      "heapDeltaBytes": 8007936,
      "heapUsedBytes": 72239100,
      "domNodes": 78,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 8.479,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 607.3210000000131,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.914000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 392.385,
      "heapDeltaBytes": -12212580,
      "heapUsedBytes": 52188344,
      "domNodes": 20,
      "jsHeapTotalBytes": 26214400,
      "scriptDurationMs": 56.766,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 577.6319999999942,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 9.332,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 376.794,
      "heapDeltaBytes": -11211352,
      "heapUsedBytes": 53502928,
      "domNodes": 22,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 57.263,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2022.5439999999821,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.363000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 595.256,
      "heapDeltaBytes": 12306032,
      "heapUsedBytes": 72112420,
      "domNodes": -281,
      "jsHeapTotalBytes": 3244032,
      "scriptDurationMs": 13.165000000000003,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.739000000097,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.881000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 581.99,
      "heapDeltaBytes": 12931872,
      "heapUsedBytes": 73149060,
      "domNodes": -281,
      "jsHeapTotalBytes": 2195456,
      "scriptDurationMs": 11.467999999999998,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2135.4619999999613,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.026,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1173.4740000000002,
      "heapDeltaBytes": 7535668,
      "heapUsedBytes": 68318804,
      "domNodes": -282,
      "jsHeapTotalBytes": 3436544,
      "scriptDurationMs": 337.30100000000004,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2175.371999999925,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.277,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1205.575,
      "heapDeltaBytes": 590696,
      "heapUsedBytes": 61153672,
      "domNodes": -287,
      "jsHeapTotalBytes": 4485120,
      "scriptDurationMs": 345.5,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3128.9540000000216,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 13.692000000000002,
      "layouts": 60,
      "layoutDurationMs": 7.544,
      "taskDurationMs": 1308.234,
      "heapDeltaBytes": 17320512,
      "heapUsedBytes": 79329148,
      "domNodes": 10,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 390.89000000000004,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3164.718999999991,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.202,
      "layouts": 60,
      "layoutDurationMs": 7.664000000000001,
      "taskDurationMs": 1300.47,
      "heapDeltaBytes": 17351012,
      "heapUsedBytes": 79255284,
      "domNodes": 12,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 390.006,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2010.6549999999856,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.142000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 588.1070000000001,
      "heapDeltaBytes": 12219024,
      "heapUsedBytes": 72853592,
      "domNodes": -286,
      "jsHeapTotalBytes": 2457600,
      "scriptDurationMs": 12.626999999999999,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2016.6430000000446,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.388000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 575.669,
      "heapDeltaBytes": 12904836,
      "heapUsedBytes": 73872484,
      "domNodes": -286,
      "jsHeapTotalBytes": 3244032,
      "scriptDurationMs": 12.809000000000001,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 633.1870000000208,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.326,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.01599999999996,
      "heapDeltaBytes": -10424944,
      "heapUsedBytes": 54153468,
      "domNodes": 20,
      "jsHeapTotalBytes": 26738688,
      "scriptDurationMs": 122.163,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 622.3410000000058,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.3,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 422.7,
      "heapDeltaBytes": -10352656,
      "heapUsedBytes": 54126064,
      "domNodes": 18,
      "jsHeapTotalBytes": 25690112,
      "scriptDurationMs": 126.62399999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.0820000000158,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.256999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 440.0810000000001,
      "heapDeltaBytes": 4868640,
      "heapUsedBytes": 69666072,
      "domNodes": 20,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 5.789000000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2004.946000000018,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.2799999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 435.93100000000004,
      "heapDeltaBytes": 5017844,
      "heapUsedBytes": 69612812,
      "domNodes": 18,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 5.456,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1673.5780000000204,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 35.005,
      "layouts": 16,
      "layoutDurationMs": 4.404,
      "taskDurationMs": 751.009,
      "heapDeltaBytes": -4061552,
      "heapUsedBytes": 60583192,
      "domNodes": 61,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 83.80399999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1677.3640000000114,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 35.598,
      "layouts": 16,
      "layoutDurationMs": 4.096000000000001,
      "taskDurationMs": 742.433,
      "heapDeltaBytes": -4318832,
      "heapUsedBytes": 60197432,
      "domNodes": 64,
      "jsHeapTotalBytes": 25690112,
      "scriptDurationMs": 83.87400000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.4329999999973,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 30.017000000000003,
      "layouts": 16,
      "layoutDurationMs": 13.158999999999997,
      "taskDurationMs": 893.3019999999998,
      "heapDeltaBytes": -6127688,
      "heapUsedBytes": 81176356,
      "domNodes": 13673,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 16.523999999999997,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 133,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8229.083000000002,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 40.422,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4122.63,
      "heapDeltaBytes": -5062884,
      "heapUsedBytes": 55576100,
      "domNodes": -281,
      "jsHeapTotalBytes": 4816896,
      "scriptDurationMs": 1051.6760000000002,
      "eventListeners": -165,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8264.598999999977,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 38.648,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4293.14,
      "heapDeltaBytes": -3073796,
      "heapUsedBytes": 57673136,
      "domNodes": -282,
      "jsHeapTotalBytes": 3768320,
      "scriptDurationMs": 1181.1660000000002,
      "eventListeners": -165,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16928.09500000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15917.378999999999,
      "heapDeltaBytes": -43122568,
      "heapUsedBytes": 167496320,
      "domNodes": -8312,
      "jsHeapTotalBytes": -11739136,
      "scriptDurationMs": 114.313,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16702.481000000036,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15715.919,
      "heapDeltaBytes": -44203432,
      "heapUsedBytes": 166868076,
      "domNodes": -8312,
      "jsHeapTotalBytes": -11177984,
      "scriptDurationMs": 108.909,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21588.424999999974,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 19.833999999999964,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21005.051000000003,
      "heapDeltaBytes": -27923788,
      "heapUsedBytes": 169201916,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10231808,
      "scriptDurationMs": 444.251,
      "eventListeners": -16381,
      "totalBlockingTimeMs": 106,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20923.857999999997,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 17.58599999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20280.805999999997,
      "heapDeltaBytes": -27797756,
      "heapUsedBytes": 182740940,
      "domNodes": -8316,
      "jsHeapTotalBytes": -12595200,
      "scriptDurationMs": 416.16200000000003,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 40,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 107.36099999996895,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 13.690000000000001,
      "layouts": 3,
      "layoutDurationMs": 0.707,
      "taskDurationMs": 77.548,
      "heapDeltaBytes": 3109380,
      "heapUsedBytes": 66720832,
      "domNodes": 109,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 5.804,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 110.37099999998645,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 13.623,
      "layouts": 2,
      "layoutDurationMs": 0.6330000000000001,
      "taskDurationMs": 78.896,
      "heapDeltaBytes": 3037816,
      "heapUsedBytes": 66517072,
      "domNodes": 108,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 4.486000000000001,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.799999999999727
    }
  ]
}

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 17, 2026
@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #15354      +/-   ##
==========================================
+ Coverage   79.06%   81.40%   +2.34%     
==========================================
  Files        2209     1882     -327     
  Lines      122868   117972    -4896     
  Branches    36466    35788     -678     
==========================================
- Hits        97140    96035    -1105     
+ Misses      25161    21470    -3691     
+ Partials      567      467     -100     
Flag Coverage Δ
unit 72.89% <ø> (+<0.01%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 336 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Superseded by #15356, closing this one so there is a single PR to review.

Same defect, same conclusion that a bound is the honest fix, but that PR pins the cause rather than inferring it. It pulled the artifacts from two failing runs and found the actual and diff PNGs byte-identical across different runners, then localised the 40 pixels: they are anti-aliasing inside the glyphs of the ckpt_name widget's value text, with per-glyph centroid drift under 0.09px and about 5% less ink. Not node-edge anti-aliasing from a sub-pixel camera offset — every pixel outside that text, including the panned node's own transform and border, is identical between passing and failing runs.

It also adds what this PR does not: a poll asserting the pan actually applied before any pixels are compared, so a pan that silently never happens fails with a readable error instead of masquerading as a screenshot diff — which a tolerance alone would hide.

The merge-queue evidence here is the better impact story, so I have carried it over to 15356: this flake does not just redden PR checks, it ejects unrelated PRs from the merge queue.

pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Aug 23, 2026
## The bug

`.github/workflows/ci-binary-size-validation.yaml` subscribes to the
`labeled` and `unlabeled`
pull_request event types:

```yaml
on:
  pull_request:
    types: [opened, synchronize, reopened, labeled, unlabeled]
concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: true
```

So **any** label write starts a second binary-size run on the identical
commit, and
`cancel-in-progress` kills the one already in flight. A label change
cannot alter a bundle's
size, so there is nothing for the job to re-evaluate — the second run
just recomputes the same
answer and leaves a permanent `cancelled` check run behind on the
commit.

## Why it matters beyond wasted minutes

The cancelled check does not go away when the retry succeeds. Both check
runs stay attached to
the commit, so the commit's check rollup is `FAILURE` forever.

The PR risk grader reads that rollup. Its reversibility axis treats a
non-`SUCCESS` rollup as
`no_green_checks_tier`, which `.github/risk.json` sets to **R2** — so a
PR gets bumped to R2
because a label bot wrote a `size:*` label two seconds after CI started.

The chain, end to end:

1. `dosubot[bot]` writes a `size:*` label seconds after the PR opens or
is pushed to.
2. That `labeled` event re-triggers binary-size on the same commit;
`cancel-in-progress` cancels
   the in-flight run.
3. The commit now permanently carries a `binary-size / CANCELLED` check
run.
4. The grader counts `CANCELLED` as a failing check, so the rollup is
not `SUCCESS`, so
   reversibility is pinned at R2.

## Measured (re-verified for this PR, 2026-08-18)

| measure | value |
|---|---|
| binary-size runs, 30 days (created >= 2026-07-19) | 4,307 |
| ...concluded `cancelled` | **1,128 = 26.2%** |
| ...concluded `failure` | 39 = 0.9% |
| complete 2-day window (created >= 2026-08-16) | 819 runs |
| ...cancelled | 164 = 20.0% |
| cancels superseded by a later run on the **same head SHA** | **163 of
164 = 99.4%** |
| median gap to the superseding run | **2 s** (p25 0 s, p75 4 s) |
| distinct head SHAs in that window carrying **both** a `cancelled` and
a `success` run | 110 of 613 = **17.9%** |

Cancellations outrun real findings by roughly 29 to 1.

**Timed to the second on three live PRs** (label event → new run → prior
run cancelled):

- Comfy-Org#15413 — `size:XS` at 21:31:18Z → new run 21:31:20Z, prior run
(started 21:31:17Z) cancelled
- Comfy-Org#15414 — `size:L` at 21:35:47Z → new run 21:35:49Z, prior run
(21:35:45Z) cancelled
- Comfy-Org#15412 — `size:L` at 21:02:03Z → new run 21:02:06Z, prior run
(21:02:01Z) cancelled

**A settled rollup showing the consequence.** Commit `ce9ec9b4d0`
(Comfy-Org#15414, a `browser_tests/`-only
PR) — rollup state `FAILURE` over 85 contexts: 57 `SUCCESS`, 26
`SKIPPED`, and exactly one
failing-class context, `binary-size / CANCELLED`. That PR carries
`risk:R2`.

**Across the whole label population:** of the 112 PRs currently carrying
`risk:R2`, **17 (15.2%)
have a check rollup whose only failing-class context is `binary-size /
CANCELLED`** — Comfy-Org#14546,
Comfy-Org#15138, Comfy-Org#15173, Comfy-Org#15178, Comfy-Org#15261, Comfy-Org#15280, Comfy-Org#15307, Comfy-Org#15354, Comfy-Org#15371, Comfy-Org#15376,
Comfy-Org#15380, Comfy-Org#15388, Comfy-Org#15402,
Comfy-Org#15404, Comfy-Org#15410, Comfy-Org#15411, Comfy-Org#15414.

## Why removing the trigger is the right fix, and not the concurrency
group

Keying the concurrency group on `github.event.pull_request.head.sha`
does **not** help: a label
write happens on the identical commit, so it lands in the same group and
still cancels. The
re-trigger itself is what has to go.

`binary-size` is **not** a required check for merge — the `ProtectMain`
ruleset requires `test`,
`lint-and-format`, `e2e-status` and `website-e2e`, and `CLA Check`
requires `cla-assistant`.

## Trade-off, stated plainly

The `allow-large-binaries` bypass is read from
`github.event.pull_request.labels.*.name` at the
job `if:`. With `labeled` removed, applying that label no longer
re-evaluates the check
instantly — it takes effect on the next `synchronize`/`reopened`. That
costs nothing today:
**`allow-large-binaries` has been applied to 0 PRs, ever**, and the
check does not gate merge, so
a stale red never blocks anyone.

`scripts/cicd/check-binary-size.sh:165` prints "add the
'allow-large-binaries' label to the PR"
on failure; that advice still works, it just lands on the next push
rather than instantly. I have
deliberately not touched that file — happy to reword it in a follow-up
if a reviewer wants it.

## This PR demonstrates the fix on itself

`pull_request` workflow definitions are read from the PR head, so the
change is already live
here. Timeline:

- 22:50:13Z — PR opened
- 22:50:17Z — binary-size run `32194526247` starts
- 22:50:19Z — `dosubot[bot]` applies `size:XS`, **two seconds into the
run** — the exact pattern
  that cancels the run on every other PR

Result: **one** binary-size run on this commit, no second trigger, no
cancellation,
`binary-size pass 35s`. Compare Comfy-Org#15413 / Comfy-Org#15414 / Comfy-Org#15412 above, where
the same two-second label
write killed the in-flight run and left a permanent `CANCELLED` on the
commit.

## Scope

This is half the loop. The other half is grader-side: `CANCELLED` is
counted as a *failing*
check in `Comfy-Org/github-workflows`
(`scripts/pr-risk/grade-pr-risk.sh`), which is what turns a
cancelled run into an R2. That fix has **not shipped** and is not in
this PR. So this PR removes
the largest source of the cancellations but does not fully close the
loop — a binary-size run
cancelled for any other reason would still red the rollup.

No other change to the file.
@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned) size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants