Repository navigation
[backport cloud/1.48] fix: persist workflow drafts across page refresh - #15336
Conversation
## Summary Flush pending debounced workflow draft writes when the page unloads so recent edits survive refresh. ## Root cause Workflow graph writes are debounced by 512 ms. If a user refreshed during that window, the page was destroyed before the pending write ran, so the next load restored the previous draft. The persistence composable already flushed pending writes during workspace transitions, but it had no browser lifecycle flush. ## How we handle it - Reuse the existing guarded persistence flush for `window.pagehide` instead of adding a separate unload storage path. - Preserve the existing workspace scoping and blocked-write behavior. - Remove the `pagehide` listener during scope disposal before cancelling the debounce. ## Regression coverage - Unit: a pending graph edit flushes on `pagehide`. - Unit: disposing the composable removes the lifecycle listener and prevents stale writes. - Playwright E2E: persist a baseline node state, reverse it, reload immediately without waiting for the 512 ms debounce, and verify the pending state is restored. ## Review Focus The unload path uses the same persistence operation and guards as normal graph changes and workspace transitions. ## Verification Personal workspace scenario: persist one node, add a second node, then refresh after **80 ms** (before the 512 ms debounce fires). - **AS IS**: the last edit is lost; 1 of 2 nodes returns. - **TO BE**: `pagehide` flushes the pending write; both nodes return.  - [FE-1484](https://linear.app/comfyorg/issue/FE-1484/workflow-drafts-do-not-persist-across-refresh-on-cloud) - [Slack report](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1785650948159379) --------- Co-authored-by: dante01yoon <6510430+dante01yoon@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com>
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1767 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-16T07:25:39.123Z",
"gitSha": "dceb6c900dbff4b9bc589a39bd9cf249c49becde",
"branch": "backport-14575-to-cloud-1.48",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2029.5659999999884,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.474,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.505,
"heapDeltaBytes": 3889216,
"heapUsedBytes": 71932060,
"domNodes": 22,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 13.635,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1995.50499999998,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.890000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.54600000000005,
"heapDeltaBytes": 4172696,
"heapUsedBytes": 72319048,
"domNodes": 22,
"jsHeapTotalBytes": 19791872,
"scriptDurationMs": 12.933,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1797.0710000000167,
"styleRecalcs": 73,
"styleRecalcDurationMs": 30.461000000000002,
"layouts": 12,
"layoutDurationMs": 3.17,
"taskDurationMs": 807.979,
"heapDeltaBytes": -19931320,
"heapUsedBytes": 47872280,
"domNodes": -273,
"jsHeapTotalBytes": 20967424,
"scriptDurationMs": 102.051,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1718.3459999999968,
"styleRecalcs": 75,
"styleRecalcDurationMs": 27.383,
"layouts": 12,
"layoutDurationMs": 2.718,
"taskDurationMs": 684.73,
"heapDeltaBytes": -21210312,
"heapUsedBytes": 46821252,
"domNodes": -273,
"jsHeapTotalBytes": 20443136,
"scriptDurationMs": 87.727,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1661.5070000000287,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.546000000000001,
"layouts": 6,
"layoutDurationMs": 0.5349999999999999,
"taskDurationMs": 293.834,
"heapDeltaBytes": 7174872,
"heapUsedBytes": 75305012,
"domNodes": 77,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 14.853,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1668.3639999999968,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.107,
"layouts": 6,
"layoutDurationMs": 0.4670000000000001,
"taskDurationMs": 297.64,
"heapDeltaBytes": 7293500,
"heapUsedBytes": 75224828,
"domNodes": 77,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 15.149000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 528.8759999999968,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.998000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 313.013,
"heapDeltaBytes": -12781308,
"heapUsedBytes": 55343616,
"domNodes": 20,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 44.540000000000006,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 498.6069999999927,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.715000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 296.811,
"heapDeltaBytes": -12682888,
"heapUsedBytes": 55663324,
"domNodes": 20,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 43.916999999999994,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2007.142999999985,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.222,
"heapDeltaBytes": 7425612,
"heapUsedBytes": 66564664,
"domNodes": -274,
"jsHeapTotalBytes": 5046272,
"scriptDurationMs": 73.932,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 1997.0299999999952,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.948000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.914,
"heapDeltaBytes": 6362304,
"heapUsedBytes": 65302620,
"domNodes": -275,
"jsHeapTotalBytes": 4521984,
"scriptDurationMs": 76.20100000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2094.5580000000064,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.237999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 979.0409999999998,
"heapDeltaBytes": 3524788,
"heapUsedBytes": 63778928,
"domNodes": -277,
"jsHeapTotalBytes": 5251072,
"scriptDurationMs": 322.174,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2118.247999999994,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.131999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 983.8390000000002,
"heapDeltaBytes": 3741816,
"heapUsedBytes": 63803380,
"domNodes": -276,
"jsHeapTotalBytes": 5251072,
"scriptDurationMs": 332.073,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3090.1680000000056,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.837000000000002,
"layouts": 60,
"layoutDurationMs": 6.834,
"taskDurationMs": 1173.882,
"heapDeltaBytes": 20511456,
"heapUsedBytes": 81602940,
"domNodes": 18,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 412.481,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3090.68400000001,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.996000000000002,
"layouts": 60,
"layoutDurationMs": 6.733,
"taskDurationMs": 1161.6019999999999,
"heapDeltaBytes": 21957992,
"heapUsedBytes": 84245248,
"domNodes": 14,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 410.881,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2035.525000000007,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.71,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.3679999999999,
"heapDeltaBytes": 7936872,
"heapUsedBytes": 69602072,
"domNodes": -273,
"jsHeapTotalBytes": 5308416,
"scriptDurationMs": 75.24,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.766000000047,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.457999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.6990000000001,
"heapDeltaBytes": 7132704,
"heapUsedBytes": 68144824,
"domNodes": -278,
"jsHeapTotalBytes": 4521984,
"scriptDurationMs": 74.013,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.4650000000297,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.165,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 312.87899999999996,
"heapDeltaBytes": -12160932,
"heapUsedBytes": 55884292,
"domNodes": 18,
"jsHeapTotalBytes": 22675456,
"scriptDurationMs": 93.413,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 520.2069999999708,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.723,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 312.576,
"heapDeltaBytes": -12128092,
"heapUsedBytes": 55802344,
"domNodes": 20,
"jsHeapTotalBytes": 22151168,
"scriptDurationMs": 94.397,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2001.1340000000075,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.941999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.577,
"heapDeltaBytes": -21650488,
"heapUsedBytes": 46342604,
"domNodes": -274,
"jsHeapTotalBytes": 20705280,
"scriptDurationMs": 11.34,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2004.0689999999586,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.566999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.69300000000004,
"heapDeltaBytes": 3850592,
"heapUsedBytes": 72187516,
"domNodes": 22,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 11.129,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1701.5079999999898,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.12,
"layouts": 16,
"layoutDurationMs": 3.19,
"taskDurationMs": 647.197,
"heapDeltaBytes": -21637624,
"heapUsedBytes": 46553968,
"domNodes": -273,
"jsHeapTotalBytes": 20443136,
"scriptDurationMs": 72.965,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1700.7800000000088,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.176,
"layouts": 16,
"layoutDurationMs": 3.198,
"taskDurationMs": 634.401,
"heapDeltaBytes": -21641600,
"heapUsedBytes": 46555000,
"domNodes": -274,
"jsHeapTotalBytes": 20443136,
"scriptDurationMs": 69.27799999999999,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 917.4879999999916,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.352999999999998,
"layouts": 16,
"layoutDurationMs": 9.27,
"taskDurationMs": 732.0630000000001,
"heapDeltaBytes": 2801740,
"heapUsedBytes": 93122516,
"domNodes": 13673,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 21.789999999999996,
"eventListeners": 2373,
"totalBlockingTimeMs": 82,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8120.177000000012,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.763000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3436.756,
"heapDeltaBytes": 9515864,
"heapUsedBytes": 68646292,
"domNodes": -274,
"jsHeapTotalBytes": 6561792,
"scriptDurationMs": 1060.347,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8172.0940000000155,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.517,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3455.578,
"heapDeltaBytes": 6927200,
"heapUsedBytes": 66178496,
"domNodes": -276,
"jsHeapTotalBytes": 7348224,
"scriptDurationMs": 1051.566,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14335.285,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14324.094000000001,
"heapDeltaBytes": -44182960,
"heapUsedBytes": 168436548,
"domNodes": -8312,
"jsHeapTotalBytes": -10162176,
"scriptDurationMs": 420.569,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14313.208999999915,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14293.136,
"heapDeltaBytes": -56082764,
"heapUsedBytes": 165765064,
"domNodes": -8312,
"jsHeapTotalBytes": -18026496,
"scriptDurationMs": 456.845,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 16799.053000000014,
"styleRecalcs": 112,
"styleRecalcDurationMs": 13.220999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16778.543999999998,
"heapDeltaBytes": -62353144,
"heapUsedBytes": 154143996,
"domNodes": -8312,
"jsHeapTotalBytes": -18026496,
"scriptDurationMs": 661.302,
"eventListeners": -16385,
"totalBlockingTimeMs": 11,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16950.335999999992,
"styleRecalcs": 113,
"styleRecalcDurationMs": 13.873999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16909.433,
"heapDeltaBytes": -67735244,
"heapUsedBytes": 163984828,
"domNodes": -8312,
"jsHeapTotalBytes": -17240064,
"scriptDurationMs": 709.4590000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 66,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 461.31900000000314,
"styleRecalcs": 15,
"styleRecalcDurationMs": 19.068,
"layouts": 4,
"layoutDurationMs": 1.2209999999999999,
"taskDurationMs": 104.96799999999999,
"heapDeltaBytes": -16056540,
"heapUsedBytes": 51040744,
"domNodes": 130,
"jsHeapTotalBytes": 7208960,
"scriptDurationMs": 8.597,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 73.9530000000741,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.050999999999998,
"layouts": 1,
"layoutDurationMs": 0.23099999999999987,
"taskDurationMs": 47.524999999999984,
"heapDeltaBytes": 2894216,
"heapUsedBytes": 70101332,
"domNodes": 102,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 3.3600000000000003,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.48 #15336 +/- ##
=============================================
Coverage ? 69.49%
=============================================
Files ? 1662
Lines ? 85989
Branches ? 22987
=============================================
Hits ? 59759
Misses ? 26121
Partials ? 109
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #14575 to
cloud/1.48Automatically created by backport workflow.