Skip to content

fix: persist workflow drafts across page refresh - #14575

Merged
dante01yoon merged 4 commits into
mainfrom
jaewon/fe-1484-workflow-drafts-persist-refresh
Aug 16, 2026
Merged

dante01yoon merged 4 commits into
mainfrom
jaewon/fe-1484-workflow-drafts-persist-refresh

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Aug 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Flush pending debounced workflow draft writes when the page unloads so recent edits survive refresh.

Root cause

Workflow graph writes are debounced by 512 ms. If a user refreshed during that window, the page was destroyed before the pending write ran, so the next load restored the previous draft. The persistence composable already flushed pending writes during workspace transitions, but it had no browser lifecycle flush.

How we handle it

  • Reuse the existing guarded persistence flush for window.pagehide instead of adding a separate unload storage path.
  • Preserve the existing workspace scoping and blocked-write behavior.
  • Remove the pagehide listener during scope disposal before cancelling the debounce.

Regression coverage

  • Unit: a pending graph edit flushes on pagehide.
  • Unit: disposing the composable removes the lifecycle listener and prevents stale writes.
  • Playwright E2E: persist a baseline node state, reverse it, reload immediately without waiting for the 512 ms debounce, and verify the pending state is restored.

Review Focus

The unload path uses the same persistence operation and guards as normal graph changes and workspace transitions.

Verification

Personal workspace scenario: persist one node, add a second node, then refresh after 80 ms (before the 512 ms debounce fires).

  • AS IS: the last edit is lost; 1 of 2 nodes returns.
  • TO BE: pagehide flushes the pending write; both nodes return.

AS IS versus TO BE workflow draft refresh behavior

@dante01yoon
dante01yoon requested a review from a team August 2, 2026 13:23
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 2, 2026
@dosubot

dosubot Bot commented Aug 2, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-09-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about ComfyUI_frontend Add Dosu to your team

@github-actions

github-actions Bot commented Aug 2, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1781 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1762 / ❌ 0 / ⚠️ 0 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/02/2026, 02:16:45 PM UTC

Links

📦 Bundle: 8.21 MB gzip 🔴 +45 B

Details

Summary

  • Raw size: 34.5 MB baseline 34.5 MB — 🔴 +192 B
  • Gzip: 8.21 MB baseline 8.21 MB — 🔴 +45 B
  • Brotli: 5.68 MB baseline 5.68 MB — 🟢 -44 B
  • Bundles: 427 current • 427 baseline • 3 added / 3 removed

Category Glance
Graph Workspace 🔴 +192 B (1.29 MB) · Vendor & Third-Party ⚪ 0 B (15.7 MB) · Other ⚪ 0 B (12.8 MB) · Data & Services ⚪ 0 B (3.45 MB) · Panels & Settings ⚪ 0 B (551 kB) · Utilities & Hooks ⚪ 0 B (386 kB) · + 5 more

App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-BMlSpH5R.js (new) — 3.64 kB 🔴 +3.64 kB 🔴 +1.82 kB 🔴 +1.59 kB
assets/index-BPJ_DlS3.js (removed) 3.64 kB — 🟢 -3.64 kB 🟢 -1.82 kB 🟢 -1.58 kB

Status: 1 added / 1 removed

Graph Workspace — 1.29 MB (baseline 1.29 MB) • 🔴 +192 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-BiMaccq1.js (new) — 1.29 MB 🔴 +1.29 MB 🔴 +276 kB 🔴 +208 kB
assets/GraphView-XDLUXkDH.js (removed) 1.29 MB — 🟢 -1.29 MB 🟢 -276 kB 🟢 -208 kB

Status: 1 added / 1 removed / 1 unchanged

Views & Navigation — 111 kB (baseline 111 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 16 unchanged

Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 26 unchanged

User & Accounts — 28.7 kB (baseline 28.7 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 10 unchanged

Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 7 unchanged

UI Components — 70 kB (baseline 70 kB) • ⚪ 0 B

Reusable component library chunks

Status: 15 unchanged

Data & Services — 3.45 MB (baseline 3.45 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 36 unchanged

Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 16 unchanged

Other — 12.8 MB (baseline 12.8 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/main-B-v1O9xX.js (removed) 46.9 kB — 🟢 -46.9 kB 🟢 -13.8 kB 🟢 -12 kB
assets/main-C08MXgzf.js (new) — 46.9 kB 🔴 +46.9 kB 🔴 +13.8 kB 🔴 +12 kB

Status: 1 added / 1 removed / 280 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 49.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 43.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 44.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 146ms TBT · 94.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.3 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 159.3 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 432ms TBT · 158.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.6 MB heap

⚠️ 13 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 497ms 628ms +26% ⚠️ z=7.5
canvas-mouse-sweep: task duration 911ms 986ms +8% ⚠️ z=2.1
canvas-zoom-sweep: task duration 384ms 471ms +22% ⚠️ z=6.2
dom-widget-clipping: task duration 400ms 418ms +5% ⚠️ z=3.3
large-graph-idle: task duration 712ms 835ms +17% ⚠️ z=5.4
large-graph-idle: script duration 121ms 133ms +10% ⚠️ z=2.9
large-graph-pan: task duration 1348ms 1458ms +8% ⚠️ z=8.7
large-graph-pan: script duration 459ms 507ms +10% ⚠️ z=5.0
minimap-idle: task duration 685ms 836ms +22% ⚠️ z=6.5
minimap-idle: script duration 109ms 134ms +23% ⚠️ z=3.6
subgraph-dom-widget-clipping: task duration 403ms 441ms +9% ⚠️ z=3.4
subgraph-idle: task duration 474ms 621ms +31% ⚠️ z=8.0
subgraph-mouse-sweep: task duration 817ms 910ms +11% ⚠️ z=2.1
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.1
canvas-idle: p95 frame time 17ms 17ms +0% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 9ms 6ms -32% z=-5.0
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 10 6 -40% z=-9.2
canvas-idle: task duration 497ms 628ms +26% ⚠️ z=7.5
canvas-idle: script duration 20ms 25ms +29% z=0.0
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 69.4 MB 69.7 MB +0% —
canvas-idle: DOM nodes 20 12 -40% z=-8.3
canvas-idle: event listeners 4 5 +25% z=-1.4
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.9
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 4ms 4ms -1% z=0.4
canvas-mouse-sweep: style recalc duration 41ms 43ms +4% z=0.2
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 78 77 -2% z=-0.9
canvas-mouse-sweep: task duration 911ms 986ms +8% ⚠️ z=2.1
canvas-mouse-sweep: script duration 127ms 136ms +7% z=0.1
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 49.3 MB 49.0 MB -1% —
canvas-mouse-sweep: DOM nodes -278 -281 +1% z=-132.7
canvas-mouse-sweep: event listeners -148 -148 +0% z=-37.5
canvas-zoom-sweep: avg frame time 17ms 17ms +0% z=0.5
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% —
canvas-zoom-sweep: layout duration 1ms 1ms +16% z=2.0
canvas-zoom-sweep: style recalc duration 18ms 20ms +16% z=0.8
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 32 32 -2% z=0.5
canvas-zoom-sweep: task duration 384ms 471ms +22% ⚠️ z=6.2
canvas-zoom-sweep: script duration 21ms 27ms +31% z=0.1
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 72.3 MB 72.3 MB +0% —
canvas-zoom-sweep: DOM nodes 79 78 -1% z=-1.6
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
dom-widget-clipping: p95 frame time 17ms 17ms -0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 10ms 9ms -5% z=-1.0
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 13 12 -12% z=-3.2
dom-widget-clipping: task duration 400ms 418ms +5% ⚠️ z=3.3
dom-widget-clipping: script duration 61ms 64ms +6% z=-1.1
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 53.0 MB 53.2 MB +0% —
dom-widget-clipping: DOM nodes 22 19 -14% z=-2.2
dom-widget-clipping: event listeners 2 2 +0% variance too high
large-graph-idle: avg frame time 17ms 17ms -0% z=-1.0
large-graph-idle: p95 frame time 17ms 17ms -0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 8ms 9ms +18% z=-2.8
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 8 9 +6% z=-9.9
large-graph-idle: task duration 712ms 835ms +17% ⚠️ z=5.4
large-graph-idle: script duration 121ms 133ms +10% ⚠️ z=2.9
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 64.3 MB 64.0 MB -0% —
large-graph-idle: DOM nodes -283 -282 -0% z=-339.3
large-graph-idle: event listeners -144 -144 +0% z=-27.9
large-graph-pan: avg frame time 17ms 17ms +0% z=-0.2
large-graph-pan: p95 frame time 17ms 17ms +1% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 14ms 14ms +2% z=-4.0
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 68 68 +0% z=-2.4
large-graph-pan: task duration 1348ms 1458ms +8% ⚠️ z=8.7
large-graph-pan: script duration 459ms 507ms +10% ⚠️ z=5.0
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 60.5 MB 63.8 MB +5% —
large-graph-pan: DOM nodes -284 -285 +0% z=-184.3
large-graph-pan: event listeners -144 -145 +1% z=-181.1
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms +0% —
large-graph-zoom: layout duration 7ms 8ms +4% —
large-graph-zoom: style recalc duration 16ms 16ms -0% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 64 64 -1% —
large-graph-zoom: task duration 1537ms 1680ms +9% —
large-graph-zoom: script duration 538ms 596ms +11% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 60.8 MB 68.5 MB +13% —
large-graph-zoom: DOM nodes -287 -140 -51% —
large-graph-zoom: event listeners -148 -69 -53% —
minimap-idle: avg frame time 17ms 17ms +0% z=-0.4
minimap-idle: p95 frame time 17ms 17ms +0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 7ms 7ms +4% z=-2.5
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 8 7 -13% z=-3.8
minimap-idle: task duration 685ms 836ms +22% ⚠️ z=6.5
minimap-idle: script duration 109ms 134ms +23% ⚠️ z=3.6
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 65.5 MB 65.8 MB +0% —
minimap-idle: DOM nodes -283 -284 +0% z=-221.6
minimap-idle: event listeners -144 -145 +1% z=-226.5
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 11ms 13ms +17% z=0.4
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 48 +1% z=-0.8
subgraph-dom-widget-clipping: task duration 403ms 441ms +9% ⚠️ z=3.4
subgraph-dom-widget-clipping: script duration 119ms 127ms +7% z=-0.2
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 54.5 MB 54.3 MB -0% —
subgraph-dom-widget-clipping: DOM nodes 20 21 +5% z=-1.1
subgraph-dom-widget-clipping: event listeners 6 8 +33% z=-1.4
subgraph-idle: avg frame time 17ms 17ms +0% z=0.4
subgraph-idle: p95 frame time 17ms 17ms +0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 9ms 9ms -7% z=-2.1
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 10 9 -10% z=-2.9
subgraph-idle: task duration 474ms 621ms +31% ⚠️ z=8.0
subgraph-idle: script duration 15ms 22ms +51% z=0.8
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 69.0 MB 43.7 MB -37% —
subgraph-idle: DOM nodes 20 18 -10% z=-2.5
subgraph-idle: event listeners 4 -148 -3800% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms -0% z=-0.1
subgraph-mouse-sweep: p95 frame time 17ms 17ms -0% —
subgraph-mouse-sweep: layout duration 4ms 5ms +6% z=0.2
subgraph-mouse-sweep: style recalc duration 37ms 41ms +11% z=-0.5
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 76 75 -1% z=-2.7
subgraph-mouse-sweep: task duration 817ms 910ms +11% ⚠️ z=2.1
subgraph-mouse-sweep: script duration 94ms 106ms +13% z=0.8
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 45.5 MB 44.9 MB -1% —
subgraph-mouse-sweep: DOM nodes -279 -132 -53% z=-88.8
subgraph-mouse-sweep: event listeners -148 -72 -51% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms +0% —
subgraph-transition-enter: p95 frame time 17ms 17ms -1% —
subgraph-transition-enter: layout duration 13ms 14ms +8% —
subgraph-transition-enter: style recalc duration 31ms 34ms +10% —
subgraph-transition-enter: layout count 14 13 -7% —
subgraph-transition-enter: style recalc count 18 17 -6% —
subgraph-transition-enter: task duration 959ms 1041ms +9% —
subgraph-transition-enter: script duration 35ms 42ms +21% —
subgraph-transition-enter: TBT 130ms 146ms +12% —
subgraph-transition-enter: heap used 96.3 MB 94.4 MB -2% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2371 2371 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms -1% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 39ms 41ms +7% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 250 251 +0% —
viewport-pan-sweep: task duration 4653ms 5056ms +9% —
viewport-pan-sweep: script duration 1434ms 1547ms +8% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 67.5 MB 74.3 MB +10% —
viewport-pan-sweep: DOM nodes -280 -279 -0% —
viewport-pan-sweep: event listeners -126 -127 +1% —
vue-large-graph-idle: avg frame time 18ms 18ms +0% —
vue-large-graph-idle: p95 frame time 17ms 17ms +0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 17385ms 17816ms +2% —
vue-large-graph-idle: script duration 582ms 595ms +2% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 159.6 MB 159.3 MB -0% —
vue-large-graph-idle: DOM nodes -8312 -8312 +0% —
vue-large-graph-idle: event listeners -16387 -16389 +0% —
vue-large-graph-pan: avg frame time 18ms 18ms +2% —
vue-large-graph-pan: p95 frame time 17ms 17ms -0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 18ms 22ms +20% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 145 156 +8% —
vue-large-graph-pan: task duration 20805ms 21826ms +5% —
vue-large-graph-pan: script duration 875ms 948ms +8% —
vue-large-graph-pan: TBT 195ms 432ms +121% —
vue-large-graph-pan: heap used 159.5 MB 158.0 MB -1% —
vue-large-graph-pan: DOM nodes -8312 -8313 +0% —
vue-large-graph-pan: event listeners -16383 -16383 +0% —
workflow-execution: avg frame time 17ms 17ms +0% z=0.6
workflow-execution: p95 frame time 17ms 17ms +0% —
workflow-execution: layout duration 1ms 1ms -13% z=-3.4
workflow-execution: style recalc duration 18ms 24ms +33% z=-0.2
workflow-execution: layout count 3 4 +17% z=-2.7
workflow-execution: style recalc count 13 14 +4% z=-2.1
workflow-execution: task duration 120ms 131ms +9% z=0.7
workflow-execution: script duration 11ms 12ms +7% z=-5.8
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 48.4 MB 48.6 MB +0% —
workflow-execution: DOM nodes 119 125 +5% z=-5.1
workflow-execution: event listeners 65 66 +2% z=3.2
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-08-02T14:34:08.607Z",
  "gitSha": "901ec63d2b2d521b843e99d894c7d4e79628ada9",
  "branch": "jaewon/fe-1484-workflow-drafts-persist-refresh",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2108.517000000006,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.9640000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 669.113,
      "heapDeltaBytes": 5061912,
      "heapUsedBytes": 73092552,
      "domNodes": 6,
      "jsHeapTotalBytes": 20049920,
      "scriptDurationMs": 26.24,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2035.0639999999203,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.727,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 587.735,
      "heapDeltaBytes": 4996248,
      "heapUsedBytes": 73161688,
      "domNodes": 18,
      "jsHeapTotalBytes": 19787776,
      "scriptDurationMs": 24.417,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1903.6689999999794,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 40.181,
      "layouts": 12,
      "layoutDurationMs": 3.262,
      "taskDurationMs": 974.67,
      "heapDeltaBytes": -14845784,
      "heapUsedBytes": 53246564,
      "domNodes": -284,
      "jsHeapTotalBytes": 21225472,
      "scriptDurationMs": 134.75500000000002,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1923.0810000000247,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 46.159,
      "layouts": 12,
      "layoutDurationMs": 4.122,
      "taskDurationMs": 996.4889999999999,
      "heapDeltaBytes": -18393624,
      "heapUsedBytes": 49476880,
      "domNodes": -278,
      "jsHeapTotalBytes": 19914752,
      "scriptDurationMs": 137.42000000000002,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1754.8470000000407,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 20.445999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.7620000000000001,
      "taskDurationMs": 467.593,
      "heapDeltaBytes": 7970456,
      "heapUsedBytes": 75920736,
      "domNodes": 78,
      "jsHeapTotalBytes": 21098496,
      "scriptDurationMs": 27.385999999999996,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.0060000000703,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 20.328999999999997,
      "layouts": 6,
      "layoutDurationMs": 0.702,
      "taskDurationMs": 473.84700000000004,
      "heapDeltaBytes": 7942128,
      "heapUsedBytes": 75774168,
      "domNodes": 78,
      "jsHeapTotalBytes": 20312064,
      "scriptDurationMs": 27.374999999999996,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 629.4340000000034,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.641,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.216,
      "heapDeltaBytes": -12226644,
      "heapUsedBytes": 55640776,
      "domNodes": 20,
      "jsHeapTotalBytes": 22147072,
      "scriptDurationMs": 63.68199999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 656.2189999999646,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.549,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 411.6960000000001,
      "heapDeltaBytes": -11806672,
      "heapUsedBytes": 55965156,
      "domNodes": 18,
      "jsHeapTotalBytes": 22147072,
      "scriptDurationMs": 65.09599999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2041.4089999999874,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 10.385000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 826.888,
      "heapDeltaBytes": 7933604,
      "heapUsedBytes": 66766324,
      "domNodes": -281,
      "jsHeapTotalBytes": 4780032,
      "scriptDurationMs": 134.31799999999998,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2034.7370000000637,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.210000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 842.9470000000001,
      "heapDeltaBytes": 8440624,
      "heapUsedBytes": 67393380,
      "domNodes": -283,
      "jsHeapTotalBytes": 4780032,
      "scriptDurationMs": 131.553,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2437.1469999999817,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.289000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1506.539,
      "heapDeltaBytes": 7051180,
      "heapUsedBytes": 67303820,
      "domNodes": -285,
      "jsHeapTotalBytes": 5267456,
      "scriptDurationMs": 551.307,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2284.391000000028,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.964999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1409.888,
      "heapDeltaBytes": 6657192,
      "heapUsedBytes": 66426804,
      "domNodes": -285,
      "jsHeapTotalBytes": 5267456,
      "scriptDurationMs": 462.67400000000004,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3672.0599999999877,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 16.564,
      "layouts": 60,
      "layoutDurationMs": 7.661000000000001,
      "taskDurationMs": 1749.7169999999999,
      "heapDeltaBytes": -4553760,
      "heapUsedBytes": 57123268,
      "domNodes": -290,
      "jsHeapTotalBytes": 6877184,
      "scriptDurationMs": 620.5799999999999,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3245.2899999999545,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.847,
      "layouts": 60,
      "layoutDurationMs": 7.766,
      "taskDurationMs": 1610.961,
      "heapDeltaBytes": 24335236,
      "heapUsedBytes": 86482832,
      "domNodes": 10,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 571.878,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2034.0289999999754,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.276000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 846.56,
      "heapDeltaBytes": 7694404,
      "heapUsedBytes": 68627912,
      "domNodes": -284,
      "jsHeapTotalBytes": 4255744,
      "scriptDurationMs": 135.766,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2035.6959999999162,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.664999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 824.974,
      "heapDeltaBytes": 8288160,
      "heapUsedBytes": 69267580,
      "domNodes": -284,
      "jsHeapTotalBytes": 5042176,
      "scriptDurationMs": 132.69799999999998,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 674.4800000000168,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 13.677,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.23900000000003,
      "heapDeltaBytes": -10920532,
      "heapUsedBytes": 57278916,
      "domNodes": 22,
      "jsHeapTotalBytes": 21360640,
      "scriptDurationMs": 126.31,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 644.382999999948,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.398,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 440.19,
      "heapDeltaBytes": -11377000,
      "heapUsedBytes": 56633680,
      "domNodes": 20,
      "jsHeapTotalBytes": 21884928,
      "scriptDurationMs": 127.031,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2030.3739999999948,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.135000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 604.1,
      "heapDeltaBytes": -21995344,
      "heapUsedBytes": 45831640,
      "domNodes": 18,
      "jsHeapTotalBytes": 19914752,
      "scriptDurationMs": 21.756,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2035.900999999967,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.463000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 638.817,
      "heapDeltaBytes": -22240856,
      "heapUsedBytes": 45834204,
      "domNodes": 18,
      "jsHeapTotalBytes": 20176896,
      "scriptDurationMs": 23.161999999999995,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1745.7019999999943,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 40.449,
      "layouts": 16,
      "layoutDurationMs": 4.883,
      "taskDurationMs": 901.535,
      "heapDeltaBytes": -21685900,
      "heapUsedBytes": 46189556,
      "domNodes": 20,
      "jsHeapTotalBytes": 20701184,
      "scriptDurationMs": 103.519,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1752.1740000000818,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 40.887,
      "layouts": 16,
      "layoutDurationMs": 4.654,
      "taskDurationMs": 917.7089999999998,
      "heapDeltaBytes": -19915804,
      "heapUsedBytes": 47968552,
      "domNodes": -283,
      "jsHeapTotalBytes": 21225472,
      "scriptDurationMs": 108.798,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.8680000000027,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 33.555,
      "layouts": 13,
      "layoutDurationMs": 13.659999999999998,
      "taskDurationMs": 1041.329,
      "heapDeltaBytes": 30932480,
      "heapUsedBytes": 99004060,
      "domNodes": 13673,
      "jsHeapTotalBytes": 15728640,
      "scriptDurationMs": 42.32899999999999,
      "eventListeners": 2371,
      "totalBlockingTimeMs": 146,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9015.045999999984,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 42.24400000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5080.124000000001,
      "heapDeltaBytes": 20093168,
      "heapUsedBytes": 78906776,
      "domNodes": -279,
      "jsHeapTotalBytes": 7331840,
      "scriptDurationMs": 1581.1100000000001,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8838.10399999993,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 40.263999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5032.0019999999995,
      "heapDeltaBytes": 18066556,
      "heapUsedBytes": 76832424,
      "domNodes": -279,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 1513.5939999999998,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17828.434000000016,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17801.092,
      "heapDeltaBytes": -45006356,
      "heapUsedBytes": 167145880,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9117696,
      "scriptDurationMs": 635.927,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17849.593000000026,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17831.026,
      "heapDeltaBytes": -45034008,
      "heapUsedBytes": 166929688,
      "domNodes": -8312,
      "jsHeapTotalBytes": -11214848,
      "scriptDurationMs": 553.948,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21926.737,
      "styleRecalcs": 157,
      "styleRecalcDurationMs": 22.114000000000022,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21879.95,
      "heapDeltaBytes": -31818376,
      "heapUsedBytes": 177296396,
      "domNodes": -8312,
      "jsHeapTotalBytes": -15966208,
      "scriptDurationMs": 984.9510000000001,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 451,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21806.740999999987,
      "styleRecalcs": 155,
      "styleRecalcDurationMs": 21.272000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21771.372999999996,
      "heapDeltaBytes": -55473172,
      "heapUsedBytes": 154152568,
      "domNodes": -8313,
      "jsHeapTotalBytes": -11440128,
      "scriptDurationMs": 910.9159999999999,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 412,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 473.1310000000235,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 18.275,
      "layouts": 3,
      "layoutDurationMs": 0.6050000000000001,
      "taskDurationMs": 122.54,
      "heapDeltaBytes": -16035992,
      "heapUsedBytes": 50974500,
      "domNodes": 128,
      "jsHeapTotalBytes": 7991296,
      "scriptDurationMs": 11.539000000000001,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 490.28199999997923,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 29.391999999999996,
      "layouts": 4,
      "layoutDurationMs": 1.51,
      "taskDurationMs": 138.81799999999998,
      "heapDeltaBytes": -16037944,
      "heapUsedBytes": 50859544,
      "domNodes": 121,
      "jsHeapTotalBytes": 7467008,
      "scriptDurationMs": 12.128000000000002,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@coderabbitai

coderabbitai Bot commented Aug 2, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The workflow persistence composable flushes pending saves on pagehide. Cleanup removes the event listener. Regression tests cover persistence before disposal and prevention of persistence after disposal.

Changes

Workflow persistence

Layer / File(s) Summary
Pagehide flush and lifecycle coverage
src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.ts, src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts
The composable registers and cleans up a shared pagehide flush handler. Tests verify serialized persistence of pending graph edits and no persistence after disposal.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive Commit subjects and the PR title are not provided, so the required bug-fix signal cannot be verified from the allowed metadata. Provide the PR title and commit subjects, then reassess whether the frontend changes require a browser_tests/ regression test.
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed files are limited to workflow persistence composable and test files; none are under the listed litegraph, ECS, or graph-entity paths.
Title check ✅ Passed The title clearly describes the primary change: preserving workflow drafts across page refreshes.
Description check ✅ Passed The description explains the root cause, implementation, regression coverage, review focus, and verification results in sufficient detail.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jaewon/fe-1484-workflow-drafts-persist-refresh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously requested changes Aug 2, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts`:
- Around line 625-648: Add a disposal-focused test near the existing pagehide
coverage for useWorkflowPersistenceV2: queue a workflow edit, unmount or dispose
the composable before dispatching pagehide, then assert localStorage.getItem for
the workflow’s StorageKeys.draftPayload remains null. Keep the existing
mounted-pagehide flush behavior unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4d2f2997-b200-4d5e-a71b-5c7b6e7cda16

📥 Commits

Reviewing files that changed from the base of the PR and between 6f86ace and 4b1fc35.

📒 Files selected for processing (2)
  • src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts
  • src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.ts

@dante01yoon
dante01yoon enabled auto-merge August 2, 2026 13:27
coderabbitai[bot]
coderabbitai Bot previously requested changes Aug 2, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts`:
- Around line 656-658: Update the test setup around graphChangedHandler to
explicitly assert that the handler is registered before invoking it, rather than
using optional chaining. Ensure the graph edit triggers a pending write before
disposal, so the subsequent no-payload assertion verifies disposal behavior
instead of passing through a skipped handler.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ce6bc2d2-cffc-4a9f-aaaf-051df7f7d142

📥 Commits

Reviewing files that changed from the base of the PR and between 4b1fc35 and ec65312.

📒 Files selected for processing (1)
  • src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts

@dante01yoon
dante01yoon dismissed coderabbitai[bot]’s stale review August 2, 2026 13:33

Requested disposal coverage was added in ec65312 and the review thread is resolved.

@codecov

codecov Bot commented Aug 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #14575      +/-   ##
==========================================
- Coverage   79.14%   79.14%   -0.01%     
==========================================
  Files        1769     1769              
  Lines      113307   113310       +3     
  Branches    35242    35241       -1     
==========================================
+ Hits        89678    89680       +2     
+ Misses      23092    23088       -4     
- Partials      537      542       +5     
Flag Coverage Δ
unit 70.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ersistence/composables/useWorkflowPersistenceV2.ts 93.00% <100.00%> (+0.08%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.48 labels Aug 2, 2026
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Verification — AS IS / TO BE

Scenario: in a personal workspace, persist one node, add a second node, then refresh after 80 ms (before the 512 ms persistence debounce fires).

  • AS IS — without the pagehide flush: the last edit is lost; 1 of 2 nodes returns.
  • TO BE — with this PR: pagehide flushes the pending write; both nodes return.

AS IS versus TO BE workflow draft refresh behavior

@dante01yoon
dante01yoon dismissed coderabbitai[bot]’s stale review August 2, 2026 14:09

The false-positive test setup was corrected in 2d22f41 and the review thread is resolved.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 2, 2026
@dante01yoon
dante01yoon added this pull request to the merge queue Aug 16, 2026
Merged via the queue into main with commit 2b99609 Aug 16, 2026
60 checks passed
@dante01yoon
dante01yoon deleted the jaewon/fe-1484-workflow-drafts-persist-refresh branch August 16, 2026 07:13
@comfy-pr-bot

Copy link
Copy Markdown
Member

@dante01yoon Successfully backported to #15335

@comfy-pr-bot

Copy link
Copy Markdown
Member

@dante01yoon Successfully backported to #15336

@github-actions github-actions Bot removed the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Aug 16, 2026
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Aug 17, 2026
…y-Org#15069)

Drop a new image on a Load Image node, reload the browser without saving
— the node comes back with the **previous** image.

## Intended behaviour

It should survive. `Comfy.Workflow.Persist` defaults to `true`
(`coreSettings.ts:1129`) and `useWorkflowPersistenceV2` writes a
localStorage draft on every `graphChanged`, debounced 512ms. Autosave
being `off` by default is a red herring — the draft, not autosave, is
what restores a page reload. So this is a bug, not a wrong expectation.

## Root cause

`graphChanged` is dispatched from exactly one place:
`ChangeTracker.updateModified` (`changeTracker.ts:393`), reachable only
via `captureCanvasState()`. Every caller of `captureCanvasState`
registered in `ChangeTracker.init()` is a user-input hook — `keyup`,
`mouseup` (`:587`), `LGraphCanvas.processMouseUp`, `ContextMenu.close`,
litegraph change transactions.

HTML5 drag-and-drop emits **no** `mousedown`/`mouseup`, and the upload
resolves asynchronously *after* the drop gesture ends. So when
`useImageUploadWidget`'s `onUploadComplete` commits the new value with a
bare property assignment, nothing nudges the tracker: `activeState` is
never refreshed, `isModified` stays false, `graphChanged` never fires,
the draft is never rewritten. On reload the draft still holds the old
filename.

The file picker has the same gap; it's just less reproducible, because a
later stray click anywhere on the page happens to flush it.

`createAssetWidget.ts:105-107` already does exactly this for the asset
browser. `useImageUploadWidget`'s commit block was the same shape minus
that call.

## Change

Capture canvas state when the committed value actually differs,
mirroring `createAssetWidget`.

## Regression coverage

Red commit first (`bed706e0d7`).

- Unit: an upload that changes the combo value captures canvas state;
one that doesn't, doesn't.
- E2E: `browser_tests/tests/loadImageUploadPersistence.spec.ts` — drop a
file on a Load Image node, wait for the draft index to update, reload,
assert the widget still holds the dropped value.

## Scope

One call in the frontend commit path. No API, schema, or backend
contract. Independent of the assets rework.

## Notes for review

- Reported in FE-1425. Related but **not** fixed here: the preview is
nulled at `useNodeImageUpload.ts:109` before the upload and is not
restored when the upload fails, so a failed drop leaves the node blank —
that's the "old image disappears" half and wants its own PR.
- Adjacent open work worth sequencing against:
Comfy-Org#14575 (flush pending
draft writes on `pagehide`) fixes a different window in the same
mechanism and is complementary, not overlapping.
- The e2e was not executed locally (no ComfyUI backend on this machine);
unit tests and typecheck were.

---------

Co-authored-by: Connor Byrne <c.byrne@comfy.org>
comfy-pr-bot added a commit that referenced this pull request Aug 26, 2026
…#15335)

Backport of #14575 to `core/1.48`

Automatically created by backport workflow.

Co-authored-by: Dante <bunggl@naver.com>
Co-authored-by: dante01yoon <6510430+dante01yoon@users.noreply.github.com>
Co-authored-by: Amp <amp@ampcode.com>
comfy-pr-bot added a commit that referenced this pull request Aug 26, 2026
#15336)

Backport of #14575 to `cloud/1.48`

Automatically created by backport workflow.

Co-authored-by: Dante <bunggl@naver.com>
Co-authored-by: dante01yoon <6510430+dante01yoon@users.noreply.github.com>
Co-authored-by: Amp <amp@ampcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants