Repository navigation
fix(settings): render the legacy credits body on the local Credits tab - #15275
comfydesigner wants to merge 4 commits into
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019ffdc1-4c9f-7326-b121-80041ba8a10d Co-authored-by: Amp <amp@ampcode.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1814 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-14T23:14:13.394Z",
"gitSha": "f0db89bbf7cedc34fb4f00c08274936c30d1c136",
"branch": "comfydesigner/local-credits-body",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2051.474000000013,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.858999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.402,
"heapDeltaBytes": 4982060,
"heapUsedBytes": 69500540,
"domNodes": 16,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 8.896,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2021.0309999999936,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.958,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.36999999999995,
"heapDeltaBytes": 4985192,
"heapUsedBytes": 69490860,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 7.916999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1888.70399999999,
"styleRecalcs": 76,
"styleRecalcDurationMs": 42.052,
"layouts": 12,
"layoutDurationMs": 3.8100000000000005,
"taskDurationMs": 879.038,
"heapDeltaBytes": -692384,
"heapUsedBytes": 63679224,
"domNodes": 59,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 108.27400000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.082999999997,
"styleRecalcs": 76,
"styleRecalcDurationMs": 41.463,
"layouts": 12,
"layoutDurationMs": 3.798,
"taskDurationMs": 905.029,
"heapDeltaBytes": -15247276,
"heapUsedBytes": 49333208,
"domNodes": -282,
"jsHeapTotalBytes": 24612864,
"scriptDurationMs": 111.239,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.8689999999947,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.532,
"layouts": 6,
"layoutDurationMs": 0.662,
"taskDurationMs": 417.05300000000005,
"heapDeltaBytes": 7845272,
"heapUsedBytes": 72307808,
"domNodes": 78,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 12.845,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.7260000000797,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.244999999999997,
"layouts": 6,
"layoutDurationMs": 0.6610000000000001,
"taskDurationMs": 357.371,
"heapDeltaBytes": 8002984,
"heapUsedBytes": 72352460,
"domNodes": 77,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 9.514999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 606.7370000000096,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.716999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.02600000000007,
"heapDeltaBytes": -11312872,
"heapUsedBytes": 53139996,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 55.217,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 590.0269999999637,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.519999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.666,
"heapDeltaBytes": -11353720,
"heapUsedBytes": 53134048,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 54.114000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.3339999999826,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.382000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 695.6830000000001,
"heapDeltaBytes": 12077052,
"heapUsedBytes": 71746692,
"domNodes": -284,
"jsHeapTotalBytes": 4030464,
"scriptDurationMs": 21.197,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2032.7050000000781,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.841,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 644.7769999999999,
"heapDeltaBytes": 12839848,
"heapUsedBytes": 72869896,
"domNodes": -282,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 15.508999999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2187.817999999993,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.383999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1207.0910000000001,
"heapDeltaBytes": 10754452,
"heapUsedBytes": 71129388,
"domNodes": -287,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 318.631,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2167.0230000000856,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.249000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1159.23,
"heapDeltaBytes": 12258800,
"heapUsedBytes": 72983828,
"domNodes": -285,
"jsHeapTotalBytes": 2387968,
"scriptDurationMs": 301.533,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3266.8519999999717,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.489,
"layouts": 60,
"layoutDurationMs": 8.565,
"taskDurationMs": 1477.683,
"heapDeltaBytes": 97744,
"heapUsedBytes": 62312116,
"domNodes": -286,
"jsHeapTotalBytes": 4030464,
"scriptDurationMs": 404.26800000000003,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3129.2159999999285,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.526000000000002,
"layouts": 60,
"layoutDurationMs": 8.084,
"taskDurationMs": 1361.709,
"heapDeltaBytes": -7851740,
"heapUsedBytes": 55117004,
"domNodes": -289,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 377.85400000000004,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.9560000000033,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.322000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 764.3340000000001,
"heapDeltaBytes": 12980452,
"heapUsedBytes": 74387392,
"domNodes": -282,
"jsHeapTotalBytes": 2457600,
"scriptDurationMs": 18.500000000000004,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2040.4859999999871,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.5489999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.1030000000001,
"heapDeltaBytes": 13149428,
"heapUsedBytes": 73934860,
"domNodes": -283,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 14.997,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 677.7660000000196,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.062999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.87499999999994,
"heapDeltaBytes": -10481212,
"heapUsedBytes": 54115204,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 124.628,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.0660000000644,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.109999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.929,
"heapDeltaBytes": -10820208,
"heapUsedBytes": 54222656,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 122.15699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.7239999999783,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.969,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.54200000000003,
"heapDeltaBytes": 5136204,
"heapUsedBytes": 69841232,
"domNodes": 22,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 7.888000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2038.7880000000678,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.316,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.32699999999994,
"heapDeltaBytes": 5164816,
"heapUsedBytes": 69717096,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 7.496000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.6749999999688,
"styleRecalcs": 79,
"styleRecalcDurationMs": 43.087,
"layouts": 16,
"layoutDurationMs": 4.824,
"taskDurationMs": 829.5049999999999,
"heapDeltaBytes": -3999232,
"heapUsedBytes": 60662068,
"domNodes": 65,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 91.34100000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1718.134999999961,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.39,
"layouts": 16,
"layoutDurationMs": 4.482,
"taskDurationMs": 789.481,
"heapDeltaBytes": -4113472,
"heapUsedBytes": 60602936,
"domNodes": 65,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 85.14,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.416999999985,
"styleRecalcs": 21,
"styleRecalcDurationMs": 29.462000000000003,
"layouts": 16,
"layoutDurationMs": 11.550999999999998,
"taskDurationMs": 933.1100000000001,
"heapDeltaBytes": -6096456,
"heapUsedBytes": 80435132,
"domNodes": 13673,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 16.26299999999999,
"eventListeners": 2375,
"totalBlockingTimeMs": 120,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8383.789999999975,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.98,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4289.133000000001,
"heapDeltaBytes": 15491176,
"heapUsedBytes": 75925656,
"domNodes": -282,
"jsHeapTotalBytes": 2387968,
"scriptDurationMs": 983.7499999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8245.265000000018,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.678999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3999.506,
"heapDeltaBytes": 13790968,
"heapUsedBytes": 74137708,
"domNodes": -283,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 935.5169999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 18643.557999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17682.113,
"heapDeltaBytes": -43919368,
"heapUsedBytes": 167577608,
"domNodes": -8312,
"jsHeapTotalBytes": -12787712,
"scriptDurationMs": 147.13700000000003,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18562.854000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17563.357,
"heapDeltaBytes": -32179576,
"heapUsedBytes": 165588472,
"domNodes": -8316,
"jsHeapTotalBytes": -17244160,
"scriptDurationMs": 129.608,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22526.79499999999,
"styleRecalcs": 175,
"styleRecalcDurationMs": 24.610999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21997.928,
"heapDeltaBytes": -28503596,
"heapUsedBytes": 181874444,
"domNodes": -8317,
"jsHeapTotalBytes": -10493952,
"scriptDurationMs": 448.6140000000001,
"eventListeners": -16381,
"totalBlockingTimeMs": 202,
"frameDurationMs": 18.33666666666662,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22021.671999999966,
"styleRecalcs": 179,
"styleRecalcDurationMs": 20.73999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21394.190000000002,
"heapDeltaBytes": -15487596,
"heapUsedBytes": 182437004,
"domNodes": -8312,
"jsHeapTotalBytes": -12820480,
"scriptDurationMs": 400.952,
"eventListeners": -16381,
"totalBlockingTimeMs": 112,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 450.33699999999044,
"styleRecalcs": 13,
"styleRecalcDurationMs": 19.117999999999995,
"layouts": 3,
"layoutDurationMs": 0.7229999999999999,
"taskDurationMs": 108.776,
"heapDeltaBytes": 4948808,
"heapUsedBytes": 68551680,
"domNodes": 126,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.3370000000000015,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 451.1610000000701,
"styleRecalcs": 12,
"styleRecalcDurationMs": 17.918999999999997,
"layouts": 3,
"layoutDurationMs": 0.71,
"taskDurationMs": 103.905,
"heapDeltaBytes": 4928728,
"heapUsedBytes": 68424896,
"domNodes": 121,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7.4190000000000005,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #15275 +/- ##
==========================================
- Coverage 81.33% 80.98% -0.36%
==========================================
Files 1884 1884
Lines 109538 112065 +2527
Branches 33207 32320 -887
==========================================
+ Hits 89093 90752 +1659
- Misses 20069 20930 +861
- Partials 376 383 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 74 files with indirect coverage changes 🚀 New features to boost your workflow:
|
95aa6ed to
a8360bc
Compare
|
Updating Playwright Expectations |
Behavior: on local, the Credits tab shows the user's real credit balance and top-up actions — never another plan's card or pricing. Behavioral source of truth for local V1: the Plan & Credits decision log.
Stacked on #15239; delivers the review item that can't be a GitHub suggestion because it touches files outside that PR's diff.
Local Credits tab renders the legacy credits body. With
SubscriptionPanelContentWorkspaceunconditional, local shows the workspace plan card against legacy balance data — verified on a local build: $0/mo plan, cloud tier benefits, wrong out-of-credits state. Off-cloud the Credits tab now forks to the legacy credits content inside the "Workspace credits" card with Manage billing (legacy portal), per the design.CreditsPanelgainsembedded/show-footer-linksprops; the tab becomes one scrolling column ending in the sharedSubscriptionFooterLinks(whose top divider is removed by design — note: that line also disappears from the cloud subscription overview, intentional).The sidebar entry keeps the "Plan & Credits" label and icon on both distributions — decided 2026-08-14 (Alex + Mar): local reads "Plan & Credits" too, in settings and the user profile menu. An earlier revision of this PR forked the label to "Credits" off-cloud; that's been dropped.
Merge into #15239 or land right after it — either works.