Repository navigation
feat(settings): plans-in-settings prototype for local Plan & Credits - #15268
comfydesigner wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1810 passed, 0 failed · 4 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-14T22:24:08.659Z",
"gitSha": "526788f1dde2ad6d1ac5ba8531fb437dd2fb6eae",
"branch": "comfydesigner/settings-plans-prototype",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2035.8939999999848,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.148,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.1550000000001,
"heapDeltaBytes": 4983400,
"heapUsedBytes": 69372836,
"domNodes": 16,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 10.845,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2021.9869999999673,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.552999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.0350000000001,
"heapDeltaBytes": 4936068,
"heapUsedBytes": 69368160,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 10.398000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2187.0079999999916,
"styleRecalcs": 80,
"styleRecalcDurationMs": 55.778000000000006,
"layouts": 12,
"layoutDurationMs": 4.203,
"taskDurationMs": 1147.8310000000001,
"heapDeltaBytes": -672332,
"heapUsedBytes": 63764052,
"domNodes": 63,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 141.598,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1887.1959999999035,
"styleRecalcs": 74,
"styleRecalcDurationMs": 41.272999999999996,
"layouts": 12,
"layoutDurationMs": 3.419,
"taskDurationMs": 954.296,
"heapDeltaBytes": -109796,
"heapUsedBytes": 64545144,
"domNodes": 56,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 122.99499999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1769.444999999962,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.183000000000003,
"layouts": 6,
"layoutDurationMs": 0.8099999999999999,
"taskDurationMs": 465.508,
"heapDeltaBytes": 8076004,
"heapUsedBytes": 72732784,
"domNodes": 76,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 14.286,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1769.1160000000536,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.403000000000002,
"layouts": 6,
"layoutDurationMs": 0.7159999999999999,
"taskDurationMs": 452.208,
"heapDeltaBytes": 7999140,
"heapUsedBytes": 72624716,
"domNodes": 76,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 14.034,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 722.2219999999879,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.342000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.55500000000006,
"heapDeltaBytes": -10874156,
"heapUsedBytes": 53605160,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 69.334,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 622.7719999999408,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.975999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.959,
"heapDeltaBytes": -11345920,
"heapUsedBytes": 53280824,
"domNodes": 20,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 61.28600000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2030.1230000000032,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.567000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 709.9,
"heapDeltaBytes": 12782772,
"heapUsedBytes": 72247500,
"domNodes": -283,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 19.049000000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2036.354000000074,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.34,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 743.5149999999999,
"heapDeltaBytes": 12491604,
"heapUsedBytes": 72072816,
"domNodes": -283,
"jsHeapTotalBytes": 1933312,
"scriptDurationMs": 18.993000000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2343.34199999995,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.757000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1337.99,
"heapDeltaBytes": -1574852,
"heapUsedBytes": 59643276,
"domNodes": -285,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 356.263,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2353.8320000000112,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.836000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1306.406,
"heapDeltaBytes": -811412,
"heapUsedBytes": 59582888,
"domNodes": -285,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 354.541,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3297.928000000013,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.330000000000002,
"layouts": 60,
"layoutDurationMs": 10.187,
"taskDurationMs": 1541.255,
"heapDeltaBytes": 55700,
"heapUsedBytes": 62592256,
"domNodes": -289,
"jsHeapTotalBytes": 4030464,
"scriptDurationMs": 431.20000000000005,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3345.352000000048,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.334999999999997,
"layouts": 60,
"layoutDurationMs": 7.887,
"taskDurationMs": 1518.221,
"heapDeltaBytes": 3789984,
"heapUsedBytes": 65362024,
"domNodes": -287,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 408.55199999999996,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2024.287999999956,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.102,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 757.4990000000001,
"heapDeltaBytes": 12465052,
"heapUsedBytes": 73791304,
"domNodes": -283,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 18.853999999999996,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2040.3840000000173,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.372,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 726.707,
"heapDeltaBytes": 12527224,
"heapUsedBytes": 73882420,
"domNodes": -283,
"jsHeapTotalBytes": 2195456,
"scriptDurationMs": 19.002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 680.4460000000176,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.841999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.222,
"heapDeltaBytes": -10716044,
"heapUsedBytes": 53824020,
"domNodes": 18,
"jsHeapTotalBytes": 26738688,
"scriptDurationMs": 124.992,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 666.9870000000628,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.520999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.013,
"heapDeltaBytes": -10739804,
"heapUsedBytes": 53988800,
"domNodes": 18,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 120.049,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2001.8680000000018,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.768999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.9989999999999,
"heapDeltaBytes": 5024140,
"heapUsedBytes": 69767336,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 11.695,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2002.1600000000035,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.043999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.012,
"heapDeltaBytes": 5281896,
"heapUsedBytes": 69678932,
"domNodes": 18,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 9.399000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1703.9679999999748,
"styleRecalcs": 75,
"styleRecalcDurationMs": 39.044000000000004,
"layouts": 16,
"layoutDurationMs": 5.266,
"taskDurationMs": 858.7320000000001,
"heapDeltaBytes": -4235448,
"heapUsedBytes": 60296944,
"domNodes": 60,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 93.24000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.3939999999848,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.382,
"layouts": 16,
"layoutDurationMs": 4.492999999999999,
"taskDurationMs": 847.463,
"heapDeltaBytes": -3966052,
"heapUsedBytes": 60836396,
"domNodes": 63,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 92.903,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1419.4549999999708,
"styleRecalcs": 20,
"styleRecalcDurationMs": 32.58399999999999,
"layouts": 15,
"layoutDurationMs": 13.509999999999998,
"taskDurationMs": 1038.7879999999998,
"heapDeltaBytes": -3995316,
"heapUsedBytes": 79594660,
"domNodes": 13673,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 20.500999999999998,
"eventListeners": 2375,
"totalBlockingTimeMs": 159,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9008.208999999966,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.330000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4718.256,
"heapDeltaBytes": 16201096,
"heapUsedBytes": 76075256,
"domNodes": -283,
"jsHeapTotalBytes": 2912256,
"scriptDurationMs": 1113.587,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9052.490999999918,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.888000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4691.987,
"heapDeltaBytes": 15279184,
"heapUsedBytes": 75703860,
"domNodes": -283,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 1086.856,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18206.172999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17293.989,
"heapDeltaBytes": -44602036,
"heapUsedBytes": 165572116,
"domNodes": -8312,
"jsHeapTotalBytes": -10952704,
"scriptDurationMs": 138.83299999999997,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18562.83799999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17497.497,
"heapDeltaBytes": -40639900,
"heapUsedBytes": 170898852,
"domNodes": -8312,
"jsHeapTotalBytes": -9637888,
"scriptDurationMs": 132.038,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21845.191999999995,
"styleRecalcs": 171,
"styleRecalcDurationMs": 23.640999999999966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21227.301,
"heapDeltaBytes": -46519196,
"heapUsedBytes": 163375240,
"domNodes": -8312,
"jsHeapTotalBytes": -10424320,
"scriptDurationMs": 491.887,
"eventListeners": -16385,
"totalBlockingTimeMs": 210,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21952.47299999994,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.085999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21273.874,
"heapDeltaBytes": -27090888,
"heapUsedBytes": 183296900,
"domNodes": -8312,
"jsHeapTotalBytes": -15704064,
"scriptDurationMs": 450.36800000000005,
"eventListeners": -16379,
"totalBlockingTimeMs": 161,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 467.58199999999306,
"styleRecalcs": 14,
"styleRecalcDurationMs": 23,
"layouts": 4,
"layoutDurationMs": 1.319,
"taskDurationMs": 125.82900000000002,
"heapDeltaBytes": 5020016,
"heapUsedBytes": 68850692,
"domNodes": 124,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.205,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 475.99800000000414,
"styleRecalcs": 17,
"styleRecalcDurationMs": 21.744000000000003,
"layouts": 4,
"layoutDurationMs": 1.2960000000000003,
"taskDurationMs": 117.89200000000001,
"heapDeltaBytes": 5050960,
"heapUsedBytes": 68502160,
"domNodes": 147,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.83,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
0c9d724 to
2e81826
Compare
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-15268.vercel.app This commit: https://website-frontend-gzh61tct0-comfyui.vercel.app Last updated: 2026-08-14T21:10:52Z for |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## comfydesigner/local-credits-body #15268 +/- ##
===================================================================
Coverage ? 80.95%
===================================================================
Files ? 1885
Lines ? 112161
Branches ? 31867
===================================================================
Hits ? 90797
Misses ? 20982
Partials ? 382
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
2e81826 to
a5e10d5
Compare
c13b266 to
91518a9
Compare
95aa6ed to
a8360bc
Compare
|
Closing: we're no longer putting plans in Cloud Settings. Cloud's Plan & Credits is becoming a balance card with Add credits, and plans move to the billing site (prototype: Comfy-Org/platform#1348). The branch stays if anything here is worth revisiting. |
What the user sees (prototype scope): the local Credits tab gains a Plans section below the credits card — personal tier cards and the Teams credit slider with real pricing data, billed-yearly toggle, and an Enterprise contact band. Buttons are inert; checkout keeps the existing modal (decision log item 7). Behavioral source of truth for local V1: the Plan & Credits decision log.
Design prototype for moving the pricing plans out of the subscription dialog and into Settings > Plan & Credits, per DES-734. Reference implementation to visualize the direction — adopt, adapt, or rebuild from it freely.
Designs: personal · teams
What it adds —
SettingsPlansSectionrenders below the Workspace credits card on the local Credits tab: Plans header, Personal/TeamsToggleGroup, Billed-yearlySwitchwith the Save 20% pill, three personal plan cards, and for Teams the credit-slider card (productionCreditSlider) with the Details column and the Enterprise contact band, closing with the "Checkout happens right here" caption.Real vs stubbed
TIER_PRICINGandTEAM_PLAN_CREDIT_STOPS; the slider is the productionCreditSlider(cyclehalves the yearly discount on monthly); toggles are design-system components.GET /api/billing/plans → team_credit_stopslikeUnifiedPricingTabledoes, not the hardcoded fallback.Recommendation for productionizing: the personal card markup follows the Figma variant, close to (but not identical to)
UnifiedPricingTable's cards. Rather than two copies, extract the card internals fromUnifiedPricingTableinto shared subcomponents and compose them from both surfaces — the structural difference is only who owns the audience/cycle controls.Stacked on #15275 (the local credits body it renders beneath), which stacks on #15239. Not intended to merge as-is — it's the working reference for the settings-plans build.
Screenshots (Playwright, mocked local boot, 1440x1000)
Opening view — the credits card owns the first viewport; Plans crests the fold:
Personal plans (Billed yearly on) — the full section fits one viewport once scrolled:
Teams — the credit-slider card with Details and the Enterprise band, no scrolling needed:
Run locally: OSS backend on 8188, then
pnpm dev— Settings > Plan & Credits.