Repository navigation
fix: make locale planning and validation explicit - #15236
benceruleanlu wants to merge 4 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1979 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.14 MB gzipDetailsSummary
Category Glance App Entry Points — 3.71 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.38 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 124 kBTop-level views, pages, and routed surfaces
Status: 17 added Panels & Settings — 591 kBConfiguration panels, inspectors, and settings screens
Status: 27 added User & Accounts — 27.5 kBAuthentication, profile, and account management bundles
Status: 11 added Editors & Dialogs — 125 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 67.1 kBReusable component library chunks
Status: 14 added Data & Services — 3.49 MBStores, services, APIs, and repositories
Status: 17 added Utilities & Hooks — 549 kBHelpers, composables, and utility bundles
Status: 37 added Vendor & Third-Party — 18.1 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 14.3 MBBundles that do not match a named category
Status: 290 added ⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-24T10:06:56.030Z",
"gitSha": "36888e886aa2b5c0a49b84b8bf418eb6d402ec66",
"branch": "bl/i18n-planning-validation-core",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.8960000000643,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.047,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.243,
"heapDeltaBytes": 13697540,
"heapUsedBytes": 75492416,
"domNodes": -283,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 9.060999999999998,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2043.1640000001607,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.892999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.454,
"heapDeltaBytes": 12064036,
"heapUsedBytes": 74624480,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.138000000000003,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2105.144999999993,
"styleRecalcs": 79,
"styleRecalcDurationMs": 46.938,
"layouts": 12,
"layoutDurationMs": 3.8689999999999998,
"taskDurationMs": 1050.96,
"heapDeltaBytes": -4097920,
"heapUsedBytes": 58912560,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 127.003,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1848.9750000001095,
"styleRecalcs": 72,
"styleRecalcDurationMs": 35.708000000000006,
"layouts": 12,
"layoutDurationMs": 3.641,
"taskDurationMs": 868.5749999999998,
"heapDeltaBytes": -3727112,
"heapUsedBytes": 58058452,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 110.343,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.066000000027,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.927,
"layouts": 6,
"layoutDurationMs": 0.7210000000000001,
"taskDurationMs": 396.394,
"heapDeltaBytes": 3362048,
"heapUsedBytes": 65520384,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.212,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1714.8849999998674,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.408,
"layouts": 6,
"layoutDurationMs": 0.776,
"taskDurationMs": 393.55,
"heapDeltaBytes": 3385388,
"heapUsedBytes": 65549384,
"domNodes": 77,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 11.738999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 543.8299999999572,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.363999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.787,
"heapDeltaBytes": 10117452,
"heapUsedBytes": 71957948,
"domNodes": 14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 56.267,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 578.5430000000815,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.0969999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.071,
"heapDeltaBytes": 10532000,
"heapUsedBytes": 72331196,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 59.445,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.8479999999454,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.156,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 672.325,
"heapDeltaBytes": -5403868,
"heapUsedBytes": 71804400,
"domNodes": -281,
"jsHeapTotalBytes": -1839104,
"scriptDurationMs": 16.218,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2022.7230000000418,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.790000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 660.032,
"heapDeltaBytes": -13185528,
"heapUsedBytes": 63923304,
"domNodes": -283,
"jsHeapTotalBytes": 3665920,
"scriptDurationMs": 15.376000000000001,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2281.3730000000305,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.714,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1263.1229999999998,
"heapDeltaBytes": -13801480,
"heapUsedBytes": 64093608,
"domNodes": -285,
"jsHeapTotalBytes": 4452352,
"scriptDurationMs": 347.976,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2353.7220000000616,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.920000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1334.898,
"heapDeltaBytes": -6151924,
"heapUsedBytes": 72115788,
"domNodes": -277,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 401.231,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3263.0659999999807,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.495000000000001,
"layouts": 60,
"layoutDurationMs": 7.763999999999999,
"taskDurationMs": 1462.923,
"heapDeltaBytes": -9908764,
"heapUsedBytes": 69618640,
"domNodes": -287,
"jsHeapTotalBytes": 4976640,
"scriptDurationMs": 396.001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3233.8689999999133,
"styleRecalcs": 65,
"styleRecalcDurationMs": 18.259,
"layouts": 60,
"layoutDurationMs": 7.221,
"taskDurationMs": 1449.6970000000001,
"heapDeltaBytes": -4425576,
"heapUsedBytes": 74709060,
"domNodes": -249,
"jsHeapTotalBytes": -4096,
"scriptDurationMs": 399.082,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2364.358999999922,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.944,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1457.64,
"heapDeltaBytes": -14338460,
"heapUsedBytes": 70386052,
"domNodes": 12,
"jsHeapTotalBytes": 8425472,
"scriptDurationMs": 457.115,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2416.8190000000322,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.091,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1465.241,
"heapDeltaBytes": 11085312,
"heapUsedBytes": 96608960,
"domNodes": 12,
"jsHeapTotalBytes": 8056832,
"scriptDurationMs": 462.04100000000005,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.8930000000018,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.7780000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 668.21,
"heapDeltaBytes": -13436080,
"heapUsedBytes": 69974468,
"domNodes": -281,
"jsHeapTotalBytes": 3403776,
"scriptDurationMs": 15.514,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.2560000001322,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.897999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 678.293,
"heapDeltaBytes": -6526384,
"heapUsedBytes": 71599788,
"domNodes": -285,
"jsHeapTotalBytes": -790528,
"scriptDurationMs": 17.339999999999996,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.5240000000449,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.844999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.66,
"heapDeltaBytes": 10841796,
"heapUsedBytes": 73284224,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 119.77199999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.5669999999645,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.307,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.33099999999996,
"heapDeltaBytes": 11491408,
"heapUsedBytes": 74220504,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 120.417,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.8909999999823,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.458999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.694,
"heapDeltaBytes": 18690352,
"heapUsedBytes": 81434116,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.056999999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.2889999999534,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.554999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.4649999999999,
"heapDeltaBytes": 19094788,
"heapUsedBytes": 82073352,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.404,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.5500000000611,
"styleRecalcs": 75,
"styleRecalcDurationMs": 39.288000000000004,
"layouts": 16,
"layoutDurationMs": 5.262,
"taskDurationMs": 854.6799999999998,
"heapDeltaBytes": 2604876,
"heapUsedBytes": 65361608,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 90.104,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1753.4550000000309,
"styleRecalcs": 74,
"styleRecalcDurationMs": 39.855000000000004,
"layouts": 16,
"layoutDurationMs": 4.5889999999999995,
"taskDurationMs": 855.329,
"heapDeltaBytes": 2803488,
"heapUsedBytes": 65927148,
"domNodes": -283,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 90.254,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1426.0510000001432,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.344,
"layouts": 14,
"layoutDurationMs": 14.612,
"taskDurationMs": 1015.175,
"heapDeltaBytes": -6163836,
"heapUsedBytes": 86882576,
"domNodes": 13673,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 19.587000000000007,
"eventListeners": 2373,
"totalBlockingTimeMs": 150,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8513.6839999999,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.876,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4447.947,
"heapDeltaBytes": 1112448,
"heapUsedBytes": 78316764,
"domNodes": -277,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 1057.6219999999998,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8464.203999999881,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.74799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4351.951,
"heapDeltaBytes": -11483028,
"heapUsedBytes": 64837020,
"domNodes": -281,
"jsHeapTotalBytes": 4190208,
"scriptDurationMs": 1040.118,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17925.96500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16959.196,
"heapDeltaBytes": -37117072,
"heapUsedBytes": 181432428,
"domNodes": -8312,
"jsHeapTotalBytes": -16388096,
"scriptDurationMs": 119.012,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17563.936999999896,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16841.088,
"heapDeltaBytes": -39834268,
"heapUsedBytes": 178504240,
"domNodes": -8312,
"jsHeapTotalBytes": -22503424,
"scriptDurationMs": 117.63900000000001,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20940.20599999999,
"styleRecalcs": 172,
"styleRecalcDurationMs": 19.052999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20365.755,
"heapDeltaBytes": -37858024,
"heapUsedBytes": 193235284,
"domNodes": -8312,
"jsHeapTotalBytes": -21823488,
"scriptDurationMs": 408.749,
"eventListeners": -16387,
"totalBlockingTimeMs": 119,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21050.253000000113,
"styleRecalcs": 170,
"styleRecalcDurationMs": 17.941999999999958,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20397.25,
"heapDeltaBytes": -40880064,
"heapUsedBytes": 192717192,
"domNodes": -8312,
"jsHeapTotalBytes": -24535040,
"scriptDurationMs": 401.14099999999996,
"eventListeners": -16387,
"totalBlockingTimeMs": 99,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 115.66300000004048,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.732000000000003,
"layouts": 7,
"layoutDurationMs": 1.9620000000000002,
"taskDurationMs": 84.87699999999998,
"heapDeltaBytes": 3066204,
"heapUsedBytes": 65239932,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.542,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 112.19000000005508,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.003999999999998,
"layouts": 2,
"layoutDurationMs": 1.2650000000000001,
"taskDurationMs": 85.48800000000001,
"heapDeltaBytes": 3073668,
"heapUsedBytes": 65412120,
"domNodes": 111,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.877999999999998,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
🎨 Storybook: 🚧 Building... |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5660c88cdf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| auditErrors: auditProtectedLiterals( | ||
| plan.source, | ||
| existing, | ||
| plan.invalidated | ||
| ), |
There was a problem hiding this comment.
Exclude shape-pending leaves from the preserved-value audit
When an unchanged locale leaf has the wrong type or array length, collectPendingLeaves correctly queues it with reason shape, but this audit also reports the same leaf as a type/shape violation because only source-invalidated paths are skipped. The global preflight at lines 426–435 then aborts before any queued translation can run, so one malformed locale value blocks regeneration for every file instead of being repaired; audit only leaves classified for preservation, or at least exclude all pendingLeaves paths.
Useful? React with 👍 / 👎.
| const linkedMessagePattern = | ||
| /@(?:\.[A-Za-z][A-Za-z0-9_-]*)?:(?:[^\s@|(){}]+|\{(?:[A-Za-z][A-Za-z0-9_.-]*|'[^']*')\})/g |
There was a problem hiding this comment.
Stop including punctuation in linked-message tokens
When a linked message is followed by normal punctuation, such as Open @:menu.save, then continue, the broad [^^\s@|(){}]+-style character class consumes the comma as part of the protected token. A translation that keeps @:menu.save intact but localizes or moves the punctuation is therefore reported as missing one link and adding another, causing retries or a validation failure even though the vue-i18n link key is unchanged; constrain this part of the matcher to the actual linked-key/literal grammar.
Useful? React with 👍 / 👎.
|
Sorry the assignment was automatic from the agent, odd action given that the rest are all draft/unassigned |
79f6e39 to
3fde8f8
Compare
5660c88 to
92b9d65
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## bl/i18n-corpus-model-rollout #15236 +/- ##
================================================================
- Coverage 81.93% 81.93% -0.01%
================================================================
Files 1905 1905
Lines 108627 108627
Branches 30342 29872 -470
================================================================
- Hits 89003 89002 -1
- Misses 19280 19282 +2
+ Partials 344 343 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
3fde8f8 to
e8bdbb5
Compare
92b9d65 to
638bf9b
Compare
e8bdbb5 to
c47e627
Compare
638bf9b to
8ae4395
Compare
f2aa550 to
d9e87d9
Compare
8ae4395 to
3e0033d
Compare
Scope the protected-literal audit to the leaves rebuildLocale actually preserves. Regenerated keys and untranslatable leaves are overwritten from the translation or the English source, so drift in them is no reason to refuse the write; previously a shape-mismatched translation was queued for regeneration and reported as a fatal violation at once, which no rerun could clear. Also restore a residual guard for malformed linked-message syntax the well-formed @:key pattern stopped matching, gate the empty-plural-form check on the English source, and cap per-leaf queued and pruned output.
Restore the prompt rule asking for the same number of plural forms. vue-i18n registers no per-locale plural rules, so it resolves every locale with its default resolver, and forms beyond the English count cannot be selected correctly. Defer plural handling to a dedicated change rather than sanctioning locale-specific form counts here.
At a floor of 5 the guard fires on routine cleanups in the two small entry files — deleting six keys from commands.json or settings.json aborts the release run and forces a manual re-dispatch with allow_prune. A guard that trips on ordinary work gets waved through by reflex, which costs the protection it exists to give. The ratio limit still governs the large files.
d9e87d9 to
7fc4763
Compare
03e5a00 to
1677222
Compare
|
Closing because this takes the wrong policy approach to validation failures. Valid syntax should be handled by improving the parser, intentional exceptions should be marked explicitly, and genuinely invalid translations should continue to autoregenerate. The useful provenance and reporting pieces can be reconsidered independently. |
Supersedes #15178 as the planning/validation review unit after the original combined PR was split.
Stacked on #15230.
The four focused review units are:
Summary
Make locale preserve/regenerate planning, provenance, protected-token validation, final validation, and operator reporting explicit.
Changes
Review Focus
The pending planner redesign is intentionally not implemented here. The next design decision is an authoritative plan that classifies every leaf as preserve or regenerate, audits only preserved leaves before generation, and validates the entire rebuilt locale without exclusions before writes or provenance advancement.
Linked messages are the one behavior change not part of the planning thesis.
@:keyand@.modifier:keyare now extracted as protected tokens and diffed as a set, replacing the bluntadded linked message @check; a residual@[.:]guard still rejects malformed link syntax the well-formed pattern does not match. Note that the English sources currently contain no linked messages, so this guard exists to stop the model inventing the syntax rather than to protect existing usage.Plural handling is deliberately out of scope. The prompt still asks for the same number of forms as English, and no form-count validation is added. vue-i18n registers no per-locale plural rules in this repo, so it resolves every locale with its default resolver and cannot correctly select forms beyond the English count.
main.jsonalready carries 196 form-count mismatches (26 in Russian, which renders incorrectly for counts of 5 and above). Both the runtime rules and the corpus repair belong to a dedicated follow-up.Prune thresholds are unchanged.
pruneCountFloorstays at 25 — a guard that trips on routine cleanups in the small entry files gets waved through withallow_pruneby reflex, which costs the protection it exists to give.Existing substantive review threads remain documented on #15178 for reviewer follow-up, including the shape-pending preflight concern and escaped interpolation behavior. The unresolved non-string retry policy belongs to #15229.
Known gap deferred to the planner redesign: the pre-generation audit failure is raised across all locales and entry files at once, so one drifted leaf blocks work on unrelated files. It fails in the safe direction and is scoped out here deliberately.
Validation:
mise exec -- pnpm test:unit scripts/i18n/update-locales.test.ts --run(33 passed)mise exec -- pnpm locale:check(exit 0; 0 protected-token violations)mise exec -- pnpm typecheck:scriptsmise exec -- pnpm typecheckmise exec -- pnpm lintmise exec -- pnpm knipmise exec -- pnpm format:check