Repository navigation
fix: repair locale corpus and remove violation baseline - #15230
benceruleanlu wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.14 MB gzipDetailsSummary
Category Glance App Entry Points — 3.71 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.38 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 124 kBTop-level views, pages, and routed surfaces
Status: 17 added Panels & Settings — 591 kBConfiguration panels, inspectors, and settings screens
Status: 27 added User & Accounts — 27.5 kBAuthentication, profile, and account management bundles
Status: 11 added Editors & Dialogs — 125 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 67.1 kBReusable component library chunks
Status: 14 added Data & Services — 3.49 MBStores, services, APIs, and repositories
Status: 17 added Utilities & Hooks — 549 kBHelpers, composables, and utility bundles
Status: 37 added Vendor & Third-Party — 18.1 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 14.3 MBBundles that do not match a named category
Status: 290 added ⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-24T10:05:48.336Z",
"gitSha": "4d6fa26a2cf63d75a64ead4d9b1380e4a357c2dc",
"branch": "bl/i18n-corpus-model-rollout",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2101.8420000000333,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.894000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.8449999999999,
"heapDeltaBytes": 17931360,
"heapUsedBytes": 80144832,
"domNodes": -284,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.547999999999998,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2058.228999999983,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.643999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.56600000000003,
"heapDeltaBytes": 18007852,
"heapUsedBytes": 80462836,
"domNodes": -281,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 6.515999999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1875.4169999999704,
"styleRecalcs": 74,
"styleRecalcDurationMs": 37.16,
"layouts": 12,
"layoutDurationMs": 3.4670000000000005,
"taskDurationMs": 838.716,
"heapDeltaBytes": 12191176,
"heapUsedBytes": 74535140,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 108.7,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1826.975000000175,
"styleRecalcs": 71,
"styleRecalcDurationMs": 32.076,
"layouts": 12,
"layoutDurationMs": 3.272,
"taskDurationMs": 843.4739999999999,
"heapDeltaBytes": -4285372,
"heapUsedBytes": 57609380,
"domNodes": -282,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 111.32000000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.63799999999,
"styleRecalcs": 31,
"styleRecalcDurationMs": 21.522,
"layouts": 6,
"layoutDurationMs": 0.656,
"taskDurationMs": 355.50399999999996,
"heapDeltaBytes": 3378640,
"heapUsedBytes": 65870544,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.962000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.304000000022,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.29,
"layouts": 6,
"layoutDurationMs": 0.6499999999999999,
"taskDurationMs": 346.104,
"heapDeltaBytes": 3125620,
"heapUsedBytes": 65629192,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.509,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 549.8900000000049,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.3999999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.77000000000004,
"heapDeltaBytes": 10441368,
"heapUsedBytes": 71875808,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 52.791000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 560.0540000000365,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.365000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.379,
"heapDeltaBytes": 11023172,
"heapUsedBytes": 73190136,
"domNodes": 16,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 53.318000000000005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2089.6679999999606,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.862,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.347,
"heapDeltaBytes": -555276,
"heapUsedBytes": 76420184,
"domNodes": -269,
"jsHeapTotalBytes": -1052672,
"scriptDurationMs": 15.080999999999998,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2040.0250000000142,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.549000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.9100000000001,
"heapDeltaBytes": -13681032,
"heapUsedBytes": 62572200,
"domNodes": -282,
"jsHeapTotalBytes": 3141632,
"scriptDurationMs": 12.268999999999998,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2180.099000000041,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.260000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1168.2109999999998,
"heapDeltaBytes": -14489444,
"heapUsedBytes": 62585016,
"domNodes": -285,
"jsHeapTotalBytes": 3141632,
"scriptDurationMs": 322.634,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2152.3990000000595,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.386,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1184.9729999999997,
"heapDeltaBytes": -5647792,
"heapUsedBytes": 72390236,
"domNodes": -276,
"jsHeapTotalBytes": -1089536,
"scriptDurationMs": 335.14900000000006,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3132.953000000043,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.561999999999998,
"layouts": 60,
"layoutDurationMs": 6.715000000000001,
"taskDurationMs": 1358.184,
"heapDeltaBytes": -4580344,
"heapUsedBytes": 74660560,
"domNodes": -245,
"jsHeapTotalBytes": -528384,
"scriptDurationMs": 373.547,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3150.181999999859,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.846000000000004,
"layouts": 60,
"layoutDurationMs": 7.3820000000000014,
"taskDurationMs": 1350.0079999999998,
"heapDeltaBytes": -14021748,
"heapUsedBytes": 65203672,
"domNodes": -287,
"jsHeapTotalBytes": 4714496,
"scriptDurationMs": 385.653,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2223.0469999999514,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.781999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1371.689,
"heapDeltaBytes": -15314484,
"heapUsedBytes": 69857312,
"domNodes": 14,
"jsHeapTotalBytes": 7639040,
"scriptDurationMs": 438.278,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2184.9059999999554,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.515000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1363.205,
"heapDeltaBytes": 11189596,
"heapUsedBytes": 90749832,
"domNodes": 10,
"jsHeapTotalBytes": 7270400,
"scriptDurationMs": 442.30099999999993,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2013.4299999999712,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.745999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.646,
"heapDeltaBytes": -13710780,
"heapUsedBytes": 63922072,
"domNodes": -285,
"jsHeapTotalBytes": 3141632,
"scriptDurationMs": 12.724999999999996,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2062.753000000157,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.941,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.286,
"heapDeltaBytes": -13418856,
"heapUsedBytes": 64812772,
"domNodes": -287,
"jsHeapTotalBytes": 3665920,
"scriptDurationMs": 13.559000000000001,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.1109999999981,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.227,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.742,
"heapDeltaBytes": 11855788,
"heapUsedBytes": 74355612,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 117.67699999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 528.919999999971,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.827000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.1789999999999,
"heapDeltaBytes": 11709696,
"heapUsedBytes": 74091928,
"domNodes": 14,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 112.90800000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.8739999999252,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.606,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.401,
"heapDeltaBytes": -5126336,
"heapUsedBytes": 57450548,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 5.851999999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.3509999998732,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.324,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.238,
"heapDeltaBytes": -7131612,
"heapUsedBytes": 55364840,
"domNodes": -281,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 5.747000000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.09799999996,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.303,
"layouts": 16,
"layoutDurationMs": 3.685,
"taskDurationMs": 760.0129999999999,
"heapDeltaBytes": -4350236,
"heapUsedBytes": 58255988,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 81.28,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.1549999998533,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.154,
"layouts": 16,
"layoutDurationMs": 4.437,
"taskDurationMs": 773.569,
"heapDeltaBytes": -3496600,
"heapUsedBytes": 59187168,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 81.554,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1399.8890000000301,
"styleRecalcs": 20,
"styleRecalcDurationMs": 30.33799999999999,
"layouts": 15,
"layoutDurationMs": 12.481000000000002,
"taskDurationMs": 898.8310000000001,
"heapDeltaBytes": -6228120,
"heapUsedBytes": 88845564,
"domNodes": 13673,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 14.946000000000002,
"eventListeners": 2373,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8194.659000000001,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.14,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3988.459,
"heapDeltaBytes": -4684404,
"heapUsedBytes": 71279416,
"domNodes": -279,
"jsHeapTotalBytes": 4677632,
"scriptDurationMs": 997.1370000000001,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8227.550999999949,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.647000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4024.278,
"heapDeltaBytes": 6579088,
"heapUsedBytes": 83684960,
"domNodes": -242,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 1015.182,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16762.065000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16025.113000000001,
"heapDeltaBytes": -42797784,
"heapUsedBytes": 175633148,
"domNodes": -8312,
"jsHeapTotalBytes": -29790208,
"scriptDurationMs": 97.18700000000001,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16793.001999999888,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16017.328000000003,
"heapDeltaBytes": -33590024,
"heapUsedBytes": 181090104,
"domNodes": -8312,
"jsHeapTotalBytes": -14336000,
"scriptDurationMs": 102.218,
"eventListeners": -16393,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19988.082999999962,
"styleRecalcs": 166,
"styleRecalcDurationMs": 15.653000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19459.972999999998,
"heapDeltaBytes": -26416560,
"heapUsedBytes": 194576976,
"domNodes": -8312,
"jsHeapTotalBytes": -23703552,
"scriptDurationMs": 396.589,
"eventListeners": -16389,
"totalBlockingTimeMs": 124,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20093.168999999987,
"styleRecalcs": 171,
"styleRecalcDurationMs": 15.738000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19516.663999999997,
"heapDeltaBytes": -27727908,
"heapUsedBytes": 186030500,
"domNodes": -8312,
"jsHeapTotalBytes": -18866176,
"scriptDurationMs": 394.23800000000006,
"eventListeners": -16387,
"totalBlockingTimeMs": 8,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 96.51000000008025,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.776000000000002,
"layouts": 2,
"layoutDurationMs": 0.8080000000000002,
"taskDurationMs": 69.851,
"heapDeltaBytes": 3128168,
"heapUsedBytes": 65470796,
"domNodes": 129,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.507999999999998,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 478.75199999998586,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.318000000000005,
"layouts": 9,
"layoutDurationMs": 2.4259999999999997,
"taskDurationMs": 117.37,
"heapDeltaBytes": 5197416,
"heapUsedBytes": 66415948,
"domNodes": 145,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.086,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🎭 Playwright: ✅ 1981 passed, 0 failed · 2 flaky📊 Browser Reports
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-15230.vercel.app This commit: https://website-frontend-rgkktvtev-comfyui.vercel.app Last updated: 2026-08-24T09:42:02Z for |
🎭 Playwright: ⏳ Running... |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## bl/i18n-openai-client-contract #15230 +/- ##
==================================================================
- Coverage 81.94% 81.93% -0.01%
==================================================================
Files 1905 1905
Lines 108627 108627
Branches 29872 30342 +470
==================================================================
- Hits 89010 89003 -7
- Misses 19273 19280 +7
Partials 344 344
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
66d728d to
ea943db
Compare
79f6e39 to
3fde8f8
Compare
ea943db to
532abef
Compare
3fde8f8 to
e8bdbb5
Compare
aa4f9d5 to
ad6a441
Compare
e8bdbb5 to
c47e627
Compare
ad6a441 to
ba3590f
Compare
f2aa550 to
d9e87d9
Compare
There was a problem hiding this comment.
💡 Codex Review
Deleting this file makes every locale command fail before doing any work: run() unconditionally passes this path to loadManifest(), which throws when it does not exist. This breaks both the Verify locale integrity step in .github/actions/lint-format-verify/action.yml, which runs pnpm locale:check, and the locale-update workflows that run pnpm locale; retain the manifest with its files hashes while removing only knownViolations.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The repaired corpus gave ar/ru/tr/pt-BR plural form counts that vue-i18n's default rule cannot address. No pluralRules are registered, so pluralDefault caps the index at Math.min(count, 2) for 3+ forms and picks index 0 only when count === 1 for 2 forms. Arabic's six CLDR forms rendered the dual for every count >= 2, Russian's gatedModelsHint rendered the plural at count === 1, and tr/pt-BR dropped the zero form that NodeSearchTypeFilterPopover renders when nothing is selected. Match the English form counts, as translate.ts already instructs the model to do, reusing the pre-existing generic plural wording for the "other" form.
ba3590f to
7eb3327
Compare
d9e87d9 to
7fc4763
Compare
|
Closing as stale. The locale rollout has already landed through newer work: current main pins gpt-5.6-terra, the corpus has been regenerated, and all 163 intended repaired leaves have moved forward (90 now have newer translations). Replaying this snapshot would overwrite current locale data. The still-useful removal of dormant knownViolations support can be carried independently while #15236 is rebuilt on the surviving stack/current corpus. |
Stacked on #15229.
Summary
Land the reviewed locale repair as one corpus/model rollout unit without the unrelated generation drift.
Changes
gpt-5.6-terra, preserve all 163 repaired locale/key pairs, remove the 25-keyknownViolationsmanifest escape hatch and supporting code, and delete its stale documentation.g.itemsSelectedandrightSidePanel.missingModels.gatedModelsHintcame back with CLDR-style form counts for ar/ru and a dropped zero form for tr/pt-BR. NopluralRulesare registered insrc/i18n.ts, so vue-i18n'spluralDefaultcaps the index atMath.min(count, 2)for 3+ forms and picks index 0 only whencount === 1for 2 forms — Arabic rendered the dual form for every count >= 2, Russian rendered the plural atcount === 1, and tr/pt-BR lost the zero case thatNodeSearchTypeFilterPopoverrenders when nothing is selected. Those six strings now match the English form counts, which is whatscripts/i18n/translate.tsalready instructs the model to produce.Review Focus
The 25 repaired keys and 163 locale leaves stay together with baseline removal. Locale JSON is byte-identical to the repaired #15178 corpus apart from the six plural strings above, and the unrelated generated translation/prune drift is absent.
Follow-up (not this PR): real CLDR plurals need
pluralRulesregistered plus per-locale form-count validation inscripts/i18n/protected-tokens.ts. That gate cannot land here — 202 of 598 locale/key pairs across 41 keys already carry arity that does not match English, so enforcing it now would require the very baseline this PR deletes.Validation:
serializeLocalepnpm locale:check(exit 0; 0 pending translations, 0 prunes, 0 protected-token violations)pnpm test:unit scripts/i18n/ --run(26 passed)pnpm typecheckpnpm typecheck:scriptspnpm lintpnpm knippnpm format:check