Repository navigation
fix: stop transient ineligibility from permanently completing the first-run tour - #15173
Conversation
handleStartupOutcome marked Comfy.TutorialCompleted for every user who was not a first-run candidate, but isFirstRunCandidate() also returns false for conditions that change between boots: viewport width, the onboarding_tour feature flag, and subscription config from /features. The setting is persisted server-side against the user record and is never unset, so one such boot permanently removed onboarding from the account. Split the decision into complete (not cloud, or a determined returning user) and defer (anything a later boot can lift). Both open the template browser; only complete writes the setting.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1801 passed, 0 failed · 5 flaky📊 Browser Reports
📦 Bundle: 8.84 MB gzip 🔴 +17 BDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.37 MB (baseline 1.37 MB) • 🔴 +93 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 2 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 27.2 kB (baseline 27.2 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks Status: 14 unchanged Data & Services — 3.51 MB (baseline 3.51 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 285 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-13T02:52:31.043Z",
"gitSha": "338bed3947bc879242dc2f84a670579fe892d14d",
"branch": "fix/first-run-tour-transient-ineligibility",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2002.5469999999927,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.017999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.556,
"heapDeltaBytes": 6011752,
"heapUsedBytes": 71019040,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 18.936,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2014.8249999999734,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.58,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.382,
"heapDeltaBytes": 5822536,
"heapUsedBytes": 70607512,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 16.758000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1920.4780000000028,
"styleRecalcs": 78,
"styleRecalcDurationMs": 43.242,
"layouts": 12,
"layoutDurationMs": 3.5410000000000004,
"taskDurationMs": 936.0540000000001,
"heapDeltaBytes": -14004192,
"heapUsedBytes": 50892160,
"domNodes": -283,
"jsHeapTotalBytes": 23826432,
"scriptDurationMs": 125.856,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1857.8180000000657,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.228,
"layouts": 12,
"layoutDurationMs": 3.6619999999999995,
"taskDurationMs": 886.71,
"heapDeltaBytes": 562644,
"heapUsedBytes": 65279892,
"domNodes": 59,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 129.767,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.7619999999752,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.403,
"layouts": 6,
"layoutDurationMs": 0.598,
"taskDurationMs": 390.25200000000007,
"heapDeltaBytes": 9134552,
"heapUsedBytes": 73926900,
"domNodes": 79,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 20.617000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.3789999999717,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.228,
"layouts": 6,
"layoutDurationMs": 0.7829999999999998,
"taskDurationMs": 453.59900000000005,
"heapDeltaBytes": 9228112,
"heapUsedBytes": 74000564,
"domNodes": 78,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 26.738999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 649.4280000000003,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.441999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.03000000000003,
"heapDeltaBytes": -10867192,
"heapUsedBytes": 53862336,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 74.214,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 575.085999999942,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.7219999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.198,
"heapDeltaBytes": -11370208,
"heapUsedBytes": 53472672,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 58.24700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2042.3040000000015,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.088999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 733.95,
"heapDeltaBytes": 7711016,
"heapUsedBytes": 67658216,
"domNodes": -284,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 120.25400000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.9990000000562,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.371000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 693.67,
"heapDeltaBytes": 7106968,
"heapUsedBytes": 68071380,
"domNodes": -282,
"jsHeapTotalBytes": 4292608,
"scriptDurationMs": 114.202,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2205.35000000001,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.333999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1314.744,
"heapDeltaBytes": 1610300,
"heapUsedBytes": 62555880,
"domNodes": -286,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 434.90000000000003,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2181.141000000025,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.128000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1309.7430000000002,
"heapDeltaBytes": -5777252,
"heapUsedBytes": 55224060,
"domNodes": -284,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 434.71999999999997,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3195.7120000000145,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.477,
"layouts": 60,
"layoutDurationMs": 7.28,
"taskDurationMs": 1544.1180000000002,
"heapDeltaBytes": -2394320,
"heapUsedBytes": 60071324,
"domNodes": -289,
"jsHeapTotalBytes": 5865472,
"scriptDurationMs": 541.705,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3212.7949999999146,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.535999999999998,
"layouts": 60,
"layoutDurationMs": 7.326,
"taskDurationMs": 1482.8700000000001,
"heapDeltaBytes": 24518632,
"heapUsedBytes": 86859260,
"domNodes": 14,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 528.201,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2038.4849999999801,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 683.2500000000001,
"heapDeltaBytes": 4253676,
"heapUsedBytes": 64961220,
"domNodes": -284,
"jsHeapTotalBytes": 2457600,
"scriptDurationMs": 112.082,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2040.7570000000987,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.248999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 713.155,
"heapDeltaBytes": -1419412,
"heapUsedBytes": 59677564,
"domNodes": -284,
"jsHeapTotalBytes": 4030464,
"scriptDurationMs": 118.849,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.0589999999688,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.952999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.374,
"heapDeltaBytes": -10800256,
"heapUsedBytes": 54160944,
"domNodes": 16,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 128.11999999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 634.3699999999899,
"styleRecalcs": 47,
"styleRecalcDurationMs": 17.545,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.184,
"heapDeltaBytes": -10629636,
"heapUsedBytes": 54285008,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 127.745,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.8089999999997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.841,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.311,
"heapDeltaBytes": 5720396,
"heapUsedBytes": 70830732,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 14.491,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2005.743999999936,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.981,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.24,
"heapDeltaBytes": 5683800,
"heapUsedBytes": 70507524,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 19.819999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.0419999999872,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.053999999999995,
"layouts": 16,
"layoutDurationMs": 4.465,
"taskDurationMs": 774.972,
"heapDeltaBytes": -3403832,
"heapUsedBytes": 61342120,
"domNodes": 63,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 95.067,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.5819999999785,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.657,
"layouts": 16,
"layoutDurationMs": 4.6930000000000005,
"taskDurationMs": 805.14,
"heapDeltaBytes": -3176224,
"heapUsedBytes": 61589440,
"domNodes": 62,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 97.633,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.0639999999821,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.970999999999997,
"layouts": 14,
"layoutDurationMs": 12.616999999999999,
"taskDurationMs": 933.7790000000001,
"heapDeltaBytes": 6991916,
"heapUsedBytes": 100762120,
"domNodes": 13673,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 36.22,
"eventListeners": 2375,
"totalBlockingTimeMs": 136,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8406.44100000003,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.76499999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4563.086,
"heapDeltaBytes": 11412788,
"heapUsedBytes": 71306456,
"domNodes": -284,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 1405.8390000000002,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8310.05899999991,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.69,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4571.941,
"heapDeltaBytes": 12061856,
"heapUsedBytes": 72122812,
"domNodes": -284,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 1423.691,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17156.420999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17138.122000000003,
"heapDeltaBytes": -36522680,
"heapUsedBytes": 167473724,
"domNodes": -8312,
"jsHeapTotalBytes": -10948608,
"scriptDurationMs": 549.132,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17170.35700000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17143.763,
"heapDeltaBytes": -20214784,
"heapUsedBytes": 182914160,
"domNodes": -8312,
"jsHeapTotalBytes": -8593408,
"scriptDurationMs": 567.643,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20402.367000000027,
"styleRecalcs": 139,
"styleRecalcDurationMs": 16.946000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20379.305000000004,
"heapDeltaBytes": -41408496,
"heapUsedBytes": 164631328,
"domNodes": -8321,
"jsHeapTotalBytes": -11210752,
"scriptDurationMs": 876.74,
"eventListeners": -16385,
"totalBlockingTimeMs": 190,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20626.723999999966,
"styleRecalcs": 140,
"styleRecalcDurationMs": 17.210999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20601.982,
"heapDeltaBytes": -50547932,
"heapUsedBytes": 177217820,
"domNodes": -8312,
"jsHeapTotalBytes": -9973760,
"scriptDurationMs": 897.107,
"eventListeners": -16383,
"totalBlockingTimeMs": 257,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 452.2510000000466,
"styleRecalcs": 15,
"styleRecalcDurationMs": 22.896,
"layouts": 3,
"layoutDurationMs": 0.6840000000000002,
"taskDurationMs": 112.093,
"heapDeltaBytes": 5089692,
"heapUsedBytes": 68851556,
"domNodes": 128,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.722000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 467.832000000044,
"styleRecalcs": 17,
"styleRecalcDurationMs": 20.926000000000002,
"layouts": 3,
"layoutDurationMs": 1.3739999999999999,
"taskDurationMs": 112.304,
"heapDeltaBytes": 5170660,
"heapUsedBytes": 68932500,
"domNodes": 147,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.383,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe first-run flow now centralizes eligibility decisions into onboarding, deferral, and completion outcomes. Startup persists completion only for permanent disqualifiers. Tests cover transient ineligibility and later onboarding. ChangesFirst-run onboarding
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: ⚪ Minimal · up to The change prevents transient startup conditions from permanently suppressing onboarding, with no actionable merge-blocking risk remaining after normal checks and review. Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15173 +/- ##
=======================================
Coverage 82.00% 82.00%
=======================================
Files 1882 1882
Lines 118470 118476 +6
Branches 35111 35104 -7
=======================================
+ Hits 97154 97160 +6
+ Misses 20873 20864 -9
- Partials 443 452 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Sharpening one line in Review Focus, since it is the main thing worth objecting to and the body soft-pedals it. "a wrong `defer` reopens the template browser one extra time" understates it. A deferred user never gets the flag written, so It self-limits: once the user has a workflow to restore, startup reports I still think |
## The bug
`.github/workflows/ci-binary-size-validation.yaml` subscribes to the
`labeled` and `unlabeled`
pull_request event types:
```yaml
on:
pull_request:
types: [opened, synchronize, reopened, labeled, unlabeled]
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
```
So **any** label write starts a second binary-size run on the identical
commit, and
`cancel-in-progress` kills the one already in flight. A label change
cannot alter a bundle's
size, so there is nothing for the job to re-evaluate — the second run
just recomputes the same
answer and leaves a permanent `cancelled` check run behind on the
commit.
## Why it matters beyond wasted minutes
The cancelled check does not go away when the retry succeeds. Both check
runs stay attached to
the commit, so the commit's check rollup is `FAILURE` forever.
The PR risk grader reads that rollup. Its reversibility axis treats a
non-`SUCCESS` rollup as
`no_green_checks_tier`, which `.github/risk.json` sets to **R2** — so a
PR gets bumped to R2
because a label bot wrote a `size:*` label two seconds after CI started.
The chain, end to end:
1. `dosubot[bot]` writes a `size:*` label seconds after the PR opens or
is pushed to.
2. That `labeled` event re-triggers binary-size on the same commit;
`cancel-in-progress` cancels
the in-flight run.
3. The commit now permanently carries a `binary-size / CANCELLED` check
run.
4. The grader counts `CANCELLED` as a failing check, so the rollup is
not `SUCCESS`, so
reversibility is pinned at R2.
## Measured (re-verified for this PR, 2026-08-18)
| measure | value |
|---|---|
| binary-size runs, 30 days (created >= 2026-07-19) | 4,307 |
| ...concluded `cancelled` | **1,128 = 26.2%** |
| ...concluded `failure` | 39 = 0.9% |
| complete 2-day window (created >= 2026-08-16) | 819 runs |
| ...cancelled | 164 = 20.0% |
| cancels superseded by a later run on the **same head SHA** | **163 of
164 = 99.4%** |
| median gap to the superseding run | **2 s** (p25 0 s, p75 4 s) |
| distinct head SHAs in that window carrying **both** a `cancelled` and
a `success` run | 110 of 613 = **17.9%** |
Cancellations outrun real findings by roughly 29 to 1.
**Timed to the second on three live PRs** (label event → new run → prior
run cancelled):
- Comfy-Org#15413 — `size:XS` at 21:31:18Z → new run 21:31:20Z, prior run
(started 21:31:17Z) cancelled
- Comfy-Org#15414 — `size:L` at 21:35:47Z → new run 21:35:49Z, prior run
(21:35:45Z) cancelled
- Comfy-Org#15412 — `size:L` at 21:02:03Z → new run 21:02:06Z, prior run
(21:02:01Z) cancelled
**A settled rollup showing the consequence.** Commit `ce9ec9b4d0`
(Comfy-Org#15414, a `browser_tests/`-only
PR) — rollup state `FAILURE` over 85 contexts: 57 `SUCCESS`, 26
`SKIPPED`, and exactly one
failing-class context, `binary-size / CANCELLED`. That PR carries
`risk:R2`.
**Across the whole label population:** of the 112 PRs currently carrying
`risk:R2`, **17 (15.2%)
have a check rollup whose only failing-class context is `binary-size /
CANCELLED`** — Comfy-Org#14546,
Comfy-Org#15138, Comfy-Org#15173, Comfy-Org#15178, Comfy-Org#15261, Comfy-Org#15280, Comfy-Org#15307, Comfy-Org#15354, Comfy-Org#15371, Comfy-Org#15376,
Comfy-Org#15380, Comfy-Org#15388, Comfy-Org#15402,
Comfy-Org#15404, Comfy-Org#15410, Comfy-Org#15411, Comfy-Org#15414.
## Why removing the trigger is the right fix, and not the concurrency
group
Keying the concurrency group on `github.event.pull_request.head.sha`
does **not** help: a label
write happens on the identical commit, so it lands in the same group and
still cancels. The
re-trigger itself is what has to go.
`binary-size` is **not** a required check for merge — the `ProtectMain`
ruleset requires `test`,
`lint-and-format`, `e2e-status` and `website-e2e`, and `CLA Check`
requires `cla-assistant`.
## Trade-off, stated plainly
The `allow-large-binaries` bypass is read from
`github.event.pull_request.labels.*.name` at the
job `if:`. With `labeled` removed, applying that label no longer
re-evaluates the check
instantly — it takes effect on the next `synchronize`/`reopened`. That
costs nothing today:
**`allow-large-binaries` has been applied to 0 PRs, ever**, and the
check does not gate merge, so
a stale red never blocks anyone.
`scripts/cicd/check-binary-size.sh:165` prints "add the
'allow-large-binaries' label to the PR"
on failure; that advice still works, it just lands on the next push
rather than instantly. I have
deliberately not touched that file — happy to reword it in a follow-up
if a reviewer wants it.
## This PR demonstrates the fix on itself
`pull_request` workflow definitions are read from the PR head, so the
change is already live
here. Timeline:
- 22:50:13Z — PR opened
- 22:50:17Z — binary-size run `32194526247` starts
- 22:50:19Z — `dosubot[bot]` applies `size:XS`, **two seconds into the
run** — the exact pattern
that cancels the run on every other PR
Result: **one** binary-size run on this commit, no second trigger, no
cancellation,
`binary-size pass 35s`. Compare Comfy-Org#15413 / Comfy-Org#15414 / Comfy-Org#15412 above, where
the same two-second label
write killed the in-flight run and left a permanent `CANCELLED` on the
commit.
## Scope
This is half the loop. The other half is grader-side: `CANCELLED` is
counted as a *failing*
check in `Comfy-Org/github-workflows`
(`scripts/pr-risk/grade-pr-risk.sh`), which is what turns a
cancelled run into an R2. That fix has **not shipped** and is not in
this PR. So this PR removes
the largest source of the cancellations but does not fully close the
loop — a binary-size run
cancelled for any other reason would still red the rollup.
No other change to the file.
…21930) ## ELI5 The first-run Getting Started tour was gated on a server flag, `onboarding_tour_enabled`, that is already on for everyone. This PR deletes the frontend's check of that flag, so the tour is always eligible for new cloud users on desktop-width screens with an active subscription setup. **A human must review and sign off on this PR before it is merged.** It was opened unattended by the Feature Flag Hygiene routine under Luke's account. Nothing is merged, and nothing in PostHog or prod was changed. @deepme987 owns FE-3278 and this PR is theirs to accept, change or close. This run could not confirm the flag's 30-day history or check the tour end to end in a browser. ## Diagram ```mermaid flowchart TD A[decideFirstRun] --> B{isCloud?} B -- no --> C[complete] B -- yes --> D{isNewUser false?} D -- yes --> C D -- no --> F{desktop width?} F -- no --> G[defer] F -- yes --> H{subscription enabled?} H -- no --> G H -- yes --> I{isNewUser null?} I -- yes --> G I -- no --> J[getting-started] ``` The removed step is the `onboardingTourEnabled` check that sat between the new-user check and the desktop-width check and returned `defer`. ## Summary Hard-codes `onboarding_tour_enabled` ON in the frontend. - `firstRunEntry.ts`: remove the `if (!flags.onboardingTourEnabled) return 'defer'` branch and the unused import. - `useFeatureFlags.ts`, `serverFeatureFlag.ts`, `remoteConfig/types.ts`, `__mocks__/useFeatureFlags.ts`: remove the accessor, enum member, remote-config type and mock entry. - Tests: drop the flag toggles and the "defaults to false" / "turns on from remote config" cases. Remove the key from the browser-test feature mocks. - Kept on purpose: the `!isCloud` guard in `decideFirstRun`, which is what hides the tour on OSS and Desktop. A missing flag key on those builds no longer matters because that guard returns `complete` first. String-literal uses of the key as sample data in `sessionFeatureFlagOverride.test.ts`, `webSessionFlagOn.test.ts` and `tools/test-recorder` are unchanged. - Backend is untouched. Cloud still emits the key. Removing it is the `[BE]` subtask (FE-3542) and must wait until this change is in the prod `frontendVersion`. Fixes FE-3278 (frontend part). Linear: https://linear.app/comfyorg/issue/FE-3278 Behavior note: the dropped `defer` also covered the window before `/api/features` resolves. The `isSubscriptionEnabled()` check still defers in that window because it reads `window.__CONFIG__` from the same fetch (see Comfy-Org#15173). ## Verification - `pnpm typecheck`: clean. - `pnpm exec vitest run` on `src/renderer/extensions/firstRunTour`, `useFeatureFlags.test.ts`, `sessionFeatureFlagOverride.test.ts`, `webSessionFlagOn.test.ts`: 14 files, 688 tests pass. - `oxlint`, `eslint`, `oxfmt --check` on the 10 changed files: 0 errors. The only warnings are eslint's "file ignored" notices. - `pnpm knip`: no findings. - Not run: the aggregate `pnpm lint` (this pnpm treats the regex script filter as unknown), the Playwright browser tests (no backend here), and `pnpm test:unit` in full. `pnpm locale:check` reports translations pending that this PR does not touch. - Committed with `--no-verify`: the husky pre-commit hook rejected the sandbox's Node 22 (repo wants >=26.8.2). I ran the checks above by hand instead. ### Change breakdown | Category | Files | Added | Deleted | Share of changed lines | |---|---|---|---|---| | Product code | 5 (`src/composables/useFeatureFlags.ts`, `src/composables/__mocks__/useFeatureFlags.ts`, `src/platform/remoteConfig/serverFeatureFlag.ts`, `src/platform/remoteConfig/types.ts`, `src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.ts`) | 0 | 12 | 19% | | Test code | 5 (`src/composables/useFeatureFlags.test.ts`, `src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.test.ts`, `browser_tests/tests/gettingStartedTour.spec.ts`, `browser_tests/tests/agent/agentConsent.spec.ts`, `browser_tests/tests/onboarding/firstRunNudgeAgentPanel.spec.ts`) | 3 | 50 | 81% | Total changed lines: 65. Documentation, config, generated, lockfile and vendored files: none. ## Provenance - Authored by: Feature Flag Hygiene routine, 2026-10-25 (PT) - Flow: coder (human-signoff draft on another owner's ticket) - Verified: the commands listed above, on head 5b00b9c - Deviations: opened as a draft because the ticket is assigned to someone else (§5a); the PostHog 100% history was taken from the Oct 19 Linear comment and the dynconfig state, not re-read from PostHog; the branch is the session-assigned `claude/intelligent-euler-73w7on` rather than the `luke-mino-altherr/...` pattern; no Claude attribution trailer, per the routine's rules. --- _Generated by [Claude Code](https://claude.ai/code/session_01Q6uR6jVvWidUaUFkm9GJZg)_ Co-authored-by: Claude <noreply@anthropic.com>
Summary
handleStartupOutcometreated "not a tour candidate on this boot" as "already onboarded", permanently writingComfy.TutorialCompletedfor users who were only transiently ineligible.Changes
isFirstRunCandidate()returns false for five reasons, only one of which is stable.handleStartupOutcomemarked the tutorial completed for all five.Comfy.TutorialCompletedis persisted server-side against the user record and is only ever set totrue, so a single ineligible boot removed onboarding from that account forever. Replaced the boolean with a three-way decision:complete(mark + template browser),defer(template browser only, flag untouched),getting-started.isFirstRunCandidate()is now derived from it, sohandleUrlWorkflowis unchanged.Classification:
!isCloud__DISTRIBUTION__; cannot change for this deploymentisNewUser() === false!onboardingTourEnabled/featuresresolves, and flips during rollout!isDesktopWidth!isSubscriptionEnabled()window.__CONFIG__, written by the same/featuresfetchisNewUser() === nullTwo reachable cases this fixes. Signing up on a phone and returning on a laptop is ordinary behaviour, and today it costs the user onboarding permanently — raised by @MaanilVerma on #15091. The broader variant, found while verifying that one: every boot taken while
onboarding_tour_enabledis off marks every new user completed, so the entire cohort onboarded before the rollout can never see the tour once it is turned on.Review Focus
isSubscriptionEnabled()isisCloud && window.__CONFIG__?.subscription_required— deployment config, not per-user subscription state, so "permanent" is arguable. It is classified transient becausewindow.__CONFIG__is populated by the async/featuresfetch inrefreshRemoteConfig, which sets it to{}on timeout (5s), on 401/403, and on any network error. A wedged features endpoint would otherwise burn the tour for every user who booted during the outage. The cost of being wrong is asymmetric: a wrongdeferreopens the template browser one extra time, a wrongcompleteis unrecoverable.The
url-intentbranch still marks completed, unchanged. That user got a real first-run experience — their workflow loaded, andhandleUrlWorkflowoffers the tour over it — so it is a genuine completion, not an environmental miss.Candidacy is still read once per startup:
decideFirstRun()is called a single time inhandleStartupOutcome, so a later resize, flag refresh, or subscription change cannot unmount the Getting Started screen mid-interaction. Covered by the existing test.Non-candidates still get
Comfy.BrowseTemplateson both paths.Tests
Existing disqualifier table split into permanent and transient. Four new transient cases assert the flag is not written, plus an end-to-end case that runs two boots through a
setSettingmock that actually persists: narrow viewport, then desktop. All five fail onmain(expected "vi.fn()" to not be called at all, but actually been called 1 times, andexpected false to be truefor the two-boot case).