Skip to content

fix: stop transient ineligibility from permanently completing the first-run tour - #15173

Merged
christian-byrne merged 1 commit into
mainfrom
fix/first-run-tour-transient-ineligibility
Aug 13, 2026
Merged

christian-byrne merged 1 commit into
mainfrom
fix/first-run-tour-transient-ineligibility

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

handleStartupOutcome treated "not a tour candidate on this boot" as "already onboarded", permanently writing Comfy.TutorialCompleted for users who were only transiently ineligible.

Changes

  • What: isFirstRunCandidate() returns false for five reasons, only one of which is stable. handleStartupOutcome marked the tutorial completed for all five. Comfy.TutorialCompleted is persisted server-side against the user record and is only ever set to true, so a single ineligible boot removed onboarding from that account forever. Replaced the boolean with a three-way decision: complete (mark + template browser), defer (template browser only, flag untouched), getting-started. isFirstRunCandidate() is now derived from it, so handleUrlWorkflow is unchanged.

Classification:

condition decision why
!isCloud complete build-time __DISTRIBUTION__; cannot change for this deployment
isNewUser() === false complete a determined returning user does not become new again
!onboardingTourEnabled defer server flag, defaults false before /features resolves, and flips during rollout
!isDesktopWidth defer viewport
!isSubscriptionEnabled() defer reads window.__CONFIG__, written by the same /features fetch
isNewUser() === null defer undetermined is not a determination

Two reachable cases this fixes. Signing up on a phone and returning on a laptop is ordinary behaviour, and today it costs the user onboarding permanently — raised by @MaanilVerma on #15091. The broader variant, found while verifying that one: every boot taken while onboarding_tour_enabled is off marks every new user completed, so the entire cohort onboarded before the rollout can never see the tour once it is turned on.

Review Focus

isSubscriptionEnabled() is isCloud && window.__CONFIG__?.subscription_required — deployment config, not per-user subscription state, so "permanent" is arguable. It is classified transient because window.__CONFIG__ is populated by the async /features fetch in refreshRemoteConfig, which sets it to {} on timeout (5s), on 401/403, and on any network error. A wedged features endpoint would otherwise burn the tour for every user who booted during the outage. The cost of being wrong is asymmetric: a wrong defer reopens the template browser one extra time, a wrong complete is unrecoverable.

The url-intent branch still marks completed, unchanged. That user got a real first-run experience — their workflow loaded, and handleUrlWorkflow offers the tour over it — so it is a genuine completion, not an environmental miss.

Candidacy is still read once per startup: decideFirstRun() is called a single time in handleStartupOutcome, so a later resize, flag refresh, or subscription change cannot unmount the Getting Started screen mid-interaction. Covered by the existing test.

Non-candidates still get Comfy.BrowseTemplates on both paths.

Tests

Existing disqualifier table split into permanent and transient. Four new transient cases assert the flag is not written, plus an end-to-end case that runs two boots through a setSetting mock that actually persists: narrow viewport, then desktop. All five fail on main (expected "vi.fn()" to not be called at all, but actually been called 1 times, and expected false to be true for the two-boot case).

handleStartupOutcome marked Comfy.TutorialCompleted for every user who was
not a first-run candidate, but isFirstRunCandidate() also returns false for
conditions that change between boots: viewport width, the onboarding_tour
feature flag, and subscription config from /features. The setting is
persisted server-side against the user record and is never unset, so one
such boot permanently removed onboarding from the account.

Split the decision into complete (not cloud, or a determined returning
user) and defer (anything a later boot can lift). Both open the template
browser; only complete writes the setting.
@christian-byrne
christian-byrne requested a review from a team August 13, 2026 02:40
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/13/2026, 02:42:10 AM UTC

Links

🎭 Playwright: ✅ 1801 passed, 0 failed · 5 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1780 / ❌ 0 / ⚠️ 5 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle: 8.84 MB gzip 🔴 +17 B

Details

Summary

  • Raw size: 37.3 MB baseline 37.3 MB — 🔴 +93 B
  • Gzip: 8.84 MB baseline 8.84 MB — 🔴 +17 B
  • Brotli: 6.18 MB baseline 6.18 MB — 🔴 +64 B
  • Bundles: 439 current • 439 baseline • 3 added / 3 removed

Category Glance
Graph Workspace 🔴 +93 B (1.37 MB) · Vendor & Third-Party ⚪ 0 B (16.8 MB) · Other ⚪ 0 B (14.2 MB) · Data & Services ⚪ 0 B (3.51 MB) · Panels & Settings ⚪ 0 B (565 kB) · Utilities & Hooks ⚪ 0 B (550 kB) · + 5 more

App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-5b1U8j1w.js (new) — 3.71 kB 🔴 +3.71 kB 🔴 +1.85 kB 🔴 +1.58 kB
assets/index-UlTs_EYK.js (removed) 3.71 kB — 🟢 -3.71 kB 🟢 -1.85 kB 🟢 -1.57 kB

Status: 1 added / 1 removed

Graph Workspace — 1.37 MB (baseline 1.37 MB) • 🔴 +93 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-DYeRV_zx.js (new) — 1.36 MB 🔴 +1.36 MB 🔴 +295 kB 🔴 +222 kB
assets/GraphView-BOUT_1pB.js (removed) 1.36 MB — 🟢 -1.36 MB 🟢 -295 kB 🟢 -222 kB

Status: 1 added / 1 removed / 2 unchanged

Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 17 unchanged

Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 26 unchanged

User & Accounts — 27.2 kB (baseline 27.2 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 11 unchanged

Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 8 unchanged

UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 B

Reusable component library chunks

Status: 14 unchanged

Data & Services — 3.51 MB (baseline 3.51 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 38 unchanged

Vendor & Third-Party — 16.8 MB (baseline 16.8 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 14.2 MB (baseline 14.2 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/main-6lyD0smr.js (removed) 45.3 kB — 🟢 -45.3 kB 🟢 -13.2 kB 🟢 -11.4 kB
assets/main-Ddruxh7K.js (new) — 45.3 kB 🔴 +45.3 kB 🔴 +13.2 kB 🔴 +11.4 kB

Status: 1 added / 1 removed / 285 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 136ms TBT · 96.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.4 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.1 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 224ms TBT · 163.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.7 MB heap

⚠️ 7 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 376ms 493ms +31% ⚠️ z=3.2
canvas-zoom-sweep: task duration 295ms 422ms +43% ⚠️ z=4.1
large-graph-idle: task duration 530ms 714ms +35% ⚠️ z=3.2
large-graph-pan: task duration 891ms 1312ms +47% ⚠️ z=5.3
minimap-idle: task duration 537ms 698ms +30% ⚠️ z=3.6
subgraph-dom-widget-clipping: task duration 295ms 426ms +44% ⚠️ z=2.6
subgraph-idle: task duration 369ms 491ms +33% ⚠️ z=3.9
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.1
canvas-idle: p95 frame time 17ms 17ms +0% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 6ms 8ms +42% z=-2.8
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 10 9 -10% z=-3.8
canvas-idle: task duration 376ms 493ms +31% ⚠️ z=3.2
canvas-idle: script duration 13ms 18ms +38% z=-3.3
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 67.4 MB 67.5 MB +0% —
canvas-idle: DOM nodes 20 18 -10% z=-3.6
canvas-idle: event listeners 6 5 -17% z=-1.4
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=0.2
canvas-mouse-sweep: p95 frame time 17ms 17ms -0% —
canvas-mouse-sweep: layout duration 2ms 4ms +51% z=-0.0
canvas-mouse-sweep: style recalc duration 23ms 42ms +80% z=-0.3
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 72 77 +7% z=-0.7
canvas-mouse-sweep: task duration 629ms 911ms +45% z=0.8
canvas-mouse-sweep: script duration 79ms 128ms +62% z=-1.2
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 61.6 MB 55.4 MB -10% —
canvas-mouse-sweep: DOM nodes 57 -112 -296% z=-67.4
canvas-mouse-sweep: event listeners 4 -74 -1938% z=-19.7
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=-0.3
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% —
canvas-zoom-sweep: layout duration 1ms 1ms +38% z=1.1
canvas-zoom-sweep: style recalc duration 12ms 19ms +65% z=0.1
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 30 32 +5% z=0.5
canvas-zoom-sweep: task duration 295ms 422ms +43% ⚠️ z=4.1
canvas-zoom-sweep: script duration 14ms 24ms +69% z=-1.1
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 69.9 MB 70.5 MB +1% —
canvas-zoom-sweep: DOM nodes 78 79 +1% z=-0.9
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.2
dom-widget-clipping: p95 frame time 17ms 17ms -1% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 5ms 8ms +49% z=-2.3
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 13 11 -15% z=-4.2
dom-widget-clipping: task duration 266ms 397ms +49% z=2.0
dom-widget-clipping: script duration 36ms 66ms +84% z=-0.5
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 50.7 MB 51.2 MB +1% —
dom-widget-clipping: DOM nodes 22 18 -18% z=-2.9
dom-widget-clipping: event listeners 2 1 -50% variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=-0.2
large-graph-idle: p95 frame time 17ms 17ms -0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 6ms 7ms +26% z=-4.8
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 11 8 -32% z=-13.1
large-graph-idle: task duration 530ms 714ms +35% ⚠️ z=3.2
large-graph-idle: script duration 63ms 117ms +87% z=1.4
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 65.9 MB 64.7 MB -2% —
large-graph-idle: DOM nodes -280 -283 +1% z=-340.4
large-graph-idle: event listeners -147 -149 +1% z=-28.7
large-graph-pan: avg frame time 17ms 17ms -0% z=-0.2
large-graph-pan: p95 frame time 17ms 17ms +0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 9ms 15ms +64% z=-3.2
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 68 69 +1% z=-0.9
large-graph-pan: task duration 891ms 1312ms +47% ⚠️ z=5.3
large-graph-pan: script duration 272ms 435ms +60% z=1.3
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 61.6 MB 56.2 MB -9% —
large-graph-pan: DOM nodes -282 -285 +1% z=-184.3
large-graph-pan: event listeners -149 -149 +0% z=-185.9
large-graph-zoom: avg frame time 17ms 17ms -0% —
large-graph-zoom: p95 frame time 17ms 17ms -1% —
large-graph-zoom: layout duration 5ms 7ms +33% —
large-graph-zoom: style recalc duration 11ms 15ms +35% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 66 65 -2% —
large-graph-zoom: task duration 1101ms 1513ms +37% —
large-graph-zoom: script duration 356ms 535ms +50% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 51.8 MB 70.1 MB +35% —
large-graph-zoom: DOM nodes -284 -138 -52% —
large-graph-zoom: event listeners -153 -73 -53% —
minimap-idle: avg frame time 17ms 17ms -0% z=-0.9
minimap-idle: p95 frame time 17ms 17ms -0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 5ms 7ms +35% z=-3.0
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 9 8 -11% z=-2.3
minimap-idle: task duration 537ms 698ms +30% ⚠️ z=3.6
minimap-idle: script duration 64ms 115ms +80% z=1.7
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 59.7 MB 59.4 MB -0% —
minimap-idle: DOM nodes -282 -284 +1% z=-221.6
minimap-idle: event listeners -179 -180 +1% z=-279.5
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.4
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 8ms 14ms +81% z=1.1
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 48 46 -4% z=-3.3
subgraph-dom-widget-clipping: task duration 295ms 426ms +44% ⚠️ z=2.6
subgraph-dom-widget-clipping: script duration 85ms 128ms +51% z=-0.0
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 51.3 MB 51.7 MB +1% —
subgraph-dom-widget-clipping: DOM nodes 22 18 -18% z=-3.7
subgraph-dom-widget-clipping: event listeners 8 8 +0% z=-1.4
subgraph-idle: avg frame time 17ms 17ms -0% z=-0.2
subgraph-idle: p95 frame time 17ms 17ms +0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 6ms 8ms +31% z=-3.2
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 11 9 -18% z=-2.9
subgraph-idle: task duration 369ms 491ms +33% ⚠️ z=3.9
subgraph-idle: script duration 11ms 17ms +52% z=-1.2
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 67.5 MB 67.4 MB -0% —
subgraph-idle: DOM nodes 22 18 -18% z=-2.5
subgraph-idle: event listeners 6 4 -33% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms -0% z=-0.1
subgraph-mouse-sweep: p95 frame time 17ms 17ms -1% —
subgraph-mouse-sweep: layout duration 3ms 5ms +43% z=-0.4
subgraph-mouse-sweep: style recalc duration 25ms 38ms +51% z=-1.2
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 75 77 +2% z=-1.9
subgraph-mouse-sweep: task duration 557ms 790ms +42% z=0.3
subgraph-mouse-sweep: script duration 58ms 96ms +67% z=-0.7
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 58.6 MB 58.6 MB +0% —
subgraph-mouse-sweep: DOM nodes 61 63 +2% z=-2.0
subgraph-mouse-sweep: event listeners 4 4 +0% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms -0% —
subgraph-transition-enter: p95 frame time 17ms 17ms +1% —
subgraph-transition-enter: layout duration 8ms 13ms +50% —
subgraph-transition-enter: style recalc duration 22ms 30ms +34% —
subgraph-transition-enter: layout count 16 14 -13% —
subgraph-transition-enter: style recalc count 20 18 -10% —
subgraph-transition-enter: task duration 680ms 934ms +37% —
subgraph-transition-enter: script duration 19ms 36ms +94% —
subgraph-transition-enter: TBT 96ms 136ms +42% —
subgraph-transition-enter: heap used 94.8 MB 96.1 MB +1% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2373 2375 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 23ms 37ms +62% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 249 249 +0% —
viewport-pan-sweep: task duration 3112ms 4568ms +47% —
viewport-pan-sweep: script duration 868ms 1415ms +63% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 83.8 MB 68.4 MB -18% —
viewport-pan-sweep: DOM nodes -280 -284 +1% —
viewport-pan-sweep: event listeners -161 -131 -19% —
vue-large-graph-idle: avg frame time 17ms 18ms +5% —
vue-large-graph-idle: p95 frame time 17ms 17ms +0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 10673ms 17141ms +61% —
vue-large-graph-idle: script duration 380ms 558ms +47% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 159.6 MB 167.1 MB +5% —
vue-large-graph-idle: DOM nodes -8312 -8312 +0% —
vue-large-graph-idle: event listeners -16389 -16388 -0% —
vue-large-graph-pan: avg frame time 17ms 18ms +5% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 12ms 17ms +43% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 68 140 +105% —
vue-large-graph-pan: task duration 13360ms 20491ms +53% —
vue-large-graph-pan: script duration 684ms 887ms +30% —
vue-large-graph-pan: TBT 27ms 224ms +728% —
vue-large-graph-pan: heap used 159.6 MB 163.0 MB +2% —
vue-large-graph-pan: DOM nodes -8312 -8317 +0% —
vue-large-graph-pan: event listeners -16387 -16384 -0% —
workflow-execution: avg frame time 17ms 17ms -0% z=0.1
workflow-execution: p95 frame time 17ms 17ms -0% —
workflow-execution: layout duration 0ms 1ms +169% z=-3.6
workflow-execution: style recalc duration 14ms 22ms +59% z=-1.1
workflow-execution: layout count 2 3 +50% z=-3.6
workflow-execution: style recalc count 15 16 +7% z=-0.9
workflow-execution: task duration 87ms 112ms +29% z=-1.0
workflow-execution: script duration 7ms 11ms +54% z=-6.3
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 65.7 MB 65.7 MB -0% —
workflow-execution: DOM nodes 128 138 +7% z=-3.3
workflow-execution: event listeners 99 98 -1% z=10.6
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-08-13T02:52:31.043Z",
  "gitSha": "338bed3947bc879242dc2f84a670579fe892d14d",
  "branch": "fix/first-run-tour-transient-ineligibility",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2002.5469999999927,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.017999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 529.556,
      "heapDeltaBytes": 6011752,
      "heapUsedBytes": 71019040,
      "domNodes": 18,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 18.936,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2014.8249999999734,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.58,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.382,
      "heapDeltaBytes": 5822536,
      "heapUsedBytes": 70607512,
      "domNodes": 18,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 16.758000000000003,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1920.4780000000028,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 43.242,
      "layouts": 12,
      "layoutDurationMs": 3.5410000000000004,
      "taskDurationMs": 936.0540000000001,
      "heapDeltaBytes": -14004192,
      "heapUsedBytes": 50892160,
      "domNodes": -283,
      "jsHeapTotalBytes": 23826432,
      "scriptDurationMs": 125.856,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1857.8180000000657,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 40.228,
      "layouts": 12,
      "layoutDurationMs": 3.6619999999999995,
      "taskDurationMs": 886.71,
      "heapDeltaBytes": 562644,
      "heapUsedBytes": 65279892,
      "domNodes": 59,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 129.767,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.7619999999752,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.403,
      "layouts": 6,
      "layoutDurationMs": 0.598,
      "taskDurationMs": 390.25200000000007,
      "heapDeltaBytes": 9134552,
      "heapUsedBytes": 73926900,
      "domNodes": 79,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 20.617000000000004,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1754.3789999999717,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 20.228,
      "layouts": 6,
      "layoutDurationMs": 0.7829999999999998,
      "taskDurationMs": 453.59900000000005,
      "heapDeltaBytes": 9228112,
      "heapUsedBytes": 74000564,
      "domNodes": 78,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 26.738999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 649.4280000000003,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.441999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.03000000000003,
      "heapDeltaBytes": -10867192,
      "heapUsedBytes": 53862336,
      "domNodes": 18,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 74.214,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 575.085999999942,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.7219999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 368.198,
      "heapDeltaBytes": -11370208,
      "heapUsedBytes": 53472672,
      "domNodes": 18,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 58.24700000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.3040000000015,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.088999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 733.95,
      "heapDeltaBytes": 7711016,
      "heapUsedBytes": 67658216,
      "domNodes": -284,
      "jsHeapTotalBytes": 3768320,
      "scriptDurationMs": 120.25400000000002,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.9990000000562,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.371000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 693.67,
      "heapDeltaBytes": 7106968,
      "heapUsedBytes": 68071380,
      "domNodes": -282,
      "jsHeapTotalBytes": 4292608,
      "scriptDurationMs": 114.202,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2205.35000000001,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.333999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1314.744,
      "heapDeltaBytes": 1610300,
      "heapUsedBytes": 62555880,
      "domNodes": -286,
      "jsHeapTotalBytes": 3960832,
      "scriptDurationMs": 434.90000000000003,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2181.141000000025,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 15.128000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1309.7430000000002,
      "heapDeltaBytes": -5777252,
      "heapUsedBytes": 55224060,
      "domNodes": -284,
      "jsHeapTotalBytes": 2981888,
      "scriptDurationMs": 434.71999999999997,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3195.7120000000145,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.477,
      "layouts": 60,
      "layoutDurationMs": 7.28,
      "taskDurationMs": 1544.1180000000002,
      "heapDeltaBytes": -2394320,
      "heapUsedBytes": 60071324,
      "domNodes": -289,
      "jsHeapTotalBytes": 5865472,
      "scriptDurationMs": 541.705,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3212.7949999999146,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 15.535999999999998,
      "layouts": 60,
      "layoutDurationMs": 7.326,
      "taskDurationMs": 1482.8700000000001,
      "heapDeltaBytes": 24518632,
      "heapUsedBytes": 86859260,
      "domNodes": 14,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 528.201,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2038.4849999999801,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.025,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 683.2500000000001,
      "heapDeltaBytes": 4253676,
      "heapUsedBytes": 64961220,
      "domNodes": -284,
      "jsHeapTotalBytes": 2457600,
      "scriptDurationMs": 112.082,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2040.7570000000987,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.248999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 713.155,
      "heapDeltaBytes": -1419412,
      "heapUsedBytes": 59677564,
      "domNodes": -284,
      "jsHeapTotalBytes": 4030464,
      "scriptDurationMs": 118.849,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 608.0589999999688,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.952999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 423.374,
      "heapDeltaBytes": -10800256,
      "heapUsedBytes": 54160944,
      "domNodes": 16,
      "jsHeapTotalBytes": 26214400,
      "scriptDurationMs": 128.11999999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 634.3699999999899,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 17.545,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 428.184,
      "heapDeltaBytes": -10629636,
      "heapUsedBytes": 54285008,
      "domNodes": 20,
      "jsHeapTotalBytes": 25690112,
      "scriptDurationMs": 127.745,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.8089999999997,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.841,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 462.311,
      "heapDeltaBytes": 5720396,
      "heapUsedBytes": 70830732,
      "domNodes": 18,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 14.491,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.743999999936,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.981,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 520.24,
      "heapDeltaBytes": 5683800,
      "heapUsedBytes": 70507524,
      "domNodes": 18,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 19.819999999999997,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1710.0419999999872,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 39.053999999999995,
      "layouts": 16,
      "layoutDurationMs": 4.465,
      "taskDurationMs": 774.972,
      "heapDeltaBytes": -3403832,
      "heapUsedBytes": 61342120,
      "domNodes": 63,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 95.067,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.5819999999785,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 37.657,
      "layouts": 16,
      "layoutDurationMs": 4.6930000000000005,
      "taskDurationMs": 805.14,
      "heapDeltaBytes": -3176224,
      "heapUsedBytes": 61589440,
      "domNodes": 62,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 97.633,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.0639999999821,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 29.970999999999997,
      "layouts": 14,
      "layoutDurationMs": 12.616999999999999,
      "taskDurationMs": 933.7790000000001,
      "heapDeltaBytes": 6991916,
      "heapUsedBytes": 100762120,
      "domNodes": 13673,
      "jsHeapTotalBytes": 13631488,
      "scriptDurationMs": 36.22,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 136,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8406.44100000003,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.76499999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4563.086,
      "heapDeltaBytes": 11412788,
      "heapUsedBytes": 71306456,
      "domNodes": -284,
      "jsHeapTotalBytes": 5271552,
      "scriptDurationMs": 1405.8390000000002,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8310.05899999991,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.69,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4571.941,
      "heapDeltaBytes": 12061856,
      "heapUsedBytes": 72122812,
      "domNodes": -284,
      "jsHeapTotalBytes": 5271552,
      "scriptDurationMs": 1423.691,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17156.420999999966,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17138.122000000003,
      "heapDeltaBytes": -36522680,
      "heapUsedBytes": 167473724,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10948608,
      "scriptDurationMs": 549.132,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17170.35700000008,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17143.763,
      "heapDeltaBytes": -20214784,
      "heapUsedBytes": 182914160,
      "domNodes": -8312,
      "jsHeapTotalBytes": -8593408,
      "scriptDurationMs": 567.643,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20402.367000000027,
      "styleRecalcs": 139,
      "styleRecalcDurationMs": 16.946000000000016,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20379.305000000004,
      "heapDeltaBytes": -41408496,
      "heapUsedBytes": 164631328,
      "domNodes": -8321,
      "jsHeapTotalBytes": -11210752,
      "scriptDurationMs": 876.74,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 190,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20626.723999999966,
      "styleRecalcs": 140,
      "styleRecalcDurationMs": 17.210999999999977,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20601.982,
      "heapDeltaBytes": -50547932,
      "heapUsedBytes": 177217820,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9973760,
      "scriptDurationMs": 897.107,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 257,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 452.2510000000466,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 22.896,
      "layouts": 3,
      "layoutDurationMs": 0.6840000000000002,
      "taskDurationMs": 112.093,
      "heapDeltaBytes": 5089692,
      "heapUsedBytes": 68851556,
      "domNodes": 128,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 10.722000000000001,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 467.832000000044,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 20.926000000000002,
      "layouts": 3,
      "layoutDurationMs": 1.3739999999999999,
      "taskDurationMs": 112.304,
      "heapDeltaBytes": 5170660,
      "heapUsedBytes": 68932500,
      "domNodes": 147,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.383,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 13, 2026
@coderabbitai

coderabbitai Bot commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 088bbad4-24ba-4350-89a3-c756a21b3d86

📥 Commits

Reviewing files that changed from the base of the PR and between 891ee51 and c688185.

📒 Files selected for processing (2)
  • src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.test.ts
  • src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.ts

📝 Walkthrough

Walkthrough

The first-run flow now centralizes eligibility decisions into onboarding, deferral, and completion outcomes. Startup persists completion only for permanent disqualifiers. Tests cover transient ineligibility and later onboarding.

Changes

First-run onboarding

Layer / File(s) Summary
Centralized first-run decisions
src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.ts
decideFirstRun() now returns explicit outcomes for eligible, deferred, and completed states. Startup persists completion only for the complete outcome.
Decision persistence tests
src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.test.ts
Tests now persist mocked settings and cover permanent disqualifiers, transient deferral, later onboarding, and template-browser resolution.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Mergeability Score: ⚪ Minimal · up to c6881

The change prevents transient startup conditions from permanently suppressing onboarding, with no actionable merge-blocking risk remaining after normal checks and review.

Suggested labels: core/1.49

Suggested reviewers: maanilverma


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive Commit subjects and the PR title are not available, so the required bug-fix signal cannot be verified from the permitted metadata. Provide the PR title and commit subjects, then verify whether the description gives a concrete reason for omitting a browser_tests/ Playwright regression test.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary fix: preventing transient ineligibility from permanently completing the first-run tour.
Description check ✅ Passed The description includes the required summary, changes, review focus, issue context, and tests, with clear detail about behavior and edge cases.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed files are first-run tour files, not under src/lib/litegraph/, src/ecs/, or graph-entity-related paths; this check does not apply.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/first-run-tour-transient-ineligibility

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main   #15173   +/-   ##
=======================================
  Coverage   82.00%   82.00%           
=======================================
  Files        1882     1882           
  Lines      118470   118476    +6     
  Branches    35111    35104    -7     
=======================================
+ Hits        97154    97160    +6     
+ Misses      20873    20864    -9     
- Partials      443      452    +9     
Flag Coverage Δ
unit 72.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sions/firstRunTour/gettingStarted/firstRunEntry.ts 97.67% <100.00%> (+0.37%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Sharpening one line in Review Focus, since it is the main thing worth objecting to and the body soft-pedals it.

"a wrong `defer` reopens the template browser one extra time" understates it. A deferred user never gets the flag written, so handleStartupOutcome runs the full path on every boot that returns fresh. For someone persistently ineligible rather than transiently — a mobile-only user, say — that is the template browser on every launch where there is nothing to restore, not once more. That is exactly the behaviour the old code was buying with the unconditional markTutorialCompleted(), and the assertion message on the existing test said so: "Without this the browser reopens on every launch, forever."

It self-limits: once the user has a workflow to restore, startup reports restored and returns before any of this. So the exposure is a new user who is persistently ineligible AND never leaves a workflow behind.

I still think defer is the right call, for the asymmetry already in the body: reopening the template browser is recoverable and a burned Comfy.TutorialCompleted is not. But reviewers should weigh the real cost, not the understated one. If the repeat opening is judged too annoying, the fix is a separate local-only "template browser already shown" marker, not reinstating the server-side write.

@christian-byrne
christian-byrne added this pull request to the merge queue Aug 13, 2026
Merged via the queue into main with commit 0f001a6 Aug 13, 2026
78 of 79 checks passed
@christian-byrne
christian-byrne deleted the fix/first-run-tour-transient-ineligibility branch August 13, 2026 20:44
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Aug 23, 2026
## The bug

`.github/workflows/ci-binary-size-validation.yaml` subscribes to the
`labeled` and `unlabeled`
pull_request event types:

```yaml
on:
  pull_request:
    types: [opened, synchronize, reopened, labeled, unlabeled]
concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: true
```

So **any** label write starts a second binary-size run on the identical
commit, and
`cancel-in-progress` kills the one already in flight. A label change
cannot alter a bundle's
size, so there is nothing for the job to re-evaluate — the second run
just recomputes the same
answer and leaves a permanent `cancelled` check run behind on the
commit.

## Why it matters beyond wasted minutes

The cancelled check does not go away when the retry succeeds. Both check
runs stay attached to
the commit, so the commit's check rollup is `FAILURE` forever.

The PR risk grader reads that rollup. Its reversibility axis treats a
non-`SUCCESS` rollup as
`no_green_checks_tier`, which `.github/risk.json` sets to **R2** — so a
PR gets bumped to R2
because a label bot wrote a `size:*` label two seconds after CI started.

The chain, end to end:

1. `dosubot[bot]` writes a `size:*` label seconds after the PR opens or
is pushed to.
2. That `labeled` event re-triggers binary-size on the same commit;
`cancel-in-progress` cancels
   the in-flight run.
3. The commit now permanently carries a `binary-size / CANCELLED` check
run.
4. The grader counts `CANCELLED` as a failing check, so the rollup is
not `SUCCESS`, so
   reversibility is pinned at R2.

## Measured (re-verified for this PR, 2026-08-18)

| measure | value |
|---|---|
| binary-size runs, 30 days (created >= 2026-07-19) | 4,307 |
| ...concluded `cancelled` | **1,128 = 26.2%** |
| ...concluded `failure` | 39 = 0.9% |
| complete 2-day window (created >= 2026-08-16) | 819 runs |
| ...cancelled | 164 = 20.0% |
| cancels superseded by a later run on the **same head SHA** | **163 of
164 = 99.4%** |
| median gap to the superseding run | **2 s** (p25 0 s, p75 4 s) |
| distinct head SHAs in that window carrying **both** a `cancelled` and
a `success` run | 110 of 613 = **17.9%** |

Cancellations outrun real findings by roughly 29 to 1.

**Timed to the second on three live PRs** (label event → new run → prior
run cancelled):

- Comfy-Org#15413 — `size:XS` at 21:31:18Z → new run 21:31:20Z, prior run
(started 21:31:17Z) cancelled
- Comfy-Org#15414 — `size:L` at 21:35:47Z → new run 21:35:49Z, prior run
(21:35:45Z) cancelled
- Comfy-Org#15412 — `size:L` at 21:02:03Z → new run 21:02:06Z, prior run
(21:02:01Z) cancelled

**A settled rollup showing the consequence.** Commit `ce9ec9b4d0`
(Comfy-Org#15414, a `browser_tests/`-only
PR) — rollup state `FAILURE` over 85 contexts: 57 `SUCCESS`, 26
`SKIPPED`, and exactly one
failing-class context, `binary-size / CANCELLED`. That PR carries
`risk:R2`.

**Across the whole label population:** of the 112 PRs currently carrying
`risk:R2`, **17 (15.2%)
have a check rollup whose only failing-class context is `binary-size /
CANCELLED`** — Comfy-Org#14546,
Comfy-Org#15138, Comfy-Org#15173, Comfy-Org#15178, Comfy-Org#15261, Comfy-Org#15280, Comfy-Org#15307, Comfy-Org#15354, Comfy-Org#15371, Comfy-Org#15376,
Comfy-Org#15380, Comfy-Org#15388, Comfy-Org#15402,
Comfy-Org#15404, Comfy-Org#15410, Comfy-Org#15411, Comfy-Org#15414.

## Why removing the trigger is the right fix, and not the concurrency
group

Keying the concurrency group on `github.event.pull_request.head.sha`
does **not** help: a label
write happens on the identical commit, so it lands in the same group and
still cancels. The
re-trigger itself is what has to go.

`binary-size` is **not** a required check for merge — the `ProtectMain`
ruleset requires `test`,
`lint-and-format`, `e2e-status` and `website-e2e`, and `CLA Check`
requires `cla-assistant`.

## Trade-off, stated plainly

The `allow-large-binaries` bypass is read from
`github.event.pull_request.labels.*.name` at the
job `if:`. With `labeled` removed, applying that label no longer
re-evaluates the check
instantly — it takes effect on the next `synchronize`/`reopened`. That
costs nothing today:
**`allow-large-binaries` has been applied to 0 PRs, ever**, and the
check does not gate merge, so
a stale red never blocks anyone.

`scripts/cicd/check-binary-size.sh:165` prints "add the
'allow-large-binaries' label to the PR"
on failure; that advice still works, it just lands on the next push
rather than instantly. I have
deliberately not touched that file — happy to reword it in a follow-up
if a reviewer wants it.

## This PR demonstrates the fix on itself

`pull_request` workflow definitions are read from the PR head, so the
change is already live
here. Timeline:

- 22:50:13Z — PR opened
- 22:50:17Z — binary-size run `32194526247` starts
- 22:50:19Z — `dosubot[bot]` applies `size:XS`, **two seconds into the
run** — the exact pattern
  that cancels the run on every other PR

Result: **one** binary-size run on this commit, no second trigger, no
cancellation,
`binary-size pass 35s`. Compare Comfy-Org#15413 / Comfy-Org#15414 / Comfy-Org#15412 above, where
the same two-second label
write killed the in-flight run and left a permanent `CANCELLED` on the
commit.

## Scope

This is half the loop. The other half is grader-side: `CANCELLED` is
counted as a *failing*
check in `Comfy-Org/github-workflows`
(`scripts/pr-risk/grade-pr-risk.sh`), which is what turns a
cancelled run into an R2. That fix has **not shipped** and is not in
this PR. So this PR removes
the largest source of the cancellations but does not fully close the
loop — a binary-size run
cancelled for any other reason would still red the rollup.

No other change to the file.
@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
jzwyz pushed a commit to jzwyz/comfyui_frontend that referenced this pull request Oct 27, 2026
…21930)

## ELI5

The first-run Getting Started tour was gated on a server flag,
`onboarding_tour_enabled`, that is already on for everyone. This PR
deletes the frontend's check of that flag, so the tour is always
eligible for new cloud users on desktop-width screens with an active
subscription setup.

**A human must review and sign off on this PR before it is merged.** It
was opened unattended by the Feature Flag Hygiene routine under Luke's
account. Nothing is merged, and nothing in PostHog or prod was changed.
@deepme987 owns FE-3278 and this PR is theirs to accept, change or
close. This run could not confirm the flag's 30-day history or check the
tour end to end in a browser.

## Diagram

```mermaid
flowchart TD
  A[decideFirstRun] --> B{isCloud?}
  B -- no --> C[complete]
  B -- yes --> D{isNewUser false?}
  D -- yes --> C
  D -- no --> F{desktop width?}
  F -- no --> G[defer]
  F -- yes --> H{subscription enabled?}
  H -- no --> G
  H -- yes --> I{isNewUser null?}
  I -- yes --> G
  I -- no --> J[getting-started]
```

The removed step is the `onboardingTourEnabled` check that sat between
the new-user check and the desktop-width check and returned `defer`.

## Summary

Hard-codes `onboarding_tour_enabled` ON in the frontend.

- `firstRunEntry.ts`: remove the `if (!flags.onboardingTourEnabled)
return 'defer'` branch and the unused import.
- `useFeatureFlags.ts`, `serverFeatureFlag.ts`, `remoteConfig/types.ts`,
`__mocks__/useFeatureFlags.ts`: remove the accessor, enum member,
remote-config type and mock entry.
- Tests: drop the flag toggles and the "defaults to false" / "turns on
from remote config" cases. Remove the key from the browser-test feature
mocks.
- Kept on purpose: the `!isCloud` guard in `decideFirstRun`, which is
what hides the tour on OSS and Desktop. A missing flag key on those
builds no longer matters because that guard returns `complete` first.
String-literal uses of the key as sample data in
`sessionFeatureFlagOverride.test.ts`, `webSessionFlagOn.test.ts` and
`tools/test-recorder` are unchanged.
- Backend is untouched. Cloud still emits the key. Removing it is the
`[BE]` subtask (FE-3542) and must wait until this change is in the prod
`frontendVersion`.

Fixes FE-3278 (frontend part). Linear:
https://linear.app/comfyorg/issue/FE-3278

Behavior note: the dropped `defer` also covered the window before
`/api/features` resolves. The `isSubscriptionEnabled()` check still
defers in that window because it reads `window.__CONFIG__` from the same
fetch (see Comfy-Org#15173).

## Verification

- `pnpm typecheck`: clean.
- `pnpm exec vitest run` on `src/renderer/extensions/firstRunTour`,
`useFeatureFlags.test.ts`, `sessionFeatureFlagOverride.test.ts`,
`webSessionFlagOn.test.ts`: 14 files, 688 tests pass.
- `oxlint`, `eslint`, `oxfmt --check` on the 10 changed files: 0 errors.
The only warnings are eslint's "file ignored" notices.
- `pnpm knip`: no findings.
- Not run: the aggregate `pnpm lint` (this pnpm treats the regex script
filter as unknown), the Playwright browser tests (no backend here), and
`pnpm test:unit` in full. `pnpm locale:check` reports translations
pending that this PR does not touch.
- Committed with `--no-verify`: the husky pre-commit hook rejected the
sandbox's Node 22 (repo wants >=26.8.2). I ran the checks above by hand
instead.

### Change breakdown

| Category | Files | Added | Deleted | Share of changed lines |
|---|---|---|---|---|
| Product code | 5 (`src/composables/useFeatureFlags.ts`,
`src/composables/__mocks__/useFeatureFlags.ts`,
`src/platform/remoteConfig/serverFeatureFlag.ts`,
`src/platform/remoteConfig/types.ts`,
`src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.ts`)
| 0 | 12 | 19% |
| Test code | 5 (`src/composables/useFeatureFlags.test.ts`,
`src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.test.ts`,
`browser_tests/tests/gettingStartedTour.spec.ts`,
`browser_tests/tests/agent/agentConsent.spec.ts`,
`browser_tests/tests/onboarding/firstRunNudgeAgentPanel.spec.ts`) | 3 |
50 | 81% |

Total changed lines: 65. Documentation, config, generated, lockfile and
vendored files: none.

## Provenance

- Authored by: Feature Flag Hygiene routine, 2026-10-25 (PT)
- Flow: coder (human-signoff draft on another owner's ticket)
- Verified: the commands listed above, on head 5b00b9c
- Deviations: opened as a draft because the ticket is assigned to
someone else (§5a); the PostHog 100% history was taken from the Oct 19
Linear comment and the dynconfig state, not re-read from PostHog; the
branch is the session-assigned `claude/intelligent-euler-73w7on` rather
than the `luke-mino-altherr/...` pattern; no Claude attribution trailer,
per the routine's rules.

---
_Generated by [Claude
Code](https://claude.ai/code/session_01Q6uR6jVvWidUaUFkm9GJZg)_

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned) size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants