Repository navigation
fix(first-run-tour): give the nudge its own illustration - #14957
christian-byrne wants to merge 1 commit into
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Comment |
🎭 Playwright: ✅ 1806 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.69 MB gzip 🔴 +126 BDetailsSummary
Category Glance App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.36 MB (baseline 1.36 MB) • 🔴 +221 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 2 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 570 kB (baseline 570 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks Status: 14 unchanged Data & Services — 3.5 MB (baseline 3.5 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 14 MB (baseline 14 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 285 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-09T03:11:18.797Z",
"gitSha": "c2e34fb2d6b777e7cd8e8282fce9658d6d581669",
"branch": "fix/nudge-illustration-asset",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2131.6150000000107,
"styleRecalcs": 9,
"styleRecalcDurationMs": 11.133000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.628,
"heapDeltaBytes": 5850480,
"heapUsedBytes": 70283148,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 23.166,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2018.177000000037,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.644999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.28800000000007,
"heapDeltaBytes": 5864068,
"heapUsedBytes": 70296892,
"domNodes": 16,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 21.036999999999995,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2077.1080000000097,
"styleRecalcs": 79,
"styleRecalcDurationMs": 47.898999999999994,
"layouts": 12,
"layoutDurationMs": 3.982,
"taskDurationMs": 1043.1399999999999,
"heapDeltaBytes": -12838064,
"heapUsedBytes": 51564332,
"domNodes": -282,
"jsHeapTotalBytes": 24092672,
"scriptDurationMs": 130.16400000000002,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1880.0170000000094,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.938,
"layouts": 12,
"layoutDurationMs": 3.73,
"taskDurationMs": 946.3820000000001,
"heapDeltaBytes": -14208320,
"heapUsedBytes": 50203580,
"domNodes": -281,
"jsHeapTotalBytes": 23568384,
"scriptDurationMs": 125.05000000000003,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.379000000005,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.067999999999998,
"layouts": 6,
"layoutDurationMs": 0.694,
"taskDurationMs": 415.575,
"heapDeltaBytes": 8633800,
"heapUsedBytes": 72820008,
"domNodes": 76,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 23.394,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.2160000000422,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.911,
"layouts": 6,
"layoutDurationMs": 0.7869999999999999,
"taskDurationMs": 413.88199999999995,
"heapDeltaBytes": 8891748,
"heapUsedBytes": 73169992,
"domNodes": 78,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 22.358000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 624.5440000000144,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.472,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.0489999999999,
"heapDeltaBytes": -11206804,
"heapUsedBytes": 53105568,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 60.126,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 588.1289999999808,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.368,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.821,
"heapDeltaBytes": -11152912,
"heapUsedBytes": 53150688,
"domNodes": 16,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 60.197,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2025.3739999999993,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.357000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 700.7739999999999,
"heapDeltaBytes": 6911316,
"heapUsedBytes": 66944740,
"domNodes": -284,
"jsHeapTotalBytes": 3248128,
"scriptDurationMs": 103.83799999999998,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2040.9720000000107,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.053,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 706.0609999999999,
"heapDeltaBytes": 7367952,
"heapUsedBytes": 67372296,
"domNodes": -285,
"jsHeapTotalBytes": 4034560,
"scriptDurationMs": 108.222,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2159.4240000000013,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.933000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1298.797,
"heapDeltaBytes": 5216788,
"heapUsedBytes": 65693264,
"domNodes": -284,
"jsHeapTotalBytes": 4227072,
"scriptDurationMs": 418.907,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2206.2740000000076,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.514,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1325.674,
"heapDeltaBytes": 4646732,
"heapUsedBytes": 65805464,
"domNodes": -286,
"jsHeapTotalBytes": 3440640,
"scriptDurationMs": 435.166,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3198.167000000012,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.653999999999998,
"layouts": 60,
"layoutDurationMs": 8.379999999999999,
"taskDurationMs": 1575.983,
"heapDeltaBytes": -3599796,
"heapUsedBytes": 58657972,
"domNodes": -287,
"jsHeapTotalBytes": 5869568,
"scriptDurationMs": 534.8340000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3197.414999999978,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.608,
"layouts": 60,
"layoutDurationMs": 8.672,
"taskDurationMs": 1592.1689999999999,
"heapDeltaBytes": -2563588,
"heapUsedBytes": 59729916,
"domNodes": -290,
"jsHeapTotalBytes": 6393856,
"scriptDurationMs": 545.539,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.6030000000278,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.136,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 733.965,
"heapDeltaBytes": 6651160,
"heapUsedBytes": 67231088,
"domNodes": -285,
"jsHeapTotalBytes": 2985984,
"scriptDurationMs": 112.32000000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2012.1410000000424,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.027000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 711.6499999999999,
"heapDeltaBytes": 5895364,
"heapUsedBytes": 66570660,
"domNodes": -283,
"jsHeapTotalBytes": 3510272,
"scriptDurationMs": 109.47299999999998,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 605.0679999999602,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.337000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.958,
"heapDeltaBytes": -10475472,
"heapUsedBytes": 53824496,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 122.97800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 651.1910000000398,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.388000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.26599999999996,
"heapDeltaBytes": -11031352,
"heapUsedBytes": 53449724,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 124.094,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2007.9020000000014,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.744,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.675,
"heapDeltaBytes": 5952924,
"heapUsedBytes": 70307548,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 16.089,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.630999999994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.004000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.3,
"heapDeltaBytes": -17595040,
"heapUsedBytes": 46766428,
"domNodes": -281,
"jsHeapTotalBytes": 23830528,
"scriptDurationMs": 16.551000000000002,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1762.3279999999681,
"styleRecalcs": 78,
"styleRecalcDurationMs": 37.699,
"layouts": 16,
"layoutDurationMs": 4.312,
"taskDurationMs": 831.205,
"heapDeltaBytes": -17935472,
"heapUsedBytes": 46497236,
"domNodes": -279,
"jsHeapTotalBytes": 22781952,
"scriptDurationMs": 93.444,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1737.212999999997,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.809999999999995,
"layouts": 16,
"layoutDurationMs": 4.827999999999999,
"taskDurationMs": 843.1890000000001,
"heapDeltaBytes": -18284832,
"heapUsedBytes": 46079804,
"domNodes": -1,
"jsHeapTotalBytes": 22781952,
"scriptDurationMs": 96.67999999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.028999999961,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.191999999999997,
"layouts": 15,
"layoutDurationMs": 11.696000000000002,
"taskDurationMs": 965.4779999999998,
"heapDeltaBytes": 7051232,
"heapUsedBytes": 98823076,
"domNodes": 13673,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 37.504,
"eventListeners": 2375,
"totalBlockingTimeMs": 112,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8220.661000000007,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.671,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4529.013,
"heapDeltaBytes": 10824256,
"heapUsedBytes": 70805564,
"domNodes": -283,
"jsHeapTotalBytes": 5799936,
"scriptDurationMs": 1341.772,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8254.863999999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.425000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4621.660000000001,
"heapDeltaBytes": 12263632,
"heapUsedBytes": 71646144,
"domNodes": -284,
"jsHeapTotalBytes": 5537792,
"scriptDurationMs": 1375.577,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17993.278999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17942.516,
"heapDeltaBytes": -33881892,
"heapUsedBytes": 166572448,
"domNodes": -8312,
"jsHeapTotalBytes": -9117696,
"scriptDurationMs": 577.6030000000001,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.889999999999905,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18465.477999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18418.634000000002,
"heapDeltaBytes": -59162060,
"heapUsedBytes": 166762044,
"domNodes": -8312,
"jsHeapTotalBytes": -8331264,
"scriptDurationMs": 697.0719999999999,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22651.104999999974,
"styleRecalcs": 168,
"styleRecalcDurationMs": 26.09800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22625.33,
"heapDeltaBytes": -41751524,
"heapUsedBytes": 164410040,
"domNodes": -8312,
"jsHeapTotalBytes": -9117696,
"scriptDurationMs": 934.371,
"eventListeners": -16379,
"totalBlockingTimeMs": 887,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22638.720000000034,
"styleRecalcs": 168,
"styleRecalcDurationMs": 24.251999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22593.294,
"heapDeltaBytes": -47018452,
"heapUsedBytes": 176452048,
"domNodes": -8312,
"jsHeapTotalBytes": -9711616,
"scriptDurationMs": 912.052,
"eventListeners": -16383,
"totalBlockingTimeMs": 589,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 454.88399999999274,
"styleRecalcs": 13,
"styleRecalcDurationMs": 22.136000000000003,
"layouts": 3,
"layoutDurationMs": 1.2790000000000001,
"taskDurationMs": 118.50899999999999,
"heapDeltaBytes": 5061868,
"heapUsedBytes": 68438052,
"domNodes": 122,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.567000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 463.1819999999607,
"styleRecalcs": 12,
"styleRecalcDurationMs": 20.738,
"layouts": 3,
"layoutDurationMs": 0.5860000000000002,
"taskDurationMs": 113.82300000000001,
"heapDeltaBytes": 5040052,
"heapUsedBytes": 68552756,
"domNodes": 123,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.899999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
|
@MaanilVerma — context you should have before reviewing, because I closed a #14671 proposed swapping the nudge illustration to This PR is not that change. It is the alternative I described when closing If you would rather keep the coupling too, close this and I will not raise it a Two corrections to #14671 while I am here, both of which cut against my own
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14957 +/- ##
=======================================
Coverage 81.29% 81.29%
=======================================
Files 1873 1873
Lines 106900 106900
Branches 32977 32977
=======================================
Hits 86902 86902
+ Misses 19641 19631 -10
- Partials 357 367 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
MaanilVerma
left a comment
There was a problem hiding this comment.
@christian-byrne Yes, keeping the OG image coupled with the Onboarding Tour Nudge is intentional. That way, if we want to promote a new feature via the OG image, it will automatically reflect in the Tour.
I can sync with the design team on how best to use this real estate—whether that's highlighting new features in the Nudge image specifically or showing natural progression by displaying the workflow output an image/video in Onboarding Tour Nudge. But for now, I don't think this PR is necessary.
The nudge rendered `/assets/images/og-image.png` — the site's Open Graph social-preview card. That file's only other references are the OG meta tags in `vite.config.mts` and a drag-and-drop fixture, so the coupling was invisible: rotating the social preview restyled first-run onboarding, and nothing told whoever did it. Adds `first-run-nudge.png`, derived from the same artwork so the rendered result is unchanged. It is cropped to exactly the region `object-cover` was already showing in the 320x200 box and encoded at 2x for hidpi, which also halves the bytes a first-run user downloads: 269 KB -> 128 KB. Closes #14624
cd79d5f to
54b849c
Compare
|
Understood — closing. That reframes it properly: I had the coupling filed as an accident to be Also closing #14624, since its premise was wrong rather than its fix — I'll not One fact worth handing to the design conversation you mentioned, with no ask |
…15107) @MaanilVerma — **your call entirely; close it if you'd rather not.** I owe you context on why it's arriving as a PR eight days late rather than as a question. ## The gap `OnboardingTourNudgeMetadata` is `{ tour }` only, so `nudge_shown` and `explore_templates_clicked` cannot be split by how the tour ended. That matters more here than it would elsewhere, because **every ending arms the nudge** — deliberately, per your call in Comfy-Org#14144: *"a user who saw no tour is the one who most needs somewhere to go next."* So the nudge's audience is deliberately a mix of *finished the tour* and *never saw one*, and right now the funnel cannot tell those two apart. A conversion from someone who completed the walkthrough and one from someone the tour never started for land in the same bucket. ## The change `tourWasCompleted` is already in scope in the component — it picks the copy one line above the telemetry call. This carries the same value onto both events: ```ts telemetry?.trackOnboardingTour('nudge_shown', { tour: 'firstRun', tour_completed: tourWasCompleted.value }) ``` Optional field, no new event, **no visibility rule changed**, nothing added to any other event. ## Verification `FirstRunTourNudge.test.ts` **12/12**. The two existing assertions pinned the exact metadata shape, so they failed until updated — which is the suite working. Added one case asserting both events carry `false` when the tour did not complete. Mutation-checked: hard-coding `tour_completed: true` fails exactly that new case, 11 others still pass. `typecheck` and `format:check` clean. ## Why it's late I drafted this as part of a Slack reply to you on **2026-08-04** and never sent it, so you have never actually seen the offer. That's the failure, not the telemetry. It was the one item in that draft still worth acting on — the rest of it has since been overtaken (the nudge copy landed in Comfy-Org#14677, and you've since settled the OG image on Comfy-Org#14957). If you'd rather have the *full* ending instead of a boolean — `completed` vs `skipped` with its `skipReason` — say so and I'll rework it; the controller has `engine.lastEnding` and only exposes the boolean today. I went with the boolean because it needed no change to the controller's surface. Co-authored-by: t <t@t.t>
Closes #14624
The coupling
FirstRunTourNudge.vuerendered/assets/images/og-image.png. That file'sonly other references in the repo are the Open Graph meta tags in
vite.config.mtsand a drag-and-drop fixture inappMode.spec.ts— so thedependency ran one way and was invisible from the other side. Anyone rotating
the site's social preview would have restyled first-run onboarding, with no
reason to know they had and no test that would have caught it.
The fix
Adds
public/assets/images/first-run-nudge.png, owned by this surface.It is derived from the same artwork, so the rendered result is unchanged.
The nudge box is
w-80 h-50(320x200) and the image isobject-cover, whichagainst a 1200x630 source shows the centre 1008x630 region. The new asset is
exactly that crop, encoded at 2x (640x400) for hidpi and quantised back to the
source's own 256-colour palette.
Side effect worth having on a first-run surface: 269 KB → 128 KB.
og-image.png(shared)first-run-nudge.png(owned)Verification
object-covergeometry and diffed themvisually — indistinguishable, which is the point: this is a decoupling, not
a redesign.
FirstRunTourNudge.test.ts11/11 pass. The suite never asserted the imagesource, which is part of why the coupling survived; I did not add an
assertion pinning the filename, since that would only restate the constant.
pnpm run format:checkclean.Note for design
The illustration is the Comfy Cloud banner ("Run ComfyUI anywhere. No setup.").
That is not misplaced —
firstRunEntry.ts:32gates the whole first-run tour onisCloud, so only cloud users ever see it. But now that the asset is owned bythis surface rather than borrowed, it can be replaced with something purpose-drawn
for a 320x200 card without touching code — just swap the file.