Skip to content

fix(first-run-tour): give the nudge its own illustration - #14957

Closed
christian-byrne wants to merge 1 commit into
mainfrom
fix/nudge-illustration-asset
Closed

christian-byrne wants to merge 1 commit into
mainfrom
fix/nudge-illustration-asset

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Closes #14624

The coupling

FirstRunTourNudge.vue rendered /assets/images/og-image.png. That file's
only other references in the repo are the Open Graph meta tags in
vite.config.mts and a drag-and-drop fixture in appMode.spec.ts — so the
dependency ran one way and was invisible from the other side. Anyone rotating
the site's social preview would have restyled first-run onboarding, with no
reason to know they had and no test that would have caught it.

The fix

Adds public/assets/images/first-run-nudge.png, owned by this surface.

It is derived from the same artwork, so the rendered result is unchanged.
The nudge box is w-80 h-50 (320x200) and the image is object-cover, which
against a 1200x630 source shows the centre 1008x630 region. The new asset is
exactly that crop, encoded at 2x (640x400) for hidpi and quantised back to the
source's own 256-colour palette.

Side effect worth having on a first-run surface: 269 KB → 128 KB.

before after
file og-image.png (shared) first-run-nudge.png (owned)
source dimensions 1200x630 640x400
bytes 269,193 130,778

Verification

  • Rendered both through the real object-cover geometry and diffed them
    visually — indistinguishable, which is the point: this is a decoupling, not
    a redesign.
  • FirstRunTourNudge.test.ts 11/11 pass. The suite never asserted the image
    source, which is part of why the coupling survived; I did not add an
    assertion pinning the filename, since that would only restate the constant.
  • pnpm run format:check clean.

Note for design

The illustration is the Comfy Cloud banner ("Run ComfyUI anywhere. No setup.").
That is not misplaced — firstRunEntry.ts:32 gates the whole first-run tour on
isCloud, so only cloud users ever see it. But now that the asset is owned by
this surface rather than borrowed, it can be replaced with something purpose-drawn
for a 320x200 card without touching code — just swap the file.

@christian-byrne
christian-byrne requested a review from a team August 9, 2026 02:58
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 9, 2026
@coderabbitai

coderabbitai Bot commented Aug 9, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f5f75453-09ad-4763-b498-858017076df8

📥 Commits

Reviewing files that changed from the base of the PR and between b2d6e41 and 54b849c.

⛔ Files ignored due to path filters (1)
  • public/assets/images/first-run-nudge.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • src/renderer/extensions/firstRunTour/nudge/FirstRunTourNudge.vue

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 9, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1806 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1785 / ❌ 0 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/12/2026, 12:29:54 AM UTC

Links

📦 Bundle: 8.69 MB gzip 🔴 +126 B

Details

Summary

  • Raw size: 36.6 MB baseline 36.6 MB — 🔴 +221 B
  • Gzip: 8.69 MB baseline 8.69 MB — 🔴 +126 B
  • Brotli: 6.06 MB baseline 6.06 MB — 🔴 +159 B
  • Bundles: 437 current • 437 baseline • 3 added / 3 removed

Category Glance
Graph Workspace 🔴 +221 B (1.36 MB) · Vendor & Third-Party ⚪ 0 B (16.3 MB) · Other ⚪ 0 B (14 MB) · Data & Services ⚪ 0 B (3.5 MB) · Panels & Settings ⚪ 0 B (570 kB) · Utilities & Hooks ⚪ 0 B (550 kB) · + 5 more

App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-BDTnu7bc.js (removed) 3.67 kB — 🟢 -3.67 kB 🟢 -1.84 kB 🟢 -1.61 kB
assets/index-DG0T-vjc.js (new) — 3.67 kB 🔴 +3.67 kB 🔴 +1.84 kB 🔴 +1.61 kB

Status: 1 added / 1 removed

Graph Workspace — 1.36 MB (baseline 1.36 MB) • 🔴 +221 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-D0z1AAU9.js (new) — 1.35 MB 🔴 +1.35 MB 🔴 +294 kB 🔴 +221 kB
assets/GraphView-CsRugnFc.js (removed) 1.35 MB — 🟢 -1.35 MB 🟢 -294 kB 🟢 -221 kB

Status: 1 added / 1 removed / 2 unchanged

Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 17 unchanged

Panels & Settings — 570 kB (baseline 570 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 26 unchanged

User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 10 unchanged

Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 8 unchanged

UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 B

Reusable component library chunks

Status: 14 unchanged

Data & Services — 3.5 MB (baseline 3.5 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 38 unchanged

Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 17 unchanged

Other — 14 MB (baseline 14 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/main-BsGecGnK.js (new) — 45.1 kB 🔴 +45.1 kB 🔴 +13.1 kB 🔴 +11.4 kB
assets/main-Cc9Ji9uf.js (removed) 45.1 kB — 🟢 -45.1 kB 🟢 -13.1 kB 🟢 -11.4 kB

Status: 1 added / 1 removed / 285 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 50.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 44.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 112ms TBT · 94.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.9 MB heap
vue-large-graph-idle: · 54.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 158.9 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 738ms TBT · 162.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.3 MB heap

⚠️ 9 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 518ms 535ms +3% ⚠️ z=4.5
canvas-mouse-sweep: task duration 973ms 995ms +2% ⚠️ z=2.2
canvas-zoom-sweep: layout duration 1ms 1ms +18% ⚠️ z=2.2
canvas-zoom-sweep: task duration 413ms 415ms +1% ⚠️ z=3.8
dom-widget-clipping: task duration 378ms 400ms +6% ⚠️ z=2.2
large-graph-idle: task duration 746ms 703ms -6% ⚠️ z=3.0
large-graph-pan: task duration 1357ms 1312ms -3% ⚠️ z=5.3
minimap-idle: task duration 736ms 723ms -2% ⚠️ z=4.1
subgraph-idle: task duration 542ms 503ms -7% ⚠️ z=4.2
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms -0% z=-0.5
canvas-idle: p95 frame time 17ms 17ms -0% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 9ms 9ms +9% z=-1.6
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 9 9 -6% z=-4.7
canvas-idle: task duration 518ms 535ms +3% ⚠️ z=4.5
canvas-idle: script duration 21ms 22ms +6% z=-1.4
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 66.6 MB 67.0 MB +1% —
canvas-idle: DOM nodes 18 17 -6% z=-4.4
canvas-idle: event listeners 4 4 +0% z=-1.6
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.4
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 4ms 4ms +2% z=1.3
canvas-mouse-sweep: style recalc duration 47ms 44ms -5% z=0.6
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 77 78 +1% z=-0.5
canvas-mouse-sweep: task duration 973ms 995ms +2% ⚠️ z=2.2
canvas-mouse-sweep: script duration 133ms 128ms -4% z=-1.2
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 49.3 MB 48.5 MB -2% —
canvas-mouse-sweep: DOM nodes -280 -282 +1% z=-132.9
canvas-mouse-sweep: event listeners -153 -152 -1% z=-38.5
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=-0.3
canvas-zoom-sweep: p95 frame time 17ms 17ms -0% —
canvas-zoom-sweep: layout duration 1ms 1ms +18% ⚠️ z=2.2
canvas-zoom-sweep: style recalc duration 18ms 18ms +1% z=-0.4
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 31 32 +2% z=0.5
canvas-zoom-sweep: task duration 413ms 415ms +1% ⚠️ z=3.8
canvas-zoom-sweep: script duration 23ms 23ms -0% z=-1.4
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 69.7 MB 69.6 MB -0% —
canvas-zoom-sweep: DOM nodes 77 77 +0% z=-2.8
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.5
dom-widget-clipping: p95 frame time 17ms 17ms -0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 8ms 7ms -5% z=-3.1
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 11 11 +0% z=-4.2
dom-widget-clipping: task duration 378ms 400ms +6% ⚠️ z=2.2
dom-widget-clipping: script duration 60ms 60ms +0% z=-2.4
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 50.7 MB 50.7 MB -0% —
dom-widget-clipping: DOM nodes 18 18 +0% z=-2.9
dom-widget-clipping: event listeners 0 1 — variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=0.2
large-graph-idle: p95 frame time 17ms 17ms +0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 9ms 7ms -22% z=-4.8
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 8 8 +0% z=-11.5
large-graph-idle: task duration 746ms 703ms -6% ⚠️ z=3.0
large-graph-idle: script duration 122ms 106ms -13% z=0.3
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 63.3 MB 64.0 MB +1% —
large-graph-idle: DOM nodes -283 -285 +1% z=-342.1
large-graph-idle: event listeners -149 -147 -1% z=-28.4
large-graph-pan: avg frame time 17ms 17ms +0% z=0.3
large-graph-pan: p95 frame time 17ms 17ms -1% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 15ms 15ms +2% z=-2.6
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 69 69 -1% z=-1.7
large-graph-pan: task duration 1357ms 1312ms -3% ⚠️ z=5.3
large-graph-pan: script duration 458ms 427ms -7% z=1.0
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 64.5 MB 62.7 MB -3% —
large-graph-pan: DOM nodes -284 -285 +0% z=-184.3
large-graph-pan: event listeners -149 -149 +0% z=-185.9
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms -0% —
large-graph-zoom: layout duration 8ms 9ms +12% —
large-graph-zoom: style recalc duration 14ms 16ms +11% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 64 65 +1% —
large-graph-zoom: task duration 1572ms 1584ms +1% —
large-graph-zoom: script duration 556ms 540ms -3% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 60.8 MB 56.5 MB -7% —
large-graph-zoom: DOM nodes -287 -289 +1% —
large-graph-zoom: event listeners -153 -153 +0% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.1
minimap-idle: p95 frame time 17ms 17ms +0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 8ms 7ms -13% z=-3.0
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 8 8 -6% z=-3.0
minimap-idle: task duration 736ms 723ms -2% ⚠️ z=4.1
minimap-idle: script duration 121ms 111ms -8% z=1.3
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 64.1 MB 63.8 MB -0% —
minimap-idle: DOM nodes -284 -284 +0% z=-221.6
minimap-idle: event listeners -151 -148 -2% z=-231.1
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms -0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 13ms 11ms -18% z=-2.0
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 46 47 +1% z=-2.5
subgraph-dom-widget-clipping: task duration 432ms 412ms -5% z=1.8
subgraph-dom-widget-clipping: script duration 127ms 124ms -3% z=-0.7
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 51.3 MB 51.2 MB -0% —
subgraph-dom-widget-clipping: DOM nodes 18 19 +6% z=-2.8
subgraph-dom-widget-clipping: event listeners 6 6 +0% z=-1.7
subgraph-idle: avg frame time 17ms 17ms -0% z=0.4
subgraph-idle: p95 frame time 17ms 17ms -0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 9ms 8ms -7% z=-2.6
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 10 10 -5% z=-2.1
subgraph-idle: task duration 542ms 503ms -7% ⚠️ z=4.2
subgraph-idle: script duration 18ms 16ms -10% z=-1.5
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 66.9 MB 55.8 MB -17% —
subgraph-idle: DOM nodes 20 -131 -753% z=-101.9
subgraph-idle: event listeners 4 -75 -1963% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.4
subgraph-mouse-sweep: p95 frame time 17ms 17ms -0% —
subgraph-mouse-sweep: layout duration 5ms 5ms -6% z=-0.4
subgraph-mouse-sweep: style recalc duration 41ms 38ms -6% z=-1.3
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 78 78 +0% z=-1.1
subgraph-mouse-sweep: task duration 884ms 837ms -5% z=1.0
subgraph-mouse-sweep: script duration 100ms 95ms -5% z=-0.9
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 44.0 MB 44.1 MB +0% —
subgraph-mouse-sweep: DOM nodes 3 -140 -4767% z=-92.6
subgraph-mouse-sweep: event listeners -153 -153 +0% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms +0% —
subgraph-transition-enter: p95 frame time 17ms 17ms -0% —
subgraph-transition-enter: layout duration 14ms 12ms -14% —
subgraph-transition-enter: style recalc duration 32ms 30ms -6% —
subgraph-transition-enter: layout count 15 15 +0% —
subgraph-transition-enter: style recalc count 19 19 +0% —
subgraph-transition-enter: task duration 983ms 965ms -2% —
subgraph-transition-enter: script duration 39ms 38ms -4% —
subgraph-transition-enter: TBT 144ms 112ms -22% —
subgraph-transition-enter: heap used 94.9 MB 94.2 MB -1% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2375 2375 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms -0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 39ms 43ms +8% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 249 250 +0% —
viewport-pan-sweep: task duration 4775ms 4575ms -4% —
viewport-pan-sweep: script duration 1507ms 1359ms -10% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 65.3 MB 67.9 MB +4% —
viewport-pan-sweep: DOM nodes -283 -284 +0% —
viewport-pan-sweep: event listeners -161 -133 -17% —
vue-large-graph-idle: avg frame time 18ms 18ms +3% —
vue-large-graph-idle: p95 frame time 17ms 17ms +1% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 17306ms 18181ms +5% —
vue-large-graph-idle: script duration 579ms 637ms +10% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 173.1 MB 158.9 MB -8% —
vue-large-graph-idle: DOM nodes -8312 -8312 +0% —
vue-large-graph-idle: event listeners -16389 -16387 -0% —
vue-large-graph-pan: avg frame time 18ms 18ms +2% —
vue-large-graph-pan: p95 frame time 17ms 17ms -0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 19ms 25ms +30% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 148 168 +14% —
vue-large-graph-pan: task duration 21503ms 22609ms +5% —
vue-large-graph-pan: script duration 920ms 923ms +0% —
vue-large-graph-pan: TBT 360ms 738ms +105% —
vue-large-graph-pan: heap used 166.1 MB 162.5 MB -2% —
vue-large-graph-pan: DOM nodes -8312 -8312 +0% —
vue-large-graph-pan: event listeners -16383 -16381 -0% —
workflow-execution: avg frame time 17ms 17ms -0% z=-0.4
workflow-execution: p95 frame time 17ms 17ms +0% —
workflow-execution: layout duration 0ms 1ms +122% z=-4.2
workflow-execution: style recalc duration 20ms 21ms +7% z=-1.3
workflow-execution: layout count 2 3 +50% z=-3.6
workflow-execution: style recalc count 13 13 -4% z=-2.6
workflow-execution: task duration 114ms 116ms +2% z=-0.6
workflow-execution: script duration 10ms 10ms +1% z=-6.4
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 65.4 MB 65.3 MB -0% —
workflow-execution: DOM nodes 121 123 +1% z=-5.4
workflow-execution: event listeners 97 98 +1% z=10.6
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-08-09T03:11:18.797Z",
  "gitSha": "c2e34fb2d6b777e7cd8e8282fce9658d6d581669",
  "branch": "fix/nudge-illustration-asset",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2131.6150000000107,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 11.133000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 578.628,
      "heapDeltaBytes": 5850480,
      "heapUsedBytes": 70283148,
      "domNodes": 18,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 23.166,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2018.177000000037,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.644999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 492.28800000000007,
      "heapDeltaBytes": 5864068,
      "heapUsedBytes": 70296892,
      "domNodes": 16,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 21.036999999999995,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2077.1080000000097,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 47.898999999999994,
      "layouts": 12,
      "layoutDurationMs": 3.982,
      "taskDurationMs": 1043.1399999999999,
      "heapDeltaBytes": -12838064,
      "heapUsedBytes": 51564332,
      "domNodes": -282,
      "jsHeapTotalBytes": 24092672,
      "scriptDurationMs": 130.16400000000002,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1880.0170000000094,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 40.938,
      "layouts": 12,
      "layoutDurationMs": 3.73,
      "taskDurationMs": 946.3820000000001,
      "heapDeltaBytes": -14208320,
      "heapUsedBytes": 50203580,
      "domNodes": -281,
      "jsHeapTotalBytes": 23568384,
      "scriptDurationMs": 125.05000000000003,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1755.379000000005,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.067999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.694,
      "taskDurationMs": 415.575,
      "heapDeltaBytes": 8633800,
      "heapUsedBytes": 72820008,
      "domNodes": 76,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 23.394,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1754.2160000000422,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.911,
      "layouts": 6,
      "layoutDurationMs": 0.7869999999999999,
      "taskDurationMs": 413.88199999999995,
      "heapDeltaBytes": 8891748,
      "heapUsedBytes": 73169992,
      "domNodes": 78,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 22.358000000000004,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 624.5440000000144,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.472,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 412.0489999999999,
      "heapDeltaBytes": -11206804,
      "heapUsedBytes": 53105568,
      "domNodes": 20,
      "jsHeapTotalBytes": 25690112,
      "scriptDurationMs": 60.126,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 588.1289999999808,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.368,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 388.821,
      "heapDeltaBytes": -11152912,
      "heapUsedBytes": 53150688,
      "domNodes": 16,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 60.197,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2025.3739999999993,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.357000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 700.7739999999999,
      "heapDeltaBytes": 6911316,
      "heapUsedBytes": 66944740,
      "domNodes": -284,
      "jsHeapTotalBytes": 3248128,
      "scriptDurationMs": 103.83799999999998,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.9720000000107,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.053,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 706.0609999999999,
      "heapDeltaBytes": 7367952,
      "heapUsedBytes": 67372296,
      "domNodes": -285,
      "jsHeapTotalBytes": 4034560,
      "scriptDurationMs": 108.222,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2159.4240000000013,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.933000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1298.797,
      "heapDeltaBytes": 5216788,
      "heapUsedBytes": 65693264,
      "domNodes": -284,
      "jsHeapTotalBytes": 4227072,
      "scriptDurationMs": 418.907,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2206.2740000000076,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.514,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1325.674,
      "heapDeltaBytes": 4646732,
      "heapUsedBytes": 65805464,
      "domNodes": -286,
      "jsHeapTotalBytes": 3440640,
      "scriptDurationMs": 435.166,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3198.167000000012,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.653999999999998,
      "layouts": 60,
      "layoutDurationMs": 8.379999999999999,
      "taskDurationMs": 1575.983,
      "heapDeltaBytes": -3599796,
      "heapUsedBytes": 58657972,
      "domNodes": -287,
      "jsHeapTotalBytes": 5869568,
      "scriptDurationMs": 534.8340000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3197.414999999978,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 15.608,
      "layouts": 60,
      "layoutDurationMs": 8.672,
      "taskDurationMs": 1592.1689999999999,
      "heapDeltaBytes": -2563588,
      "heapUsedBytes": 59729916,
      "domNodes": -290,
      "jsHeapTotalBytes": 6393856,
      "scriptDurationMs": 545.539,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.6030000000278,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.136,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 733.965,
      "heapDeltaBytes": 6651160,
      "heapUsedBytes": 67231088,
      "domNodes": -285,
      "jsHeapTotalBytes": 2985984,
      "scriptDurationMs": 112.32000000000001,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2012.1410000000424,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.027000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 711.6499999999999,
      "heapDeltaBytes": 5895364,
      "heapUsedBytes": 66570660,
      "domNodes": -283,
      "jsHeapTotalBytes": 3510272,
      "scriptDurationMs": 109.47299999999998,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 605.0679999999602,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.337000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 405.958,
      "heapDeltaBytes": -10475472,
      "heapUsedBytes": 53824496,
      "domNodes": 18,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 122.97800000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 651.1910000000398,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.388000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.26599999999996,
      "heapDeltaBytes": -11031352,
      "heapUsedBytes": 53449724,
      "domNodes": 20,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 124.094,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.9020000000014,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.744,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 490.675,
      "heapDeltaBytes": 5952924,
      "heapUsedBytes": 70307548,
      "domNodes": 20,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 16.089,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.630999999994,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.004000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 515.3,
      "heapDeltaBytes": -17595040,
      "heapUsedBytes": 46766428,
      "domNodes": -281,
      "jsHeapTotalBytes": 23830528,
      "scriptDurationMs": 16.551000000000002,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1762.3279999999681,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 37.699,
      "layouts": 16,
      "layoutDurationMs": 4.312,
      "taskDurationMs": 831.205,
      "heapDeltaBytes": -17935472,
      "heapUsedBytes": 46497236,
      "domNodes": -279,
      "jsHeapTotalBytes": 22781952,
      "scriptDurationMs": 93.444,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1737.212999999997,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 38.809999999999995,
      "layouts": 16,
      "layoutDurationMs": 4.827999999999999,
      "taskDurationMs": 843.1890000000001,
      "heapDeltaBytes": -18284832,
      "heapUsedBytes": 46079804,
      "domNodes": -1,
      "jsHeapTotalBytes": 22781952,
      "scriptDurationMs": 96.67999999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.028999999961,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 30.191999999999997,
      "layouts": 15,
      "layoutDurationMs": 11.696000000000002,
      "taskDurationMs": 965.4779999999998,
      "heapDeltaBytes": 7051232,
      "heapUsedBytes": 98823076,
      "domNodes": 13673,
      "jsHeapTotalBytes": 14680064,
      "scriptDurationMs": 37.504,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 112,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8220.661000000007,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 41.671,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4529.013,
      "heapDeltaBytes": 10824256,
      "heapUsedBytes": 70805564,
      "domNodes": -283,
      "jsHeapTotalBytes": 5799936,
      "scriptDurationMs": 1341.772,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8254.863999999998,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 43.425000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4621.660000000001,
      "heapDeltaBytes": 12263632,
      "heapUsedBytes": 71646144,
      "domNodes": -284,
      "jsHeapTotalBytes": 5537792,
      "scriptDurationMs": 1375.577,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17993.278999999973,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17942.516,
      "heapDeltaBytes": -33881892,
      "heapUsedBytes": 166572448,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9117696,
      "scriptDurationMs": 577.6030000000001,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.889999999999905,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18465.477999999963,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18418.634000000002,
      "heapDeltaBytes": -59162060,
      "heapUsedBytes": 166762044,
      "domNodes": -8312,
      "jsHeapTotalBytes": -8331264,
      "scriptDurationMs": 697.0719999999999,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22651.104999999974,
      "styleRecalcs": 168,
      "styleRecalcDurationMs": 26.09800000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22625.33,
      "heapDeltaBytes": -41751524,
      "heapUsedBytes": 164410040,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9117696,
      "scriptDurationMs": 934.371,
      "eventListeners": -16379,
      "totalBlockingTimeMs": 887,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22638.720000000034,
      "styleRecalcs": 168,
      "styleRecalcDurationMs": 24.251999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22593.294,
      "heapDeltaBytes": -47018452,
      "heapUsedBytes": 176452048,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9711616,
      "scriptDurationMs": 912.052,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 589,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 454.88399999999274,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 22.136000000000003,
      "layouts": 3,
      "layoutDurationMs": 1.2790000000000001,
      "taskDurationMs": 118.50899999999999,
      "heapDeltaBytes": 5061868,
      "heapUsedBytes": 68438052,
      "domNodes": 122,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 10.567000000000002,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 463.1819999999607,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 20.738,
      "layouts": 3,
      "layoutDurationMs": 0.5860000000000002,
      "taskDurationMs": 113.82300000000001,
      "heapDeltaBytes": 5040052,
      "heapUsedBytes": 68552756,
      "domNodes": 123,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 9.899999999999999,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

@christian-byrne

Copy link
Copy Markdown
Contributor Author

@MaanilVerma — context you should have before reviewing, because I closed a
predecessor to this on your call.

#14671 proposed swapping the nudge illustration to default-template.png.
You flagged in Slack that the OG image was a deliberate choice, so I closed it
as yours to make and said I would not reopen it. I stand by that.

This PR is not that change. It is the alternative I described when closing
#14671: "a dedicated copy of the same asset at its own path gets the identical
visual with none of the coupling."
The image on screen is byte-for-byte the
same artwork, cropped to exactly the region object-cover was already showing.
Nothing about the aesthetic decision is being relitigated — only the fact that
the file is shared with the site's social preview.

If you would rather keep the coupling too, close this and I will not raise it a
third time.

Two corrections to #14671 while I am here, both of which cut against my own
earlier argument:

  1. fix(first-run-tour): stop illustrating the nudge with the Open Graph card #14671 said a local first-run user gets a cloud ad. That was wrong.
    firstRunEntry.ts:32 gates isFirstRunCandidate() on isCloud, and both
    beginTour call paths run through it, so the nudge only ever arms on cloud.
    The banner is on-audience.
  2. fix(first-run-tour): stop illustrating the nudge with the Open Graph card #14671 picked default-template.png. That would have been a visible
    regression
    — it is 224x224, so object-cover into the 320x200 box upscales
    it 1.43x and blurs it. The issue text (mine) suggested it without checking
    the dimensions.

@codecov

codecov Bot commented Aug 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main   #14957   +/-   ##
=======================================
  Coverage   81.29%   81.29%           
=======================================
  Files        1873     1873           
  Lines      106900   106900           
  Branches    32977    32977           
=======================================
  Hits        86902    86902           
+ Misses      19641    19631   -10     
- Partials      357      367   +10     
Flag Coverage Δ
unit 72.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...xtensions/firstRunTour/nudge/FirstRunTourNudge.vue 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MaanilVerma MaanilVerma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christian-byrne Yes, keeping the OG image coupled with the Onboarding Tour Nudge is intentional. That way, if we want to promote a new feature via the OG image, it will automatically reflect in the Tour.

I can sync with the design team on how best to use this real estate—whether that's highlighting new features in the Nudge image specifically or showing natural progression by displaying the workflow output an image/video in Onboarding Tour Nudge. But for now, I don't think this PR is necessary.

The nudge rendered `/assets/images/og-image.png` — the site's Open Graph
social-preview card. That file's only other references are the OG meta
tags in `vite.config.mts` and a drag-and-drop fixture, so the coupling was
invisible: rotating the social preview restyled first-run onboarding, and
nothing told whoever did it.

Adds `first-run-nudge.png`, derived from the same artwork so the rendered
result is unchanged. It is cropped to exactly the region `object-cover`
was already showing in the 320x200 box and encoded at 2x for hidpi, which
also halves the bytes a first-run user downloads: 269 KB -> 128 KB.

Closes #14624
@christian-byrne
christian-byrne force-pushed the fix/nudge-illustration-asset branch from cd79d5f to 54b849c Compare August 12, 2026 00:28
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Understood — closing.

That reframes it properly: I had the coupling filed as an accident to be
removed, and it is a deliberate channel. "Rotate the OG image to promote a
feature and it reflects in the tour automatically" is a reason to keep the two
pointing at one file, and a dedicated copy would have quietly broken that.
Your call, and the right one.

Also closing #14624, since its premise was wrong rather than its fix — I'll not
raise this a third time.

One fact worth handing to the design conversation you mentioned, with no ask
attached: the asset is 1200x630 / 269 KB, object-cover-cropped into a
320x200 box, so a first-run user downloads roughly 2x the pixels the panel can
show. If that real estate does get purpose-designed, sizing it for the panel is
free weight back. Nothing to do here either way.

@christian-byrne
christian-byrne deleted the fix/nudge-illustration-asset branch August 12, 2026 00:29
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Aug 12, 2026
…15107)

@MaanilVerma — **your call entirely; close it if you'd rather not.** I
owe you
context on why it's arriving as a PR eight days late rather than as a
question.

## The gap

`OnboardingTourNudgeMetadata` is `{ tour }` only, so `nudge_shown` and
`explore_templates_clicked` cannot be split by how the tour ended.

That matters more here than it would elsewhere, because **every ending
arms the
nudge** — deliberately, per your call in Comfy-Org#14144: *"a user who saw no
tour is the
one who most needs somewhere to go next."* So the nudge's audience is
deliberately a mix of *finished the tour* and *never saw one*, and right
now the
funnel cannot tell those two apart. A conversion from someone who
completed the
walkthrough and one from someone the tour never started for land in the
same
bucket.

## The change

`tourWasCompleted` is already in scope in the component — it picks the
copy one
line above the telemetry call. This carries the same value onto both
events:

```ts
telemetry?.trackOnboardingTour('nudge_shown', {
  tour: 'firstRun',
  tour_completed: tourWasCompleted.value
})
```

Optional field, no new event, **no visibility rule changed**, nothing
added to
any other event.

## Verification

`FirstRunTourNudge.test.ts` **12/12**. The two existing assertions
pinned the
exact metadata shape, so they failed until updated — which is the suite
working.
Added one case asserting both events carry `false` when the tour did not
complete.

Mutation-checked: hard-coding `tour_completed: true` fails exactly that
new
case, 11 others still pass. `typecheck` and `format:check` clean.

## Why it's late

I drafted this as part of a Slack reply to you on **2026-08-04** and
never sent
it, so you have never actually seen the offer. That's the failure, not
the
telemetry. It was the one item in that draft still worth acting on — the
rest
of it has since been overtaken (the nudge copy landed in Comfy-Org#14677, and
you've
since settled the OG image on Comfy-Org#14957).

If you'd rather have the *full* ending instead of a boolean —
`completed` vs
`skipped` with its `skipReason` — say so and I'll rework it; the
controller has
`engine.lastEnding` and only exposes the boolean today. I went with the
boolean
because it needed no change to the controller's surface.

Co-authored-by: t <t@t.t>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

First-run tour nudge uses the site's Open Graph card as its illustration

3 participants