Repository navigation
feat(telemetry): split nudge events by how the tour ended - #15107
Conversation
`OnboardingTourNudgeMetadata` was `{ tour }` only, so `nudge_shown` and
`explore_templates_clicked` could not be separated by outcome: a conversion
from a tour walked to the end and one from a tour that never started landed in
the same bucket. Since every ending arms the nudge - deliberately, per #14144 -
that bucket mixes the two populations the funnel most needs to tell apart.
`tourWasCompleted` is already in scope in the component; it drives the copy
choice one line above. This carries the same value on both events.
Adds no new field to any other event and changes no visibility rule.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe first-run nudge telemetry now records whether the associated tour was completed. Tests cover completed and unfinished tour states for display and template exploration events. ChangesFirst-run tour telemetry
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1806 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.71 MB gzip 🔴 +15 BDetailsSummary
Category Glance App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.36 MB (baseline 1.36 MB) • 🔴 +102 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 2 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks Status: 14 unchanged Data & Services — 3.51 MB (baseline 3.51 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 14.1 MB (baseline 14.1 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 284 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-12T02:00:55.773Z",
"gitSha": "2b1bf525c24a24e104d0c177c13bbc2752542186",
"branch": "feat/nudge-telemetry-tour-completed",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2083.665999999994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.301000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.4000000000001,
"heapDeltaBytes": 5772540,
"heapUsedBytes": 70334536,
"domNodes": 18,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 17.442000000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2033.7599999999725,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.847999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.83699999999993,
"heapDeltaBytes": 5684572,
"heapUsedBytes": 69909236,
"domNodes": 12,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 16.213,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2048.237,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.982000000000006,
"layouts": 12,
"layoutDurationMs": 3.5640000000000005,
"taskDurationMs": 1048.5690000000002,
"heapDeltaBytes": -13578396,
"heapUsedBytes": 50962552,
"domNodes": -280,
"jsHeapTotalBytes": 23830528,
"scriptDurationMs": 123.76500000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1795.7829999999717,
"styleRecalcs": 72,
"styleRecalcDurationMs": 32.697,
"layouts": 12,
"layoutDurationMs": 3.365,
"taskDurationMs": 874.7700000000001,
"heapDeltaBytes": -13513020,
"heapUsedBytes": 50824632,
"domNodes": -280,
"jsHeapTotalBytes": 23830528,
"scriptDurationMs": 112.188,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.8390000000136,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.191999999999997,
"layouts": 6,
"layoutDurationMs": 0.6689999999999999,
"taskDurationMs": 394.579,
"heapDeltaBytes": 8750456,
"heapUsedBytes": 73210808,
"domNodes": 78,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 18.738999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.0019999999986,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.526,
"layouts": 6,
"layoutDurationMs": 0.608,
"taskDurationMs": 297.06100000000004,
"heapDeltaBytes": 8876592,
"heapUsedBytes": 73247024,
"domNodes": 78,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 18.366,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 561.9939999999701,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.274,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.85200000000003,
"heapDeltaBytes": -11231824,
"heapUsedBytes": 53271564,
"domNodes": 22,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 57.417,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 608.5059999999771,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.508,
"heapDeltaBytes": -11288064,
"heapUsedBytes": 53133056,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 55.510000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.0320000000106,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.3489999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 690.308,
"heapDeltaBytes": 4154836,
"heapUsedBytes": 63887760,
"domNodes": -281,
"jsHeapTotalBytes": 2461696,
"scriptDurationMs": 96.33500000000001,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2017.9299999999785,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.432,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 662.0109999999999,
"heapDeltaBytes": 6659648,
"heapUsedBytes": 66353692,
"domNodes": -284,
"jsHeapTotalBytes": 2985984,
"scriptDurationMs": 89.37400000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2182.5359999999705,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.513000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1241.112,
"heapDeltaBytes": 4073260,
"heapUsedBytes": 64994204,
"domNodes": -284,
"jsHeapTotalBytes": 3702784,
"scriptDurationMs": 397.332,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2144.5059999999785,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.927999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1206.708,
"heapDeltaBytes": 4450480,
"heapUsedBytes": 64969824,
"domNodes": -283,
"jsHeapTotalBytes": 4227072,
"scriptDurationMs": 392.19399999999996,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3180.534000000023,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.086000000000002,
"layouts": 60,
"layoutDurationMs": 7.751000000000001,
"taskDurationMs": 1452.046,
"heapDeltaBytes": -2909180,
"heapUsedBytes": 59715756,
"domNodes": -287,
"jsHeapTotalBytes": 6918144,
"scriptDurationMs": 512.033,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3163.729999999987,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.345999999999998,
"layouts": 60,
"layoutDurationMs": 7.962000000000001,
"taskDurationMs": 1502.0430000000001,
"heapDeltaBytes": -5677148,
"heapUsedBytes": 56625464,
"domNodes": -287,
"jsHeapTotalBytes": 6393856,
"scriptDurationMs": 530.933,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.132999999987,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.034000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 681.613,
"heapDeltaBytes": 5100776,
"heapUsedBytes": 65963420,
"domNodes": -282,
"jsHeapTotalBytes": 4296704,
"scriptDurationMs": 94.37800000000001,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2056.026999999972,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.543,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 663.3129999999999,
"heapDeltaBytes": 7463988,
"heapUsedBytes": 68258592,
"domNodes": -283,
"jsHeapTotalBytes": 3248128,
"scriptDurationMs": 96.101,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.8490000000188,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.334,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.45099999999996,
"heapDeltaBytes": -10675596,
"heapUsedBytes": 53802952,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 118.49600000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.2270000000644,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.990000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.27599999999995,
"heapDeltaBytes": -10964320,
"heapUsedBytes": 53499520,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 122.77000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1991.0050000000297,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.2219999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.021,
"heapDeltaBytes": 5959356,
"heapUsedBytes": 70388364,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 13.732000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1995.7110000000284,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.248000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.68600000000004,
"heapDeltaBytes": 5879812,
"heapUsedBytes": 70376896,
"domNodes": 16,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 13.016000000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1728.1039999999734,
"styleRecalcs": 80,
"styleRecalcDurationMs": 36.742,
"layouts": 16,
"layoutDurationMs": 4.063000000000001,
"taskDurationMs": 781.0200000000001,
"heapDeltaBytes": -18316588,
"heapUsedBytes": 46149012,
"domNodes": 5,
"jsHeapTotalBytes": 23830528,
"scriptDurationMs": 86.755,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.450000000008,
"styleRecalcs": 77,
"styleRecalcDurationMs": 33.374,
"layouts": 16,
"layoutDurationMs": 4.020999999999999,
"taskDurationMs": 745.553,
"heapDeltaBytes": -3214464,
"heapUsedBytes": 61103392,
"domNodes": 66,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 85.756,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1388.1430000000137,
"styleRecalcs": 19,
"styleRecalcDurationMs": 29.016000000000005,
"layouts": 15,
"layoutDurationMs": 11.217999999999998,
"taskDurationMs": 901.4350000000002,
"heapDeltaBytes": 3417396,
"heapUsedBytes": 74619016,
"domNodes": 13673,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 30.927999999999997,
"eventListeners": 2375,
"totalBlockingTimeMs": 125,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8277.92800000003,
"styleRecalcs": 251,
"styleRecalcDurationMs": 39.977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4376.3769999999995,
"heapDeltaBytes": 13013676,
"heapUsedBytes": 72589996,
"domNodes": -282,
"jsHeapTotalBytes": 6848512,
"scriptDurationMs": 1350.565,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8166.61600000009,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.137,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4236.63,
"heapDeltaBytes": 8647004,
"heapUsedBytes": 68079180,
"domNodes": -282,
"jsHeapTotalBytes": 5275648,
"scriptDurationMs": 1264.008,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17427.939999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17402.124,
"heapDeltaBytes": -74304608,
"heapUsedBytes": 152043308,
"domNodes": -8341,
"jsHeapTotalBytes": -7544832,
"scriptDurationMs": 588.227,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17411.13699999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17383.274999999998,
"heapDeltaBytes": -61399780,
"heapUsedBytes": 165707436,
"domNodes": -8312,
"jsHeapTotalBytes": -9904128,
"scriptDurationMs": 548.9340000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20929.895999999986,
"styleRecalcs": 146,
"styleRecalcDurationMs": 18.557999999999964,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20883.842999999997,
"heapDeltaBytes": -37783696,
"heapUsedBytes": 178907636,
"domNodes": -8312,
"jsHeapTotalBytes": -6565888,
"scriptDurationMs": 861.437,
"eventListeners": -16381,
"totalBlockingTimeMs": 338,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21295.393999999986,
"styleRecalcs": 143,
"styleRecalcDurationMs": 17.396999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21248.460000000003,
"heapDeltaBytes": -41820520,
"heapUsedBytes": 164408208,
"domNodes": -8312,
"jsHeapTotalBytes": -8855552,
"scriptDurationMs": 861.359,
"eventListeners": -16381,
"totalBlockingTimeMs": 171,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 485.3999999999701,
"styleRecalcs": 12,
"styleRecalcDurationMs": 16.530000000000005,
"layouts": 3,
"layoutDurationMs": 0.624,
"taskDurationMs": 117.545,
"heapDeltaBytes": 5066188,
"heapUsedBytes": 68550048,
"domNodes": 124,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.05,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 457.1249999999054,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.534000000000002,
"layouts": 3,
"layoutDurationMs": 0.6690000000000002,
"taskDurationMs": 108.62299999999999,
"heapDeltaBytes": 5039668,
"heapUsedBytes": 68736564,
"domNodes": 123,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.415999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
|
One thing I decided not to decide: I briefly put The convention I've been following on this stack is that user-facing tour fixes get backported and test/CI changes don't. This is neither — it's an enhancement. It would make the 1.49 tour measurable, which is an argument for it, but whether a new telemetry field rides into the RC is your call and @deepme987's, not something I should pre-decide by labelling. Add them if you want it there. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15107 +/- ##
==========================================
+ Coverage 81.30% 81.34% +0.03%
==========================================
Files 1874 1874
Lines 107762 107810 +48
Branches 33811 33850 +39
==========================================
+ Hits 87620 87699 +79
+ Misses 19751 19712 -39
- Partials 391 399 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes 🚀 New features to boost your workflow:
|
@MaanilVerma — your call entirely; close it if you'd rather not. I owe you
context on why it's arriving as a PR eight days late rather than as a question.
The gap
OnboardingTourNudgeMetadatais{ tour }only, sonudge_shownandexplore_templates_clickedcannot be split by how the tour ended.That matters more here than it would elsewhere, because every ending arms the
nudge — deliberately, per your call in #14144: "a user who saw no tour is the
one who most needs somewhere to go next." So the nudge's audience is
deliberately a mix of finished the tour and never saw one, and right now the
funnel cannot tell those two apart. A conversion from someone who completed the
walkthrough and one from someone the tour never started for land in the same
bucket.
The change
tourWasCompletedis already in scope in the component — it picks the copy oneline above the telemetry call. This carries the same value onto both events:
Optional field, no new event, no visibility rule changed, nothing added to
any other event.
Verification
FirstRunTourNudge.test.ts12/12. The two existing assertions pinned theexact metadata shape, so they failed until updated — which is the suite working.
Added one case asserting both events carry
falsewhen the tour did notcomplete.
Mutation-checked: hard-coding
tour_completed: truefails exactly that newcase, 11 others still pass.
typecheckandformat:checkclean.Why it's late
I drafted this as part of a Slack reply to you on 2026-08-04 and never sent
it, so you have never actually seen the offer. That's the failure, not the
telemetry. It was the one item in that draft still worth acting on — the rest
of it has since been overtaken (the nudge copy landed in #14677, and you've
since settled the OG image on #14957).
If you'd rather have the full ending instead of a boolean —
completedvsskippedwith itsskipReason— say so and I'll rework it; the controller hasengine.lastEndingand only exposes the boolean today. I went with the booleanbecause it needed no change to the controller's surface.