Repository navigation
fix: forward promoted widget value changes to the interior widget callback - #14956
claude[bot] wants to merge 1 commit into
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2040 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.92 MB gzip 🔴 +534 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • 🔴 +6 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • 🔴 +1.97 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 565 kB (baseline 565 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • 🔴 +12 BBundles that do not match a named category
Status: 73 added / 73 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-19T04:02:58.935Z",
"gitSha": "f3359af105af6872a4abe3755f92ddcd7c8c5314",
"branch": "fix/fe-14692-promoted-widget-callback",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2052.769000000012,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.313999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.213,
"heapDeltaBytes": 15390200,
"heapUsedBytes": 76333028,
"domNodes": -263,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.489,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.4430000000666,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.543000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.612,
"heapDeltaBytes": 5235920,
"heapUsedBytes": 67231140,
"domNodes": -263,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 13.104999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1795.831000000021,
"styleRecalcs": 76,
"styleRecalcDurationMs": 27.001000000000005,
"layouts": 14,
"layoutDurationMs": 4.1770000000000005,
"taskDurationMs": 798.294,
"heapDeltaBytes": -6389140,
"heapUsedBytes": 55026484,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 157.107,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1906.6540000000032,
"styleRecalcs": 79,
"styleRecalcDurationMs": 35.052,
"layouts": 14,
"layoutDurationMs": 4.867000000000001,
"taskDurationMs": 930.645,
"heapDeltaBytes": 15877824,
"heapUsedBytes": 77854236,
"domNodes": -260,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 179.148,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.9809999999948,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.990999999999998,
"layouts": 6,
"layoutDurationMs": 1.267,
"taskDurationMs": 314.876,
"heapDeltaBytes": 2099960,
"heapUsedBytes": 64151912,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.940999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.6810000000423,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.098999999999997,
"layouts": 6,
"layoutDurationMs": 1.23,
"taskDurationMs": 352.649,
"heapDeltaBytes": 2085408,
"heapUsedBytes": 64208652,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.163999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 606.7829999999503,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.136,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.057,
"heapDeltaBytes": 18229108,
"heapUsedBytes": 80021240,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 159.45800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 715.4100000000199,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.912999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.984,
"heapDeltaBytes": 18221288,
"heapUsedBytes": 79878520,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 173.31099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2015.9439999999904,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.756,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.80100000000004,
"heapDeltaBytes": 19737948,
"heapUsedBytes": 83296180,
"domNodes": -248,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.607000000000006,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2037.729000000013,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.548,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 644.9230000000001,
"heapDeltaBytes": 2779880,
"heapUsedBytes": 82839924,
"domNodes": -251,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 48.71399999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2232.0270000000164,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.629999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1616.479,
"heapDeltaBytes": -1629264,
"heapUsedBytes": 78844556,
"domNodes": -250,
"jsHeapTotalBytes": 1003520,
"scriptDurationMs": 844.8919999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2391.518000000019,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.244,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1608.572,
"heapDeltaBytes": 18439800,
"heapUsedBytes": 82906560,
"domNodes": 2,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 900.4369999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3498.108000000002,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.478000000000002,
"layouts": 60,
"layoutDurationMs": 12.212999999999997,
"taskDurationMs": 1601.7469999999998,
"heapDeltaBytes": 8490504,
"heapUsedBytes": 74287028,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 776.107,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3844.530000000077,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.096000000000002,
"layouts": 60,
"layoutDurationMs": 14.525,
"taskDurationMs": 1851.3899999999999,
"heapDeltaBytes": 8376260,
"heapUsedBytes": 74146644,
"domNodes": -259,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 863.161,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3051.3410000000363,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.656000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1883.396,
"heapDeltaBytes": 18123248,
"heapUsedBytes": 83533436,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 983.0210000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3218.691999999919,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.722999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2054.8010000000004,
"heapDeltaBytes": 19907392,
"heapUsedBytes": 87551032,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1033.1160000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1998.1690000000185,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.3560000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.545,
"heapDeltaBytes": 19636760,
"heapUsedBytes": 84054616,
"domNodes": -253,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.426000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1997.351999999978,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.117,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 652.3980000000001,
"heapDeltaBytes": 19654768,
"heapUsedBytes": 84047524,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.705,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 565.0989999999751,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.655999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.93699999999995,
"heapDeltaBytes": 14084776,
"heapUsedBytes": 77115536,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 143.067,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.2369999999783,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.873,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.462,
"heapDeltaBytes": 13641524,
"heapUsedBytes": 76752152,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 146.82199999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1991.6450000000054,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.137999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.414,
"heapDeltaBytes": 16153156,
"heapUsedBytes": 79296956,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.813999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.5680000000066,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.876999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.1980000000001,
"heapDeltaBytes": -7159436,
"heapUsedBytes": 55121808,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 12.026000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.5460000000267,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.205000000000002,
"layouts": 18,
"layoutDurationMs": 4.8149999999999995,
"taskDurationMs": 743.5740000000001,
"heapDeltaBytes": 11763916,
"heapUsedBytes": 73952880,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 105.831,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.3000000000238,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.063,
"layouts": 18,
"layoutDurationMs": 6.2440000000000015,
"taskDurationMs": 893.2009999999999,
"heapDeltaBytes": 18941616,
"heapUsedBytes": 81732912,
"domNodes": -277,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 127.89299999999997,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.5820000000467,
"styleRecalcs": 16,
"styleRecalcDurationMs": 28.789,
"layouts": 5,
"layoutDurationMs": 13.007000000000001,
"taskDurationMs": 887.2650000000002,
"heapDeltaBytes": -6413244,
"heapUsedBytes": 81199740,
"domNodes": 13587,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 28.845999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8258.568000000025,
"styleRecalcs": 247,
"styleRecalcDurationMs": 32.482,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5594.438999999999,
"heapDeltaBytes": -12680812,
"heapUsedBytes": 66951500,
"domNodes": -248,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 2761.724,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8727.758999999991,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.483000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6061.992,
"heapDeltaBytes": -3910100,
"heapUsedBytes": 75276936,
"domNodes": -246,
"jsHeapTotalBytes": -77824,
"scriptDurationMs": 2843.6820000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15756.950999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14950.528999999999,
"heapDeltaBytes": -32986708,
"heapUsedBytes": 188917960,
"domNodes": -8061,
"jsHeapTotalBytes": -15708160,
"scriptDurationMs": 279.06299999999993,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17074.11400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16649.192,
"heapDeltaBytes": -32463280,
"heapUsedBytes": 177512648,
"domNodes": -8061,
"jsHeapTotalBytes": -10817536,
"scriptDurationMs": 274.717,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20243.097000000034,
"styleRecalcs": 173,
"styleRecalcDurationMs": 16.13199999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19806.272999999997,
"heapDeltaBytes": -36466148,
"heapUsedBytes": 178606640,
"domNodes": -8061,
"jsHeapTotalBytes": -18550784,
"scriptDurationMs": 894.4479999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 70,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20745.304000000033,
"styleRecalcs": 153,
"styleRecalcDurationMs": 18.166000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20458.503,
"heapDeltaBytes": -46330068,
"heapUsedBytes": 167295000,
"domNodes": -8061,
"jsHeapTotalBytes": -13639680,
"scriptDurationMs": 920.5179999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 66,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6109.7950000000765,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.959,
"layouts": 20,
"layoutDurationMs": 22.852999999999998,
"taskDurationMs": 6031.754999999999,
"heapDeltaBytes": -59682464,
"heapUsedBytes": 175625192,
"domNodes": -8061,
"jsHeapTotalBytes": 15261696,
"scriptDurationMs": 108.91800000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 331,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6033.803999999918,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.86100000000002,
"layouts": 20,
"layoutDurationMs": 23.55800000000001,
"taskDurationMs": 5970.053,
"heapDeltaBytes": -35415724,
"heapUsedBytes": 173758704,
"domNodes": -8061,
"jsHeapTotalBytes": 9658368,
"scriptDurationMs": 135.241,
"eventListeners": -14928,
"totalBlockingTimeMs": 407,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8516.332000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8301.213,
"heapDeltaBytes": 6368628,
"heapUsedBytes": 177625200,
"domNodes": 0,
"jsHeapTotalBytes": -9699328,
"scriptDurationMs": 130.56600000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8196.46899999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7794.634999999999,
"heapDeltaBytes": -10205704,
"heapUsedBytes": 170055032,
"domNodes": 0,
"jsHeapTotalBytes": -27262976,
"scriptDurationMs": 118.147,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 467.8289999999379,
"styleRecalcs": 19,
"styleRecalcDurationMs": 23.744999999999997,
"layouts": 5,
"layoutDurationMs": 2.342,
"taskDurationMs": 128.27200000000002,
"heapDeltaBytes": 5231176,
"heapUsedBytes": 66875300,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.595999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 463.1580000000213,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.953000000000003,
"layouts": 3,
"layoutDurationMs": 1.308,
"taskDurationMs": 112.46900000000001,
"heapDeltaBytes": 4952592,
"heapUsedBytes": 66562540,
"domNodes": 148,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.237,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
c5f7335 to
cbea0bb
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #14956 +/- ##
==========================================
+ Coverage 82.77% 83.80% +1.02%
==========================================
Files 2936 2242 -694
Lines 144482 127652 -16830
Branches 39021 32472 -6549
==========================================
- Hits 119593 106977 -12616
+ Misses 23632 20385 -3247
+ Partials 1257 290 -967
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 705 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Context links for the architecture analysis behind this area:
Where this sits: #14495, #14488, #13601 and #11297 share one root cause — the promoted widget's value is keyed to the host ( Scope note, since #14961 has an open objection about writing to the shared interior widget: that objection does not apply here. CI green on |
c15e2ef to
f23539b
Compare
f23539b to
f3cc29a
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Two callback paths remain incorrect:
- source observers see stale values
- promoted multiline widgets bypass forwarding
Full context for agent readers
At this exact head, the existing focused suites pass 51/51. Two controlled assertions then fail: a source callback receives 99 but observes its captured source widget still at 42, and a promoted multiline textarea edit invokes the source callback zero times. A rerere-disabled synthetic merge with current main is clean.
Please preserve ADR 0009’s host-store authority while restoring callback compatibility; simply assigning the shared interior widget value would violate the isolation contract. Open draft #15869 overlaps this projection path and should preserve whichever host-safe callback contract lands here when it rebases.
| if (resolution.status !== 'resolved') return | ||
|
|
||
| const { node: sourceNode, widget: sourceWidget } = resolution.resolved | ||
| sourceWidget.callback?.(value, canvas, sourceNode, pos, e) |
There was a problem hiding this comment.
Source observers see stale values.
Full context for agent readers
This invokes the source callback after updating only the host widget store. Ordinary BaseWidget.setValue writes this.value before invoking the callback, and first-party callbacks such as useImageUploadWidget ignore callback arguments and read their captured widget value. A controlled assertion passed 99 to this callback but observed the source widget still at 42. Please provide a host-aware notification/projection contract (or equivalent) that preserves that observer behavior without making the shared interior widget authoritative.
There was a problem hiding this comment.
Fixed in the current head: invokePromotedWidgetSourceCallback (src/core/graph/subgraph/promotedInputWidget.ts) now writes the resolved source widget's .value before invoking its callback, mirroring BaseWidget.setValue's write-then-invoke order, then restores the widget's prior value once the callback returns (so the host store write stays the sole authoritative state per ADR-SUBGRAPH-PROMOTION-0009 — the write doesn't outlive the call, and doesn't leak into sibling hosts of the same subgraph definition). A first-party callback that reads its captured widget's own value (not the callback args) now sees the fresh value during the call.
| callback(next) { | ||
| callback(next, canvas, _node, pos, e) { | ||
| store.setValue(id, next) | ||
| invokePromotedWidgetSourceCallback(node, input, next, canvas, pos, e) |
There was a problem hiding this comment.
Specialized multiline widgets bypass this forwarding bridge.
Full context for agent readers
_setWidget selects createPromotedHostWidget(...) before _projectPromotedWidget(...). The multiline host writes only the host store, and its input handler invokes a host callback that is never wired to the source callback. A controlled textarea-input assertion observed zero source-callback calls. Please route specialized promoted widgets through the same host-safe callback contract and add multiline coverage.
There was a problem hiding this comment.
Fixed in the current head: the host-owned multiline (DOM textarea) promoted widget built by createPromotedMultilineWidget (src/renderer/extensions/vueNodes/widgets/utils/multilineTextarea.ts) now calls invokePromotedWidgetSourceCallback from its setValue, after the host store write, so it goes through the same forwarding bridge as the store-backed projection's callback instead of bypassing it.
…llback, extend forwarding to multiline Two gaps in the promoted-widget callback bridge (review feedback on #14956): - invokePromotedWidgetSourceCallback invoked the interior/source widget's callback before that widget's own `.value` was updated, so callbacks that read their captured widget's `.value` directly (e.g. useImageUploadWidget) observed a stale value. It now writes sourceWidget.value first, mirroring BaseWidget.setValue's own write-then-invoke order. The host widgetValueStore entry stays the sole authoritative value (ADR-0009); this only mirrors that value onto the interior widget instance. - Multiline (customtext) promoted widgets are built by createPromotedMultilineWidget as a host-owned DOM widget, bypassing the store-backed projection whose callback wires this forwarding bridge. Its own edit path never reached the interior widget's callback. setValue now calls invokePromotedWidgetSourceCallback too, after writing the host store. Fixes #14692
This comment has been minimized.
This comment has been minimized.
…lback promotedInputWidget() and SubgraphNode._projectPromotedWidget() project a promoted input into a store-backed widget descriptor whose callback only called store.setValue, so custom node extensions relying on widget.callback for dependent state never fired. invokePromotedWidgetSourceCallback resolves the concrete interior source widget and invokes its callback with the same signature BaseWidget.setValue uses. It writes the source widget's value before invoking the callback and restores the prior value afterward, so observers that read their captured widget's own .value (instead of the callback args) see the fresh value without making the shared interior widget authoritative across sibling hosts (ADR-SUBGRAPH-PROMOTION-0009). The host-owned multiline (DOM textarea) promoted widget bypassed this bridge entirely since it never wires the store-backed projection's callback; its setValue now also calls invokePromotedWidgetSourceCallback. Fixes #14692
e9fcb1d to
efac7a9
Compare
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
DrJKL
left a comment
There was a problem hiding this comment.
PR 14956 initial review
Pre-merge blocker
- P1: The new bridge invokes arbitrary extension behavior on the shared
interior widget and node. Linked hosts of one subgraph definition therefore
share every callback side effect. Thefinallyrestores only the source
widget value, not dependent widget options/values, node properties, requests,
or delayed work. An async callback also sees the restored old value after its
firstawait. A cloned subgraph has an independent definition, but every host
linked to that clone shares within it. This needs a host-WidgetId-scoped
behavior boundary as described by ECS-WIDGETS-0023, plus linked, cloned, and
nested regression cases.
Findings without an inline anchor
- P2: The PR description says promoted and interior edits notify extensions
identically. The bridge invokes onlywidget.callback; ordinary
BaseWidget.setValuealso appliessetProperty, callsonWidgetChanged, and
increments the graph version. Narrow the claim to callback argument
compatibility.
Existing findings
- The old stale captured-value finding is addressed for synchronous callbacks:
the source value is assigned before invocation and restored afterward. - The old multiline bypass finding is addressed: multiline
setValuenow
enters the forwarding bridge after the host store write.
Checked and cleared
- Synchronous sibling-host re-entry unwinds in LIFO order, and callback throws
restore the source value. The focused experiment passed 3/3 cases. Subgraph.clone()creates an independent graph ID and remapped nodes, so
clones do not share source widget objects. Linked hosts do.- The PR does not add entity state or methods to
LGraphNode,SubgraphNode,
LGraph, orSubgraph. promotedInputWidgetis an internal source module, so its required parameter
change is not a supported public API break.
Coverage
Standard review. Correctness, maintainability, TypeScript/Vue idiomaticity,
tests, Playwright structure, and documentation lanes ran. I checked
ECS-0008, ECS-WIDGETS-0023, ECS-SLOTS-0017, and SUBGRAPH-PROMOTION-0009. There
is no ADR named SLOP in this repository, so I did not invent one. Focused unit
baseline: 56/56 passed. Fallow found no changed-code clone finding; its
architecture guard has no configured zones.
| const priorValue = sourceWidget.value | ||
| sourceWidget.value = value | ||
| try { | ||
| sourceWidget.callback?.(value, canvas, sourceNode, pos, e) |
There was a problem hiding this comment.
[P1] Keep callback effects scoped to the host. Every host linked to one subgraph definition resolves this same source widget and source node. Restoring sourceWidget.value protects only that one field after a synchronous return; the callback can mutate dependent widget values/options, node properties, or other shared extension state, and the cascading-selector case in #14692 is exactly that kind of side effect. Async callbacks can also race across hosts, and a callback that rereads the captured widget after await sees the restored old value. Cloned definitions are independent, but all hosts linked to a given clone still share its interior objects. Please route this through a host-WidgetId-scoped behavior adapter/projection, consistent with ECS-WIDGETS-0023, rather than invoking arbitrary behavior against the shared definition object. Add linked-host, cloned-definition, and nested-host regression cases with distinct values.
|
|
||
| test.describe('Promoted Widget Reactivity', { tag: ['@vue-nodes'] }, () => { | ||
| // https://github.com/Comfy-Org/ComfyUI_frontend/issues/14495 | ||
| test.fail( |
There was a problem hiding this comment.
[P2] Remove this unrelated expected failure from the callback fix. This flow does not invoke or observe the new callback bridge, and the comment below says #14495 predates this PR. Keeping it here adds a suite obligation that will turn red when a separate synchronization fix lands. Please move it to the #14495 change, or replace it here with a passing linked-host callback isolation E2E.
| sourceWidget: textareaSource() | ||
| }) | ||
| const element = ( | ||
| widget as unknown as DOMWidget<HTMLTextAreaElement, string> |
There was a problem hiding this comment.
[P3] Narrow this with the existing isDOMWidget guard instead of using a double assertion. The TypeScript guidance explicitly forbids double assertions in tests, and the guard also makes the factory return assumption visible before .element is read.
| setValue: (value: string) => { | ||
| element.value = value | ||
| widgetStore.setValue(widgetId, value) | ||
| // Being a host-owned DOM widget (not the store-backed projection |
There was a problem hiding this comment.
[P3] Delete this nine-line narration. The named helper and statement order already show that the host store write precedes callback forwarding, while the helper JSDoc owns the cross-path rationale. Keeping a second explanation here couples this renderer utility to _projectPromotedWidget internals and gives the invariant two prose copies to maintain.
Requested by Christian Byrne
Summary
Promoted subgraph widget edits only wrote to
widgetValueStore, never forwarding to the interior widget'scallback, so custom node extensions relying onwidget.callbackfor dependent state (e.g. a promoted project selector refreshing a downstream task selector) never fired.Changes
promotedInputWidget()(src/core/graph/subgraph/promotedInputWidget.ts) andSubgraphNode._projectPromotedWidget()both project a promoted input into a store-backed widget descriptor whosecallbackpreviously only calledstore.setValue. AddedinvokePromotedWidgetSourceCallback, which resolves the concrete interior source widget (via the existingresolveConcretePromotedWidgettraversal, so it also works through nested subgraphs) and invokes itscallbackwith the same(value, canvas, node, pos, e)signatureBaseWidget.setValueuses for ordinary widgets. Both projection sites now call it afterstore.setValue, so promoted-widget edits and interior-widget edits notify extensions identically.promotedInputWidget()gained a requirednodeparameter (needed to resolve the interior source); all call sites were updated.Review Focus
invokePromotedWidgetSourceCallbackforwardscanvas/pos/ethrough from the transient concrete widget's callback invocation, so extensions that inspect those get the same values they'd see on a non-promoted widget.BaseWidget.setValuealready invokescallbackafter committing state.Fixes #14692