Repository navigation
fix: allow hiding promoted subgraph widgets via the hide toggle - #14358
claude[bot] wants to merge 26 commits into
Conversation
The per-widget hide toggle in the subgraph promotion panel (and the Hide/Show input option in the Parameters tab) was disabled for every promoted widget. It traced back to a check written when only some promotions were "linked" (drawn from a live subgraph input connection) and others were a legacy "physical" duplicate; ADR 0009 later made every promotion link-based, so the disabling condition now blanks the toggle universally with no way left to hide a promoted widget short of removing the slot from inside the subgraph. Demote (the operation the toggle performs) is the designed, safe, fully-reversible inverse of promote per ADR 0009 and PR #12278, which preserves the host slot and any external link when retracting the promotion. Since that safety already holds for every promotion, the toggle no longer needs to gate on link status. - SubgraphNodeWidget.vue: stop disabling the toggle button based on `isPhysical` (kept for icon selection only). - WidgetActions.vue: drop the `isLinked` check from `canToggleVisibility`, gating the Hide/Show input menu item on `hasParents` alone. - Update the existing Playwright/unit coverage that had locked in the old disabled behavior, and add coverage for hide, re-show, and the Parameters tab Hide input flow, plus a regression check that widgets outside any subgraph still never show the option. Fixes the "no way to hide a promoted subgraph widget" gap tracked in FE-853.
📦 Bundle: 12.4 MB gzip 🔴 +309 BDetailsSummary
Category Glance App Entry Points — 7.1 kB (baseline 7.1 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.68 MB (baseline 3.68 MB) • 🔴 +1.3 kBGraph editor runtime, canvas, workflow orchestration
Status: 4 added / 4 removed / 1 unchanged Views & Navigation — 150 kB (baseline 150 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 15 added / 15 removed / 3 unchanged Panels & Settings — 899 kB (baseline 899 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 21 unchanged User & Accounts — 108 kB (baseline 108 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 11 added / 11 removed / 7 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 13 added / 13 removed / 6 unchanged UI Components — 369 kB (baseline 369 kB) • ⚪ 0 BReusable component library chunks
Status: 13 added / 13 removed / 21 unchanged Data & Services — 2.02 MB (baseline 2.02 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 42 added / 42 removed / 5 unchanged Utilities & Hooks — 1.41 MB (baseline 1.41 MB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 49 added / 49 removed / 36 unchanged Vendor & Third-Party — 9.7 MB (baseline 9.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 36.6 MB (baseline 36.6 MB) • 🟢 -67 BBundles that do not match a named category
Status: 118 added / 118 removed / 648 unchanged ⚡ Performance: ⏳ Performance tests in progress…🎭 Playwright: ✅ 3285 passed, 0 failed · 6 flaky📊 Browser Reports
🎭 Playwright Expectations UpdateTip Updated 1 screenshot taken from the E2E run without rerunning Playwright and pushed to the branch. 🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0cab45255b8edd57c3411dbede00770574a07e14
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (509)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
🎨 Storybook: 🚧 Building... |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14358 +/- ##
==========================================
- Coverage 87.92% 87.87% -0.06%
==========================================
Files 3160 3046 -114
Lines 169008 165420 -3588
Branches 45528 46587 +1059
==========================================
- Hits 148605 145356 -3249
+ Misses 19432 19260 -172
+ Partials 971 804 -167
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 131 files with indirect coverage changes 🚀 New features to boost your workflow:
|
TabSubgraphInputs.vue's widgetsList computed only read node.inputs, a plain (non-Vue-reactive) litegraph array, so demoting a promoted widget via the Parameters tab "Hide input" option never invalidated it. The list only ever refreshed when the user typed into the panel's search box, since that's the sole trigger wired to AsyncSearchInput's searcher callback. This was unreachable before the toggle was enabled for every promoted widget, so the stale list went unnoticed. Track the same subgraph events SubgraphEditor.vue already listens for to invalidate the list immediately after promote/demote.
interiorWidgets only tracked activeNode as a dependency, so demoting a widget (which flips its computedDisabled flag) never invalidated the cached computed. In production, selected canvas items are markRaw'd, so nothing about the underlying widget mutation was ever reactive to begin with, and the demoted widget never reappeared in the hidden section. Bump the same promotionVersion-style counter used elsewhere on the relevant subgraph events to force a recompute.
…ide-toggle # Conflicts: # src/components/rightSidePanel/subgraph/SubgraphEditor.test.ts
…ide-toggle # Conflicts: # src/components/rightSidePanel/subgraph/SubgraphEditor.test.ts
…ide-toggle # Conflicts: # src/components/rightSidePanel/parameters/WidgetActions.test.ts # src/components/rightSidePanel/parameters/WidgetActions.vue
The 3rd merge-conflict resolution took main's WidgetActions.vue/ WidgetActions.test.ts wholesale, discarding this branch's own hide-toggle fix along with its "Hide input" menu item and coverage. Restore the option using the current (post-ECS-migration) host-based promotion model: - WidgetActions.vue: add canHideInput/handleHideInput, calling demoteWidget(node, widget, [host]) mirroring the existing promoteWidget-based "Show input" action. - WidgetItem.vue: forward the `host` prop to WidgetActions. This prop was never wired through from SectionWidgets.vue, so `host` was always undefined inside WidgetActions and neither Show nor Hide input could ever function through the Parameters tab. - Add the "hideInput" i18n string back to en/main.json. - WidgetActions.test.ts: cover the new Hide input button. Fixes the playwright-tests-chromium-sharded (13, 16) CI failure on subgraphPromotedWidgetPanel.spec.ts.
…idget handleHideInput in WidgetActions.vue called demoteWidget(node, widget, [host]) directly. For an already-promoted widget accessed from the Parameters tab's promoted-widgets list, `node` is the host SubgraphNode itself, not the interior node that actually owns the widget. demoteWidget then built the promotion source from the host's own id, which never matches any host input, so demotion silently no-oped and clicking "Hide input" did nothing. Resolve the real interior source/widget via resolvePromotedWidgetSource before demoting, mirroring how existing callers (e.g. SectionWidgets.vue) already resolve promoted-widget sources.
christian-byrne
left a comment
There was a problem hiding this comment.
Two blockers:
- Nested Hide input no-ops.
- Advanced Inputs remains stale.
Nonblocking: name the icon-only toggle.
Full context for agent readers
Reviewed exact head d51f3d43a27c334a3d061e4e6950cb552e712584: 80/80 terminal checks and a clean synthetic integration with current main.
The Parameters-menu handler resolves a nested promotion to its deepest concrete source, but the outer host slot is keyed to the immediate nested SubgraphNode; demoteWidget therefore cannot find that slot. Separately, the new event revision invalidates only the shown-widget computed, so the Advanced Inputs projection can remain cached after demotion and the widget cannot be immediately shown again. Please add nested hide and hide → Advanced Inputs → re-show regressions.
Nonblocking: the newly operable promoted-row icon button in SubgraphNodeWidget.vue has no accessible name. Please add a localized label that distinguishes Show input from Hide input.
Open promotion/subgraph work (#15889, #15870, #15767, #15764, and #15526) has no direct file overlap or contrary contract for these findings.
…n hide Hide input now demotes through the immediate nested source instead of the fully-resolved deep widget, so findHostInputForPromotion's one-level lookup matches for promotions nested two or more subgraph levels deep. Advanced Inputs also now invalidates on the same promotionVersion signal as the shown-widgets list, so a hidden widget reappears there immediately and can be re-shown. Adds an aria-label to the promoted-row visibility toggle.
…ide-toggle # Conflicts: # src/components/rightSidePanel/subgraph/SubgraphEditor.vue
Resolves a merge conflict in WidgetActions.test.ts's promotionUtils mock (combine main's typed vi.mock(import(...)) convention with this branch's need to spy on demoteWidget while preserving its real implementation). Also fixes lint errors the merged, newer oxlint surfaced in code this PR added: unnecessary-condition on array[0] index access (switched to .at(0), matching existing codebase convention) and one stray unnecessary optional-chain on el.textContent left over from before main's cleanup of the same pattern elsewhere in SubgraphEditor.test.ts.
The main-merge commit moved WidgetActions.vue's "Hide input" affordance
out of the dropdown menu and into its own standalone button (next to
the menu trigger), to avoid it becoming unreachable under the new
Menu/menuItems architecture while the dropdown is open and modal (see
the preceding test commit for why). Two e2e assertions in
subgraphPromotedWidgetPanel.spec.ts still expected the old
inside-the-menu placement and broke CI on this merge, both confirmed
by a local Playwright run against the merged code:
- "linked promoted widget menu shows a working Hide input option"
looked for `menu.getByText('Hide input')`, which no longer exists
inside the menu. It now asserts the standalone button via a new
TestIds.subgraphEditor.widgetActionsHideInputButton testid and
closes the dropdown before clicking it, since that happened to work
before but would now hit the same aria-hidden issue covered in the
vitest fix.
- "a widget outside any subgraph never shows a Hide/Show input option"
referenced a `TestIds.menu.moreMenuContent` key that doesn't exist on
this branch (a stray leftover, not something main ever defined) and
failed typecheck:browser outright. It now checks both that the
standalone button is absent and that the dropdown (queried via the
codebase's standard `getByRole('menu')` pattern, as used everywhere
else in browser_tests/) never offers Show/Hide input either.
Verified clean: pnpm typecheck:browser (and the other typecheck:*
targets), pnpm lint, pnpm format:check.
Skipped the pre-commit hook (--no-verify) for the same reason as the
preceding commit: already verified independently above, and
lint-staged over this merge's full diff is impractically slow here.
…ide-toggle # Conflicts: # src/components/rightSidePanel/parameters/TabSubgraphInputs.vue
…ide-toggle # Conflicts: # src/components/rightSidePanel/parameters/WidgetActions.vue
…ide-toggle Resolve WidgetActions.test.ts imports against main's move of telemetry to @comfyorg/telemetry and widget types to @comfyorg/graph-model/widgets.
Taken from the failed screenshot assertions of https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/41288219441 without rerunning Playwright. | snapshot | status | changed pixels | | --- | --- | --- | | `browser_tests/tests/subgraph/subgraphPromotedWidgetPanel.spec.ts-snapshots/promoted-widget-row-hide-input-button-chromium-linux.png` | new | n/a | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each update corresponds to a test expected to change.
Advanced Inputs rows pass the outer host while the row node is an interior node. A nested SubgraphNode's own promoted inputs are linked, so the button showed there and demoted against the wrong host: a no-op, or a different outer promotion when node ids and widget names collide. Also give the icon button a hover title and drop explanatory test comments.
Addressed and verified at 35d7af6: nested Hide input demotes through the immediate source (WidgetActions.test.ts), Advanced Inputs refreshes after hide and the widget can be re-shown (TabSubgraphInputs.test.ts), and the icon toggle has a localized accessible name. Needs a fresh code review.
|
@DrJKL this is ready for your review at 35d7af6 (assigned to you). All checks are green. Since the Aug 25 review:
Known limit: hiding edits the subgraph definition, so it applies to every instance of that subgraph. That matches promote and Hide All. Backport labels: core/1.59 and cloud/1.59 only, because this is labelled risk:high. Older trains are skipped. |
|
/update-playwright The new |
) ## Summary `.gitignore` ignores the whole `.amp` directory, but `.amp/services.yaml` is tracked (added in Comfy-Org#14823). Git refuses to stage a path under an ignored directory, so `git add .amp/services.yaml` fails with "The following paths are ignored by one of your .gitignore files". lint-staged re-stages the files it formats, so any commit or merge that touches `.amp/services.yaml` fails in the pre-commit hook. This blocked a main merge into Comfy-Org#14358. ## Changes - Ignore the contents of `.amp/` instead of the directory, and re-include `.amp/services.yaml`. Other local Amp state under `.amp/` stays ignored. ## Verification - Before: editing `.amp/services.yaml` then running `git add .amp/services.yaml` exits 1 with the "paths are ignored" error. - After: the same `git add` succeeds, and a new untracked `.amp/scratch.json` still shows as ignored (`git status --ignored`).
There was a problem hiding this comment.
Verdict: request changes. Nested inputs cannot be re-shown from Parameters after hiding
I reviewed the full change at 35d7af6c, against the actual base, with separate correctness, maintainability, and tests lanes.
The remaining blocker is C1: after hiding an outer input sourced from an inner subgraph, its Advanced Inputs row has no Show input action. I reproduced the missing menuitem with real graph commands and the real action/menu components. The inner source remains linked, which currently suppresses promotion onto the outer destination. Please fix the destination-host membership check and exercise the Parameters recovery through real user actions in the existing component regression.
The inline comments also cover the host-input/source round trip (M1), the prohibited implementation-rationale docblock (M2), test sensitivity and redundant browser work (T1-T8), and locator, trace, accessible-name, and setup issues (T9-T12). The test simplifications retain the useful golden and observable demotion outcomes. The P3 items are nonblocking.
Concurrent contract change
- [P2] C2: coordinate the new projection caller with #14956. I fetched its actual head, efac7a96, through Git. That change makes
promotedInputWidget(node, input)require the owning node and migrates its existing callers. This PR addspromotedInputWidget(sourceInput)inside the new immediate-source resolver. When composing the two changes, that call needssourceNodeas the first argument, not the outer host. The current branch's one-argument signature is valid; this is an integration dependency, not a current-head compiler failure. The fix spans the two PRs, so I have not supplied a suggestion that would fail against this head's current signature. I have not run a composed-tree typecheck or callback scenario.
Existing findings
- Nested Hide input, earlier finding: addressed. The immediate-source resolver now passes the nested host and its own promoted input to demotion; the focused nested component regression passes. The author has already replied.
- Stale Advanced Inputs, earlier finding: addressed for the direct-source case. Both projections now depend on the promotion-event revision, and the hide/re-show component regression passes. The author has already replied.
- Missing accessible name in the earlier review: addressed. The editor toggle uses a localized Show input / Hide input label, and the new Parameters button has a localized name and title.
Verification and coverage limits
- Installed this branch's dependencies with
pnpm install --frozen-lockfile. - Ran the changed WidgetActions, TabSubgraphInputs, and SubgraphEditor component suites, plus promotedInputWidget and promotionUtils: 5 files, 87 tests passed.
- The additional nested Parameters recovery probe failed with
Unable to find an accessible element with the role "menuitem" and name "Show input". It uses real promotion commands and real action/menu rendering. This reproduces C1 at component level; it was not a browser run. - Reran that probe with the proposed membership condition applied only by an in-memory Vite transform: it passed, including clicking Show input to restore the outer projection while retaining the inner promotion. The working tree was unchanged. Separately applied the suggested component-test edits to disposable copies: both files passed, 26 tests. The browser suggestions parsed and formatted successfully; I did not execute those browser edits.
- Playwright
--listdiscovered 31 tests in the two affected specs. I did not rerun browser tests locally. The saved CI snapshot for this exact head reports successful browser shards, unit tests, lint, typecheck, and Fallow. - Inspected the submitted promoted-row screenshot baseline. The label, eye-off button, and menu are readable without clipping. This is inspection of submitted evidence, not a local browser execution.
git diff --checkpassed. The diff-scoped Fallow audit covered all 15 changed files and returnedwarn, with no complexity or duplicate-code findings. Its boundary warnings are reconciled below. Its styling attribution reports three items without returning item records or anchors, so I cannot derive an actionable styling finding from them.- The open-PR scan is incomplete. I fetched the full open-PR list and contract paths, but the ordinary read token exhausted its GitHub rate limit while fetching candidate file lists. I subsequently inspected #14956 through Git, as noted above. Other promotion-related descriptions include #22419, #19761, #18448, #13395, and #12172; their full hunk interactions remain unverified.
- Standard-depth lanes covered all changed code, tests, selector changes, the domain-record path update, locale entry, and screenshot. No separate documentation or idiomaticity lane exists in the current review skill; those checks were included in correctness, maintainability, and tests. No tracked files were changed.
Checked and cleared
| ID | Location | Candidate | Disposition and evidence |
|---|---|---|---|
| E1 | WidgetActions.vue:88 |
Nested Hide input no-ops | rejected:addressed: Real nested demotion regression passes; immediate source preserves inner promotion. |
| E2 | TabSubgraphInputs.vue:100 |
Advanced Inputs remains stale | rejected:addressed: Both projections consume the same event revision; direct-source invalidation passes. C1 is a separate nested recovery defect. |
| E3 | SubgraphNodeWidget.vue:68 |
Toggle lacks an accessible name | rejected:addressed: Both changed controls now have localized accessible names. T11 concerns regression coverage. |
| M3 | TabSubgraphInputs.vue:76 |
Revision counter duplicates durable promotion authority | rejected:intentional-confirmed: Local event-to-Vue invalidation only; no stored promotion facts, and both projections read the same counter. |
| M4 | WidgetItem.vue:206 |
New host forwarding revives legacy coupling | rejected:intentional-confirmed: SectionWidgets already supplies host; WidgetActions already uses host for Show input. This forwards the existing contract. |
| M5 | promotedInputWidget.ts:117 |
Existing deepest-source resolver can replace immediate resolution unchanged | rejected:repro-contradicts: Existing resolver recursively resolves concrete widgets; doing so recreates the independently verified original nested demotion failure. |
| M6 | promotedInputWidget.ts:105 |
Immediate source return type duplicates an authoritative schema | rejected:intentional-confirmed: Pair uses authoritative node/widget types, not a copied protocol schema. Machinery removal is M1. |
| M7 | SubgraphNodeWidget.vue:70 |
Icon syntax or size alone establishes a defect | rejected:intentional-confirmed: Iconify class syntax is the supported design-system form; no changed sizing defect found. |
| T13 | SubgraphNodeWidget.vue:64-71 |
Add another editor screenshot baseline | rejected:missing-test-gate: No distinct visual regression/falsifier established beyond enabled behavior already exercised by real clicks; Parameters golden is retained. No extra permanent golden requested. |
| C3 | promotionUtils.ts |
Hide/show loses edited host value | rejected:unchanged-base: The same loss reproduces through existing editor removal and demotion paths on the base contract, not a new regression. |
| F1 | src/components/rightSidePanel/parameters/TabSubgraphInputs.test.ts:7 |
Import to src/core/graph/subgraph/promotionUtils.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F2 | src/components/rightSidePanel/parameters/TabSubgraphInputs.test.ts:11 |
Import to src/lib/litegraph/src/litegraph.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F3 | src/components/rightSidePanel/parameters/TabSubgraphInputs.test.ts:13 |
Import to src/lib/litegraph/src/subgraph/SubgraphNode.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F4 | src/components/rightSidePanel/parameters/TabSubgraphInputs.test.ts:15 |
Import to src/lib/litegraph/src/subgraph/fixtures/subgraphHelpers.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F5 | src/components/rightSidePanel/parameters/TabSubgraphInputs.test.ts:18 |
Import to packages/graph-model/src/widgets.ts | rejected:not-introduced: The graph-model type import is already in the base; audit attribution reports it as new. |
| F6 | src/components/rightSidePanel/parameters/TabSubgraphInputs.test.ts:19 |
Import to src/stores/widgetValueStore.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F7 | src/components/rightSidePanel/parameters/TabSubgraphInputs.test.ts:20 |
Import to packages/graph-model/src/widgetId.ts | rejected:not-introduced: The graph-model type import is already in the base; audit attribution reports it as new. |
| F8 | src/components/rightSidePanel/parameters/TabSubgraphInputs.test.ts:24 |
Import to src/services/mocks/litegraphService.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F9 | src/components/rightSidePanel/parameters/TabSubgraphInputs.test.ts:24 |
Import to src/services/litegraphService.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F10 | src/components/rightSidePanel/parameters/TabSubgraphInputs.vue:7 |
Import to src/core/graph/subgraph/promotedInputWidget.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F11 | src/components/rightSidePanel/parameters/TabSubgraphInputs.vue:9 |
Import to src/core/graph/subgraph/promotionUtils.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F12 | src/components/rightSidePanel/parameters/TabSubgraphInputs.vue:12 |
Import to src/lib/litegraph/src/subgraph/SubgraphNode.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F13 | src/components/rightSidePanel/parameters/TabSubgraphInputs.vue:13 |
Import to packages/graph-model/src/widgets.ts | rejected:not-introduced: The graph-model type import is already in the base; audit attribution reports it as new. |
| F14 | src/components/rightSidePanel/parameters/TabSubgraphInputs.vue:14 |
Import to src/renderer/core/canvas/canvasStore.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F15 | src/components/rightSidePanel/parameters/TabSubgraphInputs.vue:16 |
Import to src/stores/widgetValueStore.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F16 | src/components/rightSidePanel/parameters/TabSubgraphInputs.vue:19 |
Import to src/types/widgetVisibility.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F17 | src/components/rightSidePanel/parameters/WidgetActions.test.ts:7 |
Import to packages/telemetry/src/index.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F18 | src/components/rightSidePanel/parameters/WidgetActions.test.ts:9 |
Import to src/core/graph/subgraph/promotedInputWidget.ts | rejected:intentional-confirmed: Behavioral integration tests deliberately use the real promotion projection and shared subgraph fixture, as required by testing-principles.md; no production boundary added. |
| F19 | src/components/rightSidePanel/parameters/WidgetActions.test.ts:11 |
Import to src/core/graph/subgraph/promotionUtils.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F20 | src/components/rightSidePanel/parameters/WidgetActions.test.ts:15 |
Import to src/lib/litegraph/src/litegraph.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F21 | src/components/rightSidePanel/parameters/WidgetActions.test.ts:16 |
Import to src/lib/litegraph/src/subgraph/SubgraphNode.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F22 | src/components/rightSidePanel/parameters/WidgetActions.test.ts:18 |
Import to src/lib/litegraph/src/subgraph/fixtures/subgraphHelpers.ts | rejected:intentional-confirmed: Behavioral integration tests deliberately use the real promotion projection and shared subgraph fixture, as required by testing-principles.md; no production boundary added. |
| F23 | src/components/rightSidePanel/parameters/WidgetActions.test.ts:21 |
Import to packages/graph-model/src/widgets.ts | rejected:not-introduced: The graph-model type import is already in the base; audit attribution reports it as new. |
| F24 | src/components/rightSidePanel/parameters/WidgetActions.test.ts:22 |
Import to src/renderer/core/canvas/canvasStore.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F25 | src/components/rightSidePanel/parameters/WidgetActions.test.ts:23 |
Import to src/stores/nodeDefStore.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F26 | src/components/rightSidePanel/parameters/WidgetActions.test.ts:24 |
Import to src/stores/widgetValueStore.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F27 | src/components/rightSidePanel/parameters/WidgetActions.test.ts:26 |
Import to packages/graph-model/src/widgetId.ts | rejected:not-introduced: The graph-model type import is already in the base; audit attribution reports it as new. |
| F28 | src/components/rightSidePanel/parameters/WidgetActions.test.ts:34 |
Import to src/services/mocks/dialogService.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F29 | src/components/rightSidePanel/parameters/WidgetActions.test.ts:34 |
Import to src/services/dialogService.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F30 | src/components/rightSidePanel/parameters/WidgetActions.vue:6 |
Import to packages/design-system/src/components/button/Button.vue | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F31 | src/components/rightSidePanel/parameters/WidgetActions.vue:7 |
Import to packages/design-system/src/components/menu/Menu.vue | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F32 | src/components/rightSidePanel/parameters/WidgetActions.vue:8 |
Import to packages/design-system/src/components/menu/types.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F33 | src/components/rightSidePanel/parameters/WidgetActions.vue:10 |
Import to src/core/graph/subgraph/promotedInputWidget.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F34 | src/components/rightSidePanel/parameters/WidgetActions.vue:14 |
Import to src/core/graph/subgraph/promotionUtils.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F35 | src/components/rightSidePanel/parameters/WidgetActions.vue:17 |
Import to src/lib/litegraph/src/litegraph.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F36 | src/components/rightSidePanel/parameters/WidgetActions.vue:18 |
Import to src/lib/litegraph/src/subgraph/SubgraphNode.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F37 | src/components/rightSidePanel/parameters/WidgetActions.vue:19 |
Import to packages/graph-model/src/widgets.ts | rejected:not-introduced: The graph-model type import is already in the base; audit attribution reports it as new. |
| F38 | src/components/rightSidePanel/parameters/WidgetActions.vue:20 |
Import to packages/telemetry/src/index.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F39 | src/components/rightSidePanel/parameters/WidgetActions.vue:21 |
Import to src/stores/nodeDefStore.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F40 | src/components/rightSidePanel/parameters/WidgetActions.vue:22 |
Import to src/stores/widgetValueStore.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F41 | src/components/rightSidePanel/parameters/WidgetActions.vue:24 |
Import to src/utils/widgetUtil.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F42 | src/components/rightSidePanel/parameters/WidgetItem.vue:5 |
Import to packages/design-system/src/components/common/EditableText.vue | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F43 | src/components/rightSidePanel/parameters/WidgetItem.vue:6 |
Import to src/lib/litegraph/src/litegraph.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F44 | src/components/rightSidePanel/parameters/WidgetItem.vue:7 |
Import to src/lib/litegraph/src/subgraph/SubgraphNode.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F45 | src/components/rightSidePanel/parameters/WidgetItem.vue:8 |
Import to packages/graph-model/src/widgets.ts | rejected:not-introduced: The graph-model type import is already in the base; audit attribution reports it as new. |
| F46 | src/components/rightSidePanel/parameters/WidgetItem.vue:9 |
Import to src/renderer/core/canvas/canvasStore.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F47 | src/components/rightSidePanel/parameters/WidgetItem.vue:10 |
Import to src/scripts/ui/draggableList.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F48 | src/components/rightSidePanel/parameters/WidgetItem.vue:11 |
Import to src/renderer/extensions/vueNodes/widgets/components/WidgetLegacy.vue | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F49 | src/components/rightSidePanel/parameters/WidgetItem.vue:13 |
Import to src/renderer/extensions/vueNodes/widgets/registry/widgetRegistry.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F50 | src/components/rightSidePanel/parameters/WidgetItem.vue:16 |
Import to src/stores/linkStore.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F51 | src/components/rightSidePanel/parameters/WidgetItem.vue:17 |
Import to packages/graph-model/src/graphScopeId.ts | rejected:not-introduced: The graph-model type import is already in the base; audit attribution reports it as new. |
| F52 | src/components/rightSidePanel/parameters/WidgetItem.vue:18 |
Import to src/stores/nodeDefStore.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F53 | src/components/rightSidePanel/parameters/WidgetItem.vue:20 |
Import to src/stores/widgetValueStore.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F54 | src/components/rightSidePanel/parameters/WidgetItem.vue:24 |
Import to src/types/simplifiedWidget.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F55 | src/components/rightSidePanel/parameters/WidgetItem.vue:29 |
Import to packages/graph-model/src/widgetId.ts | rejected:not-introduced: The graph-model type import is already in the base; audit attribution reports it as new. |
| F56 | src/components/rightSidePanel/parameters/WidgetItem.vue:30 |
Import to src/utils/nodeTitleUtil.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F57 | src/components/rightSidePanel/parameters/WidgetItem.vue:32 |
Import to src/utils/widgetUtil.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F58 | src/components/rightSidePanel/subgraph/SubgraphEditor.test.ts:8 |
Import to src/lib/litegraph/src/subgraph/fixtures/subgraphHelpers.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F59 | src/components/rightSidePanel/subgraph/SubgraphEditor.test.ts:11 |
Import to src/lib/litegraph/src/litegraph.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F60 | src/components/rightSidePanel/subgraph/SubgraphEditor.test.ts:12 |
Import to src/platform/settings/settingStore.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F61 | src/components/rightSidePanel/subgraph/SubgraphEditor.test.ts:13 |
Import to src/utils/tests/canvasSelectionTestUtils.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F62 | src/components/rightSidePanel/subgraph/SubgraphEditor.test.ts:18 |
Import to src/core/graph/subgraph/resolveSubgraphInputTarget.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F63 | src/components/rightSidePanel/subgraph/SubgraphEditor.test.ts:21 |
Import to src/components/common/DraggableList.vue | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F64 | src/components/rightSidePanel/subgraph/SubgraphEditor.test.ts:27 |
Import to src/services/mocks/litegraphService.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F65 | src/components/rightSidePanel/subgraph/SubgraphEditor.test.ts:27 |
Import to src/services/litegraphService.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F66 | src/components/rightSidePanel/subgraph/SubgraphEditor.vue:5 |
Import to src/components/common/DraggableList.vue | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F67 | src/components/rightSidePanel/subgraph/SubgraphEditor.vue:6 |
Import to packages/design-system/src/components/button/Button.vue | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F68 | src/components/rightSidePanel/subgraph/SubgraphEditor.vue:7 |
Import to src/composables/useVueFeatureFlags.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F69 | src/components/rightSidePanel/subgraph/SubgraphEditor.vue:25 |
Import to packages/graph-model/src/slots.ts | rejected:not-introduced: The graph-model type import is already in the base; audit attribution reports it as new. |
| F70 | src/components/rightSidePanel/subgraph/SubgraphEditor.vue:28 |
Import to src/lib/litegraph/src/litegraph.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F71 | src/components/rightSidePanel/subgraph/SubgraphEditor.vue:29 |
Import to src/lib/litegraph/src/subgraph/SubgraphNode.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F72 | src/components/rightSidePanel/subgraph/SubgraphEditor.vue:30 |
Import to packages/graph-model/src/widgets.ts | rejected:not-introduced: The graph-model type import is already in the base; audit attribution reports it as new. |
| F73 | src/components/rightSidePanel/subgraph/SubgraphEditor.vue:31 |
Import to src/renderer/core/canvas/canvasStore.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F74 | src/components/rightSidePanel/subgraph/SubgraphEditor.vue:32 |
Import to packages/design-system/src/components/search-input/AsyncSearchInput.vue | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F75 | src/components/rightSidePanel/subgraph/SubgraphEditor.vue:33 |
Import to src/services/litegraphService.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F76 | src/components/rightSidePanel/subgraph/SubgraphEditor.vue:38 |
Import to src/types/widgetVisibility.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F77 | src/components/rightSidePanel/subgraph/SubgraphNodeWidget.vue:5 |
Import to packages/design-system/src/components/button/Button.vue | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F78 | src/core/graph/subgraph/promotedInputWidget.ts:1 |
Import to packages/graph-model/src/slots.ts | rejected:not-introduced: The graph-model type import is already in the base; audit attribution reports it as new. |
| F79 | src/core/graph/subgraph/promotedInputWidget.ts:2 |
Import to src/lib/litegraph/src/litegraph.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F80 | src/core/graph/subgraph/promotedInputWidget.ts:3 |
Import to packages/graph-model/src/widgets.ts | rejected:not-introduced: The graph-model type import is already in the base; audit attribution reports it as new. |
| F81 | src/core/graph/subgraph/promotedInputWidget.ts:4 |
Import to src/stores/widgetValueStore.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| F82 | src/core/graph/subgraph/promotedInputWidget.ts:5 |
Import to packages/graph-model/src/nodeId.ts | rejected:not-introduced: The graph-model type import is already in the base; audit attribution reports it as new. |
| F83 | src/core/graph/subgraph/promotedInputWidget.ts:7 |
Import to src/core/graph/subgraph/resolveSubgraphInputTarget.ts | rejected:not-introduced: Fallow marks this edge inherited at the actual base. |
| const count = await toggleButtons.count() | ||
| for (let i = 0; i < count; i++) { | ||
| await expect(toggleButtons.nth(i)).toBeDisabled() | ||
| await expect(toggleButtons.nth(i)).toBeEnabled() |
There was a problem hiding this comment.
[P2] Delete the enabled-only browser case (T4)
The adjacent editor round trip actually clicks this shared toggle. The linked-demotion case in subgraphPromotion.spec.ts also checks enablement and verifies the node widget disappears. This separate app boot/workflow load checks only a prerequisite of those stronger behaviors; no widget-specific enablement branch distinguishes the additional copies here. Please delete this case and retain those behavior checks. A one-click deletion would span the deleted assertion and unchanged setup between separate diff hunks, so I cannot anchor the complete test as one valid suggestion.
There was a problem hiding this comment.
I removed the enabled-only browser case in c1e90d6. The actual editor Hide/Show round trip and linked-demotion browser coverage remain and pass locally.
|
|
||
| test.describe('Parameters tab (WidgetActions menu)', () => { | ||
| test('linked promoted widget menu should not show Hide/Show input', async ({ | ||
| test('linked promoted widget menu shows a working Hide input option', async ({ |
There was a problem hiding this comment.
[P2] Preserve screenshot selection on the functional Parameters case (T5a)
The paired T5b suggestion moves the screenshot into this existing functional case and deletes its duplicate boot. Keep its @screenshot selection on the survivor, and name the standalone button accurately.
| test('linked promoted widget menu shows a working Hide input option', async ({ | |
| test('Hide a linked row', { tag: '@screenshot' }, async ({ |
There was a problem hiding this comment.
I retained the @screenshot tag on the functional Parameters Hide case in c1e90d6, together with its accessible-name and row-golden checks.
| const panel = await ensurePropertiesPanel(comfyPage) | ||
|
|
||
| const hideInputButtons = panel.getByTestId( | ||
| TestIds.subgraphEditor.widgetActionsHideInputButton | ||
| ) | ||
| await expect(hideInputButtons.first()).toBeVisible() | ||
|
|
||
| const moreButtons = panel.getByTestId( | ||
| TestIds.subgraphEditor.widgetActionsMenuButton | ||
| ) | ||
| await expect(moreButtons.first()).toBeVisible() | ||
| await moreButtons.first().click() | ||
|
|
||
| const menu = comfyPage.page.getByRole('menu') | ||
| await expect(menu).toBeVisible() | ||
| await expect(menu.getByText('Rename')).toBeVisible() | ||
| await menu.press('Escape') | ||
|
|
||
| const widgetCountBeforeHide = await moreButtons.count() | ||
|
|
||
| await hideInputButtons.first().click() | ||
|
|
||
| await expect | ||
| .poll(() => moreButtons.count()) | ||
| .toBeLessThan(widgetCountBeforeHide) | ||
| }) | ||
|
|
||
| test( | ||
| 'promoted widget row places the Hide input button before the menu', | ||
| { tag: '@screenshot' }, | ||
| async ({ comfyPage }) => { | ||
| await comfyPage.workflow.loadWorkflow( | ||
| 'subgraphs/subgraph-nested-promotion' | ||
| ) | ||
| const subgraphNodes = | ||
| await comfyPage.nodeOps.getNodeRefsByTitle('Sub 0') | ||
| expect(subgraphNodes.length).toBeGreaterThan(0) | ||
| await subgraphNodes[0].click('title') | ||
|
|
||
| const panel = await ensurePropertiesPanel(comfyPage) | ||
| const hideInputButton = panel | ||
| .getByTestId(TestIds.subgraphEditor.widgetActionsHideInputButton) | ||
| .first() | ||
| await expect(hideInputButton).toBeVisible() | ||
| await expect(hideInputButton).toHaveAccessibleName('Hide input') | ||
|
|
||
| const rowHeader = hideInputButton.locator('xpath=../..') | ||
| await expectElementScreenshot( | ||
| rowHeader, | ||
| 'promoted-widget-row-hide-input-button.png' | ||
| ) | ||
| } | ||
| ) |
There was a problem hiding this comment.
[P2] Capture the row golden in the existing functional Parameters case (T5b)
Both cases load the same workflow, select Sub 0, open the same panel, and observe the same first row before hiding it. Please move the useful golden and accessible-name check into that already-open functional case. This replacement preserves the golden while removing the duplicate workflow boot; T5a preserves screenshot selection. The unrelated menu smoke check and ancestor-count locator are separate findings (T7 and T9).
| const panel = await ensurePropertiesPanel(comfyPage) | |
| const hideInputButtons = panel.getByTestId( | |
| TestIds.subgraphEditor.widgetActionsHideInputButton | |
| ) | |
| await expect(hideInputButtons.first()).toBeVisible() | |
| const moreButtons = panel.getByTestId( | |
| TestIds.subgraphEditor.widgetActionsMenuButton | |
| ) | |
| await expect(moreButtons.first()).toBeVisible() | |
| await moreButtons.first().click() | |
| const menu = comfyPage.page.getByRole('menu') | |
| await expect(menu).toBeVisible() | |
| await expect(menu.getByText('Rename')).toBeVisible() | |
| await menu.press('Escape') | |
| const widgetCountBeforeHide = await moreButtons.count() | |
| await hideInputButtons.first().click() | |
| await expect | |
| .poll(() => moreButtons.count()) | |
| .toBeLessThan(widgetCountBeforeHide) | |
| }) | |
| test( | |
| 'promoted widget row places the Hide input button before the menu', | |
| { tag: '@screenshot' }, | |
| async ({ comfyPage }) => { | |
| await comfyPage.workflow.loadWorkflow( | |
| 'subgraphs/subgraph-nested-promotion' | |
| ) | |
| const subgraphNodes = | |
| await comfyPage.nodeOps.getNodeRefsByTitle('Sub 0') | |
| expect(subgraphNodes.length).toBeGreaterThan(0) | |
| await subgraphNodes[0].click('title') | |
| const panel = await ensurePropertiesPanel(comfyPage) | |
| const hideInputButton = panel | |
| .getByTestId(TestIds.subgraphEditor.widgetActionsHideInputButton) | |
| .first() | |
| await expect(hideInputButton).toBeVisible() | |
| await expect(hideInputButton).toHaveAccessibleName('Hide input') | |
| const rowHeader = hideInputButton.locator('xpath=../..') | |
| await expectElementScreenshot( | |
| rowHeader, | |
| 'promoted-widget-row-hide-input-button.png' | |
| ) | |
| } | |
| ) | |
| const panel = await ensurePropertiesPanel(comfyPage) | |
| const hideInputButtons = panel.getByTestId( | |
| TestIds.subgraphEditor.widgetActionsHideInputButton | |
| ) | |
| await expect(hideInputButtons.first()).toBeVisible() | |
| await expect(hideInputButtons.first()).toHaveAccessibleName('Hide input') | |
| const rowHeader = hideInputButtons.first().locator('xpath=../..') | |
| await expectElementScreenshot( | |
| rowHeader, | |
| 'promoted-widget-row-hide-input-button.png' | |
| ) | |
| const moreButtons = panel.getByTestId( | |
| TestIds.subgraphEditor.widgetActionsMenuButton | |
| ) | |
| await expect(moreButtons.first()).toBeVisible() | |
| await moreButtons.first().click() | |
| const menu = comfyPage.page.getByRole('menu') | |
| await expect(menu).toBeVisible() | |
| await expect(menu.getByText('Rename')).toBeVisible() | |
| await menu.press('Escape') | |
| const widgetCountBeforeHide = await moreButtons.count() | |
| await hideInputButtons.first().click() | |
| await expect | |
| .poll(() => moreButtons.count()) | |
| .toBeLessThan(widgetCountBeforeHide) | |
| }) |
There was a problem hiding this comment.
I folded the golden and accessible-name assertions into the functional Parameters case in c1e90d6 and removed the duplicate workflow boot. Local Chromium reports a six-pixel golden mismatch; the original standalone test reproduces the same mismatch. I left the golden and tolerance unchanged.
| test('a widget outside any subgraph never shows a Hide/Show input option', async ({ | ||
| comfyPage | ||
| }) => { | ||
| await comfyPage.workflow.loadWorkflow( | ||
| 'subgraphs/subgraph-nested-promotion' | ||
| ) | ||
| const outer = await comfyPage.nodeOps.getNodeRefsByTitle('Outer') | ||
| expect(outer.length).toBeGreaterThan(0) | ||
| await outer[0].click('title') | ||
|
|
||
| const panel = await ensurePropertiesPanel(comfyPage) | ||
|
|
||
| await expect( | ||
| panel.getByTestId(TestIds.subgraphEditor.widgetActionsHideInputButton) | ||
| ).toHaveCount(0) |
There was a problem hiding this comment.
[P2] Keep the no-host negative contract at component level (T6)
WidgetActions.test.ts already checks no Show input without a host, and the new no-host Hide input case checks the standalone control. The real interior-row case covers the other host-identity restriction. This extra workflow boot exercises the same action component and repeats those guards; the positive Parameters browser case retains the WidgetItem-to-WidgetActions integration. Please delete this additional browser case and keep those component cases. The complete deletion crosses the removed assertion and unchanged menu setup between diff hunks; a suggestion limited to this added setup would leave a detached test body.
There was a problem hiding this comment.
I removed the duplicate outside-subgraph browser case in c1e90d6. The component missing-host and interior-row cases remain, and the targeted component suites pass.
| expect(screen.queryByTestId('advanced-inputs-section')).toBeNull() | ||
|
|
||
| demoteWidget(sourceNode, seedWidget, [host]) | ||
| await nextTick() | ||
|
|
||
| expect(screen.getByTestId('advanced-inputs-section').textContent).toContain( | ||
| 'seed' | ||
| ) | ||
|
|
||
| promoteWidget(sourceNode, seedWidget, [host]) | ||
| await nextTick() | ||
|
|
||
| expect(screen.queryByTestId('advanced-inputs-section')).toBeNull() |
There was a problem hiding this comment.
[P2] Exercise the actual Parameters recovery actions in this regression (T2)
SectionWidgets is replaced by test-generated spans, and this test calls demoteWidget/promoteWidget itself. It protects projection invalidation, but not the promised user recovery. Removing :host="node" from the Advanced Inputs SectionWidgets leaves it green while removing Show input from the actual row; the Parameters browser case also stops after hiding.
Please rewrite this existing case with real SectionWidgets/WidgetItem/WidgetActions: hide through the button, expand Advanced Inputs, choose Show input, and assert the row returns. Use the nested source from C1 so the concrete failure is covered without another browser case. I am leaving the integration rewrite as prose because the complete repair spans the source membership condition in WidgetActions.vue and this component test, including its child-stub setup.
There was a problem hiding this comment.
The author replaced the synthetic projection check with real nested Parameters actions in 841ebe0. I verified that regression fails with the old Show-input condition and passes now, and exercised Hide → Advanced Inputs → Show in the live browser.
canShowInput checked isLinked on the interior node, which stays true for a promotion that is still linked one level further in. After hiding an outer input sourced from an inner subgraph promotion, its Advanced Inputs row (node=innerHost, host=outerHost) lost Show input even though it was the correct recovery action. Check row ownership (node !== host) instead, mirroring the host-row check canHideInput already uses. Extends the Hide/Show regression to hide a two-level nested promotion through the real button, expand Advanced Inputs, and restore it through the real Show input menu item. Also applies review nits: drops the disallowed implementation-rationale docblock, removes WidgetActions test cases that no longer exercise a distinct condition after the fix, protects the SubgraphEditor toggle's accessible names in its existing regression, and names the hide/show phases in the browser round trip.
Requested by Christian Byrne · Slack thread
Summary
Re-enable hiding a promoted input from the subgraph editor and the Parameters tab, including promotions nested through another subgraph. Hidden inputs appear immediately in Advanced Inputs and can be shown again.
Fixes FRONT-1440. The separate size-collapse bug from the same thread, FE-853, was fixed by #14461.
Why this is not by design
The disabling check came from #10648, written when only some promotions were linked. ADR 0009 and #12197 later made every promotion linked, so the old check disabled every toggle. Demote is the reversible inverse of promote, as in #12278 and the existing Hide All action.
Hiding edits the subgraph definition and therefore applies to every instance of that subgraph, just like promotion and Hide All.
Evidence
Promoted row baseline, showing the Hide input button before the menu: