Repository navigation
feat(website): link to status.comfy.org from the failed payment page - #14877
Conversation
🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-14877.vercel.app This commit: https://website-frontend-at2rng7zq-comfyui.vercel.app Last updated: 2026-08-07T03:29:59Z for |
📝 WalkthroughWalkthroughPayment failure pages now show a localized cloud status link. English and zh-CN end-to-end tests verify the visible link and its target URL. ChangesPayment status link
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant PaymentStatusSection
participant Translations
participant CloudStatusPage
PaymentStatusSection->>Translations: Request localized failure prompt
Translations-->>PaymentStatusSection: Return translated prompt text
PaymentStatusSection->>CloudStatusPage: Navigate to externalLinks.cloudStatus
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/website/e2e/payment.spec.ts`:
- Around line 123-125: Update the zh-CN payment test assertion for the “查看系统状态”
link to also verify visibility, matching the existing visibility assertion in
the English test while retaining the href check.
In `@apps/website/src/components/payment/PaymentStatusSection.vue`:
- Around line 99-106: Add a semantic focus-visible outline or ring utility to
the anchor rendered by the failed-status branch in PaymentStatusSection.vue,
alongside its existing hover styling, so keyboard users can clearly identify
focus while preserving the current link behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: a958385b-028c-4c5f-b75a-e0048140413f
📒 Files selected for processing (3)
apps/website/e2e/payment.spec.tsapps/website/src/components/payment/PaymentStatusSection.vueapps/website/src/i18n/translations.ts
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/website/src/components/payment/PaymentStatusSection.vue`:
- Around line 105-107: Add a semantic Tailwind hover utility using a hover:
modifier to both status anchors in PaymentStatusSection, including the external
cloud status link and the other status link. Preserve their existing semantic
styling and ensure pointer interaction has clear visual feedback.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f10c508c-58fd-4a8e-8240-703ac2fb7692
📒 Files selected for processing (3)
apps/website/e2e/payment.spec.tsapps/website/src/components/payment/PaymentStatusSection.vueapps/website/src/i18n/translations.ts
dante01yoon
left a comment
There was a problem hiding this comment.
No blocking regressions found on d30d0b1.
Validated the latest Vercel preview in English desktop and zh-CN mobile: the guidance is limited to the failed-payment state, resolves to https://status.comfy.org/, renders without horizontal overflow, and produced no console errors. The focused payment E2E coverage exercises the new link in both locales. Website E2E was still running when this approval was submitted; all completed required checks were green.
|
@coderabbitai approve |
✅ Action performedComments resolved and changes approved. |
|
@robinjhuang Successfully backported to #14884 |
|
@robinjhuang Successfully backported to #14885 |
…fordances (Comfy-Org#14915) ## Summary Follow-up to Comfy-Org#14877: the status-page link on `/payment/failed` had no hover or keyboard-focus affordance. ## Changes - **What**: Adds `hover:opacity-70` and a `focus-visible` ring to the anchor, matching the inline-link pattern already used in `FAQSplit01.vue`. One line, styling only. ## Review Focus Addresses two CodeRabbit findings on Comfy-Org#14877 that arrived after it entered the merge queue, so they could not be pushed to that branch. Verified by focusing the link in a real browser (ring renders) plus the payment e2e suite (11 tests, en + zh-CN), unit tests, and `astro check`.

Summary
Adds status-page guidance to
/payment/failed(theSTRIPE_CANCEL_URLtarget) so someone whose payment did not go through can rule out an outage before contacting support.Changes
externalLinks.cloudStatus. Sentence is assembled from prefix/link/suffix translation keys (en + zh-CN), matching the existing pattern inHubspotFormEmbed.vue, sincet()has no interpolation. Support is intentionally not repeated here; the CONTACT SUPPORT CTA above already covers it.Review Focus
apps/websiteunit tests,astro check, and the payment e2e suite (11 tests, en + zh-CN) pass locally against the built site.