Skip to content

feat(website): link to status.comfy.org from the failed payment page - #14877

Merged
dante01yoon merged 3 commits into
mainfrom
robinjhuang/payment-failed-status-link
Aug 7, 2026
Merged

dante01yoon merged 3 commits into
mainfrom
robinjhuang/payment-failed-status-link

Conversation

@robinjhuang

@robinjhuang robinjhuang commented Aug 7, 2026 •

Copy link
Copy Markdown
Member

Summary

Adds status-page guidance to /payment/failed (the STRIPE_CANCEL_URL target) so someone whose payment did not go through can rule out an outage before contacting support.

Changes

  • What: A line under the CTAs on the failed payment page only — "Check our [status page] for more information." — linking externalLinks.cloudStatus. Sentence is assembled from prefix/link/suffix translation keys (en + zh-CN), matching the existing pattern in HubspotFormEmbed.vue, since t() has no interpolation. Support is intentionally not repeated here; the CONTACT SUPPORT CTA above already covers it.

Review Focus

apps/website unit tests, astro check, and the payment e2e suite (11 tests, en + zh-CN) pass locally against the built site.
Screenshot 2026-08-06 at 8 31 16 PM

@robinjhuang
robinjhuang requested a review from a team August 7, 2026 03:09
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-14877.vercel.app

This commit: https://website-frontend-at2rng7zq-comfyui.vercel.app

Last updated: 2026-08-07T03:29:59Z for d30d0b1

@coderabbitai

coderabbitai Bot commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Payment failure pages now show a localized cloud status link. English and zh-CN end-to-end tests verify the visible link and its target URL.

Changes

Payment status link

Layer / File(s) Summary
Payment failure status link
apps/website/src/components/payment/PaymentStatusSection.vue, apps/website/src/i18n/translations.ts
Failed payments now show a localized link to externalLinks.cloudStatus. English and Chinese translation keys were added. Utility classes were reordered without changing styling.
Payment status link tests
apps/website/e2e/payment.spec.ts
English and zh-CN payment failure tests verify that the visible status link targets STATUS_URL.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: mobeenabdullah

Sequence Diagram(s)

sequenceDiagram
  participant PaymentStatusSection
  participant Translations
  participant CloudStatusPage
  PaymentStatusSection->>Translations: Request localized failure prompt
  Translations-->>PaymentStatusSection: Return translated prompt text
  PaymentStatusSection->>CloudStatusPage: Navigate to externalLinks.cloudStatus
Loading

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive The review context does not provide the PR title or actual commit subjects, so the required bug-fix signal cannot be verified. Provide the PR title and commit subjects to determine whether the bug-fix condition applies.
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed files are under apps/website and do not include src/lib/litegraph/, src/ecs/, or graph-entity files; the check is not applicable.
Title check ✅ Passed The title clearly identifies the main change: adding a status-page link to the failed payment page.
Description check ✅ Passed The description includes the required summary, changes, review focus, and applicable screenshot, with clear implementation and testing details.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch robinjhuang/payment-failed-status-link

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/website/e2e/payment.spec.ts`:
- Around line 123-125: Update the zh-CN payment test assertion for the “查看系统状态”
link to also verify visibility, matching the existing visibility assertion in
the English test while retaining the href check.

In `@apps/website/src/components/payment/PaymentStatusSection.vue`:
- Around line 99-106: Add a semantic focus-visible outline or ring utility to
the anchor rendered by the failed-status branch in PaymentStatusSection.vue,
alongside its existing hover styling, so keyboard users can clearly identify
focus while preserving the current link behavior.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a958385b-028c-4c5f-b75a-e0048140413f

📥 Commits

Reviewing files that changed from the base of the PR and between 2c33aaf and e682289.

📒 Files selected for processing (3)
  • apps/website/e2e/payment.spec.ts
  • apps/website/src/components/payment/PaymentStatusSection.vue
  • apps/website/src/i18n/translations.ts

Comment thread apps/website/e2e/payment.spec.ts Resolved
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 7, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/website/src/components/payment/PaymentStatusSection.vue`:
- Around line 105-107: Add a semantic Tailwind hover utility using a hover:
modifier to both status anchors in PaymentStatusSection, including the external
cloud status link and the other status link. Preserve their existing semantic
styling and ensure pointer interaction has clear visual feedback.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f10c508c-58fd-4a8e-8240-703ac2fb7692

📥 Commits

Reviewing files that changed from the base of the PR and between e682289 and 6ea46bf.

📒 Files selected for processing (3)
  • apps/website/e2e/payment.spec.ts
  • apps/website/src/components/payment/PaymentStatusSection.vue
  • apps/website/src/i18n/translations.ts

@dante01yoon

Copy link
Copy Markdown
Collaborator

TO BE

Failed-payment page on preview at d30d0b1 (desktop, 1440 px):

TO BE — failed payment page with status-page guidance

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking regressions found on d30d0b1.

Validated the latest Vercel preview in English desktop and zh-CN mobile: the guidance is limited to the failed-payment state, resolves to https://status.comfy.org/, renders without horizontal overflow, and produced no console errors. The focused payment E2E coverage exercises the new link in both locales. Website E2E was still running when this approval was submitted; all completed required checks were green.

@dante01yoon

Copy link
Copy Markdown
Collaborator

@coderabbitai approve

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Comments resolved and changes approved.

@dante01yoon dante01yoon added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch cloud/1.48 labels Aug 7, 2026
@dante01yoon
dante01yoon added this pull request to the merge queue Aug 7, 2026
Merged via the queue into main with commit 1485bb3 Aug 7, 2026
74 of 77 checks passed
@dante01yoon
dante01yoon deleted the robinjhuang/payment-failed-status-link branch August 7, 2026 03:54
@comfy-pr-bot

Copy link
Copy Markdown
Member

@robinjhuang Successfully backported to #14884

@comfy-pr-bot

Copy link
Copy Markdown
Member

@robinjhuang Successfully backported to #14885

@github-actions github-actions Bot removed the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Aug 7, 2026
comfy-pr-bot added a commit that referenced this pull request Aug 7, 2026
…e failed payment page (#14885)

Backport of #14877 to `cloud/1.49`

Automatically created by backport workflow.

Co-authored-by: Robin Huang <robin.j.huang@gmail.com>
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Aug 8, 2026
…fordances (Comfy-Org#14915)

## Summary

Follow-up to Comfy-Org#14877: the status-page link on `/payment/failed` had no
hover or keyboard-focus affordance.

## Changes

- **What**: Adds `hover:opacity-70` and a `focus-visible` ring to the
anchor, matching the inline-link pattern already used in
`FAQSplit01.vue`. One line, styling only.

## Review Focus

Addresses two CodeRabbit findings on Comfy-Org#14877 that arrived after it
entered the merge queue, so they could not be pushed to that branch.
Verified by focusing the link in a real browser (ring renders) plus the
payment e2e suite (11 tests, en + zh-CN), unit tests, and `astro check`.
@comfy-pr-bot comfy-pr-bot added the released:cloud PR has been released to cloud label Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released:cloud PR has been released to cloud size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants