Skip to content

fix(website): give the payment status link hover and focus-visible affordances - #14915

Merged
christian-byrne merged 1 commit into
mainfrom
robinjhuang/status-link-a11y
Aug 8, 2026
Merged

christian-byrne merged 1 commit into
mainfrom
robinjhuang/status-link-a11y

Conversation

@robinjhuang

Copy link
Copy Markdown
Member

Summary

Follow-up to #14877: the status-page link on /payment/failed had no hover or keyboard-focus affordance.

Changes

  • What: Adds hover:opacity-70 and a focus-visible ring to the anchor, matching the inline-link pattern already used in FAQSplit01.vue. One line, styling only.

Review Focus

Addresses two CodeRabbit findings on #14877 that arrived after it entered the merge queue, so they could not be pushed to that branch. Verified by focusing the link in a real browser (ring renders) plus the payment e2e suite (11 tests, en + zh-CN), unit tests, and astro check.

@robinjhuang
robinjhuang requested a review from a team August 7, 2026 22:37
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 7, 2026
@coderabbitai

coderabbitai Bot commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 986b4c41-9445-47a0-9237-4247490b552f

📥 Commits

Reviewing files that changed from the base of the PR and between ccdcf60 and e7b3c38.

📒 Files selected for processing (1)
  • apps/website/src/components/payment/PaymentStatusSection.vue

📝 Walkthrough

Walkthrough

The failed-payment cloud status link keeps its existing yellow underlined style and adds rounded corners, hover opacity feedback, and a visible keyboard focus ring.

Changes

Payment status styling

Layer / File(s) Summary
Link interaction styles
apps/website/src/components/payment/PaymentStatusSection.vue
The cloud status link adds rounded corners, hover opacity feedback, and visible focus styling.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: cloud/1.48, cloud/1.49


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive The changed file is available and is exclusively under apps/website, but commit subjects are not provided in the review context. Provide the PR commit subjects, or confirm that the changed-file list and metadata are complete for this check.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the added hover and focus-visible affordances for the payment status link.
Description check ✅ Passed The description includes the required summary, changes, review focus, rationale, and verification details; screenshots are not necessary for this styling-only change.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Adr Compliance For Entity/Litegraph Changes ✅ Passed The only changed file is PaymentStatusSection.vue, which is outside the listed litegraph, ECS, and graph-entity paths.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch robinjhuang/status-link-a11y

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-14915.vercel.app

This commit: https://website-frontend-ptobea1g0-comfyui.vercel.app

Last updated: 2026-08-07T22:39:19Z for e7b3c38

@christian-byrne
christian-byrne added this pull request to the merge queue Aug 8, 2026
Merged via the queue into main with commit e4990a1 Aug 8, 2026
57 of 58 checks passed
@christian-byrne
christian-byrne deleted the robinjhuang/status-link-a11y branch August 8, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants