Repository navigation
fix(assets): fall back to bare-tag grouping for legacy tags in model_type mode - #14848
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughModel asset bucketing now uses shared category resolution. Browser tests add coverage for legacy bare tags, mid-retag duplicates, loader paths, and model folder assignment. ChangesModel asset categories
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: daf301be69
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Regression for the AC3 bug flagged in #13574's review: on a | ||
| // model_type-capable backend, a bare (non-namespaced) tag resolved to no | ||
| // category and buildModelBuckets dropped the asset with a console.warn | ||
| // instead of falling back to legacy bare-tag grouping. |
There was a problem hiding this comment.
Remove the redundant regression-history comment
Delete this comment: it restates the test name and fixture setup while coupling the test to external review IDs, so it adds maintenance burden without clarifying non-obvious behavior. The repository explicitly forbids multi-line comments that justify trivial changes or paraphrase test setup.
AGENTS.md reference: AGENTS.md:L208-L212
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Agreed — removed in f16560c, along with a second instance of the same thing you didn't flag (the "Regression for the high-severity finding on #14217" block above Groups a model_type-covered asset once and ignores its bare-tag twins). That one had also gone stale: #14217 is now closed, so it pointed at a dead PR.
Kept the two remaining comments in this spec, which I'd argue are a different class — they explain non-obvious test mechanics rather than paraphrasing setup:
- why the
lorasfixture needs a realmodel_type:lorasasset (asset mode hides zero-model folders, so an absent row would be ambiguous between "correctly empty" and "never loaded") - why the twin assertion is scoped to the
lorassubtree rather thantab.modelTree(checkpoints is still expanded from the previous assertion, and its correct copy of the leaf would satisfy a tree-wide query on its own, making the test pass for the wrong reason)
Both describe a trap that would otherwise be re-introduced by someone simplifying the test. Happy to drop them too if you read AGENTS.md as covering that case as well.
Posted by Simon's agent from his account — the bot identity isn't installed on this repo. 👎 if unhelpful.
…type mode `modelFolderFromTag` returned `undefined` for any tag without the `model_type:` prefix as soon as `modelTypeMode` was true. `buildModelBuckets` treats an asset whose tags resolve to no folder as uncategorized and drops it with a `console.warn`, so a model still carrying a legacy bare tag (e.g. `checkpoints` rather than `model_type:checkpoints`) vanished from the model library sidebar entirely once the backend advertised `supports_model_type_tags`. Delete the local `modelFolderFromTag` and bucket via `getAssetCategories`, which already implements the intended semantics: `model_type:*` values are authoritative when present, and an asset with none still routes by its bare tags. An asset covered by `model_type:` tags is grouped by those alone, so a leftover bare-tag twin from a partial re-tagging cannot cross-list it into a second folder. Adds an e2e scenario and fixture covering a bare-tagged asset walked with `supports_model_type_tags: true`.
Both restated their test's own name and coupled the spec to external review IDs, one of which now points at a closed PR. AGENTS.md forbids multi-line comments that justify trivial changes or paraphrase test setup.
f16560c to
16587ba
Compare
🎭 Playwright: ✅ 1804 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.69 MB gzip 🟢 -294 BDetailsSummary
Category Glance App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.36 MB (baseline 1.36 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 565 kB (baseline 565 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 4 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.5 MB (baseline 3.5 MB) • 🟢 -525 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 550 kB (baseline 550 kB) • 🟢 -28 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 14 MB (baseline 14 MB) • ⚪ 0 BBundles that do not match a named category
Status: 69 added / 69 removed / 216 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-11T23:41:10.178Z",
"gitSha": "600dc5a14545c2ad84afd58b1fcbf49dabdfab5f",
"branch": "synap5e/fix/assets-bare-tag-model-type-fallback",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2055.3600000000074,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.491999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.11099999999993,
"heapDeltaBytes": 5862484,
"heapUsedBytes": 70207292,
"domNodes": 18,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 19.809,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2035.8229999999367,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.87,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.6809999999999,
"heapDeltaBytes": -18653472,
"heapUsedBytes": 45623372,
"domNodes": 16,
"jsHeapTotalBytes": 22519808,
"scriptDurationMs": 19.622999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2167.676999999969,
"styleRecalcs": 82,
"styleRecalcDurationMs": 51.922999999999995,
"layouts": 12,
"layoutDurationMs": 3.9640000000000004,
"taskDurationMs": 1107.655,
"heapDeltaBytes": -10386044,
"heapUsedBytes": 53816640,
"domNodes": -282,
"jsHeapTotalBytes": 23306240,
"scriptDurationMs": 148.52100000000002,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.8620000000765,
"styleRecalcs": 73,
"styleRecalcDurationMs": 37.749,
"layouts": 12,
"layoutDurationMs": 6.051000000000001,
"taskDurationMs": 858.195,
"heapDeltaBytes": -110804,
"heapUsedBytes": 64217916,
"domNodes": 57,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 125.70500000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.2329999999888,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.278,
"layouts": 6,
"layoutDurationMs": 0.6580000000000001,
"taskDurationMs": 395.20300000000003,
"heapDeltaBytes": 8835748,
"heapUsedBytes": 73146724,
"domNodes": 77,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 20.679999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.4270000000251,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.024999999999995,
"layouts": 6,
"layoutDurationMs": 0.6149999999999999,
"taskDurationMs": 389.089,
"heapDeltaBytes": 8778576,
"heapUsedBytes": 73176072,
"domNodes": 79,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 20.372,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 646.013000000039,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.909,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.7339999999999,
"heapDeltaBytes": -10903316,
"heapUsedBytes": 53556236,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 64.68599999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 589.2220000000634,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.336000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.717,
"heapDeltaBytes": -11217164,
"heapUsedBytes": 53171800,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 59.736,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2025.6779999999708,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.355,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.168,
"heapDeltaBytes": 6888844,
"heapUsedBytes": 67636784,
"domNodes": -284,
"jsHeapTotalBytes": 4296704,
"scriptDurationMs": 113.275,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2047.0020000000204,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.203999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 691.576,
"heapDeltaBytes": 7411568,
"heapUsedBytes": 66927676,
"domNodes": -282,
"jsHeapTotalBytes": 2199552,
"scriptDurationMs": 111.15499999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2178.724999999986,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.775,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1303.75,
"heapDeltaBytes": -5578936,
"heapUsedBytes": 55585448,
"domNodes": -285,
"jsHeapTotalBytes": 4820992,
"scriptDurationMs": 434.26899999999995,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2248.4880000000658,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.435,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1337.412,
"heapDeltaBytes": 5211612,
"heapUsedBytes": 65747600,
"domNodes": -283,
"jsHeapTotalBytes": 3702784,
"scriptDurationMs": 438.72,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3231.935999999962,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.978000000000005,
"layouts": 60,
"layoutDurationMs": 7.332999999999999,
"taskDurationMs": 1571.895,
"heapDeltaBytes": -949988,
"heapUsedBytes": 61198084,
"domNodes": -288,
"jsHeapTotalBytes": 6656000,
"scriptDurationMs": 537.886,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3285.3380000000243,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.932,
"layouts": 60,
"layoutDurationMs": 7.736,
"taskDurationMs": 1568.478,
"heapDeltaBytes": 1783196,
"heapUsedBytes": 64117516,
"domNodes": -288,
"jsHeapTotalBytes": 6131712,
"scriptDurationMs": 547.2779999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2055.890999999974,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.726,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 724.857,
"heapDeltaBytes": 7590732,
"heapUsedBytes": 68258964,
"domNodes": -284,
"jsHeapTotalBytes": 3510272,
"scriptDurationMs": 120.31,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2016.5319999999838,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.572,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 679.894,
"heapDeltaBytes": 6219244,
"heapUsedBytes": 66843904,
"domNodes": -284,
"jsHeapTotalBytes": 4820992,
"scriptDurationMs": 105.83200000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.8380000000052,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.601,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.94499999999994,
"heapDeltaBytes": -11051028,
"heapUsedBytes": 53559716,
"domNodes": 20,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 123.214,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.2089999999916,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.395,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.07300000000004,
"heapDeltaBytes": -10378856,
"heapUsedBytes": 54089540,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 117.199,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2028.536000000031,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.878000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.21500000000003,
"heapDeltaBytes": 5890868,
"heapUsedBytes": 70421488,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 15.059000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2012.3989999999594,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.009999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.62499999999994,
"heapDeltaBytes": 5904236,
"heapUsedBytes": 70359672,
"domNodes": 16,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 14.664999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1766.804000000036,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.91,
"layouts": 16,
"layoutDurationMs": 4.894,
"taskDurationMs": 868.9599999999999,
"heapDeltaBytes": -17924336,
"heapUsedBytes": 46498460,
"domNodes": -282,
"jsHeapTotalBytes": 23830528,
"scriptDurationMs": 98.98499999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.6510000000126,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.824,
"layouts": 16,
"layoutDurationMs": 4.727,
"taskDurationMs": 801.759,
"heapDeltaBytes": -3796224,
"heapUsedBytes": 60728400,
"domNodes": 62,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 97.58,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.7709999999634,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.50399999999999,
"layouts": 14,
"layoutDurationMs": 12.706999999999999,
"taskDurationMs": 949.397,
"heapDeltaBytes": 31026284,
"heapUsedBytes": 99139772,
"domNodes": 13673,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 35.619,
"eventListeners": 2375,
"totalBlockingTimeMs": 137,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8355.841999999995,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.343,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4627.603000000001,
"heapDeltaBytes": 12066916,
"heapUsedBytes": 71460260,
"domNodes": -281,
"jsHeapTotalBytes": 6062080,
"scriptDurationMs": 1420.2709999999997,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8691.364000000021,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.891999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5077.994,
"heapDeltaBytes": 24412716,
"heapUsedBytes": 84068364,
"domNodes": -284,
"jsHeapTotalBytes": 11829248,
"scriptDurationMs": 1706.672,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17246.445999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17232.308,
"heapDeltaBytes": -66133648,
"heapUsedBytes": 159720556,
"domNodes": -8312,
"jsHeapTotalBytes": -8331264,
"scriptDurationMs": 554.516,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17348.18900000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17324.521,
"heapDeltaBytes": -58749268,
"heapUsedBytes": 167639388,
"domNodes": -8312,
"jsHeapTotalBytes": -6496256,
"scriptDurationMs": 589.881,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21083.114999999965,
"styleRecalcs": 146,
"styleRecalcDurationMs": 18.235,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21058.815000000002,
"heapDeltaBytes": -49063812,
"heapUsedBytes": 176738696,
"domNodes": -8316,
"jsHeapTotalBytes": -10235904,
"scriptDurationMs": 922.317,
"eventListeners": -16383,
"totalBlockingTimeMs": 447,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21517.913000000022,
"styleRecalcs": 152,
"styleRecalcDurationMs": 19.274999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21462.25,
"heapDeltaBytes": -41731252,
"heapUsedBytes": 164406000,
"domNodes": -8312,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 929.8259999999999,
"eventListeners": -16381,
"totalBlockingTimeMs": 369,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 460.32500000001164,
"styleRecalcs": 14,
"styleRecalcDurationMs": 19.222999999999995,
"layouts": 3,
"layoutDurationMs": 0.5840000000000001,
"taskDurationMs": 111.769,
"heapDeltaBytes": 5060860,
"heapUsedBytes": 68382516,
"domNodes": 126,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.742,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 461.2839999999778,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.266,
"layouts": 3,
"layoutDurationMs": 0.5869999999999999,
"taskDurationMs": 118.365,
"heapDeltaBytes": 5056976,
"heapUsedBytes": 68548060,
"domNodes": 123,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.019,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14848 +/- ##
==========================================
- Coverage 80.81% 80.81% -0.01%
==========================================
Files 1873 1873
Lines 121954 121942 -12
Branches 37495 37948 +453
==========================================
- Hits 98558 98546 -12
+ Misses 22859 22849 -10
- Partials 537 547 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Fixes a bug where a legacy bare-tagged model asset silently disappears from the model library sidebar once the backend advertises
model_type:support, instead of falling back to legacy bare-tag grouping.Recreated from #14217 — same change, opened directly under my own account for tracking. The High finding from Cursor's panel on that PR is already folded into this diff.
Changes
modelFolderFromTagreturnedundefinedfor any tag that didn't carry themodel_type:prefix as soon asmodelTypeModewastrue.buildModelBucketstreats an asset whose tags resolve to no folder as "uncategorized" and drops it with aconsole.warn, so a model still carrying a legacy bare tag (e.g.checkpointsinstead ofmodel_type:checkpoints) vanished from the sidebar entirely on amodel_type:-capable backend. Changed insrc/platform/assets/services/assetService.ts.How
The fix deletes the local
modelFolderFromTaghelper and buckets viagetAssetCategoriesfromassetMetadataUtils, which already implements exactly the intended semantics and is already used by the other asset surfaces:model_type:*values are authoritative when present, and an asset with nomodel_type:tag still routes by its bare tags (with namespace residue filtered out). This makes the sidebar consistent with the rest of the asset code rather than carrying a second, subtly different grouping rule.A side effect worth calling out: because
getAssetCategoriesreturnsmodel_type:values alone when an asset has any, an asset covered bymodel_type:tags can no longer be cross-listed into a second folder by a leftover bare-tag twin from a partial re-tagging. The e2e suite covers that case (the "mid-retag twin" scenario).Added an e2e scenario,
Model library sidebar - asset mode with a legacy bare tag, inbrowser_tests/tests/sidebar/modelLibraryAssetMode.spec.ts, plus a matching fixture (MODEL_TYPE_CHECKPOINT_LEGACY_TAGinbrowser_tests/fixtures/data/assetFixtures.ts): a bare-tagged asset that still carries aloader_path, walked withsupports_model_type_tags: true, asserting it still renders in thecheckpointsfolder rather than being dropped.Review Focus
maindirectly. The stack it was originally written on top of (test(assets): e2e coverage for the assets-mode model library sidebar #13574) has since merged, so the diff here is just the three files.mainthat the bug is still live:modelFolderFromTagonmainstill returnsundefinedfor bare tags whenevermodelTypeModeis true.assetService.test.tscases onmainremain valid under the new path:getBareTagCategoriesfilters out the reservedmodelstag, so the "drops uncategorized model assets with a warning" case still drops itstags: ['models']asset; the bare-tag grouping cases all run withsupports_model_type_tags = false, an unchanged path.Test plan
pnpm typecheck— not run: no Node/pnpm toolchain provisioned on the host I authored this on. Relying on CI.pnpm exec vitest run src/platform/assets/services/assetService.test.ts— not run, same reason. Compatibility with the existing cases was verified by reading them (see Review Focus).MODEL_TYPE_TAG_PREFIXimport removed with no remaining uses in the file,modelFolderFromTaghas zero references repo-wide,getAssetCategoriesis exported fromassetMetadataUtilsonmain.Review coverage note: no Cursor panel has run on this PR — verified by querying for the panel review itself rather than inferring from an empty findings list. That is a did-not-run, not a clean result; the checks API reports success either way. CodeRabbit was rate-limited. Codex did review it, and its one finding was addressed in
f16560c.(An earlier version of this note blamed an org-wide Cursor outage running to 2026-08-22. That attribution was wrong and is withdrawn — panels have since been seen running normally elsewhere. The measured fact, that none ran here, is unchanged.)