Skip to content

fix(billing): show enterprise guidance at top-up cap - #14815

Closed
dante01yoon wants to merge 2 commits into
dante01yoon/test-billing-e2e-matrixfrom
dante/topup-max-enterprise-warning
Closed

dante01yoon wants to merge 2 commits into
dante01yoon/test-billing-e2e-matrixfrom
dante/topup-max-enterprise-warning

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Summary

Makes the existing maximum top-up guidance reachable when a custom amount is clamped to $10,000. This is the isolated production prerequisite for the deterministic maximum-contract coverage in the follow-up billing E2E PR.

Root cause

handlePayAmountChange always cleared showCeilingWarning. Since the number stepper clamps values to MAX_AMOUNT, the UI can never retain a value above $10,000, so the previous greater-than path could not expose the enterprise Contact us guidance.

Change

Set the warning when the normalized custom value is equal to the maximum. Preset selection remains unchanged.

AS IS

A custom value at or above $10,000 is clamped but hides enterprise guidance.

AS IS screenshot

TO BE

The same clamped value shows the existing Maximum allowed and Contact us guidance.

TO BE screenshot

Validation

Stacking

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ba9c5639-4dea-4f43-b379-5eec54de45db

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/07/2026, 04:48:36 PM UTC

Links

🎭 Playwright: ✅ 1792 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1771 / ❌ 0 / ⚠️ 0 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 50.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 84ms TBT · 95.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.9 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 155.9 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 21ms TBT · 168.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 402ms
canvas-idle: script duration 15ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.5 MB
canvas-idle: DOM nodes 20
canvas-idle: event listeners 6
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 29ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 720ms
canvas-mouse-sweep: script duration 94ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 55.3 MB
canvas-mouse-sweep: DOM nodes -113
canvas-mouse-sweep: event listeners -73
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 305ms
canvas-zoom-sweep: script duration 16ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 68.9 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 304ms
dom-widget-clipping: script duration 45ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 50.5 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 559ms
large-graph-idle: script duration 81ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 63.7 MB
large-graph-idle: DOM nodes -280
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1018ms
large-graph-pan: script duration 330ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 59.7 MB
large-graph-pan: DOM nodes -283
large-graph-pan: event listeners -148
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 67
large-graph-zoom: task duration 1223ms
large-graph-zoom: script duration 422ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 66.3 MB
large-graph-zoom: DOM nodes -134
large-graph-zoom: event listeners -73
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 587ms
minimap-idle: script duration 89ms
minimap-idle: TBT 0ms
minimap-idle: heap used 64.2 MB
minimap-idle: DOM nodes -282
minimap-idle: event listeners -164
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 49
subgraph-dom-widget-clipping: task duration 320ms
subgraph-dom-widget-clipping: script duration 94ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 51.2 MB
subgraph-dom-widget-clipping: DOM nodes 23
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 384ms
subgraph-idle: script duration 13ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 66.1 MB
subgraph-idle: DOM nodes 22
subgraph-idle: event listeners 6
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 628ms
subgraph-mouse-sweep: script duration 76ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 51.4 MB
subgraph-mouse-sweep: DOM nodes -110
subgraph-mouse-sweep: event listeners -75
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 25ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 787ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 84ms
subgraph-transition-enter: heap used 95.8 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2375
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 3597ms
viewport-pan-sweep: script duration 1094ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 65.9 MB
viewport-pan-sweep: DOM nodes -280
viewport-pan-sweep: event listeners -132
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14697ms
vue-large-graph-idle: script duration 452ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 155.9 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16390
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 116
vue-large-graph-pan: task duration 17039ms
vue-large-graph-pan: script duration 710ms
vue-large-graph-pan: TBT 21ms
vue-large-graph-pan: heap used 168.4 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16386
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 2
workflow-execution: style recalc count 13
workflow-execution: task duration 80ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 64.3 MB
workflow-execution: DOM nodes 133
workflow-execution: event listeners 73
Raw data
{
  "timestamp": "2026-08-07T16:57:52.316Z",
  "gitSha": "8e0e12fb8a9aa67fb45b27554747e028229b24f3",
  "branch": "dante/topup-max-enterprise-warning",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2037.9279999999937,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.362000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 396.78499999999997,
      "heapDeltaBytes": 5438288,
      "heapUsedBytes": 69729616,
      "domNodes": 20,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 13.994000000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 1993.4769999999844,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.44,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 407.78700000000003,
      "heapDeltaBytes": 5502332,
      "heapUsedBytes": 69822516,
      "domNodes": 20,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 16.72,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1777.2349999999904,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 28.132000000000005,
      "layouts": 12,
      "layoutDurationMs": 2.845,
      "taskDurationMs": 738.74,
      "heapDeltaBytes": -11936644,
      "heapUsedBytes": 52208612,
      "domNodes": -280,
      "jsHeapTotalBytes": 24096768,
      "scriptDurationMs": 93.068,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1708.4859999999935,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 29.526,
      "layouts": 12,
      "layoutDurationMs": 3.014,
      "taskDurationMs": 701.826,
      "heapDeltaBytes": -203516,
      "heapUsedBytes": 63795004,
      "domNodes": 54,
      "jsHeapTotalBytes": 25690112,
      "scriptDurationMs": 95.761,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1685.0880000000075,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 13.019999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.5379999999999998,
      "taskDurationMs": 295.887,
      "heapDeltaBytes": 8181536,
      "heapUsedBytes": 72101444,
      "domNodes": 77,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 15.506999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1676.4220000000023,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 13.998999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.5109999999999999,
      "taskDurationMs": 314.99100000000004,
      "heapDeltaBytes": 8294760,
      "heapUsedBytes": 72352632,
      "domNodes": 77,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 17.47,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 469.12500000001955,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.075999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 290.34700000000004,
      "heapDeltaBytes": -11313704,
      "heapUsedBytes": 52817068,
      "domNodes": 20,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 43.512,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 534.8749999999995,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.073000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 317.55400000000003,
      "heapDeltaBytes": -11127560,
      "heapUsedBytes": 52997096,
      "domNodes": 20,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 46.885999999999996,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2013.8880000000086,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.9140000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 534.6189999999999,
      "heapDeltaBytes": 5852812,
      "heapUsedBytes": 67423192,
      "domNodes": -280,
      "jsHeapTotalBytes": 3514368,
      "scriptDurationMs": 74.769,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2015.7990000000154,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.024000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 583.332,
      "heapDeltaBytes": 6743092,
      "heapUsedBytes": 66082996,
      "domNodes": -279,
      "jsHeapTotalBytes": 2465792,
      "scriptDurationMs": 87.623,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2069.817999999998,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.563,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 960.166,
      "heapDeltaBytes": 3179092,
      "heapUsedBytes": 64009656,
      "domNodes": -281,
      "jsHeapTotalBytes": 3706880,
      "scriptDurationMs": 313.67699999999996,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2095.249000000024,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.979999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1075.8190000000002,
      "heapDeltaBytes": 782436,
      "heapUsedBytes": 61137448,
      "domNodes": -284,
      "jsHeapTotalBytes": 3182592,
      "scriptDurationMs": 346.368,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3071.493999999973,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 14.290000000000001,
      "layouts": 60,
      "layoutDurationMs": 6.82,
      "taskDurationMs": 1158.0980000000002,
      "heapDeltaBytes": 22778656,
      "heapUsedBytes": 85014460,
      "domNodes": 16,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 403.87,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3108.136000000002,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 15.328000000000001,
      "layouts": 60,
      "layoutDurationMs": 7.255,
      "taskDurationMs": 1287.7269999999999,
      "heapDeltaBytes": -7776492,
      "heapUsedBytes": 53986220,
      "domNodes": -284,
      "jsHeapTotalBytes": 5349376,
      "scriptDurationMs": 439.93499999999995,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 1999.3440000000078,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.586999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 575.326,
      "heapDeltaBytes": 4990568,
      "heapUsedBytes": 68015640,
      "domNodes": -282,
      "jsHeapTotalBytes": 3252224,
      "scriptDurationMs": 85.49900000000001,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2009.3010000000504,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.318999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 599.65,
      "heapDeltaBytes": 6354260,
      "heapUsedBytes": 66643984,
      "domNodes": -281,
      "jsHeapTotalBytes": 3514368,
      "scriptDurationMs": 93.08,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 509.1960000000313,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 9.761000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 310.818,
      "heapDeltaBytes": -10492152,
      "heapUsedBytes": 53647680,
      "domNodes": 24,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 93.067,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 517.8850000000921,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 10.060999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 329.47800000000007,
      "heapDeltaBytes": -10480912,
      "heapUsedBytes": 53676540,
      "domNodes": 22,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 95.57000000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2052.5840000000244,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.044,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 374.447,
      "heapDeltaBytes": 5045432,
      "heapUsedBytes": 69375892,
      "domNodes": 24,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 11.623999999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1995.9410000000162,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.687000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 394.28799999999995,
      "heapDeltaBytes": 5159076,
      "heapUsedBytes": 69330696,
      "domNodes": 20,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 13.732000000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1685.1009999999746,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 26.723999999999997,
      "layouts": 16,
      "layoutDurationMs": 3.151,
      "taskDurationMs": 625.516,
      "heapDeltaBytes": -16517224,
      "heapUsedBytes": 47607940,
      "domNodes": -280,
      "jsHeapTotalBytes": 23834624,
      "scriptDurationMs": 72.50200000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1700.6809999999746,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 30.520000000000003,
      "layouts": 16,
      "layoutDurationMs": 4.119000000000001,
      "taskDurationMs": 631.098,
      "heapDeltaBytes": -3983128,
      "heapUsedBytes": 60209348,
      "domNodes": 60,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 79.62799999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1218.494000000021,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 24.818,
      "layouts": 14,
      "layoutDurationMs": 9.520000000000001,
      "taskDurationMs": 787.361,
      "heapDeltaBytes": 8447076,
      "heapUsedBytes": 100416188,
      "domNodes": 13673,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 29.924000000000007,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 84,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8106.919000000005,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.845,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3533.6569999999997,
      "heapDeltaBytes": 9571524,
      "heapUsedBytes": 71166772,
      "domNodes": -279,
      "jsHeapTotalBytes": 6328320,
      "scriptDurationMs": 1093.338,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8122.532000000036,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 37.519,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3660.4869999999996,
      "heapDeltaBytes": 7495780,
      "heapUsedBytes": 67071776,
      "domNodes": -280,
      "jsHeapTotalBytes": 4755456,
      "scriptDurationMs": 1093.893,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14697.589999999991,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14681.225999999999,
      "heapDeltaBytes": -37087140,
      "heapUsedBytes": 167166164,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9375744,
      "scriptDurationMs": 457.36600000000004,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14723.270999999953,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14713.244999999999,
      "heapDeltaBytes": -40325008,
      "heapUsedBytes": 159844812,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9904128,
      "scriptDurationMs": 445.90500000000003,
      "eventListeners": -16391,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16949.99999999999,
      "styleRecalcs": 113,
      "styleRecalcDurationMs": 14.209,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16922.772,
      "heapDeltaBytes": -51109836,
      "heapUsedBytes": 176640000,
      "domNodes": -8312,
      "jsHeapTotalBytes": -8138752,
      "scriptDurationMs": 719.99,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17175.506999999925,
      "styleRecalcs": 118,
      "styleRecalcDurationMs": 14.890999999999988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17155.561999999998,
      "heapDeltaBytes": -22127344,
      "heapUsedBytes": 176614796,
      "domNodes": -8312,
      "jsHeapTotalBytes": -8400896,
      "scriptDurationMs": 700.8100000000001,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 38,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 452.7680000000487,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 18.058,
      "layouts": 3,
      "layoutDurationMs": 0.9850000000000002,
      "taskDurationMs": 104.61999999999999,
      "heapDeltaBytes": 5458084,
      "heapUsedBytes": 68525836,
      "domNodes": 159,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 9.398,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "workflow-execution",
      "durationMs": 82.35600000000431,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 8.877999999999998,
      "layouts": 1,
      "layoutDurationMs": 0.289,
      "taskDurationMs": 54.88599999999999,
      "heapDeltaBytes": 3128652,
      "heapUsedBytes": 66311404,
      "domNodes": 106,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 3.937999999999999,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@codecov

codecov Bot commented Aug 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../components/TopUpCreditsDialogContentWorkspace.vue 0.00% 1 Missing ⚠️
@@                         Coverage Diff                          @@
##           dante01yoon/test-billing-e2e-matrix   #14815   +/-   ##
====================================================================
  Coverage                                78.71%   78.71%           
====================================================================
  Files                                     1804     1804           
  Lines                                   107023   107023           
  Branches                                 30683    30683           
====================================================================
  Hits                                     84238    84238           
  Misses                                   22330    22330           
  Partials                                   455      455           
Flag Coverage Δ
unit 71.54% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../components/TopUpCreditsDialogContentWorkspace.vue 61.44% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.49 labels Aug 5, 2026
## Summary

Adds deterministic browser coverage for the current-main partner-node,
top-up, and responsive billing-cycle workflows. This PR is stacked on
the isolated maximum-warning prerequisite #14815, which is itself
stacked on #14713 so the Cloud Team recovery-banner slice remains
independently reviewable.

## Why this is needed

These journeys span stateful API polling, exact currency payloads,
workspace-scoped balances, partner-node recovery, permission boundaries,
and responsive pricing interactions. Main and #14713 did not
deterministically exercise them, leaving regressions dependent on live
billing state and timing.

The maximum top-up test also exposed a current frontend bug: manually
entering an amount at or above $10,000 clamps the input correctly, but
the enterprise guidance was unreachable because the warning only
appeared for values strictly greater than the maximum.

## Changes

- Adds a typed stateful billing API fixture for deterministic status,
balance, plans, preview, top-up, subscription, cancellation, and
operation polling responses.
- Adds partner-node coverage for price presentation, prompt execution
request, sufficient-credit balance deduction/refresh,
insufficient-credit recovery after a failed billing refresh, and member
privacy/permissions.
- Adds top-up coverage for exact-cent personal preset/custom payloads,
active Team workspace scoping, pending completion, HTTP failure/retry,
failed operation feedback, and the current $10,000/enterprise contract.
- Adds monthly-to-yearly Creator pricing interaction through the direct
supported pricing route on Cloud desktop and mobile, guarded by nonempty
interactive-plan assertions.
- Depends on #14815, which isolates the `showCeilingWarning` production
prerequisite.

## Root cause and fix

### AS IS

`showCeilingWarning` used `value > MAX_AMOUNT`. Because the input is
clamped to `MAX_AMOUNT`, the observable value could never remain above
the cap, hiding the warning and Contact us link at $10,000.

[AS IS
screenshot](https://ampcode.com/user-content/artifacts/6f5bcdc4d255307bdaed598273b88977160cebe70cc89f89baa56c5330e79c0f-file.png)

### TO BE

The warning uses `value >= MAX_AMOUNT`, preserving the cap while
exposing enterprise billing guidance at the reachable maximum.

[TO BE
screenshot](https://ampcode.com/user-content/artifacts/4ef8548ce8b54dee264330d27bcef202cc5633667fecacd04c46d170a3a4b44b-file.png)

## Review focus

- Stateful billing operation polling and mocked balance
refresh/deduction behavior.
- Team member permission/privacy expectations.
- The one-line maximum-warning prerequisite is isolated in #14815.
- #14526 is an active draft for a future saved-payment-method UI
contract with component tests; these browser tests remain scoped to
current-main behavior and do not mock provider metering.
- Workspace Activity API wiring and browser coverage are isolated in
#14811 and #14813 rather than duplicated here.

## Validation

- `pnpm typecheck` and `pnpm typecheck:browser`
- Focused Cloud partner-node/top-up/pricing Playwright
- Pricing mobile-chrome repeated 3 times and Cloud once after the
responsive route fix
- ESLint, oxfmt, oxlint, knip, and `git diff --check`

## Stacking

- Base: `dante/topup-max-enterprise-warning` (#14815)
- #14815 is based on `dante01yoon/test-billing-e2e-matrix` (#14713)
- Workspace Activity prerequisite/tests: #14811 → #14813

---------

Co-authored-by: Amp <amp@ampcode.com>
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Aug 7, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor

Working the pre-17600 backlog — this is the last item on it. Recommending revive: the bug is live on main, and it is reachable by an ordinary customer action.

Your root-cause analysis checks out, and we traced the mechanism end to end rather than taking it.

TopUpCreditsDialogContentWorkspace.vue binds both events on the same stepper:

@update:model-value="handlePayAmountChange"
@max-reached="showCeilingWarning = true"

and handlePayAmountChange on main clears unconditionally:

function handlePayAmountChange(value: number) {
  payAmount.value = value
  selectedPreset.value = null
  showCeilingWarning.value = false      // ← main
}

The ordering is what makes it unreachable, and it is decided inside the stepper:

// FormattedNumberStepper.vue:145-149
if (wasClamped) {
  emit('max-reached')     // sets showCeilingWarning = true
}
modelValue.value = clamped // emits update:model-value → handlePayAmountChange → sets it false

emit('max-reached') fires first, then the assignment to modelValue emits update:model-value in the same synchronous handler. So the warning is set and cleared before anything renders. There is no timing window in which it can appear.

What that means for a customer: someone typing 50000 into the amount field is silently clamped to $10,000 with no explanation and no Contact-us route. That is exactly the customer the enterprise guidance exists for — the one trying to spend more than self-serve allows — and they are the one who never sees it.

Your fix is order-independent rather than a reordering, which is the right call:

showCeilingWarning.value = value >= MAX_AMOUNT

It also covers a case the original bug report does not: landing exactly on the cap by stepping, where wasClamped is false and max-reached never fires at all. So the >= is doing real work rather than being a defensive widening.

The diff reads as +1555/−38, but the production change is one line in one file. Everything else is the E2E fixture and spec scaffolding for the follow-up coverage. Worth saying because the size makes it look like a much bigger revive than it is.

Recommend rebasing and landing it. If the E2E half is the expensive part of the rebase, the one-line production fix stands alone and would be worth landing on its own.


This was the last undispositioned item in the pre-17600 backlog. Everything in it now has a recommendation with evidence on the PR; none of it needs more review, all of it needs decisions. Summarised in christian-byrne/blocked-on-christian#778.

@dante01yoon dante01yoon closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants