Repository navigation
[backport core/1.49] FE-1251 feat: add flagged payment recovery UI - #14799
Conversation
## Summary Adds the independently flagged frontend slice for Payment Recovery US1 and US3: unattended renewal-failure visibility and role-safe paused-workspace run recovery, without depending on #14091. ### Root cause and why this is needed Payment recovery states were coupled to `billing_control_enabled`, which is the rollout control for existing out-of-credits and subscription-ending notices. Paused workspaces also fell through the generic inactive path, replacing the entire queue group with `Subscribe to Run`. This hid batch/queue controls and exposed generic subscription/payment language to members instead of the required role-safe recovery UX. ### How this changes - Adds the authenticated server flag key `v1_payment_recovery`, exposed as `flags.v1PaymentRecovery` with the normal `ff:v1_payment_recovery` local override. - Gates only `payment_failed` and `paused` banners/run-lock behavior with the new flag; existing out-of-credits, ending, and generic inactive behavior remain on their existing paths. - Shows billing managers a non-dismissible `Payment failed` banner with `Update payment`; returning focus refetches status/balance while that banner is visible. - Keeps the queue group mounted when paused. Existing auto-run mode is reset and the visible dropdown is locked so no queued execution bypasses recovery. - Gives owners a gold `Update payment to run` action and portal recovery dialog; members see a gray locked `Run` action and a billing-private `Subscription paused` explainer with `Ok, got it`. - Uses the existing billing portal action, which opens Stripe Billing Portal in a new tab. ### API / backend boundary This PR consumes existing `billing_status` values (`payment_failed`, `paused`) and the existing payment-portal endpoint. Backend/remote config must deliver `v1_payment_recovery`. It does not implement dunning, recovery state transitions, or server mechanics. PR #14091 remains separate transactional-decline work; this PR has no dependency on its dialog or implementation. ## Changes - **What**: Flag wiring, payment recovery banner derivation/focus refresh, paused queue lock, owner/member recovery dialog, focused unit/component coverage. ## Review Focus - Recovery states are independent from `billing_control_enabled` while unrelated states preserve existing gates. - Paused owner/member flows cannot submit via primary action or Run-on-Change, but batch/dropdown controls stay mounted. - Members receive no payment-declined, card, or payment-method details. ## Screenshots Captured in the real cloud application with billing/workspace endpoints mocked through the repository's Playwright fixtures; no Storybook state was used. ### AS IS — paused owner uses generic inactive replacement  ### TO BE — paused owner queue lock and recovery   ### TO BE — paused member privacy-safe explainer  ## Validation - `pnpm typecheck` - `pnpm lint:unstaged` - 101 focused unit/component tests - 2 real-app Playwright cloud scenarios (paused owner/member) - `pnpm exec oxfmt --check` on touched files - `git diff --check` `pnpm typecheck:browser` is currently blocked by pre-existing `BillingStatusResponse` fixture drift on `main` (existing fixtures are missing newly required seat fields); the added Playwright fixture itself was exercised successfully before being kept out of this focused diff. --------- Co-authored-by: Amp <amp@ampcode.com>
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1785 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-05T12:25:14.088Z",
"gitSha": "bde8e527984ead6c3d999dcac3403fbc54b15dcc",
"branch": "backport-14701-to-core-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.9850000000247,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.543000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.768,
"heapDeltaBytes": 5155756,
"heapUsedBytes": 73206304,
"domNodes": 18,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 22.512,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2054.2649999999867,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.232000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.415,
"heapDeltaBytes": 5190572,
"heapUsedBytes": 73308336,
"domNodes": 18,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 22.641000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2050.795999999991,
"styleRecalcs": 79,
"styleRecalcDurationMs": 47.952,
"layouts": 12,
"layoutDurationMs": 3.881,
"taskDurationMs": 1065.999,
"heapDeltaBytes": -17315232,
"heapUsedBytes": 50716672,
"domNodes": -280,
"jsHeapTotalBytes": 21479424,
"scriptDurationMs": 139.58399999999997,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1885.375999999951,
"styleRecalcs": 74,
"styleRecalcDurationMs": 38.098000000000006,
"layouts": 12,
"layoutDurationMs": 3.313,
"taskDurationMs": 926.1590000000001,
"heapDeltaBytes": -16330484,
"heapUsedBytes": 51877920,
"domNodes": -282,
"jsHeapTotalBytes": 20955136,
"scriptDurationMs": 127.647,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1694.0830000000915,
"styleRecalcs": 29,
"styleRecalcDurationMs": 17.86,
"layouts": 6,
"layoutDurationMs": 0.591,
"taskDurationMs": 444.92099999999994,
"heapDeltaBytes": 8080336,
"heapUsedBytes": 76257440,
"domNodes": 77,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 25.174,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.2649999999985,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.303,
"layouts": 6,
"layoutDurationMs": 0.593,
"taskDurationMs": 399.291,
"heapDeltaBytes": 8143272,
"heapUsedBytes": 76304988,
"domNodes": 77,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 22.151000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 626.8489999999929,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.456,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.81999999999994,
"heapDeltaBytes": -12056676,
"heapUsedBytes": 55965060,
"domNodes": 22,
"jsHeapTotalBytes": 21352448,
"scriptDurationMs": 61.987,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 605.4249999999683,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.668000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.919,
"heapDeltaBytes": -12167664,
"heapUsedBytes": 55972260,
"domNodes": 20,
"jsHeapTotalBytes": 21876736,
"scriptDurationMs": 63.502,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2029.1780000000017,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.452,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 680.8700000000001,
"heapDeltaBytes": 8257488,
"heapUsedBytes": 67674004,
"domNodes": -284,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 108.81099999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2049.2380000000594,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.066000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 789.217,
"heapDeltaBytes": 8318124,
"heapUsedBytes": 67601744,
"domNodes": -281,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 131.96099999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2202.184999999986,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.464999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1320.5249999999999,
"heapDeltaBytes": 5334676,
"heapUsedBytes": 65509248,
"domNodes": -285,
"jsHeapTotalBytes": 5263360,
"scriptDurationMs": 436.71099999999996,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2219.7989999999663,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.124,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1368.211,
"heapDeltaBytes": 5169500,
"heapUsedBytes": 65660276,
"domNodes": -286,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 464.238,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3445.378000000005,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.497,
"layouts": 60,
"layoutDurationMs": 7.825,
"taskDurationMs": 1690.9050000000002,
"heapDeltaBytes": 10019272,
"heapUsedBytes": 72287132,
"domNodes": -287,
"jsHeapTotalBytes": 7921664,
"scriptDurationMs": 618.9789999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3313.8950000000023,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.697999999999995,
"layouts": 60,
"layoutDurationMs": 7.271000000000001,
"taskDurationMs": 1584.0459999999998,
"heapDeltaBytes": 5185788,
"heapUsedBytes": 67121216,
"domNodes": -289,
"jsHeapTotalBytes": 7397376,
"scriptDurationMs": 555.1320000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2035.502000000065,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.025999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 785.9659999999999,
"heapDeltaBytes": 8212520,
"heapUsedBytes": 69478888,
"domNodes": -284,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 127.494,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2040.982000000099,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.358,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 746.095,
"heapDeltaBytes": 8071052,
"heapUsedBytes": 69586072,
"domNodes": -284,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 125.01800000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 628.4030000000485,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.154,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.37,
"heapDeltaBytes": -11868964,
"heapUsedBytes": 56301464,
"domNodes": 18,
"jsHeapTotalBytes": 22401024,
"scriptDurationMs": 121.979,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 585.0379999999404,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.002999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.75,
"heapDeltaBytes": -12459524,
"heapUsedBytes": 56054300,
"domNodes": 20,
"jsHeapTotalBytes": 22663168,
"scriptDurationMs": 117.062,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2033.2880000000273,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.521999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.7299999999999,
"heapDeltaBytes": 4782324,
"heapUsedBytes": 73208400,
"domNodes": 20,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 15.443,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.912999999964,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.401,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.37100000000004,
"heapDeltaBytes": 4740580,
"heapUsedBytes": 73144608,
"domNodes": 18,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 18.825000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.601000000001,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.59700000000001,
"layouts": 16,
"layoutDurationMs": 4.348,
"taskDurationMs": 784.474,
"heapDeltaBytes": -4455352,
"heapUsedBytes": 64010328,
"domNodes": 64,
"jsHeapTotalBytes": 20828160,
"scriptDurationMs": 94.18700000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1733.7989999999763,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.948,
"layouts": 16,
"layoutDurationMs": 4.494,
"taskDurationMs": 864.671,
"heapDeltaBytes": -22149844,
"heapUsedBytes": 46139364,
"domNodes": 62,
"jsHeapTotalBytes": 20168704,
"scriptDurationMs": 97.65899999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1438.3839999999282,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.846,
"layouts": 15,
"layoutDurationMs": 12.994000000000002,
"taskDurationMs": 1034.4399999999998,
"heapDeltaBytes": 30685132,
"heapUsedBytes": 99546900,
"domNodes": 13673,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 55.99599999999999,
"eventListeners": 2375,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8850.39999999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.204,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5016.255,
"heapDeltaBytes": 19496896,
"heapUsedBytes": 78875328,
"domNodes": -281,
"jsHeapTotalBytes": 7852032,
"scriptDurationMs": 1590.914,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8449.477000000003,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.657999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4758.428,
"heapDeltaBytes": 18284552,
"heapUsedBytes": 77597756,
"domNodes": -283,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 1533.056,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17465.688000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17438.083,
"heapDeltaBytes": -44830840,
"heapUsedBytes": 166043460,
"domNodes": -8312,
"jsHeapTotalBytes": -10428416,
"scriptDurationMs": 610.4130000000001,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17631.43600000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17604.532,
"heapDeltaBytes": -45900680,
"heapUsedBytes": 167632688,
"domNodes": -8312,
"jsHeapTotalBytes": -9117696,
"scriptDurationMs": 631.8269999999999,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21275.13399999998,
"styleRecalcs": 151,
"styleRecalcDurationMs": 19.477999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21223.124,
"heapDeltaBytes": -45883664,
"heapUsedBytes": 164258316,
"domNodes": -8312,
"jsHeapTotalBytes": -11476992,
"scriptDurationMs": 915.183,
"eventListeners": -16385,
"totalBlockingTimeMs": 358,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21804.059000000052,
"styleRecalcs": 157,
"styleRecalcDurationMs": 20.566000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21760.019,
"heapDeltaBytes": -24313452,
"heapUsedBytes": 176888824,
"domNodes": -8312,
"jsHeapTotalBytes": -15478784,
"scriptDurationMs": 931.328,
"eventListeners": -16381,
"totalBlockingTimeMs": 535,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 486.43300000003364,
"styleRecalcs": 14,
"styleRecalcDurationMs": 22.087999999999997,
"layouts": 2,
"layoutDurationMs": 0.38100000000000006,
"taskDurationMs": 137.755,
"heapDeltaBytes": -15498356,
"heapUsedBytes": 51748132,
"domNodes": 132,
"jsHeapTotalBytes": 7196672,
"scriptDurationMs": 12.188999999999998,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 459.5640000000003,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.240000000000002,
"layouts": 3,
"layoutDurationMs": 0.6380000000000001,
"taskDurationMs": 121.55499999999999,
"heapDeltaBytes": -15771304,
"heapUsedBytes": 51567008,
"domNodes": 123,
"jsHeapTotalBytes": 6934528,
"scriptDurationMs": 9.14,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.49 #14799 +/- ##
=============================================
+ Coverage 78.74% 78.75% +0.01%
=============================================
Files 1790 1791 +1
Lines 104458 104546 +88
Branches 32032 32065 +33
=============================================
+ Hits 82251 82338 +87
- Misses 21777 21778 +1
Partials 430 430
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #14701 to
core/1.49Automatically created by backport workflow.