Repository navigation
FE-1251 feat: add flagged payment recovery UI - #14701
Conversation
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fcd78-f172-70fb-9190-7fb1960fa77b
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.25 MB gzip 🔴 +2.34 kBDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.35 MB (baseline 1.35 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 112 kB (baseline 112 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 551 kB (baseline 551 kB) • 🔴 +206 BConfiguration panels, inspectors, and settings screens
Status: 12 added / 12 removed / 14 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 4 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 6 added / 6 removed / 1 unchanged UI Components — 72.1 kB (baseline 71.1 kB) • 🔴 +1.03 kBReusable component library chunks
Status: 8 added / 8 removed / 7 unchanged Data & Services — 3.48 MB (baseline 3.48 MB) • 🔴 +22 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 386 kB (baseline 386 kB) • 🔴 +250 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 17 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • 🔴 +6.26 kBBundles that do not match a named category
Status: 86 added / 86 removed / 195 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-04T23:09:53.639Z",
"gitSha": "b648d7ed0d131ad2b39abb78906f666b3fd84117",
"branch": "dante01yoon/payment-recovery-us1-us3",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2128.3970000000068,
"styleRecalcs": 5,
"styleRecalcDurationMs": 8.270000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.385,
"heapDeltaBytes": 5769700,
"heapUsedBytes": 70145364,
"domNodes": 10,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 19.699,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2042.8660000000036,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.012999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.4649999999999,
"heapDeltaBytes": 5609764,
"heapUsedBytes": 69673296,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 19.791,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1925.643000000008,
"styleRecalcs": 76,
"styleRecalcDurationMs": 39.861,
"layouts": 12,
"layoutDurationMs": 3.972,
"taskDurationMs": 973.361,
"heapDeltaBytes": -12836240,
"heapUsedBytes": 51189724,
"domNodes": -284,
"jsHeapTotalBytes": 24358912,
"scriptDurationMs": 123.67399999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1972.8929999999991,
"styleRecalcs": 79,
"styleRecalcDurationMs": 47.152,
"layouts": 12,
"layoutDurationMs": 4.012,
"taskDurationMs": 985.2439999999999,
"heapDeltaBytes": -12565196,
"heapUsedBytes": 51404492,
"domNodes": -281,
"jsHeapTotalBytes": 24096768,
"scriptDurationMs": 132.937,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1751.0760000000118,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.667,
"layouts": 6,
"layoutDurationMs": 0.7049999999999998,
"taskDurationMs": 414.694,
"heapDeltaBytes": 8616236,
"heapUsedBytes": 72691816,
"domNodes": 76,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 21.090999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1771.1780000000772,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.028000000000002,
"layouts": 6,
"layoutDurationMs": 0.654,
"taskDurationMs": 425.948,
"heapDeltaBytes": 8684400,
"heapUsedBytes": 72694116,
"domNodes": 78,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 23.461999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 594.1300000000069,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.221000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.44300000000004,
"heapDeltaBytes": -11017636,
"heapUsedBytes": 53041672,
"domNodes": 18,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 65.243,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 588.903000000073,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.113000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.383,
"heapDeltaBytes": -11061308,
"heapUsedBytes": 52994284,
"domNodes": 16,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 57.80800000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2039.652999999987,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.24,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 736.2489999999999,
"heapDeltaBytes": 7994272,
"heapUsedBytes": 67679812,
"domNodes": -285,
"jsHeapTotalBytes": 3776512,
"scriptDurationMs": 114.16000000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2025.7810000000518,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.401999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 698.7760000000001,
"heapDeltaBytes": 6951856,
"heapUsedBytes": 66258964,
"domNodes": -283,
"jsHeapTotalBytes": 2465792,
"scriptDurationMs": 103.03299999999999,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2181.418000000008,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.016000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1309.714,
"heapDeltaBytes": 4153688,
"heapUsedBytes": 64926304,
"domNodes": -283,
"jsHeapTotalBytes": 3706880,
"scriptDurationMs": 429.151,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2142.0779999999695,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.274,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1280.4879999999998,
"heapDeltaBytes": 1624632,
"heapUsedBytes": 62588636,
"domNodes": -284,
"jsHeapTotalBytes": 3706880,
"scriptDurationMs": 410.827,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3185.001999999997,
"styleRecalcs": 66,
"styleRecalcDurationMs": 17.435999999999996,
"layouts": 60,
"layoutDurationMs": 8.666,
"taskDurationMs": 1430.3029999999999,
"heapDeltaBytes": -3893368,
"heapUsedBytes": 58114204,
"domNodes": -287,
"jsHeapTotalBytes": 6397952,
"scriptDurationMs": 540.621,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3147.4150000000236,
"styleRecalcs": 64,
"styleRecalcDurationMs": 16.212,
"layouts": 60,
"layoutDurationMs": 8.56,
"taskDurationMs": 1596.967,
"heapDeltaBytes": -6290400,
"heapUsedBytes": 56406228,
"domNodes": -288,
"jsHeapTotalBytes": 6397952,
"scriptDurationMs": 550.3629999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2080.9619999999995,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.646000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 758.181,
"heapDeltaBytes": 7436136,
"heapUsedBytes": 68017996,
"domNodes": -284,
"jsHeapTotalBytes": 3252224,
"scriptDurationMs": 118.62,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2029.0599999999586,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.234,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 735.1990000000001,
"heapDeltaBytes": 6872184,
"heapUsedBytes": 68018800,
"domNodes": -284,
"jsHeapTotalBytes": 3252224,
"scriptDurationMs": 113.323,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 623.2800000000225,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.075,
"heapDeltaBytes": -10421604,
"heapUsedBytes": 53759000,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 141.27800000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.629999999991,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.715000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.6070000000001,
"heapDeltaBytes": -10496020,
"heapUsedBytes": 53767484,
"domNodes": 18,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 124.619,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.296999999951,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.28299999999996,
"heapDeltaBytes": 5229004,
"heapUsedBytes": 69604060,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 15.723,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2002.2920000000113,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.975999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.024,
"heapDeltaBytes": 5110904,
"heapUsedBytes": 69191992,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 20.515,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1751.7139999999927,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.042,
"layouts": 16,
"layoutDurationMs": 4.573,
"taskDurationMs": 847.869,
"heapDeltaBytes": -17450732,
"heapUsedBytes": 46589868,
"domNodes": -278,
"jsHeapTotalBytes": 23834624,
"scriptDurationMs": 96.748,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1767.0360000000755,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.287,
"layouts": 16,
"layoutDurationMs": 5.0520000000000005,
"taskDurationMs": 835.4979999999999,
"heapDeltaBytes": -17710596,
"heapUsedBytes": 46408596,
"domNodes": -282,
"jsHeapTotalBytes": 23048192,
"scriptDurationMs": 99.553,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.6349999999752,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.474,
"layouts": 14,
"layoutDurationMs": 11.431000000000001,
"taskDurationMs": 970.8619999999999,
"heapDeltaBytes": 30644440,
"heapUsedBytes": 97730000,
"domNodes": 13673,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 37.772,
"eventListeners": 2375,
"totalBlockingTimeMs": 118,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8251.265000000047,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.038000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4543.978,
"heapDeltaBytes": 9087808,
"heapUsedBytes": 68431092,
"domNodes": -281,
"jsHeapTotalBytes": 6328320,
"scriptDurationMs": 1374.177,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8234.810999999921,
"styleRecalcs": 249,
"styleRecalcDurationMs": 43.61,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4146.618,
"heapDeltaBytes": 12866252,
"heapUsedBytes": 72488288,
"domNodes": -283,
"jsHeapTotalBytes": 6590464,
"scriptDurationMs": 1469.541,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18282.646999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18249.298000000003,
"heapDeltaBytes": -48653400,
"heapUsedBytes": 154517484,
"domNodes": -8312,
"jsHeapTotalBytes": -7540736,
"scriptDurationMs": 531.35,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18284.132999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18264.622,
"heapDeltaBytes": -48408304,
"heapUsedBytes": 167495080,
"domNodes": -8312,
"jsHeapTotalBytes": -7806976,
"scriptDurationMs": 563.909,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23006.84199999995,
"styleRecalcs": 174,
"styleRecalcDurationMs": 26.553999999999967,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22982.457000000002,
"heapDeltaBytes": -22352648,
"heapUsedBytes": 176629092,
"domNodes": -8312,
"jsHeapTotalBytes": -7614464,
"scriptDurationMs": 973.3739999999999,
"eventListeners": -16379,
"totalBlockingTimeMs": 965,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22742.729000000054,
"styleRecalcs": 167,
"styleRecalcDurationMs": 25.065999999999978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22688.814000000002,
"heapDeltaBytes": -53305484,
"heapUsedBytes": 170505468,
"domNodes": -8312,
"jsHeapTotalBytes": -11022336,
"scriptDurationMs": 940.379,
"eventListeners": -16383,
"totalBlockingTimeMs": 782,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 457.650000000001,
"styleRecalcs": 15,
"styleRecalcDurationMs": 20.426999999999996,
"layouts": 2,
"layoutDurationMs": 0.3699999999999999,
"taskDurationMs": 119.80700000000002,
"heapDeltaBytes": 5312204,
"heapUsedBytes": 68541768,
"domNodes": 136,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.741,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 453.5000000000764,
"styleRecalcs": 14,
"styleRecalcDurationMs": 21.061999999999998,
"layouts": 3,
"layoutDurationMs": 0.7129999999999999,
"taskDurationMs": 112.19600000000001,
"heapDeltaBytes": 5077808,
"heapUsedBytes": 68348004,
"domNodes": 123,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.700000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎭 Playwright: ✅ 1785 passed, 0 failed · 3 flaky📊 Browser Reports
|
🎭 Playwright: ⏳ Running... |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds feature-flagged payment recovery for paused subscriptions. Billing banners refresh payment status on focus. The run button locks execution and opens owner/member recovery messaging. ChangesPayment recovery
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant ComfyQueueButton
participant CloudRunButtonWrapper
participant SubscriptionPausedDialog
participant BillingContext
BillingContext-->>CloudRunButtonWrapper: paused billing status
CloudRunButtonWrapper->>ComfyQueueButton: set payment recovery lock
User->>ComfyQueueButton: click locked run button
ComfyQueueButton->>CloudRunButtonWrapper: emit paymentRecoveryClick
CloudRunButtonWrapper->>SubscriptionPausedDialog: open dialog
User->>SubscriptionPausedDialog: select recovery action
SubscriptionPausedDialog->>CloudRunButtonWrapper: update payment or close
CloudRunButtonWrapper->>BillingContext: manage subscription
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/actionbar/ComfyRunButton/CloudRunButtonWrapper.vue`:
- Around line 41-44: Update updatePayment to handle and surface rejections from
manageSubscription before closing the payment recovery dialog; do not fire it
with an unhandled void promise, and ensure failures receive the existing
user-facing error handling while successful navigation preserves the current
behavior.
In `@src/platform/workspace/components/SubscriptionPausedDialog.test.ts`:
- Around line 40-67: Add a behavioral test for the visible Close button in the
SubscriptionPausedDialog tests, using renderDialog to obtain onClose, clicking
the button with accessible name “Close,” and asserting onClose is called once.
Keep this separate from the existing primary-action tests so the close handler
is directly covered.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 24dce2fa-2469-4fc5-a022-196131b1abf1
📒 Files selected for processing (17)
src/components/actionbar/ComfyRunButton/CloudRunButtonWrapper.test.tssrc/components/actionbar/ComfyRunButton/CloudRunButtonWrapper.vuesrc/components/actionbar/ComfyRunButton/ComfyQueueButton.test.tssrc/components/actionbar/ComfyRunButton/ComfyQueueButton.vuesrc/composables/useFeatureFlags.test.tssrc/composables/useFeatureFlags.tssrc/locales/en/main.jsonsrc/platform/remoteConfig/refreshRemoteConfig.tssrc/platform/remoteConfig/remoteConfig.tssrc/platform/remoteConfig/types.tssrc/platform/workspace/components/SubscriptionPausedDialog.test.tssrc/platform/workspace/components/SubscriptionPausedDialog.vuesrc/platform/workspace/components/dialogs/settings/BillingStatusBanner.test.tssrc/platform/workspace/composables/deriveBillingBanner.test.tssrc/platform/workspace/composables/useBillingBanner.test.tssrc/platform/workspace/composables/useBillingBanner.tssrc/storybook/mocks/useFeatureFlags.ts
Amp-Thread-ID: https://ampcode.com/threads/T-019fcd78-f172-70fb-9190-7fb1960fa77b Co-authored-by: Amp <amp@ampcode.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/actionbar/ComfyRunButton/CloudRunButtonWrapper.test.ts`:
- Line 152: Update the owner-case test around the queue-button interaction to
query the recovery control by its accessible role and name, using the button
labeled “Update payment to run” instead of getByTestId('queue-button').
In `@src/components/actionbar/ComfyRunButton/CloudRunButtonWrapper.vue`:
- Around line 43-50: Update the owner portal flow around updatePayment and the
corresponding SubscriptionPausedDialog action to track the active
manageSubscription request, disable the owner action while it is pending, and
reuse or await the existing request on repeated clicks instead of issuing
another portal URL request. Keep the pending state synchronized when the dialog
closes and reopens, and add coverage for rapid clicks plus close/reopen while
the request remains pending.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 5c698cf9-1fea-45a1-aae1-5a5629ace133
📒 Files selected for processing (3)
src/components/actionbar/ComfyRunButton/CloudRunButtonWrapper.test.tssrc/components/actionbar/ComfyRunButton/CloudRunButtonWrapper.vuesrc/platform/workspace/components/SubscriptionPausedDialog.test.ts
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #14701 +/- ##
==========================================
- Coverage 78.64% 78.54% -0.11%
==========================================
Files 1790 1795 +5
Lines 104690 105653 +963
Branches 32118 33360 +1242
==========================================
+ Hits 82335 82982 +647
- Misses 21916 22217 +301
- Partials 439 454 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 48 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Amp-Thread-ID: https://ampcode.com/threads/T-019fcd78-f172-70fb-9190-7fb1960fa77b Co-authored-by: Amp <amp@ampcode.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/actionbar/ComfyRunButton/CloudRunButtonWrapper.vue`:
- Around line 45-65: Track wrapper disposal with an unmount flag in
CloudRunButtonWrapper and set it from onUnmounted(); in updatePayment(), skip
closePaymentRecoveryDialog(), toastErrorHandler(), and
dialogStore.updateDialog() completion updates when disposed, while preserving
request cleanup. In
src/components/actionbar/ComfyRunButton/CloudRunButtonWrapper.test.ts lines
168-204, add coverage that replaces the wrapper, waits for manageSubscription,
resolves the stale request, and verifies the replacement subscription-paused
dialog remains unchanged.
In `@src/platform/workspace/components/SubscriptionPausedDialog.vue`:
- Around line 39-45: Remove the aria-label binding from the visible CTA in
SubscriptionPausedDialog, while preserving its translated button text and the
aria-label on the icon-only close button.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: a4bb8f15-3df3-44ec-91f2-cb168323eadd
📒 Files selected for processing (4)
src/components/actionbar/ComfyRunButton/CloudRunButtonWrapper.test.tssrc/components/actionbar/ComfyRunButton/CloudRunButtonWrapper.vuesrc/platform/workspace/components/SubscriptionPausedDialog.test.tssrc/platform/workspace/components/SubscriptionPausedDialog.vue
Amp-Thread-ID: https://ampcode.com/threads/T-019fcd78-f172-70fb-9190-7fb1960fa77b Co-authored-by: Amp <amp@ampcode.com>
huang47
left a comment
There was a problem hiding this comment.
Requesting changes for the paused-owner recovery path. Current-head visual evidence.
Amp-Thread-ID: https://ampcode.com/threads/T-019fcd78-f172-70fb-9190-7fb1960fa77b Co-authored-by: Amp <amp@ampcode.com>
|
The new lock labels ("Update payment to run" / member "Run") render thinner than "Subscribe to Run". Cause: they inherit Fix: use medium weight when |
There was a problem hiding this comment.
Design follow-ups to match the settled recovery matrix:
- Payment-failed banner: drop the
warning.bodydate variant. Pause is now immediate on a failed renewal, so "will pause on {date}" can never be true — a failed renewal surfaces as the paused banner directly. ShipbodyNoDateas the only payment-failed copy; the state's remaining producer is auto-reload. - Paused dialog CTA:
invertedinstead ofsubscribe— suggestion inline. I think gold is reserved for the run-button family; I'll need to verify that. For now let's have the dialog's Update payment matching the paused banner's CTA — same action, same portal destination.
Amp-Thread-ID: https://ampcode.com/threads/T-019fcd78-f172-70fb-9190-7fb1960fa77b Co-authored-by: Amp <amp@ampcode.com>
|
Addressed the remaining design follow-ups in
Focused component tests (28), typecheck, lint, formatting, commit hooks, and knip pass. |
huang47
left a comment
There was a problem hiding this comment.
Could we confirm v1_payment_recovery reaches at least the current billing_control_enabled rollout before deployment, or add a temporary OR fallback during rollout? Otherwise paused / payment_failed users without the new flag lose the shipped banners. Current-head route-mocked screenshot.
Please squash-merge the five follow-up fixes so known-broken intermediate commits do not remain in history.
|
Deployment prerequisite acknowledged: The PR remains configured for a squash merge so the follow-up fixes land as one commit. I am leaving the approved PR unmerged per the requested ready-to-merge delivery boundary. |
|
@dante01yoon Successfully backported to #14799 |
|
@dante01yoon Successfully backported to #14800 |


Summary
Adds the independently flagged frontend slice for Payment Recovery US1 and US3: unattended renewal-failure visibility and role-safe paused-workspace run recovery, without depending on #14091.
Root cause and why this is needed
Payment recovery states were coupled to
billing_control_enabled, which is the rollout control for existing out-of-credits and subscription-ending notices. Paused workspaces also fell through the generic inactive path, replacing the entire queue group withSubscribe to Run. This hid batch/queue controls and exposed generic subscription/payment language to members instead of the required role-safe recovery UX.How this changes
v1_payment_recovery, exposed asflags.v1PaymentRecoverywith the normalff:v1_payment_recoverylocal override.payment_failedandpausedbanners/run-lock behavior with the new flag; existing out-of-credits, ending, and generic inactive behavior remain on their existing paths.Payment failedbanner withUpdate payment; returning focus refetches status/balance while that banner is visible.Update payment to runaction and portal recovery dialog; members see a gray lockedRunaction and a billing-privateSubscription pausedexplainer withOk, got it.API / backend boundary
This PR consumes existing
billing_statusvalues (payment_failed,paused) and the existing payment-portal endpoint. Backend/remote config must deliverv1_payment_recovery. It does not implement dunning, recovery state transitions, or server mechanics. PR #14091 remains separate transactional-decline work; this PR has no dependency on its dialog or implementation.Changes
Review Focus
billing_control_enabledwhile unrelated states preserve existing gates.Screenshots
Captured in the real cloud application with billing/workspace endpoints mocked through the repository's Playwright fixtures; no Storybook state was used.
AS IS — paused owner uses generic inactive replacement
TO BE — paused owner queue lock and recovery
TO BE — paused member privacy-safe explainer
Validation
pnpm typecheckpnpm lint:unstagedpnpm exec oxfmt --checkon touched filesgit diff --checkpnpm typecheck:browseris currently blocked by pre-existingBillingStatusResponsefixture drift onmain(existing fixtures are missing newly required seat fields); the added Playwright fixture itself was exercised successfully before being kept out of this focused diff.