Repository navigation
fix(first-run-tour): let the upload step take the click it asks for - #14685
Conversation
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1786 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 8.24 MB gzip 🟢 -6 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.35 MB (baseline 1.35 MB) • 🟢 -23 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 111 kB (baseline 111 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 16 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 28.7 kB (baseline 28.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 7 unchanged UI Components — 70 kB (baseline 70 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.47 MB (baseline 3.47 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 280 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-04T09:45:21.992Z",
"gitSha": "0da7798fffcc56675693390959b6fb14720aaaf4",
"branch": "fix/first-run-tour-upload-interactive",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.1529999999657,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.158,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.22700000000003,
"heapDeltaBytes": 5310404,
"heapUsedBytes": 69509320,
"domNodes": 16,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 18.673000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2021.7259999999442,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.366,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.90299999999996,
"heapDeltaBytes": 5614452,
"heapUsedBytes": 69774496,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 17.138,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1903.2170000000406,
"styleRecalcs": 79,
"styleRecalcDurationMs": 43.628,
"layouts": 12,
"layoutDurationMs": 3.927,
"taskDurationMs": 924.9580000000001,
"heapDeltaBytes": -11904032,
"heapUsedBytes": 52276240,
"domNodes": -280,
"jsHeapTotalBytes": 24367104,
"scriptDurationMs": 129.427,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1834.4660000000204,
"styleRecalcs": 73,
"styleRecalcDurationMs": 35.809,
"layouts": 12,
"layoutDurationMs": 3.5170000000000003,
"taskDurationMs": 885.146,
"heapDeltaBytes": -11719780,
"heapUsedBytes": 52253772,
"domNodes": -281,
"jsHeapTotalBytes": 22794240,
"scriptDurationMs": 122.86200000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1716.2670000000162,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.782,
"layouts": 6,
"layoutDurationMs": 0.722,
"taskDurationMs": 381.54200000000003,
"heapDeltaBytes": 8606788,
"heapUsedBytes": 72690912,
"domNodes": 74,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 18.91,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.1280000000925,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.496000000000002,
"layouts": 6,
"layoutDurationMs": 0.683,
"taskDurationMs": 408.397,
"heapDeltaBytes": 8610744,
"heapUsedBytes": 72713864,
"domNodes": 75,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 22.09,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 675.5120000000261,
"styleRecalcs": 12,
"styleRecalcDurationMs": 12.464999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.101,
"heapDeltaBytes": -10761056,
"heapUsedBytes": 53261804,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 67.65499999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 591.0959999999932,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.873999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.62,
"heapDeltaBytes": -11202824,
"heapUsedBytes": 53153732,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 61.352000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.4059999999522,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.830999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 701.212,
"heapDeltaBytes": 6991172,
"heapUsedBytes": 66322104,
"domNodes": -281,
"jsHeapTotalBytes": 3784704,
"scriptDurationMs": 111.85499999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.7650000000021,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.082999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 680.892,
"heapDeltaBytes": 6446144,
"heapUsedBytes": 66765856,
"domNodes": -282,
"jsHeapTotalBytes": 2998272,
"scriptDurationMs": 109.29700000000001,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2202.2979999999848,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.625000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1319.6,
"heapDeltaBytes": 5213996,
"heapUsedBytes": 65667284,
"domNodes": -285,
"jsHeapTotalBytes": 3977216,
"scriptDurationMs": 453.01599999999996,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2147.9320000000826,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.075999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1274.505,
"heapDeltaBytes": 2241424,
"heapUsedBytes": 62768164,
"domNodes": -284,
"jsHeapTotalBytes": 4239360,
"scriptDurationMs": 430.053,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3198.395000000005,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.965,
"layouts": 60,
"layoutDurationMs": 7.327999999999999,
"taskDurationMs": 1557.3349999999998,
"heapDeltaBytes": -3085892,
"heapUsedBytes": 59081260,
"domNodes": -287,
"jsHeapTotalBytes": 6144000,
"scriptDurationMs": 543.3520000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3215.49600000003,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.150999999999998,
"layouts": 60,
"layoutDurationMs": 7.417,
"taskDurationMs": 1544.921,
"heapDeltaBytes": -3012608,
"heapUsedBytes": 59437288,
"domNodes": -289,
"jsHeapTotalBytes": 6406144,
"scriptDurationMs": 534.5609999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2068.501000000026,
"styleRecalcs": 10,
"styleRecalcDurationMs": 12.007999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 698.097,
"heapDeltaBytes": 7544736,
"heapUsedBytes": 68055196,
"domNodes": -279,
"jsHeapTotalBytes": 3522560,
"scriptDurationMs": 109.652,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2010.0860000000011,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.231999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 709.2639999999999,
"heapDeltaBytes": 5996880,
"heapUsedBytes": 66444500,
"domNodes": -284,
"jsHeapTotalBytes": 4308992,
"scriptDurationMs": 113.766,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.6520000000023,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.62700000000007,
"heapDeltaBytes": -10703324,
"heapUsedBytes": 53387988,
"domNodes": 20,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 123.65400000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.1069999999745,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.575000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.81600000000003,
"heapDeltaBytes": -10434868,
"heapUsedBytes": 53762792,
"domNodes": 22,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 119.20899999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1995.2819999999747,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.187,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 574.482,
"heapDeltaBytes": 5242820,
"heapUsedBytes": 69462388,
"domNodes": 16,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 19.683,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.6240000000307,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.068999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.67099999999994,
"heapDeltaBytes": 4952420,
"heapUsedBytes": 69424700,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 13.996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1775.6130000000212,
"styleRecalcs": 79,
"styleRecalcDurationMs": 39.888999999999996,
"layouts": 16,
"layoutDurationMs": 4.74,
"taskDurationMs": 803.701,
"heapDeltaBytes": -3973320,
"heapUsedBytes": 60245508,
"domNodes": 67,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 98.199,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.967000000006,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.581,
"layouts": 16,
"layoutDurationMs": 3.8010000000000006,
"taskDurationMs": 812.576,
"heapDeltaBytes": -18166256,
"heapUsedBytes": 46026060,
"domNodes": 21,
"jsHeapTotalBytes": 24367104,
"scriptDurationMs": 93.55999999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1412.7090000000067,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.923000000000005,
"layouts": 15,
"layoutDurationMs": 13.070000000000002,
"taskDurationMs": 973.0919999999999,
"heapDeltaBytes": 31100792,
"heapUsedBytes": 98976536,
"domNodes": 13673,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 46.123,
"eventListeners": 2375,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8409.689000000015,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.199999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4811.441,
"heapDeltaBytes": 13850892,
"heapUsedBytes": 73936540,
"domNodes": -283,
"jsHeapTotalBytes": 7385088,
"scriptDurationMs": 1560.6129999999998,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8368.956000000026,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.147999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4588.670999999999,
"heapDeltaBytes": 10865428,
"heapUsedBytes": 70485884,
"domNodes": -282,
"jsHeapTotalBytes": 4763648,
"scriptDurationMs": 1412.268,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17364.267999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17335.445999999996,
"heapDeltaBytes": -55126740,
"heapUsedBytes": 170777288,
"domNodes": -8312,
"jsHeapTotalBytes": -5447680,
"scriptDurationMs": 573.029,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17464.74899999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17439.230000000003,
"heapDeltaBytes": -35198492,
"heapUsedBytes": 183935376,
"domNodes": -8312,
"jsHeapTotalBytes": -12001280,
"scriptDurationMs": 608.6210000000001,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20690.297999999984,
"styleRecalcs": 140,
"styleRecalcDurationMs": 17.63800000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20664.98,
"heapDeltaBytes": -60505208,
"heapUsedBytes": 154145240,
"domNodes": -8312,
"jsHeapTotalBytes": -10952704,
"scriptDurationMs": 906.6679999999999,
"eventListeners": -16383,
"totalBlockingTimeMs": 243,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21156.69200000002,
"styleRecalcs": 146,
"styleRecalcDurationMs": 17.923999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21089.349,
"heapDeltaBytes": -43525384,
"heapUsedBytes": 156332628,
"domNodes": -8312,
"jsHeapTotalBytes": -8331264,
"scriptDurationMs": 908.3240000000002,
"eventListeners": -16383,
"totalBlockingTimeMs": 303,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 471.81399999999485,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.377000000000002,
"layouts": 4,
"layoutDurationMs": 1.7009999999999998,
"taskDurationMs": 127.237,
"heapDeltaBytes": 5498040,
"heapUsedBytes": 68712956,
"domNodes": 156,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.939,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 451.8320000000813,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.15,
"layouts": 2,
"layoutDurationMs": 0.41,
"taskDurationMs": 104.962,
"heapDeltaBytes": 5080584,
"heapUsedBytes": 68336736,
"domNodes": 123,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.495999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe first-run tour now accepts pointer input for every step except the result step. The test verifies interactivity for upload, prompt, and run steps and excludes the result step. ChangesFirst-run tour interaction
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The upload step tells the user to swap in their own image, then a full-screen blocker swallows every click on the node it is pointing at. Only the result step has nothing to touch.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/renderer/extensions/firstRunTour/tour/firstRunTourDefinition.test.ts`:
- Around line 189-199: Update the test around buildSteps(FROM_IMAGE) to assert
the interaction rule rather than relying on an ordered list of interactive
names: every spotlight step except result must be interactive, while result must
not be. Retain explicit coverage for upload.image-edit, prompt.image-edit, run,
and result without asserting the complete step ordering.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 98b970a3-bbf2-42b7-8b23-2eb8678c7dda
📒 Files selected for processing (2)
src/renderer/extensions/firstRunTour/tour/firstRunTourDefinition.test.tssrc/renderer/extensions/firstRunTour/tour/firstRunTourDefinition.ts
77ed4e1 to
97f53fc
Compare
The previous assertion enumerated names in order, so reordering the tour broke a test about pointer input. Two other tests already own naming and order; this one now maps each step to whether it takes input, and covers the result step explicitly rather than by omission.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14685 +/- ##
==========================================
- Coverage 78.48% 78.48% -0.01%
==========================================
Files 1790 1790
Lines 105427 105426 -1
Branches 32185 32184 -1
==========================================
- Hits 82742 82741 -1
Misses 22243 22243
Partials 442 442
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@MaanilVerma Backport to |
…he click it asks for (#14685) (#14706) Backport of #14685 to `cloud/1.49`. The backport bot cherry-picked this cleanly and pushed the branch, but failed to open the PR ([comment](#14685 (comment))). Opening it manually — no conflicts, no manual resolution. ## Summary The upload step tells the user to swap in their own image, then a full-screen blocker swallows every click on the node it is spotlighting. ## Changes `interactive` was an allowlist of `prompt` and `run`, so `upload` fell through to the non-interactive branch in `TourSpotlight.vue`, which renders a `pointer-events-auto` overlay across the whole viewport. Inverted to exclude only `result` — the one step with nothing to touch. ## Review Focus The cherry-picked diff is byte-identical to what landed on `main`, so review is about whether it holds up on this branch rather than what changed. Verified on `cloud/1.49`: - `pnpm typecheck` clean - `pnpm exec vitest run src/renderer/extensions/firstRunTour/` — 173 passed across 10 files - Mutation-checked on this branch: reverting the one-line change turns the rewritten test red, so the test guards the fix here too and did not come along as a no-op
|
Summary
The upload step tells the user to swap in their own image, then a full-screen blocker swallows every click on the node it is spotlighting.
Changes
interactivewas an allowlist ofpromptandrun, souploadfell through to the non-interactive branch inTourSpotlight.vue, which renders apointer-events-autooverlay across the whole viewport. Inverted to exclude onlyresult— the one step with nothing to touch.Review Focus
Advancing is unaffected: only
runisselfAdvancing, anduploadandpromptboth advance on Next, souploadnow behaves exactly likepromptalready did.The existing test enumerated the old list with no rationale, so it went red. Rewritten to assert the rule rather than the list, and mutation-checked — reverting the one line turns it red again.
Found by hand against a real backend. The whole
interactivecluster also drives the focus trap andaria-modal, none of which is observable in happy-dom, which is why the suite stayed green through this.What changed.
Before: clicking the spotlit LoadImage node on the upload step does nothing.
After: the node takes the click and the file picker opens.