Skip to content

[backport cloud/1.49] fix(first-run-tour): let the upload step take the click it asks for (#14685) - #14706

Merged
benceruleanlu merged 1 commit into
cloud/1.49from
backport-14685-to-cloud-1.49
Aug 4, 2026
Merged

benceruleanlu merged 1 commit into
cloud/1.49from
backport-14685-to-cloud-1.49

Conversation

@MaanilVerma

Copy link
Copy Markdown
Collaborator

Backport of #14685 to cloud/1.49.

The backport bot cherry-picked this cleanly and pushed the branch, but failed to open the PR (comment). Opening it manually — no conflicts, no manual resolution.

Summary

The upload step tells the user to swap in their own image, then a full-screen blocker swallows every click on the node it is spotlighting.

Changes

interactive was an allowlist of prompt and run, so upload fell through to the non-interactive branch in TourSpotlight.vue, which renders a pointer-events-auto overlay across the whole viewport. Inverted to exclude only result — the one step with nothing to touch.

Review Focus

The cherry-picked diff is byte-identical to what landed on main, so review is about whether it holds up on this branch rather than what changed.

Verified on cloud/1.49:

  • pnpm typecheck clean
  • pnpm exec vitest run src/renderer/extensions/firstRunTour/ — 173 passed across 10 files
  • Mutation-checked on this branch: reverting the one-line change turns the rewritten test red, so the test guards the fix here too and did not come along as a no-op

…14685)

## Summary

The upload step tells the user to swap in their own image, then a
full-screen blocker swallows every click on the node it is spotlighting.

## Changes

- **What**: `interactive` was an allowlist of `prompt` and `run`, so
`upload` fell through to the non-interactive branch in
`TourSpotlight.vue`, which renders a `pointer-events-auto` overlay
across the whole viewport. Inverted to exclude only `result` — the one
step with nothing to touch.

## Review Focus

Advancing is unaffected: only `run` is `selfAdvancing`, and `upload` and
`prompt` both advance on Next, so `upload` now behaves exactly like
`prompt` already did.

The existing test enumerated the old list with no rationale, so it went
red. Rewritten to assert the rule rather than the list, and
mutation-checked — reverting the one line turns it red again.

Found by hand against a real backend. The whole `interactive` cluster
also drives the focus trap and `aria-modal`, none of which is observable
in happy-dom, which is why the suite stayed green through this.

## What changed.

Before: clicking the spotlit LoadImage node on the upload step does
nothing.
After: the node takes the click and the file picker opens.
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 4, 2026
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ec71a0d1-0a00-479c-b9b6-0b90b5509ff2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dosubot

dosubot Bot commented Aug 4, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-09-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about ComfyUI_frontend Add Dosu to your team

@github-actions

github-actions Bot commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1786 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1765 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/04/2026, 07:57:35 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 52.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 128ms TBT · 95.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.2 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 162.1 MB heap
vue-large-graph-pan: · 52.9 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 594ms TBT · 164.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 49.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 604ms
canvas-idle: script duration 25ms
canvas-idle: TBT 0ms
canvas-idle: heap used 69.9 MB
canvas-idle: DOM nodes 18
canvas-idle: event listeners 4
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 40ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 908ms
canvas-mouse-sweep: script duration 123ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 57.4 MB
canvas-mouse-sweep: DOM nodes -112
canvas-mouse-sweep: event listeners -74
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 19ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 405ms
canvas-zoom-sweep: script duration 23ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.6 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 390ms
dom-widget-clipping: script duration 58ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 53.4 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 9ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 799ms
large-graph-idle: script duration 123ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 64.7 MB
large-graph-idle: DOM nodes -282
large-graph-idle: event listeners -148
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1314ms
large-graph-pan: script duration 423ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 59.8 MB
large-graph-pan: DOM nodes -286
large-graph-pan: event listeners -163
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1500ms
large-graph-zoom: script duration 532ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 81.9 MB
large-graph-zoom: DOM nodes 11
large-graph-zoom: event listeners 8
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 773ms
minimap-idle: script duration 119ms
minimap-idle: TBT 0ms
minimap-idle: heap used 66.6 MB
minimap-idle: DOM nodes -283
minimap-idle: event listeners -149
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 407ms
subgraph-dom-widget-clipping: script duration 125ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 54.5 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 523ms
subgraph-idle: script duration 18ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 56.6 MB
subgraph-idle: DOM nodes 18
subgraph-idle: event listeners -75
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 37ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 811ms
subgraph-mouse-sweep: script duration 94ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 52.5 MB
subgraph-mouse-sweep: DOM nodes 42
subgraph-mouse-sweep: event listeners 4
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1030ms
subgraph-transition-enter: script duration 40ms
subgraph-transition-enter: TBT 128ms
subgraph-transition-enter: heap used 95.2 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2375
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 43ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4772ms
viewport-pan-sweep: script duration 1443ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 69.2 MB
viewport-pan-sweep: DOM nodes -283
viewport-pan-sweep: event listeners -132
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 18223ms
vue-large-graph-idle: script duration 602ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 162.1 MB
vue-large-graph-idle: DOM nodes -8310
vue-large-graph-idle: event listeners -16387
vue-large-graph-pan: avg frame time 19ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 25ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 167
vue-large-graph-pan: task duration 22612ms
vue-large-graph-pan: script duration 937ms
vue-large-graph-pan: TBT 594ms
vue-large-graph-pan: heap used 164.6 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16381
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 123ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 49.1 MB
workflow-execution: DOM nodes 127
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-08-04T20:07:53.532Z",
  "gitSha": "d336f33fc94abf14f75e882172ba2f09db38ad2f",
  "branch": "backport-14685-to-cloud-1.49",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2070.772999999974,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.399000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 634.342,
      "heapDeltaBytes": 5126904,
      "heapUsedBytes": 73299576,
      "domNodes": 18,
      "jsHeapTotalBytes": 20041728,
      "scriptDurationMs": 25.336000000000002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2054.7940000000153,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.065999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 573.359,
      "heapDeltaBytes": 5245472,
      "heapUsedBytes": 73245040,
      "domNodes": 18,
      "jsHeapTotalBytes": 20041728,
      "scriptDurationMs": 24.932999999999996,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1847.801000000004,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 36.019000000000005,
      "layouts": 12,
      "layoutDurationMs": 3.6190000000000007,
      "taskDurationMs": 891.658,
      "heapDeltaBytes": -15524824,
      "heapUsedBytes": 52592572,
      "domNodes": -282,
      "jsHeapTotalBytes": 21217280,
      "scriptDurationMs": 118.616,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1917.391000000066,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 44.687999999999995,
      "layouts": 12,
      "layoutDurationMs": 4.119999999999999,
      "taskDurationMs": 924.5730000000001,
      "heapDeltaBytes": -339452,
      "heapUsedBytes": 67824816,
      "domNodes": 59,
      "jsHeapTotalBytes": 20566016,
      "scriptDurationMs": 126.81900000000002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1754.2779999999993,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.628000000000004,
      "layouts": 6,
      "layoutDurationMs": 0.73,
      "taskDurationMs": 400.899,
      "heapDeltaBytes": 7949556,
      "heapUsedBytes": 76236712,
      "domNodes": 77,
      "jsHeapTotalBytes": 20566016,
      "scriptDurationMs": 21.802000000000003,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1742.0610000000352,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 18.965000000000003,
      "layouts": 6,
      "layoutDurationMs": 0.677,
      "taskDurationMs": 408.974,
      "heapDeltaBytes": 7823772,
      "heapUsedBytes": 75968588,
      "domNodes": 76,
      "jsHeapTotalBytes": 20566016,
      "scriptDurationMs": 23.296000000000003,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 593.4440000000336,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.930000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 378.55,
      "heapDeltaBytes": -12190568,
      "heapUsedBytes": 55857656,
      "domNodes": 20,
      "jsHeapTotalBytes": 21876736,
      "scriptDurationMs": 56.499,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 618.4349999999768,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.495,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.49800000000005,
      "heapDeltaBytes": -12110624,
      "heapUsedBytes": 56198164,
      "domNodes": 18,
      "jsHeapTotalBytes": 21614592,
      "scriptDurationMs": 59.32,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.8990000000244,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.25,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 716.5279999999998,
      "heapDeltaBytes": 8487484,
      "heapUsedBytes": 67716016,
      "domNodes": -280,
      "jsHeapTotalBytes": 5038080,
      "scriptDurationMs": 107.58899999999998,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2066.7040000000725,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.117,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 880.967,
      "heapDeltaBytes": 8439576,
      "heapUsedBytes": 68033664,
      "domNodes": -283,
      "jsHeapTotalBytes": 5300224,
      "scriptDurationMs": 138.544,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2177.2189999999796,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.264999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1271.5510000000002,
      "heapDeltaBytes": 6411572,
      "heapUsedBytes": 69399424,
      "domNodes": -283,
      "jsHeapTotalBytes": 5525504,
      "scriptDurationMs": 413.21799999999996,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2168.9269999999397,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.520000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1355.7459999999999,
      "heapDeltaBytes": -4742064,
      "heapUsedBytes": 56027768,
      "domNodes": -289,
      "jsHeapTotalBytes": 5562368,
      "scriptDurationMs": 432.162,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3198.045000000036,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.595,
      "layouts": 60,
      "layoutDurationMs": 8.268999999999998,
      "taskDurationMs": 1454.507,
      "heapDeltaBytes": 23504108,
      "heapUsedBytes": 85153988,
      "domNodes": 10,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 518.52,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3244.0619999999853,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.962999999999997,
      "layouts": 60,
      "layoutDurationMs": 8.320999999999998,
      "taskDurationMs": 1546.164,
      "heapDeltaBytes": 24442500,
      "heapUsedBytes": 86661880,
      "domNodes": 12,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 545.515,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2039.8500000000013,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.738999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 700.1220000000001,
      "heapDeltaBytes": 8464180,
      "heapUsedBytes": 69643936,
      "domNodes": -281,
      "jsHeapTotalBytes": 5038080,
      "scriptDurationMs": 106.21900000000001,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2040.5470000000605,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.288000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 845.256,
      "heapDeltaBytes": 8319592,
      "heapUsedBytes": 70017584,
      "domNodes": -285,
      "jsHeapTotalBytes": 4251648,
      "scriptDurationMs": 132.073,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 604.5569999999998,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.162,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 400.26099999999997,
      "heapDeltaBytes": -11159052,
      "heapUsedBytes": 57163192,
      "domNodes": 20,
      "jsHeapTotalBytes": 21352448,
      "scriptDurationMs": 124.07100000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 608.1819999999425,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.380999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 414.434,
      "heapDeltaBytes": -11121176,
      "heapUsedBytes": 57200632,
      "domNodes": 18,
      "jsHeapTotalBytes": 20828160,
      "scriptDurationMs": 125.83999999999997,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.2119999999718,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.599,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 464.81999999999994,
      "heapDeltaBytes": 4665508,
      "heapUsedBytes": 72713944,
      "domNodes": 18,
      "jsHeapTotalBytes": 20828160,
      "scriptDurationMs": 14.48,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2063.780999999949,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.208,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 580.3290000000001,
      "heapDeltaBytes": -22298572,
      "heapUsedBytes": 45988620,
      "domNodes": 18,
      "jsHeapTotalBytes": 19906560,
      "scriptDurationMs": 21.932999999999996,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1700.078000000019,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 35.419000000000004,
      "layouts": 16,
      "layoutDurationMs": 3.9190000000000005,
      "taskDurationMs": 760.907,
      "heapDeltaBytes": -4400656,
      "heapUsedBytes": 63921204,
      "domNodes": 64,
      "jsHeapTotalBytes": 21090304,
      "scriptDurationMs": 89.693,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1734.9750000000768,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 39.269,
      "layouts": 16,
      "layoutDurationMs": 4.703,
      "taskDurationMs": 861.297,
      "heapDeltaBytes": -22376244,
      "heapUsedBytes": 46118196,
      "domNodes": 20,
      "jsHeapTotalBytes": 20430848,
      "scriptDurationMs": 99.076,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1412.6139999999623,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 32.417999999999985,
      "layouts": 14,
      "layoutDurationMs": 12.213000000000001,
      "taskDurationMs": 1029.57,
      "heapDeltaBytes": 31029468,
      "heapUsedBytes": 99816352,
      "domNodes": 13673,
      "jsHeapTotalBytes": 15728640,
      "scriptDurationMs": 39.882,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 128,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8284.23799999996,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 41.751,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4418.236,
      "heapDeltaBytes": 12628900,
      "heapUsedBytes": 71855304,
      "domNodes": -282,
      "jsHeapTotalBytes": 7065600,
      "scriptDurationMs": 1327.9080000000001,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8769.170999999915,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 43.403,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5125.728,
      "heapDeltaBytes": 13949608,
      "heapUsedBytes": 73338980,
      "domNodes": -284,
      "jsHeapTotalBytes": 7589888,
      "scriptDurationMs": 1558.7220000000002,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18035.011999999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18003.352,
      "heapDeltaBytes": -42567600,
      "heapUsedBytes": 168810344,
      "domNodes": -8312,
      "jsHeapTotalBytes": -8851456,
      "scriptDurationMs": 587.8539999999999,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18463.44399999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18441.986999999997,
      "heapDeltaBytes": -41352444,
      "heapUsedBytes": 171108216,
      "domNodes": -8308,
      "jsHeapTotalBytes": -6987776,
      "scriptDurationMs": 616.0649999999999,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22288.692000000025,
      "styleRecalcs": 162,
      "styleRecalcDurationMs": 23.536,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22250.782,
      "heapDeltaBytes": -38521676,
      "heapUsedBytes": 168473100,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9900032,
      "scriptDurationMs": 922.526,
      "eventListeners": -16381,
      "totalBlockingTimeMs": 563,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23013.418999999998,
      "styleRecalcs": 172,
      "styleRecalcDurationMs": 27.069999999999983,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22973.261000000002,
      "heapDeltaBytes": -44476836,
      "heapUsedBytes": 176679096,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9707520,
      "scriptDurationMs": 952.076,
      "eventListeners": -16381,
      "totalBlockingTimeMs": 625,
      "frameDurationMs": 19.44333333333331,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 461.5339999999719,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 20.894000000000002,
      "layouts": 3,
      "layoutDurationMs": 0.7609999999999998,
      "taskDurationMs": 122.798,
      "heapDeltaBytes": -15622128,
      "heapUsedBytes": 51502568,
      "domNodes": 132,
      "jsHeapTotalBytes": 7720960,
      "scriptDurationMs": 11.001000000000001,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 457.3090000000093,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 21.883,
      "layouts": 3,
      "layoutDurationMs": 0.5739999999999998,
      "taskDurationMs": 124.13499999999999,
      "heapDeltaBytes": -15754516,
      "heapUsedBytes": 51405488,
      "domNodes": 121,
      "jsHeapTotalBytes": 7196672,
      "scriptDurationMs": 11.572000000000001,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.49   #14706   +/-   ##
=============================================
  Coverage              ?   78.59%           
=============================================
  Files                 ?     1789           
  Lines                 ?   104419           
  Branches              ?    32880           
=============================================
  Hits                  ?    82073           
  Misses                ?    21916           
  Partials              ?      430           
Flag Coverage Δ
unit 70.74% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nsions/firstRunTour/tour/firstRunTourDefinition.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benceruleanlu
benceruleanlu merged commit cc66ba2 into cloud/1.49 Aug 4, 2026
68 checks passed
@benceruleanlu
benceruleanlu deleted the backport-14685-to-cloud-1.49 branch August 4, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants