Repository navigation
fix(first-run-tour): stop illustrating the nudge with the Open Graph card - #14671
christian-byrne wants to merge 1 commit into
Conversation
The nudge rendered `/assets/images/og-image.png` — the site's Open Graph banner, and the only reference to that file outside the OG meta tags. Anyone rotating the social preview silently redrew onboarding with no reason to know they had. It is also a 269 KB 1200x630 "Comfy Cloud — Run ComfyUI anywhere" ad object-cover-cropped into a 320x200 box. Point it at `default-template.png` instead: the placeholder the template thumbnails already fall back to, owned by the UI, 54 KB. The constant carries a comment saying it must not be the OG image, and a test asserts the same, since the failure mode is invisible from the side that breaks it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎭 Playwright: ✅ 1786 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.24 MB gzip 🔴 +241 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.35 MB (baseline 1.35 MB) • 🔴 +489 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 111 kB (baseline 111 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 16 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 28.7 kB (baseline 28.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 7 unchanged UI Components — 70 kB (baseline 70 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.47 MB (baseline 3.47 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 280 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-04T05:39:46.443Z",
"gitSha": "e970a60889d99dd96cf4798a67cd6e6f59aab6f0",
"branch": "fix/tour-nudge-image",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2044.5320000000038,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.9419999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.4670000000001,
"heapDeltaBytes": 5614576,
"heapUsedBytes": 69803832,
"domNodes": 16,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 24.909000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2018.7439999999697,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.769,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.2929999999999,
"heapDeltaBytes": 5312520,
"heapUsedBytes": 69330084,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 24.061000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2089.5189999999957,
"styleRecalcs": 78,
"styleRecalcDurationMs": 56.754,
"layouts": 12,
"layoutDurationMs": 5.581,
"taskDurationMs": 1140.252,
"heapDeltaBytes": -11086804,
"heapUsedBytes": 53068484,
"domNodes": -282,
"jsHeapTotalBytes": 24104960,
"scriptDurationMs": 145.39100000000002,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1891.477000000009,
"styleRecalcs": 77,
"styleRecalcDurationMs": 42.745000000000005,
"layouts": 12,
"layoutDurationMs": 3.6740000000000004,
"taskDurationMs": 934.3990000000001,
"heapDeltaBytes": -234524,
"heapUsedBytes": 63734408,
"domNodes": 62,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 133.874,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.030000000047,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.944000000000003,
"layouts": 6,
"layoutDurationMs": 0.67,
"taskDurationMs": 446.735,
"heapDeltaBytes": 8696012,
"heapUsedBytes": 72680956,
"domNodes": 78,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 26.229000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1674.74500000003,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.795,
"layouts": 6,
"layoutDurationMs": 0.621,
"taskDurationMs": 447.82,
"heapDeltaBytes": 8385932,
"heapUsedBytes": 72439604,
"domNodes": 78,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 26.200999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 605.8519999999703,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.745,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.74199999999996,
"heapDeltaBytes": -11005716,
"heapUsedBytes": 53062704,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 62.800999999999995,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 657.0380000000569,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.589,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.31999999999994,
"heapDeltaBytes": -10742496,
"heapUsedBytes": 53401044,
"domNodes": 16,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 65.056,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2037.969999999973,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.341999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 832.3340000000002,
"heapDeltaBytes": 5917340,
"heapUsedBytes": 65379344,
"domNodes": -281,
"jsHeapTotalBytes": 2473984,
"scriptDurationMs": 132.14299999999997,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2042.1309999999266,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.366999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 837.513,
"heapDeltaBytes": 5670776,
"heapUsedBytes": 65102160,
"domNodes": -282,
"jsHeapTotalBytes": 2736128,
"scriptDurationMs": 130.791,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2355.5299999999875,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.681000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1456.7779999999998,
"heapDeltaBytes": -4638256,
"heapUsedBytes": 55950844,
"domNodes": -284,
"jsHeapTotalBytes": 5095424,
"scriptDurationMs": 513.688,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2253.2850000000053,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.734999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1381.5149999999999,
"heapDeltaBytes": 3900288,
"heapUsedBytes": 64594368,
"domNodes": -285,
"jsHeapTotalBytes": 3452928,
"scriptDurationMs": 453.75100000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3432.1770000000242,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.939999999999998,
"layouts": 60,
"layoutDurationMs": 7.634,
"taskDurationMs": 1689.183,
"heapDeltaBytes": 8112824,
"heapUsedBytes": 70664616,
"domNodes": -287,
"jsHeapTotalBytes": 6406144,
"scriptDurationMs": 602.382,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3415.341000000012,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.258000000000001,
"layouts": 60,
"layoutDurationMs": 7.662999999999999,
"taskDurationMs": 1652.367,
"heapDeltaBytes": 8506736,
"heapUsedBytes": 70450944,
"domNodes": -289,
"jsHeapTotalBytes": 6406144,
"scriptDurationMs": 573.7410000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.5209999999552,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.521999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 840.6139999999999,
"heapDeltaBytes": 6652276,
"heapUsedBytes": 66961176,
"domNodes": -283,
"jsHeapTotalBytes": 3260416,
"scriptDurationMs": 130.831,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.5610000000443,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.744999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 838.047,
"heapDeltaBytes": 5624364,
"heapUsedBytes": 66423516,
"domNodes": -285,
"jsHeapTotalBytes": 3522560,
"scriptDurationMs": 131.22699999999998,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.3309999999833,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.969000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.57500000000005,
"heapDeltaBytes": -10399864,
"heapUsedBytes": 53729908,
"domNodes": 14,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 123.637,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.9190000000572,
"styleRecalcs": 48,
"styleRecalcDurationMs": 13.222000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.982,
"heapDeltaBytes": -10462964,
"heapUsedBytes": 53715520,
"domNodes": 22,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 124.796,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.7790000000182,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.443000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.727,
"heapDeltaBytes": 4960896,
"heapUsedBytes": 68892652,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 22.576000000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2006.1279999999897,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.661999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.7310000000001,
"heapDeltaBytes": 5117888,
"heapUsedBytes": 69302208,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 21.543,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.8380000000006,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.186,
"layouts": 16,
"layoutDurationMs": 5.008,
"taskDurationMs": 838.1999999999999,
"heapDeltaBytes": -3948916,
"heapUsedBytes": 60219272,
"domNodes": 61,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 101.028,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.5610000000097,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.869,
"layouts": 16,
"layoutDurationMs": 4.919,
"taskDurationMs": 863.792,
"heapDeltaBytes": -4235276,
"heapUsedBytes": 59836784,
"domNodes": 62,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 105.146,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1450.7099999999582,
"styleRecalcs": 18,
"styleRecalcDurationMs": 33.072,
"layouts": 14,
"layoutDurationMs": 13.443999999999997,
"taskDurationMs": 1052.0539999999999,
"heapDeltaBytes": 30597460,
"heapUsedBytes": 99160584,
"domNodes": 13673,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 41.42799999999999,
"eventListeners": 2375,
"totalBlockingTimeMs": 148,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8876.628999999979,
"styleRecalcs": 250,
"styleRecalcDurationMs": 41.190000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4995.38,
"heapDeltaBytes": 18912340,
"heapUsedBytes": 78421716,
"domNodes": -283,
"jsHeapTotalBytes": 6074368,
"scriptDurationMs": 1526.3519999999999,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8674.58099999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.147,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5001.428000000001,
"heapDeltaBytes": 17362136,
"heapUsedBytes": 77270832,
"domNodes": -280,
"jsHeapTotalBytes": 5025792,
"scriptDurationMs": 1492.483,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17682.84799999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17662.978000000003,
"heapDeltaBytes": -61505928,
"heapUsedBytes": 167766480,
"domNodes": -8312,
"jsHeapTotalBytes": -8331264,
"scriptDurationMs": 610.321,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17512.15000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17470.292,
"heapDeltaBytes": -57405540,
"heapUsedBytes": 167316552,
"domNodes": -8312,
"jsHeapTotalBytes": -7016448,
"scriptDurationMs": 604.651,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21781.770999999993,
"styleRecalcs": 149,
"styleRecalcDurationMs": 20.940000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21743.315000000002,
"heapDeltaBytes": -28880388,
"heapUsedBytes": 176337540,
"domNodes": -8312,
"jsHeapTotalBytes": -8658944,
"scriptDurationMs": 980.4659999999999,
"eventListeners": -16385,
"totalBlockingTimeMs": 410,
"frameDurationMs": 18.33666666666674,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21747.116000000005,
"styleRecalcs": 151,
"styleRecalcDurationMs": 21.529999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21702.250999999997,
"heapDeltaBytes": -56954100,
"heapUsedBytes": 153710708,
"domNodes": -8312,
"jsHeapTotalBytes": -13836288,
"scriptDurationMs": 913.994,
"eventListeners": -16379,
"totalBlockingTimeMs": 502,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 468.1239999999889,
"styleRecalcs": 12,
"styleRecalcDurationMs": 19.799999999999997,
"layouts": 3,
"layoutDurationMs": 0.6790000000000002,
"taskDurationMs": 122.996,
"heapDeltaBytes": 5308936,
"heapUsedBytes": 68503260,
"domNodes": 132,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.017000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 459.30199999997967,
"styleRecalcs": 14,
"styleRecalcDurationMs": 27.788999999999994,
"layouts": 4,
"layoutDurationMs": 1.3849999999999998,
"taskDurationMs": 131.45000000000002,
"heapDeltaBytes": 5086924,
"heapUsedBytes": 68044280,
"domNodes": 123,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.034,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe first-run nudge now uses ChangesFirst-run nudge illustration
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14671 +/- ##
========================================
Coverage 78.46% 78.46%
========================================
Files 1790 1790
Lines 105382 105382
Branches 33052 32178 -874
========================================
Hits 82683 82683
+ Misses 22264 22257 -7
- Partials 435 442 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@MaanilVerma flagged in Slack that the OG image was a deliberate choice and that he is fine either way, so treating this as his call rather than a defect. Leaving it open for you to take or close. The only argument I would still make is the coupling rather than the aesthetics: Also worth knowing since it argues for some change: the current asset is a 269 KB "Comfy Cloud — Run ComfyUI anywhere" banner, so a local first-run user gets a cloud ad as their congratulation. Your call entirely — close it if you would rather keep what is there. |
|
Closing — @MaanilVerma flagged the OG image as a deliberate choice, and that's his call to make. For the record so it isn't lost: |
Summary
The first-run tour nudge illustrated itself with
/assets/images/og-image.png— the site's Open Graph card. It was the only reference to that file outside the OG meta tags, so anyone rotating the social preview silently redrew onboarding UI with no reason to know they had.Closes #14624
Changes
FirstRunTourNudge.vuenow renders/assets/images/default-template.png, with a comment on the constant and a test both stating the asset must never be the OG card.What was actually on screen: a 1200x630, 269 KB "Comfy Cloud — Run ComfyUI anywhere. No setup." marketing banner,
object-cover-cropped into a 320x200 panel — so a local first-run user finished their first generation and got a cloud ad, mid-cropped, as their congratulation.Choosing the replacement
I inventoried every image under
public/before picking:og-image.pngdefault-template.pngBaseThumbnail/LazyImagealready render in card slotsapp-mode-landing.pngcomfy-icon-512.pngdefault-template.pngis a soft blue-green gradient, so the upscale from 224 px to a 320 px-wide box costs nothing visible — I simulated the exactobject-covertransform (cover-scale, center-crop to 320x200) and the result is a clean gradient, no artefacts or seams. It also cuts 215 KB off the panel.This is a stopgap, not the real fix.
default-template.pngis a placeholder, not an illustration; the nudge deserves a designer-provided asset. What this PR guarantees is that whatever lands there, it is not the social preview. Per the issue I did not invent an asset, so the coupling is instead made explicit:A unit test asserts the same, because the failure mode is invisible from the side that causes it — someone editing OG metadata will never open this component.
Review Focus
imggaineddata-testid="first-run-nudge-image"so the test can reach it — it hasalt=""(decorative), so there is no Testing Library query for it otherwise.Verification
pnpm test:unit src/renderer/extensions/firstRunTour/nudge/FirstRunTourNudge.test.ts— 9 passed, including the new assertion.object-covercrop offline (cover-scale + center-crop to the panel's 320x200) to confirm the replacement does not look degraded at the size it is displayed.pnpm format:check,pnpm lint,pnpm typecheck— all clean.Not verified: I did not see this in a running browser. The crop check was an offline simulation of the CSS, not a screenshot of the real panel, so the composition against the surrounding card (close button contrast over the gradient, in particular) is unconfirmed. Worth a glance from whoever has the tour running locally.
browser_tests/tests/appMode.spec.tsalso referencesog-image.png, but as a drag-and-drop payload fixture — unrelated, and left alone.