Repository navigation
[backport core/1.49] feat(first-run-tour): resolve tour roles from pinned nodes - #14634
Conversation
> **Stack — 3 of 6.** Rebuilt from scratch after the review on #13725, split into short PRs. > Based on #13290 (coachmark engine); each PR stacks on the one before it. > > 1. #14140 — engine: canvas targets for the coachmark tour > 2. #14141 — Getting Started screen + entry gating > 3. #14142 — role pins + live drift guard ← this PR > 4. #14143 — the tour itself + e2e walk > 5. #14144 — post-tour nudge > 6. #14145 — unpinned workflows (share / template links) ## Summary Given a loaded graph, which nodes does the tour point at? For the eight templates the Getting Started grid can show, the answer is pinned by hand — three node ids each. The previous attempt inferred this with a 544-line resolver that parsed serialized JSON; this is 161 lines that read the live graph. ## Changes - `TOUR_ROLE_PINS` maps each supported template to its source / prompt / sink. The type is exhaustive over both grid id lists, so a card without pins is a compile error. - Pins carry the node type alongside the id, and resolution checks both — a renumbered template degrades to null instead of spotlighting the wrong node. - All three roles host-map through the same path, so a pin inside a subgraph resolves to the root node that hosts it. - A Playwright guard fetches every pinned template from the backend and asserts each pinned node still exists with its expected type. ## Review focus No vendored fixtures. The old PR carried 12,723 lines of copied template JSON; the drift guard replaces it by checking against what the backend actually serves, so an upstream rename fails CI instead of silently mis-targeting a spotlight. --------- Co-authored-by: pythongosssss <125205205+pythongosssss@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: AustinMroz <austin@comfy.org>
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎭 Playwright: ✅ 1778 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-04T00:29:46.781Z",
"gitSha": "278808a56c4154e3820cb434a72295c85760362a",
"branch": "backport-14142-to-core-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2108.7630000000104,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.579999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.045,
"heapDeltaBytes": 4742848,
"heapUsedBytes": 72651356,
"domNodes": 20,
"jsHeapTotalBytes": 20832256,
"scriptDurationMs": 17.979999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.704000000023,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.339999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.03,
"heapDeltaBytes": 5141312,
"heapUsedBytes": 73100148,
"domNodes": 20,
"jsHeapTotalBytes": 20307968,
"scriptDurationMs": 13.583,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1935.5649999999969,
"styleRecalcs": 78,
"styleRecalcDurationMs": 41.52,
"layouts": 12,
"layoutDurationMs": 4.04,
"taskDurationMs": 917.0950000000001,
"heapDeltaBytes": -177944,
"heapUsedBytes": 67534400,
"domNodes": 61,
"jsHeapTotalBytes": 20832256,
"scriptDurationMs": 128.872,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1808.2029999999918,
"styleRecalcs": 73,
"styleRecalcDurationMs": 35.474,
"layouts": 12,
"layoutDurationMs": 3.5989999999999998,
"taskDurationMs": 865.1829999999999,
"heapDeltaBytes": -17721808,
"heapUsedBytes": 50284588,
"domNodes": -281,
"jsHeapTotalBytes": 20959232,
"scriptDurationMs": 118.864,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1715.0060000000167,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.460999999999999,
"layouts": 6,
"layoutDurationMs": 0.624,
"taskDurationMs": 368.056,
"heapDeltaBytes": 7760324,
"heapUsedBytes": 75486188,
"domNodes": 76,
"jsHeapTotalBytes": 20832256,
"scriptDurationMs": 17.612,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.3850000000548,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.423000000000002,
"layouts": 6,
"layoutDurationMs": 0.57,
"taskDurationMs": 364.476,
"heapDeltaBytes": 7938536,
"heapUsedBytes": 75839596,
"domNodes": 77,
"jsHeapTotalBytes": 20307968,
"scriptDurationMs": 17.374000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 575.0999999999635,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.343000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.86600000000004,
"heapDeltaBytes": -12439368,
"heapUsedBytes": 55644456,
"domNodes": 20,
"jsHeapTotalBytes": 21880832,
"scriptDurationMs": 57.283,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 577.6280000000042,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.565999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.91799999999995,
"heapDeltaBytes": -12237728,
"heapUsedBytes": 55892208,
"domNodes": 20,
"jsHeapTotalBytes": 21356544,
"scriptDurationMs": 57.568000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2028.7930000000074,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.391,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 658.304,
"heapDeltaBytes": 8063816,
"heapUsedBytes": 69457736,
"domNodes": -281,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 99.691,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2010.0289999999177,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.082999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 651.0720000000001,
"heapDeltaBytes": 7864404,
"heapUsedBytes": 67106420,
"domNodes": -283,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 97.81300000000002,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2192.6650000000336,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.533,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1267.49,
"heapDeltaBytes": 6120240,
"heapUsedBytes": 65945052,
"domNodes": -284,
"jsHeapTotalBytes": 4476928,
"scriptDurationMs": 431.586,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2240.872999999965,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.322000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1315.732,
"heapDeltaBytes": 4821668,
"heapUsedBytes": 65191480,
"domNodes": -285,
"jsHeapTotalBytes": 5001216,
"scriptDurationMs": 454.895,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3180.7320000000345,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.659000000000002,
"layouts": 60,
"layoutDurationMs": 6.796,
"taskDurationMs": 1501.21,
"heapDeltaBytes": -3355032,
"heapUsedBytes": 58051872,
"domNodes": -288,
"jsHeapTotalBytes": 6873088,
"scriptDurationMs": 525.63,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3213.9060000000654,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.369000000000003,
"layouts": 60,
"layoutDurationMs": 7.114000000000001,
"taskDurationMs": 1472.519,
"heapDeltaBytes": -847480,
"heapUsedBytes": 60597208,
"domNodes": -287,
"jsHeapTotalBytes": 7921664,
"scriptDurationMs": 518.77,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2029.5739999999682,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.494,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 646.447,
"heapDeltaBytes": 8127116,
"heapUsedBytes": 68671352,
"domNodes": -285,
"jsHeapTotalBytes": 4251648,
"scriptDurationMs": 99.128,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2028.701999999953,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.270000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 646.0889999999999,
"heapDeltaBytes": 7946504,
"heapUsedBytes": 68718664,
"domNodes": -284,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 100.11099999999998,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.528999999985,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.138000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.14900000000006,
"heapDeltaBytes": -12233640,
"heapUsedBytes": 55955580,
"domNodes": 20,
"jsHeapTotalBytes": 22929408,
"scriptDurationMs": 120.81800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 570.4630000000179,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.078,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.523,
"heapDeltaBytes": -10803140,
"heapUsedBytes": 57244764,
"domNodes": 20,
"jsHeapTotalBytes": 21094400,
"scriptDurationMs": 114.30799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2023.0710000000158,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.514999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.987,
"heapDeltaBytes": -21550652,
"heapUsedBytes": 46394288,
"domNodes": 18,
"jsHeapTotalBytes": 20959232,
"scriptDurationMs": 12.578000000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.5640000000258,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.622,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.15100000000007,
"heapDeltaBytes": 4669164,
"heapUsedBytes": 72742308,
"domNodes": 20,
"jsHeapTotalBytes": 20307968,
"scriptDurationMs": 12.427,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.7880000000214,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.051,
"layouts": 16,
"layoutDurationMs": 4.21,
"taskDurationMs": 735.0159999999998,
"heapDeltaBytes": -4529792,
"heapUsedBytes": 63449592,
"domNodes": 65,
"jsHeapTotalBytes": 20570112,
"scriptDurationMs": 90.047,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.242999999915,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.300999999999995,
"layouts": 16,
"layoutDurationMs": 3.803,
"taskDurationMs": 732.37,
"heapDeltaBytes": -4897420,
"heapUsedBytes": 63109696,
"domNodes": 64,
"jsHeapTotalBytes": 20832256,
"scriptDurationMs": 86.519,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.383999999974,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.515,
"layouts": 14,
"layoutDurationMs": 12.601,
"taskDurationMs": 917.5370000000003,
"heapDeltaBytes": 29103580,
"heapUsedBytes": 96965328,
"domNodes": 13673,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 42.003,
"eventListeners": 2371,
"totalBlockingTimeMs": 136,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8190.345000000036,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.812,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4327.725,
"heapDeltaBytes": 10431252,
"heapUsedBytes": 69276336,
"domNodes": -283,
"jsHeapTotalBytes": 7852032,
"scriptDurationMs": 1356.892,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8197.369999999977,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.1,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4263.489,
"heapDeltaBytes": 10689688,
"heapUsedBytes": 69478980,
"domNodes": -281,
"jsHeapTotalBytes": 6803456,
"scriptDurationMs": 1345.9029999999998,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16480.706999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16464.614999999998,
"heapDeltaBytes": -45316000,
"heapUsedBytes": 165967208,
"domNodes": -8312,
"jsHeapTotalBytes": -12263424,
"scriptDurationMs": 521.22,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16638.26000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16607.857,
"heapDeltaBytes": -57672440,
"heapUsedBytes": 167754012,
"domNodes": -8312,
"jsHeapTotalBytes": -10952704,
"scriptDurationMs": 563.639,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20287.51,
"styleRecalcs": 141,
"styleRecalcDurationMs": 16.091999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20226.451999999997,
"heapDeltaBytes": -40131812,
"heapUsedBytes": 181618936,
"domNodes": -8312,
"jsHeapTotalBytes": -9711616,
"scriptDurationMs": 910.3570000000001,
"eventListeners": -16381,
"totalBlockingTimeMs": 196,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20209.80499999996,
"styleRecalcs": 136,
"styleRecalcDurationMs": 15.16799999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20185.086000000003,
"heapDeltaBytes": -54347484,
"heapUsedBytes": 154454064,
"domNodes": -8312,
"jsHeapTotalBytes": -12001280,
"scriptDurationMs": 850.558,
"eventListeners": -16387,
"totalBlockingTimeMs": 112,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 453.26900000003434,
"styleRecalcs": 15,
"styleRecalcDurationMs": 18.775999999999996,
"layouts": 3,
"layoutDurationMs": 0.642,
"taskDurationMs": 112.08500000000001,
"heapDeltaBytes": -15801808,
"heapUsedBytes": 51308872,
"domNodes": 132,
"jsHeapTotalBytes": 8511488,
"scriptDurationMs": 9.357000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 106.83300000005147,
"styleRecalcs": 6,
"styleRecalcDurationMs": 13.317,
"layouts": 3,
"layoutDurationMs": 0.7120000000000002,
"taskDurationMs": 73.712,
"heapDeltaBytes": 2997056,
"heapUsedBytes": 69783932,
"domNodes": 104,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 6.359000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
🎨 Storybook: 🚧 Building... |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.49 #14634 +/- ##
=============================================
+ Coverage 78.45% 78.46% +0.01%
=============================================
Files 1778 1781 +3
Lines 103825 103844 +19
Branches 31855 31863 +8
=============================================
+ Hits 81456 81483 +27
+ Misses 21938 21930 -8
Partials 431 431
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approving — this is a clean cherry-pick of #14142, which I reviewed and approved on main.
Verified the backport itself rather than assuming: cherry-picking all four stack PRs onto core/1.49 and cloud/1.49 in stack order produces zero conflicts, and the resulting tour code matches main byte-for-byte. The locale merge adds 30 onboardingCoachmarks.firstRun.* keys, loses none, and correctly does not drag in main-only keys from unrelated PRs.
Worth knowing for the rest of this set: core/1.49 and cloud/1.49 are currently the same commit with zero commits not on main, so both take identical cherry-picks.
These must merge in stack order. #14637 (the #14143 backport) is currently failing 8 checks purely because its branch has none of this PR's files under it — setup fails, and lint/scan/fonts/perf cascade from that. Once this lands, #14637 needs its branch updated and its CI will be meaningful. Same story for #14144 and #14145, whose auto-backports failed for exactly this reason and should be re-triggered only after the ones below them land.
Backport of #14142 to
core/1.49Automatically created by backport workflow.