Skip to content

[backport cloud/1.49] feat(first-run-tour): run the tour from a picked template - #14638

Merged
comfy-pr-bot merged 2 commits into
cloud/1.49from
backport-14143-to-cloud-1.49
Aug 4, 2026
Merged

comfy-pr-bot merged 2 commits into
cloud/1.49from
backport-14143-to-cloud-1.49

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #14143 to cloud/1.49

Automatically created by backport workflow.

> **Stack — 4 of 6.** Rebuilt from scratch after the review on #13725,
split into short PRs.
> Based on #13290 (coachmark engine); each PR stacks on the one before
it.
>
> 1. #14140 — engine: canvas targets for the coachmark tour
> 2. #14141 — Getting Started screen + entry gating
> 3. #14142 — role pins + live drift guard
> 4. #14143 — the tour itself + e2e walk  ← this PR
> 5. #14144 — post-tour nudge
> 6. #14145 — unpinned workflows (share / template links)

## Summary

The tour a new user actually walks: upload, prompt, run, result. Steps
come from the resolved roles, targets are canvas nodes registered with
the engine, and the engine renders and advances them. The parallel
overlay stack from the previous attempt is conspicuously absent.

## Changes

- `TOURS.firstRun` builds real `CoachStep`s with `coachId`s and
registered canvas targets, so the engine's spotlight, positioning, copy
resolution and telemetry all apply.
- Camera framing is a glide then a fit against a known duration. No
settle detection, no watchdog — `animateToBounds` is wall-clock, so the
end time is already known. Reduced motion frames instantly rather than
skipping.
- The Run step gates on the paywall, consuming the click so the
underlying handler never queues a refused run.
- Run outcomes are matched to the tour's own workflow through the
execution store, so a job queued elsewhere can't speak for the tour.
- The tour turns Nodes 2.0 on when it starts: every step names a
`[data-node-id]`, and a new user has no `Comfy.InstalledVersion`, so the
versioned default never applies and the setting reads off. If no tour
then starts, the switch is undone.
- A Playwright walk: fresh profile → Getting Started → pick a template →
steps → Run → result.

### From the review round (`c504c6a`, `48358e6`)

- A rejecting tour resolver used to escape `begin()` and leave the
engine stuck at `resolving`, refusing every later start. It now resolves
to no steps.
- `beginTour` consulted the engine only after persisting the renderer
switch, mutating the tour registry and waiting out the preview. It bails
first, and undoes only a switch it made itself.
- The Run-button interceptor keyed on `step.name === 'run'`, so renaming
a translation key changed control flow. It reads `selfAdvancing`.
- A registered tour can now carry the condition it runs under, so the
first-run tour is torn down when the layout its coachmarks need goes
away — same path as a trigger's, without the seen flag.
- The Result step's spinner is gone. Its predicate was the same
expression as the copy beside it, and it kept spinning when a run ended
without a recorded status.

## Review focus

No feature-layer RAF, no second overlay, no second i18n namespace, no
inline telemetry — the engine owns all of it. Worth knowing: onboarding
is one-shot by design. A run that fails still ends the tour; the user
sees a "didn't finish" card and moves on.

---------

Co-authored-by: pythongosssss <125205205+pythongosssss@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: AustinMroz <austin@comfy.org>
Co-authored-by: bymyself <cbyrne@comfy.org>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 4, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) August 4, 2026 00:56
@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Aug 4, 2026
@dosubot

dosubot Bot commented Aug 4, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-09-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about ComfyUI_frontend Add Dosu to your team

@github-actions

github-actions Bot commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/04/2026, 03:47:50 AM UTC

Links

🎭 Playwright: ✅ 1785 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1764 / ❌ 0 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 46.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 52.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 135ms TBT · 95.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.3 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 161.5 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 112ms TBT · 164.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 511ms
canvas-idle: script duration 17ms
canvas-idle: TBT 0ms
canvas-idle: heap used 69.8 MB
canvas-idle: DOM nodes 19
canvas-idle: event listeners 4
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 39ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 885ms
canvas-mouse-sweep: script duration 125ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 46.1 MB
canvas-mouse-sweep: DOM nodes -130
canvas-mouse-sweep: event listeners -153
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 33
canvas-zoom-sweep: task duration 367ms
canvas-zoom-sweep: script duration 18ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.3 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 381ms
dom-widget-clipping: script duration 62ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 53.3 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 686ms
large-graph-idle: script duration 108ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 58.8 MB
large-graph-idle: DOM nodes -283
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1297ms
large-graph-pan: script duration 438ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 62.3 MB
large-graph-pan: DOM nodes -286
large-graph-pan: event listeners -148
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1504ms
large-graph-zoom: script duration 527ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 57.6 MB
large-graph-zoom: DOM nodes -289
large-graph-zoom: event listeners -153
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 679ms
minimap-idle: script duration 106ms
minimap-idle: TBT 0ms
minimap-idle: heap used 66.2 MB
minimap-idle: DOM nodes -283
minimap-idle: event listeners -148
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 398ms
subgraph-dom-widget-clipping: script duration 119ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 53.3 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 456ms
subgraph-idle: script duration 15ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 69.5 MB
subgraph-idle: DOM nodes 19
subgraph-idle: event listeners 4
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 36ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 762ms
subgraph-mouse-sweep: script duration 88ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 52.3 MB
subgraph-mouse-sweep: DOM nodes 44
subgraph-mouse-sweep: event listeners -75
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 903ms
subgraph-transition-enter: script duration 35ms
subgraph-transition-enter: TBT 135ms
subgraph-transition-enter: heap used 95.0 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2371
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4481ms
viewport-pan-sweep: script duration 1424ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 66.3 MB
viewport-pan-sweep: DOM nodes -284
viewport-pan-sweep: event listeners -148
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16633ms
vue-large-graph-idle: script duration 545ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 161.5 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16387
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 134
vue-large-graph-pan: task duration 19873ms
vue-large-graph-pan: script duration 877ms
vue-large-graph-pan: TBT 112ms
vue-large-graph-pan: heap used 164.0 MB
vue-large-graph-pan: DOM nodes -8314
vue-large-graph-pan: event listeners -16383
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 4
workflow-execution: style recalc count 12
workflow-execution: task duration 114ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 58.4 MB
workflow-execution: DOM nodes 134
workflow-execution: event listeners 73
Raw data
{
  "timestamp": "2026-08-04T03:58:29.608Z",
  "gitSha": "8875dd1c3e5e2bb123fe4b993b3002d7c83a9bf6",
  "branch": "backport-14143-to-cloud-1.49",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2113.4429999999893,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.9430000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 576.422,
      "heapDeltaBytes": 5245372,
      "heapUsedBytes": 73214708,
      "domNodes": 18,
      "jsHeapTotalBytes": 20041728,
      "scriptDurationMs": 19.884,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2038.0309999999895,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.865000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 445.29799999999994,
      "heapDeltaBytes": 5198584,
      "heapUsedBytes": 73217904,
      "domNodes": 20,
      "jsHeapTotalBytes": 20041728,
      "scriptDurationMs": 14.137,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1912.2020000000077,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 39.711000000000006,
      "layouts": 12,
      "layoutDurationMs": 3.5649999999999995,
      "taskDurationMs": 887.3380000000001,
      "heapDeltaBytes": -18028768,
      "heapUsedBytes": 50271940,
      "domNodes": -284,
      "jsHeapTotalBytes": 19382272,
      "scriptDurationMs": 126.85,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1888.9369999999985,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 39.089,
      "layouts": 12,
      "layoutDurationMs": 3.6740000000000004,
      "taskDurationMs": 882.731,
      "heapDeltaBytes": -21688928,
      "heapUsedBytes": 46411644,
      "domNodes": 25,
      "jsHeapTotalBytes": 20692992,
      "scriptDurationMs": 122.71300000000002,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.366000000014,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.986,
      "layouts": 6,
      "layoutDurationMs": 0.6119999999999999,
      "taskDurationMs": 370.226,
      "heapDeltaBytes": 7869272,
      "heapUsedBytes": 75830460,
      "domNodes": 77,
      "jsHeapTotalBytes": 20303872,
      "scriptDurationMs": 18.589,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1754.5300000000452,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 17.648999999999997,
      "layouts": 6,
      "layoutDurationMs": 0.7020000000000002,
      "taskDurationMs": 363.59799999999996,
      "heapDeltaBytes": 7835740,
      "heapUsedBytes": 75883284,
      "domNodes": 79,
      "jsHeapTotalBytes": 20041728,
      "scriptDurationMs": 17.185,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 605.5309999999849,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.425,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 398.29400000000004,
      "heapDeltaBytes": -12245536,
      "heapUsedBytes": 55942936,
      "domNodes": 18,
      "jsHeapTotalBytes": 21614592,
      "scriptDurationMs": 65.839,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 573.003999999969,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.089,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 363.864,
      "heapDeltaBytes": -12332724,
      "heapUsedBytes": 55865932,
      "domNodes": 16,
      "jsHeapTotalBytes": 21090304,
      "scriptDurationMs": 59.092,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.683000000011,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.262999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 719.9230000000001,
      "heapDeltaBytes": -3069024,
      "heapUsedBytes": 55706132,
      "domNodes": -281,
      "jsHeapTotalBytes": 3989504,
      "scriptDurationMs": 119.073,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2034.407000000101,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.680999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 651.1339999999999,
      "heapDeltaBytes": 8376780,
      "heapUsedBytes": 67554788,
      "domNodes": -284,
      "jsHeapTotalBytes": 5038080,
      "scriptDurationMs": 96.91199999999999,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2243.362999999988,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.440000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1333.904,
      "heapDeltaBytes": 5405180,
      "heapUsedBytes": 65817296,
      "domNodes": -285,
      "jsHeapTotalBytes": 5787648,
      "scriptDurationMs": 439.11799999999994,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2154.568999999924,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.157000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1259.447,
      "heapDeltaBytes": 4118916,
      "heapUsedBytes": 64934172,
      "domNodes": -287,
      "jsHeapTotalBytes": 5263360,
      "scriptDurationMs": 436.039,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3277.547000000027,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 12.839999999999998,
      "layouts": 60,
      "layoutDurationMs": 7.639000000000001,
      "taskDurationMs": 1545.3570000000002,
      "heapDeltaBytes": 2689908,
      "heapUsedBytes": 64693060,
      "domNodes": -290,
      "jsHeapTotalBytes": 7659520,
      "scriptDurationMs": 549.3280000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3146.3959999999815,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 13.620999999999997,
      "layouts": 60,
      "layoutDurationMs": 6.675999999999999,
      "taskDurationMs": 1463.225,
      "heapDeltaBytes": -5324844,
      "heapUsedBytes": 56188432,
      "domNodes": -287,
      "jsHeapTotalBytes": 7921664,
      "scriptDurationMs": 505.23799999999994,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.6090000000127,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.041,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 716.2620000000001,
      "heapDeltaBytes": 8596612,
      "heapUsedBytes": 69420024,
      "domNodes": -283,
      "jsHeapTotalBytes": 3465216,
      "scriptDurationMs": 116.506,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2025.1009999999496,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.863000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 642.2160000000001,
      "heapDeltaBytes": 8603824,
      "heapUsedBytes": 69458240,
      "domNodes": -283,
      "jsHeapTotalBytes": 4251648,
      "scriptDurationMs": 95.437,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 610.7560000000376,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.583,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 410.231,
      "heapDeltaBytes": -12426084,
      "heapUsedBytes": 55979504,
      "domNodes": 18,
      "jsHeapTotalBytes": 22401024,
      "scriptDurationMs": 119.935,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 551.559999999995,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.424,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 386.09,
      "heapDeltaBytes": -12242332,
      "heapUsedBytes": 55879580,
      "domNodes": 20,
      "jsHeapTotalBytes": 22925312,
      "scriptDurationMs": 117.707,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.089999999972,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.935,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 484.117,
      "heapDeltaBytes": 4530240,
      "heapUsedBytes": 72822468,
      "domNodes": 20,
      "jsHeapTotalBytes": 20566016,
      "scriptDurationMs": 17.558,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.667999999977,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.002000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 428.46099999999996,
      "heapDeltaBytes": 4839696,
      "heapUsedBytes": 72976508,
      "domNodes": 18,
      "jsHeapTotalBytes": 20303872,
      "scriptDurationMs": 11.575999999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1746.7459999999733,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 39.04,
      "layouts": 16,
      "layoutDurationMs": 4.35,
      "taskDurationMs": 754.786,
      "heapDeltaBytes": -4656780,
      "heapUsedBytes": 63459948,
      "domNodes": 67,
      "jsHeapTotalBytes": 20566016,
      "scriptDurationMs": 90.947,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1726.9209999999475,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 33.71300000000001,
      "layouts": 16,
      "layoutDurationMs": 3.4430000000000005,
      "taskDurationMs": 768.396,
      "heapDeltaBytes": -22274208,
      "heapUsedBytes": 46184684,
      "domNodes": 21,
      "jsHeapTotalBytes": 20430848,
      "scriptDurationMs": 85.20700000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.5579999999895,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 29.758000000000006,
      "layouts": 15,
      "layoutDurationMs": 13.369,
      "taskDurationMs": 902.5659999999998,
      "heapDeltaBytes": 30980760,
      "heapUsedBytes": 99638280,
      "domNodes": 13673,
      "jsHeapTotalBytes": 14680064,
      "scriptDurationMs": 35.03200000000001,
      "eventListeners": 2371,
      "totalBlockingTimeMs": 135,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8534.468000000004,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 36.483000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4714.975,
      "heapDeltaBytes": 7861992,
      "heapUsedBytes": 66704704,
      "domNodes": -283,
      "jsHeapTotalBytes": 7327744,
      "scriptDurationMs": 1512.76,
      "eventListeners": -163,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8222.572000000015,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 33.638,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4247.1449999999995,
      "heapDeltaBytes": 9784656,
      "heapUsedBytes": 72435604,
      "domNodes": -285,
      "jsHeapTotalBytes": 6279168,
      "scriptDurationMs": 1335.465,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16914.91499999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16890.054,
      "heapDeltaBytes": -36200220,
      "heapUsedBytes": 166993276,
      "domNodes": -8312,
      "jsHeapTotalBytes": -13049856,
      "scriptDurationMs": 570.685,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16410.049000000072,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16375.253,
      "heapDeltaBytes": -38087296,
      "heapUsedBytes": 171758868,
      "domNodes": -8312,
      "jsHeapTotalBytes": -4399104,
      "scriptDurationMs": 519.514,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19953.201000000037,
      "styleRecalcs": 134,
      "styleRecalcDurationMs": 15.112999999999987,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19923.384000000002,
      "heapDeltaBytes": -30260556,
      "heapUsedBytes": 176987780,
      "domNodes": -8316,
      "jsHeapTotalBytes": -9973760,
      "scriptDurationMs": 863.495,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 146,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19866.60100000006,
      "styleRecalcs": 134,
      "styleRecalcDurationMs": 14.382000000000033,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19823.208000000002,
      "heapDeltaBytes": -40161576,
      "heapUsedBytes": 166851296,
      "domNodes": -8312,
      "jsHeapTotalBytes": -11214848,
      "scriptDurationMs": 891.4380000000001,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 78,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 145.13099999999213,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 18.342,
      "layouts": 3,
      "layoutDurationMs": 1.3900000000000001,
      "taskDurationMs": 92.84,
      "heapDeltaBytes": 3468652,
      "heapUsedBytes": 70723000,
      "domNodes": 146,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 7.213000000000001,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 470.58000000004085,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 23.417,
      "layouts": 4,
      "layoutDurationMs": 1.434,
      "taskDurationMs": 134.75300000000001,
      "heapDeltaBytes": -15470968,
      "heapUsedBytes": 51777388,
      "domNodes": 121,
      "jsHeapTotalBytes": 6934528,
      "scriptDurationMs": 11.242,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.27007% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/platform/onboarding/TourSpotlight.vue 95.83% 1 Missing ⚠️
.../renderer/extensions/firstRunTour/FirstRunTour.vue 0.00% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.49   #14638   +/-   ##
=============================================
  Coverage              ?   78.52%           
=============================================
  Files                 ?     1784           
  Lines                 ?   104084           
  Branches              ?    32778           
=============================================
  Hits                  ?    81734           
  Misses                ?    21919           
  Partials              ?      431           
Flag Coverage Δ
unit 70.60% <99.27%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/actionbar/ComfyActionbar.vue 82.22% <100.00%> (ø)
src/platform/onboarding/coachmarkLayout.ts 95.34% <100.00%> (ø)
src/platform/onboarding/onboardingTourStore.ts 98.26% <100.00%> (ø)
src/platform/onboarding/onboardingTours.ts 96.15% <100.00%> (ø)
src/platform/onboarding/tourState.ts 100.00% <100.00%> (ø)
src/platform/onboarding/useCoachmarkTarget.ts 96.34% <100.00%> (ø)
src/platform/telemetry/types.ts 100.00% <ø> (ø)
...rstRunTour/gettingStarted/GettingStartedScreen.vue 84.72% <100.00%> (ø)
...erer/extensions/firstRunTour/tour/cameraFraming.ts 100.00% <100.00%> (ø)
...nsions/firstRunTour/tour/firstRunTourDefinition.ts 100.00% <100.00%> (ø)
... and 3 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — clean backport of #14143, which I reviewed and approved on main.

This PR was failing 8 checks earlier (setup, and lint/scan/fonts/perf cascading from it). That was not a defect in the backport. The auto-backport bot cherry-picks each PR onto the release branch independently, so this branch carried #14143's code with none of #14142's underneath it — it merged textually and then could not build. Now that #14634/#14635 have landed, I merged the release branch in and CI is green: 49 success, 8 skipped, zero failures.

Same story applies to the #14144 and #14145 backports, whose auto-attempts failed for exactly this reason. I'll re-trigger those once this pair lands.

For confidence rather than hope: a dry run cherry-picking all four onto core/1.49 and cloud/1.49 in stack order produced zero conflicts, the resulting tour code matches main byte-for-byte, and the locale merge loses no keys while correctly not dragging in main-only strings from unrelated PRs.

@comfy-pr-bot
comfy-pr-bot merged commit ff52203 into cloud/1.49 Aug 4, 2026
57 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-14143-to-cloud-1.49 branch August 4, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants