Skip to content

fix: label account menu entry for the settings panel it opens - #14600

Closed
christian-byrne wants to merge 4 commits into
mainfrom
glary/fe-1485-manage-plan-label
Closed

christian-byrne wants to merge 4 commits into
mainfrom
glary/fe-1485-manage-plan-label

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

PR Created by the Glary-Bot Agent


Summary

The account popover entry read "Manage plan" on every distribution, but Settings only hosts a plan-management panel on Cloud. On local/desktop builds the entry opens Settings → Credits (balance + usage), which is what the user reported.

Changes

  • What: The entry's label is now derived from the panel it actually opens, in both CurrentUserPopoverLegacy.vue and CurrentUserPopoverWorkspace.vue:
    • Cloud → "Manage plan", opens the plan panel (subscription / workspace) — unchanged.
    • Off Cloud → "Credits", opens the credits panel, matching that panel's own title in the Settings sidebar.
  • Why relabel instead of reroute: there is no plan-management view to route to off Cloud. subscriptionPanel in src/platform/settings/composables/useSettingUI.ts is null unless isCloud && __CONFIG__.subscription_required, and legacy billing has no plans at all (useLegacyBilling returns plans: [], currentPlanSlug: null). The entry still appears off Cloud because isActiveSubscription is hardcoded true there (isSubscribedOrIsNotCloud), which is what surfaced the mislabeled item.
  • Routing/behavior: unchanged. No new i18n keys — reuses the existing credits.credits.
  • Breaking: none. data-testid="manage-plan-menu-item" is kept, so existing e2e specs (localCreditsNoSubscribeUi, pricingTableDeepLink) are unaffected.

Review Focus

  • The label must track the destination, not the tier: off Cloud it reads "Credits" for every tier, since no plan panel exists to open.
  • Unit coverage asserts label and destination per distribution in both popovers; both new label assertions fail against main.

Verification

  • pnpm typecheck, pnpm lint (0 errors), pnpm format:check, pnpm knip — clean.
  • pnpm vitest run on both popover suites — 39 passing.
  • Manual: local (non-Cloud) build against a running ComfyUI backend, signed in via the repo's Firebase auth mock, driving the real popover in Chromium. Screenshots below reproduce the reported flow — the entry now reads "Credits" and lands on the Credits panel highlighted in the sidebar.

Screenshots

Screenshots

Account menu on a local build: the entry now reads Credits instead of Manage plan

Clicking the entry opens Settings with the Credits panel selected, matching the label

The account popover entry read "Manage plan" on every distribution, but
Settings only hosts a plan-management panel on Cloud. Elsewhere the entry
opens the Credits panel, so it now reads "Credits" there.
@github-actions

github-actions Bot commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1777 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1758 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/03/2026, 09:34:10 AM UTC

Links

📦 Bundle: 8.21 MB gzip 🔴 +31 B

Details

Summary

  • Raw size: 34.5 MB baseline 34.5 MB — 🔴 +124 B
  • Gzip: 8.21 MB baseline 8.21 MB — 🔴 +31 B
  • Brotli: 5.68 MB baseline 5.68 MB — 🔴 +55 B
  • Bundles: 427 current • 427 baseline • 4 added / 4 removed

Category Glance
Other 🔴 +62 B (12.8 MB) · Graph Workspace 🔴 +62 B (1.29 MB) · Vendor & Third-Party ⚪ 0 B (15.7 MB) · Data & Services ⚪ 0 B (3.45 MB) · Panels & Settings ⚪ 0 B (551 kB) · Utilities & Hooks ⚪ 0 B (386 kB) · + 5 more

App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-34YwEiEz.js (new) — 3.64 kB 🔴 +3.64 kB 🔴 +1.82 kB 🔴 +1.59 kB
assets/index-DQN0Qv6q.js (removed) 3.64 kB — 🟢 -3.64 kB 🟢 -1.82 kB 🟢 -1.6 kB

Status: 1 added / 1 removed

Graph Workspace — 1.29 MB (baseline 1.29 MB) • 🔴 +62 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-BXn5L1pr.js (new) — 1.29 MB 🔴 +1.29 MB 🔴 +276 kB 🔴 +208 kB
assets/GraphView-CAq8Qh4f.js (removed) 1.29 MB — 🟢 -1.29 MB 🟢 -276 kB 🟢 -208 kB

Status: 1 added / 1 removed / 1 unchanged

Views & Navigation — 111 kB (baseline 111 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 16 unchanged

Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 26 unchanged

User & Accounts — 28.7 kB (baseline 28.7 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 10 unchanged

Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 7 unchanged

UI Components — 70 kB (baseline 70 kB) • ⚪ 0 B

Reusable component library chunks

Status: 15 unchanged

Data & Services — 3.45 MB (baseline 3.45 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 36 unchanged

Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 16 unchanged

Other — 12.8 MB (baseline 12.8 MB) • 🔴 +62 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/main-CxnUIa3X.js (new) — 46.9 kB 🔴 +46.9 kB 🔴 +13.8 kB 🔴 +12 kB
assets/main-DtqtZur9.js (removed) 46.9 kB — 🟢 -46.9 kB 🟢 -13.8 kB 🟢 -12 kB
assets/CurrentUserPopoverWorkspace-BmF7HouT.js (new) — 20.6 kB 🔴 +20.6 kB 🔴 +4.71 kB 🔴 +4.2 kB
assets/CurrentUserPopoverWorkspace-BmK9j9I7.js (removed) 20.5 kB — 🟢 -20.5 kB 🟢 -4.69 kB 🟢 -4.18 kB

Status: 2 added / 2 removed / 279 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 45.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 45.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 138ms TBT · 94.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 161.5 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 200ms TBT · 165.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.7 MB heap

⚠️ 7 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 682ms 549ms -19% ⚠️ z=5.0
canvas-mouse-sweep: task duration 1116ms 983ms -12% ⚠️ z=2.0
canvas-zoom-sweep: task duration 467ms 388ms -17% ⚠️ z=2.7
large-graph-idle: task duration 894ms 692ms -23% ⚠️ z=2.8
large-graph-pan: task duration 1573ms 1314ms -16% ⚠️ z=5.4
minimap-idle: task duration 887ms 698ms -21% ⚠️ z=3.6
subgraph-idle: task duration 615ms 496ms -19% ⚠️ z=4.0
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.1
canvas-idle: p95 frame time 17ms 17ms +0% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 10ms 9ms -13% z=-2.0
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 9 10 +6% z=-2.9
canvas-idle: task duration 682ms 549ms -19% ⚠️ z=5.0
canvas-idle: script duration 29ms 21ms -30% z=-2.1
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 69.5 MB 69.4 MB -0% —
canvas-idle: DOM nodes 18 19 +6% z=-2.8
canvas-idle: event listeners 4 4 +0% z=-1.6
canvas-mouse-sweep: avg frame time 17ms 17ms -0% z=-1.5
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 4ms 4ms -7% z=0.6
canvas-mouse-sweep: style recalc duration 54ms 48ms -11% z=1.7
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 79 80 +1% z=0.3
canvas-mouse-sweep: task duration 1116ms 983ms -12% ⚠️ z=2.0
canvas-mouse-sweep: script duration 151ms 135ms -11% z=-0.1
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 49.3 MB 45.0 MB -9% —
canvas-mouse-sweep: DOM nodes -280 -280 -0% z=-132.2
canvas-mouse-sweep: event listeners -148 -148 +0% z=-37.5
canvas-zoom-sweep: avg frame time 17ms 17ms +0% z=1.4
canvas-zoom-sweep: p95 frame time 17ms 17ms -1% —
canvas-zoom-sweep: layout duration 1ms 1ms -14% z=-1.7
canvas-zoom-sweep: style recalc duration 20ms 18ms -10% z=-0.7
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 32 32 -2% z=0.5
canvas-zoom-sweep: task duration 467ms 388ms -17% ⚠️ z=2.7
canvas-zoom-sweep: script duration 28ms 21ms -25% z=-2.0
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 72.3 MB 72.3 MB -0% —
canvas-zoom-sweep: DOM nodes 78 79 +1% z=-0.9
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.2
dom-widget-clipping: p95 frame time 17ms 17ms +0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 9ms 7ms -17% z=-3.3
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 10 11 +5% z=-5.2
dom-widget-clipping: task duration 446ms 379ms -15% z=0.9
dom-widget-clipping: script duration 67ms 60ms -11% z=-2.5
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 53.3 MB 53.1 MB -0% —
dom-widget-clipping: DOM nodes 16 17 +6% z=-3.6
dom-widget-clipping: event listeners 2 0 -100% variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=-0.2
large-graph-idle: p95 frame time 17ms 17ms +0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 9ms 9ms +5% z=-2.7
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 8 10 +19% z=-6.7
large-graph-idle: task duration 894ms 692ms -23% ⚠️ z=2.8
large-graph-idle: script duration 146ms 111ms -24% z=0.8
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 64.3 MB 63.6 MB -1% —
large-graph-idle: DOM nodes -281 -281 +0% z=-338.2
large-graph-idle: event listeners -144 -144 +0% z=-27.9
large-graph-pan: avg frame time 17ms 17ms +0% z=0.3
large-graph-pan: p95 frame time 17ms 17ms -1% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 15ms 14ms -6% z=-3.6
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 69 69 -1% z=-1.7
large-graph-pan: task duration 1573ms 1314ms -16% ⚠️ z=5.4
large-graph-pan: script duration 524ms 445ms -15% z=1.9
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 65.8 MB 62.5 MB -5% —
large-graph-pan: DOM nodes -285 -284 -0% z=-183.7
large-graph-pan: event listeners -144 -144 +0% z=-179.9
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms -0% —
large-graph-zoom: layout duration 8ms 7ms -12% —
large-graph-zoom: style recalc duration 16ms 14ms -10% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 63 64 +2% —
large-graph-zoom: task duration 1785ms 1559ms -13% —
large-graph-zoom: script duration 633ms 548ms -13% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 57.7 MB 60.5 MB +5% —
large-graph-zoom: DOM nodes -288 -288 +0% —
large-graph-zoom: event listeners -146 -148 +1% —
minimap-idle: avg frame time 17ms 17ms -0% z=0.1
minimap-idle: p95 frame time 17ms 17ms +0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 8ms 8ms +5% z=-1.7
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 7 9 +21% z=-1.6
minimap-idle: task duration 887ms 698ms -21% ⚠️ z=3.6
minimap-idle: script duration 140ms 114ms -19% z=1.6
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 66.0 MB 65.5 MB -1% —
minimap-idle: DOM nodes -281 -284 +1% z=-221.3
minimap-idle: event listeners -144 -145 +1% z=-226.5
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.4
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms -1% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 12ms 11ms -7% z=-2.0
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 46 47 +2% z=-1.6
subgraph-dom-widget-clipping: task duration 441ms 394ms -11% z=0.8
subgraph-dom-widget-clipping: script duration 127ms 118ms -7% z=-1.6
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 54.5 MB 54.0 MB -1% —
subgraph-dom-widget-clipping: DOM nodes 18 20 +11% z=-1.9
subgraph-dom-widget-clipping: event listeners 8 6 -25% z=-1.7
subgraph-idle: avg frame time 17ms 17ms -0% z=-0.2
subgraph-idle: p95 frame time 17ms 17ms +0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 8ms 9ms +9% z=-1.7
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 8 10 +25% z=-1.4
subgraph-idle: task duration 615ms 496ms -19% ⚠️ z=4.0
subgraph-idle: script duration 25ms 15ms -41% z=-2.0
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 69.0 MB 56.5 MB -18% —
subgraph-idle: DOM nodes 16 -130 -909% z=-101.2
subgraph-idle: event listeners 4 -72 -1900% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms -0% z=-0.1
subgraph-mouse-sweep: p95 frame time 17ms 17ms +1% —
subgraph-mouse-sweep: layout duration 5ms 5ms -6% z=0.0
subgraph-mouse-sweep: style recalc duration 45ms 39ms -12% z=-0.9
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 76 77 +1% z=-1.6
subgraph-mouse-sweep: task duration 988ms 855ms -13% z=1.3
subgraph-mouse-sweep: script duration 109ms 97ms -10% z=-0.5
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 46.7 MB 45.0 MB -4% —
subgraph-mouse-sweep: DOM nodes -280 -278 -1% z=-154.4
subgraph-mouse-sweep: event listeners -146 -148 +1% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms +0% —
subgraph-transition-enter: p95 frame time 17ms 17ms +0% —
subgraph-transition-enter: layout duration 14ms 12ms -9% —
subgraph-transition-enter: style recalc duration 33ms 30ms -7% —
subgraph-transition-enter: layout count 13 13 +0% —
subgraph-transition-enter: style recalc count 17 17 +0% —
subgraph-transition-enter: task duration 1064ms 963ms -10% —
subgraph-transition-enter: script duration 42ms 38ms -10% —
subgraph-transition-enter: TBT 140ms 138ms -1% —
subgraph-transition-enter: heap used 95.0 MB 94.8 MB -0% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2369 2371 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms -0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 42ms 36ms -13% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 250 250 -0% —
viewport-pan-sweep: task duration 5389ms 4541ms -16% —
viewport-pan-sweep: script duration 1701ms 1405ms -17% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 78.1 MB 68.9 MB -12% —
viewport-pan-sweep: DOM nodes -282 -282 +0% —
viewport-pan-sweep: event listeners -126 -128 +2% —
vue-large-graph-idle: avg frame time 18ms 18ms +2% —
vue-large-graph-idle: p95 frame time 17ms 17ms -0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 17809ms 17521ms -2% —
vue-large-graph-idle: script duration 638ms 603ms -5% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 159.7 MB 161.5 MB +1% —
vue-large-graph-idle: DOM nodes -8312 -8313 +0% —
vue-large-graph-idle: event listeners -16385 -16386 +0% —
vue-large-graph-pan: avg frame time 18ms 18ms -3% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 24ms 18ms -25% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 166 145 -13% —
vue-large-graph-pan: task duration 22504ms 21063ms -6% —
vue-large-graph-pan: script duration 984ms 909ms -8% —
vue-large-graph-pan: TBT 648ms 200ms -69% —
vue-large-graph-pan: heap used 157.5 MB 165.1 MB +5% —
vue-large-graph-pan: DOM nodes -8312 -8318 +0% —
vue-large-graph-pan: event listeners -16379 -16384 +0% —
workflow-execution: avg frame time 17ms 17ms +0% z=0.6
workflow-execution: p95 frame time 17ms 17ms +0% —
workflow-execution: layout duration 1ms 1ms +38% z=-3.4
workflow-execution: style recalc duration 19ms 20ms +2% z=-2.0
workflow-execution: layout count 3 4 +17% z=-2.7
workflow-execution: style recalc count 13 12 -12% z=-3.1
workflow-execution: task duration 129ms 119ms -8% z=-0.4
workflow-execution: script duration 12ms 11ms -6% z=-6.1
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 48.6 MB 48.7 MB +0% —
workflow-execution: DOM nodes 121 122 +0% z=-5.5
workflow-execution: event listeners 65 66 +2% z=3.2
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-08-03T09:49:01.321Z",
  "gitSha": "7651855164ed54b671c40128c5f0154cddc9b2d2",
  "branch": "glary/fe-1485-manage-plan-label",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2179.8330000000306,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.155999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 620.1059999999999,
      "heapDeltaBytes": 5053096,
      "heapUsedBytes": 72775792,
      "domNodes": 20,
      "jsHeapTotalBytes": 21098496,
      "scriptDurationMs": 21.436999999999998,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2011.9280000000117,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.839999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 478.77699999999993,
      "heapDeltaBytes": 4874012,
      "heapUsedBytes": 72733668,
      "domNodes": 18,
      "jsHeapTotalBytes": 20836352,
      "scriptDurationMs": 19.94,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1968.8170000000014,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 49.98499999999999,
      "layouts": 12,
      "layoutDurationMs": 3.873,
      "taskDurationMs": 987.716,
      "heapDeltaBytes": -20791780,
      "heapUsedBytes": 46869112,
      "domNodes": -280,
      "jsHeapTotalBytes": 20701184,
      "scriptDurationMs": 135.70000000000002,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1939.6419999999353,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 46.21,
      "layouts": 12,
      "layoutDurationMs": 3.5699999999999994,
      "taskDurationMs": 978.966,
      "heapDeltaBytes": -20527996,
      "heapUsedBytes": 47543712,
      "domNodes": -279,
      "jsHeapTotalBytes": 20701184,
      "scriptDurationMs": 134.09799999999998,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1754.9750000000017,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.347,
      "layouts": 6,
      "layoutDurationMs": 0.5149999999999998,
      "taskDurationMs": 374.19599999999997,
      "heapDeltaBytes": 8002444,
      "heapUsedBytes": 75809140,
      "domNodes": 78,
      "jsHeapTotalBytes": 19787776,
      "scriptDurationMs": 18.647,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1753.9259999999786,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.868999999999996,
      "layouts": 6,
      "layoutDurationMs": 0.621,
      "taskDurationMs": 401.99100000000004,
      "heapDeltaBytes": 7956008,
      "heapUsedBytes": 75804272,
      "domNodes": 79,
      "jsHeapTotalBytes": 20312064,
      "scriptDurationMs": 23.531000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 550.7460000000037,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.517,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 369.153,
      "heapDeltaBytes": -11938424,
      "heapUsedBytes": 55881548,
      "domNodes": 16,
      "jsHeapTotalBytes": 21622784,
      "scriptDurationMs": 59.43399999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 591.7719999999917,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.055000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 388.68199999999996,
      "heapDeltaBytes": -12399764,
      "heapUsedBytes": 55423040,
      "domNodes": 18,
      "jsHeapTotalBytes": 22409216,
      "scriptDurationMs": 59.97500000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2028.6239999999793,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.949,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 684.6409999999998,
      "heapDeltaBytes": 7957204,
      "heapUsedBytes": 66710704,
      "domNodes": -281,
      "jsHeapTotalBytes": 5042176,
      "scriptDurationMs": 107.64,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2027.798999999959,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.93,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 698.78,
      "heapDeltaBytes": 7962424,
      "heapUsedBytes": 66739520,
      "domNodes": -281,
      "jsHeapTotalBytes": 4517888,
      "scriptDurationMs": 115.123,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2201.7759999999953,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.161000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1279.9019999999998,
      "heapDeltaBytes": 6059756,
      "heapUsedBytes": 65759860,
      "domNodes": -283,
      "jsHeapTotalBytes": 5529600,
      "scriptDurationMs": 441.525,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2221.4170000000877,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.646000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1347.3290000000002,
      "heapDeltaBytes": 5506880,
      "heapUsedBytes": 65378476,
      "domNodes": -285,
      "jsHeapTotalBytes": 4743168,
      "scriptDurationMs": 449.25100000000003,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3180.768999999998,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 12.535999999999998,
      "layouts": 60,
      "layoutDurationMs": 7.020000000000001,
      "taskDurationMs": 1484.067,
      "heapDeltaBytes": -3343548,
      "heapUsedBytes": 59308420,
      "domNodes": -288,
      "jsHeapTotalBytes": 6615040,
      "scriptDurationMs": 521.8660000000001,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3328.512000000046,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.54,
      "layouts": 60,
      "layoutDurationMs": 7.882999999999999,
      "taskDurationMs": 1634.5400000000002,
      "heapDeltaBytes": 5884164,
      "heapUsedBytes": 67610216,
      "domNodes": -288,
      "jsHeapTotalBytes": 7663616,
      "scriptDurationMs": 573.7900000000001,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2009.0609999999742,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.234000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 664.8739999999999,
      "heapDeltaBytes": 7642428,
      "heapUsedBytes": 68590232,
      "domNodes": -283,
      "jsHeapTotalBytes": 4780032,
      "scriptDurationMs": 102.69300000000001,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.8340000000744,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.058,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 731.4590000000001,
      "heapDeltaBytes": 7676396,
      "heapUsedBytes": 68684976,
      "domNodes": -284,
      "jsHeapTotalBytes": 5042176,
      "scriptDurationMs": 125.21500000000002,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 571.4639999999918,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.715,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 385.517,
      "heapDeltaBytes": -11849328,
      "heapUsedBytes": 56176300,
      "domNodes": 20,
      "jsHeapTotalBytes": 22147072,
      "scriptDurationMs": 116.874,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 593.8710000000356,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.867999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.0759999999999,
      "heapDeltaBytes": -10856632,
      "heapUsedBytes": 57156864,
      "domNodes": 20,
      "jsHeapTotalBytes": 21360640,
      "scriptDurationMs": 118.72600000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2051.160999999979,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.913999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 495.13899999999995,
      "heapDeltaBytes": -22157004,
      "heapUsedBytes": 45826740,
      "domNodes": -281,
      "jsHeapTotalBytes": 20176896,
      "scriptDurationMs": 13.491000000000001,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2029.5210000000452,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.304999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 496.155,
      "heapDeltaBytes": 4637484,
      "heapUsedBytes": 72681180,
      "domNodes": 22,
      "jsHeapTotalBytes": 21360640,
      "scriptDurationMs": 16.242,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1712.5479999999698,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 38.376,
      "layouts": 16,
      "layoutDurationMs": 4.840000000000001,
      "taskDurationMs": 854.7090000000001,
      "heapDeltaBytes": -20444208,
      "heapUsedBytes": 47474048,
      "domNodes": -278,
      "jsHeapTotalBytes": 20176896,
      "scriptDurationMs": 96.89699999999999,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1710.5930000000171,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 40.62200000000001,
      "layouts": 16,
      "layoutDurationMs": 4.5760000000000005,
      "taskDurationMs": 855.234,
      "heapDeltaBytes": -21138884,
      "heapUsedBytes": 46849228,
      "domNodes": -278,
      "jsHeapTotalBytes": 20701184,
      "scriptDurationMs": 97.63900000000001,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1385.2040000000443,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 30.267000000000003,
      "layouts": 13,
      "layoutDurationMs": 12.379000000000001,
      "taskDurationMs": 962.6100000000002,
      "heapDeltaBytes": 30923160,
      "heapUsedBytes": 99401100,
      "domNodes": 13673,
      "jsHeapTotalBytes": 15204352,
      "scriptDurationMs": 37.57799999999999,
      "eventListeners": 2371,
      "totalBlockingTimeMs": 138,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8284.156999999994,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 36.516999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4389.983,
      "heapDeltaBytes": 13246900,
      "heapUsedBytes": 72123144,
      "domNodes": -281,
      "jsHeapTotalBytes": 7331840,
      "scriptDurationMs": 1381.5059999999999,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8385.869999999955,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.458,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4691.509,
      "heapDeltaBytes": 13734268,
      "heapUsedBytes": 72446332,
      "domNodes": -283,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 1427.5420000000001,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17717.982000000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17666.333000000002,
      "heapDeltaBytes": -58782800,
      "heapUsedBytes": 167444248,
      "domNodes": -8313,
      "jsHeapTotalBytes": -9379840,
      "scriptDurationMs": 604.4350000000001,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17406.459999999926,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17376.625,
      "heapDeltaBytes": -50437928,
      "heapUsedBytes": 171161380,
      "domNodes": -8312,
      "jsHeapTotalBytes": -9379840,
      "scriptDurationMs": 602.4459999999999,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20841.82699999997,
      "styleRecalcs": 142,
      "styleRecalcDurationMs": 16.654000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20803.663,
      "heapDeltaBytes": -33051644,
      "heapUsedBytes": 179560296,
      "domNodes": -8312,
      "jsHeapTotalBytes": -13119488,
      "scriptDurationMs": 887.794,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 132,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21369.669000000045,
      "styleRecalcs": 148,
      "styleRecalcDurationMs": 18.971000000000014,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21321.579,
      "heapDeltaBytes": -42792720,
      "heapUsedBytes": 166770316,
      "domNodes": -8324,
      "jsHeapTotalBytes": -10166272,
      "scriptDurationMs": 929.353,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 268,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 465.1690000000599,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 15.956999999999999,
      "layouts": 3,
      "layoutDurationMs": 0.6619999999999998,
      "taskDurationMs": 112.534,
      "heapDeltaBytes": -15925188,
      "heapUsedBytes": 51132548,
      "domNodes": 124,
      "jsHeapTotalBytes": 7991296,
      "scriptDurationMs": 10.331,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 477.31999999996333,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 23.558000000000003,
      "layouts": 4,
      "layoutDurationMs": 1.463,
      "taskDurationMs": 124.952,
      "heapDeltaBytes": -15972632,
      "heapUsedBytes": 50964180,
      "domNodes": 119,
      "jsHeapTotalBytes": 7204864,
      "scriptDurationMs": 11.763000000000002,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@coderabbitai

coderabbitai Bot commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The legacy and workspace user popovers now show “Manage plan” for cloud deployments and “Credits” otherwise. Tests verify the corresponding settings panels, targets, and popover close behavior.

Changes

Popover billing actions

Layer / File(s) Summary
Legacy popover billing behavior
src/components/topbar/CurrentUserPopoverLegacy.vue, src/components/topbar/CurrentUserPopoverLegacy.test.ts, browser_tests/tests/localCreditsNoSubscribeUi.spec.ts
The menu label is computed from cloud mode. Tests verify subscription and credits settings behavior. The browser test identifies the plan and credits entry as the route to Settings > Credits.
Workspace popover billing behavior
src/platform/workspace/components/CurrentUserPopoverWorkspace.vue, src/platform/workspace/components/CurrentUserPopoverWorkspace.test.ts
The menu label and settings-dialog target depend on cloud mode. Tests cover both distributions and reset the cloud-mode mock between cases.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: size:XS

Suggested reviewers: dante01yoon

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The PR changes frontend files and also changes browser_tests/tests/localCreditsNoSubscribeUi.spec.ts, so the missing end-to-end coverage condition is false.
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed files are popover components and tests; none are under src/lib/litegraph/, src/ecs/, or graph-entity-related paths.
Title check ✅ Passed The title clearly summarizes the main change: aligning the account menu label with the Settings panel it opens.
Description check ✅ Passed The description covers the required summary, changes, review focus, screenshots, issue reference, and verification details.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch glary/fe-1485-manage-plan-label

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/topbar/CurrentUserPopoverLegacy.test.ts`:
- Around line 512-521: Update the three specified test branches to capture the
popover close handler and assert one close event after the menu click:
src/components/topbar/CurrentUserPopoverLegacy.test.ts lines 512-521 for the
credits branch,
src/platform/workspace/components/CurrentUserPopoverWorkspace.test.ts lines
266-278 for off-cloud credits, and lines 280-292 for cloud plan management.
Preserve the existing label and settings-target assertions while adding the
close-event verification to each branch.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2d27fc28-23dd-4429-a202-b477125e5087

📥 Commits

Reviewing files that changed from the base of the PR and between 8291e69 and a730388.

📒 Files selected for processing (4)
  • src/components/topbar/CurrentUserPopoverLegacy.test.ts
  • src/components/topbar/CurrentUserPopoverLegacy.vue
  • src/platform/workspace/components/CurrentUserPopoverWorkspace.test.ts
  • src/platform/workspace/components/CurrentUserPopoverWorkspace.vue

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main   #14600   +/-   ##
=======================================
  Coverage   79.10%   79.10%           
=======================================
  Files        1769     1769           
  Lines      118915   118919    +4     
  Branches    37501    37487   -14     
=======================================
+ Hits        94062    94076   +14     
+ Misses      24228    24213   -15     
- Partials      625      630    +5     
Flag Coverage Δ
unit 70.27% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/topbar/CurrentUserPopoverLegacy.vue 73.04% <100.00%> (+4.90%) ⬆️
...rkspace/components/CurrentUserPopoverWorkspace.vue 81.98% <100.00%> (+4.91%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne marked this pull request as ready for review August 3, 2026 09:54
@christian-byrne
christian-byrne requested a review from a team August 3, 2026 09:54
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 3, 2026
@dosubot

dosubot Bot commented Aug 3, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-09-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about ComfyUI_frontend Add Dosu to your team

@dante01yoon

Copy link
Copy Markdown
Collaborator

This is not valid. workspace should be shown, not Credits.

@dante01yoon dante01yoon closed this Aug 3, 2026
@glary-bot

glary-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

Thanks — before I change anything I want to check we're looking at the same surface, because I think we may not be.

On Cloud this PR changes nothing. The entry still reads "Manage plan" and still opens the workspace panel:

  • CurrentUserPopoverWorkspace → settingsDialog.show('workspace') (unchanged)
  • CurrentUserPopoverLegacy → settingsDialog.show('subscription') (unchanged)

Only the non-Cloud branch changed, and the bug reported in FE-1485 is non-Cloud. Two independent tells in the reporter's screenshots:

  1. The popover reads Partner nodes pricing → Manage plan → Account settings → Log Out. In CurrentUserPopoverLegacy.vue, plans-pricing-menu-item sits between partner-nodes and manage-plan and is v-if="isCloud" — it's absent. CurrentUserPopoverWorkspace is ruled out too: it orders plans-pricing → manage-plan → partner-nodes and always renders Workspace settings, neither of which matches.
  2. The Settings sidebar reads ACCOUNT: User, Credits. That's the legacy sidebar; on Cloud with team workspaces you get WORKSPACE: Plan & Credits, Members.

Off Cloud there is currently no workspace panel to show. I verified this against useSettingUI rather than assuming — with isCloud: false but teamWorkspacesEnabled: true, billingControlEnabled: true, logged in, active subscription, billingType: 'workspace':

navGroups:                  [Account: user, credits] [Application Settings: Comfy, LiteGraph, Appearance] [Special Settings: ...]
findPanelByKey('workspace'): null
useSettingUI('workspace') →  defaultCategory = root/Comfy  ("Comfy")

teamWorkspacesEnabled is computed as isCloud && flags.teamWorkspacesEnabled, so the key doesn't exist and defaultCategory falls back to settingCategories[0]. Routing this entry to 'workspace' off Cloud would drop the user on the Comfy settings page — strictly worse than today.

So which do you want?

(a) Keep this PR as-is — a labeling fix. Off Cloud the entry reads "Credits" because the Credits panel is the only thing Settings can show there.

(b) Make the workspace panel available off Cloud so "Manage plan" can open it. That means dropping isCloud from useSettingUI's teamWorkspacesEnabled and useSettingsDialog's isWorkspaceMode, i.e. exposing team-workspace billing UI on OSS/desktop builds. I'm happy to do it, but it's a product change well beyond FE-1485 and I'd want your explicit sign-off rather than sneaking it in under a labeling fix.

If you meant something narrower — e.g. a specific line, or that the workspace popover should always show('workspace') regardless of distribution — point me at it and I'll turn it around quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants