Repository navigation
fix: label account menu entry for the settings panel it opens - #14600
christian-byrne wants to merge 4 commits into
Conversation
The account popover entry read "Manage plan" on every distribution, but Settings only hosts a plan-management panel on Cloud. Elsewhere the entry opens the Credits panel, so it now reads "Credits" there.
🎭 Playwright: ✅ 1777 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.21 MB gzip 🔴 +31 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.29 MB (baseline 1.29 MB) • 🔴 +62 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 111 kB (baseline 111 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 16 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 28.7 kB (baseline 28.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 7 unchanged UI Components — 70 kB (baseline 70 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.45 MB (baseline 3.45 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • 🔴 +62 BBundles that do not match a named category
Status: 2 added / 2 removed / 279 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-03T09:49:01.321Z",
"gitSha": "7651855164ed54b671c40128c5f0154cddc9b2d2",
"branch": "glary/fe-1485-manage-plan-label",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2179.8330000000306,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.155999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.1059999999999,
"heapDeltaBytes": 5053096,
"heapUsedBytes": 72775792,
"domNodes": 20,
"jsHeapTotalBytes": 21098496,
"scriptDurationMs": 21.436999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2011.9280000000117,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.839999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.77699999999993,
"heapDeltaBytes": 4874012,
"heapUsedBytes": 72733668,
"domNodes": 18,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 19.94,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1968.8170000000014,
"styleRecalcs": 80,
"styleRecalcDurationMs": 49.98499999999999,
"layouts": 12,
"layoutDurationMs": 3.873,
"taskDurationMs": 987.716,
"heapDeltaBytes": -20791780,
"heapUsedBytes": 46869112,
"domNodes": -280,
"jsHeapTotalBytes": 20701184,
"scriptDurationMs": 135.70000000000002,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1939.6419999999353,
"styleRecalcs": 79,
"styleRecalcDurationMs": 46.21,
"layouts": 12,
"layoutDurationMs": 3.5699999999999994,
"taskDurationMs": 978.966,
"heapDeltaBytes": -20527996,
"heapUsedBytes": 47543712,
"domNodes": -279,
"jsHeapTotalBytes": 20701184,
"scriptDurationMs": 134.09799999999998,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.9750000000017,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.347,
"layouts": 6,
"layoutDurationMs": 0.5149999999999998,
"taskDurationMs": 374.19599999999997,
"heapDeltaBytes": 8002444,
"heapUsedBytes": 75809140,
"domNodes": 78,
"jsHeapTotalBytes": 19787776,
"scriptDurationMs": 18.647,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1753.9259999999786,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.868999999999996,
"layouts": 6,
"layoutDurationMs": 0.621,
"taskDurationMs": 401.99100000000004,
"heapDeltaBytes": 7956008,
"heapUsedBytes": 75804272,
"domNodes": 79,
"jsHeapTotalBytes": 20312064,
"scriptDurationMs": 23.531000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 550.7460000000037,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.517,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.153,
"heapDeltaBytes": -11938424,
"heapUsedBytes": 55881548,
"domNodes": 16,
"jsHeapTotalBytes": 21622784,
"scriptDurationMs": 59.43399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 591.7719999999917,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.055000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.68199999999996,
"heapDeltaBytes": -12399764,
"heapUsedBytes": 55423040,
"domNodes": 18,
"jsHeapTotalBytes": 22409216,
"scriptDurationMs": 59.97500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2028.6239999999793,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.949,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 684.6409999999998,
"heapDeltaBytes": 7957204,
"heapUsedBytes": 66710704,
"domNodes": -281,
"jsHeapTotalBytes": 5042176,
"scriptDurationMs": 107.64,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.798999999959,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.93,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 698.78,
"heapDeltaBytes": 7962424,
"heapUsedBytes": 66739520,
"domNodes": -281,
"jsHeapTotalBytes": 4517888,
"scriptDurationMs": 115.123,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2201.7759999999953,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.161000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1279.9019999999998,
"heapDeltaBytes": 6059756,
"heapUsedBytes": 65759860,
"domNodes": -283,
"jsHeapTotalBytes": 5529600,
"scriptDurationMs": 441.525,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2221.4170000000877,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.646000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1347.3290000000002,
"heapDeltaBytes": 5506880,
"heapUsedBytes": 65378476,
"domNodes": -285,
"jsHeapTotalBytes": 4743168,
"scriptDurationMs": 449.25100000000003,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3180.768999999998,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.535999999999998,
"layouts": 60,
"layoutDurationMs": 7.020000000000001,
"taskDurationMs": 1484.067,
"heapDeltaBytes": -3343548,
"heapUsedBytes": 59308420,
"domNodes": -288,
"jsHeapTotalBytes": 6615040,
"scriptDurationMs": 521.8660000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3328.512000000046,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.54,
"layouts": 60,
"layoutDurationMs": 7.882999999999999,
"taskDurationMs": 1634.5400000000002,
"heapDeltaBytes": 5884164,
"heapUsedBytes": 67610216,
"domNodes": -288,
"jsHeapTotalBytes": 7663616,
"scriptDurationMs": 573.7900000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2009.0609999999742,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.234000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 664.8739999999999,
"heapDeltaBytes": 7642428,
"heapUsedBytes": 68590232,
"domNodes": -283,
"jsHeapTotalBytes": 4780032,
"scriptDurationMs": 102.69300000000001,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2028.8340000000744,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.058,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 731.4590000000001,
"heapDeltaBytes": 7676396,
"heapUsedBytes": 68684976,
"domNodes": -284,
"jsHeapTotalBytes": 5042176,
"scriptDurationMs": 125.21500000000002,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 571.4639999999918,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.715,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.517,
"heapDeltaBytes": -11849328,
"heapUsedBytes": 56176300,
"domNodes": 20,
"jsHeapTotalBytes": 22147072,
"scriptDurationMs": 116.874,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.8710000000356,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.867999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.0759999999999,
"heapDeltaBytes": -10856632,
"heapUsedBytes": 57156864,
"domNodes": 20,
"jsHeapTotalBytes": 21360640,
"scriptDurationMs": 118.72600000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2051.160999999979,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.913999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.13899999999995,
"heapDeltaBytes": -22157004,
"heapUsedBytes": 45826740,
"domNodes": -281,
"jsHeapTotalBytes": 20176896,
"scriptDurationMs": 13.491000000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2029.5210000000452,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.304999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.155,
"heapDeltaBytes": 4637484,
"heapUsedBytes": 72681180,
"domNodes": 22,
"jsHeapTotalBytes": 21360640,
"scriptDurationMs": 16.242,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.5479999999698,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.376,
"layouts": 16,
"layoutDurationMs": 4.840000000000001,
"taskDurationMs": 854.7090000000001,
"heapDeltaBytes": -20444208,
"heapUsedBytes": 47474048,
"domNodes": -278,
"jsHeapTotalBytes": 20176896,
"scriptDurationMs": 96.89699999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.5930000000171,
"styleRecalcs": 78,
"styleRecalcDurationMs": 40.62200000000001,
"layouts": 16,
"layoutDurationMs": 4.5760000000000005,
"taskDurationMs": 855.234,
"heapDeltaBytes": -21138884,
"heapUsedBytes": 46849228,
"domNodes": -278,
"jsHeapTotalBytes": 20701184,
"scriptDurationMs": 97.63900000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.2040000000443,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.267000000000003,
"layouts": 13,
"layoutDurationMs": 12.379000000000001,
"taskDurationMs": 962.6100000000002,
"heapDeltaBytes": 30923160,
"heapUsedBytes": 99401100,
"domNodes": 13673,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 37.57799999999999,
"eventListeners": 2371,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8284.156999999994,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.516999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4389.983,
"heapDeltaBytes": 13246900,
"heapUsedBytes": 72123144,
"domNodes": -281,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 1381.5059999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8385.869999999955,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.458,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4691.509,
"heapDeltaBytes": 13734268,
"heapUsedBytes": 72446332,
"domNodes": -283,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 1427.5420000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17717.982000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17666.333000000002,
"heapDeltaBytes": -58782800,
"heapUsedBytes": 167444248,
"domNodes": -8313,
"jsHeapTotalBytes": -9379840,
"scriptDurationMs": 604.4350000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17406.459999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17376.625,
"heapDeltaBytes": -50437928,
"heapUsedBytes": 171161380,
"domNodes": -8312,
"jsHeapTotalBytes": -9379840,
"scriptDurationMs": 602.4459999999999,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20841.82699999997,
"styleRecalcs": 142,
"styleRecalcDurationMs": 16.654000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20803.663,
"heapDeltaBytes": -33051644,
"heapUsedBytes": 179560296,
"domNodes": -8312,
"jsHeapTotalBytes": -13119488,
"scriptDurationMs": 887.794,
"eventListeners": -16383,
"totalBlockingTimeMs": 132,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21369.669000000045,
"styleRecalcs": 148,
"styleRecalcDurationMs": 18.971000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21321.579,
"heapDeltaBytes": -42792720,
"heapUsedBytes": 166770316,
"domNodes": -8324,
"jsHeapTotalBytes": -10166272,
"scriptDurationMs": 929.353,
"eventListeners": -16385,
"totalBlockingTimeMs": 268,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 465.1690000000599,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.956999999999999,
"layouts": 3,
"layoutDurationMs": 0.6619999999999998,
"taskDurationMs": 112.534,
"heapDeltaBytes": -15925188,
"heapUsedBytes": 51132548,
"domNodes": 124,
"jsHeapTotalBytes": 7991296,
"scriptDurationMs": 10.331,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 477.31999999996333,
"styleRecalcs": 14,
"styleRecalcDurationMs": 23.558000000000003,
"layouts": 4,
"layoutDurationMs": 1.463,
"taskDurationMs": 124.952,
"heapDeltaBytes": -15972632,
"heapUsedBytes": 50964180,
"domNodes": 119,
"jsHeapTotalBytes": 7204864,
"scriptDurationMs": 11.763000000000002,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
📝 WalkthroughWalkthroughThe legacy and workspace user popovers now show “Manage plan” for cloud deployments and “Credits” otherwise. Tests verify the corresponding settings panels, targets, and popover close behavior. ChangesPopover billing actions
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/topbar/CurrentUserPopoverLegacy.test.ts`:
- Around line 512-521: Update the three specified test branches to capture the
popover close handler and assert one close event after the menu click:
src/components/topbar/CurrentUserPopoverLegacy.test.ts lines 512-521 for the
credits branch,
src/platform/workspace/components/CurrentUserPopoverWorkspace.test.ts lines
266-278 for off-cloud credits, and lines 280-292 for cloud plan management.
Preserve the existing label and settings-target assertions while adding the
close-event verification to each branch.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 2d27fc28-23dd-4429-a202-b477125e5087
📒 Files selected for processing (4)
src/components/topbar/CurrentUserPopoverLegacy.test.tssrc/components/topbar/CurrentUserPopoverLegacy.vuesrc/platform/workspace/components/CurrentUserPopoverWorkspace.test.tssrc/platform/workspace/components/CurrentUserPopoverWorkspace.vue
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14600 +/- ##
=======================================
Coverage 79.10% 79.10%
=======================================
Files 1769 1769
Lines 118915 118919 +4
Branches 37501 37487 -14
=======================================
+ Hits 94062 94076 +14
+ Misses 24228 24213 -15
- Partials 625 630 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
|
This is not valid. workspace should be shown, not Credits. |
|
Thanks — before I change anything I want to check we're looking at the same surface, because I think we may not be. On Cloud this PR changes nothing. The entry still reads "Manage plan" and still opens the workspace panel:
Only the non-Cloud branch changed, and the bug reported in FE-1485 is non-Cloud. Two independent tells in the reporter's screenshots:
Off Cloud there is currently no workspace panel to show. I verified this against
So which do you want? (a) Keep this PR as-is — a labeling fix. Off Cloud the entry reads "Credits" because the Credits panel is the only thing Settings can show there. (b) Make the workspace panel available off Cloud so "Manage plan" can open it. That means dropping If you meant something narrower — e.g. a specific line, or that the workspace popover should always |
PR Created by the Glary-Bot Agent
Summary
The account popover entry read "Manage plan" on every distribution, but Settings only hosts a plan-management panel on Cloud. On local/desktop builds the entry opens Settings → Credits (balance + usage), which is what the user reported.
Changes
CurrentUserPopoverLegacy.vueandCurrentUserPopoverWorkspace.vue:subscription/workspace) — unchanged.creditspanel, matching that panel's own title in the Settings sidebar.subscriptionPanelinsrc/platform/settings/composables/useSettingUI.tsisnullunlessisCloud && __CONFIG__.subscription_required, and legacy billing has no plans at all (useLegacyBillingreturnsplans: [],currentPlanSlug: null). The entry still appears off Cloud becauseisActiveSubscriptionis hardcodedtruethere (isSubscribedOrIsNotCloud), which is what surfaced the mislabeled item.credits.credits.data-testid="manage-plan-menu-item"is kept, so existing e2e specs (localCreditsNoSubscribeUi,pricingTableDeepLink) are unaffected.Review Focus
main.Verification
pnpm typecheck,pnpm lint(0 errors),pnpm format:check,pnpm knip— clean.pnpm vitest runon both popover suites — 39 passing.Screenshots
Screenshots