Repository navigation
fix: align profile billing action with distribution - #14602
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019fc7f1-79b9-7783-984d-b29a7fe4cd32 Co-authored-by: Amp <amp@ampcode.com>
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎭 Playwright: ✅ 1777 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.21 MB gzip 🔴 +49 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.29 MB (baseline 1.29 MB) • 🔴 +105 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 111 kB (baseline 111 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 16 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 28.7 kB (baseline 28.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 7 unchanged UI Components — 70 kB (baseline 70 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.45 MB (baseline 3.45 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • 🔴 +1 BBundles that do not match a named category
Status: 2 added / 2 removed / 279 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-03T19:43:45.975Z",
"gitSha": "9b7ace7a6040a422f9b6bb9bd93b2645cd54ba36",
"branch": "dante01yoon/fe-1485-hide-v0-credits-tab",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2074.3989999999994,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.812999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.842,
"heapDeltaBytes": 4895484,
"heapUsedBytes": 72839684,
"domNodes": 20,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 18.279,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2012.8780000000006,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.387000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.976,
"heapDeltaBytes": 5137744,
"heapUsedBytes": 72836456,
"domNodes": 18,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 14.661999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1974.1850000000056,
"styleRecalcs": 75,
"styleRecalcDurationMs": 40.812,
"layouts": 12,
"layoutDurationMs": 3.616,
"taskDurationMs": 990.2460000000001,
"heapDeltaBytes": -14373172,
"heapUsedBytes": 53528436,
"domNodes": -277,
"jsHeapTotalBytes": 20963328,
"scriptDurationMs": 130.392,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.4789999999634,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.717,
"layouts": 12,
"layoutDurationMs": 3.543,
"taskDurationMs": 873.312,
"heapDeltaBytes": -20659932,
"heapUsedBytes": 47311356,
"domNodes": -280,
"jsHeapTotalBytes": 20963328,
"scriptDurationMs": 122.64300000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.5889999999513,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.292,
"layouts": 6,
"layoutDurationMs": 0.516,
"taskDurationMs": 355.572,
"heapDeltaBytes": 7991676,
"heapUsedBytes": 75859204,
"domNodes": 76,
"jsHeapTotalBytes": 19787776,
"scriptDurationMs": 16.956,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.4399999999978,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.302999999999997,
"layouts": 6,
"layoutDurationMs": 0.626,
"taskDurationMs": 365.73,
"heapDeltaBytes": 7811372,
"heapUsedBytes": 75846152,
"domNodes": 78,
"jsHeapTotalBytes": 20049920,
"scriptDurationMs": 18.258999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 578.2460000000071,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.063999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.937,
"heapDeltaBytes": -12158424,
"heapUsedBytes": 55710576,
"domNodes": 18,
"jsHeapTotalBytes": 21622784,
"scriptDurationMs": 59.939,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 592.835999999977,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.114,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.415,
"heapDeltaBytes": -12050000,
"heapUsedBytes": 55792364,
"domNodes": 18,
"jsHeapTotalBytes": 21622784,
"scriptDurationMs": 61.23,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2011.197999999979,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.984000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 664.888,
"heapDeltaBytes": 7654856,
"heapUsedBytes": 66409324,
"domNodes": -283,
"jsHeapTotalBytes": 4517888,
"scriptDurationMs": 102.88799999999999,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2049.0449999999782,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.079999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 668.531,
"heapDeltaBytes": 8628708,
"heapUsedBytes": 67453248,
"domNodes": -283,
"jsHeapTotalBytes": 5304320,
"scriptDurationMs": 102.725,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2187.657999999999,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.925000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1271.806,
"heapDeltaBytes": 5629836,
"heapUsedBytes": 65246348,
"domNodes": -283,
"jsHeapTotalBytes": 5005312,
"scriptDurationMs": 419.059,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2182.223000000022,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.874999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1265.841,
"heapDeltaBytes": 6197856,
"heapUsedBytes": 65890776,
"domNodes": -283,
"jsHeapTotalBytes": 4743168,
"scriptDurationMs": 434.052,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3094.730000000027,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.339,
"layouts": 60,
"layoutDurationMs": 7.043999999999999,
"taskDurationMs": 1482.817,
"heapDeltaBytes": -6708684,
"heapUsedBytes": 54476708,
"domNodes": -284,
"jsHeapTotalBytes": 6615040,
"scriptDurationMs": 511.04799999999994,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3117.07100000001,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.701999999999998,
"layouts": 60,
"layoutDurationMs": 7.159000000000001,
"taskDurationMs": 1428.833,
"heapDeltaBytes": 23000828,
"heapUsedBytes": 85446248,
"domNodes": 10,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 511.316,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.0320000000156,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.043000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 689.619,
"heapDeltaBytes": 8024596,
"heapUsedBytes": 68706044,
"domNodes": -283,
"jsHeapTotalBytes": 4255744,
"scriptDurationMs": 108.06900000000002,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.3160000000235,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.220000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 661.1339999999999,
"heapDeltaBytes": 8689860,
"heapUsedBytes": 69344048,
"domNodes": -283,
"jsHeapTotalBytes": 3207168,
"scriptDurationMs": 102.94300000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 550.233999999989,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.806,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.25,
"heapDeltaBytes": -11858124,
"heapUsedBytes": 56162824,
"domNodes": 20,
"jsHeapTotalBytes": 22147072,
"scriptDurationMs": 114.64099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 585.3640000000269,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.808999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.237,
"heapDeltaBytes": -12066504,
"heapUsedBytes": 56057144,
"domNodes": 20,
"jsHeapTotalBytes": 22147072,
"scriptDurationMs": 117.412,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2011.0430000000008,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.511999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.23400000000004,
"heapDeltaBytes": 4590744,
"heapUsedBytes": 72563220,
"domNodes": 20,
"jsHeapTotalBytes": 20312064,
"scriptDurationMs": 13.252,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1993.520999999987,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.767999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.62899999999996,
"heapDeltaBytes": 5010684,
"heapUsedBytes": 72990328,
"domNodes": 22,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 13.279000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1714.7889999999961,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.818000000000005,
"layouts": 16,
"layoutDurationMs": 4.292,
"taskDurationMs": 782.6560000000001,
"heapDeltaBytes": -20738260,
"heapUsedBytes": 47522628,
"domNodes": -278,
"jsHeapTotalBytes": 20701184,
"scriptDurationMs": 89.37599999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.93799999995,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.772999999999996,
"layouts": 16,
"layoutDurationMs": 3.814,
"taskDurationMs": 751.31,
"heapDeltaBytes": -4835524,
"heapUsedBytes": 63135876,
"domNodes": 64,
"jsHeapTotalBytes": 21360640,
"scriptDurationMs": 90.764,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.8330000000383,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.240999999999996,
"layouts": 13,
"layoutDurationMs": 12.149000000000001,
"taskDurationMs": 920.1119999999999,
"heapDeltaBytes": 30942888,
"heapUsedBytes": 97974476,
"domNodes": 13673,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 32.432,
"eventListeners": 2371,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8205.824000000008,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.641000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4343.9800000000005,
"heapDeltaBytes": 12329520,
"heapUsedBytes": 71095364,
"domNodes": -283,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 1352.7160000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8288.669000000027,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.745,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4471.888000000001,
"heapDeltaBytes": 13972632,
"heapUsedBytes": 72964848,
"domNodes": -280,
"jsHeapTotalBytes": 7626752,
"scriptDurationMs": 1458.2949999999998,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16632.515000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16601.696,
"heapDeltaBytes": -44225552,
"heapUsedBytes": 166990168,
"domNodes": -8312,
"jsHeapTotalBytes": -7806976,
"scriptDurationMs": 545.0070000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17081.17200000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17045.606999999996,
"heapDeltaBytes": -53474016,
"heapUsedBytes": 167781244,
"domNodes": -8312,
"jsHeapTotalBytes": -14884864,
"scriptDurationMs": 565.733,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20069.23800000004,
"styleRecalcs": 135,
"styleRecalcDurationMs": 15.01600000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20027.962,
"heapDeltaBytes": -22860680,
"heapUsedBytes": 178482928,
"domNodes": -8312,
"jsHeapTotalBytes": -18362368,
"scriptDurationMs": 873.148,
"eventListeners": -16383,
"totalBlockingTimeMs": 112,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20663.99899999999,
"styleRecalcs": 142,
"styleRecalcDurationMs": 16.07900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20601.785,
"heapDeltaBytes": -35702708,
"heapUsedBytes": 172512080,
"domNodes": -8312,
"jsHeapTotalBytes": -7090176,
"scriptDurationMs": 863.098,
"eventListeners": -16387,
"totalBlockingTimeMs": 151,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 457.11399999999,
"styleRecalcs": 11,
"styleRecalcDurationMs": 17.894000000000002,
"layouts": 3,
"layoutDurationMs": 0.5810000000000001,
"taskDurationMs": 112.839,
"heapDeltaBytes": -15879532,
"heapUsedBytes": 50974524,
"domNodes": 128,
"jsHeapTotalBytes": 7467008,
"scriptDurationMs": 9.589000000000002,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 467.8309999999328,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.957,
"layouts": 3,
"layoutDurationMs": 0.6939999999999998,
"taskDurationMs": 107.60799999999999,
"heapDeltaBytes": -16168380,
"heapUsedBytes": 50957520,
"domNodes": 117,
"jsHeapTotalBytes": 7467008,
"scriptDurationMs": 9.056000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
📝 WalkthroughWalkthroughThe popover plan-related entries now use environment-specific labels and icons. Tests verify subscription, credits, and workspace settings navigation, along with popover closure. ChangesPopover plan and credits navigation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14602 +/- ##
==========================================
- Coverage 79.10% 79.09% -0.01%
==========================================
Files 1769 1769
Lines 118915 119185 +270
Branches 38244 37624 -620
==========================================
+ Hits 94062 94264 +202
- Misses 24223 24290 +67
- Partials 630 631 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Amp-Thread-ID: https://ampcode.com/threads/T-019fc7f1-79b9-7783-984d-b29a7fe4cd32 Co-authored-by: Amp <amp@ampcode.com>
|
Visual proof (PR head Setup: route-mocked real-app V0 personal workspace ( 901b34f5e7a4-evidence.mp4 |
huang47
left a comment
There was a problem hiding this comment.
LGTM. Visual proof: #14602 (comment)
Amp-Thread-ID: https://ampcode.com/threads/T-019fc7f1-79b9-7783-984d-b29a7fe4cd32 Co-authored-by: Amp <amp@ampcode.com>
1d4d14c
|
@dante01yoon Successfully backported to #14806 |
|
@dante01yoon Successfully backported to #14807 |
Summary
Align the profile billing action with the surface available in each distribution:
lucide--coins, opening Settings → Credits.lucide--credit-card, opening the workspace Plan & Credits surface.FE-1485 · final requirement clarification
Root cause
The legacy profile popover hardcoded Manage plan and a file-text icon across distributions, even though local/desktop has no workspace plan-management surface and the action opens its standalone Credits panel. The workspace popover already enforced subscription-management permissions correctly, but its generic file-text icon did not distinguish plan management from the separate Plans & pricing action.
The earlier version of this PR treated the standalone Credits settings tab as the regression and removed it from V0. The clarified requirement confirms that tab is required on local/desktop, so that change is fully reverted.
Changes
creditssubscriptioncanManageSubscriptiongating in the workspace popover.Why previous tests missed it
Existing tests only checked that the menu item existed. They did not assert its distribution-specific label, destination, or icon semantics. Workspace tests covered billing visibility in several roles but did not exercise plan-management navigation for both personal and team owners. The new tests assert the action text and destination in each distribution and cover owner/member permission behavior across workspace types.
Review focus
Verification
pnpm test:unit src/components/topbar/CurrentUserPopoverLegacy.test.ts src/platform/workspace/components/CurrentUserPopoverWorkspace.test.ts— 39 passedpnpm typecheckpnpm typecheck:browserpnpm knip --cacheScreenshots
AS IS — local/desktop
The original real-app report shows Manage plan opening the local Credits surface. See the source screenshots in the report.
TO BE — local/desktop
The profile action reads Credits and opens Settings with the standalone Credits panel selected.
TO BE — Cloud
Cloud retains Manage plan and uses the credit-card icon, distinct from the receipt icon used by Plans & pricing.
Captured from the current PR head in the route-mocked real Cloud app. Approved Cloud reference.