Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1811 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-14T00:30:25.980Z",
"gitSha": "b12446b8158ed1568bbb2b12a0ccf4154b715a0c",
"branch": "jaeone94/errors-tab-rename-issues",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2033.9639999999974,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.302,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.97399999999993,
"heapDeltaBytes": 6059148,
"heapUsedBytes": 71044780,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 18.014000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2022.8139999999826,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.472000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.47499999999997,
"heapDeltaBytes": 5831172,
"heapUsedBytes": 70588540,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 16.272000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2046.83,
"styleRecalcs": 79,
"styleRecalcDurationMs": 49.36,
"layouts": 12,
"layoutDurationMs": 3.8329999999999997,
"taskDurationMs": 969.6770000000001,
"heapDeltaBytes": -14970016,
"heapUsedBytes": 49875592,
"domNodes": -283,
"jsHeapTotalBytes": 23564288,
"scriptDurationMs": 133.46000000000004,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1839.4850000000247,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.971,
"layouts": 12,
"layoutDurationMs": 3.5719999999999996,
"taskDurationMs": 873.2139999999999,
"heapDeltaBytes": -17013316,
"heapUsedBytes": 47967172,
"domNodes": -283,
"jsHeapTotalBytes": 23040000,
"scriptDurationMs": 125.26499999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1731.0190000000034,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.479,
"layouts": 6,
"layoutDurationMs": 0.6739999999999999,
"taskDurationMs": 367.56600000000003,
"heapDeltaBytes": 8761764,
"heapUsedBytes": 73687184,
"domNodes": 77,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 17.817,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.1070000000464,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.579,
"layouts": 6,
"layoutDurationMs": 0.6480000000000001,
"taskDurationMs": 416.879,
"heapDeltaBytes": 8829492,
"heapUsedBytes": 73696184,
"domNodes": 77,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 21.687,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 567.149000000029,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.783999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.055,
"heapDeltaBytes": -11245420,
"heapUsedBytes": 53619116,
"domNodes": 14,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 57.513000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 623.4889999999496,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.602,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.66200000000003,
"heapDeltaBytes": -11518352,
"heapUsedBytes": 53506704,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 65.967,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2030.7429999999727,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.619000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 659.233,
"heapDeltaBytes": 6916732,
"heapUsedBytes": 67717976,
"domNodes": -283,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 100.51700000000001,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.7329999999793,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.208,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 681.0529999999999,
"heapDeltaBytes": 871648,
"heapUsedBytes": 60730020,
"domNodes": -282,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 103.873,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2197.926000000052,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.297999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1260.8570000000002,
"heapDeltaBytes": 4576860,
"heapUsedBytes": 65636172,
"domNodes": -283,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 421.257,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2256.8449999999984,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.064,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1317.834,
"heapDeltaBytes": 3995756,
"heapUsedBytes": 65898916,
"domNodes": -288,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 433.605,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3231.8610000000376,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.083000000000002,
"layouts": 60,
"layoutDurationMs": 7.186000000000001,
"taskDurationMs": 1527.666,
"heapDeltaBytes": -1638436,
"heapUsedBytes": 61288192,
"domNodes": -288,
"jsHeapTotalBytes": 7176192,
"scriptDurationMs": 528.9390000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3231.742000000054,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.700999999999995,
"layouts": 60,
"layoutDurationMs": 7.393000000000001,
"taskDurationMs": 1568.358,
"heapDeltaBytes": 507124,
"heapUsedBytes": 63052804,
"domNodes": -287,
"jsHeapTotalBytes": 6389760,
"scriptDurationMs": 550.069,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.0039999999817,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.4350000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 678.687,
"heapDeltaBytes": 6933364,
"heapUsedBytes": 67973420,
"domNodes": -285,
"jsHeapTotalBytes": 4030464,
"scriptDurationMs": 103.66900000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.4389999999867,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.699000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 687.241,
"heapDeltaBytes": 6662596,
"heapUsedBytes": 67322320,
"domNodes": -282,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 108.646,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.3450000000321,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.593000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.19300000000004,
"heapDeltaBytes": -10540748,
"heapUsedBytes": 54376552,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 117.066,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.1449999999786,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.355999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.869,
"heapDeltaBytes": -10344932,
"heapUsedBytes": 54483576,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 121.08999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.3670000000016,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.201000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.246,
"heapDeltaBytes": 5839392,
"heapUsedBytes": 70861212,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 12.325000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2020.9619999999404,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.037,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.009,
"heapDeltaBytes": 5918360,
"heapUsedBytes": 70746388,
"domNodes": 18,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 14.858,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.8450000000103,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.01500000000001,
"layouts": 16,
"layoutDurationMs": 3.8409999999999997,
"taskDurationMs": 752.8889999999999,
"heapDeltaBytes": -3506384,
"heapUsedBytes": 61401828,
"domNodes": 65,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 89.253,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.9630000000107,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.807,
"layouts": 16,
"layoutDurationMs": 4.2700000000000005,
"taskDurationMs": 757.2270000000001,
"heapDeltaBytes": -3464852,
"heapUsedBytes": 61480820,
"domNodes": 63,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 91.362,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1403.2980000000066,
"styleRecalcs": 19,
"styleRecalcDurationMs": 29.876,
"layouts": 15,
"layoutDurationMs": 12.427999999999997,
"taskDurationMs": 991.157,
"heapDeltaBytes": 1539320,
"heapUsedBytes": 89862516,
"domNodes": 13673,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 33.307,
"eventListeners": 2375,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8407.621000000006,
"styleRecalcs": 251,
"styleRecalcDurationMs": 36.979,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4539.178000000001,
"heapDeltaBytes": -17713588,
"heapUsedBytes": 64565068,
"domNodes": -282,
"jsHeapTotalBytes": 8785920,
"scriptDurationMs": 1389.3770000000002,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8313.606999999934,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.123000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4466.433999999999,
"heapDeltaBytes": 12100716,
"heapUsedBytes": 71448224,
"domNodes": -282,
"jsHeapTotalBytes": 5795840,
"scriptDurationMs": 1380.973,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16791.449,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16762.154000000002,
"heapDeltaBytes": -62346336,
"heapUsedBytes": 167449900,
"domNodes": -8312,
"jsHeapTotalBytes": -7282688,
"scriptDurationMs": 578.506,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16736.041999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16721.22,
"heapDeltaBytes": -51103308,
"heapUsedBytes": 167198048,
"domNodes": -8315,
"jsHeapTotalBytes": -13307904,
"scriptDurationMs": 541.396,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20129.770000000008,
"styleRecalcs": 136,
"styleRecalcDurationMs": 15.959000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20089.41,
"heapDeltaBytes": -48351892,
"heapUsedBytes": 158167672,
"domNodes": -8312,
"jsHeapTotalBytes": -8851456,
"scriptDurationMs": 854.169,
"eventListeners": -16385,
"totalBlockingTimeMs": 156,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20164.627999999993,
"styleRecalcs": 135,
"styleRecalcDurationMs": 15.595000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20142.486,
"heapDeltaBytes": -20989116,
"heapUsedBytes": 177159324,
"domNodes": -8312,
"jsHeapTotalBytes": -9449472,
"scriptDurationMs": 888.046,
"eventListeners": -16385,
"totalBlockingTimeMs": 111,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 450.6509999999935,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.698999999999998,
"layouts": 2,
"layoutDurationMs": 0.40700000000000003,
"taskDurationMs": 103.103,
"heapDeltaBytes": 5061860,
"heapUsedBytes": 68781064,
"domNodes": 126,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.366999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 470.98300000004656,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.237000000000002,
"layouts": 3,
"layoutDurationMs": 0.631,
"taskDurationMs": 111.44999999999999,
"heapDeltaBytes": 5048460,
"heapUsedBytes": 68948228,
"domNodes": 125,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.734000000000002,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## jaeone94/errors-panel-missing-absorption #14253 +/- ##
=========================================================================
Coverage 82.15% 82.15%
=========================================================================
Files 1887 1887
Lines 120874 120874
Branches 36607 36607
=========================================================================
+ Hits 99309 99310 +1
+ Misses 21076 21075 -1
Partials 489 489
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
c40167f to
ff40aa0
Compare
4d20900 to
706bd80
Compare
c0af610 to
7f5b6f4
Compare
…entation Adapt the absorption unit tests and the missing-model E2E spec to the unified hero (single summary row, 'Setup required' wording, filter chips instead of per-severity rows). Restyle the blocked-last-run indicator to the spec pill — warning background at ten percent with warning text — and move it out of the header actions onto a title-badge slot so it sits left-aligned beside the section title.
Resolving a missing model or media file — refresh after installing, deleting or bypassing the node — removed the absorbing candidate but left the absorbed validation error behind, so fixing the problem escalated the panel from setup-amber to a blocking red error pointing at a resource that is no longer missing. A store watcher now retires errors whose absorption justification leaves the candidate stores, matching by content so rescans that rebuild equivalent candidates retire nothing; this mirrors the existing missing-node prompt-error retirement. Tighten the absorption matcher: pending candidates no longer absorb (the pipelines only surface confirmed ones), and received-value equality only matches errors that name no input, so a same-valued sibling widget's genuine failure stays red. Collapse the twin model/media matchers into one, name the MissingResourceAbsorption union, and drop the selection-scoped blockedLastRun threading that carried a graph-wide flag into selection groups nothing reads. Remove the store's absorption-unaware totalErrorCount, whose last consumer derives its own count, and pin the new behavior with negative node-identity, pending-candidate, sibling-widget, and retirement tests.
classifyValidationErrorAbsorption says the same thing in half the words; document blockedLastRun as a per-render derivation.
The tab now lists blocking errors and missing-resource setup items side by side, so 'Errors' names only half of what it shows. Rename the tab and its empty state, and update the copy that pointed at the old name - including the st() fallback strings in source, which would otherwise drift from the locale values. The selection-emphasis counts change from 'error' to 'issue' for a reason beyond naming: selectionErrorCount reduces over selectionScopedGroups, which includes the missing-severity groups, so selecting a node whose only problem was a missing model rendered 'MyNode - 1 error'. Strings that genuinely name the error severity - errorsDetected, errorsSummary and friends - keep saying 'error'. The Comfy.RightSidePanel.ShowErrorsTab setting id is unchanged so existing user settings are preserved.
b535366 to
83552f0
Compare
7f5b6f4 to
3a272b5
Compare
83552f0 to
32c9758
Compare
|
Folded into #14439 (commit 2261487 there). Review on that PR surfaced that the selection-emphasis strings mislabel missing-only nodes as errors — which is exactly the defect this rename existed to fix — so the rename now ships with the severity presentation instead of trailing it. No content changes beyond the rebase; the branch is preserved as-is. |
…ors (Comfy-Org#14439) Missing resources (node packs, models, media) currently render as blocking errors, identical in weight to a runtime failure. They are not the same thing: a missing model is resolved by installing it, a failed sampler is not. This PR introduces the severity distinction and its presentation, following the updated Figma spec (`Errors-ComfyUI`, node `3052-8805`). It does not change which error cards are produced. - `ErrorGroupSeverity` on `ErrorGroupBase`, assigned at each group builder - One unified summary hero: coral count + "Errors detected" (errors only), gold count + "Setup required" (missing only), neutral total + "Issues detected" (mixed) - In the mixed case, outline-only per-severity filter chips under the hero. A pressed chip shows only that severity; it releases automatically — never auto-selects — when the hidden severity gains new entries, when the filtered severity empties, or when the canvas selection changes to include the hidden severity - Gold palette for missing-resource section badges, and a gold `triangle-alert` tab icon (with an accessible label) when nothing is blocking - Execution error groups sort above missing-resource groups - While the Issues tab is only retained by a pending error scan (no issues present), it renders no severity icon - Context strip wording follows severity ("items" for setup-only workflows) - The Errors tab is renamed to Issues (folds Comfy-Org#14253 in: the tab now lists two severities side by side, and the selection-emphasis strings previously mislabeled missing-only nodes as errors) - Light theme uses the DES-588 AA amber: gold-800 `#8c6a38` behind a `warning-foreground` semantic for chip/hero/icon text, and `warning-on-background` (charcoal-800) for badge text on gold; dark theme renders unchanged `main` already renders both the missing-resource card and the duplicate validation card under one red hero, so this PR classifies an existing duplicate rather than creating one. The duplicate itself is removed in the follow-up. Follow-up: Comfy-Org#14440 absorbs the duplicate validation errors into the missing-resource cards, adds the "Blocked last run" marker, and restyles it to the new spec. Notes for reviewers: - `TabErrors.test.ts` retains the test name `uses error severity for an unabsorbed node validation error`. Absorption does not exist yet in this PR — the name is kept so the follow-up does not have to churn it back. - Light-theme amber text follows the DES-588 value; the dark-theme badge keeps the Figma-specified white-on-gold (2.16:1 — flagged to design). - Part of the errors-tab severity work split out of Comfy-Org#14252 ## Screenshots <img width="618" height="497" alt="스크린샷 2026-08-12 오전 9 59 51" src="https://github.com/user-attachments/assets/57385397-b217-471c-8454-904f98f2267d" /> <img width="620" height="310" alt="스크린샷 2026-08-12 오전 9 59 59" src="https://github.com/user-attachments/assets/97056832-bc46-47df-ac73-fdd9b44588bf" /> <img width="618" height="346" alt="스크린샷 2026-08-12 오전 10 00 07" src="https://github.com/user-attachments/assets/f2c21e85-b7f8-400d-a172-f2ac14d446cc" />
Summary
The tab now lists blocking errors and missing-resource setup items side by side, so "Errors" names only half of what it shows. Renames it to "Issues" and updates the copy that pointed at the old name.
Changes
Errors→Issues, and its empty stateNo errors→No issues.selectionErrorCount, which reduces overselectionScopedGroupsand therefore includes the missing-severity groups, so selecting a node whose only problem was a missing model renderedMyNode — 1 error. Reproduced by reverting the string before fixing it.st()fallback literals in source, which would otherwise drift from the locale values.Comfy.RightSidePanel.ShowErrorsTabsetting tooltip was reworded rather than noun-swapped — it described "workflow execution errors", which is no longer what the tab shows.Review Focus
What deliberately keeps saying "error". Strings that name the error severity specifically:
errorsDetected(the red hero row),errorsSummary/errorNodeSummary/errorNodesSummary(used only in the error-only state),severityErrorLabel,resolveBeforeRun, anderrorHelpGithub("submit a GitHub issue" — different sense of the word).Setting id unchanged.
Comfy.RightSidePanel.ShowErrorsTabkeeps its id so existing user settings are preserved; only the label and tooltip change.Keys, not values. Only English values changed — i18n key names are untouched, so the other locales re-sync normally rather than falling back to English.