Repository navigation
Conversation
🎭 Playwright: ✅ 1767 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-31T00:44:03.614Z",
"gitSha": "73ff65f94da0fecdbdeaf13bd756ed50de09eaec",
"branch": "codex/instrument-allowlist-actions",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2109.1370000000043,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.843000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 628.054,
"heapDeltaBytes": -21744048,
"heapUsedBytes": 46068244,
"domNodes": 16,
"jsHeapTotalBytes": 19652608,
"scriptDurationMs": 18.944,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2055.0029999999992,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.391,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.413,
"heapDeltaBytes": 4540948,
"heapUsedBytes": 72381432,
"domNodes": 20,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 16.215,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1857.5950000000034,
"styleRecalcs": 74,
"styleRecalcDurationMs": 36.348000000000006,
"layouts": 12,
"layoutDurationMs": 3.571,
"taskDurationMs": 877.564,
"heapDeltaBytes": -15668436,
"heapUsedBytes": 52479720,
"domNodes": -280,
"jsHeapTotalBytes": 20439040,
"scriptDurationMs": 116.747,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1867.4760000000106,
"styleRecalcs": 74,
"styleRecalcDurationMs": 37.714,
"layouts": 12,
"layoutDurationMs": 3.4569999999999994,
"taskDurationMs": 875.876,
"heapDeltaBytes": -14227560,
"heapUsedBytes": 53712252,
"domNodes": -280,
"jsHeapTotalBytes": 22274048,
"scriptDurationMs": 114.98800000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1688.9919999999847,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.349999999999998,
"layouts": 6,
"layoutDurationMs": 0.6759999999999999,
"taskDurationMs": 382.59099999999995,
"heapDeltaBytes": 7894016,
"heapUsedBytes": 75816392,
"domNodes": 78,
"jsHeapTotalBytes": 20049920,
"scriptDurationMs": 18.585,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.7729999999237,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.987000000000002,
"layouts": 6,
"layoutDurationMs": 0.745,
"taskDurationMs": 371.811,
"heapDeltaBytes": 7887032,
"heapUsedBytes": 76070620,
"domNodes": 76,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 18.622,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 590.8919999999966,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.027,
"heapDeltaBytes": -12444580,
"heapUsedBytes": 55482188,
"domNodes": 20,
"jsHeapTotalBytes": 22147072,
"scriptDurationMs": 56.98199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 591.6760000000068,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.717999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.028,
"heapDeltaBytes": -12289856,
"heapUsedBytes": 55850460,
"domNodes": 16,
"jsHeapTotalBytes": 21360640,
"scriptDurationMs": 55.171,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2042.4820000000068,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.105,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 664.8639999999999,
"heapDeltaBytes": 8530272,
"heapUsedBytes": 67395156,
"domNodes": -280,
"jsHeapTotalBytes": 3731456,
"scriptDurationMs": 93.287,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2022.3829999999907,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.607,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 672.2030000000001,
"heapDeltaBytes": 8345336,
"heapUsedBytes": 67013776,
"domNodes": -281,
"jsHeapTotalBytes": 4517888,
"scriptDurationMs": 93.30699999999999,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2166.095999999982,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.443000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1244.5040000000001,
"heapDeltaBytes": 6387568,
"heapUsedBytes": 66254984,
"domNodes": -282,
"jsHeapTotalBytes": 4743168,
"scriptDurationMs": 411.8190000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2174.6610000000146,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.797999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1214.7430000000002,
"heapDeltaBytes": 5477532,
"heapUsedBytes": 65866148,
"domNodes": -282,
"jsHeapTotalBytes": 5267456,
"scriptDurationMs": 399.04,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3232.2600000000534,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.969,
"layouts": 60,
"layoutDurationMs": 7.767999999999999,
"taskDurationMs": 1494.142,
"heapDeltaBytes": -66592,
"heapUsedBytes": 61310172,
"domNodes": -287,
"jsHeapTotalBytes": 7663616,
"scriptDurationMs": 518.552,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3144.4930000000113,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.767,
"layouts": 60,
"layoutDurationMs": 7.643000000000001,
"taskDurationMs": 1424.968,
"heapDeltaBytes": 23083768,
"heapUsedBytes": 84656476,
"domNodes": 10,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 512.8629999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2073.090000000036,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.042,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 698.871,
"heapDeltaBytes": 8145980,
"heapUsedBytes": 69045116,
"domNodes": -282,
"jsHeapTotalBytes": 4255744,
"scriptDurationMs": 98.248,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2041.317999999933,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.7940000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 664.1610000000001,
"heapDeltaBytes": 4798644,
"heapUsedBytes": 65356264,
"domNodes": -284,
"jsHeapTotalBytes": 5042176,
"scriptDurationMs": 92.53799999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 567.2170000000278,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.929999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.81,
"heapDeltaBytes": -11743608,
"heapUsedBytes": 56308152,
"domNodes": 20,
"jsHeapTotalBytes": 21622784,
"scriptDurationMs": 118.977,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.2149999999101,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.776,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.26199999999994,
"heapDeltaBytes": -11992788,
"heapUsedBytes": 56214484,
"domNodes": 18,
"jsHeapTotalBytes": 22147072,
"scriptDurationMs": 122.423,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2004.2479999999614,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.998000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.092,
"heapDeltaBytes": 4675992,
"heapUsedBytes": 72531524,
"domNodes": 22,
"jsHeapTotalBytes": 21622784,
"scriptDurationMs": 13.017,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2016.9240000000173,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.477,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.372,
"heapDeltaBytes": 4522308,
"heapUsedBytes": 72685060,
"domNodes": 16,
"jsHeapTotalBytes": 21098496,
"scriptDurationMs": 13.451,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1729.9719999999752,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.358000000000004,
"layouts": 16,
"layoutDurationMs": 3.9699999999999998,
"taskDurationMs": 779.1370000000001,
"heapDeltaBytes": -19843160,
"heapUsedBytes": 48222332,
"domNodes": -280,
"jsHeapTotalBytes": 21487616,
"scriptDurationMs": 86.98,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.5450000000637,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.387,
"layouts": 16,
"layoutDurationMs": 4.2059999999999995,
"taskDurationMs": 773.821,
"heapDeltaBytes": -22060880,
"heapUsedBytes": 46215520,
"domNodes": 65,
"jsHeapTotalBytes": 20701184,
"scriptDurationMs": 86.643,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1379.2230000000245,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.816999999999997,
"layouts": 15,
"layoutDurationMs": 11.375,
"taskDurationMs": 907.9710000000001,
"heapDeltaBytes": 31012128,
"heapUsedBytes": 99645904,
"domNodes": 13673,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 32.135,
"eventListeners": 2371,
"totalBlockingTimeMs": 112,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8163.236999999981,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.48499999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4243.763999999999,
"heapDeltaBytes": 10750992,
"heapUsedBytes": 69903204,
"domNodes": -283,
"jsHeapTotalBytes": 7364608,
"scriptDurationMs": 1302.6460000000002,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8238.678999999935,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.296,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4283.929999999999,
"heapDeltaBytes": 12887872,
"heapUsedBytes": 72737924,
"domNodes": -281,
"jsHeapTotalBytes": 7102464,
"scriptDurationMs": 1301.693,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17534.058000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17497.421,
"heapDeltaBytes": -32548612,
"heapUsedBytes": 170518632,
"domNodes": -8312,
"jsHeapTotalBytes": -11476992,
"scriptDurationMs": 588.9519999999999,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17581.045000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17562.252,
"heapDeltaBytes": -41182872,
"heapUsedBytes": 166946152,
"domNodes": -8312,
"jsHeapTotalBytes": -15147008,
"scriptDurationMs": 531.393,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21098.835000000006,
"styleRecalcs": 144,
"styleRecalcDurationMs": 19.02999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21047.867,
"heapDeltaBytes": -34713968,
"heapUsedBytes": 167549816,
"domNodes": -8312,
"jsHeapTotalBytes": -16719872,
"scriptDurationMs": 936.6170000000001,
"eventListeners": -16381,
"totalBlockingTimeMs": 285,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21278.052000000003,
"styleRecalcs": 145,
"styleRecalcDurationMs": 19.562999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21253.553999999996,
"heapDeltaBytes": -53036072,
"heapUsedBytes": 154337584,
"domNodes": -8312,
"jsHeapTotalBytes": -10424320,
"scriptDurationMs": 854.332,
"eventListeners": -16383,
"totalBlockingTimeMs": 204,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 470.8190000000059,
"styleRecalcs": 19,
"styleRecalcDurationMs": 23.026999999999997,
"layouts": 3,
"layoutDurationMs": 1.5450000000000002,
"taskDurationMs": 128.585,
"heapDeltaBytes": -15622108,
"heapUsedBytes": 51345680,
"domNodes": 154,
"jsHeapTotalBytes": 7467008,
"scriptDurationMs": 11.934,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 499.09100000002127,
"styleRecalcs": 12,
"styleRecalcDurationMs": 22.193,
"layouts": 3,
"layoutDurationMs": 0.654,
"taskDurationMs": 123.71399999999998,
"heapDeltaBytes": -16073236,
"heapUsedBytes": 50921652,
"domNodes": 117,
"jsHeapTotalBytes": 7991296,
"scriptDurationMs": 9.3,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
📝 WalkthroughWalkthroughThe telemetry layer now supports feature-flag exposure events, including Datadog RUM forwarding. Workspace settings report partner-node governance flag exposure, while ChangesTelemetry instrumentation
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.test.ts`:
- Around line 211-246: Update the telemetry assertion for
mockTrackUiButtonClicked so it verifies all expected payloads without depending
on call order, using an unordered collection matcher or individual
toContainEqual checks. Preserve the existing payload values and coverage while
removing the exact sequence requirement.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 17dcced7-e1a8-4840-b585-a7da3b0d0312
📒 Files selected for processing (3)
src/platform/telemetry/types.tssrc/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.test.tssrc/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14273 +/- ##
==========================================
+ Coverage 78.43% 78.45% +0.02%
==========================================
Files 1760 1760
Lines 102113 102138 +25
Branches 32159 32845 +686
==========================================
+ Hits 80094 80135 +41
+ Misses 21600 21578 -22
- Partials 419 425 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
72a7df1 to
8e9648e
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/settings/composables/useSettingUI.test.ts`:
- Around line 351-365: Add the required workspace visibility state assignments
in the parameterized governance telemetry test before invoking useSettingUI(),
setting teamWorkspacesEnabled and isLoggedIn to enabled values so
shouldShowWorkspacePanel allows the partner_node_governance_enabled exposure to
be tracked. Preserve the existing enabled/disabled parameter coverage and
expectation.
In `@src/platform/settings/composables/useSettingUI.ts`:
- Around line 1-7: Update the exposure telemetry watcher in useSettingUI to
watch only shouldShowWorkspacePanel, not flags.partnerNodeGovernanceEnabled.
Read the current flag value inside the watcher callback so flag changes while
the panel remains visible do not re-emit telemetry, while visibility transitions
retain the existing behavior.
In
`@src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue`:
- Around line 449-458: Update toggleExpanded to determine the tracking event
from the effective expansion state by calling isProviderExpanded(providerId)
after assigning expandedProviderIds.value, rather than checking nextIds
directly. Keep the existing set toggle behavior unchanged and emit expanded or
collapsed based on the state actually used by the UI, including when search
forces providers open.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d04ef8b5-fbb4-4ce4-9552-53993b2d9f9d
📒 Files selected for processing (9)
src/platform/settings/composables/useSettingUI.test.tssrc/platform/settings/composables/useSettingUI.tssrc/platform/telemetry/TelemetryRegistry.test.tssrc/platform/telemetry/TelemetryRegistry.tssrc/platform/telemetry/providers/cloud/DatadogRumTelemetryProvider.test.tssrc/platform/telemetry/providers/cloud/DatadogRumTelemetryProvider.tssrc/platform/telemetry/types.tssrc/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.test.tssrc/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/settings/composables/useSettingUI.test.ts`:
- Around line 351-365: Add the required workspace visibility state assignments
in the parameterized governance telemetry test before invoking useSettingUI(),
setting teamWorkspacesEnabled and isLoggedIn to enabled values so
shouldShowWorkspacePanel allows the partner_node_governance_enabled exposure to
be tracked. Preserve the existing enabled/disabled parameter coverage and
expectation.
In `@src/platform/settings/composables/useSettingUI.ts`:
- Around line 1-7: Update the exposure telemetry watcher in useSettingUI to
watch only shouldShowWorkspacePanel, not flags.partnerNodeGovernanceEnabled.
Read the current flag value inside the watcher callback so flag changes while
the panel remains visible do not re-emit telemetry, while visibility transitions
retain the existing behavior.
In
`@src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue`:
- Around line 449-458: Update toggleExpanded to determine the tracking event
from the effective expansion state by calling isProviderExpanded(providerId)
after assigning expandedProviderIds.value, rather than checking nextIds
directly. Keep the existing set toggle behavior unchanged and emit expanded or
collapsed based on the state actually used by the UI, including when search
forces providers open.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d04ef8b5-fbb4-4ce4-9552-53993b2d9f9d
📒 Files selected for processing (9)
src/platform/settings/composables/useSettingUI.test.tssrc/platform/settings/composables/useSettingUI.tssrc/platform/telemetry/TelemetryRegistry.test.tssrc/platform/telemetry/TelemetryRegistry.tssrc/platform/telemetry/providers/cloud/DatadogRumTelemetryProvider.test.tssrc/platform/telemetry/providers/cloud/DatadogRumTelemetryProvider.tssrc/platform/telemetry/types.tssrc/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.test.tssrc/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue
🛑 Comments failed to post (2)
src/platform/settings/composables/useSettingUI.test.ts (1)
351-365: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
rg -n -C 6 'beforeEach|isCloud|teamWorkspacesEnabled|isLoggedIn|clearAllMocks|mockClear' src/platform/settings/composables/useSettingUI.test.tsRepository: Comfy-Org/ComfyUI_frontend
Length of output: 4558
🏁 Script executed:
#!/bin/bash set -euo pipefail echo "Outline:" ast-grep outline src/platform/settings/composables/useSettingUI.test.ts || true echo echo "Relevant test file section:" sed -n '130,370p' src/platform/settings/composables/useSettingUI.test.ts echo echo "Source useSettingUI relevant references:" sed -n '1,220p' src/platform/settings/composables/useSettingUI.ts rg -n 'shouldShowWorkspacePanel|partner_node_governance_enabled|featureFlagExposure|FeatureFlagExposure|trackFeatureFlagExposure|shouldShowWorkspacePanel' src/platform/settings/composables/useSettingUI.ts src/platform/settings src/composables -g '*.ts' -g '*.vue' | head -200Repository: Comfy-Org/ComfyUI_frontend
Length of output: 16853
🏁 Script executed:
#!/bin/bash set -euo pipefail echo "useSettingUI.ts telemetry/workspace visibility section:" sed -n '230,270p' src/platform/settings/composables/useSettingUI.ts echo echo "Mock useTelemetry setup:" sed -n '60,80p' src/platform/settings/composables/useSettingUI.test.ts echo echo "Read-only check: whether parameterized governance test runs without workspace visibility state:" python3 - <<'PY' from pathlib import Path import re p = Path('src/platform/settings/composables/useSettingUI.test.ts') src = p.read_text() m = re.search(r"it\.for\(\[true, false\]\)\(\s*'reports the resolved governance flag when it is %s'.*?expect\(mockTrackFeatureFlagExposure\)\.toHaveBeenCalledExactlyOnceWith\(`"'"'"([^`]+)`"'"'",\s*enabled\s*\)", src, re.S) test = m.group(0) if m else '' print('test_found=', bool(m)) print('test_snippet=', test) for flag in ['isCloud:', 'isLoggedIn:', 'teamWorkspacesEnabled:', 'partnerNodeGovernanceEnabled=']: print(flag, 'inside_test=', bool(re.search(rf"{flag}", test))) PYRepository: Comfy-Org/ComfyUI_frontend
Length of output: 2256
Set the workspace visibility precondition explicitly for the governance telemetry test.
partner_node_governance_enabledis only tracked inside theshouldShowWorkspacePanelguard, which requiresteamWorkspacesEnabledandisLoggedInin this test setup. Add those prerequisite state assignments to the parameterized cases, otherwise the watcher returns early and the telemetry expectation can be an incomplete/noop path.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/platform/settings/composables/useSettingUI.test.ts` around lines 351 - 365, Add the required workspace visibility state assignments in the parameterized governance telemetry test before invoking useSettingUI(), setting teamWorkspacesEnabled and isLoggedIn to enabled values so shouldShowWorkspacePanel allows the partner_node_governance_enabled exposure to be tracked. Preserve the existing enabled/disabled parameter coverage and expectation.Source: Path instructions
src/platform/settings/composables/useSettingUI.ts (1)
1-7: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Avoid re-emitting exposure telemetry on flag changes.
watchEffecttracks bothshouldShowWorkspacePanelandflags.partnerNodeGovernanceEnabled, so changing the flag while the workspace panel remains visible emits another exposure event. Watch only the visibility transition and read the current flag inside the callback.Proposed fix
-import { ..., watchEffect } from 'vue' +import { ..., watch } from 'vue' -watchEffect(() => { - if (!shouldShowWorkspacePanel.value) return - - useTelemetry()?.trackFeatureFlagExposure( - ServerFeatureFlag.PARTNER_NODE_GOVERNANCE_ENABLED, - flags.partnerNodeGovernanceEnabled - ) -}) +watch( + shouldShowWorkspacePanel, + (isVisible) => { + if (!isVisible) return + + useTelemetry()?.trackFeatureFlagExposure( + ServerFeatureFlag.PARTNER_NODE_GOVERNANCE_ENABLED, + flags.partnerNodeGovernanceEnabled + ) + }, + { immediate: true } +)Also applies to: 244-251
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/platform/settings/composables/useSettingUI.ts` around lines 1 - 7, Update the exposure telemetry watcher in useSettingUI to watch only shouldShowWorkspacePanel, not flags.partnerNodeGovernanceEnabled. Read the current flag value inside the watcher callback so flag changes while the panel remains visible do not re-emit telemetry, while visibility transitions retain the existing behavior.
2ab4e1b to
5211c0b
Compare
8e9648e to
ab08bf0
Compare
5211c0b to
02162e4
Compare
ab08bf0 to
fcb50e7
Compare
02162e4 to
453cc51
Compare
fcb50e7 to
5171528
Compare
453cc51 to
77dc41c
Compare
5171528 to
9277494
Compare
|
@comfydesigner see if the tracking here makes sense to you Note Track search, sort, expand, retry, policy clicks, confirmations, and cancellations. |
9277494 to
b0ac82d
Compare
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-14273.vercel.app This commit: https://website-frontend-7tdjwjogq-comfyui.vercel.app Last updated: 2026-07-31T00:33:15Z for |
## Summary Adds one terminal Datadog RUM action for each flag-enabled unified-auth 401 recovery attempt so rollout monitoring can distinguish successful recovery, persistent authorization failures, re-mint failures, and retry transport failures. ## Changes - **What**: Emits `auth.unified.request_retry.succeeded` or `auth.unified.request_retry.failed` after fetch and Axios 401 recovery, with only low-cardinality `transport`, `outcome`, `final_status`, and `failure_reason` context. - **Root cause**: Resource events show the treatment cohort but cannot identify whether a 401 was recovered or amplified by the retry path. Current production baselines include tens of thousands of repeated 401/403 events from fewer than 100 sessions, so raw resource counts cannot safely drive rollout decisions. - **Privacy**: Does not emit tokens, authorization headers, request URLs, response bodies, or user identifiers. - **Dependencies**: Related to Comfy-Org#14273, which supplies `unified_cloud_auth` feature-flag attribution. This PR remains runtime-safe without it; cohort filtering becomes available after both changes deploy. ## Review Focus - Exactly one lifecycle action is emitted per initial 401 that enters the unified retry path. - Flag-off and non-401 traffic remain telemetry no-ops. - Persistent 401s and transport failures preserve the existing response/error behavior. ## Verification - `pnpm test:unit src/platform/auth/unified/remintRetry.test.ts src/platform/telemetry/TelemetryRegistry.test.ts src/platform/telemetry/providers/cloud/DatadogRumTelemetryProvider.test.ts` (40 tests) - `pnpm typecheck` - Targeted ESLint on all changed files ## Screenshots (if applicable) Not applicable; telemetry-only change with no UI impact. Co-authored-by: dante01yoon <dante01yoon@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com>
## Summary
Restyles the workspace partner node governance panel to the new Partner
Models design (workspace settings parity with the platform.comfy.org
governance UX).
## Changes
- **What**:
- Replace the Unrestricted/Restricted segmented control with an **Allow
all partner models** toggle card; while restricted, the helper line
carries a warning icon and explains that later-published partner models
stay blocked until a workspace owner enables them
- Rename the settings tab **Allowlist → Partner Models**
- Table: **Models** column is a static `{n} models` count in both modes;
new sortable **State** column with per-provider toggles rendered only
while restricted (width always reserved, so columns never shift); pinned
header and footer with rows scrolling between them; table is no longer
dimmed/inert while allow-all is on (rows stay explorable)
- Replace the Enable all / Disable all buttons with a **Disable all ▾**
menu whose items carry scope counts (`Disable all 36 providers` /
`Enable 4 matching providers`); with a search active, bulk actions apply
to matching providers only; no-op items are disabled
- Add an allowed-models summary under the table (`All partner models
allowed` / `214 partner models allowed`)
- Search: providers match by name or model name, nothing auto-expands
(chevron is always user-controlled); rows narrowed by the query show `3
of 7 match` in the Models column, full-relevance rows keep the plain
count
- Static table geometry: sticky in-scroller header (fixes a pre-existing
scrollbar-width misalignment from Comfy-Org#13951), full-height card, reserved
scrollbar gutter — no layout shift on expand/collapse/mode change
- New `setProvidersEnabled(providerIds, enabled)` store action for
search-scoped bulk edits
- Partner-models vocabulary sweep across `workspacePanel.partnerNodes`
strings
- **Enterprise upsell (gated state)**: workspaces whose policy access
403s but whose catalog loads render the tab read-only with a muted crown
on the nav item, an Enterprise pill + Contact us on the access card, and
a confirm-dialog upsell when the locked toggle is clicked. Store keeps
the provider catalog when only the policy fetch is forbidden; `NavItem`
gains an optional `suffixIcon`.
- **Breaking**: none — policy API payloads and enforcement semantics
unchanged
## Review Focus
- Unfiltered *Disable all N providers* still confirms via dialog;
search-scoped bulk applies immediately (scope is explicit in the item
label)
- Access-mode flips now **remember provider states** (per design
annotation): first-ever restriction defaults all providers on;
thereafter, disabling BFL, allowing all, and restricting again leaves
BFL disabled. Returning to allow-all no longer resets stored states —
behavior change vs the shipped store, FE-only (the full policy is
persisted either way)
- Analytics in Comfy-Org#14273 instruments the previous control set and will need
a rebase
- Confirm-dialog components (`ConfirmHeader/Body/Footer`,
`showConfirmDialog`) restyled to the Modal/Small design spec — 512px
width, rounded-2xl, `border-default`, 14px regular title, muted Cancel,
16px section padding. **This affects every `showConfirmDialog` caller
app-wide** (visual only; behavior unchanged)
Design: [Team Plan / Workspaces — Partner Models
settings](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Team-Plan---Workspaces?node-id=5732-53942)
Linear: Part of DES-685 and DES-641 · implementation counterpart FE-1525
---------
Co-authored-by: Claude <noreply@anthropic.com>
|
Closing the Allowlist action instrumentation because there is no confirmed product/design consumer for these events. The reusable feature-flag telemetry work remains separately in #14279. |


Summary
Instrument Allowlist actions behind
partner_node_governance_enabled, with automatic Datadog feature-flag evaluation for current and future flag reads.Changes
Review Focus
Verification
b0ac82d.Created by Codex