Skip to content

feat: instrument Allowlist actions - #14273

Closed
huang47 wants to merge 7 commits into
mainfrom
codex/instrument-allowlist-actions
Closed

huang47 wants to merge 7 commits into
mainfrom
codex/instrument-allowlist-actions

Conversation

@huang47

@huang47 huang47 commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Instrument Allowlist actions behind partner_node_governance_enabled, with automatic Datadog feature-flag evaluation for current and future flag reads.

Changes

  • Track search, sort, expand, retry, policy clicks, confirmations, and cancellations.
  • Attach evaluated flags to RUM actions, resources, vitals, and long tasks.
  • Skip search-forced expansion; count Escape and close dismissals.

Review Focus

  • Allowlist event semantics.
  • Datadog flag normalization, privacy, and runtime overhead.

Verification

  • 226 focused tests, typecheck, lint, format, and knip.
  • Datadog RUM evidence from rebased head b0ac82d.

Created by Codex

@github-actions

github-actions Bot commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1767 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1746 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 07/31/2026, 12:33:33 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 50.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 45.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 112ms TBT · 95.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.0 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 160.9 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 245ms TBT · 153.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.8 MB heap

⚠️ 6 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 403ms 546ms +36% ⚠️ z=4.9
canvas-zoom-sweep: task duration 310ms 377ms +22% ⚠️ z=2.2
large-graph-idle: task duration 542ms 669ms +23% ⚠️ z=2.3
large-graph-pan: task duration 980ms 1230ms +25% ⚠️ z=3.4
minimap-idle: task duration 561ms 682ms +21% ⚠️ z=3.3
subgraph-idle: task duration 397ms 460ms +16% ⚠️ z=2.9
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.1
canvas-idle: p95 frame time 17ms 17ms -1% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 6ms 8ms +23% z=-3.6
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 10 9 -10% z=-3.8
canvas-idle: task duration 403ms 546ms +36% ⚠️ z=4.9
canvas-idle: script duration 13ms 18ms +31% z=-3.4
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 43.6 MB 56.5 MB +30% —
canvas-idle: DOM nodes -277 18 -106% z=-3.6
canvas-idle: event listeners -146 5 -103% z=-1.4
canvas-mouse-sweep: avg frame time 17ms 17ms -0% z=-0.9
canvas-mouse-sweep: p95 frame time 17ms 17ms -0% —
canvas-mouse-sweep: layout duration 3ms 4ms +23% z=-0.5
canvas-mouse-sweep: style recalc duration 27ms 37ms +39% z=-1.8
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 72 74 +3% z=-2.0
canvas-mouse-sweep: task duration 697ms 877ms +26% z=0.2
canvas-mouse-sweep: script duration 93ms 116ms +25% z=-3.0
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 50.0 MB 50.6 MB +1% —
canvas-mouse-sweep: DOM nodes -280 -280 +0% z=-132.3
canvas-mouse-sweep: event listeners -146 -148 +1% z=-37.5
canvas-zoom-sweep: avg frame time 17ms 17ms +0% z=0.5
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% —
canvas-zoom-sweep: layout duration 1ms 1ms +38% z=1.5
canvas-zoom-sweep: style recalc duration 13ms 17ms +33% z=-1.3
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 29 31 +5% z=-1.7
canvas-zoom-sweep: task duration 310ms 377ms +22% ⚠️ z=2.2
canvas-zoom-sweep: script duration 16ms 19ms +19% z=-2.8
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 71.9 MB 72.4 MB +1% —
canvas-zoom-sweep: DOM nodes 78 77 -1% z=-2.8
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.5
dom-widget-clipping: p95 frame time 17ms 17ms +0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 8ms 7ms -2% z=-3.2
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 13 11 -15% z=-4.2
dom-widget-clipping: task duration 313ms 370ms +18% z=0.3
dom-widget-clipping: script duration 47ms 56ms +19% z=-3.6
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 53.3 MB 53.1 MB -0% —
dom-widget-clipping: DOM nodes 22 18 -18% z=-2.9
dom-widget-clipping: event listeners 2 0 -100% variance too high
large-graph-idle: avg frame time 17ms 17ms -0% z=-0.6
large-graph-idle: p95 frame time 17ms 17ms +0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 6ms 8ms +29% z=-4.2
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 10 10 -5% z=-6.7
large-graph-idle: task duration 542ms 669ms +23% ⚠️ z=2.3
large-graph-idle: script duration 77ms 93ms +21% z=-0.9
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 63.9 MB 64.1 MB +0% —
large-graph-idle: DOM nodes -280 -281 +0% z=-337.7
large-graph-idle: event listeners -144 -144 +0% z=-27.9
large-graph-pan: avg frame time 17ms 17ms +0% z=0.8
large-graph-pan: p95 frame time 17ms 17ms -0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 13ms 15ms +11% z=-3.3
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 68 69 +1% z=-0.9
large-graph-pan: task duration 980ms 1230ms +25% ⚠️ z=3.4
large-graph-pan: script duration 314ms 405ms +29% z=-0.1
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 62.2 MB 63.0 MB +1% —
large-graph-pan: DOM nodes -282 -282 +0% z=-182.4
large-graph-pan: event listeners -142 -143 +1% z=-178.6
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms +0% —
large-graph-zoom: layout duration 7ms 8ms +12% —
large-graph-zoom: style recalc duration 14ms 15ms +3% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 67 65 -4% —
large-graph-zoom: task duration 1223ms 1460ms +19% —
large-graph-zoom: script duration 429ms 516ms +20% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 54.9 MB 69.6 MB +27% —
large-graph-zoom: DOM nodes -281 -139 -51% —
large-graph-zoom: event listeners -148 -70 -53% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.1
minimap-idle: p95 frame time 17ms 17ms -0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 7ms 9ms +24% z=-0.8
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 9 8 -17% z=-3.0
minimap-idle: task duration 561ms 682ms +21% ⚠️ z=3.3
minimap-idle: script duration 86ms 95ms +12% z=-0.3
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 67.0 MB 64.1 MB -4% —
minimap-idle: DOM nodes -282 -283 +0% z=-220.9
minimap-idle: event listeners -144 -143 -1% z=-223.5
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.4
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 9ms 10ms +5% z=-3.0
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 47 -1% z=-2.5
subgraph-dom-widget-clipping: task duration 331ms 391ms +18% z=0.7
subgraph-dom-widget-clipping: script duration 100ms 121ms +20% z=-1.2
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 53.6 MB 53.7 MB +0% —
subgraph-dom-widget-clipping: DOM nodes 20 19 -5% z=-2.8
subgraph-dom-widget-clipping: event listeners 8 7 -13% z=-1.6
subgraph-idle: avg frame time 17ms 17ms -0% z=-0.7
subgraph-idle: p95 frame time 17ms 17ms -1% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 7ms 8ms +16% z=-3.4
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 11 10 -14% z=-2.1
subgraph-idle: task duration 397ms 460ms +16% ⚠️ z=2.9
subgraph-idle: script duration 11ms 13ms +20% z=-2.6
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 44.9 MB 69.2 MB +54% —
subgraph-idle: DOM nodes -279 19 -107% z=-1.9
subgraph-idle: event listeners -146 4 -103% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms -0% z=-0.5
subgraph-mouse-sweep: p95 frame time 17ms 17ms +1% —
subgraph-mouse-sweep: layout duration 3ms 4ms +24% z=-1.9
subgraph-mouse-sweep: style recalc duration 27ms 36ms +31% z=-2.0
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 76 76 +0% z=-2.1
subgraph-mouse-sweep: task duration 609ms 776ms +27% z=0.2
subgraph-mouse-sweep: script duration 71ms 87ms +22% z=-2.1
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 46.0 MB 45.0 MB -2% —
subgraph-mouse-sweep: DOM nodes -276 -108 -61% z=-78.1
subgraph-mouse-sweep: event listeners -146 -72 -51% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms +0% —
subgraph-transition-enter: p95 frame time 17ms 17ms -0% —
subgraph-transition-enter: layout duration 9ms 11ms +24% —
subgraph-transition-enter: style recalc duration 24ms 29ms +22% —
subgraph-transition-enter: layout count 15 15 +0% —
subgraph-transition-enter: style recalc count 19 19 +0% —
subgraph-transition-enter: task duration 745ms 908ms +22% —
subgraph-transition-enter: script duration 22ms 32ms +48% —
subgraph-transition-enter: TBT 79ms 112ms +42% —
subgraph-transition-enter: heap used 92.2 MB 95.0 MB +3% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2369 2371 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms -0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 37ms 39ms +6% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 250 249 -1% —
viewport-pan-sweep: task duration 3515ms 4264ms +21% —
viewport-pan-sweep: script duration 1057ms 1302ms +23% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 64.9 MB 68.0 MB +5% —
viewport-pan-sweep: DOM nodes -279 -282 +1% —
viewport-pan-sweep: event listeners -128 -128 +0% —
vue-large-graph-idle: avg frame time 17ms 18ms +3% —
vue-large-graph-idle: p95 frame time 17ms 17ms -0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 14412ms 17530ms +22% —
vue-large-graph-idle: script duration 433ms 560ms +29% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 159.6 MB 160.9 MB +1% —
vue-large-graph-idle: DOM nodes -8312 -8312 +0% —
vue-large-graph-idle: event listeners -16389 -16385 -0% —
vue-large-graph-pan: avg frame time 17ms 18ms +5% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 13ms 19ms +46% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 112 145 +29% —
vue-large-graph-pan: task duration 16727ms 21151ms +26% —
vue-large-graph-pan: script duration 693ms 895ms +29% —
vue-large-graph-pan: TBT 35ms 245ms +599% —
vue-large-graph-pan: heap used 159.9 MB 153.5 MB -4% —
vue-large-graph-pan: DOM nodes -8312 -8312 +0% —
vue-large-graph-pan: event listeners -16385 -16382 -0% —
workflow-execution: avg frame time 17ms 17ms +0% z=0.6
workflow-execution: p95 frame time 17ms 17ms -1% —
workflow-execution: layout duration 0ms 1ms +220% z=-3.1
workflow-execution: style recalc duration 15ms 23ms +55% z=-0.7
workflow-execution: layout count 2 3 +50% z=-3.6
workflow-execution: style recalc count 14 16 +11% z=-1.1
workflow-execution: task duration 90ms 126ms +41% z=0.3
workflow-execution: script duration 7ms 11ms +43% z=-6.2
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 48.6 MB 48.8 MB +0% —
workflow-execution: DOM nodes 121 136 +12% z=-3.6
workflow-execution: event listeners 67 66 -1% z=3.2
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-07-31T00:44:03.614Z",
  "gitSha": "73ff65f94da0fecdbdeaf13bd756ed50de09eaec",
  "branch": "codex/instrument-allowlist-actions",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2109.1370000000043,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.843000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 628.054,
      "heapDeltaBytes": -21744048,
      "heapUsedBytes": 46068244,
      "domNodes": 16,
      "jsHeapTotalBytes": 19652608,
      "scriptDurationMs": 18.944,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2055.0029999999992,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.391,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 463.413,
      "heapDeltaBytes": 4540948,
      "heapUsedBytes": 72381432,
      "domNodes": 20,
      "jsHeapTotalBytes": 20836352,
      "scriptDurationMs": 16.215,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1857.5950000000034,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 36.348000000000006,
      "layouts": 12,
      "layoutDurationMs": 3.571,
      "taskDurationMs": 877.564,
      "heapDeltaBytes": -15668436,
      "heapUsedBytes": 52479720,
      "domNodes": -280,
      "jsHeapTotalBytes": 20439040,
      "scriptDurationMs": 116.747,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1867.4760000000106,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 37.714,
      "layouts": 12,
      "layoutDurationMs": 3.4569999999999994,
      "taskDurationMs": 875.876,
      "heapDeltaBytes": -14227560,
      "heapUsedBytes": 53712252,
      "domNodes": -280,
      "jsHeapTotalBytes": 22274048,
      "scriptDurationMs": 114.98800000000001,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1688.9919999999847,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 17.349999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.6759999999999999,
      "taskDurationMs": 382.59099999999995,
      "heapDeltaBytes": 7894016,
      "heapUsedBytes": 75816392,
      "domNodes": 78,
      "jsHeapTotalBytes": 20049920,
      "scriptDurationMs": 18.585,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.7729999999237,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.987000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.745,
      "taskDurationMs": 371.811,
      "heapDeltaBytes": 7887032,
      "heapUsedBytes": 76070620,
      "domNodes": 76,
      "jsHeapTotalBytes": 20574208,
      "scriptDurationMs": 18.622,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 590.8919999999966,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 371.027,
      "heapDeltaBytes": -12444580,
      "heapUsedBytes": 55482188,
      "domNodes": 20,
      "jsHeapTotalBytes": 22147072,
      "scriptDurationMs": 56.98199999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 591.6760000000068,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.717999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 369.028,
      "heapDeltaBytes": -12289856,
      "heapUsedBytes": 55850460,
      "domNodes": 16,
      "jsHeapTotalBytes": 21360640,
      "scriptDurationMs": 55.171,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.4820000000068,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.105,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 664.8639999999999,
      "heapDeltaBytes": 8530272,
      "heapUsedBytes": 67395156,
      "domNodes": -280,
      "jsHeapTotalBytes": 3731456,
      "scriptDurationMs": 93.287,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2022.3829999999907,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.607,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 672.2030000000001,
      "heapDeltaBytes": 8345336,
      "heapUsedBytes": 67013776,
      "domNodes": -281,
      "jsHeapTotalBytes": 4517888,
      "scriptDurationMs": 93.30699999999999,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2166.095999999982,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.443000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1244.5040000000001,
      "heapDeltaBytes": 6387568,
      "heapUsedBytes": 66254984,
      "domNodes": -282,
      "jsHeapTotalBytes": 4743168,
      "scriptDurationMs": 411.8190000000001,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2174.6610000000146,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.797999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1214.7430000000002,
      "heapDeltaBytes": 5477532,
      "heapUsedBytes": 65866148,
      "domNodes": -282,
      "jsHeapTotalBytes": 5267456,
      "scriptDurationMs": 399.04,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3232.2600000000534,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 14.969,
      "layouts": 60,
      "layoutDurationMs": 7.767999999999999,
      "taskDurationMs": 1494.142,
      "heapDeltaBytes": -66592,
      "heapUsedBytes": 61310172,
      "domNodes": -287,
      "jsHeapTotalBytes": 7663616,
      "scriptDurationMs": 518.552,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3144.4930000000113,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.767,
      "layouts": 60,
      "layoutDurationMs": 7.643000000000001,
      "taskDurationMs": 1424.968,
      "heapDeltaBytes": 23083768,
      "heapUsedBytes": 84656476,
      "domNodes": 10,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 512.8629999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2073.090000000036,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 12.042,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 698.871,
      "heapDeltaBytes": 8145980,
      "heapUsedBytes": 69045116,
      "domNodes": -282,
      "jsHeapTotalBytes": 4255744,
      "scriptDurationMs": 98.248,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2041.317999999933,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.7940000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 664.1610000000001,
      "heapDeltaBytes": 4798644,
      "heapUsedBytes": 65356264,
      "domNodes": -284,
      "jsHeapTotalBytes": 5042176,
      "scriptDurationMs": 92.53799999999998,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 567.2170000000278,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.929999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 390.81,
      "heapDeltaBytes": -11743608,
      "heapUsedBytes": 56308152,
      "domNodes": 20,
      "jsHeapTotalBytes": 21622784,
      "scriptDurationMs": 118.977,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 577.2149999999101,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.776,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 391.26199999999994,
      "heapDeltaBytes": -11992788,
      "heapUsedBytes": 56214484,
      "domNodes": 18,
      "jsHeapTotalBytes": 22147072,
      "scriptDurationMs": 122.423,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2004.2479999999614,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.998000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 473.092,
      "heapDeltaBytes": 4675992,
      "heapUsedBytes": 72531524,
      "domNodes": 22,
      "jsHeapTotalBytes": 21622784,
      "scriptDurationMs": 13.017,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2016.9240000000173,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.477,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 446.372,
      "heapDeltaBytes": 4522308,
      "heapUsedBytes": 72685060,
      "domNodes": 16,
      "jsHeapTotalBytes": 21098496,
      "scriptDurationMs": 13.451,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1729.9719999999752,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 35.358000000000004,
      "layouts": 16,
      "layoutDurationMs": 3.9699999999999998,
      "taskDurationMs": 779.1370000000001,
      "heapDeltaBytes": -19843160,
      "heapUsedBytes": 48222332,
      "domNodes": -280,
      "jsHeapTotalBytes": 21487616,
      "scriptDurationMs": 86.98,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1742.5450000000637,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 36.387,
      "layouts": 16,
      "layoutDurationMs": 4.2059999999999995,
      "taskDurationMs": 773.821,
      "heapDeltaBytes": -22060880,
      "heapUsedBytes": 46215520,
      "domNodes": 65,
      "jsHeapTotalBytes": 20701184,
      "scriptDurationMs": 86.643,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1379.2230000000245,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 28.816999999999997,
      "layouts": 15,
      "layoutDurationMs": 11.375,
      "taskDurationMs": 907.9710000000001,
      "heapDeltaBytes": 31012128,
      "heapUsedBytes": 99645904,
      "domNodes": 13673,
      "jsHeapTotalBytes": 15990784,
      "scriptDurationMs": 32.135,
      "eventListeners": 2371,
      "totalBlockingTimeMs": 112,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8163.236999999981,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 38.48499999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4243.763999999999,
      "heapDeltaBytes": 10750992,
      "heapUsedBytes": 69903204,
      "domNodes": -283,
      "jsHeapTotalBytes": 7364608,
      "scriptDurationMs": 1302.6460000000002,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8238.678999999935,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 40.296,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4283.929999999999,
      "heapDeltaBytes": 12887872,
      "heapUsedBytes": 72737924,
      "domNodes": -281,
      "jsHeapTotalBytes": 7102464,
      "scriptDurationMs": 1301.693,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17534.058000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17497.421,
      "heapDeltaBytes": -32548612,
      "heapUsedBytes": 170518632,
      "domNodes": -8312,
      "jsHeapTotalBytes": -11476992,
      "scriptDurationMs": 588.9519999999999,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17581.045000000016,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17562.252,
      "heapDeltaBytes": -41182872,
      "heapUsedBytes": 166946152,
      "domNodes": -8312,
      "jsHeapTotalBytes": -15147008,
      "scriptDurationMs": 531.393,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21098.835000000006,
      "styleRecalcs": 144,
      "styleRecalcDurationMs": 19.02999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21047.867,
      "heapDeltaBytes": -34713968,
      "heapUsedBytes": 167549816,
      "domNodes": -8312,
      "jsHeapTotalBytes": -16719872,
      "scriptDurationMs": 936.6170000000001,
      "eventListeners": -16381,
      "totalBlockingTimeMs": 285,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21278.052000000003,
      "styleRecalcs": 145,
      "styleRecalcDurationMs": 19.562999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21253.553999999996,
      "heapDeltaBytes": -53036072,
      "heapUsedBytes": 154337584,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10424320,
      "scriptDurationMs": 854.332,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 204,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 470.8190000000059,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 23.026999999999997,
      "layouts": 3,
      "layoutDurationMs": 1.5450000000000002,
      "taskDurationMs": 128.585,
      "heapDeltaBytes": -15622108,
      "heapUsedBytes": 51345680,
      "domNodes": 154,
      "jsHeapTotalBytes": 7467008,
      "scriptDurationMs": 11.934,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 499.09100000002127,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 22.193,
      "layouts": 3,
      "layoutDurationMs": 0.654,
      "taskDurationMs": 123.71399999999998,
      "heapDeltaBytes": -16073236,
      "heapUsedBytes": 50921652,
      "domNodes": 117,
      "jsHeapTotalBytes": 7991296,
      "scriptDurationMs": 9.3,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@coderabbitai

coderabbitai Bot commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The telemetry layer now supports feature-flag exposure events, including Datadog RUM forwarding. Workspace settings report partner-node governance flag exposure, while PartnerNodeAccessPanel tracks allowlist searches and user interactions with expanded test coverage.

Changes

Telemetry instrumentation

Layer / File(s) Summary
Feature-flag telemetry contracts and provider dispatch
src/platform/telemetry/types.ts, src/platform/telemetry/TelemetryRegistry.ts, src/platform/telemetry/providers/cloud/...
Adds optional feature-flag exposure support to telemetry providers, registry dispatch, and Datadog RUM.
Workspace governance flag exposure
src/platform/settings/composables/useSettingUI.ts, src/platform/settings/composables/useSettingUI.test.ts
Tracks the partner-node governance flag value when the workspace settings panel is shown.
Allowlist interaction tracking
src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue
Tracks allowlist opening, searching, sorting, expansion, provider changes, retries, and confirmation outcomes while preserving existing operations.
Allowlist telemetry validation
src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.test.ts
Mocks telemetry hooks and verifies emitted events across allowlist interactions and retry flows.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

Suggested reviewers: christian-byrne, dante01yoon


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive Commit subjects/PR title weren’t provided, so I can’t determine whether this is a bug-fix PR under the check rules. Please provide the PR title and commit subjects (or confirm none use bug-fix language) so I can assess whether a browser_tests regression test was required.
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Adr Compliance For Entity/Litegraph Changes ✅ Passed No changed files are under src/lib/litegraph/, src/ecs/, or graph-entity paths, so ADR 0003/0008 checks are not applicable.
Title check ✅ Passed The title clearly and concisely describes the primary change: adding telemetry instrumentation for Allowlist actions.
Description check ✅ Passed The description covers the summary, changes, review focus, and verification, though it omits explicit template fields for breaking changes and dependencies.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/instrument-allowlist-actions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.test.ts`:
- Around line 211-246: Update the telemetry assertion for
mockTrackUiButtonClicked so it verifies all expected payloads without depending
on call order, using an unordered collection matcher or individual
toContainEqual checks. Preserve the existing payload values and coverage while
removing the exact sequence requirement.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 17dcced7-e1a8-4840-b585-a7da3b0d0312

📥 Commits

Reviewing files that changed from the base of the PR and between fc92a12 and 72a7df1.

📒 Files selected for processing (3)
  • src/platform/telemetry/types.ts
  • src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.test.ts
  • src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue

@codecov

codecov Bot commented Jul 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #14273      +/-   ##
==========================================
+ Coverage   78.43%   78.45%   +0.02%     
==========================================
  Files        1760     1760              
  Lines      102113   102138      +25     
  Branches    32159    32845     +686     
==========================================
+ Hits        80094    80135      +41     
+ Misses      21600    21578      -22     
- Partials      419      425       +6     
Flag Coverage Δ
unit 69.77% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/dialog/confirm/confirmDialog.ts 100.00% <100.00%> (ø)
src/composables/useFeatureFlags.ts 100.00% <100.00%> (+16.16%) ⬆️
src/platform/assets/utils/assetPreviewUtil.ts 90.90% <100.00%> (ø)
...c/platform/nodeReplacement/nodeReplacementStore.ts 100.00% <100.00%> (ø)
src/platform/telemetry/TelemetryRegistry.ts 25.98% <100.00%> (+1.18%) ⬆️
src/platform/telemetry/initDatadogRum.ts 100.00% <ø> (ø)
...try/providers/cloud/DatadogRumTelemetryProvider.ts 100.00% <100.00%> (ø)
src/platform/telemetry/types.ts 100.00% <ø> (ø)
...onents/dialogs/settings/PartnerNodeAccessPanel.vue 98.97% <100.00%> (+0.17%) ⬆️
.../extensions/manager/composables/useManagerState.ts 82.29% <100.00%> (+0.18%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@huang47
huang47 force-pushed the codex/instrument-allowlist-actions branch from 72a7df1 to 8e9648e Compare July 29, 2026 18:00
@huang47
huang47 changed the base branch from main to codex/datadog-partner-governance-flag July 29, 2026 18:00

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/platform/settings/composables/useSettingUI.test.ts`:
- Around line 351-365: Add the required workspace visibility state assignments
in the parameterized governance telemetry test before invoking useSettingUI(),
setting teamWorkspacesEnabled and isLoggedIn to enabled values so
shouldShowWorkspacePanel allows the partner_node_governance_enabled exposure to
be tracked. Preserve the existing enabled/disabled parameter coverage and
expectation.

In `@src/platform/settings/composables/useSettingUI.ts`:
- Around line 1-7: Update the exposure telemetry watcher in useSettingUI to
watch only shouldShowWorkspacePanel, not flags.partnerNodeGovernanceEnabled.
Read the current flag value inside the watcher callback so flag changes while
the panel remains visible do not re-emit telemetry, while visibility transitions
retain the existing behavior.

In
`@src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue`:
- Around line 449-458: Update toggleExpanded to determine the tracking event
from the effective expansion state by calling isProviderExpanded(providerId)
after assigning expandedProviderIds.value, rather than checking nextIds
directly. Keep the existing set toggle behavior unchanged and emit expanded or
collapsed based on the state actually used by the UI, including when search
forces providers open.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d04ef8b5-fbb4-4ce4-9552-53993b2d9f9d

📥 Commits

Reviewing files that changed from the base of the PR and between 72a7df1 and 8e9648e.

📒 Files selected for processing (9)
  • src/platform/settings/composables/useSettingUI.test.ts
  • src/platform/settings/composables/useSettingUI.ts
  • src/platform/telemetry/TelemetryRegistry.test.ts
  • src/platform/telemetry/TelemetryRegistry.ts
  • src/platform/telemetry/providers/cloud/DatadogRumTelemetryProvider.test.ts
  • src/platform/telemetry/providers/cloud/DatadogRumTelemetryProvider.ts
  • src/platform/telemetry/types.ts
  • src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.test.ts
  • src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/platform/settings/composables/useSettingUI.test.ts`:
- Around line 351-365: Add the required workspace visibility state assignments
in the parameterized governance telemetry test before invoking useSettingUI(),
setting teamWorkspacesEnabled and isLoggedIn to enabled values so
shouldShowWorkspacePanel allows the partner_node_governance_enabled exposure to
be tracked. Preserve the existing enabled/disabled parameter coverage and
expectation.

In `@src/platform/settings/composables/useSettingUI.ts`:
- Around line 1-7: Update the exposure telemetry watcher in useSettingUI to
watch only shouldShowWorkspacePanel, not flags.partnerNodeGovernanceEnabled.
Read the current flag value inside the watcher callback so flag changes while
the panel remains visible do not re-emit telemetry, while visibility transitions
retain the existing behavior.

In
`@src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue`:
- Around line 449-458: Update toggleExpanded to determine the tracking event
from the effective expansion state by calling isProviderExpanded(providerId)
after assigning expandedProviderIds.value, rather than checking nextIds
directly. Keep the existing set toggle behavior unchanged and emit expanded or
collapsed based on the state actually used by the UI, including when search
forces providers open.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d04ef8b5-fbb4-4ce4-9552-53993b2d9f9d

📥 Commits

Reviewing files that changed from the base of the PR and between 72a7df1 and 8e9648e.

📒 Files selected for processing (9)
  • src/platform/settings/composables/useSettingUI.test.ts
  • src/platform/settings/composables/useSettingUI.ts
  • src/platform/telemetry/TelemetryRegistry.test.ts
  • src/platform/telemetry/TelemetryRegistry.ts
  • src/platform/telemetry/providers/cloud/DatadogRumTelemetryProvider.test.ts
  • src/platform/telemetry/providers/cloud/DatadogRumTelemetryProvider.ts
  • src/platform/telemetry/types.ts
  • src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.test.ts
  • src/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vue
🛑 Comments failed to post (2)
src/platform/settings/composables/useSettingUI.test.ts (1)

351-365: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

rg -n -C 6 'beforeEach|isCloud|teamWorkspacesEnabled|isLoggedIn|clearAllMocks|mockClear' src/platform/settings/composables/useSettingUI.test.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 4558


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Outline:"
ast-grep outline src/platform/settings/composables/useSettingUI.test.ts || true

echo
echo "Relevant test file section:"
sed -n '130,370p' src/platform/settings/composables/useSettingUI.test.ts

echo
echo "Source useSettingUI relevant references:"
sed -n '1,220p' src/platform/settings/composables/useSettingUI.ts
rg -n 'shouldShowWorkspacePanel|partner_node_governance_enabled|featureFlagExposure|FeatureFlagExposure|trackFeatureFlagExposure|shouldShowWorkspacePanel' src/platform/settings/composables/useSettingUI.ts src/platform/settings src/composables -g '*.ts' -g '*.vue' | head -200

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 16853


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "useSettingUI.ts telemetry/workspace visibility section:"
sed -n '230,270p' src/platform/settings/composables/useSettingUI.ts

echo
echo "Mock useTelemetry setup:"
sed -n '60,80p' src/platform/settings/composables/useSettingUI.test.ts

echo
echo "Read-only check: whether parameterized governance test runs without workspace visibility state:"
python3 - <<'PY'
from pathlib import Path
import re
p = Path('src/platform/settings/composables/useSettingUI.test.ts')
src = p.read_text()
m = re.search(r"it\.for\(\[true, false\]\)\(\s*'reports the resolved governance flag when it is %s'.*?expect\(mockTrackFeatureFlagExposure\)\.toHaveBeenCalledExactlyOnceWith\(`"'"'"([^`]+)`"'"'",\s*enabled\s*\)", src, re.S)
test = m.group(0) if m else ''
print('test_found=', bool(m))
print('test_snippet=', test)
for flag in ['isCloud:', 'isLoggedIn:', 'teamWorkspacesEnabled:', 'partnerNodeGovernanceEnabled=']:
    print(flag, 'inside_test=', bool(re.search(rf"{flag}", test)))
PY

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 2256


Set the workspace visibility precondition explicitly for the governance telemetry test.

partner_node_governance_enabled is only tracked inside the shouldShowWorkspacePanel guard, which requires teamWorkspacesEnabled and isLoggedIn in this test setup. Add those prerequisite state assignments to the parameterized cases, otherwise the watcher returns early and the telemetry expectation can be an incomplete/noop path.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/platform/settings/composables/useSettingUI.test.ts` around lines 351 -
365, Add the required workspace visibility state assignments in the
parameterized governance telemetry test before invoking useSettingUI(), setting
teamWorkspacesEnabled and isLoggedIn to enabled values so
shouldShowWorkspacePanel allows the partner_node_governance_enabled exposure to
be tracked. Preserve the existing enabled/disabled parameter coverage and
expectation.

Source: Path instructions

src/platform/settings/composables/useSettingUI.ts (1)

1-7: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Avoid re-emitting exposure telemetry on flag changes.

watchEffect tracks both shouldShowWorkspacePanel and flags.partnerNodeGovernanceEnabled, so changing the flag while the workspace panel remains visible emits another exposure event. Watch only the visibility transition and read the current flag inside the callback.

Proposed fix
-import { ..., watchEffect } from 'vue'
+import { ..., watch } from 'vue'

-watchEffect(() => {
-  if (!shouldShowWorkspacePanel.value) return
-
-  useTelemetry()?.trackFeatureFlagExposure(
-    ServerFeatureFlag.PARTNER_NODE_GOVERNANCE_ENABLED,
-    flags.partnerNodeGovernanceEnabled
-  )
-})
+watch(
+  shouldShowWorkspacePanel,
+  (isVisible) => {
+    if (!isVisible) return
+
+    useTelemetry()?.trackFeatureFlagExposure(
+      ServerFeatureFlag.PARTNER_NODE_GOVERNANCE_ENABLED,
+      flags.partnerNodeGovernanceEnabled
+    )
+  },
+  { immediate: true }
+)

Also applies to: 244-251

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/platform/settings/composables/useSettingUI.ts` around lines 1 - 7, Update
the exposure telemetry watcher in useSettingUI to watch only
shouldShowWorkspacePanel, not flags.partnerNodeGovernanceEnabled. Read the
current flag value inside the watcher callback so flag changes while the panel
remains visible do not re-emit telemetry, while visibility transitions retain
the existing behavior.

@huang47
huang47 force-pushed the codex/datadog-partner-governance-flag branch from 2ab4e1b to 5211c0b Compare July 29, 2026 18:34
@huang47
huang47 force-pushed the codex/instrument-allowlist-actions branch from 8e9648e to ab08bf0 Compare July 29, 2026 18:35
@huang47
huang47 force-pushed the codex/datadog-partner-governance-flag branch from 5211c0b to 02162e4 Compare July 29, 2026 18:48
@huang47
huang47 force-pushed the codex/instrument-allowlist-actions branch from ab08bf0 to fcb50e7 Compare July 29, 2026 18:49
@huang47
huang47 force-pushed the codex/datadog-partner-governance-flag branch from 02162e4 to 453cc51 Compare July 29, 2026 19:06
@huang47
huang47 force-pushed the codex/instrument-allowlist-actions branch from fcb50e7 to 5171528 Compare July 29, 2026 19:07
@huang47
huang47 force-pushed the codex/datadog-partner-governance-flag branch from 453cc51 to 77dc41c Compare July 29, 2026 20:30
@huang47
huang47 force-pushed the codex/instrument-allowlist-actions branch from 5171528 to 9277494 Compare July 29, 2026 20:30
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 29, 2026
@huang47

huang47 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@comfydesigner see if the tracking here makes sense to you

Note

Track search, sort, expand, retry, policy clicks, confirmations, and cancellations.
Skip search-forced expansion; count Escape and close dismissals.

@huang47
huang47 force-pushed the codex/instrument-allowlist-actions branch from 9277494 to b0ac82d Compare July 31, 2026 00:31
@huang47
huang47 changed the base branch from codex/datadog-partner-governance-flag to main July 31, 2026 00:31
@huang47
huang47 dismissed coderabbitai[bot]’s stale review July 31, 2026 00:31

The base branch was changed.

@github-actions

Copy link
Copy Markdown
Contributor

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-14273.vercel.app

This commit: https://website-frontend-7tdjwjogq-comfyui.vercel.app

Last updated: 2026-07-31T00:33:15Z for b0ac82d

@huang47

huang47 commented Jul 31, 2026 •

Copy link
Copy Markdown
Contributor Author

Datadog RUM proof from rebased b0ac82d:

  • 4 actions from fe-pr-14273.testenvs.comfy.org matched @feature_flags.partner_node_governance_enabled:*.
  • click on Workspace carries partner_node_governance_enabled: false and full head b0ac82d53de1d9939256822c721fd1a5f53e023e.

The gate is OFF for this account; live proof covers automatic RUM flag attachment. Allowlist action-name coverage is in the 226 passing focused tests.

pr-14273-datadog-actions pr-14273-datadog-feature-flag-detail

Created by Codex

pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Aug 1, 2026
## Summary

Adds one terminal Datadog RUM action for each flag-enabled unified-auth
401 recovery attempt so rollout monitoring can distinguish successful
recovery, persistent authorization failures, re-mint failures, and retry
transport failures.

## Changes

- **What**: Emits `auth.unified.request_retry.succeeded` or
`auth.unified.request_retry.failed` after fetch and Axios 401 recovery,
with only low-cardinality `transport`, `outcome`, `final_status`, and
`failure_reason` context.
- **Root cause**: Resource events show the treatment cohort but cannot
identify whether a 401 was recovered or amplified by the retry path.
Current production baselines include tens of thousands of repeated
401/403 events from fewer than 100 sessions, so raw resource counts
cannot safely drive rollout decisions.
- **Privacy**: Does not emit tokens, authorization headers, request
URLs, response bodies, or user identifiers.
- **Dependencies**: Related to Comfy-Org#14273, which supplies
`unified_cloud_auth` feature-flag attribution. This PR remains
runtime-safe without it; cohort filtering becomes available after both
changes deploy.

## Review Focus

- Exactly one lifecycle action is emitted per initial 401 that enters
the unified retry path.
- Flag-off and non-401 traffic remain telemetry no-ops.
- Persistent 401s and transport failures preserve the existing
response/error behavior.

## Verification

- `pnpm test:unit src/platform/auth/unified/remintRetry.test.ts
src/platform/telemetry/TelemetryRegistry.test.ts
src/platform/telemetry/providers/cloud/DatadogRumTelemetryProvider.test.ts`
(40 tests)
- `pnpm typecheck`
- Targeted ESLint on all changed files

## Screenshots (if applicable)

Not applicable; telemetry-only change with no UI impact.

Co-authored-by: dante01yoon <dante01yoon@users.noreply.github.com>
Co-authored-by: Amp <amp@ampcode.com>
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Aug 12, 2026
## Summary

Restyles the workspace partner node governance panel to the new Partner
Models design (workspace settings parity with the platform.comfy.org
governance UX).

## Changes

- **What**:
- Replace the Unrestricted/Restricted segmented control with an **Allow
all partner models** toggle card; while restricted, the helper line
carries a warning icon and explains that later-published partner models
stay blocked until a workspace owner enables them
  - Rename the settings tab **Allowlist → Partner Models**
- Table: **Models** column is a static `{n} models` count in both modes;
new sortable **State** column with per-provider toggles rendered only
while restricted (width always reserved, so columns never shift); pinned
header and footer with rows scrolling between them; table is no longer
dimmed/inert while allow-all is on (rows stay explorable)
- Replace the Enable all / Disable all buttons with a **Disable all ▾**
menu whose items carry scope counts (`Disable all 36 providers` /
`Enable 4 matching providers`); with a search active, bulk actions apply
to matching providers only; no-op items are disabled
- Add an allowed-models summary under the table (`All partner models
allowed` / `214 partner models allowed`)
- Search: providers match by name or model name, nothing auto-expands
(chevron is always user-controlled); rows narrowed by the query show `3
of 7 match` in the Models column, full-relevance rows keep the plain
count
- Static table geometry: sticky in-scroller header (fixes a pre-existing
scrollbar-width misalignment from Comfy-Org#13951), full-height card, reserved
scrollbar gutter — no layout shift on expand/collapse/mode change
- New `setProvidersEnabled(providerIds, enabled)` store action for
search-scoped bulk edits
- Partner-models vocabulary sweep across `workspacePanel.partnerNodes`
strings
- **Enterprise upsell (gated state)**: workspaces whose policy access
403s but whose catalog loads render the tab read-only with a muted crown
on the nav item, an Enterprise pill + Contact us on the access card, and
a confirm-dialog upsell when the locked toggle is clicked. Store keeps
the provider catalog when only the policy fetch is forbidden; `NavItem`
gains an optional `suffixIcon`.
- **Breaking**: none — policy API payloads and enforcement semantics
unchanged

## Review Focus

- Unfiltered *Disable all N providers* still confirms via dialog;
search-scoped bulk applies immediately (scope is explicit in the item
label)
- Access-mode flips now **remember provider states** (per design
annotation): first-ever restriction defaults all providers on;
thereafter, disabling BFL, allowing all, and restricting again leaves
BFL disabled. Returning to allow-all no longer resets stored states —
behavior change vs the shipped store, FE-only (the full policy is
persisted either way)
- Analytics in Comfy-Org#14273 instruments the previous control set and will need
a rebase
- Confirm-dialog components (`ConfirmHeader/Body/Footer`,
`showConfirmDialog`) restyled to the Modal/Small design spec — 512px
width, rounded-2xl, `border-default`, 14px regular title, muted Cancel,
16px section padding. **This affects every `showConfirmDialog` caller
app-wide** (visual only; behavior unchanged)

Design: [Team Plan / Workspaces — Partner Models
settings](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Team-Plan---Workspaces?node-id=5732-53942)

Linear: Part of DES-685 and DES-641 · implementation counterpart FE-1525

---------

Co-authored-by: Claude <noreply@anthropic.com>

huang47 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Closing the Allowlist action instrumentation because there is no confirmed product/design consumer for these events. The reusable feature-flag telemetry work remains separately in #14279.

@huang47 huang47 closed this Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant