Repository navigation
feat: restyle partner model governance settings panel - #14837
Conversation
🎭 Playwright: ✅ 1787 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.68 MB gzip 🔴 +1.39 kBDetailsSummary
Category Glance App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.36 MB (baseline 1.36 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 3 unchanged Panels & Settings — 570 kB (baseline 570 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 4 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 67.1 kB (baseline 67.1 kB) • 🟢 -21 BReusable component library chunks
Status: 10 added / 10 removed / 4 unchanged Data & Services — 3.5 MB (baseline 3.49 MB) • 🔴 +8.6 kBStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 547 kB (baseline 547 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 17 unchanged Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 14 MB (baseline 14 MB) • 🟢 -2.51 kBBundles that do not match a named category
Status: 87 added / 87 removed / 199 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-08T18:34:24.431Z",
"gitSha": "bb50c31c31a12e7522d97cc734dec4f650d5117e",
"branch": "comfydesigner/partner-models-governance-v2",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.3740000000325,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.199000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.79400000000004,
"heapDeltaBytes": 5951572,
"heapUsedBytes": 70287792,
"domNodes": 16,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 20.176,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2003.6010000000033,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.9170000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.41600000000005,
"heapDeltaBytes": 5966232,
"heapUsedBytes": 70256652,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 20.630999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1728.8969999999608,
"styleRecalcs": 71,
"styleRecalcDurationMs": 26.492999999999995,
"layouts": 12,
"layoutDurationMs": 2.8520000000000003,
"taskDurationMs": 732.448,
"heapDeltaBytes": -14405672,
"heapUsedBytes": 49921548,
"domNodes": -279,
"jsHeapTotalBytes": 23306240,
"scriptDurationMs": 99.46900000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1719.3429999999807,
"styleRecalcs": 73,
"styleRecalcDurationMs": 30.704,
"layouts": 12,
"layoutDurationMs": 2.944,
"taskDurationMs": 728.087,
"heapDeltaBytes": 93892,
"heapUsedBytes": 64279124,
"domNodes": 57,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 101.282,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1685.6010000000197,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.336,
"layouts": 6,
"layoutDurationMs": 0.528,
"taskDurationMs": 339.639,
"heapDeltaBytes": 8224164,
"heapUsedBytes": 72524240,
"domNodes": 78,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 20.848,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1699.9809999999798,
"styleRecalcs": 29,
"styleRecalcDurationMs": 17.227,
"layouts": 6,
"layoutDurationMs": 0.6619999999999999,
"taskDurationMs": 380.525,
"heapDeltaBytes": 8219200,
"heapUsedBytes": 72544548,
"domNodes": 77,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 23.819,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 592.4210000000016,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.483999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.50800000000004,
"heapDeltaBytes": -11166520,
"heapUsedBytes": 53158684,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 55.004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 538.2779999999912,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.782000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.347,
"heapDeltaBytes": -10977356,
"heapUsedBytes": 53216176,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 49.326,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2021.2649999999712,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.871000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.245,
"heapDeltaBytes": 7523732,
"heapUsedBytes": 67469608,
"domNodes": -278,
"jsHeapTotalBytes": 3248128,
"scriptDurationMs": 94.659,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2015.4479999999921,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.744,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 654.481,
"heapDeltaBytes": 6658844,
"heapUsedBytes": 66293044,
"domNodes": -282,
"jsHeapTotalBytes": 3248128,
"scriptDurationMs": 101.53799999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2074.92000000002,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.057,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1028.099,
"heapDeltaBytes": 3283456,
"heapUsedBytes": 64218008,
"domNodes": -282,
"jsHeapTotalBytes": 3964928,
"scriptDurationMs": 328.178,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2091.4670000000797,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.03,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1030.5110000000002,
"heapDeltaBytes": 2157456,
"heapUsedBytes": 64791792,
"domNodes": -283,
"jsHeapTotalBytes": 4227072,
"scriptDurationMs": 337.358,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3186.776000000009,
"styleRecalcs": 67,
"styleRecalcDurationMs": 16.434,
"layouts": 60,
"layoutDurationMs": 7.357000000000001,
"taskDurationMs": 1305.85,
"heapDeltaBytes": -4918112,
"heapUsedBytes": 59283052,
"domNodes": -284,
"jsHeapTotalBytes": 6393856,
"scriptDurationMs": 444.34000000000003,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3120.739999999955,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.057,
"layouts": 60,
"layoutDurationMs": 7.353,
"taskDurationMs": 1283.974,
"heapDeltaBytes": 23475492,
"heapUsedBytes": 86151228,
"domNodes": 16,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 463.666,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.3450000000294,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.452999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.263,
"heapDeltaBytes": 6600252,
"heapUsedBytes": 67169680,
"domNodes": -284,
"jsHeapTotalBytes": 3772416,
"scriptDurationMs": 98.04400000000001,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2019.5730000000367,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.364000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.176,
"heapDeltaBytes": 7305736,
"heapUsedBytes": 68196860,
"domNodes": -283,
"jsHeapTotalBytes": 2461696,
"scriptDurationMs": 95.20200000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 532.0790000000102,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.969000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.745,
"heapDeltaBytes": -11003040,
"heapUsedBytes": 53560996,
"domNodes": 22,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 96.65899999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 547.5900000000138,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.385,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 340.101,
"heapDeltaBytes": -10996916,
"heapUsedBytes": 53563376,
"domNodes": 20,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 98.232,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.3520000000162,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.139000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.38,
"heapDeltaBytes": -18129844,
"heapUsedBytes": 46314876,
"domNodes": -281,
"jsHeapTotalBytes": 22781952,
"scriptDurationMs": 14.028,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2011.918000000037,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.536999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.48199999999997,
"heapDeltaBytes": -18749684,
"heapUsedBytes": 45572588,
"domNodes": 1,
"jsHeapTotalBytes": 22781952,
"scriptDurationMs": 16.579,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1738.7320000000273,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.957,
"layouts": 16,
"layoutDurationMs": 3.754,
"taskDurationMs": 709.76,
"heapDeltaBytes": -17683664,
"heapUsedBytes": 46607568,
"domNodes": -280,
"jsHeapTotalBytes": 23044096,
"scriptDurationMs": 77.88999999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.18699999999,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.151999999999997,
"layouts": 16,
"layoutDurationMs": 3.5260000000000002,
"taskDurationMs": 697.693,
"heapDeltaBytes": -17756956,
"heapUsedBytes": 46767300,
"domNodes": -279,
"jsHeapTotalBytes": 22781952,
"scriptDurationMs": 80.41900000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1183.3259999999655,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.981,
"layouts": 15,
"layoutDurationMs": 9.685,
"taskDurationMs": 805.9580000000002,
"heapDeltaBytes": 8228060,
"heapUsedBytes": 100338804,
"domNodes": 13673,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 27.880000000000003,
"eventListeners": 2375,
"totalBlockingTimeMs": 85,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8224.321999999973,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.114000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3985.573,
"heapDeltaBytes": 14967692,
"heapUsedBytes": 74604568,
"domNodes": -282,
"jsHeapTotalBytes": 9207808,
"scriptDurationMs": 1268.3999999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8106.56199999994,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.188,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3747.9869999999996,
"heapDeltaBytes": 28188168,
"heapUsedBytes": 88083132,
"domNodes": -278,
"jsHeapTotalBytes": 4227072,
"scriptDurationMs": 1085.808,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14917.014999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14896.483,
"heapDeltaBytes": -51810432,
"heapUsedBytes": 164059860,
"domNodes": -8312,
"jsHeapTotalBytes": -10690560,
"scriptDurationMs": 483.35100000000006,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14982.083999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14965.201000000001,
"heapDeltaBytes": -48544532,
"heapUsedBytes": 159680612,
"domNodes": -8312,
"jsHeapTotalBytes": -12259328,
"scriptDurationMs": 488.533,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17727.777000000002,
"styleRecalcs": 124,
"styleRecalcDurationMs": 14.967000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17700.993,
"heapDeltaBytes": -37189712,
"heapUsedBytes": 176684636,
"domNodes": -8312,
"jsHeapTotalBytes": -10989568,
"scriptDurationMs": 745.9449999999999,
"eventListeners": -16385,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17396.300999999992,
"styleRecalcs": 120,
"styleRecalcDurationMs": 15.148999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17358.27,
"heapDeltaBytes": -47744044,
"heapUsedBytes": 176809004,
"domNodes": -8312,
"jsHeapTotalBytes": -10760192,
"scriptDurationMs": 734.042,
"eventListeners": -16383,
"totalBlockingTimeMs": 62,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 457.25299999998015,
"styleRecalcs": 15,
"styleRecalcDurationMs": 29.152000000000005,
"layouts": 4,
"layoutDurationMs": 2.085,
"taskDurationMs": 123.78000000000002,
"heapDeltaBytes": 5322788,
"heapUsedBytes": 68754192,
"domNodes": 134,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.155,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 474.97899999996207,
"styleRecalcs": 14,
"styleRecalcDurationMs": 16.089,
"layouts": 3,
"layoutDurationMs": 0.513,
"taskDurationMs": 107.978,
"heapDeltaBytes": 5121420,
"heapUsedBytes": 68679212,
"domNodes": 125,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 17.230000000000004,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe partner model settings panel now uses model terminology, switch-based access control, provider bulk actions, model counts, sorting, filtering, and responsive layouts. The governance store adds batch provider updates. Tests cover the revised controls and states. ChangesPartner model access
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
actor WorkspaceOwner
participant PartnerNodeAccessPanel
participant partnerNodeGovernanceStore
participant savePolicy
WorkspaceOwner->>PartnerNodeAccessPanel: Select provider bulk action
PartnerNodeAccessPanel->>partnerNodeGovernanceStore: setProvidersEnabled(providerIds, enabled)
partnerNodeGovernanceStore->>savePolicy: Save updated provider policy
savePolicy-->>partnerNodeGovernanceStore: Return save result
partnerNodeGovernanceStore-->>PartnerNodeAccessPanel: Complete update
PartnerNodeAccessPanel-->>WorkspaceOwner: Show updated provider states
Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/locales/en/main.json`:
- Around line 3117-3118: Update src/locales/en/main.json:3117-3118 to define
singular and plural forms for allowedSummary. In
PartnerNodeAccessPanel.vue:308-319, render the localized summary using
enabledModelCount so one model uses the singular form and multiple models use
the plural form, while keeping the unrestricted summary as a complete localized
message. Add one-model coverage in PartnerNodeAccessPanel.test.ts:390-404.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 44b6bb31-be78-4d7e-b38c-c2253502e3f3
📒 Files selected for processing (4)
src/locales/en/main.jsonsrc/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.test.tssrc/platform/workspace/components/dialogs/settings/PartnerNodeAccessPanel.vuesrc/platform/workspace/stores/partnerNodeGovernanceStore.ts
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #14837 +/- ##
==========================================
+ Coverage 79.36% 79.38% +0.01%
==========================================
Files 1804 1865 +61
Lines 118450 123786 +5336
Branches 35723 37035 +1312
==========================================
+ Hits 94009 98265 +4256
- Misses 23858 24900 +1042
- Partials 583 621 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 451 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Replace the Unrestricted/Restricted segmented control with an Allow all partner models toggle card; rename the settings tab Allowlist -> Partner Models; add a sortable State column with per-provider toggles; replace Enable all/Disable all with a scope-aware Disable all menu; add an allowed-models summary; sweep partnerNodes copy to the partner-models vocabulary. Squashed from the original branch history (was: 593c6a7, d5647f9, 1f5db97, b5ba81d, 2524355, 652675e, 4503626, 5c96bd4, 30288a2) to fold layout/copy corrections into the redesign commit they correct.
Restyle ConfirmHeader/Body/Footer and showConfirmDialog to the Modal/Small design spec: 512px width, rounded-2xl, border-default, 14px regular title, muted Cancel, 16px section padding, lg footer buttons. This affects every showConfirmDialog caller app-wide (visual only; behavior unchanged). Squashed from the original branch history (was: 0e8f91f, 1b48b57).
21f73b4 to
8b3c6a3
Compare
Review feedback addressed + branch history rewrittenFix 1 (blocking) — Fix 2 (non-blocking) — Branch history rewritten (force-pushed)
Verified the rewritten tree is byte-identical to the pre-rewrite tip except for Fixes 1 and 2 ( This was a force-push that rewrote shared branch history (the branch has commits originally authored by both ShihChi Huang's request and Alex Tov's implementation) — local checkouts of this branch need a fresh fetch/reset, and the diff should be re-reviewed from scratch rather than incrementally. Generated by Claude Code |
Workspaces whose policy access 403s but whose catalog loads render the Partner Models tab read-only with a muted crown on the nav item, an Enterprise pill + Contact us on the access card, and a confirm dialog upsell when the locked toggle is clicked. The store keeps the provider catalog when only the policy fetch is forbidden; NavItem gains an optional suffixIcon. Squashed from the original branch history (was: 17235ae, a450261, 04a60a8, 2ae32ab, 332256d, 03cf91b, f3b0700, 48992a3) to fold the follow-on guard/copy/layout corrections into the feature commit they correct.
Move the provider table's header row inside the scrolling container so it stays sticky without the pre-existing scrollbar-width misalignment from #13951; keep provider-name search matches collapsed (only model- name matches auto-expand); make the table card fill the remaining panel height, reserve a stable scrollbar gutter, close the subpixel slit above the sticky header, and mute the row chevrons. Squashed from the original branch history (was: c579be2, 96b729b, c867725, a56e37f, 2ce1814).
Rows narrowed by a search query show "N of M match" in the Models column instead of auto-expanding, and only when the query actually narrows the provider's model list; full-relevance rows keep the plain count. Copy aligned with platform (N of M match). Squashed from the original branch history (was: 3fc84f3, 9bab2cd, 1f47862).
setProvidersEnabled backfilled providers absent from the current policy's payload as enabled:true, so a search-scoped bulk-disable action (Disable all N matching providers) could flip a previously blocked provider back to enabled just because it wasn't in the in-scope id set and had no existing entry. Default the backfill to enabled:false so disabled-by-default holds, matching the store's "later-published partner models stay blocked" behavior. Adds a regression test covering an existing restricted policy plus a search-scoped bulk-disable action, asserting a provider missing from the payload stays disabled.
restrictAccessTitle/Message and allowAllAccessTitle/Message still read "partner nodes" after the partner-models vocabulary sweep. Update the four occurrences to "partner models" and the matching confirm-dialog test assertions.
…e with a non-empty provider list A catalog fetch returning 403 clears partnerNodeGovernanceStore.providers to empty, which is a different state from a policy that legitimately restricts a non-empty provider catalog. Gate the crown badge on both status === 'ineligible' and providers.length > 0 so an empty catalog 403 no longer renders the Enterprise upsell crown. Covers both cases with regression tests: policy-restricted (providers present) shows the crown, catalog-403-cleared (empty providers) does not.
73f0e89 to
69c64ee
Compare
huang47
left a comment
There was a problem hiding this comment.
The PR looks great, visually aligned with the spec, thanks @comfydesigner
|
@comfydesigner Successfully backported to #15181 |
|
@comfydesigner Successfully backported to #15182 |
Summary
Restyles the workspace partner node governance panel to the new Partner Models design (workspace settings parity with the platform.comfy.org governance UX).
Changes
{n} modelscount in both modes; new sortable State column with per-provider toggles rendered only while restricted (width always reserved, so columns never shift); pinned header and footer with rows scrolling between them; table is no longer dimmed/inert while allow-all is on (rows stay explorable)Disable all 36 providers/Enable 4 matching providers); with a search active, bulk actions apply to matching providers only; no-op items are disabledAll partner models allowed/214 partner models allowed)3 of 7 matchin the Models column, full-relevance rows keep the plain countsetProvidersEnabled(providerIds, enabled)store action for search-scoped bulk editsworkspacePanel.partnerNodesstringsNavItemgains an optionalsuffixIcon.Review Focus
ConfirmHeader/Body/Footer,showConfirmDialog) restyled to the Modal/Small design spec — 512px width, rounded-2xl,border-default, 14px regular title, muted Cancel, 16px section padding. This affects everyshowConfirmDialogcaller app-wide (visual only; behavior unchanged)Design: Team Plan / Workspaces — Partner Models settings
Linear: Part of DES-685 and DES-641 · implementation counterpart FE-1525