Repository navigation
Conversation
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎭 Playwright: ⏳ Running...🎨 Storybook: 🚧 Building... |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughChangesThe PR adds Nodes 2.0 settings for compact collapsed nodes and status badge visibility. It preserves expanded node dimensions during collapsed visual updates, synchronizes slot geometry during movement, and improves named widget serialization and restoration. Vue node collapsed-state behavior
Widget serialization compatibility
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant LGraphNodeVue
participant NodeHeader
participant useVueNodeResizeTracking
participant layoutStore
User->>LGraphNodeVue: collapse or expand node
LGraphNodeVue->>NodeHeader: update compact and badge visibility
LGraphNodeVue->>useVueNodeResizeTracking: report visual dimensions
useVueNodeResizeTracking->>layoutStore: batch bounds with preserveSize
layoutStore->>LGraphNodeVue: retain canonical expanded size
Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@browser_tests/tests/creditHelpers.spec.ts`:
- Around line 273-280: Update the width assertion in the relevant creditHelpers
test to import and use MIN_NODE_WIDTH, multiplied by canvasOps.getScale(),
instead of the hardcoded 225 value. Match the equivalent check in resize.spec.ts
while preserving the existing polling and comparison behavior.
In `@src/platform/settings/constants/coreSettings.ts`:
- Around line 1212-1234: Update the locale definitions corresponding to the
settings categories used by Comfy.VueNodes.CompactCollapsedNodes, adding
Categories.Settings entries for CompactCollapsedNodes and every translated
parent/category path expected by SettingGroup.vue after normalization. Preserve
the existing category hierarchy and translation style so nested groups display
localized labels instead of raw PascalCase keys.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 7fd0681f-0720-4424-9081-26d22dc08842
📒 Files selected for processing (21)
browser_tests/fixtures/ComfyPage.tsbrowser_tests/tests/creditHelpers.spec.tsbrowser_tests/tests/vueNodes/interactions/node/move.spec.tsbrowser_tests/tests/vueNodes/interactions/node/resize.spec.tssrc/lib/litegraph/src/LGraphNode.test.tssrc/lib/litegraph/src/LGraphNode.tssrc/locales/en/settings.jsonsrc/platform/settings/constants/coreSettings.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/core/layout/store/layoutStore.tssrc/renderer/core/layout/types.tssrc/renderer/extensions/vueNodes/components/LGraphNode.test.tssrc/renderer/extensions/vueNodes/components/LGraphNode.vuesrc/renderer/extensions/vueNodes/components/NodeHeader.test.tssrc/renderer/extensions/vueNodes/components/NodeHeader.vuesrc/renderer/extensions/vueNodes/composables/useSlotElementTracking.test.tssrc/renderer/extensions/vueNodes/composables/useSlotElementTracking.tssrc/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking.test.tssrc/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking.tssrc/renderer/extensions/vueNodes/interactions/resize/resizeHandleConfig.tssrc/schemas/apiSchema.ts
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/lib/litegraph/src/LGraphNode.test.ts (1)
683-716: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winRestore
LiteGraph.vueNodesModeafter the test.This test enables the shared
LiteGraph.vueNodesModeflag, but the shown cleanup only restorestitle_mode. Later measurement tests can therefore run in Vue mode and become order-dependent. Capture the previous value and restore it infinally(or reset it in test setup).Suggested cleanup
+const previousVueNodesMode = LiteGraph.vueNodesMode +try { LiteGraph.vueNodesMode = true ... +} finally { + LiteGraph.vueNodesMode = previousVueNodesMode +}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lib/litegraph/src/LGraphNode.test.ts` around lines 683 - 716, Restore the shared LiteGraph.vueNodesMode flag after each Vue-mode test. Capture its previous value before enabling it and restore it in a finally block, including the parameterized test around nodeConstructor.title_mode, while preserving the existing title_mode cleanup.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/lib/litegraph/src/LGraphNode.test.ts`:
- Around line 683-716: Restore the shared LiteGraph.vueNodesMode flag after each
Vue-mode test. Capture its previous value before enabling it and restore it in a
finally block, including the parameterized test around
nodeConstructor.title_mode, while preserving the existing title_mode cleanup.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 406be3a9-88bc-4d7e-a348-fcafe29f7e6e
📒 Files selected for processing (2)
src/lib/litegraph/src/LGraphNode.test.tssrc/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking.test.ts
|
@coderabbitai review |
✅ Action performedReview finished.
|
4f81dcf to
a69ff10
Compare
a69ff10 to
4f81dcf
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
src/lib/litegraph/src/LGraphNode.ts (3)
1077-1089: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winUse a dense index for legacy widget values.
The legacy restore loop skips
serialize === falsewidgets and readsinfo.widgets_valuesdensely. This serializer writes values at the original widget index. If a non-serialized widget precedes a serialized widget, the serialized array becomes sparse and the value restores asnullafter a JSON round-trip.Use a separate index that increments only for serialized widgets. Add a regression test for this ordering.
Proposed fix
o.widgets_values = [] o.widgets_values_named = {} - for (const [i, widget] of widgets.entries()) { + let serializedIndex = 0 + for (const widget of widgets) { if (widget.serialize === false) continue const val = widget.value const serialisedVal = val != null && typeof val === 'object' ? JSON.parse(JSON.stringify(val)) : (val ?? null) - o.widgets_values[i] = serialisedVal + o.widgets_values[serializedIndex++] = serialisedVal o.widgets_values_named[widget.name] = serialisedVal }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lib/litegraph/src/LGraphNode.ts` around lines 1077 - 1089, Update the widget serialization loop in LGraphNode serialization to use a separate dense index for widgets_values, incrementing it only when widget.serialize is not false, while keeping widgets_values_named keyed by widget.name. Add a regression test covering a non-serialized widget before a serialized widget and verify legacy restoration preserves the serialized value.
991-1022: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick winKeep
widgets_values_namedoutside the legacy shadow path.
configure()receivesISerialisedNodedirectly, and nothing validates that the external JSONwidgets_values_namedfield is a record. A truthy non-record can reachdiffNamedValuesShadow()andNamedValuesShadowDiffLoadAggregation, then throw during load configuration. Add a runtime type guard or schema validation before the named-field branch.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lib/litegraph/src/LGraphNode.ts` around lines 991 - 1022, Validate info.widgets_values_named is a record of named widget values before returning it from getNamedValues or entering the named-values branches in configure. Treat invalid truthy values as absent so diffNamedValuesShadow, reportNamedValuesShadowDiff, and restoration only receive valid named-value data, while preserving the existing legacy fallback via fallbackWidgetsValuesNames.Source: Coding guidelines
1077-1090: 🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy liftPreserve and document the
widgets_values_namedworkflow contract.
serialize()emitswidgets_values_namedandconfigure()reads it, so nodes such asSubgraphNodemust not drop this field when rewriting widgets, and node-replacement paths should also restore named widget values. Add migration guidance for extensions that add node widgets throughnode.widgetsand preserve unknown-node widget data. Add a LGraphNode save/load round-trip test insrc/lib/litegraph/src/LGraphNode.test.ts.Document that
widget.serializecontrols workflow persistence andwidget.options.serializeremains the separate prompt/API serialization path.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lib/litegraph/src/LGraphNode.ts` around lines 1077 - 1090, Preserve the widgets_values_named workflow field throughout LGraphNode.serialize(), configure(), SubgraphNode widget rewrites, and node-replacement restoration paths, including unknown-node widget data. Add migration guidance for extensions that append widgets through node.widgets, and document that widget.serialize controls workflow persistence while widget.options.serialize remains the prompt/API path. Add an LGraphNode save/load round-trip test in LGraphNode.test.ts covering named widget values.Sources: Coding guidelines, Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/lib/litegraph/src/LGraphNode.ts`:
- Around line 1077-1089: Update the widget serialization loop in LGraphNode
serialization to use a separate dense index for widgets_values, incrementing it
only when widget.serialize is not false, while keeping widgets_values_named
keyed by widget.name. Add a regression test covering a non-serialized widget
before a serialized widget and verify legacy restoration preserves the
serialized value.
- Around line 991-1022: Validate info.widgets_values_named is a record of named
widget values before returning it from getNamedValues or entering the
named-values branches in configure. Treat invalid truthy values as absent so
diffNamedValuesShadow, reportNamedValuesShadowDiff, and restoration only receive
valid named-value data, while preserving the existing legacy fallback via
fallbackWidgetsValuesNames.
- Around line 1077-1090: Preserve the widgets_values_named workflow field
throughout LGraphNode.serialize(), configure(), SubgraphNode widget rewrites,
and node-replacement restoration paths, including unknown-node widget data. Add
migration guidance for extensions that append widgets through node.widgets, and
document that widget.serialize controls workflow persistence while
widget.options.serialize remains the prompt/API path. Add an LGraphNode
save/load round-trip test in LGraphNode.test.ts covering named widget values.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 7365cf4f-279c-43d7-94c6-bb92fc4779dd
📒 Files selected for processing (3)
src/lib/litegraph/src/LGraphNode.tssrc/locales/en/main.jsonsrc/locales/en/settings.json
|
Verified against the current branch head and fixed the still-valid parts in
Already correct, so left unchanged: the serialized-node type already carries Validation: 123 focused Vitest tests, application typecheck, targeted ESLint, oxfmt check, |
Collapses the twelve reviewed slices of the ECS migration into one commit so the series can be replayed onto main as a unit. Each slice kept its own review on GitHub: - ECS: Moving widgets out of the Node data (#13322) - ECS: Link topology store (single source of truth for link data) (#13436) - ECS: Reroute chain store with derived link membership (#13449) - ECS: derive slot floating links; reroute cleanup follow-ups (#13451) - refactor: read widgeted-input connectivity from linkStore (#13455) - feat: nodeBadgeStore + badge system (slice A) (#13458) - refactor: derive badge rows on read, delete the badge store (#13686) - refactor: host-scoped promoted widget rows (no source traversal) (#13434) - refactor!: delete the output.links runtime mirror (#13479) - refactor!: delete the input.link runtime mirror (#13498) - fix: ECS stack audit fixes (#13528) - refactor!: make nodeDataStore the source of truth for node shell state (#13963) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Amp-Thread-ID: https://ampcode.com/threads/T-019ff78d-80f9-73e1-986a-5e4abc9f9d6a
Split 2/6 of #14480. Stacked on #15001. Fixes cross-subgraph-definition topology contamination: `linkStore`/`rerouteStore` buckets were keyed only by root graph id, but every subgraph definition numbers links from 1 and shares the IO pseudo-node ids (−10/−20). Two definitions under one root therefore shared an origin index and reroute membership — one definition's links joined another definition's reroute chains, driving wrong reroute pruning on configure. Repro: `browser_tests/tests/subgraph/subgraphLinkIdentity.spec.ts` + fixture. Changes: - Adds `GraphScope` (`rootGraphId`, `owningGraphId`) and scopes topology queries, owner-local iteration, and teardown to the graph that directly owns each entity. Root-wide identity lookup remains keyed by `rootGraphId`. - Makes `linkStore`, `rerouteStore`, and `nodeDataStore` the authoritative collision boundaries. Registrations are first-wins; rejected entities remain detached and are not assigned to the requesting owner. - Shares link and reroute ID allocation across a root and its subgraphs. Serialized subgraphs are deduplicated before registration so link, reroute, node, widget, and promoted-widget references are remapped together. - Keeps endpoint swaps, rotations, and removals atomic within `linkStore`: an entire batch is validated before indexes or topology fields change. `LLink` retains the store-held reactive topology object across ID and endpoint updates. - Treats configure payloads as authoritative for their owner by clearing owner-local registrations before rebuilding them, with empty root-bucket pruning. - Derives topology scope from the directly owning graph at callers such as `NodeSlots.vue` and `useProcessedWidgets.ts`. - Positions promoted DOM widgets immediately on mount instead of waiting for a watched value to change. - Removes redundant graph-local collision checks, floating-link ID bookkeeping, unreachable tuple deduplication, obsolete compatibility types, and mock-only tests. - Documents root-vs-owner query guidance, topology transaction boundaries, and the deferred measurement of root-wide group scans before introducing another persistent index. Behavior notes: - Constructing or configuring an `LGraph` from serialized data requires an active Pinia because entities register with topology stores during deserialization. - Runtime duplicate IDs are rejected by the root-scoped store; persisted collisions are remapped before object registration. - Registration failures remain explicit return values and do not throw errors. --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com>
Centralizes entity layout ownership and command submission on top of #15009's graph identity, collision, and teardown boundaries. Nodes, groups, and reroutes now hold instance-bound `{ graphId, id }` attachments. Only the attached instance can mutate canonical geometry; stale instances become inert without delete/recreate compensation. Changes: - Replaces ID-derived registration with `graphLayoutAttachment.ts`, covering attach, adopt, detach, geometry writes, and batched teardown. - Acquires reroute topology/map ownership before layout ownership, so collision losers cannot adopt incumbent geometry. - Centralizes group ID allocation at creation through the graph-state high-water mark. - Uses deep Yjs observation and emits geometry invalidation once per transaction, including group- and reroute-only changes. - Queues listener delivery after committed store writes, allowing nested observer mutations as ordinary follow-up transactions. - Requires mutation producers to supply `LayoutSource`; the store stamps its session actor at submission. DOM measurement conventions are explicit rather than ambient process state. - Narrows `useLayoutMutations` to its four production behaviors and removes redundant command `entity`, operation ID, and apply-result fields. - Makes node layout refs read-only and updates migration documentation to match the command/attachment boundary. Review focus: - Attachment lifetime and stale-instance isolation in `graphLayoutAttachment.ts`. - Root versus partial-subgraph teardown through #15009's centralized lifecycle. - Topology-before-layout ordering in `_addReroute`. - Explicit source/measurement semantics at mutation call sites. - Transaction and notification timing in `layoutStore.ts`. Validation: - Full GitHub CI passed, including unit tests, all Playwright shards, type/lint/format checks, Storybook, and performance tests. - The branch is net −170 lines against `feature/ecs-migration`. --------- Co-authored-by: Amp <amp@ampcode.com>
Retargeted squash: resize gestures write intent to the store, node size binds from the store instead of imperative CSS var writes, DOM measurement stays out of the replicated document, and the collapse-save width-loss repro lands as e2e coverage. Amends ADR 0003 accordingly.
6aa8874 to
fd7677a
Compare
There was a problem hiding this comment.
Pull request overview
Ports the opt-in Nodes 2.0 “compact collapsed” and “hide status badges” display settings onto the ECS-based layout/rendering pipeline while keeping default rendering unchanged, and adjusts layout/serialization plumbing to separate requested geometry from DOM-measured geometry.
Changes:
- Add two new settings (
Comfy.VueNodes.CompactCollapsedNodes,Comfy.VueNodes.HideStatusBadges) and wire them into Vue node header/collapsed rendering. - Introduce a local-only
contentSizestier in the layout store and route DOM measurement updates through it (instead of overwriting requested layout size). - Improve widget value serialization/restore compatibility (dense legacy arrays +
widgets_values_named), and extend replacement/subgraph logic to handle named values.
Reviewed changes
Copilot reviewed 38 out of 42 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/schemas/apiSchema.ts | Adds the two new Vue Nodes settings to the settings schema. |
| src/renderer/extensions/vueNodes/interactions/resize/useNodeResize.ts | Adds resize lifecycle hooks and pointercancel cleanup. |
| src/renderer/extensions/vueNodes/interactions/resize/useNodeResize.test.ts | Extends resize tests for pointercancel + lifecycle callbacks. |
| src/renderer/extensions/vueNodes/interactions/resize/resizeHandleConfig.ts | Moves resize handles inside node bounds (class adjustments). |
| src/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking.ts | Reports DOM-measured content size instead of mutating node bounds. |
| src/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking.test.ts | Updates tests for the new content-size reporting path. |
| src/renderer/extensions/vueNodes/composables/useSlotElementTracking.ts | Caches slot offsets and drops stale layouts when offsets are missing. |
| src/renderer/extensions/vueNodes/composables/useSlotElementTracking.test.ts | Adds coverage for slot translation on node/group movement and collapsed offsets. |
| src/renderer/extensions/vueNodes/components/NodeHeader.vue | Adds compact + showStatusBadge props and conditional badge rendering. |
| src/renderer/extensions/vueNodes/components/NodeHeader.test.ts | Adds tests for independent status badge visibility and pin retention. |
| src/renderer/extensions/vueNodes/components/LGraphNode.vue | Applies settings to collapsed rendering, routes resize into ECS mutations, and adjusts sizing behavior. |
| src/renderer/extensions/vueNodes/components/LGraphNode.test.ts | Updates expectations for collapsed sizing behavior and DOM vars. |
| src/renderer/core/layout/store/layoutStore.ts | Adds local-only contentSizes map with clearGraph/reset handling. |
| src/renderer/core/layout/store/layoutStore.test.ts | Verifies contentSizes are root-graph scoped and cleared correctly. |
| src/renderer/core/layout/store/mocks/layoutStore.ts | Extends layoutStore mock with contentSizeOf. |
| src/renderer/core/layout/operations/layoutMutations.ts | Adds resizeNode mutation helper. |
| src/renderer/core/layout/operations/layoutMutations.test.ts | Adds tests for resizeNode and resets layout store between tests. |
| src/platform/settings/constants/coreSettings.ts | Registers the two new settings in the core settings catalog. |
| src/platform/nodeReplacement/useNodeReplacement.ts | Transfers widget values via named values when positional metadata is absent. |
| src/platform/nodeReplacement/useNodeReplacement.test.ts | Adds test coverage for named widget value transfer. |
| src/locales/en/settings.json | Adds localized labels/tooltips for the new settings. |
| src/locales/en/main.json | Adds localized labels for Nodes 2.0 subgroup/category names. |
| src/lib/litegraph/src/types/serialisation.ts | Adds TSerializedWidgetValue + isNamedWidgetValues guard; allows null in serialized values. |
| src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts | Adds coverage for named values alignment and null serialization behavior. |
| src/lib/litegraph/src/subgraph/SubgraphNode.ts | Validates named values and serializes promoted widget values by name/dense array. |
| src/lib/litegraph/src/LGraphNode.widgetOrder.test.ts | Ensures inherited/invalid named values don’t corrupt widget restore ordering. |
| src/lib/litegraph/src/LGraphNode.ts | Separates requested vs rendered size via content-size tier; tightens named value restore/serialization. |
| src/lib/litegraph/src/LGraphNode.test.ts | Adds tests for dense serialization + Vue collapsed measurement behavior + non-serialization of measured size. |
| src/lib/litegraph/src/LGraphNode.namedValuesShadowDiff.test.ts | Ensures invalid named values are ignored without shadow-diff reporting. |
| docs/WIDGET_SERIALIZATION.md | Documents dense widget serialization and named restore guidance. |
| docs/adr/0003-crdt-based-layout-system.md | ADR amendment formalizing “intent vs measurement” split. |
| browser_tests/tests/vueNodes/nodeStates/collapse.spec.ts | Adds E2E coverage for width persistence across collapsed save/reload. |
| browser_tests/tests/vueNodes/interactions/node/resize.spec.ts | Adds E2E coverage for resize persistence, hit-testing, and compact-collapse size invariants. |
| browser_tests/tests/vueNodes/interactions/node/move.spec.ts | Adds E2E coverage for link geometry staying attached during collapsed node/group drags. |
| browser_tests/tests/dialogs/settingsDialog.spec.ts | Ensures settings search finds new settings via translated Nodes 2.0 group. |
| browser_tests/tests/creditHelpers.spec.ts | Verifies pricing/status badges behavior across compact + hideStatus matrices and live toggles. |
| browser_tests/fixtures/utils/vueNodeFixtures.ts | Adjusts resize drag start point to avoid NW handle/collapse overlap. |
| browser_tests/fixtures/ComfyPage.ts | Sets default values for the new settings in the E2E fixture baseline. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| const nodeSizeStyle = computed(() => | ||
| isCollapsed.value | ||
| ? {} | ||
| : { | ||
| '--node-width': `${size.value.width}px`, | ||
| '--node-height': `${size.value.height + LiteGraph.NODE_TITLE_HEIGHT}px` | ||
| } | ||
| ) |
| "Nodes 2_0": "Nodes 2.0", | ||
| "VueNodesEnabled": "Modern Node Design", | ||
| "CompactCollapsedNodes": "Compact Collapsed Nodes", | ||
| "HideStatusBadges": "Hidden Status Badges", |
| ## Gotchas | ||
|
|
||
| - `addWidget('combo', name, value, cb, { serialize: false })` puts `serialize` into `widget.options`, **not** onto `widget` directly. These are different properties consumed by different systems. | ||
| - `LGraphNode.serialize()` checks `widget.serialize === false` (line 967). It does **not** check `widget.options.serialize`. A widget with `options.serialize = false` is still included in `widgets_values`. |
ef435ab to
20cd48c
Compare
Depends on: #14258.
Summary
Port the opt-in Nodes 2.0 compact-collapsed and status-badge display settings onto ECS without changing default rendering.
Changes
Comfy.VueNodes.CompactCollapsedNodesandComfy.VueNodes.HideStatusBadges, both disabled by default.Review Focus
Testing
fd7677a63cde3b55ad779c9b4fd1319f650214f5.pnpm typecheck,pnpm typecheck:browser,pnpm lint,pnpm knip,pnpm format:check, andpnpm buildpassed.5359edb45d4c69e53599a276c9490db1c7ddf4d0.git diff --checkpassed.Screenshots