Repository navigation
Fix Team Workspace seat capacity handling (FE-1497) - #14050
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughWorkspace billing now provides seat capacity and occupancy. Member management and invitation flows use these values instead of a fixed workspace limit. Membership changes refresh billing status, and tests and fixtures cover unavailable, unlimited, and capped capacity. ChangesBilling seat-capacity migration
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant WorkspaceUI
participant BillingContext
participant WorkspaceBillingAPI
participant WorkspaceMembersAPI
WorkspaceUI->>BillingContext: Read maxSeats and occupiedSeats
BillingContext->>WorkspaceBillingAPI: Fetch billing status
WorkspaceUI->>WorkspaceMembersAPI: Submit member change
WorkspaceMembersAPI-->>WorkspaceUI: Return operation result
WorkspaceUI->>BillingContext: Refresh billing status
BillingContext->>WorkspaceBillingAPI: Fetch updated seat data
Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1788 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.25 MB gzip 🔴 +544 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.35 MB (baseline 1.35 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 112 kB (baseline 112 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 15 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 4 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 6 added / 6 removed / 1 unchanged UI Components — 71.1 kB (baseline 70.8 kB) • 🔴 +235 BReusable component library chunks
Status: 6 added / 6 removed / 9 unchanged Data & Services — 3.47 MB (baseline 3.47 MB) • 🔴 +910 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 386 kB (baseline 386 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 16 added / 16 removed / 20 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • 🔴 +1.37 kBBundles that do not match a named category
Status: 70 added / 70 removed / 211 unchanged ⚡ Performance Report
✅ No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-04T22:06:54.747Z",
"gitSha": "5df1eccc6b18ed45223ccb6a8488c2495d5a9d62",
"branch": "account-limits-query",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2035.683000000006,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.278999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.137,
"heapDeltaBytes": 5432148,
"heapUsedBytes": 69366728,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 16.763,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 1997.8169999999977,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.628000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.02199999999993,
"heapDeltaBytes": 5437448,
"heapUsedBytes": 69334888,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 12.764,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1725.137000000018,
"styleRecalcs": 72,
"styleRecalcDurationMs": 27.248,
"layouts": 12,
"layoutDurationMs": 2.957,
"taskDurationMs": 684.361,
"heapDeltaBytes": -14027160,
"heapUsedBytes": 50054956,
"domNodes": -280,
"jsHeapTotalBytes": 23572480,
"scriptDurationMs": 90.37,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1724.8539999999934,
"styleRecalcs": 72,
"styleRecalcDurationMs": 26.977,
"layouts": 12,
"layoutDurationMs": 2.872,
"taskDurationMs": 684.439,
"heapDeltaBytes": -12703088,
"heapUsedBytes": 51511100,
"domNodes": -281,
"jsHeapTotalBytes": 23572480,
"scriptDurationMs": 88.897,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.1709999999835,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.104000000000001,
"layouts": 6,
"layoutDurationMs": 0.5509999999999998,
"taskDurationMs": 295.852,
"heapDeltaBytes": 8693304,
"heapUsedBytes": 72660932,
"domNodes": 77,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 15.296999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.2829999999667,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.300999999999998,
"layouts": 6,
"layoutDurationMs": 0.616,
"taskDurationMs": 295.786,
"heapDeltaBytes": 8479400,
"heapUsedBytes": 72383248,
"domNodes": 77,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 15.577,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 465.1230000000055,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.0589999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 296.90799999999996,
"heapDeltaBytes": -12556036,
"heapUsedBytes": 51572848,
"domNodes": 20,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 43.06,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 481.75699999995913,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.093000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 300.699,
"heapDeltaBytes": -12500728,
"heapUsedBytes": 51534128,
"domNodes": 18,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 44.451,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2005.0110000000245,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.888999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.473,
"heapDeltaBytes": 6523708,
"heapUsedBytes": 66765248,
"domNodes": -280,
"jsHeapTotalBytes": 2990080,
"scriptDurationMs": 77.408,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2020.817999999963,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.682,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.2269999999999,
"heapDeltaBytes": 5446160,
"heapUsedBytes": 65295576,
"domNodes": -281,
"jsHeapTotalBytes": 2203648,
"scriptDurationMs": 73.768,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2103.7639999999556,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.506,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 962.2979999999999,
"heapDeltaBytes": 2860244,
"heapUsedBytes": 63121488,
"domNodes": -283,
"jsHeapTotalBytes": 2658304,
"scriptDurationMs": 307.32300000000004,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2073.2849999999985,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.734000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 993.8019999999999,
"heapDeltaBytes": 3816004,
"heapUsedBytes": 66870860,
"domNodes": -283,
"jsHeapTotalBytes": 3969024,
"scriptDurationMs": 330.96999999999997,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3107.3789999999804,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.749,
"layouts": 60,
"layoutDurationMs": 6.632000000000001,
"taskDurationMs": 1182.251,
"heapDeltaBytes": -8400392,
"heapUsedBytes": 53957500,
"domNodes": -285,
"jsHeapTotalBytes": 5349376,
"scriptDurationMs": 417.613,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3018.0149999999912,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.663,
"layouts": 60,
"layoutDurationMs": 6.848999999999999,
"taskDurationMs": 1158.124,
"heapDeltaBytes": 22267508,
"heapUsedBytes": 86352768,
"domNodes": 20,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 412.391,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2007.7989999999772,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.312999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.1880000000001,
"heapDeltaBytes": 6897528,
"heapUsedBytes": 67070388,
"domNodes": -280,
"jsHeapTotalBytes": 3776512,
"scriptDurationMs": 73.408,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2009.4759999999496,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.441999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.7539999999999,
"heapDeltaBytes": 6634120,
"heapUsedBytes": 67961384,
"domNodes": -282,
"jsHeapTotalBytes": 2727936,
"scriptDurationMs": 73.295,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 505.2699999999959,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.408000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 313.069,
"heapDeltaBytes": -10485444,
"heapUsedBytes": 53743572,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 92.984,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 502.9460000000654,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.138,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.727,
"heapDeltaBytes": -10506548,
"heapUsedBytes": 53639416,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 98.521,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2032.556999999997,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.686,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.829,
"heapDeltaBytes": 5372972,
"heapUsedBytes": 69484964,
"domNodes": 22,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 11.681,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2003.7399999999934,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.635999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.935,
"heapDeltaBytes": 5051036,
"heapUsedBytes": 69284448,
"domNodes": 24,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 11.423,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.493999999991,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.045,
"layouts": 16,
"layoutDurationMs": 3.739,
"taskDurationMs": 589.442,
"heapDeltaBytes": -4059724,
"heapUsedBytes": 60230492,
"domNodes": 61,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 67.48899999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.2350000000201,
"styleRecalcs": 75,
"styleRecalcDurationMs": 25.596999999999998,
"layouts": 16,
"layoutDurationMs": 3.178,
"taskDurationMs": 626.95,
"heapDeltaBytes": -17035976,
"heapUsedBytes": 47245428,
"domNodes": -280,
"jsHeapTotalBytes": 23310336,
"scriptDurationMs": 69.795,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 917.3080000000482,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.851999999999997,
"layouts": 15,
"layoutDurationMs": 9.018999999999998,
"taskDurationMs": 711.0180000000001,
"heapDeltaBytes": 30541668,
"heapUsedBytes": 96940680,
"domNodes": 13673,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 21.296999999999997,
"eventListeners": 2373,
"totalBlockingTimeMs": 82,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8101.479999999981,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.48,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3344.9999999999995,
"heapDeltaBytes": 10365460,
"heapUsedBytes": 70066364,
"domNodes": -282,
"jsHeapTotalBytes": 5804032,
"scriptDurationMs": 1014.321,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8107.246999999972,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.090999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3338.4179999999997,
"heapDeltaBytes": 7495240,
"heapUsedBytes": 66768200,
"domNodes": -282,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 1009.2079999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14013.112999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13960.009999999998,
"heapDeltaBytes": -59953524,
"heapUsedBytes": 165497148,
"domNodes": -8312,
"jsHeapTotalBytes": -9637888,
"scriptDurationMs": 430.245,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 13934.483999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13895.193000000001,
"heapDeltaBytes": -37411148,
"heapUsedBytes": 167637432,
"domNodes": -8312,
"jsHeapTotalBytes": -10686464,
"scriptDurationMs": 449.91499999999996,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 16873.563000000046,
"styleRecalcs": 115,
"styleRecalcDurationMs": 13.591999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16848.122,
"heapDeltaBytes": -41516788,
"heapUsedBytes": 164239116,
"domNodes": -8312,
"jsHeapTotalBytes": -11210752,
"scriptDurationMs": 702.018,
"eventListeners": -16387,
"totalBlockingTimeMs": 69,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16872.052999999938,
"styleRecalcs": 118,
"styleRecalcDurationMs": 13.493000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16836.642,
"heapDeltaBytes": -64300008,
"heapUsedBytes": 162977608,
"domNodes": -8312,
"jsHeapTotalBytes": -1515520,
"scriptDurationMs": 713.6819999999999,
"eventListeners": -16387,
"totalBlockingTimeMs": 17,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 437.3719999999821,
"styleRecalcs": 15,
"styleRecalcDurationMs": 19.679000000000002,
"layouts": 3,
"layoutDurationMs": 0.5329999999999999,
"taskDurationMs": 95.49799999999999,
"heapDeltaBytes": 5330128,
"heapUsedBytes": 68420836,
"domNodes": 134,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.866999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 437.27400000000216,
"styleRecalcs": 13,
"styleRecalcDurationMs": 13.643000000000002,
"layouts": 3,
"layoutDurationMs": 0.48300000000000004,
"taskDurationMs": 82.809,
"heapDeltaBytes": 5064592,
"heapUsedBytes": 68314348,
"domNodes": 123,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6.997999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
🎨 Storybook: 🚧 Building... |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #14050 +/- ##
========================================
Coverage 79.58% 79.58%
========================================
Files 1794 1794
Lines 116420 116474 +54
Branches 32844 33695 +851
========================================
+ Hits 92652 92697 +45
- Misses 23216 23219 +3
- Partials 552 558 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
The backend-capacity flow looks consistent, but the current head breaks the cloud member-management E2E suite because its billing-status fixture was not updated for the new response contract. Please update the fixture and get the failing cloud check green.
dante01yoon
left a comment
There was a problem hiding this comment.
Verified the follow-up capacity-mock update. The cloud fixture intercepts /api/billing/status, so it should model the new backend contract independently of backend deployment timing; older-response fail-closed behavior remains a separate compatibility case. The cloud E2E suite and all current checks are now green.
d88395e to
2b498e8
Compare
b6a19ec to
4bc0e20
Compare
4bc0e20 to
279697a
Compare
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/platform/workspace/components/dialogs/settings/MembersPanelContent.test.ts (1)
91-96: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse one capacity-aware test fixture for both component suites.
Both mocks conflate seat capacity with plan identity.
hasMemberSeatsmust distinguish unavailable, unlimited, single-seat, and capped capacity.
src/platform/workspace/components/dialogs/settings/MembersPanelContent.test.ts#L91-L96: replace themockIsOnTeamPlanmapping with a dedicated capacity-aware fixture.src/platform/workspace/components/dialogs/settings/WorkspacePanelContent.test.ts#L27-L30: replace themockHasTeamPlanmapping with the same capacity-aware fixture.As per path instructions, changed Vitest tests must cover unresolved, unlimited, single-seat, occupied-at-limit, refresh failure, mutation refresh, and invite success/failure behavior.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/platform/workspace/components/dialogs/settings/MembersPanelContent.test.ts` around lines 91 - 96, Create one shared capacity-aware test fixture distinguishing unavailable, unlimited, single-seat, and capped capacities, then use it for hasMemberSeats in MembersPanelContent.test.ts at lines 91-96 and for hasTeamPlan in WorkspacePanelContent.test.ts at lines 27-30, replacing the current conflated mock mappings. Update both Vitest suites to cover unresolved, unlimited, single-seat, occupied-at-limit, refresh failure, mutation refresh, and invite success/failure behavior.Source: Path instructions
src/platform/workspace/components/dialogs/settings/MembersPanelContent.vue (1)
11-16: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winHandle unlimited member capacity explicitly.
When
maxSeats === 0, render an unlimited-capacity label instead of passing0toworkspacePanel.members.membersCount, which displays a false zero-seat limit.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/platform/workspace/components/dialogs/settings/MembersPanelContent.vue` around lines 11 - 16, Update the hasMemberSeats rendering in MembersPanelContent so maxSeats === 0 uses the existing unlimited-capacity translation/label instead of workspacePanel.members.membersCount. Preserve the current membersCount interpolation for positive maxSeats.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/workspace/api/workspaceApi.ts`:
- Around line 286-287: Update the workspace API response type around max_seats
and occupied_seats to accept omitted values, then normalize missing fields to
null before returning the response so useWorkspaceBilling receives the expected
unavailable state.
In `@src/platform/workspace/components/dialogs/settings/MembersPanelContent.vue`:
- Around line 178-179: Move the is-single-seat-plan binding from the v-else
MemberListItem to the MemberListItem rendered for the maxSeats === 1 case. Bind
it using the existing single-seat condition so the single-seat row receives the
flag, while preserving the current isOriginalOwner binding and multi-seat
behavior.
- Around line 200-206: Update MembersPanelContent.vue so team-workspace identity
is not derived from hasMemberSeats: treat a null maxSeats as unresolved capacity
rather than no seats, while preserving team member rendering and member/invite
loading. Use a separate workspace-type check for personalWorkspaceMember, and
gate invitations until maxSeats resolves.
In `@src/platform/workspace/components/InviteMembersForm.test.ts`:
- Around line 12-27: The InviteMembersForm tests currently cover only successful
billing refreshes. Add a test using mockFetchStatus from the useBillingContext
mock that rejects after a successful invitation, and assert the submission
completes successfully and the loading state resets; retain fetchStatus
call-count checks only as secondary assertions.
In `@src/platform/workspace/components/SubscriptionSuccessWorkspace.vue`:
- Line 157: Update showInviteBlock in SubscriptionSuccessWorkspace.vue to use
effective maxSeats capacity, treating zero as unlimited, rather than requiring
isTeam; retain the teamWorkspacesEnabled flag requirement. In
src/platform/workspace/components/SubscriptionSuccessWorkspace.test.ts lines
202-204, add a Personal-plan render with maxSeats greater than one and assert
that the invitation form is available.
---
Outside diff comments:
In
`@src/platform/workspace/components/dialogs/settings/MembersPanelContent.test.ts`:
- Around line 91-96: Create one shared capacity-aware test fixture
distinguishing unavailable, unlimited, single-seat, and capped capacities, then
use it for hasMemberSeats in MembersPanelContent.test.ts at lines 91-96 and for
hasTeamPlan in WorkspacePanelContent.test.ts at lines 27-30, replacing the
current conflated mock mappings. Update both Vitest suites to cover unresolved,
unlimited, single-seat, occupied-at-limit, refresh failure, mutation refresh,
and invite success/failure behavior.
In `@src/platform/workspace/components/dialogs/settings/MembersPanelContent.vue`:
- Around line 11-16: Update the hasMemberSeats rendering in MembersPanelContent
so maxSeats === 0 uses the existing unlimited-capacity translation/label instead
of workspacePanel.members.membersCount. Preserve the current membersCount
interpolation for positive maxSeats.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: b777b7fb-e4a3-4625-bcde-653312bf5b82
📒 Files selected for processing (31)
browser_tests/fixtures/data/cloudWorkspace.tsbrowser_tests/tests/billingFacadeConsumers.spec.tsbrowser_tests/tests/currentUserPopoverCredits.spec.tsbrowser_tests/tests/dialogs/creditsTile.spec.tssrc/composables/billing/types.tssrc/composables/billing/useBillingContext.test.tssrc/composables/billing/useBillingContext.tssrc/composables/billing/useLegacyBilling.tssrc/platform/workspace/api/workspaceApi.tssrc/platform/workspace/components/InviteMembersForm.test.tssrc/platform/workspace/components/InviteMembersForm.vuesrc/platform/workspace/components/SubscriptionSuccessWorkspace.test.tssrc/platform/workspace/components/SubscriptionSuccessWorkspace.vuesrc/platform/workspace/components/dialogs/InviteMemberDialogContent.test.tssrc/platform/workspace/components/dialogs/InviteMemberDialogContent.vuesrc/platform/workspace/components/dialogs/RemoveMemberDialogContent.vuesrc/platform/workspace/components/dialogs/RevokeInviteDialogContent.vuesrc/platform/workspace/components/dialogs/settings/MembersPanelContent.test.tssrc/platform/workspace/components/dialogs/settings/MembersPanelContent.vuesrc/platform/workspace/components/dialogs/settings/WorkspacePanelContent.test.tssrc/platform/workspace/components/dialogs/settings/WorkspacePanelContent.vuesrc/platform/workspace/composables/useMembersPanel.test.tssrc/platform/workspace/composables/useMembersPanel.tssrc/platform/workspace/composables/useTeamPlan.test.tssrc/platform/workspace/composables/useTeamPlan.tssrc/platform/workspace/composables/useWorkspaceBilling.test.tssrc/platform/workspace/composables/useWorkspaceBilling.tssrc/platform/workspace/stores/teamWorkspaceStore.test.tssrc/platform/workspace/stores/teamWorkspaceStore.tssrc/storybook/mocks/teamWorkspaceStore.tssrc/storybook/mocks/useBillingContext.ts
💤 Files with no reviewable changes (3)
- src/storybook/mocks/teamWorkspaceStore.ts
- src/platform/workspace/stores/teamWorkspaceStore.test.ts
- src/platform/workspace/stores/teamWorkspaceStore.ts
dante01yoon
left a comment
There was a problem hiding this comment.
The capacity source-of-truth direction is sound, but the current head still breaks both required validation paths: the browser fixture does not match the generated API contract, and rejecting an otherwise valid billing-status payload before storing subscription state makes older responses disable unrelated billing UI rather than only fail-closing invitations. The current lint-and-format and cloud E2E failures reproduce both paths.
3681e8a to
bb0058b
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/workspace/composables/useWorkspaceBilling.ts`:
- Around line 187-199: In
src/platform/workspace/composables/useWorkspaceBilling.ts lines 187-199, update
the seat-capacity handling so invalid or missing max_seats or occupied_seats
assigns null to seatCapacity.value instead of retaining prior values; preserve
the existing object assignment for valid data. In
src/platform/workspace/composables/useWorkspaceBilling.test.ts lines 399-415,
update the incomplete-response assertion to expect null seat capacity,
confirming invitation gating remains disabled until valid capacity is available.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: e3c0102c-2aa2-49bd-a46e-976ac3d3ea31
📒 Files selected for processing (4)
browser_tests/fixtures/data/cloudWorkspace.tssrc/platform/workspace/api/workspaceApi.tssrc/platform/workspace/composables/useWorkspaceBilling.test.tssrc/platform/workspace/composables/useWorkspaceBilling.ts
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/workspace/components/dialogs/settings/MembersPanelContent.vue`:
- Around line 156-162: Treat null maxSeats as unknown capacity: in
MembersPanelContent.vue, gate the synthetic personalWorkspaceMember row and
no-seat upsell on maxSeats === 1 only; in WorkspacePanelContent.vue, fetch
members and pending invites when maxSeats is null while preserving the no-fetch
behavior for known one-seat workspaces. Add null-capacity behavioral coverage in
MembersPanelContent.test.ts for fetched members with the upsell hidden and in
WorkspacePanelContent.test.ts for fetching members and pending invites.
In `@src/platform/workspace/components/SubscriptionCheckoutSteps.stories.ts`:
- Line 219: Update the TeamSuccessWithInvite story and its billing mock state to
provide valid maxSeats and occupiedSeats values, ensuring the
SubscriptionSuccessWorkspace showInviteBlock condition is true and the invite
form renders.
In `@src/platform/workspace/components/SubscriptionSuccessWorkspace.test.ts`:
- Around line 188-199: Replace the data-testid assertions in the personal
upgrade tests with behavior-focused accessible assertions. In the single-seat
case, retain the invite-title absence check and assert the invite UI is not
exposed through its accessible content or form property; in the multi-seat case,
verify the visible “seats:4” text or an equivalent accessible form assertion
instead of targeting `invite-form`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: abbcb3fe-0a97-4381-bc29-f93fb8677d24
📒 Files selected for processing (14)
src/platform/workspace/api/workspaceApi.test.tssrc/platform/workspace/api/workspaceApi.tssrc/platform/workspace/components/InviteMembersForm.test.tssrc/platform/workspace/components/SubscriptionCheckoutSteps.stories.tssrc/platform/workspace/components/SubscriptionRequiredDialogContentUnified.vuesrc/platform/workspace/components/SubscriptionSuccessWorkspace.test.tssrc/platform/workspace/components/SubscriptionSuccessWorkspace.vuesrc/platform/workspace/components/dialogs/settings/MembersPanelContent.test.tssrc/platform/workspace/components/dialogs/settings/MembersPanelContent.vuesrc/platform/workspace/components/dialogs/settings/WorkspacePanelContent.test.tssrc/platform/workspace/components/dialogs/settings/WorkspacePanelContent.vuesrc/platform/workspace/composables/useMembersPanel.tssrc/platform/workspace/composables/useWorkspaceBilling.test.tssrc/platform/workspace/composables/useWorkspaceBilling.ts
💤 Files with no reviewable changes (1)
- src/platform/workspace/components/SubscriptionRequiredDialogContentUnified.vue
Amp-Thread-ID: https://ampcode.com/threads/T-019f8f37-fff0-740f-b6ce-6be9317353d0 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f8f37-fff0-740f-b6ce-6be9317353d0 Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019f8f37-fff0-740f-b6ce-6be9317353d0
Amp-Thread-ID: https://ampcode.com/threads/T-019f8f37-fff0-740f-b6ce-6be9317353d0 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019fc8cd-d12c-776a-b4ad-2217843502e7 Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fc8cd-d12c-776a-b4ad-2217843502e7
Amp-Thread-ID: https://ampcode.com/threads/T-019fc8cd-d12c-776a-b4ad-2217843502e7 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019fc8cd-d12c-776a-b4ad-2217843502e7 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019fcae4-2619-7223-a5da-ac3e0dfe4d94 Co-authored-by: Amp <amp@ampcode.com>
a8542aa to
5b9fb2f
Compare
dante01yoon
left a comment
There was a problem hiding this comment.
Re-reviewed after the branch rebase. The previously addressed capacity-handling changes remain present, there are no unresolved review threads, and all required checks pass on the current head.
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
|
|
…n main The seat-capacity backfill in this branch duplicated the fields #14050 added to the same fixtures, so merging main in produced duplicate object keys. Main already makes typecheck:browser green; this branch is now the CI change alone.
…497) (#14878) ## Summary Manual backport of #14050 and its generated ingest-type prerequisite to `cloud/1.49` after the automated cherry-pick conflicted. ## Changes - **What**: Cherry-picks merge commit `56b9bc1` and preserves the release branch's `isActiveSubscription` API and billing-operation recovery logic while adding backend-provided seat capacity. - **Types**: Includes generated ingest-type sync commit `3dc1734` from cloud API snapshot `9cd6161`, which the original mainline PR was built on and which defines `max_seats` and `occupied_seats`. ## Review Focus Please review the conflict resolutions in `useBillingContext.ts`, `useWorkspaceBilling.ts`, and `useMembersPanel.test.ts`. Validation: - `pnpm test:unit` (10 affected suites, 303 tests; focused rerun after type sync: 154 tests) - `pnpm typecheck` - `pnpm typecheck:browser` - `pnpm format:check` - `pnpm lint` (passes with existing warnings) --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: dante01yoon <6510430+dante01yoon@users.noreply.github.com> Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com> Co-authored-by: huntcsg <6245448+huntcsg@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
Linear
Summary
Make workspace member management trust backend-provided seat capacity so plan limits and workspace overrides are applied consistently, including Personal plans granted multiple seats.
Changes
max_seatsandoccupied_seatsfrom billing status across the members panel, invite dialog, and post-upgrade flow; remove the fixed 30-seat frontend cap; use effective capacity for member eligibility; refresh capacity after seat mutations; fail closed while capacity is unresolved.AS IS / TO BE
Both captures use the real cloud application with the same mocked workspace response: 4 occupied seats, backend
max_seats = 73, and the legacy plan metadata capped at 30.4 of 30)4 of 73)Review Focus
max_seats = 0means unlimited andmax_seats = 1means owner-only.