Repository navigation
[backport cloud/1.49] Fix Team Workspace seat capacity handling (FE-1497) - #14878
Conversation
- [FE-1497: Use backend-provided workspace seat capacity for member management](https://linear.app/comfyorg/issue/FE-1497/use-backend-provided-workspace-seat-capacity-for-member-management) Make workspace member management trust backend-provided seat capacity so plan limits and workspace overrides are applied consistently, including Personal plans granted multiple seats. - **What**: Consume `max_seats` and `occupied_seats` from billing status across the members panel, invite dialog, and post-upgrade flow; remove the fixed 30-seat frontend cap; use effective capacity for member eligibility; refresh capacity after seat mutations; fail closed while capacity is unresolved. Both captures use the real cloud application with the same mocked workspace response: 4 occupied seats, backend `max_seats = 73`, and the legacy plan metadata capped at 30. | AS IS — plan metadata cap (`4 of 30`) | TO BE — backend capacity (`4 of 73`) | | --- | --- | |  |  | - Backend capacity is the only source of truth; `max_seats = 0` means unlimited and `max_seats = 1` means owner-only. - Status refreshes invalidate stale capacity, including during subscription changes. - Backend must deploy before this frontend change; older responses safely leave invitations disabled. --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: dante01yoon <6510430+dante01yoon@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fda29-5c7b-77fc-a092-b132839fc31e
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1785 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-07T03:47:43.775Z",
"gitSha": "6c1958f2e85a1445aa12f7fea06cb1c13bc89244",
"branch": "backport-14050-to-cloud-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.8890000000147,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.456,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.17699999999996,
"heapDeltaBytes": 4971696,
"heapUsedBytes": 73344580,
"domNodes": 20,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 10.488000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2004.9940000000106,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.625000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.323,
"heapDeltaBytes": 5199816,
"heapUsedBytes": 73376248,
"domNodes": 20,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 10.881,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1701.4039999999682,
"styleRecalcs": 71,
"styleRecalcDurationMs": 23.872,
"layouts": 12,
"layoutDurationMs": 2.943,
"taskDurationMs": 532.301,
"heapDeltaBytes": -19202328,
"heapUsedBytes": 48898760,
"domNodes": -280,
"jsHeapTotalBytes": 20168704,
"scriptDurationMs": 73.27799999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1750.7409999999481,
"styleRecalcs": 73,
"styleRecalcDurationMs": 27.944,
"layouts": 12,
"layoutDurationMs": 3.111,
"taskDurationMs": 604.57,
"heapDeltaBytes": -18220304,
"heapUsedBytes": 49885132,
"domNodes": -280,
"jsHeapTotalBytes": 20430848,
"scriptDurationMs": 84.385,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.6229999999919,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.086,
"layouts": 6,
"layoutDurationMs": 0.5369999999999999,
"taskDurationMs": 222.169,
"heapDeltaBytes": 7987240,
"heapUsedBytes": 76054116,
"domNodes": 78,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 11.454,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1681.4150000000154,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.717000000000002,
"layouts": 6,
"layoutDurationMs": 0.608,
"taskDurationMs": 228.63,
"heapDeltaBytes": 7790496,
"heapUsedBytes": 75799392,
"domNodes": 78,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 11.951000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 386.58500000002505,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.633,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 231.99400000000003,
"heapDeltaBytes": -12773200,
"heapUsedBytes": 55482920,
"domNodes": 22,
"jsHeapTotalBytes": 21352448,
"scriptDurationMs": 35.943000000000005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 394.7410000000673,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.283,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 239.566,
"heapDeltaBytes": -12687116,
"heapUsedBytes": 55714328,
"domNodes": 20,
"jsHeapTotalBytes": 22138880,
"scriptDurationMs": 37.169000000000004,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2019.8879999999804,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.582000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.555,
"heapDeltaBytes": 4364332,
"heapUsedBytes": 63564068,
"domNodes": -280,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 49.984,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 1994.7680000000219,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.493999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.528,
"heapDeltaBytes": 7815524,
"heapUsedBytes": 69103724,
"domNodes": -278,
"jsHeapTotalBytes": 3465216,
"scriptDurationMs": 75.068,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2058.573000000024,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.882,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 769.702,
"heapDeltaBytes": 1344304,
"heapUsedBytes": 61596108,
"domNodes": -282,
"jsHeapTotalBytes": 5263360,
"scriptDurationMs": 263.984,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2091.339000000062,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.245,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 922.9559999999999,
"heapDeltaBytes": 16089804,
"heapUsedBytes": 78751120,
"domNodes": -283,
"jsHeapTotalBytes": 4739072,
"scriptDurationMs": 296.737,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3021.3259999999877,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.091000000000001,
"layouts": 60,
"layoutDurationMs": 7.731,
"taskDurationMs": 911.2529999999999,
"heapDeltaBytes": 22224344,
"heapUsedBytes": 85975412,
"domNodes": 20,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 329.104,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3105.066000000079,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.213,
"layouts": 60,
"layoutDurationMs": 7.9689999999999985,
"taskDurationMs": 992.59,
"heapDeltaBytes": -8385244,
"heapUsedBytes": 55304724,
"domNodes": -282,
"jsHeapTotalBytes": 6873088,
"scriptDurationMs": 332.02500000000003,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1988.9009999999985,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.930000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.51899999999995,
"heapDeltaBytes": 8130644,
"heapUsedBytes": 70572464,
"domNodes": -280,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 50.552,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.408999999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.754000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.6580000000001,
"heapDeltaBytes": 142364,
"heapUsedBytes": 60922244,
"domNodes": -282,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 49.50399999999999,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 420.24000000003525,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.344999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 258.24600000000004,
"heapDeltaBytes": -12413404,
"heapUsedBytes": 55947376,
"domNodes": 20,
"jsHeapTotalBytes": 22138880,
"scriptDurationMs": 76.308,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 423.4310000000505,
"styleRecalcs": 49,
"styleRecalcDurationMs": 9.864999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 267.28200000000004,
"heapDeltaBytes": -12196236,
"heapUsedBytes": 56012780,
"domNodes": 24,
"jsHeapTotalBytes": 22138880,
"scriptDurationMs": 80.024,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.371000000011,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.694000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 270.35200000000003,
"heapDeltaBytes": 4933024,
"heapUsedBytes": 73093584,
"domNodes": 20,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 8.101,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2029.1019999999662,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.649000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.468,
"heapDeltaBytes": -22117856,
"heapUsedBytes": 46281528,
"domNodes": -278,
"jsHeapTotalBytes": 19382272,
"scriptDurationMs": 13.411,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1666.9679999999971,
"styleRecalcs": 75,
"styleRecalcDurationMs": 27.082,
"layouts": 16,
"layoutDurationMs": 3.933,
"taskDurationMs": 485.39500000000004,
"heapDeltaBytes": -4326792,
"heapUsedBytes": 63908452,
"domNodes": 60,
"jsHeapTotalBytes": 20566016,
"scriptDurationMs": 66.93700000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1673.9710000000514,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.884,
"layouts": 16,
"layoutDurationMs": 3.831,
"taskDurationMs": 536.443,
"heapDeltaBytes": -4382244,
"heapUsedBytes": 63910216,
"domNodes": 65,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 74.222,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 833.6470000000418,
"styleRecalcs": 19,
"styleRecalcDurationMs": 20.113,
"layouts": 15,
"layoutDurationMs": 8.016,
"taskDurationMs": 552.6389999999999,
"heapDeltaBytes": 8385872,
"heapUsedBytes": 100566952,
"domNodes": 13673,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 17.214000000000006,
"eventListeners": 2373,
"totalBlockingTimeMs": 49,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8079.755999999975,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.457,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2772.4379999999996,
"heapDeltaBytes": 27848616,
"heapUsedBytes": 88661924,
"domNodes": -279,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 911.2529999999999,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8118.058000000019,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.621,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3055.561,
"heapDeltaBytes": 9754360,
"heapUsedBytes": 71055908,
"domNodes": -280,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 974.165,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 10883.398,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10869.527,
"heapDeltaBytes": -35475824,
"heapUsedBytes": 174206724,
"domNodes": -8316,
"jsHeapTotalBytes": -5705728,
"scriptDurationMs": 330.46,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11410.708999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11398.306999999999,
"heapDeltaBytes": -56406084,
"heapUsedBytes": 168104396,
"domNodes": -8312,
"jsHeapTotalBytes": -10948608,
"scriptDurationMs": 357.075,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13709.418000000027,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13678.005,
"heapDeltaBytes": -36054432,
"heapUsedBytes": 170711460,
"domNodes": -8312,
"jsHeapTotalBytes": -14163968,
"scriptDurationMs": 565.706,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 13769.758000000023,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.376999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13755.884999999998,
"heapDeltaBytes": -41061692,
"heapUsedBytes": 178444392,
"domNodes": -8312,
"jsHeapTotalBytes": -3153920,
"scriptDurationMs": 565.7379999999999,
"eventListeners": -16389,
"totalBlockingTimeMs": 10,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 418.645999999967,
"styleRecalcs": 15,
"styleRecalcDurationMs": 17.133,
"layouts": 3,
"layoutDurationMs": 0.567,
"taskDurationMs": 91.59800000000001,
"heapDeltaBytes": -15649096,
"heapUsedBytes": 51885644,
"domNodes": 136,
"jsHeapTotalBytes": 7196672,
"scriptDurationMs": 7.29,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 421.9550000000254,
"styleRecalcs": 14,
"styleRecalcDurationMs": 15.866000000000001,
"layouts": 3,
"layoutDurationMs": 0.6200000000000001,
"taskDurationMs": 87.97000000000001,
"heapDeltaBytes": -15755116,
"heapUsedBytes": 51715744,
"domNodes": 125,
"jsHeapTotalBytes": 7458816,
"scriptDurationMs": 7.154000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.49 #14878 +/- ##
=============================================
Coverage ? 78.77%
=============================================
Files ? 1791
Lines ? 104630
Branches ? 32106
=============================================
Hits ? 82424
Misses ? 21776
Partials ? 430
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
## Automated Ingest API Type Update This PR updates the Ingest API TypeScript types and Zod schemas from the latest cloud OpenAPI specification. - Cloud commit: 9cd6161 - Generated using @hey-api/openapi-ts with Zod plugin These types cover the FE-facing ingest API (workspaces, billing, secrets, assets, tasks, etc.). Cloud's internal / machine-to-machine surface — `x-internal` operations and the `/admin/`, `/api/internal/`, `/api/webhooks/` rails — is stripped before generation (BE-2669), so it is not code-generated into this public package. --------- Co-authored-by: huntcsg <6245448+huntcsg@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019fda29-5c7b-77fc-a092-b132839fc31e Co-authored-by: Amp <amp@ampcode.com>
🌐 Website E2ETip All tests passed.
|
Summary
Manual backport of #14050 and its generated ingest-type prerequisite to
cloud/1.49after the automated cherry-pick conflicted.Changes
56b9bc1and preserves the release branch'sisActiveSubscriptionAPI and billing-operation recovery logic while adding backend-provided seat capacity.3dc1734from cloud API snapshot9cd6161, which the original mainline PR was built on and which definesmax_seatsandoccupied_seats.Review Focus
Please review the conflict resolutions in
useBillingContext.ts,useWorkspaceBilling.ts, anduseMembersPanel.test.ts.Validation:
pnpm test:unit(10 affected suites, 303 tests; focused rerun after type sync: 154 tests)pnpm typecheckpnpm typecheck:browserpnpm format:checkpnpm lint(passes with existing warnings)