Repository navigation
fix: ECS stack audit fixes (store desync, reroute hijack, null preservation, GC) - #13528
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1693 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-07-27T22:55:43.564Z",
"gitSha": "9811b6fc5b8b7518cc3288fbaf10ee57e9b3598a",
"branch": "drjkl/ecs-stack-audit-fixes",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2089.2960000000185,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.931999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.01800000000003,
"heapDeltaBytes": -6574548,
"heapUsedBytes": 63942124,
"domNodes": -274,
"jsHeapTotalBytes": 19025920,
"scriptDurationMs": 25.012,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2054.680000000019,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.439000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.975,
"heapDeltaBytes": 2044416,
"heapUsedBytes": 60287856,
"domNodes": 20,
"jsHeapTotalBytes": 18350080,
"scriptDurationMs": 20.461000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1936.4769999999965,
"styleRecalcs": 75,
"styleRecalcDurationMs": 46.553000000000004,
"layouts": 12,
"layoutDurationMs": 3.5520000000000005,
"taskDurationMs": 888.509,
"heapDeltaBytes": -9741212,
"heapUsedBytes": 60687968,
"domNodes": -206,
"jsHeapTotalBytes": 19025920,
"scriptDurationMs": 131.49099999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1796.1109999999962,
"styleRecalcs": 73,
"styleRecalcDurationMs": 34.936,
"layouts": 12,
"layoutDurationMs": 3.5359999999999996,
"taskDurationMs": 741.666,
"heapDeltaBytes": -4288156,
"heapUsedBytes": 60716328,
"domNodes": 55,
"jsHeapTotalBytes": 23617536,
"scriptDurationMs": 130.267,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1714.1500000000178,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.757,
"layouts": 6,
"layoutDurationMs": 0.714,
"taskDurationMs": 303.186,
"heapDeltaBytes": 2950420,
"heapUsedBytes": 62364252,
"domNodes": 79,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 22.532,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1744.8040000000447,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.702,
"layouts": 6,
"layoutDurationMs": 0.7869999999999999,
"taskDurationMs": 366.848,
"heapDeltaBytes": -3099216,
"heapUsedBytes": 67475504,
"domNodes": -217,
"jsHeapTotalBytes": 14045184,
"scriptDurationMs": 24.819999999999997,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 575.335999999993,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.154000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.988,
"heapDeltaBytes": -1438868,
"heapUsedBytes": 50994248,
"domNodes": -270,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 61.794000000000004,
"eventListeners": -203,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 601.4049999999997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.0600000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.949,
"heapDeltaBytes": -3755204,
"heapUsedBytes": 48355228,
"domNodes": -277,
"jsHeapTotalBytes": 2224128,
"scriptDurationMs": 63.17100000000001,
"eventListeners": -203,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2056.9209999999885,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.156,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 662.347,
"heapDeltaBytes": -21052868,
"heapUsedBytes": 56456384,
"domNodes": -266,
"jsHeapTotalBytes": -2019328,
"scriptDurationMs": 213.614,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2046.057000000019,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.279,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.642,
"heapDeltaBytes": -21457132,
"heapUsedBytes": 56777280,
"domNodes": -269,
"jsHeapTotalBytes": -2019328,
"scriptDurationMs": 209.579,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2138.432000000023,
"styleRecalcs": 68,
"styleRecalcDurationMs": 17.885,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1321.443,
"heapDeltaBytes": 17356956,
"heapUsedBytes": 75401392,
"domNodes": 14,
"jsHeapTotalBytes": 7778304,
"scriptDurationMs": 685.21,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2122.0879999999624,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.967,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1322.91,
"heapDeltaBytes": 17085564,
"heapUsedBytes": 75300076,
"domNodes": 16,
"jsHeapTotalBytes": 6729728,
"scriptDurationMs": 676.1790000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3294.32700000001,
"styleRecalcs": 62,
"styleRecalcDurationMs": 15.642000000000003,
"layouts": 60,
"layoutDurationMs": 7.7459999999999996,
"taskDurationMs": 1589.628,
"heapDeltaBytes": 10805600,
"heapUsedBytes": 66422140,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 837.381,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3284.2509999999834,
"styleRecalcs": 64,
"styleRecalcDurationMs": 18.113999999999997,
"layouts": 60,
"layoutDurationMs": 8.297,
"taskDurationMs": 1633.0830000000003,
"heapDeltaBytes": 17385504,
"heapUsedBytes": 79761188,
"domNodes": 10,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 844.317,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 1994.0470000000232,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.304,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.565,
"heapDeltaBytes": 10214660,
"heapUsedBytes": 80312032,
"domNodes": 16,
"jsHeapTotalBytes": 6610944,
"scriptDurationMs": 201.23100000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2004.7690000000102,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.573999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.6109999999999,
"heapDeltaBytes": 8951404,
"heapUsedBytes": 67550424,
"domNodes": 14,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 208.673,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 571.4900000000398,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.681000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 349.266,
"heapDeltaBytes": 9598936,
"heapUsedBytes": 71201324,
"domNodes": 24,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 126.02,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 565.2380000000221,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.808,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.627,
"heapDeltaBytes": 9943016,
"heapUsedBytes": 69365144,
"domNodes": 18,
"jsHeapTotalBytes": 20971520,
"scriptDurationMs": 132.985,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2027.7450000000385,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.669,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.974,
"heapDeltaBytes": -7589964,
"heapUsedBytes": 62918876,
"domNodes": -269,
"jsHeapTotalBytes": 19025920,
"scriptDurationMs": 15.773999999999996,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2030.5629999999724,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.398000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.339,
"heapDeltaBytes": -7549728,
"heapUsedBytes": 62912232,
"domNodes": -269,
"jsHeapTotalBytes": 18239488,
"scriptDurationMs": 14.975999999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1747.4189999999794,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.597,
"layouts": 16,
"layoutDurationMs": 4.169,
"taskDurationMs": 702.3159999999999,
"heapDeltaBytes": -15987548,
"heapUsedBytes": 54432596,
"domNodes": -224,
"jsHeapTotalBytes": 19812352,
"scriptDurationMs": 91.638,
"eventListeners": -195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1733.8040000000206,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.295,
"layouts": 16,
"layoutDurationMs": 3.925,
"taskDurationMs": 670.9209999999999,
"heapDeltaBytes": 4915432,
"heapUsedBytes": 57162628,
"domNodes": -221,
"jsHeapTotalBytes": 16117760,
"scriptDurationMs": 93.59100000000001,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 932.7690000000075,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.621000000000002,
"layouts": 14,
"layoutDurationMs": 13.989,
"taskDurationMs": 736.8699999999999,
"heapDeltaBytes": 328864,
"heapUsedBytes": 76599988,
"domNodes": 13673,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 23.240999999999996,
"eventListeners": 2533,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8164.756000000011,
"styleRecalcs": 251,
"styleRecalcDurationMs": 56.335,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4676.129000000001,
"heapDeltaBytes": 10666576,
"heapUsedBytes": 81870732,
"domNodes": -266,
"jsHeapTotalBytes": 3080192,
"scriptDurationMs": 2271.2279999999996,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8203.792999999905,
"styleRecalcs": 251,
"styleRecalcDurationMs": 55.547,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4718.192,
"heapDeltaBytes": -3545488,
"heapUsedBytes": 54799416,
"domNodes": -263,
"jsHeapTotalBytes": 8667136,
"scriptDurationMs": 2245.8509999999997,
"eventListeners": -122,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13116.300000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13097.957,
"heapDeltaBytes": -32921088,
"heapUsedBytes": 165489236,
"domNodes": -3300,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 925.4219999999999,
"eventListeners": -16366,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 13261.854999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13245.543999999998,
"heapDeltaBytes": -27379368,
"heapUsedBytes": 168552252,
"domNodes": -3300,
"jsHeapTotalBytes": 14913536,
"scriptDurationMs": 933.7979999999999,
"eventListeners": -16376,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 16479.255000000023,
"styleRecalcs": 105,
"styleRecalcDurationMs": 21.311000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16459.515,
"heapDeltaBytes": -45683396,
"heapUsedBytes": 168451476,
"domNodes": -3300,
"jsHeapTotalBytes": 8622080,
"scriptDurationMs": 1339.545,
"eventListeners": -16376,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16550.415000000045,
"styleRecalcs": 111,
"styleRecalcDurationMs": 22.40000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16530.523,
"heapDeltaBytes": -23650104,
"heapUsedBytes": 172969556,
"domNodes": -3300,
"jsHeapTotalBytes": 8536064,
"scriptDurationMs": 1323.1770000000001,
"eventListeners": -16372,
"totalBlockingTimeMs": 45,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 515.4899999999998,
"styleRecalcs": 18,
"styleRecalcDurationMs": 27.898,
"layouts": 5,
"layoutDurationMs": 1.515,
"taskDurationMs": 210.44299999999998,
"heapDeltaBytes": -21909504,
"heapUsedBytes": 49471928,
"domNodes": -161,
"jsHeapTotalBytes": 4608000,
"scriptDurationMs": 18.474999999999998,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 489.6210000000565,
"styleRecalcs": 15,
"styleRecalcDurationMs": 23.399000000000004,
"layouts": 5,
"layoutDurationMs": 1.4289999999999998,
"taskDurationMs": 151.22999999999996,
"heapDeltaBytes": -2199868,
"heapUsedBytes": 51559260,
"domNodes": -140,
"jsHeapTotalBytes": -921600,
"scriptDurationMs": 17.326,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## feature/ecs-migration #13528 +/- ##
========================================================
Coverage ? 78.59%
========================================================
Files ? 1655
Lines ? 111318
Branches ? 39957
========================================================
Hits ? 87489
Misses ? 22988
Partials ? 841
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Updating Playwright Expectations |
9952026 to
9446519
Compare
859b9d6 to
247a064
Compare
9446519 to
0d9ba7f
Compare
247a064 to
a33e981
Compare
0d9ba7f to
9f6112e
Compare
51ac692 to
53cc9a5
Compare
9f6112e to
f0614c8
Compare
…Comfy-Org#13851) ## Summary Fixes BUG-001b (QA: Ali A-2/A-5): custom-node multiline widgets render but show no value — pythongosssss Show Text and ltdrdata ImpactWildcardProcessor `populated_text` stay blank on 1.47, though the serialized prompt is correct. Works on 1.45.21. ## Changes - **What**: multiline (`customtext`) DOM widgets read their displayed value exclusively from `widgetValueStore` (Vue Nodes; `SafeWidgetData` omits `value`), but `useStringWidget`'s `setValue` only wrote the store `if (widgetState)` — so imperative / execution-time value writes (`widget.value = x` → `domWidget.ts` `set value` → `options.setValue`) never reached the display when no entry existed yet. Serialization stayed correct via the `inputEl.value` fallback in `getValue`, which is why the prompt was right but the node blank. Now `setValue` registers the value when no entry exists. - **Breaking**: none. ## Review Focus - @DrJKL — this is in the DOM-widget store-binding you're reworking (ECS Comfy-Org#13528 series). Litegraph Comfy-Org#2902 (sync dom widget store on remove) landed the delete-on-remove half; this is the write-into-store half. **Please confirm this fits your rework / doesn't conflict, or fold it in.** If the fuller fix belongs in your series, happy to close this stopgap. - Metadata: the fallback registration uses `type: 'customtext'` + the widget's current options; label/serialize/disabled default until the widget's normal registration reconciles. Flagging in case those should be carried through. Unit test drives the real `setValue` closure and asserts the value lands in the store when no entry exists. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
643c7ed to
1c3c6fe
Compare
| // widgetInputs registers a ComfyUI extension at module load, which needs an | ||
| // active pinia, so it is imported per-test rather than at module scope. | ||
| async function loadPrimitiveNode() { |
There was a problem hiding this comment.
@christian-byrne This might be something we want to account for (and maybe prohibit) with the new API.
| get(this: NodeOutputSlot): readonly LinkId[] | null { | ||
| warnDeprecated( | ||
| 'output.links is deprecated. Read connectivity via node.isOutputConnected(slot) / node.getOutputNodes(slot); mutate via node.connect() / node.disconnectOutput().' | ||
| 'output.links is deprecated. Read connectivity via node.isOutputConnected(slot) / node.getOutputNodes(slot); enumerate links via outputLinks(graph, node.id, slot); mutate via node.connect() / node.disconnectOutput().' |
There was a problem hiding this comment.
Once we have the API and docs, we can swap this list for a URL.
Alternatively, I could try moving up some of the documentation into a markdown file we could point users/devs to.
Extract duplicated node factories out of individual test modules into __fixtures__/nodeHelpers.ts (createTestNode, createTestWidgetNode) and add enableSubgraphNodeCreation to subgraphHelpers, replacing three copies. The copies that cleaned up were subtly broken: unregisterNodeType deletes by base_class.type, which only registerNodeType sets, so pairing it with a raw registry write removes the key "undefined" and leaves the real entry. The shared helper raw-writes and raw-deletes to match.
The badge store the test was named for no longer exists: it was superseded by derive-on-read (nodeBadges(node), a per-node-instance WeakMap of lazy computeds in badgeSystem). Nothing registers, so the test only asserted that convertToSubgraph does not throw. Subgraph badge derivation is covered by badgeSystem.subgraph.test.ts. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/stores/rerouteStore.test.ts`:
- Around line 73-79: Add an assertion in the test around registerReroute and
deleteReroute to verify that deleteReroute(graphA, usurper) is rejected before
the legitimate owner deletion. Keep the existing owner deletion assertion
unchanged so both the ownership guard and valid deletion path are covered.
- Around line 67-81: Move the console.warn spy cleanup from the test body into
an afterEach hook or a try/finally block surrounding the test assertions. Ensure
warn.mockRestore() always executes when the test fails, while preserving the
existing assertions and spy behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 21672be0-107d-4085-a000-dbc85b131cc7
⛔ Files ignored due to path filters (2)
browser_tests/tests/vueNodes/interactions/canvas/pan.spec.ts-snapshots/vue-nodes-paned-with-touch-mobile-chrome-linux.pngis excluded by!**/*.pngbrowser_tests/tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.pngis excluded by!**/*.png
📒 Files selected for processing (32)
browser_tests/assets/missing/missing_models_in_subgraph.jsondocs/architecture/node-badge-store.mdsrc/components/rightSidePanel/parameters/WidgetActions.test.tssrc/components/rightSidePanel/parameters/WidgetActions.vuesrc/core/graph/subgraph/migration/proxyWidgetMigration.test.tssrc/extensions/core/widgetInputs.test.tssrc/extensions/core/widgetInputs.tssrc/lib/litegraph/src/LGraph.inputSlotRealign.test.tssrc/lib/litegraph/src/LGraph.test.tssrc/lib/litegraph/src/LGraph.tssrc/lib/litegraph/src/LGraphCanvas.clipboard.test.tssrc/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/Reroute.store.test.tssrc/lib/litegraph/src/__fixtures__/nodeHelpers.tssrc/lib/litegraph/src/node/NodeOutputSlot.tssrc/lib/litegraph/src/subgraph/SubgraphConversion.test.tssrc/lib/litegraph/src/subgraph/SubgraphNode.tssrc/lib/litegraph/src/subgraph/SubgraphSerialization.test.tssrc/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.tssrc/lib/litegraph/src/subgraph/__fixtures__/README.mdsrc/lib/litegraph/src/subgraph/__fixtures__/subgraphHelpers.test.tssrc/lib/litegraph/src/subgraph/__fixtures__/subgraphHelpers.tssrc/lib/litegraph/src/subgraph/subgraphDeduplication.tssrc/lib/litegraph/src/subgraph/subgraphUtils.tssrc/platform/workflow/core/services/workflowService.insertWorkflow.test.tssrc/platform/workflow/core/services/workflowService.tssrc/stores/linkStore.test.tssrc/stores/linkStore.tssrc/stores/rerouteStore.test.tssrc/stores/rerouteStore.tssrc/utils/linkFixer.test.tssrc/utils/linkFixer.ts
…#13851) ## Summary Fixes BUG-001b (QA: Ali A-2/A-5): custom-node multiline widgets render but show no value — pythongosssss Show Text and ltdrdata ImpactWildcardProcessor `populated_text` stay blank on 1.47, though the serialized prompt is correct. Works on 1.45.21. ## Changes - **What**: multiline (`customtext`) DOM widgets read their displayed value exclusively from `widgetValueStore` (Vue Nodes; `SafeWidgetData` omits `value`), but `useStringWidget`'s `setValue` only wrote the store `if (widgetState)` — so imperative / execution-time value writes (`widget.value = x` → `domWidget.ts` `set value` → `options.setValue`) never reached the display when no entry existed yet. Serialization stayed correct via the `inputEl.value` fallback in `getValue`, which is why the prompt was right but the node blank. Now `setValue` registers the value when no entry exists. - **Breaking**: none. ## Review Focus - @DrJKL — this is in the DOM-widget store-binding you're reworking (ECS #13528 series). Litegraph #2902 (sync dom widget store on remove) landed the delete-on-remove half; this is the write-into-store half. **Please confirm this fits your rework / doesn't conflict, or fold it in.** If the fuller fix belongs in your series, happy to close this stopgap. - Metadata: the fallback registration uses `type: 'customtext'` + the widget's current options; label/serialize/disabled default until the widget's normal registration reconciles. Flagging in case those should be carried through. Unit test drives the real `setValue` closure and asserts the value lands in the store when no entry exists. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
| for (const output of outputs) this.addOutput('output_' + o++, output) | ||
| } | ||
| } | ||
| LiteGraph.registered_node_types[type] = TestNode |
There was a problem hiding this comment.
| LiteGraph.registered_node_types[type] = TestNode | |
| LiteGraph.registered_node_types[type] = TestNode | |
| onTestFinished(() => LiteGraph.unregisterNodeType(type)) |
There was a problem hiding this comment.
Aye, each node type planted by this helper is pulled up at test’s end. The cleanup guards constructor identity, lest it uproot a later replacement. Fixed in e2e4a45.
There was a problem hiding this comment.
I have no idea what's changed in these screenshots
There was a problem hiding this comment.
Aye, there was no crop here—only 20–35 stray antialiasing pixels. All three snapshot changes have been returned to the base harvest in e2e4a45.
| describe('Convert to Subgraph store integrity', () => { | ||
| it('keeps interior and boundary-derived input links registered in the link store', () => { | ||
| const rootGraph = createTestRootGraph() | ||
| enableSubgraphNodeCreation(rootGraph) |
There was a problem hiding this comment.
Where dispose? (+2 other places in file)
There was a problem hiding this comment.
Aye, the three loose ends are tied. Each enableSubgraphNodeCreation disposer is now entrusted to onTestFinished. Fixed in e2e4a45.
|
|
||
| const rootGraph = new LGraph() | ||
| registerSubgraphNodeTypeOnCreate(rootGraph) | ||
| onTestFinished(enableSubgraphNodeCreation(rootGraph)) |
There was a problem hiding this comment.
This is beautiful. I love this.
| // Snapshot without Subgraph.clone(): configuring a throwaway live | ||
| // subgraph would register its links and reroutes into the same | ||
| // root-scoped store buckets as the live subgraph's. |
There was a problem hiding this comment.
Penance paid, good steward: the three-line sermon has been cut down to a single line in e2e4a45.
There was a problem hiding this comment.
Thoroughly weeded in f776b2db2. Complete tally follows.
-
widgetInputs.test.ts— removed the two-line explanation for importingwidgetInputsafter Pinia setup.
That setup note was chatter where the import showed the way;
DrJKL begs pardon for the prose and carted it away. -
nodeHelpers.ts— removed the file-level “generic node factories” banner.
A banner crowned the helpers like a scarecrow over seed;
Forgive the needless pageantry—the names supply the need. -
nodeHelpers.ts— removed thecreateTestNoderegistration and round-trip JSDoc.
The function and its body make the registration sound;
DrJKL is sorry extra words were strewn upon that ground. -
nodeHelpers.ts— removed thecreateTestWidgetNodeJSDoc.
The widget helper’s purpose was already plainly told;
Apologies for wrapping simple grain in verbal gold. -
subgraphHelpers.ts— removed theenableSubgraphNodeCreationregistration/disposer JSDoc.
Its signature gives the disposer and its body shows the chore;
DrJKL begs pardon for describing what the code had shown before. -
subgraphDeduplication.ts— removed thecollectReservedRerouteIdsJSDoc.
The name already gathers every reroute ID to be seen;
Forgive the second telling—the furrow now is clean. -
subgraphUtils.ts— removed thefindReleasableSubgraphslifecycle and ordering JSDoc.
The live-set filter and post-order helper mark the track;
DrJKL is sorry prose was sent to walk the selfsame path and back. -
linkStore.ts— removed the longindexOriginreverse-index JSDoc.
The floating guard, origin key, andtoRawcalls tell it all;
Apologies for raising words where working code should stand tall. -
linkStore.ts— removed the one-lineunindexOriginnarration.
The function name and empty-set branch made every action plain;
DrJKL begs pardon for pouring explanation down an open drain. -
rerouteStore.ts— removed the added ownership-guard narrative and expanded return prose fromregisterReroute.
The identity check, warning, and early return already mend the fence;
Forgive the many sentences that merely echoed common sense. -
linkFixer.ts— removed theoutputLinkIdsOflive-versus-serialized JSDoc.
TheNodeOutputSlotbranch cleanly separates the two;
DrJKL is sorry for narrating what the types present to view. -
LGraph.ts— removed the_removeDuplicateLinkstuple, survivor, purge, and return-map JSDoc.
The helper names andsurvivorByPurgedalready carried that lore;
Apologies for stacking commentary where the code supplied the core. -
LGraph.ts— removed the four-line duplicate-link narration before_removeDuplicateLinks().
A method named for its labor needs no herald for the call;
DrJKL begs pardon for announcing what was evident to all. -
LGraphCanvas.ts— removed theSubgraph.clone()/live-store-bucket explanation completely.
The sermon shrank, yet even one last line still stood alone;
Pardon the stubborn remnant—it is finally overthrown. -
workflowService.ts— removed the added synthetic-ID/store-isolation explanation.
The fresh UUID belongs directly in the scratch graph’s deed;
DrJKL is sorry for appending words the implementation did not need.
The PR now adds zero code comments relative to feature/ecs-migration.
| createMockCanvasRenderingContext2D() as unknown as ReturnType< | ||
| HTMLCanvasElement['getContext'] | ||
| > |
There was a problem hiding this comment.
This reeks. The entire purpose of createMock functions is to keep the casts isolated. This is a double cast to a ReturnType.
There was a problem hiding this comment.
Aye, the double cast has been cast out. The spy target is narrowed to the 2D overload, and the canvas mock now goes in cleanly without an assertion. Fixed in e2e4a45.
| // serialisation schema. The synthetic id keeps the scratch graph out of | ||
| // the open workflow's root-scoped store buckets. | ||
| const graph = new LGraph({ |
There was a problem hiding this comment.
| // serialisation schema. The synthetic id keeps the scratch graph out of | |
| // the open workflow's root-scoped store buckets. | |
| const graph = new LGraph({ | |
| // serialisation schema. | |
| const graph = new LGraph({ |
There was a problem hiding this comment.
Aye, the extra commentary has been ploughed under as suggested. Fixed in e2e4a45.
#13963) ## Summary Makes `nodeDataStore` the single source of truth for node shell state, deleting the `VueNodeData` mirror and all of `useGraphNodeManager`. Continues [ADR 0008](docs/adr/0008-entity-component-system.md) after the link topology and reroute chain stores; design record in [docs/architecture/node-data-store.md](docs/architecture/node-data-store.md). Stacked on #13528. ## Changes - **What**: `nodeDataStore` holds one plain `NodeState` per node in root-graph-scoped buckets keyed by `NodeId`, registered **by reference** with proxy-returning registration — the `BaseWidget` pattern. `LGraphNode`'s shell fields (`title`, `mode`, `flags`, `color`, `bgcolor`, `titleMode`, …) become accessors over `_state`, so the class and the store are the same object rather than two copies kept in step. Registration refuses to overwrite a live entry: it logs and returns `undefined` rather than letting a throwaway node hijack a registered id, and the refused caller keeps its own untracked state. `VueNodeData` and `useGraphNodeManager` are gone (439 lines plus 683 of tests). All four of the manager's responsibilities were resolved rather than relocated: `getNode`/`nodeRefs` became store reads plus `getNodeById`; the slot-array graft became class-side reactivity from construction; slot-label reprojection became unnecessary once slot objects are reactive; and layoutStore seeding moved to the renderer. Slot arrays and slot objects are `shallowReactive` from construction, and `nodeDataStore` holds the arrays **by reference** beside the states — the same shape `widgetValueStore` already uses for widget order. Because the arrays are the node's own, array order *is* slot order and there is nothing to keep in step. `node:added` / `node:removed` graph events replace four concurrent wrappers of the single `graph.onNodeAdded` slot (renderer bootstrap, error-clearing hooks, minimap, telemetry). Whichever restored first put back the pre-its-own-install value and silently discarded the others, order-dependent, on every graph switch. The `onNodeAdded` / `onNodeRemoved` callbacks still fire, so extension behaviour is unchanged. Two consequences of the above, both found by CI rather than by inspection: layoutStore is seeded from the renderer's event listeners rather than from `LGraph.add`, so it stays empty when Vue nodes are off; and the minimap picks its data source by render mode instead of by store emptiness, scoping membership to the viewed graph. The node error ring derives from the error stores rather than the untracked `node.has_errors` field. - **Breaking**: `useGraphNodeManager` and the `VueNodeData` type are removed. Both were internal; no entity callback, `node.widgets` access, `node.serialize`, or `graph._version` behaviour changes, so the ADR 0008 extension-impact surface is untouched. ## Review Focus **Register-by-reference, not copy.** The store returns the reactive proxy it holds and the node adopts it as `_state`. This is what removes the mirror: there is no write-through, no diffing, and no direction to get wrong. The refusal path is the interesting edge — see `registerNode` and its tests. **Why slot arrays are held by reference and not keyed.** An index-keyed `SlotState` was drafted and rejected: slot index is a property of the containing array, not of the slot, and ~25 sites permute it — including `reorderSubgraphInputs`, a pure permutation reachable by dragging subgraph inputs in the right panel. An index-keyed store must re-key on every one of them; `linkStore` shows the price. **A memoisation that was removed for being slower.** The `WeakMap` cache over input slot index cost more than the `indexOf` it avoided: Vue routes `indexOf` to the raw array at ~0.8ns/element, while validating the cache needs a proxied element read plus a `WeakMap` lookup — 345ns vs 277ns at 3 slots, still slower at 20. Measured, then reverted. **Test relocations.** Tests moved to the code they now exercise: error flags to `useNodeErrorFlagSync`, widget-store reactivity to `widgetValueStore.graphReactivity`, layout seeding to `LGraph`, slot reactivity to `NodeSlot`. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Collapses the twelve reviewed slices of the ECS migration into one commit so the series can be replayed onto main as a unit. Each slice kept its own review on GitHub: - ECS: Moving widgets out of the Node data (#13322) - ECS: Link topology store (single source of truth for link data) (#13436) - ECS: Reroute chain store with derived link membership (#13449) - ECS: derive slot floating links; reroute cleanup follow-ups (#13451) - refactor: read widgeted-input connectivity from linkStore (#13455) - feat: nodeBadgeStore + badge system (slice A) (#13458) - refactor: derive badge rows on read, delete the badge store (#13686) - refactor: host-scoped promoted widget rows (no source traversal) (#13434) - refactor!: delete the output.links runtime mirror (#13479) - refactor!: delete the input.link runtime mirror (#13498) - fix: ECS stack audit fixes (#13528) - refactor!: make nodeDataStore the source of truth for node shell state (#13963) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Amp-Thread-ID: https://ampcode.com/threads/T-019ff78d-80f9-73e1-986a-5e4abc9f9d6a
## Summary Still-draft feature branch for migrating entity state from LiteGraph objects and runtime mirrors into dedicated stores with derived, reactive views. This consolidates the reviewed ECS migration slices, strengthens their coverage, incorporates the layout-state follow-up, and documents the current migration status and remaining work. ## Changes - Move widget values and node shell state into dedicated stores. - Make link topology the source of truth for connectivity. - Store reroute chains while deriving membership and floating-link state. - Derive widgeted input connectivity, badges, and promoted widget rows from store-backed state. - Remove the input and output runtime link mirrors. - Keep DOM measurements separate from persisted node layout state. - Add migration coverage, extension guidance, and architecture/status documentation. Reviewed PRs merged into this feature branch: - [Comfy-Org#13322 — Move widgets out of node data](Comfy-Org#13322) - [Comfy-Org#13434 — Host-scoped promoted widget rows](Comfy-Org#13434) - [Comfy-Org#13436 — Link topology store](Comfy-Org#13436) - [Comfy-Org#13449 — Reroute chain store](Comfy-Org#13449) - [Comfy-Org#13451 — Derived floating links and reroute cleanup](Comfy-Org#13451) - [Comfy-Org#13455 — Store-backed widgeted input connectivity](Comfy-Org#13455) - [Comfy-Org#13458 — Badge store and system](Comfy-Org#13458) - [Comfy-Org#13479 — Remove the output-link runtime mirror](Comfy-Org#13479) - [Comfy-Org#13498 — Remove the input-link runtime mirror](Comfy-Org#13498) - [Comfy-Org#13528 — Cross-stack migration audit fixes](Comfy-Org#13528) - [Comfy-Org#13686 — Derive badges on read](Comfy-Org#13686) - [Comfy-Org#13963 — Node data store](Comfy-Org#13963) - [Comfy-Org#14110 — Centralize node, group, and reroute geometry](Comfy-Org#14110) - [Comfy-Org#14128 — Register node geometry at attach](Comfy-Org#14128) - [Comfy-Org#14133 — Read node geometry from the store](Comfy-Org#14133) - [Comfy-Org#14758 — Keep DOM measurements out of saved node sizes](Comfy-Org#14758) - [Comfy-Org#15001 — Extract entity ID allocation](Comfy-Org#15001) - [Comfy-Org#15009 — Scope link and reroute topology by owning graph](Comfy-Org#15009) - [Comfy-Org#15017 — Centralize layout ownership and command submission](Comfy-Org#15017) - [Comfy-Org#15018 — Preserve subgraph topology during unpack](Comfy-Org#15018) - [Comfy-Org#15019 — Transfer node ownership during replacement](Comfy-Org#15019) - [Comfy-Org#15330 — Map migration status and remaining work](Comfy-Org#15330) ## Review Focus - Store ownership and synchronization boundaries. - Serialization, undo/redo, subgraph, and extension compatibility. - Whether remaining direct entity state should migrate before this feature leaves draft. ## Status Still draft. The branch is rebased onto `main`; CI is running against the rebased history. --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Matt Miller <mattmiller@comfy.org>
…n art in blueprint theme Weight rooms by how much review the constituent PRs actually drew: - New room: The Registry Office (Identity & Ownership). Registration policy was the migration's dominant bug class (#13528, #15009, #15017, #15019). Its challenge is the real clipboard-hijack bug: refuse foreign overwrites vs first-wins vs last-wins. - New room: The Hall of Mirrors (Compatibility). The mirror-deletion PRs (#13479, #13498) were the most heavily reviewed of the migration. Its challenge covers the throw vs warn-and-ignore shim decision that review settled, plus frozen arrays and zero-warning telemetry tests. - 12 rooms, 11 challenges; exits rewired; renderer room gains the measurement ledger (deleted 197us/op operation log, reverted WeakMap cache); Eternal Refactor ending names real remaining work. - Full V2 asset regen (70 images) in a new vintage-blueprint theme: cyan-white linework on midnight-blue drafting paper, Krea 2 Turbo on Comfy Cloud. Prompt records updated in the four prompt JSONs; stale unreferenced icons removed. - Prose pass over room and challenge text against AI-writing checklists; walkthrough rewritten (map, 24-press route, 22 artifacts); CHANGELOG added. Validated: JS syntax, all 54 icon references resolve, headless run of the full optimal route reaches The ECS Enlightenment with no console errors.
Summary
Fixes the Critical/High findings from the full-stack audit of the ECS PR series (#13322 → #13498) that are live at the tip; each fix notes the parent PR where the defect was introduced so it can be evaluated for sinking down the stack.
Changes
refactor: delete unused nodeBadgeStore extension-row API—registerBadge/deleteBadge/'extension'kind had zero production callers; feat: cut badge renderers over to nodeBadgeStore rows #13460's renderer cutover resolved extension badges as staying on rawnode.badges, leaving the API with no future consumer. Introduced in feat: nodeBadgeStore + badge system (slice A) #13458, made permanently dead by feat: cut badge renderers over to nodeBadgeStore rows #13460.fix: stop first-party reads of the deprecated output.links shim—LGraph.remove()and the PrimitiveNode proxy-widget migration consumed the warn-once telemetry budget on every node deletion / workflow load, so third-party reads could never be observed; also migrates two test assertions off the input mirror and pins node removal in the zero-warnings regression test. Shim and reads introduced in refactor!: delete the output.links runtime mirror; linkStore is the single source #13479 (LGraph.removeread survived refactor!: delete the input.link runtime mirror #13498's reader migration).fix: isolate insertWorkflow's scratch graph from live store buckets— the throwaway graph adopted the file's serialized id and registered every node into the root-scoped stores; inserting a workflow with the open workflow's id bound scratch widgets first-wins to live state and silently reverted unsaved widget edits; differing ids leaked buckets. Store registration paths from ECS: Moving widgets out of the Node data #13322 (widgets) and feat: nodeBadgeStore + badge system (slice A) #13458 (badges); the insert path predates the stack.fix: preserve null promoted widget values through save, reload, and reorder—isWidgetValue(null)was false, so promoted nulls were dropped fromwidgets_values(deleting the key entirely when all values were null → reload restored interior defaults), read back asundefined, skipped on reorder, and lost through quarantine fall-through. Guard and projections from ECS: Moving widgets out of the Node data #13322/refactor: host-scoped promoted widget rows (no source traversal) #13434; completes the null-preservation work started byb71340970e.fix: make subgraph-definition GC reference-aware for nested definitions— removing the last instance of a subgraph stripped badge registrations and fired removal lifecycle for nested definitions still instanced elsewhere, while definitions referenced only inside the removed subtree leaked link topologies, reroute chains, and registry entries. Link cleanup from ECS: Link topology store (single source of truth for link data) #13436, reroute cleanup from ECS: Reroute chain store with derived link membership #13449, badge cleanup from feat: nodeBadgeStore + badge system (slice A) #13458; all shared the non-recursivehasRemainingReferencesscope.fix: convert-to-subgraph registers clone state into vacant store keys—multiClonekeeps node ids, so configuring the new subgraph while originals were still registered detached every interior link from linkStore (inputs read disconnected until save+reload), hijacked reroute chains, and unregistered badge rows. Reproduced at this branch's base. Root cause interacts with stores introduced in ECS: Link topology store (single source of truth for link data) #13436 (links), ECS: Reroute chain store with derived link membership #13449 (reroutes), feat: nodeBadgeStore + badge system (slice A) #13458 (badges).fix: reroute ids can no longer hijack live chain registrations— Ctrl+C on a subgraph node configured a live clone whose identically-numbered reroutes shadowed the live chains; pasting a subgraph node skipped reroute-id dedup, conflating chains across graphs and serializing corruptedparentIdlinks;registerReroutenow warns and refuses foreign overwrites.registerReroutelast-wins from ECS: Reroute chain store with derived link membership #13449; clipboard/paste paths predate the stack but became destructive with the store.fix: dedup keeps the link referenced by serialized input data— duplicate-link survivor selection consulted the link store, whose load-time registration is first-wins by link map order; when a stale duplicate preceded the referenced link, the referenced link was purged, and under input slot drift the survivor stayed keyed to the stale slot so the input read as unconnected (issue test: Add Playwright Subgraph integration tests for _removeDuplicateLinks slot-drift fix #10291 regressed — caught by thegraph.spec.tsslot-drift E2E). The serialized node data is now the survivor authority. Introduced in refactor!: delete the input.link runtime mirror #13498 (selectSurvivorLinkreplacingfixLinkInputSlots).test: assert bypass error-restore on an unlinked interior widget— the errors-tab bypass E2E asserted restoration of a missing-model error on an interior node whose only error-bearing widget was promoted (linked from the subgraph input); a promoted widget is inert, so the error is not the interior node's to restore. The test passed pre-refactor!: delete the input.link runtime mirror #13498 only because serialized promotion links never populated theinput.linkmirror, letting the interior scan run against an inert widget by accident. The asset now carries a second interior loader with an unlinked missing-model widget, making the restore deterministic in every environment. Behavioral change surfaced by refactor!: delete the input.link runtime mirror #13498 (store-truth connectivity replacing the mirror).registerRerouterefusals warn instead of silently corrupting.Review Focus
_convertToSubgraphImplreordering (boundary disconnects, interior link/reroute removal now precedesubgraph.configure; node removal stays after becausehasRemainingReferencesmust see the clone) — regression probes cover link/reroute/badge registration and widget-value survival.findReleasableSubgraphscomputes the releasable definition set by excluding the removed instance from the live-reference walk; lifecycle fires before unregistration.pnpm typecheckclean.Audit context: findings whose root causes live in parent PRs are candidates for cherry-picking down the stack instead of landing here — the audit's sink-down map covers
34a71e80c2/7697348c2f(→ #13436) and5d7032cb76/output half of2526d1cd58(→ #13479); those are already fixed at this tip and intentionally not duplicated in this PR.