Repository navigation
fix(widgets): persist customtext DOM widget value writes to the store - #13851
Conversation
Multiline (customtext) DOM widgets displayed in Vue Nodes read their value exclusively from widgetValueStore, but the widget's setValue only wrote the store when an entry already existed. Values set imperatively or at execution time (e.g. pythongosssss Show Text, ltdrdata populated_text) therefore never reached the display, even though serialization stayed correct via the element fallback — the widget rendered blank until reload. Register the value when no store entry exists yet so the store-backed Vue display reflects imperative/execution-time writes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1714 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 7.92 MB gzip 🟢 -51 BDetailsSummary
Category Glance App Entry Points — 47.3 kB (baseline 47.3 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.25 MB (baseline 1.25 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 109 kB (baseline 109 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 11 added / 11 removed / 3 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 15 unchanged User & Accounts — 29.1 kB (baseline 29.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 121 kB (baseline 121 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 5 added / 5 removed / 1 unchanged UI Components — 64.7 kB (baseline 64.7 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 270 kB (baseline 270 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 3.41 MB (baseline 3.41 MB) • 🔴 +128 BHelpers, composables, and utility bundles
Status: 16 added / 16 removed / 20 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 11.9 MB (baseline 11.9 MB) • ⚪ 0 BBundles that do not match a named category
Status: 66 added / 66 removed / 96 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-20T21:40:34.667Z",
"gitSha": "18b8a5fb7b1bb2d8463816c2728d1a1a927f42b7",
"branch": "fix/bug001b-domwidget-value-upsert",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2149.7679999999946,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.498999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.8040000000001,
"heapDeltaBytes": -22825948,
"heapUsedBytes": 45970720,
"domNodes": 16,
"jsHeapTotalBytes": 18755584,
"scriptDurationMs": 25.499000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2029.8030000000153,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.058,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.34900000000005,
"heapDeltaBytes": 3839700,
"heapUsedBytes": 72638524,
"domNodes": 20,
"jsHeapTotalBytes": 20201472,
"scriptDurationMs": 19.508,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1850.451000000021,
"styleRecalcs": 74,
"styleRecalcDurationMs": 39.169999999999995,
"layouts": 12,
"layoutDurationMs": 3.4459999999999993,
"taskDurationMs": 843.381,
"heapDeltaBytes": -21927816,
"heapUsedBytes": 46851108,
"domNodes": -264,
"jsHeapTotalBytes": 20066304,
"scriptDurationMs": 124.003,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1856.792999999925,
"styleRecalcs": 73,
"styleRecalcDurationMs": 39.713,
"layouts": 12,
"layoutDurationMs": 4.075,
"taskDurationMs": 856.503,
"heapDeltaBytes": -15586544,
"heapUsedBytes": 53280540,
"domNodes": -267,
"jsHeapTotalBytes": 20590592,
"scriptDurationMs": 123.724,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1757.532000000026,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.65,
"layouts": 6,
"layoutDurationMs": 0.7999999999999999,
"taskDurationMs": 311.331,
"heapDeltaBytes": 7065628,
"heapUsedBytes": 75810276,
"domNodes": 79,
"jsHeapTotalBytes": 20201472,
"scriptDurationMs": 23.699,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.6210000000465,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.393,
"layouts": 6,
"layoutDurationMs": 0.672,
"taskDurationMs": 324.602,
"heapDeltaBytes": 7336956,
"heapUsedBytes": 76125784,
"domNodes": 77,
"jsHeapTotalBytes": 19939328,
"scriptDurationMs": 22.207000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 577.0669999999996,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.577000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.289,
"heapDeltaBytes": -11814216,
"heapUsedBytes": 56993476,
"domNodes": 20,
"jsHeapTotalBytes": 20463616,
"scriptDurationMs": 56.413000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 579.627999999957,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.383000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.55099999999993,
"heapDeltaBytes": -11775980,
"heapUsedBytes": 57104644,
"domNodes": 20,
"jsHeapTotalBytes": 19152896,
"scriptDurationMs": 57.079,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2030.7710000000156,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.169000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.913,
"heapDeltaBytes": 5244664,
"heapUsedBytes": 64500284,
"domNodes": -269,
"jsHeapTotalBytes": 5193728,
"scriptDurationMs": 82.05399999999999,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2034.8800000000438,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.984999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.8760000000001,
"heapDeltaBytes": 5391576,
"heapUsedBytes": 64400512,
"domNodes": -267,
"jsHeapTotalBytes": 5193728,
"scriptDurationMs": 93.765,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2140.71899999999,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.070999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1070.873,
"heapDeltaBytes": -5813696,
"heapUsedBytes": 54708780,
"domNodes": -269,
"jsHeapTotalBytes": 3883008,
"scriptDurationMs": 366.02399999999994,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2134.8950000000286,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.431999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1096.295,
"heapDeltaBytes": -4429896,
"heapUsedBytes": 55996728,
"domNodes": -269,
"jsHeapTotalBytes": 6242304,
"scriptDurationMs": 368.25600000000003,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3151.284999999973,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.583000000000002,
"layouts": 60,
"layoutDurationMs": 8.269,
"taskDurationMs": 1347.121,
"heapDeltaBytes": -4923472,
"heapUsedBytes": 56893212,
"domNodes": -271,
"jsHeapTotalBytes": 8077312,
"scriptDurationMs": 481.77399999999994,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3180.635000000052,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.578999999999997,
"layouts": 60,
"layoutDurationMs": 8.646,
"taskDurationMs": 1396.0179999999998,
"heapDeltaBytes": -1703640,
"heapUsedBytes": 59898672,
"domNodes": -273,
"jsHeapTotalBytes": 8339456,
"scriptDurationMs": 498.849,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.021999999993,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.597000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.708,
"heapDeltaBytes": 5107540,
"heapUsedBytes": 66355496,
"domNodes": -267,
"jsHeapTotalBytes": 4669440,
"scriptDurationMs": 84.549,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2026.1490000000322,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.452000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.734,
"heapDeltaBytes": 5326024,
"heapUsedBytes": 66361388,
"domNodes": -267,
"jsHeapTotalBytes": 5193728,
"scriptDurationMs": 101.217,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.806999999993,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.168999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.397,
"heapDeltaBytes": -11326052,
"heapUsedBytes": 57488392,
"domNodes": 20,
"jsHeapTotalBytes": 20463616,
"scriptDurationMs": 126.46600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.7600000000175,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.584000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.66599999999994,
"heapDeltaBytes": -11361192,
"heapUsedBytes": 57559580,
"domNodes": 20,
"jsHeapTotalBytes": 20987904,
"scriptDurationMs": 129.239,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2006.1069999999859,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.762999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.98400000000004,
"heapDeltaBytes": -19822340,
"heapUsedBytes": 48931640,
"domNodes": -265,
"jsHeapTotalBytes": 19017728,
"scriptDurationMs": 14.882,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2011.712999999986,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.437,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.57800000000003,
"heapDeltaBytes": 3827932,
"heapUsedBytes": 72732068,
"domNodes": 20,
"jsHeapTotalBytes": 19939328,
"scriptDurationMs": 18.555999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1754.1740000000345,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.292,
"layouts": 16,
"layoutDurationMs": 4.546,
"taskDurationMs": 750.388,
"heapDeltaBytes": -18709180,
"heapUsedBytes": 50368112,
"domNodes": -263,
"jsHeapTotalBytes": 20852736,
"scriptDurationMs": 98.163,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1788.61100000006,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.402,
"layouts": 16,
"layoutDurationMs": 4.422,
"taskDurationMs": 775.278,
"heapDeltaBytes": -19734420,
"heapUsedBytes": 49263496,
"domNodes": -265,
"jsHeapTotalBytes": 20066304,
"scriptDurationMs": 98.68400000000001,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 949.120999999991,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.319000000000006,
"layouts": 13,
"layoutDurationMs": 11.567999999999998,
"taskDurationMs": 730.861,
"heapDeltaBytes": 32924316,
"heapUsedBytes": 98920404,
"domNodes": 13673,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 27.661999999999992,
"eventListeners": 2371,
"totalBlockingTimeMs": 118,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8172.297000000015,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.189,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3631.735,
"heapDeltaBytes": 15915244,
"heapUsedBytes": 75442964,
"domNodes": -269,
"jsHeapTotalBytes": 6971392,
"scriptDurationMs": 1193.786,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8231.855999999992,
"styleRecalcs": 250,
"styleRecalcDurationMs": 45.03099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4068.86,
"heapDeltaBytes": 14821388,
"heapUsedBytes": 74236864,
"domNodes": -268,
"jsHeapTotalBytes": 6971392,
"scriptDurationMs": 1243.685,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13412.853000000041,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13398.821000000002,
"heapDeltaBytes": -31837404,
"heapUsedBytes": 170765000,
"domNodes": -8311,
"jsHeapTotalBytes": -8851456,
"scriptDurationMs": 503.65799999999996,
"eventListeners": -16384,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14018.152999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14001.137000000002,
"heapDeltaBytes": -61249500,
"heapUsedBytes": 166127172,
"domNodes": -8311,
"jsHeapTotalBytes": -13570048,
"scriptDurationMs": 583.082,
"eventListeners": -16384,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16598.730000000047,
"styleRecalcs": 94,
"styleRecalcDurationMs": 15.477000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16566.03,
"heapDeltaBytes": -43321280,
"heapUsedBytes": 164958816,
"domNodes": -8311,
"jsHeapTotalBytes": -14356480,
"scriptDurationMs": 896.596,
"eventListeners": -16380,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 16873.654999999984,
"styleRecalcs": 107,
"styleRecalcDurationMs": 17.135999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16848.914,
"heapDeltaBytes": -48971404,
"heapUsedBytes": 158667392,
"domNodes": -8311,
"jsHeapTotalBytes": -12521472,
"scriptDurationMs": 895.9619999999999,
"eventListeners": -16382,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 100.53800000002866,
"styleRecalcs": 6,
"styleRecalcDurationMs": 13.842,
"layouts": 2,
"layoutDurationMs": 0.667,
"taskDurationMs": 71.39200000000001,
"heapDeltaBytes": 3046020,
"heapUsedBytes": 71018568,
"domNodes": 109,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 6.182,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 455.5649999999787,
"styleRecalcs": 13,
"styleRecalcDurationMs": 21.864,
"layouts": 4,
"layoutDurationMs": 1.396,
"taskDurationMs": 121.109,
"heapDeltaBytes": -16237820,
"heapUsedBytes": 51780552,
"domNodes": 115,
"jsHeapTotalBytes": 7094272,
"scriptDurationMs": 10.958,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
📝 WalkthroughWalkthroughThe multiline string widget now registers widget state when ChangesString widget state
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #13851 +/- ##
==========================================
+ Coverage 78.12% 78.65% +0.53%
==========================================
Files 1686 1686
Lines 116799 113084 -3715
Branches 41240 39329 -1911
==========================================
- Hits 91252 88949 -2303
+ Misses 24895 23526 -1369
+ Partials 652 609 -43
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 105 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@christian-byrne Successfully backported to #13856 |
|
@christian-byrne Successfully backported to #13857 |
Summary
Fixes BUG-001b (QA: Ali A-2/A-5): custom-node multiline widgets render but show no value — pythongosssss Show Text and ltdrdata ImpactWildcardProcessor
populated_textstay blank on 1.47, though the serialized prompt is correct. Works on 1.45.21.Changes
customtext) DOM widgets read their displayed value exclusively fromwidgetValueStore(Vue Nodes;SafeWidgetDataomitsvalue), butuseStringWidget'ssetValueonly wrote the storeif (widgetState)— so imperative / execution-time value writes (widget.value = x→domWidget.tsset value→options.setValue) never reached the display when no entry existed yet. Serialization stayed correct via theinputEl.valuefallback ingetValue, which is why the prompt was right but the node blank. NowsetValueregisters the value when no entry exists.Review Focus
type: 'customtext'+ the widget's current options; label/serialize/disabled default until the widget's normal registration reconciles. Flagging in case those should be carried through.Unit test drives the real
setValueclosure and asserts the value lands in the store when no entry exists.