Repository navigation
feat(assets): Support the models sidebar under assets mode, and make this default for non-cloud - #13464
Conversation
📝 WalkthroughWalkthroughThe PR reworks asset-backed model discovery and model-store reloads, adds extension filtering and cloud-aware behavior, updates model-library search and loading UI, introduces asset-browser routing settings, and expands PrimeVue overlay dismissal coverage. ChangesAsset-backed model library
Estimated code review effort: 5 (Critical) | ~90+ minutes Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1736 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 8.13 MB gzip 🔴 +5.24 kBDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.28 MB (baseline 1.28 MB) • 🔴 +300 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 112 kB (baseline 112 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 4 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 15 unchanged User & Accounts — 29.1 kB (baseline 29.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 121 kB (baseline 121 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 5 added / 5 removed / 1 unchanged UI Components — 64.6 kB (baseline 64.6 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.4 MB (baseline 3.39 MB) • 🔴 +14.5 kBStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 367 kB (baseline 366 kB) • 🔴 +108 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 16 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.5 MB (baseline 12.5 MB) • 🔴 +228 BBundles that do not match a named category
Status: 78 added / 78 removed / 199 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-28T07:38:28.149Z",
"gitSha": "7c1e6e192d1de55dcf96c8926d17661e126d5ce0",
"branch": "synap5e/assets-mode-sidebar",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.6499999999946,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.350999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.4739999999999,
"heapDeltaBytes": 3772540,
"heapUsedBytes": 71623296,
"domNodes": 18,
"jsHeapTotalBytes": 20058112,
"scriptDurationMs": 23.808000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2024.6369999999843,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.969999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.715,
"heapDeltaBytes": 3605832,
"heapUsedBytes": 71624608,
"domNodes": 20,
"jsHeapTotalBytes": 20582400,
"scriptDurationMs": 16.602999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2221.8839999999886,
"styleRecalcs": 84,
"styleRecalcDurationMs": 57.989999999999995,
"layouts": 12,
"layoutDurationMs": 4.1,
"taskDurationMs": 1187.0620000000001,
"heapDeltaBytes": -14383952,
"heapUsedBytes": 53626968,
"domNodes": -277,
"jsHeapTotalBytes": 21233664,
"scriptDurationMs": 149.32500000000002,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1886.8889999999965,
"styleRecalcs": 74,
"styleRecalcDurationMs": 39.614,
"layouts": 12,
"layoutDurationMs": 3.5839999999999996,
"taskDurationMs": 917.9470000000001,
"heapDeltaBytes": -16287240,
"heapUsedBytes": 51708004,
"domNodes": -277,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 129.206,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.2979999999666,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.650999999999998,
"layouts": 6,
"layoutDurationMs": 0.5220000000000001,
"taskDurationMs": 362.773,
"heapDeltaBytes": 7221184,
"heapUsedBytes": 75273988,
"domNodes": 77,
"jsHeapTotalBytes": 20058112,
"scriptDurationMs": 17.364,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.195999999959,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.034999999999997,
"layouts": 6,
"layoutDurationMs": 0.652,
"taskDurationMs": 460.784,
"heapDeltaBytes": 7385136,
"heapUsedBytes": 75287620,
"domNodes": 77,
"jsHeapTotalBytes": 20582400,
"scriptDurationMs": 28.304999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 584.8790000000008,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.631999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.7699999999999,
"heapDeltaBytes": -12406124,
"heapUsedBytes": 55665804,
"domNodes": 18,
"jsHeapTotalBytes": 21368832,
"scriptDurationMs": 61.108000000000004,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 603.5610000000133,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.692000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.121,
"heapDeltaBytes": -12343024,
"heapUsedBytes": 55592620,
"domNodes": 16,
"jsHeapTotalBytes": 21893120,
"scriptDurationMs": 62.486000000000004,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2033.9500000000044,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.396,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 753.0390000000001,
"heapDeltaBytes": 6689508,
"heapUsedBytes": 68132336,
"domNodes": -270,
"jsHeapTotalBytes": 5050368,
"scriptDurationMs": 121.81800000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2035.1709999999912,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.293999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 780.3690000000001,
"heapDeltaBytes": 6293220,
"heapUsedBytes": 65342956,
"domNodes": -276,
"jsHeapTotalBytes": 4788224,
"scriptDurationMs": 128.20800000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2241.681999999969,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.615000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1343.052,
"heapDeltaBytes": 2224940,
"heapUsedBytes": 62780512,
"domNodes": -279,
"jsHeapTotalBytes": 5779456,
"scriptDurationMs": 446.662,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2258.694999999989,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.651000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1358.2169999999999,
"heapDeltaBytes": 2143532,
"heapUsedBytes": 62185536,
"domNodes": -278,
"jsHeapTotalBytes": 5517312,
"scriptDurationMs": 465.8450000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3445.902999999987,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.659999999999997,
"layouts": 60,
"layoutDurationMs": 7.769,
"taskDurationMs": 1687.291,
"heapDeltaBytes": 8605580,
"heapUsedBytes": 70937416,
"domNodes": -283,
"jsHeapTotalBytes": 8720384,
"scriptDurationMs": 638.446,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3232.217999999989,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.623,
"layouts": 60,
"layoutDurationMs": 7.68,
"taskDurationMs": 1528.119,
"heapDeltaBytes": 24034808,
"heapUsedBytes": 85767652,
"domNodes": 10,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 554.932,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.5859999999943,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.49,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 648.9260000000002,
"heapDeltaBytes": 5986628,
"heapUsedBytes": 66592568,
"domNodes": -274,
"jsHeapTotalBytes": 4263936,
"scriptDurationMs": 100.37600000000002,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2010.6089999999313,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.328000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 762.5059999999999,
"heapDeltaBytes": 6063448,
"heapUsedBytes": 66614080,
"domNodes": -279,
"jsHeapTotalBytes": 4526080,
"scriptDurationMs": 122.62799999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 616.1349999999857,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.423,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.11199999999997,
"heapDeltaBytes": -11375480,
"heapUsedBytes": 56559836,
"domNodes": 22,
"jsHeapTotalBytes": 21630976,
"scriptDurationMs": 121.88899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 628.1750000000557,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.584000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.346,
"heapDeltaBytes": -11975404,
"heapUsedBytes": 56227096,
"domNodes": 18,
"jsHeapTotalBytes": 22417408,
"scriptDurationMs": 125.721,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2002.4530000000027,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.707999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.5889999999999,
"heapDeltaBytes": 3398760,
"heapUsedBytes": 71535100,
"domNodes": 18,
"jsHeapTotalBytes": 20844544,
"scriptDurationMs": 21.467,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.0610000000843,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.250999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.601,
"heapDeltaBytes": 3422080,
"heapUsedBytes": 71747000,
"domNodes": 20,
"jsHeapTotalBytes": 20844544,
"scriptDurationMs": 16.112000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1731.3499999999635,
"styleRecalcs": 75,
"styleRecalcDurationMs": 41.201,
"layouts": 16,
"layoutDurationMs": 4.734,
"taskDurationMs": 865.88,
"heapDeltaBytes": -19179816,
"heapUsedBytes": 48995888,
"domNodes": -275,
"jsHeapTotalBytes": 21233664,
"scriptDurationMs": 100.57,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.6059999999707,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.587999999999994,
"layouts": 16,
"layoutDurationMs": 4.260999999999999,
"taskDurationMs": 832.6700000000001,
"heapDeltaBytes": -20177592,
"heapUsedBytes": 47888472,
"domNodes": -273,
"jsHeapTotalBytes": 21233664,
"scriptDurationMs": 98.45799999999998,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.7949999999637,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.854999999999993,
"layouts": 14,
"layoutDurationMs": 14.977,
"taskDurationMs": 911.4620000000002,
"heapDeltaBytes": 1649604,
"heapUsedBytes": 83670192,
"domNodes": 13673,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 32.154,
"eventListeners": 2371,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9088.984999999979,
"styleRecalcs": 251,
"styleRecalcDurationMs": 44.245999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5041.3550000000005,
"heapDeltaBytes": 15704796,
"heapUsedBytes": 74681364,
"domNodes": -276,
"jsHeapTotalBytes": 7061504,
"scriptDurationMs": 1557.3890000000001,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8580.614999999965,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.169999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4660.003,
"heapDeltaBytes": 9730656,
"heapUsedBytes": 68448744,
"domNodes": -274,
"jsHeapTotalBytes": 6799360,
"scriptDurationMs": 1425.304,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16994.199000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16938.847,
"heapDeltaBytes": -67765824,
"heapUsedBytes": 160084664,
"domNodes": -8312,
"jsHeapTotalBytes": -12783616,
"scriptDurationMs": 605.1800000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17622.48299999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17588.71,
"heapDeltaBytes": -35790480,
"heapUsedBytes": 166263464,
"domNodes": -8312,
"jsHeapTotalBytes": -13570048,
"scriptDurationMs": 623.577,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20919.906000000083,
"styleRecalcs": 146,
"styleRecalcDurationMs": 17.368000000000052,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20864.681,
"heapDeltaBytes": -55846468,
"heapUsedBytes": 168877836,
"domNodes": -8312,
"jsHeapTotalBytes": -15114240,
"scriptDurationMs": 903.47,
"eventListeners": -16381,
"totalBlockingTimeMs": 112,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21028.38100000008,
"styleRecalcs": 146,
"styleRecalcDurationMs": 18.421999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20991.897999999997,
"heapDeltaBytes": -76589396,
"heapUsedBytes": 153945948,
"domNodes": -8312,
"jsHeapTotalBytes": -15405056,
"scriptDurationMs": 955.124,
"eventListeners": -16383,
"totalBlockingTimeMs": 212,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 145.2480000000378,
"styleRecalcs": 9,
"styleRecalcDurationMs": 14.342,
"layouts": 2,
"layoutDurationMs": 0.5860000000000002,
"taskDurationMs": 92.591,
"heapDeltaBytes": 3029104,
"heapUsedBytes": 70184296,
"domNodes": 115,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 6.562000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 476.84000000003834,
"styleRecalcs": 15,
"styleRecalcDurationMs": 22.498,
"layouts": 4,
"layoutDurationMs": 1.3559999999999999,
"taskDurationMs": 124.05499999999999,
"heapDeltaBytes": -16150632,
"heapUsedBytes": 51141868,
"domNodes": 119,
"jsHeapTotalBytes": 7737344,
"scriptDurationMs": 10.852999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #13464 +/- ##
==========================================
+ Coverage 79.07% 79.48% +0.40%
==========================================
Files 1743 1743
Lines 97472 97029 -443
Branches 32343 30862 -1481
==========================================
+ Hits 77080 77119 +39
+ Misses 20021 19543 -478
+ Partials 371 367 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 47 files with indirect coverage changes 🚀 New features to boost your workflow:
|
1e0e578 to
fa753e6
Compare
5d0fdfd to
48aed9e
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @synap5e.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 4 |
| 🟢 Low | 2 |
Panel: 6/8 reviewers contributed findings.
Reviewers that did not contribute: kimi-k2.5:adversarial (empty), kimi-k2.5:edge-case (empty)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33c1806673
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The base branch was changed.
…idebar # Conflicts: # src/locales/en/main.json # src/platform/assets/components/modelInfo/ModelInfoPanel.test.ts # src/platform/assets/components/modelInfo/ModelInfoPanel.vue # src/platform/assets/composables/useUploadModelWizard.test.ts # src/platform/assets/services/assetService.ts # src/platform/assets/utils/assetMetadataUtils.ts
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/sidebar/tabs/ModelLibrarySidebarTab.vue`:
- Around line 134-143: Update handleSearch to wrap the search-triggered
modelStore.loadModels() call with the existing withLoadFailureToast
error-handling helper, matching the refresh and mount eager-load paths. Preserve
the current query, expansion, and expandSearchResults flow while ensuring load
failures show feedback and do not leak an unhandled rejection.
In `@src/platform/assets/services/assetService.test.ts`:
- Around line 439-783: The getAssetModels test suite lacks coverage for a failed
model walk and recovery. Add a test near the existing concurrent/invalidation
cases that makes fetchApiMock reject, asserts getAssetModels rejects, then
verifies a subsequent successful read triggers a new walk and returns the
recovered models, confirming the failed walk does not cache an empty result and
clears pendingModelBuckets.
In `@src/platform/assets/services/assetService.ts`:
- Around line 480-506: Update loadModelBuckets to attach a no-op rejection
handler to the shared pendingModelBuckets promise immediately after creating it,
mirroring the handling in startInputAssetsIncludingPublicRequest. Preserve
returning the original promise so callers still receive the buildModelBuckets
result or rejection.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: c65b867f-66f9-430a-845c-233d2642e9cd
📒 Files selected for processing (16)
src/components/dialog/GlobalDialog.test.tssrc/components/dialog/rekaPrimeVueBridge.tssrc/components/sidebar/tabs/ModelLibrarySidebarTab.test.tssrc/components/sidebar/tabs/ModelLibrarySidebarTab.vuesrc/components/sidebar/tabs/modelLibrary/ModelTreeLeaf.vuesrc/locales/en/main.jsonsrc/platform/assets/schemas/assetSchema.tssrc/platform/assets/services/assetService.test.tssrc/platform/assets/services/assetService.tssrc/platform/assets/utils/assetMetadataUtils.tssrc/platform/settings/constants/coreSettings.tssrc/schemas/apiSchema.tssrc/stores/modelStore.test.tssrc/stores/modelStore.tssrc/stores/workspace/sidebarTabStore.test.tssrc/stores/workspace/sidebarTabStore.ts
…search Addresses deep-pass perf findings on the assets-mode model-library sidebar (#13464): - modelStore: add a shared FIFO semaphore (6 in flight) that ComfyModelDef.load() awaits before viewMetadata, so expanding a large folder no longer fires one uncapped GET per mounted leaf. Per-model de-dupe is unchanged. - assetService.getAllAssetsByTag: add the MAX_PAGINATION_BATCHES backstop its sibling assetsStore.loadBatches already has, so an unbounded-unique-cursor backend cannot loop forever. - ModelLibrarySidebarTab: drive the full-model search scan off a debounced query ref (updated on the existing debounced @search path) instead of the raw v-model, so the scan no longer runs on every keystroke. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Summary
Backs the model library sidebar with the assets API: one walk of the
modelstag bucketed bymodel_type:tags,loader_pathas the widget value, and refresh triggering a backend rescan with live updates.This restores the models sidebar for non-cloud when assets mode is enabled (and makes enabling it a hidden setting on cloud). The intent is to deliver an almost unchanged UX when assets mode is enabled.
Changes
Comfy.ModelLibrary.UseAssetBrowser(hidden) routes the model-library tab to the asset browser (cloud default) or the sidebar tree (core default). Sidebar contents come from a single asset walk withloader_pathwidget values (null = orphan, dropped; bare-tag backends fall back to filename metadata like the asset browser). Refresh seeds a rescan and the sidebar live-updates onassets.seed.fast_complete; asset mode eager-loads on open and drops the load-all button; folders are display-filtered by their registeredextensions(empty allowlist = match-all, which takes an FE default list); search results stay live across reloads;viewMetadata/preview reads gated!isCloud.rekaPrimeVueBridgenow treats PrimeVue toasts as inside non-modal Reka dialogs, so focus landing on a toast close button mid-action (e.g. a confirm disabling itself) no longer dismisses the dialog underneath; two reload races closed (a scan-complete reload during an in-flight eager load no longer strands folders unloaded, and same-folder concurrent refreshes carry a per-folder generation so a stale response cannot overwrite a fresher commit).Review Focus
assetService(request-id guard vs in-flight walks; invalidation on refresh).supports_model_type_tagsdoubles as the loader_path-contract capability proxy.loader_pathemission (must precede cloud advertisingsupports_model_type_tags)Noted UX/behaviour changes
Comparing an identical
models/folder structure the following changes between non-assets and assets backed sidebar.assets.seed.fast_complete, emitted for the refresh button,rkey, or any other scan trigger) and re-loads the sidebar with whatever the scan discovered. Filtering supported.'.ckpt', '.pt', '.pt2', '.bin', '.pth', '.safetensors', '.pkl', '.sft'). All files in a registered model folder with these extension are displayed. The new assets-backed sidebar relies on the assets system (with some presentation logic on top to prevent UX regression - see 6) to determine what assets belong to a folder. Specifically: if a custom node registers a model foldermy-custom-modelswith extensions.xyzthe original sidebar would not show.xyzfiles, and would show.ptfiles undermy-custom-models's source folder e.g.models/my-custom-models/foo.pt. This is incorrect, since loaders loading models viamy-custom-modelskey would only allow loading.xyz. The assets-backed sidebar resolves this. Screenshot 2LLM) and the assets system deliberately tracks every file in them - including READMEs, configs, and entire git repositories that some custom nodes install into their model folder. Displaying that verbatim would clutter the sidebar, so the FE post-filters match-all folders (and all folders on older backends that don't report allowlists) with a frontend copy of the fixed allowlist from 5. This reproduces what the old sidebar displayed for these folders: nothing previously hidden starts showing (e.g. font files were not visible before and stay not visible) and nothing previously visible disappears. Known trade-off: the frontend copy can go stale if a custom node extendssupported_pt_extensionsat runtime - such files appeared in the old sidebar but won't here until the list is updated. Accepted, since this surface is expected to be short-lived.extra_model_paths.yaml): asset records carry no root identity, so every model reports path index 0. Preview reads target root 0 (wrong file or 404 for secondary-root files) and same-relative-path files in different roots collapse onto one sidebar row; metadata is only affected when relative paths collide (/view_metadatasearches roots in order without an index). Loader widget values are unaffected (the backend resolves category-relative paths across roots at execution). Accepted for this surface; lifting it needs the backend to carry root identity on assets (backend ticket to follow).An alternate approach to 5+6 would be to more closely match the old assets behaviour: prevent custom-node-registered extension sets from rendering at all. We could only show models that are both matching the registered folders and matching the fixed allowlist - this was deemed similar complexity for no benefit.
Screenshots
Screenshot 1: non-assets (unchanged by this PR) | assets mode (what this PR adds)

Screenshot 2

Video 1:
recording-20260707-070537.mp4